[dpdk-dev] [PATCH v4 3/3] bnx2x: update PMD version to 1.0.1.1

2016-05-03 Thread Rasesh Mody
Signed-off-by: Rasesh Mody Signed-off-by: Harish Patil --- drivers/net/bnx2x/bnx2x.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 149fdef..dcd21f8 100644 --- a/drivers/net/bnx2x/bnx2x.c +++

[dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get

2016-05-03 Thread Rasesh Mody
Enhance the stats_get() routine to display drop counters under imissed counter. Added extended stats get support to provide additional info. Encorporated review comment to rename some of the stats. Signed-off-by: Rasesh Mody Signed-off-by: Harish Patil --- doc/guides/nics/overview.rst |

[dpdk-dev] [PATCH v4 1/3] bnx2x: refactor Tx routine for single doorbell mechanism

2016-05-03 Thread Rasesh Mody
Change the Tx routine logic to ring the doorbell once per burst and not on every Tx packet. This driver-level optimization is necessary to achieve line rates for larger frame sizes (1k or more). Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Rasesh Mody Signed-off-by: Harish Patil

[dpdk-dev] [PATCH] app/test: fix +/-1 error in allocation

2016-05-03 Thread Jan Viktorin
A bug has been detected by valgrind: ==14406== Invalid write of size 1 ==14406==by 0x86ECC76: sprintf (in /usr/lib/libc-2.23.so) ==14406==by 0x430B0A: commands_init (in /home/jviki/Projects/dpdk/dpdk-soc/build/app/test) ==14406==by 0x42F215: main (in

[dpdk-dev] [PATCH v2] app/testpmd: add packet data pointer prefetch in the forwarding loop

2016-05-03 Thread Jerin Jacob
prefetch the next packet data address in advance in forwarding loop for performance improvement. Signed-off-by: Jerin Jacob --- V2: Extend the packet data prefetch logic to other similar forwarding modes like macfwd, macfwd-retry, csumonly, icmpecho as suggested by Pablo

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

2016-05-03 Thread Jerin Jacob
On Mon, May 02, 2016 at 05:48:02PM +, De Lara Guarch, Pablo wrote: > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Monday, May 02, 2016 1:00 PM > > To: dev at dpdk.org > > Cc: De Lara Guarch, Pablo; Jerin Jacob > >

[dpdk-dev] [PATCH v2] ethdev: make struct rte_eth_dev cache aligned

2016-05-03 Thread Jerin Jacob
Elements of struct rte_eth_dev used in the fast path. Make struct rte_eth_dev cache aligned to avoid the cases where rte_eth_dev elements share the same cache line with other structures. Signed-off-by: Jerin Jacob --- v2: Remove __rte_cache_aligned from rte_eth_devices and keep it only at struct

[dpdk-dev] [PATCH] ethdev: make struct rte_eth_dev cache aligned

2016-05-03 Thread Jerin Jacob
On Tue, May 03, 2016 at 10:40:53AM +0100, Bruce Richardson wrote: > On Mon, May 02, 2016 at 01:37:45PM +0530, Jerin Jacob wrote: > > Elements of struct rte_eth_dev used in the fast path. > > Make struct rte_eth_dev cache aligned to avoid the cases where > > rte_eth_dev elements share the same

[dpdk-dev] [PATCH v2 1/4] ixgbe: rearrange vector PMD code for x86

2016-05-03 Thread Bruce Richardson
On Tue, Apr 26, 2016 at 09:50:40PM +0800, Jianbo Liu wrote: > move common code to new file "ixgbe_rxtx_vec_common.h", > and vPMD for x86 is implemented in ixgbe_rxtx_vec.c > > Signed-off-by: Jianbo Liu > Suggested-by: Bruce Richardson > --- > drivers/net/ixgbe/ixgbe_rxtx_vec.c| 256

[dpdk-dev] [PATCH v2] app/testpmd: add packet data pointer prefetch in the forwarding loop

2016-05-03 Thread Thomas Monjalon
2016-05-03 19:37, Jerin Jacob: > prefetch the next packet data address in advance in forwarding loop > for performance improvement. I would like to get some attention to other patches adding some prefetch: http://dpdk.org/dev/patchwork/project/dpdk/list/?q=prefetch

[dpdk-dev] [PATCH v2] mk: add rpath for applications

2016-05-03 Thread Ferruh Yigit
Add default library output folder to the library search folder. This is useful for development environment, in production environment DPDK libraries already should be in know locations. Patch removes requirement to set LD_LIBRARY_PATH variable when DPDK compiled as shared library.

[dpdk-dev] [PATCH] nfp: add flag for enabling device hotplug

2016-05-03 Thread Bruce Richardson
On Tue, Apr 26, 2016 at 02:10:25PM +0100, Alejandro Lucero wrote: > RTE_PCI_DRV_DETACHABLE is required for detaching a device > during execution. > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[dpdk-dev] [PATCH] nfp: fixing a bug when gather

2016-05-03 Thread Bruce Richardson
On Tue, Apr 26, 2016 at 02:06:36PM +0100, Alejandro Lucero wrote: > mbufs where not properly released when they are chained. > > Fixes: b812daadad0d ("nfp: add Rx and Tx") > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 21 ++--- > 1 file changed, 10

[dpdk-dev] [PATCH] examples: remove useless checking

2016-05-03 Thread Ferruh Yigit
On 4/29/2016 4:48 PM, Mauricio Vasquez B wrote: > The rte_eth_dev_count() function will never return a value greater > than RTE_MAX_ETHPORTS, so that checking is useless. > > Signed-off-by: Mauricio Vasquez B studenti.polito.it> Patch looks good to me. Only there is one missed in

[dpdk-dev] [PATCH] lpm: unchecked return value

2016-05-03 Thread Bruce Richardson
On Wed, Apr 27, 2016 at 02:52:34PM +0200, Slawomir Mrozowicz wrote: > Fix issue reported by Coverity. > > Coverity ID 13205: Unchecked return value > Unchecked return value > check_return: Calling rte_lpm6_add without checking return value > Fixes: 5c510e13a9cb ("lpm: add IPv6 support") > >

[dpdk-dev] [PATCH v2] ip_pipeline: configuration file parser cleanup

2016-05-03 Thread Jasvinder Singh
This patch updates the parsing routines related to packet queues (pktq_in/out fields in the PIPELINE section) and message queues (msgq_in/out fields of in the MSGQ Section) specified in ip_pipeline configuration file. In the updated routines, function "strtok_r()" is used for parsing the string

[dpdk-dev] [PATCH] mk: add rpath for applications

2016-05-03 Thread Ferruh Yigit
On 5/2/2016 5:10 PM, Thomas Monjalon wrote: > 2016-04-29 17:34, Ferruh Yigit: >> Add default library output folder to the library search folder. >> >> This is useful for development environment, in production environment >> DPDK libraries already should be in know locations. > > Yes it is useful

[dpdk-dev] [PATCH v2] nfp: avoiding concurrency when hardware reconfig

2016-05-03 Thread Bruce Richardson
On Tue, Apr 26, 2016 at 02:03:01PM +0100, Alejandro Lucero wrote: > Some apps calling some functions from different threads at the > same time could lead to reconfig problems. Reconfig mechanism is > based on a hardware queue where incrementing a counter signals the > firmware to do the reconfig.

[dpdk-dev] [PATCH 2/2] i40e: NSH packet type support

2016-05-03 Thread Jingjing Wu
NSH packet can be recognized by Intel X710/XL710 series. This patch enables the new packet type. Signed-off-by: Jingjing Wu --- app/test-pmd/rxonly.c | 3 +++ doc/guides/rel_notes/release_16_07.rst | 2 ++ drivers/net/i40e/i40e_rxtx.c | 27

[dpdk-dev] [PATCH 1/2] mbuf: new NSH packet type

2016-05-03 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- lib/librte_mbuf/rte_mbuf.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 529debb..79edae3 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -274,6 +274,13 @@ extern

[dpdk-dev] [PATCH 0/2] NSH packet type support in i40e

2016-05-03 Thread Jingjing Wu
NSH packet can be recognized by Intel X710/XL710 series. This patch set enables it. Jingjing Wu (2): mbuf: new NSH packet type i40e: NSH packet type support app/test-pmd/rxonly.c | 3 +++ doc/guides/rel_notes/release_16_07.rst | 2 ++ drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change xstats to use integers

2016-05-03 Thread David Harton (dharton)
> -Original Message- > From: Remy Horton [mailto:remy.horton at intel.com] > Sent: Tuesday, May 03, 2016 8:23 AM > To: David Harton (dharton) ; dev at dpdk.org; Helin > Zhang > > Subject: Re: [dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change > xstats to use integers > > > On

[dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change xstats to use integers

2016-05-03 Thread Remy Horton
On 29/04/2016 14:43, David Harton (dharton) wrote: [..] >> +/* RX Priority Stats */ >> +for (stat = 0; stat < IXGBE_NB_RXQ_PRIO_STATS; stat++) { >> +for (i = 0; i < 8; i++) { > > 8 seems magical. Is there a constant somewhere that can be used? Not

[dpdk-dev] [PATCH] mk: cleanup leftover references to librte_malloc

2016-05-03 Thread Bruce Richardson
On Tue, Apr 26, 2016 at 03:16:01PM +0300, Panu Matilainen wrote: > librte_malloc was long since merged into librte_eal, mop up the > leftovers from rarer drivers. > > Fixes: 2f9d47013e4d ("mem: move librte_malloc to eal/common") > > Signed-off-by: Panu Matilainen > --- >

[dpdk-dev] [PATCH] nfp: avoiding concurrency when hardware reconfig

2016-05-03 Thread Bruce Richardson
On Tue, May 03, 2016 at 12:14:26PM +0100, Alejandro Lucero wrote: > Hi Bruce, > > Sorry about this. I sent a v2 for this patch but not in the same thread: > > http://www.dpdk.org/ml/archives/dev/2016-April/037996.html > Ok, I see it in patchwork now, thanks. When sending a v2, please keep the

[dpdk-dev] [PATCH] nfp: avoiding concurrency when hardware reconfig

2016-05-03 Thread Alejandro Lucero
Hi Bruce, Sorry about this. I sent a v2 for this patch but not in the same thread: http://www.dpdk.org/ml/archives/dev/2016-April/037996.html On Tue, May 3, 2016 at 12:01 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Apr 26, 2016 at 01:14:15PM +0100, Alejandro Lucero

[dpdk-dev] [PATCH] nfp: avoiding concurrency when hardware reconfig

2016-05-03 Thread Bruce Richardson
On Tue, Apr 26, 2016 at 01:14:15PM +0100, Alejandro Lucero wrote: > Some apps calling some functions from different threads at the > same time could lead to reconfig problems. Reconfig mechanism is > based on a hardware queue where incrementing a counter signals the > firmware to do the reconfig.

[dpdk-dev] [PATCH v3] i40evf: Report error if HW CRC strip is disabled for non-DPDK PF hosts

2016-05-03 Thread Bruce Richardson
On Fri, Apr 29, 2016 at 01:42:33PM +, Zhang, Helin wrote: > > > > -Original Message- > > From: Topel, Bjorn > > Sent: Friday, April 22, 2016 1:39 PM > > To: dev at dpdk.org > > Cc: Zhang, Helin; Wu, Jingjing; Topel, Bjorn > > Subject: [PATCH v3] i40evf: Report error if HW CRC strip

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

2016-05-03 Thread Ivan Boule
On 05/03/2016 11:45 AM, Bruce Richardson wrote: > On Mon, May 02, 2016 at 05:29:37PM +0530, Jerin Jacob wrote: >> prefetch the next packet data address in advance in macswap loop >> for performance improvement. >> >> ... >> for (i = 0; i < nb_rx; i++) { >> +if (likely(i < nb_rx -

[dpdk-dev] [PATCH v2] i40e: dereference before null check

2016-05-03 Thread Bruce Richardson
On Wed, Apr 27, 2016 at 06:34:03AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Mrzyglod, DanielX T > > Sent: Tuesday, April 19, 2016 1:13 AM > > To: Chen, Jing D; Wu, Jingjing; Zhang, Helin > > Cc: dev at dpdk.org; Mrzyglod, DanielX T > > Subject: [PATCH v2] i40e:

[dpdk-dev] 16.11 Roadmap

2016-05-03 Thread O'Driscoll, Tim
We were a little late doing this for 16.07, so we're going to try and communicate our roadmap for future releases earlier. Our aim is to do this 6 months before a release. Some things will obviously change during planning/development, so we'll provide an update 4 months before the release.

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

2016-05-03 Thread Bruce Richardson
On Tue, May 03, 2016 at 11:50:31AM +0200, Ivan Boule wrote: > On 05/03/2016 11:45 AM, Bruce Richardson wrote: > >On Mon, May 02, 2016 at 05:29:37PM +0530, Jerin Jacob wrote: > >>prefetch the next packet data address in advance in macswap loop > >>for performance improvement. > >> > >>... > >>

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

2016-05-03 Thread Bruce Richardson
On Tue, May 03, 2016 at 10:48:34AM +0100, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Tuesday, May 03, 2016 10:45 AM > > To: Jerin Jacob > > Cc: dev at dpdk.org; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

2016-05-03 Thread Bruce Richardson
On Mon, May 02, 2016 at 05:29:37PM +0530, Jerin Jacob wrote: > prefetch the next packet data address in advance in macswap loop > for performance improvement. > > Signed-off-by: Jerin Jacob > --- > app/test-pmd/macswap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[dpdk-dev] [PATCH] ip_pipeline: configuration file parser cleanup

2016-05-03 Thread Bruce Richardson
On Mon, May 02, 2016 at 12:53:55PM +0100, Jasvinder Singh wrote: > This patch updates the parsing routines of packet queues (pktq_in/out > fields in the PIPELINE section) and message queues (msgq_in/out fields > of in the MSGQ Section) specified in ip_pipeline configuration file. > >

[dpdk-dev] [PATCH] ethdev: make struct rte_eth_dev cache aligned

2016-05-03 Thread Bruce Richardson
On Mon, May 02, 2016 at 01:37:45PM +0530, Jerin Jacob wrote: > Elements of struct rte_eth_dev used in the fast path. > Make struct rte_eth_dev cache aligned to avoid the cases where > rte_eth_dev elements share the same cache line with other structures. > > Signed-off-by: Jerin Jacob > --- >

[dpdk-dev] [PATCH v2] virtio: fix modify drv_flags for specific device

2016-05-03 Thread David Marchand
Hello Tan, On Thu, Apr 28, 2016 at 8:08 PM, Jianfeng Tan wrote: > Issue: virtio's drv_flags are decided by devices types (modern vs legacy), > and which kernel driver is used, and the negotiated features (especially > VIRTIO_NET_STATUS) with backend, which makes it possible to multiple > virtio

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

2016-05-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, May 03, 2016 10:45 AM > To: Jerin Jacob > Cc: dev at dpdk.org; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in > macswap loop > > On Mon, May 02, 2016 at 05:29:37PM +0530,

[dpdk-dev] [PATCH v3 0/3] xen: netfront poll mode driver

2016-05-03 Thread Xie, Huawei
On 4/20/2016 10:19 PM, Bruce Richardson wrote: > On Tue, Mar 22, 2016 at 10:55:26AM +0100, Jan Blunck wrote: >> v3 changes: >> - removed fake PCI interface >> - removed struct virt_eth_driver >> - check for UIO name and version >> - added basic documentation >> >> Jan Blunck (3): >> xen: Add UIO

[dpdk-dev] [RFC PATCH 0/4]: Implement module information export

2016-05-03 Thread Neil Horman
On Tue, Apr 26, 2016 at 01:39:47PM -0400, Neil Horman wrote: > Hey- > So a few days ago we were reviewing Davids patch series to introduce the > abiilty to dump hardware support from pmd DSO's in a human readable format. > That effort encountered some problems, most notably the fact that