[dpdk-dev] [vpp-dev] VLAN packets dropped... ?

2016-05-26 Thread John Daley (johndale)
John, As just discussed, what you suggest was considered but there are other apps depending a different behavior of the flag, so we thought the best thing to do is deprecate it. That is part of what Olivier's patch discussed in http://www.dpdk.org/ml/archives/dev/2016-May/038786.html does.

[dpdk-dev] [dpdk-announce] download fastly

2016-05-26 Thread Thomas Monjalon
Hi, Thanks to the support of Fastly.com, we now have a CDN to host our files. https://www.fastly.com/open-source The CDN name is fast.dpdk.org. Go to the new "Releases page" http://dpdk.org/rel and download a tarball at light speed! The locations of the cache servers can be found on

[dpdk-dev] [PATCH v3] e1000: fix build with clang

2016-05-26 Thread Hiroyuki Mikita
GCC_VERSION is empty in case of clang: /bin/sh: line 0: test: -ge: unary operator expected It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/ Fixes: 366113dbfb69 ("e1000: suppress misleading indentation warning") Signed-off-by: Hiroyuki Mikita --- v3: * use

[dpdk-dev] [PATCH 2/2] bond mode 4: tests for external state machine

2016-05-26 Thread Eric Kinzie
From: Eric Kinzie This adds test cases for exercising the external state machine API to the mode 4 autotest. Signed-off-by: Eric Kinzie --- app/test/test_link_bonding_mode4.c | 210 ++-- 1 file changed, 201 insertions(+), 9

[dpdk-dev] [PATCH 1/2] bond mode 4: allow external state machine

2016-05-26 Thread Eric Kinzie
From: Eric Kinzie Provide functions to allow an external 802.3ad state machine to transmit and recieve LACPDUs and to set the collection/distribution flags on slave interfaces. Signed-off-by: Eric Kinzie --- drivers/net/bonding/rte_eth_bond_8023ad.c | 318

[dpdk-dev] [PATCH 0/2] bond mode 4 external sm api

2016-05-26 Thread Eric Kinzie
This patchset introduces the ability to use an external 802.3ad state machine for mode 4 bonding. Functions to alter the mux state and to allow LACPDUs to be sent and received from outside of the bonding PMD are provided. Eric Kinzie (2): bond mode 4: allow external state machine bond mode

[dpdk-dev] [PATCH] drivers/net/pcap: fix segfault in pcap pmd

2016-05-26 Thread Ferruh Yigit
On 5/26/2016 2:35 PM, Reshma Pattan wrote: > Testpmd application will crash in fclose() upon quit after running > the below command. > > "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 --vdev > 'eth_pcap0,tx_iface=enp1s0f1,rx_pcap=/tmp/test.pcap' -- >

[dpdk-dev] [vpp-dev] VLAN packets dropped... ?

2016-05-26 Thread John Lo (loj)
Hi Konstantin, Thanks for the link to DPDK discussion wrt this VLAN offload flag PKT_RX_VLAN_PKT. It seems the proposal was to deprecate PKT_RX_VLAN_PKT and introduce two new flags PKT_RX_VLAN_STRIPPED and PKT_RX_QINQ_STRIPPED. It would be a really good idea to keep PKT_RX_VLAN_PKT to

[dpdk-dev] [REQUEST] New repository request for project SPP

2016-05-26 Thread Ferruh Yigit
Hi Thomas, SPP: Soft Patch Panel, a new project on top of DPDK library. Code is close to its first release, and we would like to open source the project and host it under dpdk.org. Can you please create a new repository under dpdk.org named "spp", and add me as the maintainer of the repo?

[dpdk-dev] [PATCH v2 6/6] bonding: remove memcpy from burst functions

2016-05-26 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_pmd.c | 71 ++ 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 474bfcc..d952658 100644 ---

[dpdk-dev] [PATCH v2 5/6] bonding: add spinlock to link update function

2016-05-26 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 55b37a5..474bfcc 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++

[dpdk-dev] [PATCH v2 4/6] bonding: add spinlock to stop function

2016-05-26 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 93043ef..55b37a5 100644 ---

[dpdk-dev] [PATCH v2 3/6] bonding: take queue spinlock in rx/tx burst functions

2016-05-26 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_pmd.c | 116 - 1 file changed, 84 insertions(+), 32 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 2e624bb..93043ef 100644 ---

[dpdk-dev] [PATCH v2 2/6] bonding: grab queue spinlocks in slave add and remove

2016-05-26 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_api.c | 52 -- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 53df9fe..006c901 100644 ---

[dpdk-dev] [PATCH v2 1/6] bonding: add spinlock to rx and tx queues

2016-05-26 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 drivers/net/bonding/rte_eth_bond_private.h | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index

[dpdk-dev] [PATCH v2 0/6] bonding: locks

2016-05-26 Thread Bernard Iremonger
Add spinlock to bonding rx and tx queues. Take spinlock in rx and tx burst functions. Take all spinlocks in slave add and remove functions. With spinlocks in place remove memcpy of slaves. Changes in v2: Replace patch 1. Add patch 2 and reorder patches. Add spinlock to bonding rx and tx queues.

[dpdk-dev] [PATCH] fix build issues in the cross-compiling mode

2016-05-26 Thread Jerin Jacob
Removed comparison against $CC in Makefiles as in cross-compiling mode CC can be a different string instead of string "gcc" Suggested-by: Thomas Monjalon Signed-off-by: Jerin Jacob --- app/test/Makefile| 2 +- drivers/net/cxgbe/Makefile | 6 -- drivers/net/e1000/Makefile |

[dpdk-dev] [PATCH 1/5] bonding: replace spinlock with read/write lock

2016-05-26 Thread Iremonger, Bernard
Hi Konstantin, > > > > On 05/05/16 18:12, Stephen Hemminger wrote: > > > > > On Thu, 5 May 2016 16:14:56 +0100 Bernard Iremonger > > > > > wrote: > > > > > > > > > >> Fixes: a45b288ef21a ("bond: support link status polling") > > > > >> Signed-off-by: Bernard Iremonger > > > > > > > > > > You

[dpdk-dev] [PATCH v2 40/40] bnxt: cleanup null pointer checks

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:29PM -0700, Stephen Hurd wrote: > Prefer !ptr to ptr == NULL > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde Nak to this particular patch, as it contradicts DPDK coding guidelines which is to make NULL checks explicit. Ref [1] /Bruce [1]

[dpdk-dev] [PATCH v2 6/6] vhost: add pmd client and reconnect option

2016-05-26 Thread Yuanhan Liu
On Wed, May 25, 2016 at 10:45:10AM -0700, Rich Lane wrote: > @@ -817,6 +821,9 @@ rte_pmd_vhost_devinit(const char *name, const char > *params) > ? ? ? ? int ret = 0; > ? ? ? ? char *iface_name; > ? ? ? ? uint16_t queues; > +? ? ? ?uint64_t flags = 0; > +? ? ? ?int

[dpdk-dev] [PATCH v2] vhost: add support for dynamic vhost PMD creation

2016-05-26 Thread Yuanhan Liu
On Wed, May 25, 2016 at 01:54:41PM +0200, Thomas Monjalon wrote: > > OTOH, let's assume there is a switch that supports quite many such > > vdevs, as well as the ability to add a new device dynamically by > > corresponding API. And assume there is just one external interface > > from the switch to

[dpdk-dev] [PATCH] af_packet: add byte counters

2016-05-26 Thread Ferruh Yigit
On 5/25/2016 10:03 PM, Rich Lane wrote: > Signed-off-by: Rich Lane Reviewed-by: Ferruh Yigit While testing this, independent from patch applied or not , I am getting following assertion after random time: testpmd> PANIC in rte_mbuf_raw_alloc(): line assert "rte_mbuf_refcnt_read(m)

[dpdk-dev] [PATCH] ethdev: change comments of VLAN type

2016-05-26 Thread Beilei Xing
If the packet carries a single VLAN header, it is treated as the outer header. So change the comments of inner VLAN and outer VLAN. Signed-off-by: Beilei Xing --- doc/guides/rel_notes/release_16_07.rst | 3 +++ lib/librte_ether/rte_ethdev.h | 4 ++-- 2 files changed, 5 insertions(+), 2

[dpdk-dev] [PATCH v2] test: fix mempool perf test enq_count wraparound of 32-bit uint

2016-05-26 Thread David Hunt
recent CPU's can easily wrap around a 32-bit unsigned int in the mempool perf test. Increase to a 64-bit uint. v2: change from %lu to %"PRIu64" Signed-off-by: David Hunt --- app/test/test_mempool_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[dpdk-dev] [PATCH] test: fix mempool perf test enq_count wraparound of 32-bit uint

2016-05-26 Thread Bruce Richardson
On Thu, May 26, 2016 at 01:51:08PM +0100, David Hunt wrote: > recent CPU's can easily wrap around a 32-bit unsigned int in > the mempool perf test. Increase to a 64-bit uint. > > Signed-off-by: David Hunt > --- > app/test/test_mempool_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

[dpdk-dev] [PATCH v3 31/40] bnxt: add start/stop/link update operations

2016-05-26 Thread Bruce Richardson
On Wed, May 18, 2016 at 01:29:41PM -0700, Stephen Hurd wrote: > BNXT driver will now minimally pass traffic with testpmd. > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 267 > + > 1 file

[dpdk-dev] [PATCH v2 30/40] bnxt: add HWRM port phy qcfg call and wrapper

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:19PM -0700, Stephen Hurd wrote: > Add HWRM port pgy qcfg HWRM command and bnxt_get_hwrm_link_config() > wrapper which parses the link state. > For commit messages, there is no need to abbreviate words, since we are not limited in the number of characters that can be

[dpdk-dev] [PATCH] drivers/net/pcap: fix segfault in pcap pmd

2016-05-26 Thread Reshma Pattan
Testpmd application will crash in fclose() upon quit after running the below command. "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 --vdev 'eth_pcap0,tx_iface=enp1s0f1,rx_pcap=/tmp/test.pcap' -- --port-topology=chained -i" The reason is, pcap vdev creation with tx

[dpdk-dev] [PATCH] drivers/net/pcap: fix segfault in pcap pmd

2016-05-26 Thread Reshma Pattan
Testpmd application will crash in fclose() upon quit after running the below command. "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 --vdev 'eth_pcap0,tx_iface=enp1s0f1,rx_pcap=/tmp/test.pcap' -- --port-topology=chained -i" The reason is, pcap vdev creation with tx

[dpdk-dev] [PATCH v2 29/40] bnxt: work around HWRM error when creating rings

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:18PM -0700, Stephen Hurd wrote: > Some HWRM versions will stop responding if we request poll mode interrupt. > As a workaround, request an MSI interrupt even though we never enable it. > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- >

[dpdk-dev] [PATCH v2 28/40] bnxt: add ring allocation and group init

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:17PM -0700, Stephen Hurd wrote: > Add a function to initialize ring groups, and a function to > allocate the rings via HWRM. > How does this patch relate to patches 24 and 25, whose titles indicate they already provide this functionality? [Perhaps some of these

[dpdk-dev] [PATCH v2 24/40] bnxt: add HWRM ring alloc/free functions

2016-05-26 Thread Bruce Richardson
On Thu, May 26, 2016 at 01:45:55PM +0100, Bruce Richardson wrote: > On Fri, May 13, 2016 at 03:46:13PM -0700, Stephen Hurd wrote: > > Add HWRM calls to allocate and free TX/RX/CMPL rings along with > > the associated structs and definitions. > > > What are these RX/TX/CMPL rings used for? I

[dpdk-dev] [PATCH v2 26/40] bnxt: add HWRM stat context free function

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:15PM -0700, Stephen Hurd wrote: > Add function and associated structures and definitions as well as > some convenienct functions for manipulating the state of the entire > function. > Again, I think more explanation is needed in the commit message. The commit title

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-26 Thread Ferruh Yigit
On 5/24/2016 11:11 AM, Christian Ehrhardt wrote: > Hi Panu, > I already agreed to Thomas on IRC but won't have time until next week. > Thanks for making a patch that does that already - I'll give it a look and > some test on my end next week then. > > > > Christian Ehrhardt > Software Engineer,

[dpdk-dev] [PATCH] test: fix mempool perf test enq_count wraparound of 32-bit uint

2016-05-26 Thread David Hunt
recent CPU's can easily wrap around a 32-bit unsigned int in the mempool perf test. Increase to a 64-bit uint. Signed-off-by: David Hunt --- app/test/test_mempool_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_mempool_perf.c

[dpdk-dev] [PATCH v2 24/40] bnxt: add HWRM ring alloc/free functions

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:13PM -0700, Stephen Hurd wrote: > Add HWRM calls to allocate and free TX/RX/CMPL rings along with > the associated structs and definitions. > What are these RX/TX/CMPL rings used for? I assume they are different from the RX/TX rings used to send/receive packets, or

[dpdk-dev] [PATCH v2] mempool: replace c memcpy code semantics with optimized rte_memcpy

2016-05-26 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- v1..v2 Corrected the the git commit message(s/mbuf/mempool/g) --- lib/librte_mempool/rte_mempool.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index 60339bd..24876a2

[dpdk-dev] [PATCH] drivers/net/pcap: fix segfault in pcap pmd

2016-05-26 Thread Pattan, Reshma
Self-Nacking.. wrong patch > -Original Message- > From: Pattan, Reshma > Sent: Thursday, May 26, 2016 2:30 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [PATCH] drivers/net/pcap: fix segfault in pcap pmd > > Testpmd application will crash in fclose() upon quit after running

[dpdk-dev] [PATCH v2 23/40] bnxt: add HWRM stats context allocation

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:12PM -0700, Stephen Hurd wrote: > Add HWRM code to allocate a statistics context and a helper function > to allocate one for evert completion ring. > typo: every How does this patch related to patch 12, which also concerns stats? /Bruce

[dpdk-dev] [PATCH] fix build issues in the cross-compiling mode

2016-05-26 Thread Bruce Richardson
On Thu, May 26, 2016 at 04:50:14PM +0530, Jerin Jacob wrote: > Removed comparison against $CC in Makefiles as > in cross-compiling mode CC can be a different string > instead of string "gcc" > > Suggested-by: Thomas Monjalon > Signed-off-by: Jerin Jacob This fixes compiler errors I see when

[dpdk-dev] [PATCHv5 6/6] remove rte.hostapp.mk

2016-05-26 Thread Neil Horman
During the review of this patchset it was discovered that rte.hostapp.mk was going unused. All its users had been previously removed, and so this file too can go. It and rte.buildtools.mk are effectively duplicates, but given that pmdinfogen is a tool used to create the dpdk build, I think the

[dpdk-dev] [PATCHv5 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-26 Thread Neil Horman
This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary, and, if found parses the remainder of the string as a json encoded string, outputting the results in either a human readable or raw, script parseable format Note that, in the case of dynamically linked applications,

[dpdk-dev] [PATCHv5 4/6] Makefile: Do post processing on objects that register a driver

2016-05-26 Thread Neil Horman
Modify the compilation makefile to identify C files that export PMD information, and use that to trigger execution of the pmdinfo binary. If the execution of pmdinfo is successful, compile the output C file to an object, and use the linker to do relocatable linking on the resultant object file

[dpdk-dev] [PATCHv5 3/6] eal: Add an export symbol to expose the autoload path to external tools

2016-05-26 Thread Neil Horman
Export a symbol containing the string: DPDK_PLUGIN_PATH="$(CONFIG_RTE_EAL_PMD_PATH)" Where the latter half of the string is set at build time to a location from which autoloaded DSO's will be found. This string is used by pmdinfo in 'plugin' mode, whereby a user can specify a dpdk installation

[dpdk-dev] [PATCHv5 1/6] pmdinfogen: Add buildtools and pmdinfogen utility

2016-05-26 Thread Neil Horman
pmdinfogen is a tool used to parse object files and build json strings for use in later determining hardware support in a dso or application binary. pmdinfo looks for the non-exported symbol names this_pmd_name and this_pmd_tbl (where n is a integer counter). It records the name of each of

[dpdk-dev] [PATCHv5 0/6] Implement pmd hardware support exports

2016-05-26 Thread Neil Horman
Hey all- So heres attempt number 2 at a method for exporting PMD hardware support information. As we discussed previously, the consensus seems to be that pmd information should be: 1) Able to be interrogated on any ELF binary (application binary or individual DSO) 2) Equally functional

[dpdk-dev] [PATCH v2 21/40] bnxt: add HWRM vnic RSS config function

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:10PM -0700, Stephen Hurd wrote: > Used to enable RSS configuration > A bit more detail in the commit message would be helpful. Should include details linking this to the contexts added in the previous commit, where RSS is also mentioned. /Bruce

[dpdk-dev] [PATCH v2 20/40] bnxt: add vnic RSS cos lb cTx alloc/free functions

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:09PM -0700, Stephen Hurd wrote: > More HWRM calls. > The title should be shortened to something like "add vnic ctx functions" and the commit message should then explain what the contexts are for, and how things like RSS apply. /Bruce

[dpdk-dev] [PATCH v2 19/40] bnxt: add HWRM vnic cfg function

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:08PM -0700, Stephen Hurd wrote: > Configurs a vnic allocaed by vnic_alloc function. > Couple of typos.

[dpdk-dev] [PATCH v2 15/40] bnxt: alloc/free ring information

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:04PM -0700, Stephen Hurd wrote: > Perform allocation and free()ing of ring information structures for > TX, RX, and completion rings. > A bit more detail would be useful here. What are the information structures and how are they used? We've already had two previous

[dpdk-dev] [PATCH v2 14/40] bnxt: initial Rx ring code

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:03PM -0700, Stephen Hurd wrote: > Initial implementation of rx_pkt_burst > Add code to allocate rings to bnxt_ring.c > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/Makefile | 1 + >

[dpdk-dev] [PATCH v2] qede: fix build issue in the cross-compiling mode

2016-05-26 Thread Jerin Jacob
In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc instead of just gcc Suggested-by: Ferruh Yigit Signed-off-by: Jerin Jacob --- v1..v2 Use CONFIG_RTE_TOOLCHAIN_GCC instead of regular expression in filter --- drivers/net/qede/Makefile | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH v2 13/40] bnxt: initial Tx ring code

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:02PM -0700, Stephen Hurd wrote: > Initial implementation of rx_pkt_burst typo: s/rx/tx/ > Add code to allocate rings to bnxt_ring.c > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/Makefile | 1 + >

[dpdk-dev] [PATCH] af_packet: add byte counters

2016-05-26 Thread John W. Linville
On Thu, May 26, 2016 at 03:47:59PM +0100, Ferruh Yigit wrote: > On 5/25/2016 10:03 PM, Rich Lane wrote: > > Signed-off-by: Rich Lane > > Reviewed-by: Ferruh Yigit Acked-by: John W. Linville -- John W. LinvilleSomeday the world will need a hero, and you linville at

[dpdk-dev] [PATCH v2 12/40] bnxt: statistics operations

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:46:01PM -0700, Stephen Hurd wrote: > Add get and clear staitstics operations and the asociated HWRM calls. > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/Makefile | 1 + > drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH v2 08/40] bnxt: add completion ring support

2016-05-26 Thread Bruce Richardson
On Fri, May 13, 2016 at 03:45:57PM -0700, Stephen Hurd wrote: > Structures, macros, and functions for working with completion rings > in the driver. > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/Makefile | 1 + >

[dpdk-dev] [PATCH v4 0/9] add packet capture framework

2016-05-26 Thread Thomas Monjalon
HELP is needed to review this patchset, please, especially patches 5 and 6. Thanks 2016-05-23 22:38, Reshma Pattan: > This patchset include below changes > > 1)Changes to librte_ether. > 2)New library librte_pdump added for packet capture framework. > 3)New app/pdump tool added for packet

[dpdk-dev] [PATCH v2 01/40] bnxt: new driver for Broadcom NetXtreme-C devices

2016-05-26 Thread Bruce Richardson
On Wed, May 25, 2016 at 01:59:00PM -0700, Stephen Hurd wrote: > Bruce, is it better at this point to modify the existing patch that adds > bnxt.rst or to create a follow-on patch? > It's better to modify existing patch to add it. However, hold off on doing new versions of the patchset until

[dpdk-dev] [PATCH v2 00/19] vhost ABI/API refactoring

2016-05-26 Thread Rich Lane
On Thu, May 12, 2016 at 10:24 PM, Yuanhan Liu wrote: > v2: - exported ifname as well to fix a vhost-pmd issue reported > by Rich > - separated the big patch that introduces several new APIs > into some small patches. > - updated release note > - updated version.map >

[dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code

2016-05-26 Thread Bruce Richardson
On Wed, May 25, 2016 at 04:35:27PM -0700, Stephen Hurd wrote: > On Wed, May 25, 2016 at 8:05 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > > > Checkpatch also highlights a few minor issues that might be worth > > addressing. > > > > CHECK:SPACING: spaces preferred around

[dpdk-dev] [PATCH] af_packet: add byte counters

2016-05-26 Thread Rich Lane
On Thu, May 26, 2016 at 7:47 AM, Ferruh Yigit wrote: > On 5/25/2016 10:03 PM, Rich Lane wrote: > > Signed-off-by: Rich Lane > > Reviewed-by: Ferruh Yigit > > > While testing this, independent from patch applied or not , I am getting > following assertion after random time: > > testpmd> PANIC

[dpdk-dev] [PATCH v3 2/4] ixgbe: implement vector PMD for arm architecture

2016-05-26 Thread Jianbo Liu
On 25 May 2016 at 20:29, Jerin Jacob wrote: > On Fri, May 06, 2016 at 11:55:46AM +0530, Jianbo Liu wrote: >> use ARM NEON intrinsic to implement ixgbe vPMD >> >> Signed-off-by: Jianbo Liu >> --- >> drivers/net/ixgbe/Makefile | 4 + >> drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 561

[dpdk-dev] [PATCH] eal: fix rte_memcpy perf in hsw/bdw

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Xu, Qian Q > Sent: Thursday, May 26, 2016 1:19 PM > To: Wang, Zhihong ; dev at dpdk.org > Cc: Wang, Zhihong > Subject: RE: [dpdk-dev] [PATCH] eal: fix rte_memcpy perf in hsw/bdw > > Tested-by: Qian Xu > > - Test Commit:

[dpdk-dev] [PATCH 2/6] testpmd: configurable tx_first burst number

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, May 26, 2016 2:32 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 2/6] testpmd: configurable

[dpdk-dev] [PATCH] i40e: fix unchecked return value

2016-05-26 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 25, 2016 11:43 AM > To: dev at dpdk.org; Mrzyglod, DanielX T > Cc: Zhang, Helin ; Wu, Jingjing > ; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH] i40e: fix unchecked return value >

[dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, May 26, 2016 2:27 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 1/6] testpmd: add io_retry

[dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > Sent: Tuesday, March 8, 2016 7:01 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions > > v1: > This patch adds test cases for rte_memcmp

[dpdk-dev] [PATCH v1 1/2] rte_memcmp functions using Intel AVX and SSE intrinsics

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > Sent: Tuesday, March 8, 2016 7:01 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/2] rte_memcmp functions using Intel AVX and > SSE intrinsics > > v1: > This patch adds memcmp

[dpdk-dev] [PATCH 1/2] mbuf: new NSH packet type

2016-05-26 Thread Pei, Yulong
Test-by: Yulong.pei at intel.com ether+nsh ether+nsh+ip ether+nsh+ip+icmp ether+nsh+ip_frag ether+nsh+ip+tcp ether+nsh+ip+udp ether+nsh+ip+sctp ether+nsh+ipv6 ether+nsh+ipv6+icmp ether+nsh+ipv6_frag ether+nsh+ipv6+tcp ether+nsh+ipv6+udp ether+nsh+ipv6+sctp Above combos can be recognized

[dpdk-dev] [PATCH v2] qede: fix build issue in the cross-compiling mode

2016-05-26 Thread Thomas Monjalon
2016-05-26 11:42, Jerin Jacob: > In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc > instead of just gcc > > Suggested-by: Ferruh Yigit > Signed-off-by: Jerin Jacob We should do the same change for clang and icc. Please check git grep '(CC)'

[dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding

2016-05-26 Thread Thomas Monjalon
2016-05-26 02:40, Wang, Zhihong: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-05-05 18:46, Zhihong Wang: > > > --- a/app/test-pmd/testpmd.h > > > +++ b/app/test-pmd/testpmd.h > > > extern struct fwd_engine io_fwd_engine; > > > +extern struct fwd_engine

[dpdk-dev] flow director on X550

2016-05-26 Thread Lu, Wenzhuo
Hi Nishant, From: Nishant Verma [mailto:vnis...@gmail.com] Sent: Thursday, May 26, 2016 11:40 AM To: Lu, Wenzhuo Cc: dev at dpdk.org Subject: Re: [dpdk-dev] flow director on X550 Hi Wenzhuo, Thanks for the reply. ?As par datasheet, if flow director filter matches then RSS won't impact as RSS

[dpdk-dev] [PATCH] eal: fix rte_memcpy perf in hsw/bdw

2016-05-26 Thread Xu, Qian Q
Tested-by: Qian Xu - Test Commit: 8f6f24342281f59de0df7bd976a32f714d39b9a9 - OS/Kernel: Fedora 21/4.1.13 - GCC: gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) - CPU: Intel(R) Xeon(R) CPU E5-2695 v4 @ 2.10 - Total 1 cases, 1 passed, 0 failed. 1. The test scenario is Vhost-Virtio loopback without

[dpdk-dev] [PATCH 5/6] testpmd: show topology at forwarding start

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 25, 2016 5:45 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 5/6] testpmd: show topology at

[dpdk-dev] [PATCH 4/6] testpmd: handle all rxqs in rss setup

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 25, 2016 5:42 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 4/6] testpmd: handle all rxqs

[dpdk-dev] [PATCH 6/6] testpmd: update documentation

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 25, 2016 5:48 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 6/6] testpmd: update

[dpdk-dev] [PATCH 2/6] testpmd: configurable tx_first burst number

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 25, 2016 5:35 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 2/6] testpmd: configurable

[dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding

2016-05-26 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 25, 2016 5:32 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 1/6] testpmd: add io_retry

[dpdk-dev] [PATCH v2] e1000: fix build with clang

2016-05-26 Thread Hiroyuki Mikita
Hi Thomas, > The output of git grep '(CC)' shows that there is some room for > cross-compilation fixes. > Any volunteer? > OK. I will send another patch after merging this. This is just a fix for clang build. Regards, Hiroyuki

[dpdk-dev] flow director on X550

2016-05-26 Thread Lu, Wenzhuo
Hi Nishant, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nishant Verma > Sent: Thursday, May 26, 2016 4:08 AM > To: dev at dpdk.org > Subject: [dpdk-dev] flow director on X550 > > Hi All, > > My system configuration is > ==>#. SuperMicro 1U >- BIOS:

[dpdk-dev] flow director on X550

2016-05-26 Thread Nishant Verma
Hi Wenzhuo, Thanks for the reply. ?As par datasheet, if flow director filter matches then RSS won't impact as RSS is the last filter to be applied on received packet. But just to confirm, i tried and still issue persist. Any other thing that you think i can try, please let me know. Thanks. On