[dpdk-dev] [PATCH v3 0/4] ixgbe: enable ixgbe vector PMD on ARM

2016-05-27 Thread Jianbo Liu
On 25 May 2016 at 00:12, Bruce Richardson wrote: > On Tue, May 24, 2016 at 05:10:01PM +0100, Bruce Richardson wrote: >> On Fri, May 06, 2016 at 11:55:44AM +0530, Jianbo Liu wrote: >> > Implement ixgbe vPMD on ARM with NEON intrinsic. >> > >> > v3: >> > - rebase to rel_16_07 branch on

[dpdk-dev] [PATCH] app/test: fix bond device name too long

2016-05-27 Thread Thomas Monjalon
2016-05-27 17:20, Michal Jastrzebski: > Bond device name was too long (grather than 32 signs) that > cause mempool allocation to fail. Maybe that this kind of failure would be avoided if the test was added to autotests (app/test/autotest_data.py). Generally speaking, it would be a good idea to

[dpdk-dev] [PATCH 2/2] mk: reduce scope of whole-archive to pmd libraries

2016-05-27 Thread Ferruh Yigit
--whole-archive argument only required for pmd libraries, and currently it covers more libraries. Reducing scope of the argument to pmd libraries slightly reduce final application size. Signed-off-by: Ferruh Yigit --- mk/rte.app.mk | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH 1/2] mk: prevent overlinking in applications

2016-05-27 Thread Ferruh Yigit
Replace --no-as-needed linker flag with --as-needed flag, which will only link libraries directly called by application. This requires inter library dependencies resolved correctly. Not linking all libraries cause a compile error for lpcap and possible to have other similar compiler errors, so

[dpdk-dev] [PATCH] bond: replace rte_panic with errno code return

2016-05-27 Thread Michal Jastrzebski
This patch modifies bond_mode_alb_enable function. When mempool allocation fails errno code is returned instead of rte_panic. This allow to decide on application level if it should quit or retry for mempool allocation. Signed-off-by: Michal Jastrzebski --- drivers/net/bonding/rte_eth_bond_alb.c

[dpdk-dev] [PATCH] app/test: fix bond device name too long

2016-05-27 Thread Michal Jastrzebski
Bond device name was too long (grather than 32 signs) that cause mempool allocation to fail. Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Michal Jastrzebski --- app/test/test_link_bonding.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-27 Thread Ferruh Yigit
On 5/27/2016 6:59 AM, Panu Matilainen wrote: > On 05/26/2016 04:13 PM, Ferruh Yigit wrote: >> On 5/24/2016 11:11 AM, Christian Ehrhardt wrote: >>> Hi Panu, >>> I already agreed to Thomas on IRC but won't have time until next week. >>> Thanks for making a patch that does that already - I'll give it

[dpdk-dev] [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy

2016-05-27 Thread Jerin Jacob
On Fri, May 27, 2016 at 11:24:57AM +0100, Hunt, David wrote: > > > On 5/24/2016 4:17 PM, Jerin Jacob wrote: > > On Tue, May 24, 2016 at 04:59:47PM +0200, Olivier Matz wrote: > > > > > Are you seeing some performance improvement by using rte_memcpy()? > > Yes, In some case, In default case, It

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-27 Thread Yuanhan Liu
On Tue, May 24, 2016 at 09:38:32PM +0800, Huawei Xie wrote: > vq->vq_ring_mem = mz->phys_addr; > vq->vq_ring_virt_mem = mz->addr; > - PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem: 0x%"PRIx64, > (uint64_t)mz->phys_addr); > - PMD_INIT_LOG(DEBUG, "vq->vq_ring_virt_mem: 0x%"PRIx64,

[dpdk-dev] [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy

2016-05-27 Thread Thomas Monjalon
2016-05-27 17:12, Jerin Jacob: > IMHO, I think we should have means to abstract this _logical_ changes > under conditional compilation flags and any arch/platform can choose > to select what it suites better for that arch/platform. > > We may NOT need to have frequent patches to select the

[dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes

2016-05-27 Thread Thomas Monjalon
2016-05-27 13:28, Panu Matilainen: > On 05/25/2016 09:36 AM, zr at semihalf.com wrote: > > @@ -1455,6 +1458,8 @@ struct eth_dev_ops { > > > > eth_get_reg_length_t get_reg_length; > > /**< Get # of registers */ > > + eth_get_reg_width_t get_reg_width; > > + /**< Get # of bytes in

[dpdk-dev] fast red autotest

2016-05-27 Thread Thomas Monjalon
2016-05-27 14:04, Kantecki, Tomasz: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Is it possible to split them in > > - short functional tests > > - long run / perf tests > > ? > > So we could keep some basic tests in fast_test. > > I expect that tests which are not

[dpdk-dev] [PATCH v2] mbuf: new flag when Vlan is stripped

2016-05-27 Thread Olivier Matz
The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in PMDs not advertising the same flags in similar conditions. Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED and PKT_RX_QINQ_STRIPPED that are better defined: PKT_RX_VLAN_STRIPPED: a vlan has been

[dpdk-dev] [PATCH] app/test: fix bond device name too long

2016-05-27 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Friday, May 27, 2016 4:21 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] app/test: fix bond device name too long > > Bond device name was too long (grather than 32 signs) that

[dpdk-dev] [PATCH] bond: replace rte_panic with errno code return

2016-05-27 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Friday, May 27, 2016 4:21 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] bond: replace rte_panic with errno code return > > This patch modifies bond_mode_alb_enable function.

[dpdk-dev] [PATCH] i40e: fix vlan filter in promiscuous mode

2016-05-27 Thread Jingjing Wu
Vlan filter didn't work if promiscuous mode is enabled. That is because i40e driver uses MAC VLAN table for the l2 filtering and internal switch. And the vlan table is disabled by default, till the first time to add rule in vlan table. This patch fixed this issue to enable vlan filter by using

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-27 Thread Jerin Jacob
On Fri, May 27, 2016 at 10:52:42AM +0100, Hunt, David wrote: > > > On 5/24/2016 4:35 PM, Jerin Jacob wrote: > > On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: > > > + /* > > > + * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to > > > + * set the correct index

[dpdk-dev] [REQUEST] New repository request for project SPP

2016-05-27 Thread Thomas Monjalon
2016-05-26 17:48, Ferruh Yigit: > SPP: Soft Patch Panel, a new project on top of DPDK library. > > > Code is close to its first release, and we would like to open source the > project and host it under dpdk.org. > > Can you please create a new repository under dpdk.org named "spp", > and add me

[dpdk-dev] [PATCH v2] doc: add pep8 as the python code style guidelines

2016-05-27 Thread John McNamara
Added PEP8 to the DPDK Coding Style guidelines to cover Python contributions to DPDK. Signed-off-by: John McNamara --- v2: fixed section level. doc/guides/contributing/coding_style.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/contributing/coding_style.rst

[dpdk-dev] [PATCHv5 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Neil Horman
On Fri, May 27, 2016 at 02:38:54PM +, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > > Sent: Thursday, May 26, 2016 6:17 PM > > To: dev at dpdk.org > > Cc: Neil Horman ; Richardson, Bruce > > ; Thomas Monjalon >

[dpdk-dev] [PATCH v1] doc: add pep8 as the python code style guidelines

2016-05-27 Thread John McNamara
Added PEP8 to the DPDK Coding Style guidelines to cover Python contributions to DPDK. Signed-off-by: John McNamara --- doc/guides/contributing/coding_style.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/contributing/coding_style.rst

[dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Panu Matilainen
On 05/27/2016 02:35 PM, Neil Horman wrote: > On Fri, May 27, 2016 at 12:16:03PM +0300, Panu Matilainen wrote: > >> Yup. But there's also a bit of a gotcha involved with the virtual devices >> with added api. This is how eg testpmd looks when built in shared library >> config: >> >> [pmatilai at

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-27 Thread Hunt, David
On 5/27/2016 11:33 AM, Jerin Jacob wrote: > On Fri, May 27, 2016 at 10:52:42AM +0100, Hunt, David wrote: >> >> On 5/24/2016 4:35 PM, Jerin Jacob wrote: >>> On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: + /* + * Since we have 4 combinations of the SP/SC/MP/MC examine

[dpdk-dev] [PATCH v4 5/9] lib/librte_pdump: add new library for packet capturing support

2016-05-27 Thread Ananyev, Konstantin
> -Original Message- > From: Pattan, Reshma > Sent: Friday, May 27, 2016 3:55 PM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Pattan, Reshma > Subject: RE: [dpdk-dev] [PATCH v4 5/9] lib/librte_pdump: add new library for > packet capturing support > > > > > -Original

[dpdk-dev] [PATCH v4 6/9] app/pdump: add pdump tool for packet capturing

2016-05-27 Thread Ananyev, Konstantin
> > New tool added for packet capturing on dpdk. > This tool supports command line options. > This tool runs as secondary process by default. > > Command line supports various parameters to capture > the packets. > > User should pass on a)port and queue (or) b)pci address > and queue (or)

[dpdk-dev] [PATCH] enic: negative array index write

2016-05-27 Thread Slawomir Mrozowicz
Negative array index write using variable pos as an index to array enic->fdir.nodes. Fixed by add array index check. Fixes: fefed3d1e62c ("enic: new driver") Coverity ID 13270 Signed-off-by: Slawomir Mrozowicz --- drivers/net/enic/enic_clsf.c | 6 ++ 1 file changed, 6 insertions(+) diff

[dpdk-dev] [PATCH v1] doc: add pep8 as the python code style guidelines

2016-05-27 Thread Mcnamara, John
> -Original Message- > From: Mcnamara, John > Sent: Friday, May 27, 2016 3:51 PM > To: dev at dpdk.org > Cc: Mcnamara, John > Subject: [PATCH v1] doc: add pep8 as the python code style guidelines > > Added PEP8 to the DPDK Coding Style guidelines to cover Python > contributions to DPDK.

[dpdk-dev] [PATCH v4 5/9] lib/librte_pdump: add new library for packet capturing support

2016-05-27 Thread Pattan, Reshma
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, May 27, 2016 2:39 PM > To: Pattan, Reshma ; dev at dpdk.org > Cc: Pattan, Reshma > Subject: RE: [dpdk-dev] [PATCH v4 5/9] lib/librte_pdump: add new library for > packet capturing support > > Hi Reshma, > > +static int >

[dpdk-dev] [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy

2016-05-27 Thread Hunt, David
On 5/27/2016 11:24 AM, Hunt, David wrote: > > > On 5/24/2016 4:17 PM, Jerin Jacob wrote: >> On Tue, May 24, 2016 at 04:59:47PM +0200, Olivier Matz wrote: >> >>> Are you seeing some performance improvement by using rte_memcpy()? >> Yes, In some case, In default case, It was replaced with memcpy

[dpdk-dev] [PATCHv5 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Thursday, May 26, 2016 6:17 PM > To: dev at dpdk.org > Cc: Neil Horman ; Richardson, Bruce > ; Thomas Monjalon 6wind.com>; > Stephen Hemminger ; Panu Matilainen > > Subject: [dpdk-dev]

[dpdk-dev] fast red autotest

2016-05-27 Thread Kantecki, Tomasz
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Is it possible to split them in > - short functional tests > - long run / perf tests > ? > So we could keep some basic tests in fast_test. > I expect that tests which are not part of fast_test won't be run often or in >

[dpdk-dev] [PATCH v4 5/9] lib/librte_pdump: add new library for packet capturing support

2016-05-27 Thread Ananyev, Konstantin
Hi Reshma, > > Added new library for packet capturing support. > > Added public api rte_pdump_init, applications should call > this as part of their application setup to have packet > capturing framework ready. > > Added public api rte_pdump_uninit to un initialize the packet > capturing

[dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes

2016-05-27 Thread Panu Matilainen
On 05/25/2016 09:36 AM, zr at semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes

[dpdk-dev] [PATCH v1] null: set port_id in mbufs received from null PMD

2016-05-27 Thread Sean Harte
Ensure that the port field is set in mbufs received from the null PMD. Signed-off-by: Sean Harte --- drivers/net/null/rte_eth_null.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 5e8e203..ab440f3 100644 ---

[dpdk-dev] [PATCH] port: add KNI interface support 1. add KNI port type to the packet framework 2. add KNI support to the IP Pipeline sample Application

2016-05-27 Thread WeiJie Zhuang
Signed-off-by: WeiJie Zhuang --- doc/api/doxy-api-index.md | 3 +- examples/ip_pipeline/Makefile | 6 +- examples/ip_pipeline/app.h | 74 examples/ip_pipeline/config/kni.cfg | 12 ++ examples/ip_pipeline/config_check.c | 30

[dpdk-dev] [PATCH v2] pcap: fix segfault in pcap pmd

2016-05-27 Thread Reshma Pattan
Testpmd application will crash in fclose() upon quit after running the below command. "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 --vdev 'eth_pcap0,tx_iface=enp1s0f1,rx_pcap=/tmp/test.pcap' -- --port-topology=chained -i" The reason is, pcap vdev

[dpdk-dev] [PATCH v2 2/2] bond mode 4: tests for external state machine

2016-05-27 Thread Eric Kinzie
This adds test cases for exercising the external state machine API to the mode 4 autotest. Signed-off-by: Eric Kinzie --- app/test/test_link_bonding_mode4.c | 215 ++-- 1 file changed, 206 insertions(+), 9 deletions(-) diff --git

[dpdk-dev] [PATCH v2 1/2] bond mode 4: allow external state machine

2016-05-27 Thread Eric Kinzie
Provide functions to allow an external 802.3ad state machine to transmit and recieve LACPDUs and to set the collection/distribution flags on slave interfaces. Signed-off-by: Eric Kinzie --- drivers/net/bonding/rte_eth_bond_8023ad.c | 323 +++--

[dpdk-dev] [PATCH v1] null: set port_id in mbufs received from null PMD

2016-05-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sean Harte > Sent: Friday, May 27, 2016 1:27 PM > To: mukawa at igel.co.jp > Cc: dev at dpdk.org; Harte, Sean > Subject: [dpdk-dev] [PATCH v1] null: set port_id in mbufs received from > null PMD > > Ensure

[dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Panu Matilainen
On 05/25/2016 09:58 PM, Thomas Monjalon wrote: > 2016-05-25 13:47, Neil Horman: >> On Wed, May 25, 2016 at 07:22:39PM +0200, Thomas Monjalon wrote: >>> 2016-05-24 15:41, Neil Horman: Note that, in the case of dynamically linked applications, pmdinfo.py will scan for implicitly

[dpdk-dev] Crashing OVS+DPDK at the host, from inside of a KVM Guest

2016-05-27 Thread Yuanhan Liu
On Wed, May 25, 2016 at 01:53:07PM +, Traynor, Kevin wrote: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian > > Ehrhardt > > Sent: Wednesday, May 25, 2016 7:06 AM > > To: Martinx - ? > > Cc: ; dev > > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy

2016-05-27 Thread Hunt, David
On 5/24/2016 4:17 PM, Jerin Jacob wrote: > On Tue, May 24, 2016 at 04:59:47PM +0200, Olivier Matz wrote: > >> Are you seeing some performance improvement by using rte_memcpy()? > Yes, In some case, In default case, It was replaced with memcpy by the > compiler itself(gcc 5.3). But when I tried

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-27 Thread Hunt, David
On 5/24/2016 4:35 PM, Jerin Jacob wrote: > On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: >> +/* >> + * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to >> + * set the correct index into the handler table. >> + */ >> +if (flags &

[dpdk-dev] [PATCH v2 15/17] eal: add hotplug operations for pci and vdev

2016-05-27 Thread Iremonger, Bernard
Hi David, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand > Sent: Wednesday, April 20, 2016 12:44 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; viktorin at rehivetech.com > Subject: [dpdk-dev] [PATCH v2 15/17] eal: add hotplug

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

2016-05-27 Thread Iremonger, Bernard
Hi David, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand > Sent: Wednesday, April 20, 2016 12:44 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; viktorin at rehivetech.com > Subject: [dpdk-dev] [PATCH v2 00/17] prepare for

[dpdk-dev] [PATCH] virtio: check if devargs is NULL before checking its value

2016-05-27 Thread Yuanhan Liu
On Wed, May 25, 2016 at 12:47:30PM +0200, Thomas Monjalon wrote: > > - dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI) { > > + (!dev->devargs || > > +dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI)) { > > Should the title be something like "fix

[dpdk-dev] [PATCH v2 00/19] vhost ABI/API refactoring

2016-05-27 Thread Yuanhan Liu
On Thu, May 26, 2016 at 10:04:23AM -0700, Rich Lane wrote: > On Thu, May 12, 2016 at 10:24 PM, Yuanhan Liu > wrote: > > v2: - exported ifname as well to fix a vhost-pmd issue reported > ? ? ? by Rich > ? ? - separated the big patch that introduces several new APIs > ? ? ? into

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-27 Thread Panu Matilainen
On 05/26/2016 04:13 PM, Ferruh Yigit wrote: > On 5/24/2016 11:11 AM, Christian Ehrhardt wrote: >> Hi Panu, >> I already agreed to Thomas on IRC but won't have time until next week. >> Thanks for making a patch that does that already - I'll give it a look and >> some test on my end next week then.

[dpdk-dev] [PATCH 1/2] ixgbe: VF supports mailbox interruption for PF link up/down

2016-05-27 Thread Wu, Jingjing
> +static void ixgbevf_mbx_process(struct rte_eth_dev *dev) { > + struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > + u32 in_msg = 0; > + > + if (ixgbe_read_mbx(hw, _msg, 1, 0)) > + return; > + > + /* PF reset VF event */ > + if (in_msg ==

[dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Neil Horman
On Fri, May 27, 2016 at 12:16:03PM +0300, Panu Matilainen wrote: > On 05/25/2016 09:58 PM, Thomas Monjalon wrote: > > 2016-05-25 13:47, Neil Horman: > > > On Wed, May 25, 2016 at 07:22:39PM +0200, Thomas Monjalon wrote: > > > > 2016-05-24 15:41, Neil Horman: > > > > > Note that, in the case of