[dpdk-dev] [PATCH v9 8/8] doc: update doc for packet capture framework

2016-06-14 Thread Thomas Monjalon
When commenting previous patches, I missed these docs. Please move them in the appropriate patches. 2016-06-14 10:38, Reshma Pattan: > --- a/doc/guides/prog_guide/index.rst > +++ b/doc/guides/prog_guide/index.rst > @@ -71,6 +71,7 @@ Programmer's Guide > writing_efficient_code > profile_a

[dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support

2016-06-14 Thread Thomas Monjalon
2016-06-14 10:38, Reshma Pattan: > The new librte_pdump library is added for packet capturing > support. > > Added public api rte_pdump_init, applications should call > this as part of their application setup to have packet > capturing framework ready. > > Added public api rte_pdump_uninit to uni

[dpdk-dev] [PATCH v9 4/8] ethdev: make get port by name and get name by port public

2016-06-14 Thread Thomas Monjalon
2016-06-14 10:38, Reshma Pattan: > Converted rte_eth_dev_get_port_by_name to a public API. > Converted rte_eth_dev_get_name_by_port to a public API. No justification? It was planned to remove these functions. The unique naming of the device interfaces could be improved in EAL.

[dpdk-dev] [PATCH v9 3/8] ethdev: add new fields to ethdev info struct

2016-06-14 Thread Thomas Monjalon
2016-06-14 10:38, Reshma Pattan: > New fields nb_rx_queues and nb_tx_queues are added to > rte_eth_dev_info structure. Please add a justification of why these fields are needed.

[dpdk-dev] [PATCH] vhost: remove internal lockless enqueue

2016-06-14 Thread Yuanhan Liu
Firstly, it's V2. So, don't forget to add version number and link it to the previous version next time. On Mon, Jun 13, 2016 at 07:52:12PM +0800, Huawei Xie wrote: > All other DPDK PMDs doesn't support concurrent receiving or sending > packets to the same queue. The upper application should deal

[dpdk-dev] [PATCH v9 2/8] ethdev: add new api to add Rx callback as head of the list

2016-06-14 Thread Thomas Monjalon
2016-06-14 10:38, Reshma Pattan: > Added new public api rte_eth_add_first_rx_callback to add given > callback as head of the list. > > Signed-off-by: Reshma Pattan > --- > +/* > +* Add a callback that must be called first on packet RX on a given port > +* and queue. > +* > +* This API configures

[dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support

2016-06-14 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:28 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet > capturing support > > 2016-06-14 10:38, Reshm

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-14 Thread Thomas Monjalon
2016-06-14 10:38, Reshma Pattan: > Added spinlocks around add/remove logic of Rx and Tx callbacks > to avoid corruption of callback lists in multithreaded context. > > Signed-off-by: Reshma Pattan Why cb->next is not locked in burst functions? Just protecting add/remove but not its usage seems u

[dpdk-dev] [PATCH v9 3/8] ethdev: add new fields to ethdev info struct

2016-06-14 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:10 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 3/8] ethdev: add new fields to ethdev info > struct > > 2016-06-14 10:38, Reshma Patta

[dpdk-dev] [PATCH v9 4/8] ethdev: make get port by name and get name by port public

2016-06-14 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:24 PM > To: Pattan, Reshma > Cc: dev at dpdk.org; david.marchand at 6wind.com > Subject: Re: [dpdk-dev] [PATCH v9 4/8] ethdev: make get port by name and get > name by port

[dpdk-dev] [PATCH v9 2/8] ethdev: add new api to add Rx callback as head of the list

2016-06-14 Thread Pattan, Reshma
Hi, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:02 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 2/8] ethdev: add new api to add Rx callback > as head of the list > > 2016-06-14 10

[dpdk-dev] [PATCH] virtio: use volatile to get used->idx in the loop

2016-06-14 Thread Yuanhan Liu
On Thu, Jun 02, 2016 at 08:54:38AM +, Xie, Huawei wrote: > On 6/2/2016 4:52 PM, Yuanhan Liu wrote: > > On Thu, Jun 02, 2016 at 08:39:36AM +, Xie, Huawei wrote: > >> On 6/1/2016 2:03 PM, Yuanhan Liu wrote: > >>> On Wed, Jun 01, 2016 at 05:40:08AM +, Xie, Huawei wrote: > On 5/30/2016

[dpdk-dev] [PATCH v2] virtio: fix crash loading virtio driver when devargs isn't specified

2016-06-14 Thread Yuanhan Liu
On Mon, Jun 13, 2016 at 10:53:08PM +0800, Huawei Xie wrote: > We skip kernel managed virtio devices, if it isn't whitelisted. > Before checking if the virtio device is whitelisted, check if devargs is > specified. > > Fixes: ac5e1d838dc1 ("virtio: skip error when probing kernel managed device") >

[dpdk-dev] [PATCH v4] ip_pipeline: add script file for pipeline to core mappings

2016-06-14 Thread Thomas Monjalon
2016-06-10 16:55, Jasvinder Singh: > From: Guruprasad Mukundarao > > This script parses the application configuration file and detects all the > pipelines specified therein, and then, it generates all the possible mappings > of those pipelines on the specified CPU core-list. > > As a result, eac

[dpdk-dev] [PATCH v2] ip_pipeline: fix false cacheline sharing among threads

2016-06-14 Thread Thomas Monjalon
2016-06-12 13:42, Jasvinder Singh: > In ip_pipeline app, the structure app_thread_data needs to be aligned to > the cache line boundary as threads on different cpu cores are accessing > fields of the app->thread_data and having this structure not aligned on > cacheline boundary leads to false cache

[dpdk-dev] [PATCH 1/1] ip_pipeline: fix null pointer dereference

2016-06-14 Thread Thomas Monjalon
> > Return value of function app_pipeline_type_find is not checking before > > dereference. Fix this problem by adding checking condition. > > > > Coverity issue: 127196 > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding > > dynamically") > > > > Signed-off-by: Marcin Kerl

[dpdk-dev] [PATCH] examples/ip_pipeline: fix build error for gcc 4.8

2016-06-14 Thread Thomas Monjalon
2016-06-09 13:38, Daniel Mrzyglod: > This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC > 4.8 > > examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function > 'app_pipeline_track_pktq_out_to_link': > examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: >

[dpdk-dev] [PATCH] virtio: fix allocating virtnet_rx not mem aligned

2016-06-14 Thread Yuanhan Liu
On Sun, Jun 12, 2016 at 02:29:42PM +, Jianfeng Tan wrote: > Compile DPDK with clang, below line in virtio_rxtx.c could be > optimized with four "VMOVAPS ymm, m256". > memset(&rxvq->fake_mbuf, 0, sizeof(rxvq->fake_mbuf)); > > This instruction requires memory address is 32-byte aligned. > Or,

[dpdk-dev] [PATCH 0/3] [RFC] vhost: micro vhost optimization

2016-06-14 Thread Yuanhan Liu
Applied to dpdk-next-virtio. --yliu On Mon, May 02, 2016 at 05:46:15PM -0700, Yuanhan Liu wrote: > Here is a small patch set does the micro optimization, which brings about > 10% performance boost in my 64B packet testing, with the following topo: > > pkt generator <> NIC <->

[dpdk-dev] [PATCH v3 0/6] vhost: add vhost-user client mode and reconnect ability

2016-06-14 Thread Yuanhan Liu
Applied to dpdk-next-virtio. --yliu On Tue, Jun 07, 2016 at 12:05:02PM +0800, Yuanhan Liu wrote: > v3: - make the "reconnect" feature be default for client mode, as it's > good to handle guest OS restart with less effort. > - fix var not-initilized error pointed out by Rich > >

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-14 Thread Yuanhan Liu
Applied to dpdk-next-virtio. --yliu On Tue, Jun 07, 2016 at 11:51:50AM +0800, Yuanhan Liu wrote: > v3: - adapted the new vhost ABI/API changes to tep_term example, to make > sure not break build at least. > - bumped the ABI version to 3 > > NOTE: I created a branch at dpdk.org

[dpdk-dev] [PATCH v2] doc: virtio pmd versions

2016-06-14 Thread Zhihong Wang
This patch explains all the versions of current virtio pmd implementation, what's the difference, and how to choose the right version. -- Changes in v2: 1. Changes on format and few descriptions. Signed-off-by: Zhihong Wang --- doc/guides/nics/virtio.rst | 64 ++

[dpdk-dev] [PATCH v4 01/19] net/thunderx/base: add hardware API for ThunderX nicvf inbuilt NIC

2016-06-14 Thread Jerin Jacob
On Mon, Jun 13, 2016 at 04:09:24PM +0100, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 07:25:25PM +0530, Jerin Jacob wrote: > > Adds hardware specific API for ThunderX nicvf inbuilt NIC device under > > drivers/net/thunderx/nicvf/base directory. > > > > Hi Jerin, > > we are trying to move a

[dpdk-dev] [PATCH v3 5/5] testpmd: show topology at forwarding start

2016-06-14 Thread Zhihong Wang
This patch show topology at forwarding start. "show config fwd" also does this, but showing it directly can reduce the possibility of misconfiguration. Currently fwd_config_display() calls fwd_config_setup(), this misleading behavior will be fixed in other patches. Signed-off-by: Zhihong Wang

[dpdk-dev] [PATCH v3 4/5] testpmd: handle all rxqs in rss setup

2016-06-14 Thread Zhihong Wang
This patch removes constraints in rxq handling when multiqueue is enabled to handle all the rxqs. Current testpmd forces a dedicated core for each rxq, some rxqs may be ignored when core number is less than rxq number, and that causes confusion and inconvenience. One example: One Red Hat engineer

[dpdk-dev] [PATCH v3 3/5] testpmd: show throughput in port stats

2016-06-14 Thread Zhihong Wang
This patch adds throughput numbers (in the period since last use of this command) in port statistics display for "show port stats (port_id|all)". Signed-off-by: Zhihong Wang --- app/test-pmd/config.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/app/test-pmd/confi

[dpdk-dev] [PATCH v3 2/5] testpmd: configurable tx_first burst number

2016-06-14 Thread Zhihong Wang
This patch enables configurable tx_first burst number. Use "start tx_first (burst_num)" to specify how many bursts of packets to be sent before forwarding start, or "start tx_first" like before for the default 1 burst send. Signed-off-by: Zhihong Wang Acked-by: Pablo de Lara --- app/test-pmd/

[dpdk-dev] [PATCH v3 1/5] testpmd: add retry option

2016-06-14 Thread Zhihong Wang
This patch adds retry option in testpmd to prevent most packet losses. It can be enabled by "set fwd retry". All modes except rxonly support this option. Adding retry mechanism expands test case coverage to support scenarios where packet loss affects test results. Signed-off-by: Zhihong Wang A

[dpdk-dev] [PATCH v3 0/5] vhost/virtio performance loopback utility

2016-06-14 Thread Zhihong Wang
This patch enables vhost/virtio pmd performance loopback test in testpmd. All the features are for general usage. The loopback test focuses on the maximum full-path packet forwarding performance between host and guest, it runs vhost/virtio pmd only without introducing extra overhead. Therefore, t

[dpdk-dev] [PATCH] mem: fix possible memzone integer overflow

2016-06-14 Thread Sergio Gonzalez Monroy
It is possible to get an integer overflow if we try to reserve a memzone with len = 0 (meaning the maximum contiguous space available) and the maximum available elem size is less than (MALLOC_ELEM_OVERHEAD + align). Issue reported by Coverity: >>> 10. overflow: Subtract operation overflows on

[dpdk-dev] [PATCH v2] mlx: fix icc compilation error

2016-06-14 Thread Thomas Monjalon
2016-06-14 17:02, Ferruh Yigit: > On 6/14/2016 4:39 PM, Thomas Monjalon wrote: > > 2016-06-14 16:22, Ferruh Yigit: > >> Compilation errors: > >> mlx4: > >> CC mlx4.o > >> .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type > >> mixed with another type > >> priv->intr

[dpdk-dev] [PATCH v11 1/3] mempool: support external mempool operations

2016-06-14 Thread Thomas Monjalon
2016-06-14 16:48, David Hunt: > +Several external mempool managers may be used in the same application. A new > +mempool can be created by using the ``rte_mempool_create_empty()`` function, > +then using ``rte_mempool_set_ops_byname()`` to point the mempool to the > +relevant mempool manager callba

[dpdk-dev] [PATCH v2 1/2] ixgbe: VF supports mailbox interruption for PF link up/down

2016-06-14 Thread Bruce Richardson
On Wed, Jun 01, 2016 at 09:53:08AM +0800, Wenzhuo Lu wrote: > In this scenario, kernel PF + DPDK VF, when PF finds the link > state changes, up -> down or down -> up, it will send a > message to VF by mailbox. This link state change may be > triggered by PHY disconnection/reconnection, configuratio

[dpdk-dev] [PATCH v2] mlx: fix icc compilation error

2016-06-14 Thread Thomas Monjalon
2016-06-14 16:22, Ferruh Yigit: > Compilation errors: > mlx4: > CC mlx4.o > .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type > mixed with another type > priv->intr_handle.type = 0; > ^ > > mlx5: > CC em_rxtx.o > .../dpdk/drivers

[dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory

2016-06-14 Thread Marcin Kerlin
Patch fixes resource leak in rte_eal_hugepage_attach() where mapped files were not freed back to the OS in case of failure. Patch uses the behavior of Linux munmap: "It is not an error if the indicated range does not contain any mapped pages". Coverity issue: 13295, 13296, 13303 Fixes: af75078fec

[dpdk-dev] [PATCH v2] mlx: fix icc compilation error

2016-06-14 Thread Adrien Mazarguil
On Tue, Jun 14, 2016 at 04:22:10PM +0100, Ferruh Yigit wrote: > Compilation errors: > mlx4: > CC mlx4.o > .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type > mixed with another type > priv->intr_handle.type = 0; > ^ > > mlx5: > C

[dpdk-dev] [PATCH] librte_sched: fix compile error on unused parameter red

2016-06-14 Thread Thomas Monjalon
2016-06-02 11:28, Jasvinder Singh: > This commit fixes the following compile error messages when > CONFIG_RTE_SCHED_RED=n and CONFIG_RTE_SCHED_COLLECT_STATS=y; > > rte_sched.c: In function ?rte_sched_port_update_subport_stats_on_drop?: > rte_sched.c:1090:41: error: unused parameter ?red? [-Werror=

[dpdk-dev] [PATCH v3] mlx: fix icc compilation error

2016-06-14 Thread Ferruh Yigit
Compilation errors: mlx4: CC mlx4.o .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type mixed with another type priv->intr_handle.type = 0; ^ mlx5: CC em_rxtx.o .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282): error #188: enumerated type

[dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity

2016-06-14 Thread Thomas Monjalon
> > From: Alex Wang > > > > Function like 'rte_kni_rx_burst()' keeps allocating 'MAX_MBUF_BURST_NUM' > > mbufs to kni fifo queue unless the queue's capacity > > ('KNI_FIFO_COUNT_MAX') is reached. So, if the mempool is under- > > provisioned, user may run into "Out of Memory" logs from KNI code.

[dpdk-dev] [PATCH v2] mlx: fix icc compilation error

2016-06-14 Thread Ferruh Yigit
On 6/14/2016 4:39 PM, Thomas Monjalon wrote: > 2016-06-14 16:22, Ferruh Yigit: >> Compilation errors: >> mlx4: >> CC mlx4.o >> .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type >> mixed with another type >> priv->intr_handle.type = 0; >>

[dpdk-dev] [PATCH v2] doc: add known issue with EAL argv

2016-06-14 Thread Thomas Monjalon
> > This patch docs the issue on EAL argument that the last EAL argument is > > replaced by program name in argv[]. > > > > Reported-by: Ziye Yang > > Signed-off-by: Jingjing Wu > > Acked-by: John McNamara Applied (with small rst fix), thanks

[dpdk-dev] [PATCH] enic: scattered Rx

2016-06-14 Thread Nelson Escobar
For performance reasons, this patch uses 2 VIC RQs per RQ presented to DPDK. The VIC requires that each descriptor be marked as either a start of packet (SOP) descriptor or a non-SOP descriptor. A one RQ solution requires skipping descriptors when receiving small packets and results in bad perfor

[dpdk-dev] [PATCH] enic: fix releasing of mbufs when tearing down rq

2016-06-14 Thread Nelson Escobar
When trying to release the mbufs, the function was incorrectly iterating over the max size configured instead of the actual size of the ring. Fixes: cbb44dddcade ("enic: receive path performance improvements") Signed-off-by: Nelson Escobar Reviewed-by: John Daley --- drivers/net/enic/enic_main

[dpdk-dev] [PATCH] enic: fix free function to actually free memory

2016-06-14 Thread Nelson Escobar
enic_alloc_consistent() allocated memory, but enic_free_consistent() was an empty function, so allocated memory was never freed. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: Nelson Escobar Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c | 14 +- drivers/net/enic

[dpdk-dev] [PATCH] enic: improve ptype handling

2016-06-14 Thread Nelson Escobar
- add l4 ptypes to the ones we report as supporting - report/use RTE_PTYPE_L3_IPV4_EXT_UNKNOWN and RTE_PTYPE_L3_IPV6_EXT_UNKNOWN instead of RTE_PTYPE_L3_IPV4 and RTE_PTYPE_L3_IPV6 as vic can't distinguish between packets with extentions and those without extentions. - correctly set the ptype

[dpdk-dev] [PATCH v4] Pci: Add the class_id support

2016-06-14 Thread Thomas Monjalon
2016-05-24 20:50, Ziye Yang: > This patch is used to add the class_id (class_code, > subclass_code, programming_interface) support for > pci_device probe. With this patch, it will be > flexible for users to probe a class of devices > by class_id. > > > Signed-off-by: Ziye Yang Applied, thanks

[dpdk-dev] [PATCH] enic: fix name of hash table used for enic classifiers

2016-06-14 Thread Nelson Escobar
The enic_clsf_init() function is called once per enic instance, but it used a static name to create the hash table. Consequently when using more than one enic instance, there was a name collision which caused errors: EAL: memzone_reserve_aligned_thread_unsafe(): memzone already exists RING: Can

[dpdk-dev] [PATCH v11 3/3] mbuf: make default mempool ops configurable at build

2016-06-14 Thread David Hunt
By default, the mempool ops used for mbuf allocations is a multi producer and multi consumer ring. We could imagine a target (maybe some network processors?) that provides an hardware-assisted pool mechanism. In this case, the default configuration for this architecture would contain a different va

[dpdk-dev] [PATCH v11 2/3] app/test: test external mempool manager

2016-06-14 Thread David Hunt
Use a minimal custom mempool external ops and check that it also passes basic mempool autotests. Signed-off-by: Olivier Matz Signed-off-by: David Hunt Acked-by: Shreyansh Jain Acked-by: Olivier Matz --- app/test/test_mempool.c | 122 +++- 1 file cha

[dpdk-dev] [PATCH v11 1/3] mempool: support external mempool operations

2016-06-14 Thread David Hunt
Until now, the objects stored in a mempool were internally stored in a ring. This patch introduces the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_ops_byname() right after rte_mempool_create_empt

[dpdk-dev] [PATCH v11 0/3] mempool: add external mempool manager

2016-06-14 Thread David Hunt
Here's the latest version of the External Mempool Manager patchset. It's re-based on top of the latest head as of 14/6/2016, including Olivier's 35-part patch series on mempool re-org [1] [1] http://dpdk.org/ml/archives/dev/2016-May/039229.html v11 changes: * Fixed comments (added '.' where nee

[dpdk-dev] [PATCH v5 9/9] app/testpmd: stop forwarding on exit

2016-06-14 Thread Bernard Iremonger
Stop forwarding on exit whether all ports are started or not. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 4 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c in

[dpdk-dev] [PATCH v5 8/9] app/testpmd: check for valid mbuf pool

2016-06-14 Thread Bernard Iremonger
Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index fa6434c..29947fd 100644 --- a/app/

[dpdk-dev] [PATCH v5 7/9] app/testpmd: check for valid socket id when attaching port

2016-06-14 Thread Bernard Iremonger
Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 38cddca..fa6434c 100644 --- a/app/test-pmd/testpmd.

[dpdk-dev] [PATCH v5 6/9] app/testpmd: move fwd streams initialisation

2016-06-14 Thread Bernard Iremonger
Move call to init_fwd_streams from start_port function to start_packet_forwarding function. Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5afce27..3

[dpdk-dev] [PATCH v5 5/9] app/testpmd: add another new function

2016-06-14 Thread Bernard Iremonger
Add new function port_is_bonding_slave Use this function in stop_port and close_port functions. Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 18 ++ app/test-pmd/testpmd.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-p

[dpdk-dev] [PATCH v5 4/9] app/testpmd: separate fwd config setup from display

2016-06-14 Thread Bernard Iremonger
Add call to fwd_config_setup to init_config. Remove fwd_config_setup from fwd_config_display. Add call to fwd_config_setup for corelist, coremask and nbcore setup. Add call to fwd_config_setup for portlist, portmask and nbport setup. Add call to fwd_config_setup for rxq, txq, rxd and txd setup. Si

[dpdk-dev] [PATCH v5 3/9] app/testpmd: check port is not forwarding

2016-06-14 Thread Bernard Iremonger
Add calls to port_is_forwarding function in stop_port and close_port functions to check that port is not forwarding. Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/app/test-pmd/testpmd.c b

[dpdk-dev] [PATCH v5 2/9] app/testpmd: do not update forwarding config

2016-06-14 Thread Bernard Iremonger
Do not update forwarding configuration when attaching or detaching a port Remove checks on test_done variable. Remove code to update forwarding configuration. Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 28 +

[dpdk-dev] [PATCH v5 1/9] app/testpmd: add new function

2016-06-14 Thread Bernard Iremonger
Add function port_is_forwarding to check whether a port is forwarding or not. Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 18 +- app/test-pmd/testpmd.h | 3 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd

[dpdk-dev] [PATCH v5 0/9] app/testpmd: forwarding

2016-06-14 Thread Bernard Iremonger
Modify testpmd to allow stop, close, detach and attach of a port without stopping forwarding. Changes in v5: rebased to latest master reworded commit messages, resulting in changes to patch names. Changes in v4: rebased to latest master reworked patch 4 Changes in v3: rebased to latest master. a

[dpdk-dev] [PATCH v8 0/6] virtio support for container

2016-06-14 Thread Yuanhan Liu
Series Acked-by: Yuanhan Liu --yliu On Mon, Jun 13, 2016 at 06:38:57AM +, Jianfeng Tan wrote: > v8: > - Change to use max_queue_pairs instead of queue_pairs to initialize >and deinitialize queues. > - Remove vhost-kernel support. > > v7: > - CONFIG_RTE_VIRTIO_VDEV -> CONFIG_R

[dpdk-dev] [PATCH 0/4] Convert lpm data from header to resource

2016-06-14 Thread Thomas Monjalon
2016-06-14 15:03, Nikita Kozlov: > Re-submission of Bruce Richardson patch set: > http://dpdk.org/dev/patchwork/patch/12484/ > > This patchset is a rebase to the current head and use of > strndupa (not posix) was replaced. [...] > Nikita Kozlov (4): > test: make all lpm routes be of unsigned ty

[dpdk-dev] [PATCH v2] mlx: fix icc compilation error

2016-06-14 Thread Ferruh Yigit
Compilation errors: mlx4: CC mlx4.o .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type mixed with another type priv->intr_handle.type = 0; ^ mlx5: CC em_rxtx.o .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282): error #188: enumerated type

[dpdk-dev] [PATCH] mem: skip memory locking on failure

2016-06-14 Thread Panu Matilainen
On 06/13/2016 01:26 PM, Olivier Matz wrote: > Since recently [1], it is not possible to run the dpdk with user > (non-root) privileges and the --no-huge option. This is because the eal > layer tries to lock the memory. Using locked memory is mandatory for > physical devices because they reference p

[dpdk-dev] [PATCH] mem: skip memory locking on failure

2016-06-14 Thread Olivier MATZ
Hi Panu, On 06/14/2016 03:21 PM, Panu Matilainen wrote: > On 06/13/2016 01:26 PM, Olivier Matz wrote: >> Since recently [1], it is not possible to run the dpdk with user >> (non-root) privileges and the --no-huge option. This is because the eal >> layer tries to lock the memory. Using locked memor

[dpdk-dev] [PATCH] app/test: remove rte_pci_dev_ids.h from pci_autotest

2016-06-14 Thread Thomas Monjalon
2016-06-14 15:46, Jan Viktorin: > There are 2 new fake devices for testing PCI infra. All the fake devices > are now identified by non-existing vendor and device IDs so there is no > real driver to bind to them. The testing drivers match those IDs. Why not removing the existing sysfs entries fakin

[dpdk-dev] [PATCH v5 38/38] bnxt: add flow control operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add flow_ctrl_get and flow_ctrl_set dev_ops. Uses the bnxt_set_hwrm_link_config() HWRM API added in earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer. --- driver

[dpdk-dev] [PATCH v5 37/38] bnxt: add RSS device operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add rss_hash_update and rss_hash_conf_get dev_ops Uses the bnxt_hwrm_vnic_rss_cfg() HWRM API added in the previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Rewrite the

[dpdk-dev] [PATCH v5 36/38] bnxt: add reta update/query operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add code to Update/query reta dev_ops Uses the bnxt_hwrm_vnic_rss_cfg() HWRM API added earlier. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer. --- drivers/net/bnxt/bnxt_eth

[dpdk-dev] [PATCH v5 35/38] bnxt: add set link up/down operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Adds dev_ops to set link UP or DOWN as appropriate. Uses the bnxt_set_hwrm_link_config() API added in previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Rewrite the patch description. Reorder the footer. --- dri

[dpdk-dev] [PATCH v5 34/38] bnxt: add MAC address add/remove dev ops

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to Add/Remove MAC addresses. These use the bnxt_hwrm_set_filter() defined in the previous patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix issues pointed out by checkpatch. v5: Rewrite the p

[dpdk-dev] [PATCH v5 33/38] bnxt: free memory in close operation

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds code to free all resources except the one corresponding to HWRM, which are required to notify the HWRM that the driver is unloaded (these are freed in uninit()). Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5:

[dpdk-dev] [PATCH v5 32/38] bnxt: add all multicast enable/disable operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to enable/disable multicast traffic. Uses the bnxt_hwrm_cfa_l2_set_rx_mask() API added in the earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v5: Reorder footer Rewrite the patch description

[dpdk-dev] [PATCH v5 31/38] bnxt: add promiscuous enable/disable operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the promiscuous mode enable and disable dev_ops. Uses the bnxt_hwrm_cfa_l2_set_rx_mask() API added in the earlier patch. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v4: Fix couple of typos in the commit messag

[dpdk-dev] [PATCH v5 30/38] bnxt: add start/stop/link update operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds code to add the start, stop and link update dev_ops. Also adds wraper functions like bnxt_init_chip(), bnxt_init_nic(), bnxt_alloc_mem(), bnxt_free_mem() The BNXT driver will now minimally pass traffic with testpmd. Signed-off-by: Ajit Khaparde Signed-off-b

[dpdk-dev] [PATCH v5 29/38] bnxt: add HWRM port PHY config call and helpers

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add HWRM calls to query the port's PHY and link configuration. New HWRM call: bnxt_hwrm_port_phy_qcfg This command queries the PHY configuration for the port Also adding helper function like bnxt_get_hwrm_link_config() and bnxt_parse_hw_link_speed() parse the link st

[dpdk-dev] [PATCH v5 28/38] bnxt: allocate and free all HWRM rings and groups

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add a top level functions to initialize ring groups, and functions to allocate and free all the rings via HWRM. A ring group is identified by an index. It consists of Rx or Tx ring id, completion ring id and a statistics context. Once a ring group is initialized, use this gro

[dpdk-dev] [PATCH v5 27/38] bnxt: add HWRM API to set and clear filters

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde New HWRM call: bnxt_clear_hwrm_vnic_filters This patch adds code to set and clear L2 filters from the corresponding VNIC. These filters will determine the Rx flows Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christensen -- v

[dpdk-dev] [PATCH v5 26/38] bnxt: add HWRM stat context free function

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add function and associated structures and definitions to free statistics context from the ASIC. New HWRM call: bnxt_hwrm_stat_ctx_free This command is used to free a stat context. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christen

[dpdk-dev] [PATCH v5 25/38] bnxt: add ring group alloc/free functions

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add HWRM API for ring group alloc/free functions, associated structs and definitions. This API allocates and does basic preparation for a ring group in ASIC. A ring group is identified by an index. It consists of Rx ring id, completion ring id and a statistics context. New HW

[dpdk-dev] [PATCH v5 24/38] bnxt: add HWRM ring alloc/free functions

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add HWRM API calls to allocate and free TX, RX and Completion rings in the hardware along with the associated structs and definitions. This informs the hardware of how the specific rings were set up in the host and allocates them in the HWRM, setting up the doorbell registers

[dpdk-dev] [PATCH v5 23/38] bnxt: add HWRM API for stats context allocation

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add HWRM API code to allocate a statistics context in the ASIC. This API will be called by the previously submitted "add statistics operations patch". New HWRM call: bnxt_hwrm_stat_ctx_alloc: This command allocates and does basic preparation for a stat context. Signe

[dpdk-dev] [PATCH v5 22/38] bnxt: add API for L2 Rx mask set/clear functions

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add API to set/clear L2 Rx mask. New HWRM calls: bnxt_hwrm_cfa_l2_clear_rx_mask bnxt_hwrm_cfa_l2_set_rx_mask These HWRM APIs allow setting and clearing of Rx masks in L2 context per VNIC. Signed-off-by: Ajit Khaparde Signed-off-by: Stephen Hurd Reviewed-by: David Christen

[dpdk-dev] [PATCH v5 21/38] bnxt: add HWRM API to configure RSS

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde A VNIC represents a virtual interface. It is a resource in the RX path of the chip and is used to setup various target actions such as RSS, MAC filtering etc.. for the physical function in use. New HWRM call: bnxt_hwrm_vnic_rss_cfg: Used to enable RSS configuration of

[dpdk-dev] [PATCH v5 20/38] bnxt: add API to allow configuration of vnic

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds APIs to allow configuration of a VNIC. The functions alloc and free the Class of Service or COS and Load Balance context corresponding to the VNIC in the chip. New HWRM calls: bnxt_hwrm_vnic_ctx_alloc: Used to allocate COS/Load Balance context of VNIC

[dpdk-dev] [PATCH v5 19/38] bnxt: add HWRM vnic configure function

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde A VNIC represents a virtual interface. It is a resource in the RX path of the chip and is used to setup various target actions such as RSS, MAC filtering etc.. for the physical function in use. This patch configures the properties and actions of the vnic allocated by vnic_all

[dpdk-dev] [PATCH v5 18/38] bnxt: add HWRM vnic free function

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde In this patch we add a new HWRM API to free a VNIC. A VNIC represents a virtual interface. It is a resource in the RX path of the chip and is used to setup various target actions such as RSS, MAC filtering etc.. for the physical function in use. New HWRM call: bnxt_hwrm_vnic

[dpdk-dev] [PATCH v5 17/38] bnxt: add HWRM vnic alloc function

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This requires a group info array in struct bnxt, so add that, we can save the max size from the func_qcap response, and alloc/free in init/uninit A VNIC represents a virtual interface. It is a resource in the RX path of the chip and is used to setup various target actions suc

[dpdk-dev] [PATCH v5 16/38] bnxt: add HWRM function reset command

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add bnxt_hwrm_func_reset() function and supporting structs and macros. New HWRM calls: bnxt_hwrm_func_reset: This command puts the function into the reset state. In the reset state, global and port related features of the chip are not available. This

[dpdk-dev] [PATCH v5 15/38] bnxt: add code to alloc/free Tx Rx and cmpl rings

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Perform allocation and free()ing of ring and information structures for the TX, RX, and completion rings. The previous patches had so far provided top level stubs and generic ring support, while this patch does the real allocation and freeing of the memory specific to each dif

[dpdk-dev] [PATCH v5 14/38] bnxt: add initial Rx code implementation

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde This patch adds initial implementation of rx_pkt_burst() function fo Rx. bnxt_recv_pkts() is the top level function for doing Rx. This patch also adds code to allocate rings in the ASIC. For each Rx queue allocated in the PMD driver, a corresponding ring in hardware will be

[dpdk-dev] [PATCH v5 13/38] bnxt: add initial Tx code implementation

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Initial implementation of tx_pkt_burst for transmit. bnxt_xmit_pkts() is the top level function that is called during Tx. bnxt_handle_tx_cp() is used to check and process the Tx completions generated for the Tx Buffer Descriptors sent by the hardware. This patch also adds co

[dpdk-dev] [PATCH v5 12/38] bnxt: add statistics operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add the bnxt_stats_get_op() and bnxt_stats_reset_op() dev_ops to get and reset staitstics. It also brings in the asociated HWRM calls to handle the requests appropriately. We also have the bnxt_free_stats() function which will be used in the follow on patches to free the memo

[dpdk-dev] [PATCH v5 11/38] bnxt: add Rx queue create/destroy operations

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde In this patch we are adding the bnxt_rx_queue_setup_op() and bnxt_rx_queue_release_op() functions. These will be tied to the rx_queue_setup and rx_queue_release dev_ops in a subsequent patch. In these functions we allocate/free memory for the RX queues. This still requires su

[dpdk-dev] [PATCH v5 10/38] bnxt: add Tx queue operations (nonfunctional)

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde In this patch we are adding the bnxt_tx_queue_setup_op() and bnxt_tx_queue_release_op() functions. These will be tied to the tx_queue_setup and tx_queue_release dev_ops in a subsequent patch. In these functions we allocate/free memory for the TX queues. This still requires su

[dpdk-dev] [PATCH v5 09/38] bnxt: add L2 filter alloc/init/free

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add the L2 filter structure and the alloc/init/free functions for dealing with them. A filter is used to identify traffic that contains a matching set of parameters like unicast or broadcast MAC address or a VLAN tag amongst other things which then allows the ASIC to direct t

[dpdk-dev] [PATCH v5 08/38] bnxt: add completion ring support

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Structures, macros, and functions for working with completion rings in the driver. Completion Ring is used by the Ethernet controller to provide the status of transmitted & received packets, report errors, report status changes to the host software, and inter-function forward

[dpdk-dev] [PATCH v5 07/38] bnxt: declare generic ring structs and free() func

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Declare generic ring structures and a free() function. These are generic ring mamagement functions which will be used to create Tx, Rx and Completion rings in the subsequent patches, and tie them to the HWRM managed ring resources. This generic ring structure is shared all th

[dpdk-dev] [PATCH v5 06/38] bnxt: add vnic functions and structs

2016-06-14 Thread Stephen Hurd
From: Ajit Khaparde Add functions to allocate, initialize, and free vnics. A VNIC represents a virtual interface. It is a resource in the RX path of the chip and is used to setup various target actions such as RSS, MAC filtering etc.. for the physical function in use. Signed-off-by: Ajit Khapar

  1   2   3   >