[dpdk-dev] [PATCH v6 21/21] eal/crypto: Support rte_soc_driver/device for cryptodev

- rte_cryptodev_driver/rte_cryptodev_dev embeds rte_soc_driver/device for linking SoC PMDs to crypto devices. - Add probe and remove functions linked Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 122 -

[dpdk-dev] [PATCH v6 20/21] ether: introduce ethernet dev probe remove

From: Jan Viktorin Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 148 +- lib/librte_ether/rte_ethdev.h | 31 + 2 files changed, 177

[dpdk-dev] [PATCH v6 19/21] ether: extract function eth_dev_get_intr_handle

From: Jan Viktorin We abstract access to the intr_handle here as we want to get it either from the pci_dev or soc_dev. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 14 -- 1

[dpdk-dev] [PATCH v6 18/21] ether: verify we copy info from a PCI device

From: Jan Viktorin Now that different types of ethdev exist, check for presence of PCI dev while copying out the info. Similar would be done for SoC. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal ---

[dpdk-dev] [PATCH v6 17/21] ether: utilize container_of for pci_drv

From: Jan Viktorin It is not necessary to place the rte_pci_driver at the beginning of the rte_eth_dev struct anymore as we use the container_of macro to get the parent pointer. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal

[dpdk-dev] [PATCH v6 16/21] eal/soc: additional features for SoC

From: Jan Viktorin Additional features introduced: - Find kernel driver through sysfs bindings - Dummy implementation for mapping to kernel driver - DMA coherency value from sysfs - Numa node number from sysfs - Support for updating device during probe if already

[dpdk-dev] [PATCH v6 15/21] eal/soc: add default scan for Soc devices

From: Jan Viktorin Default implementation which scans the sysfs platform devices hierarchy. For each device, extract the ueven and convert into rte_soc_device. The information populated can then be used in probe to match against the drivers registered. Signed-off-by:

[dpdk-dev] [PATCH v6 14/21] eal/soc: add intr_handle

From: Jan Viktorin Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h

[dpdk-dev] [PATCH v6 13/21] eal/soc: add drv_flags

From: Jan Viktorin The flags are copied from the PCI ones. They should be refactorized into a general set of flags in the future. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.h | 10

[dpdk-dev] [PATCH v6 12/21] eal/soc: extend and utilize devargs

From: Jan Viktorin It is assumed that SoC Devices provided on command line are prefixed with "soc:". This patch adds parse and attach support for such devices. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal ---

[dpdk-dev] [PATCH v6 10/21] eal/soc: init SoC infra from EAL

From: Jan Viktorin Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/Makefile| 1 + lib/librte_eal/bsdapp/eal/eal.c | 4 +++ lib/librte_eal/bsdapp/eal/eal_soc.c | 46

[dpdk-dev] [PATCH v6 09/21] eal: introduce command line enable SoC option

From: Jan Viktorin Support --enable-soc. SoC support is disabled by default. Signed-off-by: Jan Viktorin [Shreyansh: Change --no-soc to --enable-soc; disabled by default] Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal ---

[dpdk-dev] [PATCH v6 08/21] eal/soc: implement SoC device list and dump

From: Jan Viktorin SoC devices would be linked in a separate list (from PCI). This is used for probe function. A helper for dumping the device list is added. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal ---

[dpdk-dev] [PATCH v6 07/21] eal/soc: add SoC PMD register/unregister logic

From: Jan Viktorin Registeration of a SoC driver through a helper RTE_PMD_REGISTER_SOC (on the lines of RTE_PMD_REGISTER_PCI). soc_driver_list stores all the registered drivers. Test case has been introduced to verify the registration and deregistration. Signed-off-by:

[dpdk-dev] [PATCH v6 06/21] eal/soc: introduce very essential SoC infra definitions

From: Jan Viktorin Define initial structures and functions for the SoC infrastructure. This patch supports only a very minimal functions for now. More features will be added in the following commits. Includes rte_device/rte_driver inheritance of

[dpdk-dev] [PATCH v6 05/21] eal: define container macro

From: Jan Viktorin Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h

[dpdk-dev] [PATCH v6 04/21] eal/linux: generalize PCI kernel driver extraction to EAL

From: Jan Viktorin Generalize the PCI-specific pci_get_kernel_driver_by_path. The function is general enough, we have just moved it to eal.c, changed the prefix to rte_eal and provided it privately to other parts of EAL. Signed-off-by: Jan Viktorin Signed-off-by:

[dpdk-dev] [PATCH v6 03/21] eal/linux: generalize PCI kernel unbinding driver to EAL

From: Jan Viktorin Generalize the PCI-specific pci_unbind_kernel_driver. It is now divided into two parts. First, determination of the path and string identification of the device to be unbound. Second, the actual unbind operation which is generic. BSD implementation

[dpdk-dev] [PATCH v6 02/21] eal: generalize PCI map/unmap resource to EAL

From: Jan Viktorin The functions pci_map_resource, pci_unmap_resource are generic so the pci_* prefix can be omitted. The functions are moved to the eal_common_dev.c so they can be reused by other infrastructure. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh

[dpdk-dev] [PATCH v6 01/21] eal: generalize PCI kernel driver enum to EAL

From: Jan Viktorin Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain -- Changes since v0: - fix compilation error due to missing include --- lib/librte_eal/common/include/rte_dev.h | 12 lib/librte_eal/common/include/rte_pci.h | 9 - 2

[dpdk-dev] [PATCH v6 00/21] Introduce SoC device/driver framework for EAL

Introduction: = This patch set is direct derivative of Jan's original series [1],[2]. - This version is based on master HEAD (ca41215) - In this, I am merging the series [11] back. It was initially part of this set but I had split considering that those changes in PCI were

[dpdk-dev] Unable to change source MAC address of packet

> On 27-Oct-2016, at 7:37 pm, Wiles, Keith wrote: > > >> On Oct 27, 2016, at 6:33 AM, Padam Jeet Singh >> wrote: >> >> Hi, >> >> I am crafting a packet in which the source MAC address as set in the >> Ethernet header is different than the transmit port?s default MAC address. A >> packet

[dpdk-dev] Unable to change source MAC address of packet

Hi, I am crafting a packet in which the source MAC address as set in the Ethernet header is different than the transmit port?s default MAC address. A packet capture of the packets coming out of this port however comes with source MAC address of the port?s default MAC address. Altering the

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Thu, Oct 27, 2016 at 12:35:11PM +0200, Maxime Coquelin wrote: > > > On 10/27/2016 12:33 PM, Yuanhan Liu wrote: > >On Thu, Oct 27, 2016 at 11:10:34AM +0200, Maxime Coquelin wrote: > >>Hi Zhihong, > >> > >>On 10/27/2016 11:00 AM, Wang, Zhihong wrote: > >>>Hi Maxime, > >>> > >>>Seems indirect

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

2016-10-27 16:24, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-10-27 15:52, Ananyev, Konstantin: > > > > Hi Tomasz, > > > > > > > > This is a major new function in the API and I still have some comments. > > > > > > > > 2016-10-26 14:56, Tomasz

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Thu, Oct 27, 2016 at 11:10:34AM +0200, Maxime Coquelin wrote: > Hi Zhihong, > > On 10/27/2016 11:00 AM, Wang, Zhihong wrote: > >Hi Maxime, > > > >Seems indirect desc feature is causing serious performance > >degradation on Haswell platform, about 20% drop for both > >mrg=on and mrg=off

[dpdk-dev] [RFC PATCH v2 2/3] lib: add bitrate statistics library

On Fri, 28 Oct 2016 09:04:30 +0800 Remy Horton wrote: > + > +struct rte_stats_bitrate_s { > + uint64_t last_ibytes; > + uint64_t last_obytes; > + uint64_t peak_ibits; > + uint64_t peak_obits; > + uint64_t ewma_ibits; > + uint64_t ewma_obits; > +}; > + Reader/write access

[dpdk-dev] PCIe Hot Insert/Remove Support

Hi Benjamin, 2016-10-24 18:16, Walker, Benjamin: > Hi all, > > My name is Ben Walker and I'm the technical lead for SPDK (it's like DPDK, but > for storage devices). SPDK relies on DPDK only for the base functionality in > the > EAL - memory management, the rings, and the PCI scanning code. A

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

2016-10-27 15:52, Ananyev, Konstantin: > > > > > Hi Tomasz, > > > > This is a major new function in the API and I still have some comments. > > > > 2016-10-26 14:56, Tomasz Kulasek: > > > --- a/config/common_base > > > +++ b/config/common_base > > > +CONFIG_RTE_ETHDEV_TX_PREP=y > > > > We

[dpdk-dev] [PATCH] doc: fix mlx5 features overview

Fixes: 75ef62a94301 ("net/mlx5: fix link speed capability information") Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") Signed-off-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/mlx5.ini

[dpdk-dev] [PATCH v4] eal: fix lib version for device generalization patches

On Thursday 27 October 2016 04:59 PM, Shreyansh Jain wrote: > index aa0c09a..db20567 100644 > --- a/doc/guides/rel_notes/release_16_11.rst > +++ b/doc/guides/rel_notes/release_16_11.rst > @@ -201,6 +201,32 @@ API Changes > * The ``file_name`` data type of ``struct rte_port_source_params`` and >

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

Hi Tomasz, This is a major new function in the API and I still have some comments. 2016-10-26 14:56, Tomasz Kulasek: > --- a/config/common_base > +++ b/config/common_base > +CONFIG_RTE_ETHDEV_TX_PREP=y We cannot enable it until it is implemented in every drivers. > struct rte_eth_dev { >

[dpdk-dev] [PATCH v4] eal: fix lib version for device generalization patches

rte_device/driver generalization patches [1] were merged without a change in the LIBABIVER variable. This patches bumps the macro of affected libs: - libcryptodev and libetherdev have been bumped - librte_eal version changed in d7e61ad3ae36 ("log: remove deprecated history dump") Details of

[dpdk-dev] [PATCH v3] eal: fix libabi macro for device generalization patches

Hello Thomas, On Thursday 27 October 2016 03:45 PM, Thomas Monjalon wrote: > 2016-10-27 12:38, Shreyansh Jain: >> rte_device/driver generalization patches [1] were merged without a change >> in the LIBABIVER macro. This patches bumps the macro of affected libs. > > It is not a macro but a

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

Hi > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 27, 2016 18:24 > To: Thomas Monjalon > Cc: Kulasek, TomaszX ; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation > > > > > -Original Message- > > From: Thomas

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, October 27, 2016 17:01 > To: Kulasek, TomaszX > Cc: dev at dpdk.org; olivier.matz at 6wind.com > Subject: Re: [dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation > > Hi

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, October 27, 2016 5:02 PM > To: Ananyev, Konstantin > Cc: Kulasek, TomaszX ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation > > 2016-10-27 15:52,

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

> > Hi Tomasz, > > This is a major new function in the API and I still have some comments. > > 2016-10-26 14:56, Tomasz Kulasek: > > --- a/config/common_base > > +++ b/config/common_base > > +CONFIG_RTE_ETHDEV_TX_PREP=y > > We cannot enable it until it is implemented in every drivers. Not

[dpdk-dev] [PATCH] pci: Don't call probe callback if driver already loaded.

On Thu, Oct 27, 2016 at 3:28 PM, David Marchand wrote: > On Tue, Oct 25, 2016 at 11:50 PM, Ben Walker > wrote: >> If the user asks to probe multiple times, the probe >> callback should only be called on devices that don't have >> a driver already loaded. >> >> This is useful if a driver is

[dpdk-dev] [PATCH] pci: Don't call probe callback if driver already loaded.

Hello Benjamin, On Tue, Oct 25, 2016 at 11:50 PM, Ben Walker wrote: > If the user asks to probe multiple times, the probe > callback should only be called on devices that don't have > a driver already loaded. > > This is useful if a driver is registered after the > execution of a program has

[dpdk-dev] Tcpdump

Hi, I have a DPDK application that binds to an interface and processes packets. For debugging purposes I want to run tcpdump on this interface. IYO, what is my best option with hurting the performance of the application too much? TIA, Dror

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

On 10/26/2016 02:56 PM, Tomasz Kulasek wrote: > Added API for `rte_eth_tx_prep` > > [...] > > Signed-off-by: Tomasz Kulasek Acked-by: Olivier Matz

[dpdk-dev] [PATCH v4] eal: fix lib version for device generalization patches

2016-10-27 17:02, Shreyansh Jain: > Even though I have sent the v4, there is another possibility of > splitting this log across API and ABI changes. > Problem is that most of the changes are quite related in terms of impact > on ABI and API. (some like rte_device is clear enough, though). > Any

[dpdk-dev] Unable to change source MAC address of packet

> On Oct 27, 2016, at 6:33 AM, Padam Jeet Singh > wrote: > > Hi, > > I am crafting a packet in which the source MAC address as set in the Ethernet > header is different than the transmit port?s default MAC address. A packet > capture of the packets coming out of this port however comes with

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On 10/27/2016 12:33 PM, Yuanhan Liu wrote: > On Thu, Oct 27, 2016 at 11:10:34AM +0200, Maxime Coquelin wrote: >> Hi Zhihong, >> >> On 10/27/2016 11:00 AM, Wang, Zhihong wrote: >>> Hi Maxime, >>> >>> Seems indirect desc feature is causing serious performance >>> degradation on Haswell platform,

[dpdk-dev] [PATCH v3] eal: fix libabi macro for device generalization patches

rte_device/driver generalization patches [1] were merged without a change in the LIBABIVER macro. This patches bumps the macro of affected libs. (librte_eal was already bumped; libcryptodev and libetherdev have been bumped). Details of ABI/API changes: - EAL (version not bumped) |- type field

[dpdk-dev] Solarflare PMD submission question

Hi, First of all, welcome to DPDK! 2016-10-27 09:34, Andrew Rybchenko: > Hi, > > we would like to include Solarflare libefx-based PMD in the DPDK 17.02 > and start the upstreaming process. > The driver supports Solarflare SFN7xxx and SFN8xxx families of 10/40 > Gbps adapters. > The driver has

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On 10/27/2016 12:33 PM, Yuanhan Liu wrote: > On Thu, Oct 27, 2016 at 11:10:34AM +0200, Maxime Coquelin wrote: >> Hi Zhihong, >> >> On 10/27/2016 11:00 AM, Wang, Zhihong wrote: >>> Hi Maxime, >>> >>> Seems indirect desc feature is causing serious performance >>> degradation on Haswell platform,

[dpdk-dev] [PATCH v3] eal: fix libabi macro for device generalization patches

2016-10-27 12:38, Shreyansh Jain: > rte_device/driver generalization patches [1] were merged without a change > in the LIBABIVER macro. This patches bumps the macro of affected libs. It is not a macro but a Makefile variable. > (librte_eal was already bumped; libcryptodev and libetherdev have

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On 10/27/2016 11:10 AM, Maxime Coquelin wrote: > Hi Zhihong, > > On 10/27/2016 11:00 AM, Wang, Zhihong wrote: >> Hi Maxime, >> >> Seems indirect desc feature is causing serious performance >> degradation on Haswell platform, about 20% drop for both >> mrg=on and mrg=off (--txqflags=0xf00,

[dpdk-dev] [PATCH] doc: remove Intel reference from multi-process support guide

multi-process support has been verified on non IA such as ARMv8. Signed-off-by: Jerin Jacob --- doc/guides/prog_guide/multi_proc_support.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/multi_proc_support.rst

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

Hi Zhihong, On 10/27/2016 11:00 AM, Wang, Zhihong wrote: > Hi Maxime, > > Seems indirect desc feature is causing serious performance > degradation on Haswell platform, about 20% drop for both > mrg=on and mrg=off (--txqflags=0xf00, non-vector version), > both iofwd and macfwd. I tested PVP (with

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

On Wednesday 26 October 2016 08:53 PM, Thomas Monjalon wrote: > 2016-10-26 15:25, Ferruh Yigit: >> eal version seems already increased for this release, 2 => 3, in: >> d7e61ad3ae36 ("log: remove deprecated history dump") > > Yes thanks. > >> So NO need to increase it again, sorry for late notice,

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

Hello Ferruh, On Wednesday 26 October 2016 07:55 PM, Ferruh Yigit wrote: > Hi Shreyansh, > > On 10/26/2016 2:12 PM, Shreyansh Jain wrote: >> On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote: >>> rte_device/driver generalization patches [1] were merged without a change >>> in the

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

> -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Thursday, October 27, 2016 5:55 PM > To: Wang, Zhihong ; Yuanhan Liu > ; stephen at networkplumber.org; Pierre > Pfister (ppfister) > Cc: Xie, Huawei ; dev at dpdk.org; > vkaplans at redhat.com;

[dpdk-dev] Solarflare PMD submission question

Hi, we would like to include Solarflare libefx-based PMD in the DPDK 17.02 and start the upstreaming process. The driver supports Solarflare SFN7xxx and SFN8xxx families of 10/40 Gbps adapters. The driver has base driver. It is just fresh version of the same code which is used in the FreeBSD

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

Hi Maxime, Seems indirect desc feature is causing serious performance degradation on Haswell platform, about 20% drop for both mrg=on and mrg=off (--txqflags=0xf00, non-vector version), both iofwd and macfwd. I'm using RC2, and the CPU is Xeon E5-2699 v3 @ 2.30GHz. Could you please verify if

[dpdk-dev] [dpdk-announce] release candidate 16.11-rc2

A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v16.11-rc2 The release 16.11 is going to be small. We should try to speed up testing and fixing bugs in order to start the next cycle timely. Please shout if you are aware of an important bug. Now,

[dpdk-dev] [PATCH v4 18/32] net/qede: add missing 100G link speed capability

2016-10-26 21:28, Harish Patil: > > >2016-10-18 21:11, Rasesh Mody: > >> From: Harish Patil > >> > >> This patch fixes the missing 100G link speed advertisement > >> when the 100G support was initially added. > >> > >> Fixes: 2af14ca79c0a ("net/qede: support 100G") > >> > >> Signed-off-by:

[dpdk-dev] [PATCH v4 07/32] net/qede: fix 32 bit compilation

2016-10-26 21:01, Mody, Rasesh: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Wednesday, October 26, 2016 9:54 AM > > > > 2016-10-18 21:11, Rasesh Mody: > > > Fix 32 bit compilation for gcc version 4.3.4. > > > > > > Fixes: ec94dbc57362 ("qede: add base driver") > > >

[dpdk-dev] [PATCH v2] scripts: add more git log checks

2016-09-23 13:47, Ferruh Yigit: > Alphabetically sorted items to check and > added git log capitalization checks for LRO, NIC and PMD > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH v2 0/4] provide man pages for binaries provided by DPDK

> > Christian Ehrhardt (4): > > doc: move tool guides in their own subdirectory > > doc: rendering and installation of man pages > > doc: add basic invocation info for dpdk-pmdinfo > > doc: add basic invocation info for dpdk-devbind > > Acked-by: Luca Boccassi Applied with minor

[dpdk-dev] [PATCH v2 2/4] doc: rendering and installation of man pages

2016-08-31 09:50, Christian Ehrhardt: > +ifneq ($(wildcard $O/doc/man/*/*.1),) > + $(Q)$(call rte_mkdir, $(DESTDIR)$(mandir)) This line is useless because implicit in the next one. > + $(Q)$(call rte_mkdir, $(DESTDIR)$(mandir)/man1) > + $(Q)cp -a $O/doc/man/*/*.1

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

On Wed, Oct 26, 2016 at 01:43:25PM +0100, Bruce Richardson wrote: > On Tue, Oct 25, 2016 at 11:19:05PM +0530, Jerin Jacob wrote: > > On Wed, Oct 12, 2016 at 01:00:16AM +0530, Jerin Jacob wrote: > > > Thanks to Intel and NXP folks for the positive and constructive feedback > > > I've received so