[dpdk-dev] [PATCH] bnxt: use unsigned short instead of signed integer in bnxt_alloc_vnic_attributes

Prevent the arithmetic in bnxt_alloc_vnic_attributes from causing any unintentional havoc because of the usage of a signed variable. Coverity: 137874 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx

[dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet

? 2016/11/1 18:46, Ferruh Yigit ??: > Hi Haifeng, > > On 10/31/2016 3:52 AM, linhaifeng wrote: >> From: Haifeng Lin >> >> if rx vlan offload is enable we should not handle vlan slow >> packets too. >> >> Signed-off-by: Haifeng Lin >> --- >> drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- >> 1 f

[dpdk-dev] [PATCH] net: remove mempool as a dependency

Signed-off-by: Ferruh Yigit --- lib/librte_net/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_net/Makefile b/lib/librte_net/Makefile index e5758ce..20cf664 100644 --- a/lib/librte_net/Makefile +++ b/lib/librte_net/Makefile @@ -45,7 +45,6 @@ SYMLINK-$(CON

[dpdk-dev] [PATCH] doc: add missing library to release notes

Signed-off-by: Ferruh Yigit --- CC: Olivier Matz --- doc/guides/rel_notes/release_16_11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index aa0c09a..5f185be 100644 --- a/doc/guides/rel_notes/release_16_11.

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Fri, Oct 28, 2016 at 09:58:51AM +0200, Maxime Coquelin wrote: > >From my experience, and as Michael pointed out, the best mode for small > >packets is obviously > >ANY_LAYOUT so it uses a single descriptor per packet. > Of course, having a single descriptor is in theory the best way. > But, in

[dpdk-dev] [PATCH] E1000: fix for forced speed/duplex config

>From the code, it looks like, hw->mac.autoneg, variable is used to switch between calling either autoneg function or forcing speed/duplex function. But this variable is not modified in eth_em_start/eth_igb_start routines (it is always set to 1) even while forcing the link speed. Following discuss

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

Coverity detected this as an issue because internals->data will never be NULL, then the check is not necessary. Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") Coverity issue: 137873 Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_eth_ring.c | 20 +--- 1

[dpdk-dev] [PATCH] net/mlx5: fix wrong use of vector instruction

On 11/1/2016 8:13 AM, Elad Persiko wrote: > Constraint alignment was not respected in Tx. > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Elad Persiko > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[dpdk-dev] [PATCH] pmd_ring: fix coverity issue

Hi Mauricio, On 11/1/2016 3:48 AM, Mauricio Vasquez B wrote: > internals->data will never be NULL, so the check is not necessary. > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > Coverity issue: 137873 > > Signed-off-by: Mauricio Vasquez B > --- Thank you for the patch. But "

[dpdk-dev] [PATCH v11 1/6] ethdev: add Tx preparation

Hi Thomas, > > > I suggest to integrate it in the beginning of 17.02 cycle, with the hope > > > that you can convince other developers to implement it in other drivers, > > > so we could finally enable it in the default config. > > > > Ok, any insights then, how we can convince people to do that?

[dpdk-dev] [PATCH v3] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time

num_route_entries need to be reseted. Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file") Signed-off-by: Nikita Kozlov --- app/test/test_lpm_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index 608e17a..e7e1281 100644

[dpdk-dev] [PATCH v2] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time

num_route_entries need to be reseted. V2 : resubmitting the patch with a signed-off Signed-off-by: Nikita Kozlov --- app/test/test_lpm_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index 608e17a..e7e1281 100644 --- a/app/test/test

[dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time

num_route_entries need to be reseted. --- app/test/test_lpm_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index 608e17a..e7e1281 100644 --- a/app/test/test_lpm_perf.c +++ b/app/test/test_lpm_perf.c @@ -301,6 +301,7 @@ static void gen

[dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time

On Tue, Nov 01, 2016 at 11:47:42AM +0100, Nikita Kozlov wrote: > num_route_entries need to be reseted. > --- > app/test/test_lpm_perf.c | 1 + > 1 file changed, 1 insertion(+) > You forgot your signoff on the patch, but I confirm it does indeed fix the issue. Also, as fixes line is needed to iden

[dpdk-dev] [PATCH] net/enic: fix max packet length check

When the device was configured with an explicit maximum packet length, it would fail if the value was greater than MTU configured in CIMC/UCSM (plus L2 header length). It should have been compared against maximum allowed by the device. Fixes: bb34ffb848a0 ("net/enic: determine max egress packet si

[dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet

Hi Haifeng, On 10/31/2016 3:52 AM, linhaifeng wrote: > From: Haifeng Lin > > if rx vlan offload is enable we should not handle vlan slow > packets too. > > Signed-off-by: Haifeng Lin > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

2016-11-01 16:15, Yuanhan Liu: > On Fri, Oct 28, 2016 at 09:58:51AM +0200, Maxime Coquelin wrote: > > Agree, what we need is to be able to disable Virtio PMD features > > without having to rebuild the PMD. > > I want this feature (or more precisely, ability) long times ago. > For example, I'd wish

[dpdk-dev] [PATCH v8] app/testpmd: fix DCB configuration

Data Centre Bridge (DCB) configuration fails when SRIOV is enabled if nb_rxq and nb_txq are not set to 1. The failure occurs during configuration of the ixgbe PMD when it is started, in the ixgbe_check_mq_mode function. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by: Be

[dpdk-dev] [RFC PATCH v2 2/3] lib: add bitrate statistics library

On 28/10/2016 15:39, Morten Br?rup wrote: > Comments below. [..] > When working with statistical calculations using integer arithmetic, > you should round off the integer result by adding 0.5 to the result, > which you do by adding half of the divisor to the dividend, like > this: > > delta = (del

[dpdk-dev] [PATCH] net/mlx5: fix wrong use of vector instruction

Constraint alignment was not respected in Tx. Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Signed-off-by: Elad Persiko --- drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c