It's not a good idea to do the check of whether Rx/Tx offload is
enabled at the data path. Instead, we could do the check at init
stage and store the result, so that we could avoid the check again
and again at the critical datapath.
Cc: Olivier Matz
Signed-off-by: Yuanhan Liu
---
v2: - rebase on
On Fri, Nov 04, 2016 at 09:09:22AM +0100, Maxime Coquelin wrote:
>
>
> On 11/04/2016 03:00 AM, Yuanhan Liu wrote:
> >On Thu, Nov 03, 2016 at 09:36:52PM +0100, Maxime Coquelin wrote:
> >>Hi Yuanhan,
> >>
> >>On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> >>>This reverts commit 9a0615af7746 ("virtio:
On Fri, Nov 04, 2016 at 01:28:45PM +, Mcnamara, John wrote:
>
>
> > -Original Message-
> > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> > Sent: Wednesday, November 2, 2016 3:15 AM
> > To: dev at dpdk.org
> > Cc: Mcnamara, John ; Yuanhan Liu
> >
> > Subject: [PATCH 3/3]
On 11/04/2016 03:21 PM, Kevin Traynor wrote:
> On 11/03/2016 04:09 PM, Yuanhan Liu wrote:
>> Queue allocation should be done once, since the queue related info (such
>> as vring addreess) will only be informed to the vhost-user backend once
>> without virtio device reset.
>>
>> That means, if you a
On Fri, Nov 04, 2016 at 12:22:47PM +0100, Maxime Coquelin wrote:
>
>
> Hi Maxime,
>
> I did a little more macswap test and found out more stuff here:
> >>>Thanks for doing more tests.
> >>>
>
> 1. I did loopback test on another HSW machine with the same H/W,
> and i
From: Beilei Xing
Turning off S-TAG identification will impact floating VEB,
VFs can't communicate with each other.
This patch fixes this issue by judging whether floating
VEB is enabled, S-TAG identification will be turned off
only when floating VEB is disabled.
Fixes: 4d61120d5ce7 ("net/i40e:
On Fri, Nov 04, 2016 at 05:33:20PM +0800, Yuanhan Liu wrote:
> Turning off S-TAG identification will impact floating VEB,
> VFs can't communicate with each other.
> This patch fixes this issue by judging whether floating
> VEB is enabled, S-TAG identification will be turned off
> only when floating
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, November 04, 2016 5:00 PM
> To: De Lara Guarch, Pablo
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
>
> 2016-11-04 12:48, Pablo d
2016-11-04 12:48, Pablo de Lara:
> L3fwd-power requires the mbuf to have correct packet type,
> but in some drivers, the vector mode must be disabled for this.
This is a severe bug.
We must really fix packet type handling to have a constant support
whatever the driver or options.
Turning off S-TAG identification will impact floating VEB,
VFs can't communicate with each other.
This patch fixes this issue by judging whether floating
VEB is enabled, S-TAG identification will be turned off
only when floating VEB is disabled.
Fixes: 4d61120d5ce7 ("net/i40e: fix dropping packets
It's not a good idea to do Rx/Tx offload enabled check at the data
path. Instead, we could do the check at init stage and store the
result, so that we could avoid the check again and again at the
critical datapath.
Cc: Olivier Matz
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_ethdev
Hi Jan,
On 4 November 2016 at 15:24, wrote:
> Hello Jianbo Liu,
>
> thank you, a good catch!
>
> Can you please git blame for the commit introducing the issue and add
> the "Fixes:" tag as described in [1]?
>
> Same for ppc.
>
I will send v2 soon.
Thanks!
> Regards
> Jan
>
> [1] http://dpdk.
If VF device is used as slave of a bond device, it will be polled
periodically through alarm. Interrupt is involved here. And then
VF will send I40E_VIRTCHNL_OP_GET_LINK_STAT message to
PF to query the status. The response is handled by interrupt
callback. Interrupt is involved here again. That's w
Previously, link status interrupt in i40e is achieved by checking
LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only
for diagnostic use. Instead, drivers need to get the link status
change notification by using LSE (Link Status Event).
This patch enables LSE and calls LSC callback
There will be a SDN/NFV room on Saturday, February 4, 2017 at Brussels
(Belgium).
Areas of interest can be low-level networking or higher level management.
You can submit an abstract before November 16:
https://blogs.gnome.org/bolsh/2016/10/19/fosdem-sdn-nfv-devroom-call-for-content/
Hi,
Few comments below.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, November 4, 2016 3:36 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 1/3] lib: add information metrics library
>
> This patch adds a new informatio
On 03/11/2016 20:04, Lewis Donzis wrote:
> I?m curious about how/whether this got resolved. The 16.07.1 code doesn?t
> appear to have this fixed.
>
> Is it still forthcoming?
>
> Thanks,
> lew
It should have been fixed in 16.07.1.
http://dpdk.org/browse/dpdk-stable/commit/?id=82f931805506efbb8b5
On 11/3/2016 6:58 PM, Ajit Khaparde wrote:
> The cascading switch statement in bnxt_hwrm.c is missing the FALLTHROUGH
> comment. Adding that.
>
> Coverity: 127552
>
> Signed-off-by: Ajit Khaparde
Acked-by: Ferruh Yigit
On 11/03/2016 04:09 PM, Yuanhan Liu wrote:
> Queue allocation should be done once, since the queue related info (such
> as vring addreess) will only be informed to the vhost-user backend once
> without virtio device reset.
>
> That means, if you allocate queues again after the vhost-user negotiati
close the file descriptor after finish using it.
Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
Signed-off-by: Jianbo Liu
---
lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
b/lib/li
close the file descriptor after finish using it.
Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7)
Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8)
Signed-off-by: Jianbo Liu
---
lib/librte_eal/common/arch/arm/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/c
> On Nov 4, 2016, at 11:38 AM, Sergio Gonzalez Monroy at intel.com> wrote:
> It should have been fixed in 16.07.1.
> http://dpdk.org/browse/dpdk-stable/commit/?id=82f931805506efbb8b5046e9045bec8f04bbabf6
Hi, Sergio.
We confirmed that it works perfectly with 16.07.1 with the new contigmem driver
On Fri, Sep 30, 2016 at 04:18:42PM +0200, Thomas Monjalon wrote:
> This script can help to find commits to backport in stable branches.
>
> Fixes are found if there is the word "fix" in the headline or
> if there is a tag Fixes: or Reverts: in the message.
> Chained fixes of fixes are explored to
On 11/3/2016 12:12 PM, Fan Zhang wrote:
> Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> Coverity issue: 137854
>
> Signed-off-by: Fan Zhang
Acked-by: Ferruh Yigit
Minor nit, for all coverity fixes, defined commit log format is:
Coverity issue: x
Fixes: .
On 11/3/2016 12:12 PM, Fan Zhang wrote:
> Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> Coverity issue: 137855
>
> Signed-off-by: Fan Zhang
Acked-by: Ferruh Yigit
On 11/3/2016 12:12 PM, Fan Zhang wrote:
> Coverity issue: 137875
> Fixes: 0d547ed0 ("examples/ipsec-secgw: support configuration
> file")
>
> Signed-off-by: Fan Zhang
> ---
> examples/ipsec-secgw/sa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/
On 11/3/2016 12:12 PM, Fan Zhang wrote:
> Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> Coverity issue: 137871
>
> Signed-off-by: Fan Zhang
> ---
Coverity issue fix looks good to me, but since indentation level reduced
one level, many line wrappings can be re-arrange
Some of the production parts will arrive after the 16.11 release.
Back off support for those devices. We will add these IDs again
at an appropriate time.
---
drivers/net/bnxt/bnxt_ethdev.c | 30 --
1 file changed, 30 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethd
The cascading switch statement in bnxt_hwrm.c is missing the FALLTHROUGH
comment. Adding that.
Coverity: 127552
Signed-off-by: Ajit Khaparde
Acked-by: Ferruh Yigit
---
drivers/net/bnxt/bnxt_hwrm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bn
Prevent the arithmetic in bnxt_alloc_vnic_attributes from causing
any unintentional havoc because of the usage of a signed variable.
Coverity: 137874
Signed-off-by: Ajit Khaparde
--
v1: Previous attempt did not seem complete.
v2: simplify the fix by redoing the fix for Coverity 127557
---
driv
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Wednesday, October 5, 2016 9:43 AM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; jianbo.liu at linaro.org;
> viktorin at rehivetech.com; Jerin Jacob
> Subject: [dpdk-dev] [PATCH v
On 11/04/2016 01:30 PM, Wang, Zhihong wrote:
>
>
>> -Original Message-
>> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
>> Sent: Friday, November 4, 2016 7:23 PM
>> To: Wang, Zhihong ; Yuanhan Liu
>>
>> Cc: stephen at networkplumber.org; Pierre Pfister (ppfister)
>> ; Xie,
> -Original Message-
> From: Wu, Jingjing
> Sent: Friday, November 4, 2016 1:43 PM
> To: dev at dpdk.org
> Cc: Wu, Jingjing ; Xing, Beilei intel.com>;
> Zhang, Helin
> Subject: [PATCH] net/i40e: fix dcb configure failure
>
> Removing stopping LLDP in firmware is a workaround for a known
Removing stopping LLDP in firmware is a workaround for a
known errata which can cause Rx hang. But the changing will
cause DCB configuration fails. That is because when LLDP is
enabled, the return value of i40e_init_dcb is success. But
following check just considered the case when LLDP agent
is dis
On 02/11/2016 20:21, Shepard Siegel wrote:
[..]
> Almost a year into our DPDK development, we have shipped an alpha version
> of our "Arkville" product. We've thankful for all the support from this
> Most everyone has suggested "get your code upstream ASAP"; but our
> team is cut from the "if it i
> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, October 18, 2016 2:38 PM
> To: dev at dpdk.org; Mcnamara, John
> Cc: Iremonger, Bernard
> Subject: [PATCH v1] doc: announce API and ABI change for librte_ether
>
> In 17.02 five rte_eth_dev_set_vf_*** functions will be re
> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, October 18, 2016 2:38 PM
> To: dev at dpdk.org; Mcnamara, John
> Cc: Iremonger, Bernard
> Subject: [PATCH v1] doc: announce API change for ethdev function
>
> The _rte_eth_dev_call_process function will change to return "
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Yuanhan Liu
>
> Subject: [PATCH 2/3] doc: update the vhost sample guide
>
> For vhost-switch sample, the old guide ta
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Yuanhan Liu
>
> Subject: [PATCH 3/3] vhost: update comments
>
> vhost-cuse is removed, update corresponding comments
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Yuanhan Liu
>
> Subject: [PATCH 1/3] doc: update vhost programming guide
>
> vhost-cuse has been removed in this rele
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Friday, November 4, 2016 8:54 PM
> To: Wang, Zhihong ; Yuanhan Liu
>
> Cc: stephen at networkplumber.org; Pierre Pfister (ppfister)
> ; Xie, Huawei ; dev at
> dpdk.org;
> vkaplans at redhat.com;
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, November 4, 2016 12:48 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
>
> L3fwd-power app needs vector
L3fwd-power app needs vector mode to be disabled in order to work
properly. The app used to work previously, because it was using
Rx scalar function, but now it uses vector function.
Vector mode needs to be disabled to make the app works,
which has been documented in release notes.
Signed-off-by:
On 11/04/2016 12:36 PM, Yuanhan Liu wrote:
> On Fri, Nov 04, 2016 at 12:22:47PM +0100, Maxime Coquelin wrote:
>>
>>
>> Hi Maxime,
>>
>> I did a little more macswap test and found out more stuff here:
> Thanks for doing more tests.
>
>>
>> 1. I did loopback test on anot
2016-11-01 12:57, Ananyev, Konstantin:
> > > > I suggest to integrate it in the beginning of 17.02 cycle, with the hope
> > > > that you can convince other developers to implement it in other drivers,
> > > > so we could finally enable it in the default config.
> > >
> > > Ok, any insights then, ho
On Fri, Nov 4, 2016 at 5:52 AM, Ferruh Yigit wrote:
> On 11/3/2016 6:58 PM, Ajit Khaparde wrote:
> > Prevent the arithmetic in bnxt_alloc_vnic_attributes from causing
> > any unintentional havoc because of the usage of a signed variable.
> >
> > Coverity: 137874
> >
> > Signed-off-by: Ajit Khapar
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Friday, November 4, 2016 7:23 PM
> To: Wang, Zhihong ; Yuanhan Liu
>
> Cc: stephen at networkplumber.org; Pierre Pfister (ppfister)
> ; Xie, Huawei ; dev at
> dpdk.org;
> vkaplans at redhat.com;
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Friday, November 04, 2016 12:04 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] examples/l3fwd-power: fix inappropiate Rx queue count
> method
>
> Since commit b4f3c136a179 ("net/ixgbe: support checksum fl
Hi Maxime,
I did a little more macswap test and found out more stuff here:
>>> Thanks for doing more tests.
>>>
1. I did loopback test on another HSW machine with the same H/W,
and indirect_desc on and off seems have close perf
2. So I checked the gcc
Hi Yong,
Thank you for the review.
On 11/3/2016 1:24 AM, Yong Wang wrote:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Monday, October 10, 2016 6:20 AM
>> To: dev at dpdk.org
>> Cc: Ferruh Yigit
>> Subject: [dpdk-dev] [PATCH v3] n
On Fri, 4 Nov 2016 15:16:42 +0530
Jianbo Liu wrote:
> close the file descriptor after finish using it.
s/close/Close/
>
> Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7)
> Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8)
>
> Signed-off-by: Jianbo Liu
Acked-by: Jan Viktorin
On Fri, 4 Nov 2016 15:16:43 +0530
Jianbo Liu wrote:
> close the file descriptor after finish using it.
s/close/Close/
Please include my ack (below).
Jan
>
> Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
>
> Signed-off-by: Jianbo Liu
Acked-by: Jan Viktorin
Signed-off-by: Jianbo Liu
---
lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
index a8147c8..fcf96e0 100644
--- a/lib/librte_eal/common/arch/pp
Signed-off-by: Jianbo Liu
---
lib/librte_eal/common/arch/arm/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
index 23240ef..79160a6 100644
--- a/lib/librte_eal/common/arch/arm/rte_cpu
> On Nov 4, 2016, at 11:38 AM, Sergio Gonzalez Monroy at intel.com> wrote:
>
> On 03/11/2016 20:04, Lewis Donzis wrote:
>> I?m curious about how/whether this got resolved. The 16.07.1 code doesn?t
>> appear to have this fixed.
>>
>> Is it still forthcoming?
>>
>> Thanks,
>> lew
>
> It shoul
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 6185be6..3cf4795 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -78,6 +
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
config/common_base | 5 +
doc/api/doxy-api-index.md
This patch adds a new information metric library that allows other
modules to register named metrics and update their values. It is
intended to be independent of ethdev, rather than mixing ethdev
and non-ethdev information in xstats.
Signed-off-by: Remy Horton
---
config/common_base
This patchset extends statistics reporting to include peak and
average data-rate metrics. It comes in two parts: a statistics
reporting library, and a bitrate calculation library that uses
it. This structure is intended to seperate statistic reporting
from ethdev and allow more flexible metric regi
From: Linhaifeng
We should not drop the slow packets which subtype is
not marker or lacp. Because slow packets have other subtype
like OAM,OSSP,user defined and so on.
Signed-off-by: Linhaifeng
---
drivers/net/bonding/rte_eth_bond_pmd.c | 14 +-
1 file changed, 13 insertions(+), 1
On Fri, Nov 04, 2016 at 06:36:30AM +, Lu, Wenzhuo wrote:
> Hi Adrien,
>
> > -Original Message-
> > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> > Sent: Wednesday, November 2, 2016 11:21 PM
> > To: Lu, Wenzhuo
> > Cc: Ananyev, Konstantin; Liu, Yu Y; Chen, WeichunX; Xu
Hi,all
please ignore the patch which title is "net/bonding: not handle vlan slow
packet",
I will send another one.
? 2016/11/1 20:32, linhaifeng ??:
> ? 2016/11/1 18:46, Ferruh Yigit ??:
>> Hi Haifeng,
>>
>> On 10/31/2016 3:52 AM, linhaifeng wrote:
>>> From: Haifeng Lin
>>>
>>> if rx vlan offlo
On 11/3/2016 6:58 PM, Ajit Khaparde wrote:
> Prevent the arithmetic in bnxt_alloc_vnic_attributes from causing
> any unintentional havoc because of the usage of a signed variable.
>
> Coverity: 137874
>
> Signed-off-by: Ajit Khaparde
>
> --
> v2: Previous attempt did not seem complete.
> ---
>
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Friday, November 4, 2016 4:00 PM
> To: Wang, Zhihong ; Yuanhan Liu
>
> Cc: stephen at networkplumber.org; Pierre Pfister (ppfister)
> ; Xie, Huawei ; dev at
> dpdk.org;
> vkaplans at redhat.com;
In the LB, I do not use any rule.
What I do with LB:
1, use a field of the header to select an application,
2, cut the l2 Head, both with the vlan tag
3, add another L2 head with the L2 Dst MAC set to the VF used by the
application, Both rx and tx pkt has the same vlan tag.
4, put it to tx queue,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Thursday, October 27, 2016 4:04 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix mlx5 features overview
>
> Fixes: 75ef62a94301 ("net/mlx5: fix link speed capability inf
On Thu, Nov 03, 2016 at 09:36:52PM +0100, Maxime Coquelin wrote:
> Hi Yuanhan,
>
> On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> >This reverts commit 9a0615af7746 ("virtio: fix restart"); conflict is
> >manually addressed.
> >
> >Kyle reported an issue with above commit
> >
> >qemu-kvm: Guest m
On Thu, Nov 03, 2016 at 09:48:03PM +0100, Maxime Coquelin wrote:
>
>
> On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> >Let rxq/txq/cq be the union field of the virtqueue struct. This would
> >simplifies the vq allocation a bit: we don't need calculate the vq_size
> >any more based on the queue time
On Thu, Nov 03, 2016 at 10:11:43PM +0100, Maxime Coquelin wrote:
>
>
> On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> >Queue allocation should be done once, since the queue related info (such
> >as vring addreess) will only be informed to the vhost-user backend once
> >without virtio device reset.
On 11/03/2016 05:10 PM, Yuanhan Liu wrote:
> The "hw->started" field was introduced to stop touching queues
> on restart. We never touches queues on restart any more, thus
> it's safe to remove this flag.
>
> Signed-off-by: Yuanhan Liu
> ---
> drivers/net/virtio/virtio_ethdev.c | 15 ++-
On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> Invoking vtpci_reinit_complete() at port start stage doesn't make any
> sense, instead, it should be done at the end of dev init stage.
>
> So move it here.
>
> Signed-off-by: Yuanhan Liu
> ---
> drivers/net/virtio/virtio_ethdev.c | 3 +--
> 1 file c
On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> The only piece of code of virtio_dev_rxtx_start() is actually doing
> queue configure/setup work. So, move it to corresponding queue_setup
> callback.
>
> Once that is done, virtio_dev_rxtx_start() becomes an empty function,
> thus it's being removed.
On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> virtio_dev_vring_start() is actually doing the vring initiation job.
> And the vring initiation job should be done at the dev init stage, as
> stated with great details in former commit.
>
> So move it there, and rename it to virtio_init_vring().
>
> S
> -Original Message-
> From: John Daley [mailto:johndale at cisco.com]
> Sent: Thursday, November 3, 2016 6:02 PM
> To: Mcnamara, John
> Cc: dev at dpdk.org; John Daley
> Subject: [PATCH] doc: update release notes with enic PMD changes
>
> Signed-off-by: John Daley
Acked-by: John McNa
> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com]
> Sent: Thursday, November 3, 2016 1:46 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Adrien Mazarguil
>
> Subject: [PATCH v2] doc: add mlx5 release notes
>
> Add list of tested and validated NICs too.
On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> Queue allocation should be done once, since the queue related info (such
> as vring addreess) will only be informed to the vhost-user backend once
> without virtio device reset.
>
> That means, if you allocate queues again after the vhost-user negotiat
On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
> This reverts commit 9a0615af7746 ("virtio: fix restart"); conflict is
> manually addressed.
>
> Kyle reported an issue with above commit
>
> qemu-kvm: Guest moved used index from 5 to 1
>
> with following steps,
>
> 1) Start my virtio interface
On 11/04/2016 03:00 AM, Yuanhan Liu wrote:
> On Thu, Nov 03, 2016 at 09:36:52PM +0100, Maxime Coquelin wrote:
>> Hi Yuanhan,
>>
>> On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
>>> This reverts commit 9a0615af7746 ("virtio: fix restart"); conflict is
>>> manually addressed.
>>>
>>> Kyle reported an
On 11/04/2016 02:50 AM, Yuanhan Liu wrote:
> On Thu, Nov 03, 2016 at 10:11:43PM +0100, Maxime Coquelin wrote:
>>
>>
>> On 11/03/2016 05:09 PM, Yuanhan Liu wrote:
>>> Queue allocation should be done once, since the queue related info (such
>>> as vring addreess) will only be informed to the vhost-
On 11/04/2016 08:57 AM, Maxime Coquelin wrote:
> Hi Zhihong,
>
> On 11/04/2016 08:20 AM, Wang, Zhihong wrote:
>>
>>
>>> -Original Message-
>>> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
>>> Sent: Thursday, November 3, 2016 4:11 PM
>>> To: Wang, Zhihong ; Yuanhan Liu
>>>
Hi Zhihong,
On 11/04/2016 08:20 AM, Wang, Zhihong wrote:
>
>
>> -Original Message-
>> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
>> Sent: Thursday, November 3, 2016 4:11 PM
>> To: Wang, Zhihong ; Yuanhan Liu
>>
>> Cc: stephen at networkplumber.org; Pierre Pfister (ppfist
Hi,
On 11/04/2016 07:18 AM, Xu, Qian Q wrote:
>
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maxime Coquelin
> Sent: Thursday, November 3, 2016 4:11 PM
> To: Wang, Zhihong ; Yuanhan Liu linux.intel.com>
> Cc: mst at redhat.com; dev at dpdk.org; vkaplans
Please, add the Fixes tag.
On Fri, 4 Nov 2016 11:59:09 +0530
Jianbo Liu wrote:
> Signed-off-by: Jianbo Liu
Acked-by: Jan Viktorin
Hello Jianbo Liu,
thank you, a good catch!
Can you please git blame for the commit introducing the issue and add
the "Fixes:" tag as described in [1]?
Same for ppc.
Regards
Jan
[1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
On Fri, 4 Nov 2016 11:59:08 +0530
Jia
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Thursday, November 3, 2016 4:11 PM
> To: Wang, Zhihong ; Yuanhan Liu
>
> Cc: stephen at networkplumber.org; Pierre Pfister (ppfister)
> ; Xie, Huawei ; dev at
> dpdk.org;
> vkaplans at redhat.com
Hi Adrien,
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Wednesday, November 2, 2016 11:21 PM
> To: Lu, Wenzhuo
> Cc: Ananyev, Konstantin; Liu, Yu Y; Chen, WeichunX; Xu, HuilongX;
> dev at dpdk.org
> Subject: Re: dpdk16.11 RC2 package ipv4 rea
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin
Sent: Thursday, November 3, 2016 4:11 PM
To: Wang, Zhihong ; Yuanhan Liu
Cc: mst at redhat.com; dev at dpdk.org; vkaplans at redhat.com
Subject: Re: [dpdk-dev] [PATCH v4] vhost: Add indirect descripto
> -Original Message-
> From: Iremonger, Bernard
> Sent: Friday, November 4, 2016 1:36 AM
> To: dev at dpdk.org; Shah, Rahul R ; Wu, Jingjing
> ; Lu, Wenzhuo
> Cc: Iremonger, Bernard
> Subject: [PATCH v9] app/testpmd: fix DCB configuration
>
> Data Centre Bridge (DCB) configuration fail
Hi Anning,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Caianning
> Sent: Friday, November 4, 2016 10:51 AM
> To: users at dpdk.org; dev at dpdk.org
> Subject: [dpdk-dev] HOW to forward vlan pkt using DPDK loadbalancer and L2FD,
> with intel 82599ES
>
>
HI,
I am using DPDK 16.07 example loadbalancer to as LB to forward vlan
pkt to applications. LB and applications are using VFs bound with DPDK igb_uio
driver.
But I found the packet can not be send from LB to application. Pkt input to LB
with vlan, after LB processing it is sent out to
The "hw->started" field was introduced to stop touching queues
on restart. We never touches queues on restart any more, thus
it's safe to remove this flag.
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_ethdev.c | 15 ++-
drivers/net/virtio/virtio_pci.h| 1 -
2 files c
Invoking vtpci_reinit_complete() at port start stage doesn't make any
sense, instead, it should be done at the end of dev init stage.
So move it here.
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/
The only piece of code of virtio_dev_rxtx_start() is actually doing
queue configure/setup work. So, move it to corresponding queue_setup
callback.
Once that is done, virtio_dev_rxtx_start() becomes an empty function,
thus it's being removed.
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/vir
virtio_dev_vring_start() is actually doing the vring initiation job.
And the vring initiation job should be done at the dev init stage, as
stated with great details in former commit.
So move it there, and rename it to virtio_init_vring().
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio
Queue allocation should be done once, since the queue related info (such
as vring addreess) will only be informed to the vhost-user backend once
without virtio device reset.
That means, if you allocate queues again after the vhost-user negotiation,
the vhost-user backend will not be informed any m
Let rxq/txq/cq be the union field of the virtqueue struct. This would
simplifies the vq allocation a bit: we don't need calculate the vq_size
any more based on the queue time.
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_ethdev.c | 18 +++---
drivers/net/virtio/virtqueue.
Instead of setting up a queue memzone name like "port0_rxq0", "port0_txq0",
it could be simplified a bit to something like "port0_vq0", "port0_vq1" ...
Meanwhile, the code is also simplified a bit.
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_ethdev.c | 10 --
1 file changed
This reverts commit 9a0615af7746 ("virtio: fix restart"); conflict is
manually addressed.
Kyle reported an issue with above commit
qemu-kvm: Guest moved used index from 5 to 1
with following steps,
1) Start my virtio interfaces
2) Send some traffic into/out of the interfaces
3)
This patchset fixes an issue (virtio/vhost become broken when queue setup
is done 2 or more times, check patch 2 for great details) reported by Ilya
at the late stage of last release. I sensed it would be some amounts of
code work, that I delayed it to this release. However, I failed to make
the fi
Since commit b4f3c136a179 ("net/ixgbe: support checksum flags in SSE vector
Rx"),
when HW IP Checksum is enabled, the RX vector function is available to use.
In case of L3fwd-power, since it is enabled, the RX vector function
was not used, but after this commit, it is. This has affected the way
to
100 matches
Mail list logo