Bruce Richardson writes:
> On Tue, Dec 01, 2015 at 04:58:08PM +0200, Panu Matilainen wrote:
>> On 12/01/2015 04:48 PM, Vincent JARDIN wrote:
>> >On 01/12/2015 15:27, Panu Matilainen wrote:
>> >>The problem with that (unless I'm missing something here) is that KNI
>> >>requires using out-of-tree
ting HMAC precomputes
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT)+= -lrte_pmd_qat -lcrypto
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT)+= -lrte_pmd_qat
>
> # AESNI MULTI BUFFER is dependent on the IPSec_MB library
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb
Acked-by: Aaron Conole
restarted.
Signed-off-by: Aaron Conole
---
tools/dpdk_nic_bind.py | 8
1 file changed, 8 insertions(+)
diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index f02454e..ca39389 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -344,8 +344,10 @@ def bind_one
Morten Br?rup writes:
> I noticed a discussion about support for tcpdump in DPDK 2.3.
>
>
>
> Please consider which scenarios you want to support:
Morten,
Thanks for your input here. I think there's a different way of
approaching this: "debuggability" (sorry, it's not grammatical).
The end
Matthew Hall writes:
>> The pcap file format contains a header in front of each packet, which is
>> extremely simple. But it has a timestamp (which uses 32 bit for tv_sec and
>> tv_usec in files), so it needs to be considered how to handle this
>> efficiently.
>
> I already wrote some C code
Reshma Pattan writes:
> Added new library for packet capturing support.
>
> Added public api rte_pdump_init, applications should call
> this as part of their application setup to have packet
> capturing framework ready.
>
> Added public api rte_pdump_uninit to uninitialize the packet
> capturing
"Ananyev, Konstantin" writes:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Aaron Conole
>> Sent: Thursday, June 09, 2016 4:59 PM
>> To: Pattan, Reshma
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PAT
"Ananyev, Konstantin" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:aconole at redhat.com]
>> Sent: Thursday, June 09, 2016 6:24 PM
>> To: Ananyev, Konstantin
>> Cc: Pattan, Reshma; dev at dpdk.org
>> Subject: Re: [dpdk
Hi Reshma,
Reshma Pattan writes:
> Added new library for packet capturing support.
>
> Added public api rte_pdump_init, applications should call
> this as part of their application setup to have packet
> capturing framework ready.
>
> Added public api rte_pdump_uninit to uninitialize the packet
"Pattan, Reshma" writes:
> Hi,
>
>> -Original Message-
>> From: Aaron Conole [mailto:aconole at redhat.com]
>> Sent: Friday, June 10, 2016 7:48 PM
>> To: Pattan, Reshma
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v8
to open sockets due to policy restrictions.
This patch provides a new API and ABI to allow application developers to
acquire the unix domain socket via whatever mechanism fits and pass it
to the vhost driver registration process.
Signed-off-by: Aaron Conole
---
doc/guides/prog_guide
Yuanhan Liu writes:
> On Fri, Jun 17, 2016 at 11:32:36AM -0400, Aaron Conole wrote:
>> Prior to this commit, the only way to add a vhost-user socket to the
>> system is by relying on librte_vhost to open the unix domain socket and
>> add it to the unix socket list.
Yuanhan Liu writes:
> On Fri, Jun 24, 2016 at 07:43:29AM +, Loftus, Ciara wrote:
>> >
>> > On Tue, Jun 21, 2016 at 09:15:03AM -0400, Aaron Conole wrote:
>> > > Yuanhan Liu writes:
>> > >
>> > > > On Fri, Jun 17, 2016 at 11:32:36
Yuanhan Liu writes:
> On Fri, Jun 24, 2016 at 08:23:52AM -0400, Aaron Conole wrote:
>> Is there still merit to this patch, given above? If so, I'd finish my
>> integration and testing work and submit it formally.
>
> Sorry, I don't see the strong need of this patch (at lea
The CHANNEL_CMDS_MAX_VM_CHANNELS is duplicated in the channel_commands
header file. This commit removes that duplication.
fixes 210c383e247b5335cd95223fac1c0880ebbd5c96 ("power: packet format for ...")
Signed-off-by: Aaron Conole
---
lib/librte_power/channel_commands.h | 3 ---
1 fi
The vHost eventlink driver is a kernel module that requires a kernel
source/build directory to build the ko. Convert the fixed kernel build
directory specifier to one which may be user specified on the command-line.
Signed-off-by: Aaron Conole
---
lib/librte_vhost/eventfd_link/Makefile | 6
Ravi Kerur writes:
> Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT
> are defined in each PMD driver file. Move those macros into common
> lib/librte_mbuf/rte_mbuf.h file. PMD drivers include rte_mbuf.h
> file directly/indirectly hence no additionl header file inclusion
> is
Greetings,
Tetsuya Mukawa writes:
> These variables are needed to be able to manage one of virtio devices
> using both vhost library APIs and vhost PMD.
> For example, if vhost PMD uses current callback handler and private data
> provided by vhost library, A DPDK application that links vhost
Hi Mario,
Mario Carrillo writes:
> DPDK package lacks of a mechanism to install libraries, headers
> applications, kernel modules and sdk files to a file system tree.
> This patch set allows to install files based on the next
> proposal:
>
Panu Matilainen writes:
> On 11/11/2015 06:28 PM, Bruce Richardson wrote:
>> On Wed, Nov 11, 2015 at 04:13:01PM +, Montorsi, Francesco wrote:
>>> Hi,
>>> Is there a way to permanently (i.e., have the configuration automatically
>>> applied after reboot) bind a NIC port to DPDK?
>>>
>>> In
always.
>>
>> Based on a patch by Sergio Gonzales Monroy, linker script approach
>> initially suggested by Neil Horman.
>>
>> Suggested-by: Sergio Gonzalez Monroy
>> Suggested-by: Neil Horman
>> Signed-off-by: Panu Matilainen
> Acked-by: Neil Horman
> Nice work
+1, and just for good measure:
Acked-by: Aaron Conole
Hi Rahul,
Rahul Lakkireddy writes:
> Update sge initialization with respect to free-list manager configuration
> and ingress arbiter. Also update refill logic to refill mbufs only after
> a certain threshold for rx. Optimize tx packet prefetch and free.
<>
> for (i = 0; i
but it may be required to do so for a correct fix).
Aaron Conole (8):
lpm: Fix pointer aliasing issues
app/test/test: Fix missing brackets
drivers/net/e1000: Fix missing brackets
drivers/net/e1000: Fix missing lsc interrupt check brackets
drivers/net/ixgbe: Fix vlan filter missing brackets
The current implementation attempts to use a uint16_t to alias the lpm table
structures. Such aliasing can break optimizer performance. This patch uses
union type indirection and adds static inline functions for performing the
aliasing.
Signed-off-by: Aaron Conole
---
lib/librte_lpm/rte_lpm.h
The test application calls printf(...) with the suite->suite_name argument.
The intent (based on whitespace) in the printf is to check suite->suite_name
first and then apply the printf. This doesn't happen due to missing brackets.
Signed-off-by: Aaron Conole
---
app/test/test.c | 3 ++-
The register read/write mphy functions have misleading whitespace around
the locked check. This cleanup merely preserves the existing functionality
while improving the ready check.
Signed-off-by: Aaron Conole
---
drivers/net/e1000/base/e1000_phy.c | 12 ++--
1 file changed, 6 insertions
The device lsc interupt check has a misleading whitespace around it which
can be improved by adding appropriate braces to the check. Since the ret
variable was checked after previous assignment, this introduces no functional
change.
Signed-off-by: Aaron Conole
---
drivers/net/e1000/em_ethdev.c
The ixgbe vlan filter code has an if check with an incorrect whitespace.
Signed-off-by: Aaron Conole
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3e6fe86
Tell the compiler to use an unsigned constant for the config shifts.
Signed-off-by: Aaron Conole
---
drivers/net/e1000/igb_pf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c
index 1d00dda..afe80f5 100644
Tell the compiler to use an unsigned constant for the config shifts.
Signed-off-by: Aaron Conole
---
drivers/net/ixgbe/ixgbe_pf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index 2ffbd1f..8b5119f 100644
Silence a compiler warning that this variable may be used uninitialized.
Signed-off-by: Aaron Conole
---
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index e95e6b7..775edc7
Hi Bruce,
Bruce Richardson writes:
> On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote:
>> The current implementation attempts to use a uint16_t to alias the lpm table
>> structures. Such aliasing can break optimizer performance. This patch uses
>> union type
Hi Wenzhou,
"Lu, Wenzhuo" writes:
> Hi Aaron,
>
>
>> -Original Message-----
>> From: Aaron Conole [mailto:aconole at redhat.com]
>> Sent: Friday, February 26, 2016 2:49 AM
>> To: dev at dpdk.org
>> Cc: Lu, Wenzhuo; Zhang, Helin; Ananyev, Kon
Ferruh Yigit writes:
> This work is to make DPDK ports more visible and to enable using common
> Linux tools to configure DPDK ports.
This is a good goal. Only question - why use an additional kernel module
to do this? Is it _JUST_ for ethtool support? I think the other stuff
can be accomplished
t users know that DPDK
> enabled applications will not find rebound ports until after they have been
> restarted.
>
> Signed-off-by: Aaron Conole
>
> ---
> tools/dpdk_nic_bind.py | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/dpdk_nic_bind.py b/tools
Hi Ilya,
Ilya Maximets writes:
> On 28.11.2016 21:55, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> According to DPDK API (lib/librte_eal/common/include/rte_eal.h):
>>>
>>> "After the call to rte_eal_init(), all arguments argv[x]
&
Thomas Monjalon writes:
> 2016-04-25 21:16, Yuanhan Liu:
>> On Mon, Apr 25, 2016 at 11:18:16AM +0200, Christian Ehrhardt wrote:
>> > The API doesn't hold a way to specify a owner/permission set for vhost_user
>> > created sockets.
>>
>> Yes, it's kind of like a known issue. So, thanks for
Hi Ferruh,
I missed your original reply to me. Sorry.
Ferruh Yigit writes:
> On Tue, Jan 19, 2016 at 01:29:32PM +0200, Panu Matilainen wrote:
>> On 01/19/2016 11:59 AM, Ferruh Yigit wrote:
>>> On Mon, Jan 18, 2016 at 11:20:02AM -0500, Aaron Conole wrote:
>>
Hi Ferruh,
Ferruh Yigit writes:
> This is continuation of previous mail thread:
> http://dpdk.org/ml/archives/dev/2016-February/032701.html
>
> Since there were no comments, I want to give another try, this can be
> good opportunity to escape from out-of-kernel Linux module.
Awesome! I
Thomas Monjalon writes:
> 2016-02-25 21:30, Bruce Richardson:
>> On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote:
>> > /**
>> > + * Convert from tbl_entry types to integer types
>> > + */
>> > +static inline uint16_t
>
patch from the original series has been dropped. It is no
longer needed, after commit 5ecdeba601d1 ("lpm: merge tbl24 and tbl8
structures").
Aaron Conole (7):
app/test/test: Fix missing brackets
drivers/net/e1000: Fix missing brackets
drivers/net/e1000: Fix missing lsc inter
The test application calls printf(...) with the suite->suite_name argument.
The intent (based on whitespace) in the printf is to check suite->suite_name
first and then apply the printf. This doesn't happen due to missing brackets.
Signed-off-by: Aaron Conole
Acked-by: Panu Matilainen
The register read/write mphy functions have misleading whitespace around
the locked check. This cleanup merely preserves the existing functionality
while improving the ready check.
Fixes commit 38db3f7f50bd ("e1000: update base driver")
Signed-off-by: Aaron Conole
---
v2:
* Ch
ndler")
Signed-off-by: Aaron Conole
Acked-by: Panu Matilainen
---
v2:
* Added Fixes line.
drivers/net/e1000/em_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 1f0a7f4..9b5e1af 100644
--- a/d
The ixgbe vlan filter code has an if check with an incorrect whitespace.
Signed-off-by: Aaron Conole
Acked-by: Panu Matilainen
Acked-by: Helin Zhang
---
v2:
* No change (apart from adding ACKs)
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Tell the compiler to use an unsigned constant for the config shifts.
Signed-off-by: Aaron Conole
Acked-by: Panu Matilainen
Acked-by: Helin Zhang
---
v2:
* No change (apart from adding ACKs)
drivers/net/e1000/igb_pf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Tell the compiler to use an unsigned constant for the config shifts.
Signed-off-by: Aaron Conole
Acked-by: Panu Matilainen
Acked-by: Helin Zhang
---
v2:
* No change (apart from adding ACKs)
drivers/net/ixgbe/ixgbe_pf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Silence a compiler warning that this variable may be used uninitialized.
Signed-off-by: Aaron Conole
Acked-by: Helin Zhang
---
v2:
* No change (apart from adding ACK)
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe
Thomas Monjalon writes:
> 2016-03-24 08:54, Panu Matilainen:
>> --- a/drivers/net/e1000/Makefile
>> +++ b/drivers/net/e1000/Makefile
>> @@ -54,6 +54,9 @@ else
>> #
>> CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter
>> CFLAGS_BASE_DRIVER += -Wno-unused-variable
>> +ifeq
The register read/write mphy functions have misleading whitespace around
the `locked` check. This cleanup merely preserves the existing functionality
and suppresses future gcc versions' "misleading indentation" warning.
Suggested-by: Panu Matilainen
Signed-off-by: Aaron Conole
---
v2:
50 matches
Mail list logo
