Re: [PATCH] ci: test stdatomic API

2023-09-29 Thread Aaron Conole
David Marchand writes: > Add some compilation tests with C11 atomics enabled. > The headers check can't be enabled (as gcc and clang don't provide > stdatomic before C++23). > > Signed-off-by: David Marchand > --- Reviewed-by: Aaron Conole

Minutes of Technical Board Meeting, 2023-05-31

2023-10-04 Thread Aaron Conole
Attendees: - Aaron - Bruce - David - Ferruh - Jerin - Kevin - Konstantin - Maxime - Nathan - Patrick - Stephen - Tyler Minutes: - Bruce will be moderator on June 14, 2023 - Call for additional items - Userspace Dublin - CFP - Ready to go. - Awaiting on final TB review, feedback received fr

Re: [PATCH v4] app/test: add support for skipping tests

2023-10-04 Thread Aaron Conole
Patrick Robb writes: > Thanks, this should help greatly going forward in the community lab. > > As it relates to our arm64 unit testing, I will give it a few days (or longer > if needed) for next branches to rebase off of > main and then re-enable arm64 unit testing with the > eal_flags_file_pr

[PATCH v2] common/mlx5: Optimize mlx5 mempool get extmem

2023-10-10 Thread Aaron Conole
From: John Romein This patch reduces the time to allocate and register tens of gigabytes of GPU memory from hours to seconds, by sorting the heap only once instead of for each object in the mempool. Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities") Signed-off-by: John Rom

Re: [PATCH v4 3/7] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Aaron Conole
Bruce Richardson writes: > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > from within the makefiles of our examples, we need to export the PATH > variable with the location of our installed scripts from within our CI > scripts. This matches what is already done for other p

Re: [PATCH] ci: test manuals generation in GHA

2023-10-17 Thread Aaron Conole
David Marchand writes: > Add missing package so manuals are generated as part of the docs check. > > Signed-off-by: David Marchand > --- Good catch! Reviewed-by: Aaron Conole

Re: [PATCH v5 3/9] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Aaron Conole
ne for other paths e.g. the > PKG_CONFIG_PATH variable. > > Signed-off-by: Bruce Richardson > --- Reviewed-by: Aaron Conole

Re: [PATCH] ci: combine static and shared linking build tests

2022-10-20 Thread Aaron Conole
o saves overall time because we would need fewer runners. I think this is a good change. Acked-by: Aaron Conole

Minutes of Technical Board Meeting, 2022-07-13

2023-01-16 Thread Aaron Conole
Members Attending: 6 * Aaron Conole (chair) * Hement Agarwal * Maxime Coquelin * Nathan Southern * Stephen Hemminger * Thomas Monjalon NOTE: The Technical Board meetings take place every second Wednesday on https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are

Re: [PATCH] gpu/cuda: Add missing stdlib include

2023-09-13 Thread Aaron Conole
John Romein writes: > getenv needs stdlib.h to be included. > > Bugzilla ID: 1133 > > Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy") > Signed-off-by: John Romein > --- Hi John, Thanks so much for the contribution. It looks like the patch got corrupted by something. Please chec

Re: [PATCH v4] app/test: add support for skipping tests

2023-09-25 Thread Aaron Conole
; Timeout:0 > > Signed-off-by: Bruce Richardson > Acked-by: Thomas Monjalon > > --- Acked-by: Aaron Conole

Re: [PATCH 0/2] add checks for tests not in a suite

2023-09-26 Thread Aaron Conole
David Marchand writes: > On Tue, Sep 19, 2023 at 10:36 AM Bruce Richardson > wrote: >> >> On Tue, Sep 19, 2023 at 10:29:07AM +0200, David Marchand wrote: >> > On Fri, Sep 15, 2023 at 1:52 PM Bruce Richardson >> > wrote: >> > > >> > > To help ensure that we don't have "orphaned" tests not in any

Re: DPDK patch

2023-09-26 Thread Aaron Conole
John Romein writes: > Dear Elena, Aaron, Hi John, > I hope you had a nice time after the DPDK workshop. > > I was unable to solve the issues with our mailserver to submit a patch > with git sendmail.  So I created a pull request: > https://github.com/DPDK/dpdk/pull/69 > @Elena, could you plea

Re: [PATCH 0/1] make file prefix unit test more resilient

2023-09-26 Thread Aaron Conole
Bruce Richardson writes: > On Sat, Sep 23, 2023 at 10:21:04AM +0200, Thomas Monjalon wrote: >> 22/09/2023 15:23, Bruce Richardson: >> > On Fri, Sep 22, 2023 at 02:57:32PM +0200, Thomas Monjalon wrote: >> > > 20/09/2023 12:09, Bruce Richardson: >> > > > On Wed, Sep 20, 2023 at 12:00:08PM +0200, Da

[PATCH] gpu/cuda: Add missing stdlib include

2023-09-26 Thread Aaron Conole
From: John Romein getenv needs stdlib.h to be included. Bugzilla ID: 1133 Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy") Signed-off-by: John Romein --- NOTE: this is a post of https://github.com/DPDK/dpdk/pull/69 to the mailing list. drivers/gpu/cuda/gdrcopy.c | 2 ++

[PATCH] common/mlx5: Optimize mlx5 mempool get extmem

2023-09-26 Thread Aaron Conole
From: John Romein This patch reduces the time to allocate and register tens of gigabytes of GPU memory from hours to seconds, by sorting the heap only once instead of for each object in the mempool. Fixes: 690b2a8 ("common/mlx5: add mempool registration facilities") Signed-off-by: John Romein

Re: [PATCH 0/2] add checks for tests not in a suite

2023-09-27 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Sep 27, 2023 at 11:31:07AM +0200, David Marchand wrote: >> On Wed, Sep 27, 2023 at 10:27 AM Bruce Richardson >> wrote: >> > On Wed, Sep 27, 2023 at 08:30:05AM +0200, David Marchand wrote: >> > > On Tue, Sep 26,

Re: [dpdk-dev] [dpdk-stable] [v2] test/mempool: fix heap buffer overflow

2021-04-15 Thread Aaron Conole
Olivier Matz writes: > On Tue, Apr 13, 2021 at 01:52:26PM +0200, Thomas Monjalon wrote: >> 13/04/2021 22:05, Wenwu Ma: >> > Amount of allocated memory was not enough for mempool >> > which cause buffer overflow when access fields of mempool >> > private structure in the rte_pktmbuf_priv_size func

Re: [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: >> diff --git a/lib/librte_eal/include/rte_devargs.h >> b/lib/librte_eal/include/rte_devargs.h >> index 296f19324f..134b44a887 100644 >> --- a/lib/librte_eal/include/rte_devargs.h >> +++ b/lib/librte_eal/include/rte_deva

Re: [dpdk-dev] [dpdk-ci] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Aaron Conole
Thomas Monjalon writes: > 19/04/2021 20:06, Tal Shnaiderman: >> > > 2021-04-18 19:04 (UTC+), Tal Shnaiderman: >> > > > > 18/04/2021 19:08, Tal Shnaiderman: >> > > > > > the strncasecmp marco defined in rte_os_shim.h is already >> > > > > > defined in MinGW-w64, as a result the compiler prints

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-20 Thread Aaron Conole
"Dumitrescu, Cristian" writes: >> -Original Message- >> From: Thomas Monjalon >> Sent: Tuesday, April 20, 2021 11:07 AM >> To: Dumitrescu, Cristian >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 20/04/2021 12:04, Dumit

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Aaron Conole
Ali Alnubani writes: > Hi, > >> -Original Message- >> From: dev On Behalf Of Thomas Monjalon >> Sent: Tuesday, April 20, 2021 10:58 PM >> To: Cristian Dumitrescu >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 12/04/202

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Aaron Conole
Ali Alnubani writes: >> -Original Message- >> From: Aaron Conole >> Sent: Wednesday, April 21, 2021 3:57 PM >> To: Ali Alnubani >> Cc: NBU-Contact-Thomas Monjalon ; Cristian >> Dumitrescu ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pi

Re: [dpdk-dev] [dpdk-ci] [RFC] Proposal for allowing rerun of tests

2021-04-21 Thread Aaron Conole
Thomas Monjalon writes: > 13/04/2021 17:04, Bruce Richardson: >> On Tue, Apr 13, 2021 at 04:59:00PM +0200, David Marchand wrote: >> > On Tue, Apr 13, 2021 at 4:47 PM Thomas Monjalon >> > wrote: >> > > >> > > 13/04/2021 15:50, Aaron Conole: &

Re: [dpdk-dev] [PATCH v3 2/7] test: introduce parent testsuite format

2021-04-23 Thread Aaron Conole
> cases that each require different setup, so should be in separate suites. > > The unit test suite struct is modified to hold a pointer to a list of > sub-testsuite pointers, along with the list of testcases as before. > > Signed-off-by: Ciara Power > > --- LGTM Reviewed-by: Aaron Conole

Re: [dpdk-dev] [PATCH v3 2/2] mbuf: better document usage of packet pool initializers

2021-04-27 Thread Aaron Conole
t; > Signed-off-by: Olivier Matz > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares

2021-06-29 Thread Aaron Conole
= NULL; > + return -1; > + } > + return 0; > +} > + > +static ssize_t > +firmware_read_block(struct firmware_read_ctx *ctx, void *buf, size_t count) > +{ > + return archive_read_data(ctx->a, buf, count); > +} > + > +static void > +firm

Re: [PATCH 3/3] ci: use crossbuild-essential-riscv64 for compiling

2022-06-14 Thread Aaron Conole
use the full toolchain install > to enable the C++ test. > > Besides, the user's guide for RISC-V cross-compilation recommends the > use of crossbuild-essential-riscv64. > > Signed-off-by: Stanislaw Kardach > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH 1/6] app/test: refactor of unit test suite runner

2021-03-31 Thread Aaron Conole
Ciara Power writes: > Some small changes were made to the unit test suite runner for > readability and to enable reuse of some of the function in a later patch. > > On test suite setup skip/fail, the loop to count testcases as > skipped/failed has been moved to another function. > This will allow

Re: [dpdk-dev] [PATCH 2/6] test: introduce parent testsuite format

2021-03-31 Thread Aaron Conole
Ciara Power writes: > The current structure for unit testing only allows for running a > test suite with nested test cases. This means all test cases for an > autotest must be in one suite, which is not ideal. > For example, in some cases we may want to run multiple lists of test > cases that eac

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-03-31 Thread Aaron Conole
"Doherty, Declan" writes: > Hey Aaron, > > based on the work you've been doing on the unit test documentation we > would appreciate if you could take a look over this patchset and get > your thoughts. The primary drive here is to make it easier to get a > clear picture of what is being executed i

Re: [dpdk-dev] [PATCH] doc: fix sphinx rtd theme import in GHA

2021-04-01 Thread Aaron Conole
theme when available") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- https://github.com/ovsrobot/dpdk/tree/series_16066 https://github.com/ovsrobot/dpdk/actions/runs/709682570 Acked-by: Aaron Conole > doc/guides/conf.py | 1 - > 1 file changed, 1 deletion

Re: [dpdk-dev] [PATCH v2 1/6] app/test: refactor of unit test suite runner

2021-04-05 Thread Aaron Conole
later > when multiple nested sub-testsuites are being run. > > Signed-off-by: Ciara Power > > --- > v2: > - Added macro to loop testcases in suite. > - Testcase counts added to the test suite structure. > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2 2/6] test: introduce parent testsuite format

2021-04-05 Thread Aaron Conole
Ciara Power writes: > The current structure for unit testing only allows for running a > test suite with nested test cases. This means all test cases for an > autotest must be in one suite, which is not ideal. > For example, in some cases we may want to run multiple lists of test > cases that eac

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-06 Thread Aaron Conole
Thomas Monjalon writes: > 17/03/2021 15:44, Aaron Conole: >> The hugepage test really needs to check multiple things on Linux: >> >> 1. Are hugepages reserved in the system? >> >> 2. Is the hugepage mountpoint available so that we can allocate them? >>

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-06 Thread Aaron Conole
Bruce Richardson writes: > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: >> Thomas Monjalon writes: >> >> > 17/03/2021 15:44, Aaron Conole: >> >> The hugepage test really needs to check multiple things on Linux: >> >>

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-09 Thread Aaron Conole
Ferruh Yigit writes: > On 4/8/2021 9:51 AM, Wei Huang wrote: >> In max10_staging_area_init(), variable "size" from fdt_get_reg() may >> be invalid, it should be checked before assigning to member variable >> "staging_area_size" of structure "intel_max10_device". >> >> Coverity issue: 367480, 3674

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-09 Thread Aaron Conole
Bruce Richardson writes: > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: >> >> Thomas Monjalon writes: >> >> >> >>

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon wrote: >> >> 12/04/2021 15:20, Jerin Jacob Kollanukkaran: >> > http://dpdk.org/git/next/dpdk-next-eventdev >> >> Pulled, thanks. >> >> Note few changes in titles like uppercases for acronyms, >> or "add support" simplifi

[dpdk-dev] [RFC] Proposal for allowing rerun of tests

2021-04-13 Thread Aaron Conole
Greetings, During the various CI pipelines, sometimes a test setup or lab will have an internal failure unrelated to the specific patch. Perhaps 'master' branch (or the associated -next branch) is broken and we cannot get a successful run anyway. Perhaps a network outage occurs during infrastruc

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Aaron Conole
imations > are printed). > > Signed-off-by: Dmitry Kozlyuk > Reviewed-by: Viacheslav Ovsiienko > --- Thanks for making the changes. Acked-by: Aaron Conole > app/test/meson.build| 2 + > app/test/test_malloc_perf.c | 174 >

Re: [PATCH 1/1] ci: restrict concurrency

2022-02-03 Thread Aaron Conole
Thomas Monjalon writes: > Aaron, David, > Please could you review this patch? > Thanks > > 13/01/2022 13:41, Josh Soref: >> On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon wrote: >> >> > Hi, >> > >> > The explanation should be in the patch, not the cover letter. >> > Actually, you don't need a co

Re: [PATCH] ci: remove outdated default reference tag for ABI

2022-02-08 Thread Aaron Conole
uming the UNH/other lab doesn't use this feature of the linux build script, Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH] test/service: fix race in attr check

2021-10-11 Thread Aaron Conole
missing check on rte_service_lcore_may_be_active. > > Fixes: 4d55194d76a4 ("service: add attribute get function") > Fixes: 52bb6be259ff ("test/service: fix race condition on stopping lcore") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Excellent catch. Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v6 3/3] app/test: add allocator performance autotest

2021-10-12 Thread Aaron Conole
Dmitry Kozlyuk writes: > Memory allocator performance is crucial to applications that deal > with large amount of memory or allocate frequently. DPDK allocator > performance is affected by EAL options, API used and, at least, > allocation size. New autotest is intended to be run with different >

Re: [dpdk-dev] [PATCH v3] ci: update machine meson option to platform

2021-10-14 Thread Aaron Conole
ric, which is the most up to date way to > execute the same build which is now present in all DPDK versions the ABI > check verifies. > > Signed-off-by: Juraj Linkeš > --- Acked-by: Aaron Conole Looks like something didn't go well in the UNH environment w.r.t. the windows com

Re: [dpdk-dev] [PATCH v6 3/3] app/test: add allocator performance autotest

2021-10-15 Thread Aaron Conole
Dmitry Kozlyuk writes: >> This isn't really a test, imho. There are no assert()s. How does a >> developer who >> tries to fix a bug in this area know what is acceptable? >> >> Please switch the printf()s to RTE_LOG calls, and add some RTE_TEST_ASSERT >> calls to enforce some time range at the

[dpdk-dev] [PATCH v5] guides: add a guide for developing unit tests

2021-10-15 Thread Aaron Conole
nuous integration platforms so that newer developers can understand how to develop test suites and test cases. Signed-off-by: Aaron Conole Acked-by: Ciara Power Acked-by: Fan Zhang Acked-by: John McNamara --- v0->v1: Added information for TEST_SKIPPED and details about generating

Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list

2021-10-19 Thread Aaron Conole
g on OS) or by passing a --test-args option to meson. > > Example: > $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3" > > Signed-off-by: David Marchand > --- LGTM - the spelling issue flagged seems to be a false positive. Acked-by: Aaron Conole

Re: [PATCH v2 2/2] ci: build some job with ASan

2022-05-10 Thread Aaron Conole
e_autotest in "ASan-safe" list of ut, This is great! Acked-by: Aaron Conole

Re: [PATCH v3 8/8] ci: add RISCV64 cross compilation job

2022-05-12 Thread Aaron Conole
Stanislaw Kardach writes: > Checks cross-compilation using Ubuntu 20.04 x86. > > Signed-off-by: David Marchand > Signed-off-by: Stanislaw Kardach > --- > .ci/linux-build.sh | 4 > .github/workflows/build.yml | 11 ++- > 2 files changed, 14 insertions(+), 1 deletion(-) S

Re: [PATCH v3 8/8] ci: add RISCV64 cross compilation job

2022-05-13 Thread Aaron Conole
Stanisław Kardach writes: > On Thu, 12 May 2022, 17:47 Aaron Conole, wrote: > > Stanislaw Kardach writes: > > > Checks cross-compilation using Ubuntu 20.04 x86. > > > > Signed-off-by: David Marchand > > Signed-off-by: Stanislaw Kardach > >

Re: [dpdk-dev] [PATCH v2] ci: fix aarch64 cross compilation in GHA

2021-10-29 Thread Aaron Conole
ow_bug.cgi?id=697), disable > it. > > Fixes: 5d0b4ffa6964 ("ci: add aarch64 clang cross-compilation Travis builds") > > Signed-off-by: David Marchand > --- > Changes since v1: > - disable common/cnxk compilation Acked-by: Aaron Conole

[dpdk-dev] [NOTICE] "0-day robot" CI system outage

2021-09-27 Thread Aaron Conole
Greetings all, Around September 20th, the hardware running the "0-day Robot" that provides CI testing for some upstream projects suffered a catastrophic failure. This required a lot of internal scrambling to get replacement hardware ready and eventually perform the software migration. The backup

[dpdk-dev] Minutes of Technical Board Meeting, 2021-06-30

2021-07-14 Thread Aaron Conole
Attendees - * Aaron * Bruce * Ferruh * Hemant * Honnappa * Jerin * Kevin * Konstantin * Lincoln Lavioe (UNH representative) * Maxime * Olivier * Stephen * Thomas NOTE: The technical board meets every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK co

[dpdk-dev] [PATCH v4] guides: add a guide for developing unit tests

2021-07-14 Thread Aaron Conole
nuous integration platforms so that newer developers can understand how to develop test suites and test cases. Signed-off-by: Aaron Conole --- v0->v1: Added information for TEST_SKIPPED and details about generating code coverage to help with ideas for writing unit test cases. v1->v2

Re: [dpdk-dev] [PATCH v1] doc: fix CI typo warnings

2021-08-09 Thread Aaron Conole
Ray Kinsella writes: > Fix documentation typos that are generating spurious CI warnings. > > Signed-off-by: Ray Kinsella > --- Looks like there are still a few errors. Ex: ioat: end-before not used anywhere deprecation.rst: 'inplace' should probably be 'in place' deprecation.rst: 'esn' -> pr

Re: [PATCH] ci: add Fedora 35 container in GHA

2021-11-16 Thread Aaron Conole
a ':' in their name, and must be filtered, > > Signed-off-by: David Marchand > --- This is awesome! Acked-by: Aaron Conole

Re: [PATCH v2 1/5] ci: test minimum configuration

2021-11-17 Thread Aaron Conole
since v1: > - dropped target cleanup in test-meson-builds.sh, this will be handled > in a separate series in the future, > - disabled all drivers but mempool/ring and net/null, > required to pass test-null.sh. bus/vdev is explicitly enabled for > Acked-by: Aaron Conole

Re: [PATCH] ci: add Fedora 35 container in GHA

2021-11-18 Thread Aaron Conole
David Marchand writes: > On Tue, Nov 16, 2021 at 3:44 PM Aaron Conole wrote: >> > Build DPDK with Fedora 35 containers. >> > Differences with the Ubuntu GHA vm images: >> > - tasks are run as root in containers, no need for sudo, >> > - compiler must b

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-09 Thread Aaron Conole
Jerin Jacob writes: > On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: >> >> Even though test_interrupts.c can compile on Windows, skip interrupt >> tests for now since majority of eal_interrupt on Windows are stubs. >> Will remove the skip after interrupt being fully enabled on Windows. >> >> Si

Re: [PATCH v2] app/eventdev: add crypto producer mode

2022-01-04 Thread Aaron Conole
Shijith Thotton writes: >>> >> >>> >> In crypto producer mode, producer core enqueues cryptodev with >>> >> software generated crypto ops and worker core dequeues crypto >>> >> completion events from the eventdev. Event crypto metadata used for >>> >> above processing is pre- populated in each cr

Re: [dpdk-dev] [PATCH v5 8/8] ci: add checking of includes to CI builds

2021-01-27 Thread Aaron Conole
Bruce Richardson writes: > For CI builds, turn on the checking of includes. > > Signed-off-by: Bruce Richardson > --- Thanks for the efforts here. Acked-by: Aaron Conole

[dpdk-dev] [RFC] doc: add a guide to describe developing tests

2021-01-27 Thread Aaron Conole
nuous integration platforms so that newer developers can understand how to develop test suites and test cases. Signed-off-by: Aaron Conole --- Submitting as RFC as I'm not sure if this should include making changes to the github actions or travis yml, or the linux-build ci script.

Re: [dpdk-dev] ixgbe and UDP with zero checksum

2021-01-27 Thread Aaron Conole
"Wang, Haiyue" writes: > Hi Paolo, > >> -Original Message- >> From: Paolo Valerio >> Sent: Wednesday, January 27, 2021 21:50 >> To: dev@dpdk.org >> Cc: Guo, Jia ; Wang, Haiyue ; >> Aaron Conole >> >> Subject: ixgbe and U

Re: [dpdk-dev] [RFC] doc: add a guide to describe developing tests

2021-01-27 Thread Aaron Conole
Hi Bruce, Thanks for the review! Responses below. Bruce Richardson writes: > On Wed, Jan 27, 2021 at 10:16:18AM -0500, Aaron Conole wrote: >> The DPDK testing infrastructure includes a comprehensive set of >> libraries, utilities, and CI integrations for developers to tes

Re: [dpdk-dev] [PATCH] test: allow taking test names from commandline

2021-01-29 Thread Aaron Conole
rking with components which have > multiple test suites. > > Signed-off-by: Bruce Richardson > --- LGTM, and I think it can be useful for running specific tests when developers make changes. Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v7 10/10] ci: add checking of includes to CI builds

2021-01-29 Thread Aaron Conole
Bruce Richardson writes: > For CI builds, turn on the checking of includes. > > Signed-off-by: Bruce Richardson > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v6 8/8] ci: add checking of includes to CI builds

2021-01-29 Thread Aaron Conole
ruce Richardson: >> > > > For CI builds, turn on the checking of includes. >> > > > >> > > > Signed-off-by: Bruce Richardson Acked-by: >> > > > Aaron Conole --- .ci/linux-build.sh | 1 + 1 file >> > > > changed, 1 insertion(+) &

Re: [dpdk-dev] [PATCH] ci: ignore APT update failure in GitHub Actions

2021-02-01 Thread Aaron Conole
kB] > Reading package lists... > E: The repository 'https://apt.postgresql.org/pub/repos/apt bionic-pgdg > Release' no longer has a Release file. > Error: Process completed with exit code 100. > """ > > Fixes: 9d620630ea30 ("ci: fix package installation in GitHub Actions") > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

[dpdk-dev] [CI] SPDK compilation failures @ DPDK community lab

2021-02-08 Thread Aaron Conole
Greetings, I've noticed that recently SPDK compilation in the UNH community lab seems to be failing, and I don't see an obvious reason for the failure. The logs haven't been too helpful - it appears that there is a symbol that isn't available when linking. Job details (for example): https://lab.d

[dpdk-dev] [PATCH] guides: add a testing guide for developing tests

2021-02-08 Thread Aaron Conole
nuous integration platforms so that newer developers can understand how to develop test suites and test cases. Signed-off-by: Aaron Conole --- v0: Added information for TEST_SKIPPED and details about generating code coverage to help with ideas for writing unit test cases. doc/guides/contrib

Re: [dpdk-dev] [dpdk-ci] [CI] SPDK compilation failures @ DPDK community lab

2021-02-09 Thread Aaron Conole
e builds performed for latest SPDK and SPDK LTS, against dpdk-main branch > seem to be passing. Would love to hear if > this is what you are seeing on your end too. > > > > Thanks, > > Tomek > > > > From: Lincoln Lavoie > Sent: Monday, February 8, 2021

Re: [dpdk-dev] |FAILURE| pw devtools: add llx format specifier check

2021-02-09 Thread Aaron Conole
0-day Robot writes: > From: ro...@bytheb.org > > Test-Label: travis-robot > Test-Status: FAILURE > > > _travis build: failed_ > Build URL: /build/216558092 Sorry for the noise here. We hooked up some new features for the robot and introduced a misconfiguration. It should be fixed shortly, and

Re: [dpdk-dev] [PATCH] guides: add a testing guide for developing tests

2021-02-09 Thread Aaron Conole
"Kinsella, Ray" writes: > On 08/02/2021 16:52, Aaron Conole wrote: >> The DPDK testing infrastructure includes a comprehensive set of >> libraries, utilities, and CI integrations for developers to test >> their code changes. This isn't well documented, how

[dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-02-10 Thread Aaron Conole
nuous integration platforms so that newer developers can understand how to develop test suites and test cases. Signed-off-by: Aaron Conole --- v0->v1: Added information for TEST_SKIPPED and details about generating code coverage to help with ideas for writing unit test cases. v1->v2

Re: [dpdk-dev] [dpdklab] Re: [dpdk-ci] [CI] SPDK compilation failures @ DPDK community lab

2021-02-11 Thread Aaron Conole
over the first few pipelines to >> make sure everything goes smoothly. >> >> Thanks for the update, >> Brandon >> >> On Tue, Feb 9, 2021 at 10:13 AM Aaron Conole wrote: >> > >> > "Zawadzki, Tomasz" writes: >> > >> > &

Re: [dpdk-dev] [dpdklab] Re: [dpdk-ci] [CI] SPDK compilation failures @ DPDK community lab

2021-02-15 Thread Aaron Conole
#x27;s way to the v21.01.x branch. >> >> @Brandon Lo General question, is there particular reason to disable >> vhost [configure argument '--without-vhost'] in the UNH lab tests >> with SPDK ? >> I don't recall any identified issue and enabling it woul

[dpdk-dev] Build errors due to duplicate version.map entries in librte_power

2021-02-15 Thread Aaron Conole
Greetings, During CI runs, I've noticed lots of failures from the Travis-CI side all related to librte_power/version.map containing some duplicate symbols. It seems commit 4d3892dcd77b ("power: make channel message functions public") made the following hunk: diff --git a/lib/librte_power/version

Re: [dpdk-dev] [RFC PATCH v1 1/2] ci: remove x86 Travis jobs

2021-02-17 Thread Aaron Conole
Thomas Monjalon writes: > 17/02/2021 10:42, Juraj Linkeš: >> Remove x86 jobs for which we don't have Travis credits. Leave arm64 jobs >> for which we do have the credits. > > We are missing some references. I do see that the travis job is still running, and does include the x86 builds as well...

Re: [dpdk-dev] [RFC PATCH v1 0/2] Travis CI jobs update after credits

2021-02-17 Thread Aaron Conole
Ferruh Yigit writes: > On 2/17/2021 9:42 AM, Juraj Linkeš wrote: >> Since Travis added credits we need to make some changes to the Travis >> CI. Arm has a credit agreement with Travis for arm jobs, so remove x86 >> jobs. Also, migrate all arm jobs to the latest environment. >> > > So this is beco

Re: [dpdk-dev] [RFC PATCH v1 1/2] ci: remove x86 Travis jobs

2021-02-17 Thread Aaron Conole
Juraj Linkeš writes: > Remove x86 jobs for which we don't have Travis credits. Leave arm64 jobs > for which we do have the credits. > > Signed-off-by: Juraj Linkeš > --- Individual developers will still derive benefit from those jobs, yes? I thought it was possible to use travis still for indi

Re: [dpdk-dev] [PATCH v2] ci: update arm64 Travis jobs to Graviton2

2021-02-19 Thread Aaron Conole
Juraj Linkeš writes: > Instead of using the older platform, use only the newer Graviton2 > environment in Travis CI. Can you expand on this a bit. Why should we need to use the newer environment? What problems will occur by using the older environment? I'm not against the change, but I don't

Re: [dpdk-dev] [PATCH v2] ci: update arm64 Travis jobs to Graviton2

2021-02-22 Thread Aaron Conole
Juraj Linkeš writes: >> -Original Message- >> From: Aaron Conole >> Sent: Friday, February 19, 2021 2:27 PM >> To: Juraj Linkeš >> Cc: tho...@monjalon.net; david.march...@redhat.com; >> maicolgabr...@hotmail.com; dev@dpdk.org; ruifeng.w...@arm.

Re: [dpdk-dev] Build errors due to duplicate version.map entries in librte_power

2021-02-22 Thread Aaron Conole
David? Anything? > 2. If this is a real failure, should we also use ld.lld in the other clang > jobs? We need to know if this is also an area where the LLVM linker doesn't support the same featureset as GNU. > Thanks, > Juraj > >> -Original Message- >>

Re: [dpdk-dev] [PATCH v3] ci: update arm64 Travis jobs to Graviton2

2021-02-23 Thread Aaron Conole
s hint at resource availability issues in container > environments. The Graviton2 environment is using VMs and these failures > are not observed in it. > > Signed-off-by: Juraj Linkeš > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-03-02 Thread Aaron Conole
Bruce Richardson writes: > On Tue, Mar 02, 2021 at 10:07:26AM +0100, David Marchand wrote: >> On Wed, Feb 10, 2021 at 3:56 PM Aaron Conole wrote: >> > diff --git a/doc/guides/contributing/testing.rst >> > b/doc/guides/contributing/testing.rst >> > new fi

Re: [dpdk-dev] [PATCH v2] ci: catch coredumps

2021-03-02 Thread Aaron Conole
27;visited' - sorry about that. Acked-by: Aaron Conole

Re: [PATCH v3 1/2] net/i40e: replace put function

2023-02-17 Thread Aaron Conole
Morten Brørup writes: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Friday, 17 February 2023 11.05 >> >> On 2/17/2023 7:52 AM, Morten Brørup wrote: >> >> From: Lu, Wenzhuo [mailto:wenzhuo...@intel.com] >> >> Sent: Friday, 17 February 2023 03.03 >> >> >> >> Hi Kamalakshitha, >> >>

Re: [PATCH v3 1/2] net/i40e: replace put function

2023-02-17 Thread Aaron Conole
Ferruh Yigit writes: > On 2/17/2023 7:52 AM, Morten Brørup wrote: >>> From: Lu, Wenzhuo [mailto:wenzhuo...@intel.com] >>> Sent: Friday, 17 February 2023 03.03 >>> >>> Hi Kamalakshitha, >>> From: Kamalakshitha Aligeri Sent: Tuesday, February 14, 2023 2:18 AM Integrated zero-co

Re: [PATCH v3] build: announce requirement for C11

2023-05-19 Thread Aaron Conole
st > > V2: > - add requirement for stdatomics > - fix sphinx formatting > --- > doc/guides/rel_notes/deprecation.rst | 18 ++++++++++ > 1 file changed, 18 insertions(+) Acked-by: Aaron Conole Per the meeting, I guess we're still waiting on the patches that int

Re: [PATCH 1/2] ci: bump tested distributions in GHA

2024-02-08 Thread Aaron Conole
> Install additional dependencies like ipsec-mb, isal and other > libbpf/libxdp devel packages. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH 2/2] ci: update versions of actions in GHA

2024-02-08 Thread Aaron Conole
ng-from-node-16-to-node-20/ > > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Aaron Conole
Ferruh Yigit writes: > On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: >> When rte_log.h was moved to a new directory, the include path was not >> updated for the generated C code produced by the pipeline library, >> which results in build failure for this code. >> >> Fixes: 09ce41310930 ("log:

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-02-20 Thread Aaron Conole
Patrick Robb writes: > Hi all, > > I want to poll the CI group and dev community about a proposed feature > addition to the CI retest request framework. > Currently, you can respond to a patchseries or patch email, requesting a > retest like so: > > Recheck-request: iol-compile-amd64-testing, i

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > We only need to consult the timer value when the driver waits for a > timeout, so skip making the call to get the current timer/TSC value if > the timeout is zero, as no wait will ever be done. > > Signed-off-by: Bruce Richardson > --- Recheck-request: github-robot

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > We only need to consult the timer value when the driver waits for a > timeout, so skip making the call to get the current timer/TSC value if > the timeout is zero, as no wait will ever be done. > > Signed-off-by: Bruce Richardson > --- Had a bad config value - retryin

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Dec 13, 2023 at 11:50:46AM -0500, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > We only need to consult the timer value when the driver waits for a >> > timeout, so skip making the call to get the current timer/TSC

[CI] Github Robot - Recheck support

2023-12-14 Thread Aaron Conole
Greetings DPDK Developers, The UNH IOL, and the DPDK CI community at large, have developed a mechanism to request a test recheck for failures. This allows patch authors or maintainers who suspect that a failing test is really a byproduct of something unrelated (flaky test, network issue, etc) to

Re: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Aaron Conole
Morten Brørup writes: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Wednesday, 10 January 2024 17.58 >> >> The last version of 4.14 kernel was just released (4.14.336), >> and it is now end of life. Update the DPDK kernel minimum version >> to the next LTS kernel versio

  1   2   3   4   5   6   7   8   9   10   >