Re: [PATCH] mempool: add cache guard to per-lcore debug statistics

2023-09-29 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH] net/sfc: support packet replay in transfer flows

2023-09-29 Thread Andrew Rybchenko
-off-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH v13 0/5] support error handling mode

2022-10-17 Thread Andrew Rybchenko
On 10/13/22 15:42, Chengwen Feng wrote: This patchset introduce error handling mode concept, the supported modes are as follows: 1) PASSIVE: passive error handling, after the PMD detect that a reset is required, the PMD reports RTE_ETH_EVENT_INTR_RESET event, and application invoke rte_eth_dev_r

Re: [PATCH] app/testpmd: fix slave port reset action

2022-10-17 Thread Andrew Rybchenko
On 10/13/22 20:42, Singh, Aman Deep wrote: On 10/12/2022 1:13 PM, Qiming Yang wrote: As stop action has been forbidden in secondary process, so the reset action should also not be allowed. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang

Re: [PATCH] app/testpmd: fix incorrect flow arguments name

2022-10-17 Thread Andrew Rybchenko
On 10/11/22 09:55, Ori Kam wrote: -Original Message- From: Singh, Aman Deep Sent: Thursday, 6 October 2022 10:59 On 9/30/2022 5:09 PM, Suanming Mou wrote: There should be no spaces in flow command arguments name. This commit removes incorrect arguments name in queue based table te

Re: [PATCH v3] app/testpmd: fix incorrect queues state of secondary process

2022-10-17 Thread Andrew Rybchenko
On 9/13/22 04:26, lihuisong (C) wrote: 在 2022/9/10 17:21, Zhang, Peng1X 写道: -Original Message- From: lihuisong (C) Sent: Wednesday, September 7, 2022 9:53 AM To: Zhang, Peng1X ; dev@dpdk.org Cc: andrew.rybche...@oktetlabs.ru; Singh, Aman Deep ; Zhang, Yuying ; sta...@dpdk.org Subject

Re: [PATCH V3] net/bonding: add link speeds configuration

2022-10-17 Thread Andrew Rybchenko
On 9/25/22 13:35, Chas Williams wrote: Thanks for making the changes! Signed-off-by: 3ch...@gmail.com Thanks above sentence into account I treat it as: Acked-by: Chas Williams <3ch...@gmail.com> On 9/21/22 21:33, Huisong Li wrote: This patch adds link speeds configuration. ---   -v3: add

Re: [PATCH v2] net/bonding: fix error in bonding mode 4 with dedicated queues enabled

2022-10-17 Thread Andrew Rybchenko
On 10/15/22 18:28, Chas Williams wrote: Thanks for making the change, IMHO this is much clearer. Signed-off-by: Chas Williams <3ch...@gmail.com> Taking above sentence into account I treat it as: Acked-by: Chas Williams <3ch...@gmail.com> On 9/29/22 00:05, Usman Tanveer wrote: when dedicate

Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD

2022-10-17 Thread Andrew Rybchenko
to PMD. By default it’s disabled. Signed-off-by: Hanumanth Pothula Acked-by: Andrew Rybchenko v3: - Updated run_app.rst with the new command line argument, nic-to-pmd-rx-metadata. - Updated commit text. v2: - taken cared alignment issues - renamed command line argument from rx-metadata to nic

Re: [PATCH] app/testpmd: remove useless check

2022-10-17 Thread Andrew Rybchenko
On 10/14/22 12:52, Wang, YuanX wrote: Hi Singh, -Original Message- From: Singh, Aman Deep Sent: Friday, October 14, 2022 5:37 PM To: Wang, YuanX ; Zhang, Yuying Cc: dev@dpdk.org; Ding, Xuan ; Tang, Yaqi Subject: Re: [PATCH] app/testpmd: remove useless check Thanks for the patch Yuan

Re: [PATCH] net/bonding: fix descriptor limit reporting

2022-10-17 Thread Andrew Rybchenko
of descriptor limits") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_pmd.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/

Re: [PATCH] net/bonding: fix flow flush order on bonded device close

2022-10-17 Thread Andrew Rybchenko
-ordering the steps accordingly. Fixes: 49dad9028e2a ("net/bonding: support flow API") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_pmd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/n

Re: [PATCH] net/bonding: make bonded device configure method re-entrant

2022-10-17 Thread Andrew Rybchenko
the user sees warnings which say that back-end devices have already been harnessed. Re-factor the code to have cleanup before each (re-)configure. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_pmd.c | 27 ++ 1 file changed

Re: [PATCH] net/bonding: fix descriptor limit reporting

2022-10-17 Thread Andrew Rybchenko
On 10/17/22 15:40, Chas Williams wrote: On 10/17/22 04:40, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:19, Ivan Malov wrote: Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks reporting of &q

Re: [PATCH] net/bonding: make bonded device configure method re-entrant

2022-10-17 Thread Andrew Rybchenko
On 10/17/22 15:32, Chas Williams wrote: This appears to be correct. A minor comment inline. On 10/17/22 04:42, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:24, Ivan Malov wrote: According to the documentation, rte_eth_dev_configure

[PATCH 0/2] app/testpmd: support TCP TSO in Tx only mode

2022-10-17 Thread Andrew Rybchenko
Add command-line option to generate TSO packets with specified MSS in txonly mode. I'm not sure that it is a good idea to enable TSO offload automaticaly when the options is specified, but it is convenient. Andrew Rybchenko (2): app/testpmd: prepare to support TCP in Tx only mode app/te

[PATCH 1/2] app/testpmd: prepare to support TCP in Tx only mode

2022-10-17 Thread Andrew Rybchenko
This is useful for the incoming support of TCP TSO in Tx only mode. Signed-off-by: Georgiy Levashov Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd/parameters.c | 6 +-- app/test-pmd/testpmd.h| 4 +- app/test-pmd/txonly.c | 98

[PATCH 2/2] app/testpmd: support TCP TSO in Tx only mode

2022-10-17 Thread Andrew Rybchenko
Add '--txonly-tso-mss=N' option that enables TSO offload and generates packets with specified MSS in txonly mode. Signed-off-by: Georgiy Levashov Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd/parameters.c | 10 + app/test-pmd

Re: [PATCH] net/bonding: make bonded device configure method re-entrant

2022-10-18 Thread Andrew Rybchenko
Ivan, could you rebase the patch, please, and send a new version. Thanks, Andrew. On 10/18/22 13:34, Chas Williams wrote: On 10/17/22 10:10, Andrew Rybchenko wrote: On 10/17/22 15:32, Chas Williams wrote: This appears to be correct. A minor comment inline. On 10/17/22 04:42, Andrew

Re: [PATCH v2] net/bonding: make bonded device configure method re-entrant

2022-10-19 Thread Andrew Rybchenko
been harnessed. Re-factor the code to have cleanup before each (re-)configure. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Acked-by: Chas Williams <3ch...@gmail.com> Applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/bonding: fix flow flush order on bonded device close

2022-10-19 Thread Andrew Rybchenko
On 10/17/22 15:34, Chas Williams wrote: This appears to be correct, but it needs to be coordinated with the proposed changes in net/bonding: make bonded device configure method re-entrant Ivan, could you comment and send rebased v2 version anyway. On 10/17/22 04:41, Andrew Rybchenko wrote

Re: [PATCH v2] net/bonding: fix flow flush order on bonded device close

2022-10-19 Thread Andrew Rybchenko
nding: support flow API") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Applied to dpdk-next-net/main, thanks.

Re: [PATCH v5] net/bonding: call Tx prepare before Tx burst

2022-10-20 Thread Andrew Rybchenko
On 10/15/22 18:26, Chas Williams wrote: On 10/11/22 09:20, Chengwen Feng wrote: Normally, to use the HW offloads capability (e.g. checksum and TSO) in the Tx direction, the application needs to call rte_eth_tx_prepare() to do some adjustment with the packets before sending them. But the tx_prepa

Re: [PATCH] app/testpmd: remove jumbo offload related code

2022-10-20 Thread Andrew Rybchenko
") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Reviewed-by: Andrew Rybchenko Applied to dpdk-next-net/main, thanks.

Re: [PATCH v9 01/14] common/idpf: introduce common library

2022-10-20 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Introduce common library for IDPF (Infrastructure Data Path Function) PMD. Also add OS specific implementation about some MACRO definitions and small functions which are specific for DPDK. Common drivers are required when different class drivers need to sh

Re: [PATCH v9 02/14] net/idpf: add support for device initialization

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Support device init and add the following dev ops skeleton: - dev_configure - dev_start - dev_stop - dev_close Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo --- MAINTAINERS

Re: [PATCH v9 03/14] net/idpf: add queue setup and release in single queue model

2022-10-21 Thread Andrew Rybchenko
Just top level review for the rest of patches starting from this one. On 10/21/22 08:18, Junfeng Guo wrote: Add support for queue operations in single queue model: - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release In the single queue model, the same descriptor queu

Re: [PATCH v9 02/14] net/idpf: add support for device initialization

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 10:39, Andrew Rybchenko wrote: On 10/21/22 08:18, Junfeng Guo wrote: Support device init and add the following dev ops skeleton:   - dev_configure   - dev_start One more question: are you sure that you can start without queues setup?   - dev_stop   - dev_close Signed-off-by

Re: [PATCH v9 05/14] net/idpf: add support for queue start and stop

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Add support for queue operations: - rx_queue_start - rx_queue_stop - tx_queue_start - tx_queue_stop Qeueues start/stop are required for deferred start. So, before the patch device start must simply start all setup queues which should reject deferred

Re: [PATCH v9 06/14] net/idpf: add support for device information get

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Add dev ops dev_infos_get. You can't test neither queues setup nor configure nor start before the patch since ethdev layer uses rte_eth_dev_info_get() and fails if it is not supported. So, previous patches are not actually tested since patches order is wro

Re: [PATCH v9 07/14] net/idpf: add support for packet type get

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Add dev ops dev_supported_ptypes_get. It is nice, but I don't see code on datapath which actually provides the packet type information. Basically just after the patch you can't pretend that it is actually supported since there is no datapath yet. Also it do

Re: [PATCH v9 09/14] net/idpf: add support for Rx/Tx offloading

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Add Rx/Tx offloading support, including TSO and CHKSUM. Typically code path for Rx and Tx offload are absolutely different. So, I'm wondering why both are implemented in one patch. If they are really independent, please, split it into Rx and Tx patches to m

Re: [PATCH v9 10/14] net/idpf: add support for RSS

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 08:18, Junfeng Guo wrote: Add RSS support. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 123 - drivers/net/idpf/idpf_ethdev.h | 26 +++ drivers/net/idpf/idpf_rxtx.c | 27 drivers/net

Re: [PATCH v9 01/14] common/idpf: introduce common library

2022-10-21 Thread Andrew Rybchenko
On 10/21/22 15:35, Xing, Beilei wrote: -Original Message- From: Andrew Rybchenko Sent: Friday, October 21, 2022 2:40 PM To: Guo, Junfeng ; Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Wang, Xiao W Subject: Re: [PATCH v9 01/14] common/idpf: introduce common library

Re: [PATCH v9 02/14] net/idpf: add support for device initialization

2022-10-25 Thread Andrew Rybchenko
On 10/21/22 15:41, Zhang, Qi Z wrote: Hi Andrew: -Original Message- From: Andrew Rybchenko Sent: Friday, October 21, 2022 3:48 PM To: Guo, Junfeng ; Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Li, Xiaoyun ; Wang, Xiao W Subject: Re: [PATCH v9 02/14] net/idpf: add

Re: [PATCH v11 02/18] net/idpf: add support for device initialization

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo [snip] diff --git a/doc/guides/nics/features

Re: [PATCH v11 03/18] net/idpf: add Tx queue setup

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Add support for tx_queue_setup ops. In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. In the split queue model, "RX buffer queues" are used to pass descriptor b

Re: [PATCH v11 05/18] net/idpf: add support for device start and stop

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 89 ++ drivers/net/idpf/idpf_ethdev.h | 5 ++ 2 file

Re: [PATCH v11 09/18] net/idpf: add support for packet type get

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Add dev ops dev_supported_ptypes_get. Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo Again, the patch should go after datapath implementation to make it reviewable. [snip] diff --git a/doc/guides/nics/features/idpf.ini b/doc/guides/nics/features

Re: [PATCH v11 15/18] net/idpf: add support for Rx offloading

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini |

Re: [PATCH v11 12/18] net/idpf: add support for basic Tx datapath

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo [snip] +/* TX prep functions */ +uint16_t +idpf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx

Re: [PATCH v11 16/18] net/idpf: add support for Tx offloading

2022-10-25 Thread Andrew Rybchenko
On 10/24/22 16:12, Junfeng Guo wrote: Add Tx offloading support: - support TSO Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo [snip] diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index 143c8b69f3..8f82cf1b59 100644 --- a/driver

Re: [PATCH v3 1/3] ethdev: add strict queue to pre-configuration flow hints

2022-10-26 Thread Andrew Rybchenko
in more optimized way then A because resource could be isolated and access based on queue, without lock, for example. This patch add flag about above situation and could be extended to cover more situations. Signed-off-by: Michael Baum Acked-by: Ori Kam Acked-by: Andrew Rybchenko

Re: [PATCH v3 2/3] ethdev: add queue-based API to report aged flow rules

2022-10-26 Thread Andrew Rybchenko
meter will be ignored. Signed-off-by: Michael Baum Acked-by: Ori Kam Few minor notes below, other than that Acked-by: Andrew Rybchenko [snip] diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index a8b99c8c19..8e21b2a5b7 100644 --- a/doc/g

Re: [PATCH v3 3/3] ethdev: add structure for indirect AGE update

2022-10-26 Thread Andrew Rybchenko
that Acked-by: Andrew Rybchenko diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 565868aeea..1ce0277e65 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst

Re: [PATCH] mempool: cache align mempool cache objects

2022-10-26 Thread Andrew Rybchenko
lines touched, incl. line0 for len. Credits go to Olivier Matz for the nice ASCII graphics. Signed-off-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 0/3] ethdev: AGE action preparation

2022-10-28 Thread Andrew Rybchenko
On 10/27/22 00:49, Michael Baum wrote: RFC's: https://patchwork.dpdk.org/project/dpdk/patch/7a45693f478b1b721b4e05131141b526185a175c.1654063912.git.jack...@nvidia.com/ https://patchwork.dpdk.org/project/dpdk/patch/608febf8d5d3c434a1eddb2e56f425ebbd6ff0b4.1654063912.git.jack...@nvidia.com/ v2: -

Re: [PATCH v11 02/18] net/idpf: add support for device initialization

2022-10-28 Thread Andrew Rybchenko
On 10/25/22 11:57, Andrew Rybchenko wrote: On 10/24/22 16:12, Junfeng Guo wrote: Support device init and add the following dev ops:   - dev_configure   - dev_close   - dev_infos_get Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo

Re: [PATCH v14 02/18] net/idpf: add support for device initialization

2022-10-28 Thread Andrew Rybchenko
On 10/27/22 10:47, Junfeng Guo wrote: Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo [snip] +static int

Re: [PATCH v14 05/18] net/idpf: add support for device start and stop

2022-10-28 Thread Andrew Rybchenko
On 10/27/22 10:47, Junfeng Guo wrote: Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo [snip] @@ -284,6 +305,40 @@ idpf_dev_configure(struct rte_eth_dev *dev) return 0; } +static int +idpf_dev_st

Re: [PATCH v14 06/18] net/idpf: add support for queue start

2022-10-28 Thread Andrew Rybchenko
On 10/27/22 10:47, Junfeng Guo wrote: Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo [snip] +#define IDPF_RX_BUF_STRIDE 64 +int +idpf_vc_config_rxqs(struct idpf_vport *vpor

DPDK main build is broken for me in net/mlx5 if I disable common/mlx5

2022-10-29 Thread Andrew Rybchenko
Hi, DPDK main build is broken for me in net/mlx5 if I disable common/mlx5 ../src/drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config". It worked for me before and net/mlx5 is not built since common driver is missing. Andrew.

Re: [PATCH v15 00/18] add support for idpf PMD in DPDK

2022-10-29 Thread Andrew Rybchenko
On 10/29/22 06:27, beilei.x...@intel.com wrote: From: Beilei Xing This patchset introduced the idpf (Infrastructure Data Path Function) PMD in DPDK for Intel® IPU E2000 (Device ID: 0x1452). The Intel® IPU E2000 targets to deliver high performance under real workloads with security and isolati

Re: [PATCH 0/2] fix build disabling common/mlx5

2022-10-30 Thread Andrew Rybchenko
| 4 drivers/net/mlx5/meson.build| 8 +--- 5 files changed, 11 insertions(+), 9 deletions(-) Many thanks, it solves my build problem: Series-tested-by: Andrew Rybchenko

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-17 Thread Andrew Rybchenko
On 11/14/22 14:59, Rongwei Liu wrote: In case flow rules match only one kind of traffic in a flow table, then optimization can be done via allocation of this table. Such optimization is possible only if the application gives a hint about its usage of the table during initial configuration. The t

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-17 Thread Andrew Rybchenko
On 1/17/23 18:13, Ferruh Yigit wrote: On 11/14/2022 11:59 AM, Rongwei Liu wrote: In case flow rules match only one kind of traffic in a flow table, then optimization can be done via allocation of this table. Such optimization is possible only if the application gives a hint about its usage of th

Re: [PATCH v6 1/2] ethdev: add query_update sync and async function calls

2023-01-20 Thread Andrew Rybchenko
On 1/19/23 19:47, Gregory Etelson wrote: Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When t

Re: [PATCH v6 2/2] ethdev: add quota flow action and item

2023-01-20 Thread Andrew Rybchenko
On 1/19/23 19:47, Gregory Etelson wrote: Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules:

Re: [PATCH v2 01/11] ethdev: add flex item modify field support

2023-01-20 Thread Andrew Rybchenko
On 1/19/23 07:58, Rongwei Liu wrote: Add flex item as modify field destination. Add "struct rte_flow_item_flex_handle *flex_handle" into "struct rte_flow_action_modify_data" as union with existed "level" member. This new member is dedicated for modifying flex item. Add flex item modify field cmd

Re: [PATCH v2 1/8] ethdev: add IPv6 routing extension header definition

2023-01-20 Thread Andrew Rybchenko
On 1/19/23 06:11, Rongwei Liu wrote: Add IPv6 routing extension header definition and no TLV support for now. At rte_flow layer, there are new items defined for matching type/nexthdr/segments_left field. Add command line support for IPv6 routing extension header matching: type/nexthdr/segment_l

Re: [PATCH v6 1/2] ethdev: add query_update sync and async function calls

2023-01-20 Thread Andrew Rybchenko
On 1/20/23 13:46, Gregory Etelson wrote: and it's async version `rte_flow_async_action_handle_query_update` to atomically query and update flow action. Sorry, may be I'm missing something, but after reading previous discussion I have a feeling that update could be queried data dependent. Howeve

Re: [RFC] ethdev: sharing indirect actions between ports

2023-01-20 Thread Andrew Rybchenko
On 1/18/23 19:37, Slava Ovsiienko wrote: -Original Message- From: Thomas Monjalon Sent: Wednesday, January 18, 2023 6:22 PM To: Slava Ovsiienko ; Ori Kam Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh ; andrew.rybche...@oktetlabs.ru; ivan.ma...@oktetlabs.ru; ferruh.yi...@amd.com Su

Re: [PATCH] net/sfc: export pick transfer proxy callback to representors

2023-01-30 Thread Andrew Rybchenko
On 1/31/23 10:24, Ivan Malov wrote: Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfe

Re: [PATCH v2] net/sfc: export pick transfer proxy callback to representors

2023-01-31 Thread Andrew Rybchenko
sfer proxy port callback") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Viacheslav Galaktionov No capital letters in E-mail address, please. Reviewed-by: Andrew Rybchenko

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-31 Thread Andrew Rybchenko
On 2/1/23 09:10, Ivan Malov wrote: Hello everyone, Since making automatic, or implicit, offload decisions does not belong in testpmd responsibility domain, it should be safer to avoid calling the "negotiate metadata delivery" API with some default selection unless the user asks to do so explicit

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-01-31 Thread Andrew Rybchenko
On 2/1/23 01:55, Thomas Monjalon wrote: 31/01/2023 19:14, Jerin Jacob: On Wed, Jan 18, 2023 at 9:15 PM Rongwei Liu wrote: When a DPDK application must be upgraded, the traffic downtime should be shortened as much as possible. During the migration time, the old application may stay alive while

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-01-31 Thread Andrew Rybchenko
On 1/18/23 18:44, Rongwei Liu wrote: When a DPDK application must be upgraded, the traffic downtime should be shortened as much as possible. During the migration time, the old application may stay alive while the new application is starting and being configured. In order to optimize the switch t

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 11:27, Thomas Monjalon wrote: 01/02/2023 08:52, Andrew Rybchenko: On 1/18/23 18:44, Rongwei Liu wrote: + * When configuring the device from a standby process, + * it has no effect except for below situations: + * - traffic not handled by the active process configuration + * - no

Re: [PATCH v2 1/2] ethdev: add PHY affinity match item

2023-02-01 Thread Andrew Rybchenko
On 1/30/23 20:00, Jiawei Wang wrote: For the multiple hardware ports connect to a single DPDK port (mhpsdp), Sorry, what is mhpsdp? currently, there is no information to indicate the packet belongs to which hardware port. This patch introduces a new phy affinity item in rte flow API, and "

Re: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-01 Thread Andrew Rybchenko
On 1/30/23 20:00, Jiawei Wang wrote: For the multiple hardware ports connect to a single DPDK port (mhpsdp), the previous patch introduces the new rte flow item to match the phy affinity of the received packets. This patch adds the tx_phy_affinity setting in Tx queue API, the affinity "This pa

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 12:05, Thomas Monjalon wrote: 01/02/2023 10:00, Ori Kam: Hi all, Sorry for jumping in late, -Original Message- From: Jerin Jacob Sent: Wednesday, 1 February 2023 10:53 On Wed, Feb 1, 2023 at 12:46 PM Andrew Rybchenko wrote: On 2/1/23 09:10, Ivan Malov wrote: Hello

Re: [PATCH v4 2/3] ethdev: add modify IPv6 protocol field

2023-02-01 Thread Andrew Rybchenko
On 1/31/23 12:36, Rongwei Liu wrote: Add IPv6 protocol modify field definition. Add new modify field destination type string: "ipv6_proto". Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Andrew Rybchenko

Re: [PATCH v4 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Andrew Rybchenko
On 1/31/23 12:36, Rongwei Liu wrote: Add IPv6 routing extension header definition and no TLV support for now. At rte_flow layer, there are new items defined for matching type/nexthdr/segments_left field. Add command line support for IPv6 routing extension header matching: type/nexthdr/segment_l

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 12:14, Jerin Jacob wrote: On Wed, Feb 1, 2023 at 2:37 PM Andrew Rybchenko wrote: On 2/1/23 12:05, Thomas Monjalon wrote: 01/02/2023 10:00, Ori Kam: Hi all, Sorry for jumping in late, -Original Message- From: Jerin Jacob Sent: Wednesday, 1 February 2023 10:53 On Wed

Re: [PATCH v4 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 12:27, Rongwei Liu wrote: HI Andrew: BR Rongwei -Original Message- From: Andrew Rybchenko Sent: Wednesday, February 1, 2023 17:21 To: Rongwei Liu ; dev@dpdk.org; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: Raslan Darawsheh ; Aman

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Andrew Rybchenko
On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08:28, Andrew Rybchenko: On 11/14/22 14:59, Rongwei Liu wrote: In case flow rules match only one kind of traffic in a flow table, then optimization can be done via allocation of this table. Such optimization is possible only if the

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 13:48, Jerin Jacob wrote: On Wed, Feb 1, 2023 at 2:59 PM Andrew Rybchenko wrote: On 2/1/23 12:14, Jerin Jacob wrote: On Wed, Feb 1, 2023 at 2:37 PM Andrew Rybchenko wrote: On 2/1/23 12:05, Thomas Monjalon wrote: 01/02/2023 10:00, Ori Kam: Hi all, Sorry for jumping in late

Re: [PATCH v6 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Andrew Rybchenko
On 1/20/23 19:50, Gregory Etelson wrote: Hello Andrew, [] On 1/20/23 13:46, Gregory Etelson wrote: and it's async version `rte_flow_async_action_handle_query_update` to atomically query and update flow action. Sorry, may be I'm missing something, but after reading previous discussion I have

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 13:58, Thomas Monjalon wrote: 01/02/2023 11:17, Andrew Rybchenko: On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08:28, Andrew Rybchenko: On 11/14/22 14:59, Rongwei Liu wrote: In case flow rules match only one kind of traffic in a flow table, then optimization can be done via

Re: [PATCH v7 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Andrew Rybchenko
On 1/24/23 12:37, Gregory Etelson wrote: Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When t

Re: [PATCH v7 2/2] ethdev: add quota flow action and item

2023-02-01 Thread Andrew Rybchenko
On 1/24/23 12:37, Gregory Etelson wrote: Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules:

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 14:22, Ori Kam wrote: Hi Please also see my previous mail. -Original Message- From: Andrew Rybchenko Sent: Wednesday, 1 February 2023 13:11 On 2/1/23 13:58, Thomas Monjalon wrote: 01/02/2023 11:17, Andrew Rybchenko: On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 14:18, Thomas Monjalon wrote: 01/02/2023 12:10, Andrew Rybchenko: On 2/1/23 13:58, Thomas Monjalon wrote: 01/02/2023 11:17, Andrew Rybchenko: On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08:28, Andrew Rybchenko: On 11/14/22 14:59, Rongwei Liu wrote: In case flow rules

Re: [PATCH v5 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Andrew Rybchenko
/segment_list. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Andrew Rybchenko

Re: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 14:35, Rongwei Liu wrote: Add IPv6 protocol modify field definition. Add new modify field destination type string: "ipv6_proto". Signed-off-by: Rongwei Liu Acked-by: Ori Kam I've already acked it: Acked-by: Andrew Rybchenko

Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
query_update is bad for summary, consider something like ethdev: add query and update sync and async API On 2/1/23 18:16, Gregory Etelson wrote: Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state applic

Re: [PATCH v8 2/2] ethdev: add quota flow action and item

2023-02-02 Thread Andrew Rybchenko
create a rule with quota action to mark flow and match on the mark with quota item in following flow rule. Signed-off-by: Gregory Etelson Acked-by: Ori Kam Acked-by: Andrew Rybchenko

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-02 Thread Andrew Rybchenko
On 2/1/23 16:48, Thomas Monjalon wrote: 01/02/2023 12:38, Andrew Rybchenko: On 2/1/23 14:18, Thomas Monjalon wrote: 01/02/2023 12:10, Andrew Rybchenko: On 2/1/23 13:58, Thomas Monjalon wrote: 01/02/2023 11:17, Andrew Rybchenko: On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08:28

Re: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-02 Thread Andrew Rybchenko
On 2/1/23 18:50, Jiawei(Jonny) Wang wrote: -Original Message- From: Andrew Rybchenko Subject: Re: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API On 1/30/23 20:00, Jiawei Wang wrote: Adds the new tx_phy_affinity field into the padding hole of rte_eth_txconf

Re: [PATCH v5 1/8] ethdev: use Ethernet protocol struct for flow matching

2023-02-02 Thread Andrew Rybchenko
flow items. The remaining protocols to clean up are listed for future work in the deprecation list. Some protocols are not even defined in the directory net yet. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [PATCH v5 3/8] ethdev: use VXLAN protocol struct for flow matching

2023-02-02 Thread Andrew Rybchenko
names. The VXLAN headers (including VXLAN-GPE) are used in apps and drivers instead of the redundant fields in the flow items. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [PATCH v5 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-02 Thread Andrew Rybchenko
members are used in apps and drivers instead of the redundant fields in the flow items. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [PATCH v5 5/8] ethdev: use GTP protocol struct for flow matching

2023-02-02 Thread Andrew Rybchenko
members are used in apps and drivers instead of the redundant fields in the flow items. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [PATCH v5 6/8] ethdev: use ARP protocol struct for flow matching

2023-02-02 Thread Andrew Rybchenko
members are used in testpmd instead of the redundant fields in the flow items. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [PATCH v5 7/8] doc: fix description of L2TPV2 flow item

2023-02-02 Thread Andrew Rybchenko
cotol") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [PATCH v5 8/8] net: mark all big endian types

2023-02-02 Thread Andrew Rybchenko
, all types are explicitly marked as big endian fields. Signed-off-by: Thomas Monjalon One nit below, Acked-by: Andrew Rybchenko diff --git a/lib/net/rte_arp.h b/lib/net/rte_arp.h index 076c8ab314ee..151e6c641fc5 100644 --- a/lib/net/rte_arp.h +++ b/lib/net/rte_arp.h @@ -23,28 +23,28 @@ extern

Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 13:24, Gregory Etelson wrote: On 2/1/23 18:16, Gregory Etelson wrote: + ops = rte_flow_ops_get(port_id, error); + if (!ops || !ops->action_handle_query_update) + return -ENOTSUP; May be it makes sense to use single-operation callbacks if another operation input is

Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 13:44, Gregory Etelson wrote: Hello Andrew, [] On 2/2/23 13:24, Gregory Etelson wrote: On 2/1/23 18:16, Gregory Etelson wrote: + ops = rte_flow_ops_get(port_id, error); + if (!ops || !ops->action_handle_query_update) + return -ENOTSUP; May be it makes sense to

Re: [PATCH v2 1/4] ethdev: add template table insertion type

2023-02-02 Thread Andrew Rybchenko
On 1/27/23 02:27, Alexander Kozyrev wrote: Allow user to specify insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted flow rules into a template table. Flow rules can be inserted by calculating the hash value for th

Re: [PATCH v9 1/2] ethdev: add query and update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 14:54, Gregory Etelson wrote: diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 7d0c24366c..4554c8f021 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1883,3 +1883,85 @@ rte_flow_async_action_handle_query(uint16_t port_id,

  1   2   3   4   5   6   7   8   9   10   >