On Mon, Oct 23, 2023 at 11:40:14AM +, Srikanth Yalavarthi wrote:
> > -Original Message-
> > From: Bruce Richardson
> > Sent: 23 October 2023 14:56
> > To: Srikanth Yalavarthi
> > Cc: Aaron Conole ; Igor Russkikh
> > ; David Marchand ;
> > de
On Mon, Oct 23, 2023 at 12:46:59PM +, Srikanth Yalavarthi wrote:
> > -Original Message-
> > From: Bruce Richardson
> > Sent: 23 October 2023 17:24
> > To: Srikanth Yalavarthi
> > Cc: Aaron Conole ; Igor Russkikh
> > ; David Marchand ;
> > de
On Mon, Oct 23, 2023 at 02:00:33PM +0100, Bruce Richardson wrote:
> On Mon, Oct 23, 2023 at 12:46:59PM +, Srikanth Yalavarthi wrote:
> > > -Original Message-
> > > From: Bruce Richardson
> > > Sent: 23 October 2023 17:24
> > > To: Srikanth Ya
nd eliminate their boilerplate
*** SUBJECT HERE ***
*** BLURB HERE ***
Bruce Richardson (9):
doc/prog_guide: new chapter on cmdline library
buildtools: script to generate cmdline boilerplate
ci: allow use of DPDK tools when building examples
examples/simple_mp: auto-generate cmdline boilerpla
using the library.
Signed-off-by: Bruce Richardson
---
app/test/commands.c | 2 +
doc/guides/prog_guide/cmdline.rst | 337 ++
doc/guides/prog_guide/index.rst | 1 +
3 files changed, 340 insertions(+)
create mode 100644 doc/guides/prog_guide
be rewritten at any future point to add more
commands, while the C file can be kept as-is and extended by the user
with any additional functions needed.
Signed-off-by: Bruce Richardson
---
buildtools/dpdk-cmdline-gen.py| 190 ++
buildtools/meson.build
variable.
Signed-off-by: Bruce Richardson
Reviewed-by: Aaron Conole
---
.ci/linux-build.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index e0b62bac90..3db9d9de6e 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -174,6 +174,7 @@ fi
if
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
structs and defines for the commandline part of the app.
Signed-off-by: Bruce Richardson
---
examples/multi_process/simple_mp/Makefile | 12 +-
examples/multi_process/simple_mp/meson.build | 9 ++
.../multi_process
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
structs and defines for the commandline part of the app.
Signed-off-by: Bruce Richardson
---
examples/multi_process/hotplug_mp/Makefile| 12 +-
examples/multi_process/hotplug_mp/commands.c | 147
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
structs and defines for the commandline part of the app.
Signed-off-by: Bruce Richardson
---
Note: the original help text on some of the commands in this example
were not useful "this command do not handle any argu
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
structs and defines for the commandline part of the app.
Signed-off-by: Bruce Richardson
---
examples/vdpa/Makefile | 12 ++--
examples/vdpa/commands.list | 8 +++
examples/vdpa/main.c| 131
Add support to the commandline generator for option strings, where there
are only a limited number of acceptable values to be passed as a
parameter.
Signed-off-by: Bruce Richardson
---
buildtools/dpdk-cmdline-gen.py| 7 +++
doc/guides/prog_guide/cmdline.rst | 7 +++
2 files changed
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
structs and defines for the commandline part of the app.
Signed-off-by: Bruce Richardson
---
examples/ntb/Makefile | 12 ++-
examples/ntb/commands.list | 11 ++
examples/ntb/meson.build | 7 ++
examples/ntb/ntb_fwd.c
; Signed-off-by: David Marchand
> ---
Acked-by: Bruce Richardson
On Mon, Oct 23, 2023 at 06:10:54PM +0200, Mattias Rönnblom wrote:
> Hi.
>
> Consider an Eventdev app using atomic-type scheduling doing something like:
>
> struct rte_event events[3];
>
> rte_event_dequeue_burst(dev_id, port_id, events, 3, 0);
>
> /* Assume three events were dequeue
On Tue, Oct 24, 2023 at 09:10:30AM +0100, Bruce Richardson wrote:
> On Mon, Oct 23, 2023 at 06:10:54PM +0200, Mattias Rönnblom wrote:
> > Hi.
> >
> > Consider an Eventdev app using atomic-type scheduling doing something like:
> >
> &
On Wed, Oct 25, 2023 at 09:40:54AM +0200, Mattias Rönnblom wrote:
> On 2023-10-24 11:10, Bruce Richardson wrote:
> > On Tue, Oct 24, 2023 at 09:10:30AM +0100, Bruce Richardson wrote:
> > > On Mon, Oct 23, 2023 at 06:10:54PM +0200, Mattias Rönnblom wrote:
> > > > Hi
On Wed, Oct 25, 2023 at 03:04:05PM +0200, Robin Jarry wrote:
> Bruce Richardson, Oct 17, 2023 at 14:13:
> > Provide a "dpdk-cmdline-gen.py" script for application developers to
> > quickly generate the boilerplate code necessary for using the cmdline
> > library.
&
On Wed, Oct 25, 2023 at 03:15:49PM +0200, Thomas Monjalon wrote:
> 24/10/2023 18:04, Stephen Hemminger:
> > On Tue, 24 Oct 2023 15:55:13 +0200
> > Morten Brørup wrote:
> >
> > > >
> > > >4. It MAY be used by preemptible multi-producer and/or preemptible
> > > > multi-
> > > > consumer pthre
hen the compiler does not support the specified
> cpu_instruction_set (or) machine argument.
>
> Signed-off-by: Sivaprasad Tummala
> ---
> config/meson.build | 5 +
> 1 file changed, 5 insertions(+)
>
Acked-by: Bruce Richardson
On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote:
> On Wed, 25 Oct 2023 15:44:25 +0200
> Thomas Monjalon wrote:
>
> > > >
> > > > I'll try to pass the test by adding a sleep in the test thread.
> > > >
> > >
> > > "sched_yield()" rather than sleep perhaps? Might better conve
On Wed, Oct 25, 2023 at 06:31:10PM +0200, Thomas Monjalon wrote:
> When running real-time threads, we may need to force scheduling
> kernel threads or other real-time threads.
> New functions are added to address these cases.
>
> The yield functions should not have any interest for normal threads.
On Thu, Oct 26, 2023 at 04:59:51PM +0200, Morten Brørup wrote:
> > From: Morten Brørup [mailto:m...@smartsharesystems.com]
> > Sent: Thursday, 26 October 2023 16.50
> >
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Thursday, 26 October 2023 16.31
> > >
> > > 26/10/2023 16:08
is accepted if that's beneficial. The new
> patches would then depend on this patch.
>
> This patch, as well as all others in the pipeline, are the result of
> extensive DTS workgroup review which happens internally. If you'd like
> us to make it more public we'd have no problem with that.
>
Thanks for all the work on this, it's good to see DTS making its way slowly
towards mainline DPDK.
Series-acked-by: Bruce Richardson
On Thu, Oct 13, 2022 at 05:11:38PM +0200, Markus Theil wrote:
> On 10/12/22 17:19, Bruce Richardson wrote:
> > On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote:
> > > Makes apps configureable from meson, like already
> > > possible for drivers.
> > >
On Thu, Oct 13, 2022 at 05:35:39PM +0200, Markus Theil wrote:
> From: Thorben Roemer
>
> In order to perform things like LTO more easily in
> our DPDK applications, we use DPDK as a meson subproject.
> Also export includes in order to be usable in this context.
>
> Signed-off-by: Thorben Roemer
On Fri, Oct 14, 2022 at 09:51:17AM +0200, Markus Theil wrote:
> Makes apps configurable from meson, like already
> possible for drivers.
>
> Signed-off-by: Markus Theil
> ---
Seems reasonable enough.
Acked-by: Bruce Richardson
On Fri, Oct 14, 2022 at 09:51:18AM +0200, Markus Theil wrote:
> In order to perform things like LTO more easily in
> our DPDK applications, we use DPDK as a meson subproject.
> Also export includes in order to be usable in this context.
>
> Signed-off-by: Markus Theil
> -
On Fri, Oct 14, 2022 at 12:44:33PM +, Power, Ciara wrote:
> Hi Chengwen,
>
> > -Original Message-
> > From: David Marchand
> > Sent: Friday 14 October 2022 10:50
> > To: Chengwen Feng
> > Cc: tho...@monjalon.net; dev@dpdk.org; Power, Ciara
> >
> > Subject: Re: [PATCH v2] usertools:
On Fri, Oct 14, 2022 at 08:01:11AM -0700, Stephen Hemminger wrote:
> On Fri, 14 Oct 2022 14:02:10 +0100
> Bruce Richardson wrote:
>
> > On Fri, Oct 14, 2022 at 12:44:33PM +, Power, Ciara wrote:
> > > Hi Chengwen,
> > >
> > > > -Origi
od_bytes": 0,
> "tx_good_bytes": 0,
> "rx_missed_errors": 0,
> "rx_errors": 0,
> "rx_mbuf_allocation_errors": 0,
> "rx_q0_packets": 0,
> ...
> }
> }
>
> Note: the non-interactive mode is made machine-readable and remains the
> original way (it means don't use indent to pretty print).
>
> Signed-off-by: Chengwen Feng
> Acked-by: David Marchand
> Acked-by: Ciara Power
>
Tested-by: Bruce Richardson
> : "KO");
> + rte_tel_data_add_dict_string(d, "Path", trace->dir);
> +
> + return 0;
> +}
> +
> +RTE_INIT(trace_telemetry)
> +{
> + rte_telemetry_register_cmd("/trace/enable", trace_telemetry_enable,
> + "Enable trace points matching the provided pattern. Parameters:
> string pattern.");
> + rte_telemetry_register_cmd("/trace/disable", trace_telemetry_disable,
> + "Disable trace points matching the provided pattern.
> Parameters: string pattern.");
> + rte_telemetry_register_cmd("/trace/list", trace_telemetry_list,
> + "List trace points. Parameters: string pattern.");
> + rte_telemetry_register_cmd("/trace/save", trace_telemetry_save,
> + "Save current traces. Takes no parameter.");
> +}
> diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c
> index 34366ecee3..5b319c18fb 100644
> --- a/lib/telemetry/telemetry_data.c
> +++ b/lib/telemetry/telemetry_data.c
> @@ -106,6 +106,7 @@ valid_name(const char *name)
> ['a' ... 'z'] = 1,
> ['_'] = 1,
> ['/'] = 1,
> + ['.'] = 1,
> };
> while (*name != '\0') {
> if ((size_t)*name >= RTE_DIM(allowed) || allowed[(int)*name] ==
> 0)
I don't see an issue with allowing "." characters in dictionary names, so
for this part:
Acked-by: Bruce Richardson
On Tue, Oct 18, 2022 at 04:33:49PM +0200, Morten Brørup wrote:
> > From: David Marchand [mailto:david.march...@redhat.com]
> > Sent: Thursday, 13 October 2022 09.49
> >
> > Register telemetry commands to list and configure trace points and
> > later
> > save traces for a running DPDK application.
On Tue, Oct 18, 2022 at 02:14:37PM +0100, Bruce Richardson wrote:
> On Thu, Oct 13, 2022 at 09:49:28AM +0200, David Marchand wrote:
> > Register telemetry commands to list and configure trace points and later
> > save traces for a running DPDK application.
> >
> > Note
tically at the vdev bus level.
Signed-off-by: Bruce Richardson
---
drivers/bus/vdev/vdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index f5b43f1930..bfd7ce60c1 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.
On Wed, Sep 21, 2022 at 04:26:11PM +0200, Thomas Monjalon wrote:
> I think this patch requires a techboard vote
> as it is dropping some user-facing naming.
>
I think a better solution is to centralize the use of aliases. I've just
posted a patch to this thread to add the aliasing for net drivers
On Wed, Oct 19, 2022 at 02:11:18PM +0100, Bruce Richardson wrote:
> For historical reasons, a number of net vdev drivers also add a driver
> alias using the "eth_" prefix. Since this is done on a per-driver basis,
> the use of the alias in inconsistent and is spread across multi
t we are not supporting booleans except as part of
an array or dictionary. Is it likely that we will ever want to have a
telemetry command that just returns true/false alone? Don't see that being
necessary just yet, so:
Reviewed-by: Bruce Richardson
Acked-by: Bruce Richardson
> app/test/test_t
On Wed, Oct 19, 2022 at 04:28:58PM +0200, David Marchand wrote:
> On Wed, Oct 19, 2022 at 3:48 PM Bruce Richardson
> wrote:
> >
> > On Wed, Oct 19, 2022 at 09:37:02AM +0200, David Marchand wrote:
> > > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts
On Thu, Oct 20, 2022 at 10:23:27AM +0200, Thomas Monjalon wrote:
> 19/10/2022 15:20, Bruce Richardson:
> > On Wed, Oct 19, 2022 at 02:11:18PM +0100, Bruce Richardson wrote:
> > > For historical reasons, a number of net vdev drivers also add a driver
> > > alias using th
> Quite likely, it is dependent on what is being done on the runners.
>
Still probably a change worth making.
Acked-by: Bruce Richardson
> > > Signed-off-by: David Marchand
> > > Acked-by: Morten Brørup
> > > Acked-by: Bruce Richardson
> > > Acked-by: Ciara Power
> > > ---
> > > Changes since v1:
> > > - fixed doxygen description,
> > >
> > > ---
>
Bernard is no longer with Intel and is no longer involved in the DPDK
community, so remove him from the MAINTAINERS file.
Signed-off-by: Bruce Richardson
---
MAINTAINERS | 2 --
1 file changed, 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2bd4a55f1b..86a66b3981 100644
--- a
On Tue, Oct 25, 2022 at 05:33:31PM +0200, Maxime Coquelin wrote:
>
>
> On 10/25/22 11:15, Hu, Jiayu wrote:
> > > I think that for Vhost PMD, the Virtio completions should either be
> > > performed by DMA engine or by a dedicated thread.
> >
> > We cannot depend on DMA engine to do completion, a
>
> Signed-off-by: David Marchand
> ---
Acked-by: Bruce Richardson
On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote:
> If the dependency common/mlx5 is explicitly disabled,
> but net/mlx5 is not explicitly disabled,
> Meson will read the full recipe of net/mlx5
> and will fail when accessing a variable from common/mlx5:
> drivers/net/mlx5/meson.buil
("compress/mlx5: introduce PMD")
> Fixes: a7c86884f150 ("crypto/mlx5: introduce Mellanox crypto driver")
> Fixes: 5e7596ba7cb3 ("vdpa/sfc: introduce Xilinx vDPA driver")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Thomas Monjalon
> ---
Acked-by: Bruce Richardson
On Wed, Nov 02, 2022 at 01:29:49PM +0100, Thomas Monjalon wrote:
> 02/11/2022 13:10, Bruce Richardson:
> > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote:
> > > If the dependency common/mlx5 is explicitly disabled,
> > > but net/mlx5 is not explicitly
On Tue, Jan 10, 2023 at 12:10:33PM -0800, Tyler Retzlaff wrote:
> On Tue, Jan 10, 2023 at 09:16:48AM +0000, Bruce Richardson wrote:
> > On Mon, Jan 09, 2023 at 02:56:04PM -0800, Tyler Retzlaff wrote:
> > > hi folks,
> > >
> > > i would like to introduce a l
On Wed, Jan 11, 2023 at 11:23:07AM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 11 January 2023 11.10
> >
> > One additional point that just became clear to me when I started
> > thinking
> &
On Wed, Jan 11, 2023 at 12:06:26PM +, Chengwen Feng wrote:
> The stats reset is useful for debugging, so add it to the dmadev
> telemetry command lists.
>
> Signed-off-by: Chengwen Feng
Looks ok to me, just one small comment inline. With that fixed:
Reviewed-by: Bruc
cture/
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Chengwen Feng
> ---
Reviewed-by: Bruce Richardson
> lib/telemetry/telemetry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Wed, Jan 11, 2023 at 12:06:30PM +, Chengwen Feng wrote:
> The number of xstats may be large, after the hide zero option is added,
> only non-zero values can be displayed.
>
> Signed-off-by: Chengwen Feng
> ---
> lib/ethdev/rte_ethdev.c | 28 ++--
> 1 file changed,
On Wed, Jan 11, 2023 at 02:16:52PM +0100, Thomas Monjalon wrote:
> Generation and comparison of ABI dumps are done on multiple cores
> thanks to xargs -P0.
> It can accelerate this long step by 5 in my tests.
>
> xargs reports a global error if one of the process has an error.
>
> Running a shell
On Wed, Jan 11, 2023 at 01:46:02PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 11 January 2023 12.57
> >
> > On Wed, Jan 11, 2023 at 11:23:07AM +0100, Morten Brørup wrote:
> > > > From: Br
On Wed, Jan 11, 2023 at 02:24:28PM +, Tomasz Duszynski wrote:
>
>
> >-Original Message-
> >From: Morten Brørup
> >Sent: Wednesday, January 11, 2023 10:31 AM
> >To: Tyler Retzlaff ; Tomasz Duszynski
> >;
> >bruce.richard...@intel.com
> >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Ja
To better distinguish which values are public and which are internal
remove the "RTE_" prefix off the internal enum defining the container
types.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/ethdev/sff_telemetry.c | 2 +-
lib
added new patch to make the renamed/new functions immediately public
allowing us to mark the original named versions as deprecated
- re-ordered patches within the sit, so the extra cleanup changes come
first
Bruce Richardson (9):
telemetry: remove RTE prefix from internal enum values
telem
Rather than relying on a specific ordering of elements in the array
matching that of elements in the enum definition, we can explicitly mark
each array entry using the equivalent enum value as an index.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib
API-level compatibility, we can use a macro to alias the
old name to the new.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
app/test/test_telemetry_data.c | 10 +-
drivers/net/cnxk/cnxk_ethdev_sec_teleme
the
older ones with the "u64" suffix.
Internal functions can be directly renamed, without any need for
aliasing or deprecation.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
NOTE: To avoid excessive checkpatch warni
he older
functions as deprecated without hitting warnings.
Signed-off-by: Bruce Richardson
---
app/test/test_telemetry_data.c | 12 ++--
drivers/common/cnxk/roc_platform.h | 2 +-
drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 20 +++---
drivers/net/cnxk/cnxk_ethdev_telemetry.c
Add a deprecation notice for the renaming of the telemetry data u64/uint
functions, and point users to the newer versions of them when building.
To do this, we also need to mark the renamed versions as stable, rather
than experimental.
Signed-off-by: Bruce Richardson
---
Note: This patch adds
Since we are standardizing on using uint in place of u64, and expanding
the int values to 64-bit, we can update the internal json functions to
use the new names and expanded signed type.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler
The internal storage for int values can be expanded from 32-bit to
64-bit without affecting the external ABI.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/telemetry/telemetry_data.h | 2 +-
1 file changed, 1 insertion
use the older functions taking a 32-bit
parameter.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/telemetry/meson.build | 1 +
lib/telemetry/rte_telemetry.h | 4 ++--
lib/telemetry/telemetry_data.c | 33
On Wed, Oct 19, 2022 at 02:11:18PM +0100, Bruce Richardson wrote:
> For historical reasons, a number of net vdev drivers also add a driver
> alias using the "eth_" prefix. Since this is done on a per-driver basis,
> the use of the alias in inconsistent and is spread across multi
oldest supported version of GCC.
DPDK headers do not build with the official C89 standard, and, to the
best of my knowledge, have never done so.
Bruce Richardson (1):
build: increase minimum C standard for DPDK builds
buildtools/chkincs/meson.build | 1 +
meson.build| 1 +
2
r external apps using DPDK.
Signed-off-by: Bruce Richardson
---
buildtools/chkincs/meson.build | 1 +
meson.build| 1 +
2 files changed, 2 insertions(+)
diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index 378c2f19ef..322ac775ce 100644
--- a/buildtoo
On Thu, Jan 12, 2023 at 01:42:48PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Thursday, 12 January 2023 12.36
> >
> > Set the default C language standard to be used for DPDK builds to C99.
> > This requires n
anges come
first
Bruce Richardson (9):
telemetry: remove RTE prefix from internal enum values
telemetry: make array initialization more robust
telemetry: rename unsigned 64-bit enum value to uint
telemetry: add uint type as alias for u64
global: rename telemetry functions to newe
To better distinguish which values are public and which are internal
remove the "RTE_" prefix off the internal enum defining the container
types.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/ethdev/sff_telemetry.c | 2 +-
lib
Rather than relying on a specific ordering of elements in the array
matching that of elements in the enum definition, we can explicitly mark
each array entry using the equivalent enum value as an index.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib
API-level compatibility, we can use a macro to alias the
old name to the new.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
app/test/test_telemetry_data.c | 10 +-
drivers/net/cnxk/cnxk_ethdev_sec_teleme
the
older ones with the "u64" suffix.
Internal functions can be directly renamed, without any need for
aliasing or deprecation.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
NOTE: To avoid excessive checkpatch warni
he older
functions as deprecated without hitting warnings.
Signed-off-by: Bruce Richardson
---
app/test/test_telemetry_data.c | 12 ++--
drivers/common/cnxk/roc_platform.h | 4 +-
drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 20 +++---
drivers/net/cnxk/cnxk_ethdev_telemetry.c
Add a deprecation notice for the renaming of the telemetry data u64/uint
functions, and point users to the newer versions of them when building.
To do this, we also need to mark the renamed versions as stable, rather
than experimental.
Signed-off-by: Bruce Richardson
---
Note: This patch adds
Since we are standardizing on using uint in place of u64, and expanding
the int values to 64-bit, we can update the internal json functions to
use the new names and expanded signed type.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler
The internal storage for int values can be expanded from 32-bit to
64-bit without affecting the external ABI.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/telemetry/telemetry_data.h | 2 +-
1 file changed, 1 insertion
use the older functions taking a 32-bit
parameter.
Suggested-by: Morten Brørup
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/telemetry/meson.build | 1 +
lib/telemetry/rte_telemetry.h | 4 ++--
lib/telemetry/telemetry_data.c | 33
uild. Since only one file is involved, there
seemed little need for replicating EAL's separate subdirectories
per-OS.
Bruce Richardson (3):
eal/windows: move fnmatch function to header file
log: separate logging functions out of EAL
telemetry: use standard logging
lib/eal/common/eal_pr
ile,
preventing duplicate definitions if it is used by two libraries, while
also not requiring export for sharing.
Signed-off-by: Bruce Richardson
---
lib/eal/windows/fnmatch.c | 172 -
lib/eal/windows/include/fnmatch.h | 175 +++---
Move the logging capability to a separate library, free from EAL.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_private.h | 7
lib/eal/common/meson.build| 1 -
lib/eal/include/meson.build | 1 -
lib/eal/linux/meson.build
Now that logging is moved out of EAL, we don't need injection of the
logtype and logging function from EAL to telemetry library, simplifying
things.
Signed-off-by: Bruce Richardson
---
lib/eal/freebsd/eal.c | 6 +-
lib/eal/linux/eal.c| 6 +-
lib/tele
On Fri, Jan 13, 2023 at 05:41:29PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Friday, 13 January 2023 17.20
> >
> > To allow the fnmatch function to be shared between libraries, without
> > having to expor
On Fri, Jan 13, 2023 at 09:31:26AM -0800, Tyler Retzlaff wrote:
> On Fri, Jan 13, 2023 at 05:01:20PM +0000, Bruce Richardson wrote:
> > On Fri, Jan 13, 2023 at 05:41:29PM +0100, Morten Brørup wrote:
> > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > &
r BSD
* Removed "eal" from the filenames of files in the log directory
* added prefixes to elements in the fnmatch header to avoid conflicts
* fixed space indentation in new lines in telemetry.c (checkpatch)
* removed "extern int logtype" definition in telemetry.c (checkpatch)
* added
ile,
preventing duplicate definitions if it is used by two libraries, while
also not requiring export for sharing.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/eal/windows/fnmatch.c | 172 -
lib/eal/windows/include/
Move the logging capability to a separate library, free from EAL. Rename
files as appropriate, and use meson.build to select the correct file to
be built for each operating system, rather than having a subdir per-os.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler
Now that logging is moved out of EAL, we don't need injection of the
logtype and logging function from EAL to telemetry library, simplifying
things.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/eal/freebsd/eal.c | 6 +-
li
and/turbo_sw: support meson build")
> Fixes: 72c00ae9dba7 ("regex/cn9k: use cnxk infrastructure")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Thomas Monjalon
> ---
Acked-by: Bruce Richardson
will suffer from issues.
Bruce Richardson (5):
dma/ioat: fix device stop if no copies done
dma/ioat: fix incorrectly set indexes after restart
test/dmadev: check result for device stop
test/dmadev: create separate function for single copy test
test/dmadev: add tests for stopping and
different, as is the final device state.
Update the IOAT driver "stop" function to take account of this
difference.
Fixes: 583f046dd404 ("dma/ioat: add start and stop")
Cc: conor.wa...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/dma/ioat/ioat_d
om
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/dma/ioat/ioat_dmadev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c
index aff7bbbfde..072eb17cd9 100644
--- a/drivers/dma/ioat/ioat_dmadev.c
+++ b/driver
The DMA device stop API can return an error value so check that return
value when running dmadev unit tests.
Signed-off-by: Bruce Richardson
---
app/test/test_dmadev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
index
The copy tests for dmadev had separate blocks in the test function for
single copy and burst copies. Separate out the single-copy block to its
own function so that it can be re-used if necessary.
Signed-off-by: Bruce Richardson
---
app/test/test_dmadev.c | 120
case.
Signed-off-by: Bruce Richardson
---
app/test/test_dmadev.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
index de787c14e2..8fb73a41e2 100644
--- a/app/test/test_dmadev.c
+++ b/app/test
On Mon, Jan 16, 2023 at 04:09:19PM +, Walsh, Conor wrote:
> Hi Bruce,
>
> This patchset breaks the dmadev autotest for IOAT on IceLake.
>
> Trace below:
>
> ### Test dmadev instance 0 [:00:01.0] IOAT.status: ACTIVE
> [0x100242880] DMA Dev 0: Running copy Tests Ops submitted: 85120Ops
drivers will suffer from issues.
v2:
* extra patch to fix issues with error reporting, as noted by Conor W.
Bruce Richardson (6):
dma/ioat: fix device stop if no copies done
dma/ioat: fix incorrectly set indexes after restart
dma/ioat: fix incorrect error reporting on restart
test/dmadev: check
different, as is the final device state.
Update the IOAT driver "stop" function to take account of this
difference.
Fixes: 583f046dd404 ("dma/ioat: add start and stop")
Cc: conor.wa...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/dma/ioat/ioat_d
101 - 200 of 9084 matches
Mail list logo
