Hi huawei,
> -Original Message-
> From: Xie, Huawei
> Sent: Wednesday, February 4, 2015 6:54 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Cc: stephen at networkplumber.org; Cao, Waterman; Xu, Qian Q
> Subject: Re: [PATCH v3 19/25] ether: Fix vlan strip/insert issue
>
I will be a volunteer of reviewing the following files:
lib/librte_pmd_virtio/
doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
lib/librte_vhost/
doc/guides/prog_guide/vhost_lib.rst
examples/vhost/
doc/guides/sample_app_ug/vhost.rst
Signed-off-by: Changchun Ouyang
This is the patch set for single virtio implementation.
Why we need single virtio?
As we know currently there are at least 3 virtio PMD driver implementations:
A) lib/librte_pmd_virtio(refer as virtio A);
B) virtio_net_pmd by 6wind(refer as virtio B);
C) virtio by
For clarity make the setup of PCI resources for Linux into a function rather
than block of code #ifdef'd in middle of dev_init.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 76 ---
1 file changed,
The DPDK driver only has to deal with the case of running on PCI
and with SMP. In this case, the code can use the weaker barriers
instead of using hard (fence) barriers. This will help performance.
The rationale is explained in Linux kernel virtio_ring.h.
To make it clearer that this is a virtio
Starting driver with link down should be ok, it is with every
other driver. So just allow it.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
It is helpful to allow device drivers that don't support hardware
VLAN stripping to emulate this in software. This allows application
to be device independent.
Avoid discarding shared mbufs. Make a copy in rte_vlan_insert() of any
packet to be tagged that has a reference count > 1.
Virtio has link state interrupt which can be used.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 78 +++
lib/librte_pmd_virtio/virtio_pci.c| 22 ++
lib/librte_pmd_virtio/virtio_pci.h|
Implement VLAN stripping in software. This allows application
to be device independent.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 3 +++
lib/librte_pmd_virtio/virtio_ethdev.c | 2 ++
lib/librte_pmd_virtio/virtio_pci.h| 1
Change order of initialiazation to match Linux kernel.
Don't blow away control queue by doing reset when stopped.
Calling dev_stop then dev_start would not work.
Dev_stop was calling virtio reset and that would clear all queues
and clear all feature negotiation.
Resolved by only doing reset on
Better to check at compile time than fail at runtime.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
Since vq_alignment is constant (always 4K), it does not
need to be part of the vring struct.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 1 -
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
lib/librte_pmd_virtio/virtqueue.h | 3
Cleanup virtio code by eliminating unnecessary nesting of
virtio hardware structure inside adapter structure.
Also allows removing unneeded macro, making code clearer.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 43
If allocation fails, don't want to leave virtio device stuck
in middle of initialization sequence.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
Virtio supports vlan filtering.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
Virtio support multiple MAC addresses.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++-
lib/librte_pmd_virtio/virtio_ethdev.h | 3 +-
lib/librte_pmd_virtio/virtqueue.h | 34 -
3
Need to have do special things to set default mac address.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 5 +
lib/librte_pmd_virtio/virtio_ethdev.c | 24
2 files changed, 29 insertions(+)
diff --git
This makes virtio driver work like ixgbe. Transmit buffers are
held until a transmit threshold is reached. The previous behavior
was to hold mbuf's until the ring entry was reused which caused
more memory usage than needed.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
Make virtio not require UIO for some security reasons, this is to match 6Wind's
virtio-net-pmd.
Signed-off-by: Changchun Ouyang
---
changes in v3:
Remove macro RTE_EAL_PORT_IO;
virtio pmd could support uio and ioports method to get the address;
lib/librte_pmd_virtio/Makefile|
It should use vring descriptor index instead of used_ring index to index
vq_descx.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
Need swap the data from cpu to BE(big endian) for vlan-type.
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ether.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ether.h b/lib/librte_ether/rte_ether.h
index 74f71c2..0797908 100644
---
Check if it has already been vlan-tagged packet, if true, avoid inserting a
duplicated vlan tag into it.
This is a possible case when guest has the capability of inserting vlan tag.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 45 -
1
Support turn on/off RX VLAN strip on host, this let guest get the chance of
using its software VALN strip functionality.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/examples/vhost/main.c
Remove those hotspots which is unnecessary when early returning occurs;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
It needs use virtio_wmb instead of virtio_rmb for store memory barrier.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtqueue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_virtio/virtqueue.h
b/lib/librte_pmd_virtio/virtqueue.h
index
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Wednesday, February 11, 2015 12:33 PM
> To: Ouyang, Changchun
> Cc: dev at dpdk.org; Xie, Huawei; Cao, Waterman; Xu, Qian Q
> Subject: Re: [PATCH v4 17/26] virtio: Use port IO t
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, February 11, 2015 10:16 PM
> To: Stephen Hemminger
> Cc: dev at dpdk.org; Vincent JARDIN; Ouyang, Changchun
> Subject: Re: [dpdk-dev] [PATCH v4 17/26] virtio: Use
This patch set update IXGBE base codes to the version of
cid-10g-shared-code.2015.02.03.
and this patch set add 2 new device id as following:
#define IXGBE_DEV_ID_X550EM_X_10G_T0x15AD
#define IXGBE_DEV_ID_X550EM_X_1G_T 0x15AE
Changchun Ouyang (36):
ixgbe base codes:
Use DEBUGOUT to replace ERROR_REPORT1.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
index
Remove '&' before function name;
Adjust the spaces etc.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c | 55 +++---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.h | 1 -
lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 105 +--
It needs check if the bus type is the unknown type or not.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
Remove unnecessary '|' for the link speed.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c
b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c
index
Update the adress of IXGBE_CS4227.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.h | 2 +-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.h
It could early return according to read status.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c
b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c
index 76e9a32..84ab8b7 100644
---
Define the function of setting phy power;
Set copper phy power for x540.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 30 ++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.h | 1 +
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 1 +
Remove lan_id from struct ixgbe_phy_info.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 4 +-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 1 -
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x540.c | 2 +-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 66
Use IOMEM for hw addr.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h | 2 ++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
Define function ixgbe_mng_present to check if management capability is present
or not.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 16
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h | 1 +
2 files changed, 17 insertions(+)
diff --git
82599 use mng present to check if MNG FW could be enabled.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
Add timeout as new argument in host interface command.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 13 -
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h | 2 +-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 5 -
Wait for a last completion before clearing buffers,
and before proceeding, it needs make sure that the PCIe block does not have
transactions pending.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 22 +-
1 file changed, 21 insertions(+), 1
Update macros in ixgbe_type header files.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 59 +
1 file changed, 53 insertions(+), 6 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h
Add new phy ID: X557_PHY_ID, and implement its internal setup function and
external init function.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 3 +
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 10 ++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 204
New API for setup internal phy.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c | 14 ++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c
Support 5G link speed for X550.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c| 15 +++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 3 ++-
3 files changed, 21 insertions(+), 1 deletion(-)
diff
Use switch-case statement to replace if-else statement.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
Check if SFP is detected or not.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 18 ++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.h | 4
2 files changed, 22 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c
New function to get bus information for x550em;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 1 +
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 23 +--
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.h | 1 +
3 files changed, 23 insertions(+), 2
Request and response command have different struct.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 22 -
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 34 -
2 files changed, 34 insertions(+), 22 deletions(-)
diff
It needs '>=' rather than '=='.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c| 2 +-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82599.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
New API to control the phy power state.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c | 11 +++
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c
New API to perform I2C read combined operation.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c | 16
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c
New API to perform I2C write combined operation.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c | 16
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.h | 1 +
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 11 +--
3 files changed, 26 insertions(+), 2
LAN ID is needed for i2c access, so move it before reading I2C eeprom.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c
Add function to calculate checksum for X550; and add buffer into argument list
to hold the eeprom image.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 74 -
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.h | 1 +
2 files changed, 55
Support the bit-bang mode on X550;
And negate I2C output enable;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 66 +++--
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 6 +++
2 files changed, 68 insertions(+), 4 deletions(-)
diff --git
Auto-negotiation for link speed of 5G.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 41 -
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 ++
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git
Setup kx4 phy for x550em;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 14 +--
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 44 -
2 files changed, 55 insertions(+), 3 deletions(-)
diff --git
Update the macro to read/write iosf sb stat.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c
b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x550.c
index
The old device id: IXGBE_DEV_ID_X550EM_X is split into 2 new device id:
IXGBE_DEV_ID_X550EM_X_10G_T and IXGBE_DEV_ID_X550EM_X_1G_T
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_api.c | 3 ++-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 5 +++--
Accordingly, add 2 new device id into lib_eal.
Signed-off-by: Changchun Ouyang
---
lib/librte_eal/common/include/rte_pci_dev_ids.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h
This patch enables testpmd user can config port hw_vlan with more fine
granularity:
hw vlan filter, hw vlan strip, and hw vlan extend.
Don't remove the original command(hw-vlan) considering that some user still
want to use
only one command to switch on/off all 3 options.
Signed-off-by:
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica
> Sent: Saturday, February 21, 2015 12:13 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] virtio: Changed variable types to prevent
> possible data loss in virtio_ethdev.c,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski
> Sent: Thursday, February 19, 2015 11:55 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV
>
> Enable DCB in SRIOV mode for ixgbe driver.
>
> To
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski
> Sent: Thursday, February 19, 2015 11:55 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode()
> logic to driver
>
> Function
Update the share code version into cid-10g-shared-code.2015.02.03.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe/README
b/lib/librte_pmd_ixgbe/ixgbe/README
index
Resend this single patch only as it seems be blocked and not present in the
mailing list.
Thanks
Changchun
> -Original Message-
> From: Ouyang, Changchun
> Sent: Thursday, February 26, 2015 10:09 AM
> To: dev at dpdk.org
> Cc: Richardson, Bruce; Cao, Waterman; Ou
Fix possible memory leak issue: free kvlist before return;
Fix possible resource lost issue: close qssockfd before return;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_af_packet/rte_eth_af_packet.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git
Fix possible memory leak issue: free kvlist before return;
Fix possible resource lost issue: close qssockfd before return;
Signed-off-by: Changchun Ouyang
---
change in v2:
- Make the error exit point a common path.
lib/librte_pmd_af_packet/rte_eth_af_packet.c | 11 +--
1 file
This patch fixes the compilation issue on freebsd:
/root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function
'virtio_resource_init':
/root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error:
unused parameter 'pci_dev' [-Werror=unused-parameter] static int
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, February 27, 2015 10:05 PM
> To: Ouyang, Changchun
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] af_packet: Fix some klocwork errors
>
> On Fri, Feb 27,
Fix possible memory leak issue: free kvlist before return;
Fix possible resource lost issue: close qssockfd before return;
Signed-off-by: Changchun Ouyang
---
Change in v3:
- Also close sockets for all queues.
Change in v2:
- Make the error exit point a common path.
Hi Steve,
> -Original Message-
> From: Liang, Cunming
> Sent: Sunday, January 4, 2015 10:11 AM
> To: Ouyang, Changchun; dev at dpdk.org
> Cc: Cao, Waterman
> Subject: RE: [PATCH v3 5/6] ixgbe: Config VF RSS
>
>
>
> > -Original Message-
>
This patch enables VF RSS for Niantic, which allow each VF having at most 4
queues.
The actual queue number per VF depends on the total number of pool, which is
determined by the max number of VF at PF initialization stage and the number of
queue specified in config:
1) If the max number of VF is
Put global register configuring out of loop for queue; also fix typo and indent;
Also fix typo and indent.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git
Negotiate API version with VF when receiving the IXGBE_VF_API_NEGOTIATE message.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 +
lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
2 files changed, 26 insertions(+)
diff --git
It needs config RSS and IXGBE_MRQC and IXGBE_VFPSRTYPE to enable VF RSS.
The psrtype will determine how many queues the received packets will distribute
to,
and the value of psrtype should depends on both facet: max VF rxq number which
has been negotiated with PF, and the number of rxq specified
Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS
information.
Signed-off-by: Changchun Ouyang
---
app/test-pmd/testpmd.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 8c69756..6230f8b 100644
---
Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES
message from VF.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe_pf.c | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git
Hi Vlad,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:30 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version
>
>
> On 01/04/
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:40 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version
>
>
> On 01/04/15 10:37,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:45 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode
>
>
> On 01/04/15 09:18
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:50 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode
>
>
> On 01/04/15 09:18
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 5:46 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode
>
>
> On 01/04/15 10:58,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 5:47 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode
>
>
> On 01/04/15 11:01,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:39 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number
>
>
> On 01/04/15 09:18
> -Original Message-
> From: Richardson, Bruce
> Sent: Monday, January 5, 2015 6:29 PM
> To: Ouyang, Changchun
> Cc: Vlad Zolotarov; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS
>
> On Fri, Dec 26, 2014 at 01:52:25AM +,
> -Original Message-
> From: Richardson, Bruce
> Sent: Monday, January 5, 2015 6:38 PM
> To: Ouyang, Changchun
> Cc: Vlad Zolotarov; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 0/6] Enable VF RSS for Niantic
>
> On Thu, Dec 25, 2014 at 01:46:54AM +,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Monday, January 5, 2015 9:02 PM
> To: Richardson, Bruce; Ouyang, Changchun
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 0/6] Enable VF RSS for Niantic
>
>
&g
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Monday, January 5, 2015 6:07 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number
>
>
> On 01/05/15 04:59,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Monday, January 5, 2015 6:10 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode
>
>
> On 01/05/15 03:00,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Monday, January 5, 2015 6:12 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode
>
>
> On 01/05/15 04:38,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Tuesday, January 6, 2015 7:27 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number
>
>
> On 01/06/15 03:54,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Tuesday, January 6, 2015 8:53 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode
>
>
> On 01/06/15 04:01,
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Wednesday, January 7, 2015 3:56 AM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode
>
>
> On 01/06/15 03:56,
This patch enables VF RSS for Niantic, which allow each VF having at most 4
queues.
The actual queue number per VF depends on the total number of pool, which is
determined by the max number of VF at PF initialization stage and the number of
queue specified in config:
1) If the max number of VF is
Put global register configuring out of loop for queue; also fix typo and indent;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
Negotiate API version with VF when receiving the IXGBE_VF_API_NEGOTIATE message.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 +
lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
2 files changed, 26 insertions(+)
diff --git
Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES
message from VF.
Signed-off-by: Changchun Ouyang
changes in v5
- Add some 'FIX ME' comments for IXGBE_VF_TRANS_VLAN.
---
lib/librte_pmd_ixgbe/ixgbe_pf.c | 40 +++-
1 file
Check mq mode for VMDq RSS, handle it correctly instead of returning an error;
Also remove the limitation of per pool queue number has max value of 1, because
the per pool queue number could be 2 or 4 if it is VMDq RSS mode;
The number of rxq specified in config will determine the mq mode for
1 - 100 of 666 matches
Mail list logo
