[dpdk-dev] [PATCH v7 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-09 Thread Qiu, Michael
On 2/9/2015 4:31 PM, Tetsuya Mukawa wrote: > To remove assumption, do like followings. [...] > struct rte_eth_dev_sriov { > @@ -1604,6 +1605,10 @@ extern struct rte_eth_dev rte_eth_devices[]; > * initialized by the [matching] Ethernet driver during the PCI probing > phase. > * All devices

[dpdk-dev] [PATCH v7 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-09 Thread Qiu, Michael
On 2/9/2015 4:31 PM, Tetsuya Mukawa wrote: > This patch replaces pci_addr_comparison() and memcmp() of pci addresses by > eal_compare_pci_addr(). > > v5: > - Fix pci_scan_one to handle pt_driver correctly. > v4: > - Fix calculation method of eal_compare_pci_addr(). > - Add parameter checking. > >

[dpdk-dev] [PATCH v4 00/15] lib/librte_pmd_fm10k : fm10k pmd driver

2015-02-11 Thread Qiu, Michael
On 2/11/2015 9:31 AM, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > The patch set add poll mode driver for the host interface of Intel > fm10k series of silicons, which integrate NIC and switch > functionalities. The patch set include below features: > > 1. Basic RX/TX functions for PF/VF.

[dpdk-dev] [PATCH v7 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-11 Thread Qiu, Michael
On 2/10/2015 11:11 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Monday, February 9, 2015 1:10 PM >> To: Tetsuya Mukawa; dev at dpdk.org >> Cc: Iremonger, Bernard >> Subject: Re: [PATCH v7 04/14] eal/pci: Consoli

[dpdk-dev] [PATCH v7 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-11 Thread Qiu, Michael
On 2/11/2015 12:57 PM, Tetsuya Mukawa wrote: > On 2015/02/11 13:53, Tetsuya Mukawa wrote: >> On 2015/02/11 12:27, Qiu, Michael wrote: >>> On 2/10/2015 11:11 PM, Iremonger, Bernard wrote: >>>>> -Original Message- >>>>> From: Qiu, Mich

[dpdk-dev] [PATCH v7 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-11 Thread Qiu, Michael
On 2/11/2015 4:14 PM, Tetsuya Mukawa wrote: > On 2015/02/11 15:29, Qiu, Michael wrote: >> On 2/11/2015 12:57 PM, Tetsuya Mukawa wrote: >>> On 2015/02/11 13:53, Tetsuya Mukawa wrote: >>>> On 2015/02/11 12:27, Qiu, Michael wrote: >>>>> On

[dpdk-dev] [PATCH] eal_pci: Fix max_vfs missing for none igb_uio driver

2015-02-11 Thread Qiu, Michael
On 2/11/2015 8:32 PM, David Marchand wrote: > Hello Michael, > > On Wed, Feb 11, 2015 at 12:10 PM, Michael Qiu > wrote: > > max_vfs will only be created by igb_uio driver, for other > drivers like vfio or pci_uio_generic, max_vfs will miss. > > But

[dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

2015-02-11 Thread Qiu, Michael
[+cc] David On 2/11/2015 9:26 PM, Qiu, Michael wrote: > max_vfs will only be created by igb_uio driver, for other > drivers like vfio or pci_uio_generic, max_vfs will miss. > > But sriov_numvfs is not driver related, just get the vf numbers > from that field. > > Signe

[dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

2015-02-13 Thread Qiu, Michael
On 2/13/2015 12:26 AM, Thomas Monjalon wrote: > 2015-02-11 21:25, Michael Qiu: >> max_vfs will only be created by igb_uio driver, for other >> drivers like vfio or pci_uio_generic, max_vfs will miss. >> >> But sriov_numvfs is not driver related, just get the vf numbers >> from that field. >> >>

[dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

2015-02-13 Thread Qiu, Michael
On 2/12/2015 1:50 PM, David Marchand wrote: > On Wed, Feb 11, 2015 at 2:25 PM, Michael Qiu > wrote: > > max_vfs will only be created by igb_uio driver, for other > drivers like vfio or pci_uio_generic, max_vfs will miss. > > But sriov_numvfs is not

[dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores

2015-02-15 Thread Qiu, Michael
Hi, Steve Why not post this patch within your enabling EAL "--lcores" option patch set? As it is not merged yet. Just a suggestion, depends you. Thanks, Michael On 2/15/2015 1:48 PM, Cunming Liang wrote: > The patch add unit test for the new eal option "--lcores". > > Signed-off-by: Cunming

[dpdk-dev] [PATCH v8 00/14] Port Hotplug Framework

2015-02-16 Thread Qiu, Michael
d patch. It will show you how to fix your legacy > applications to support port hotplug feature. > > PATCH v8 changes > - Fix Makefile and add version map file. > - Add missing symbol in version map. > - Fix pci_scan_one() to update sysfs values. >(Thanks to Qiu, Micha

[dpdk-dev] [PATCH v8 01/14] eal_pci: Add flag to hold kernel driver type

2015-02-17 Thread Qiu, Michael
On 2/17/2015 8:13 AM, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> From: Michael Qiu >> >> Currently, dpdk has no ability to know which type of driver( >> vfio-pci/igb_uio/uio_pci_generic) the device used. It only can >> check whether vfio is enabled or not staticly. >> >> It

[dpdk-dev] l3fwd error, port 0 is not present on the board

2015-01-04 Thread Qiu, Michael
On 1/2/2015 11:08 PM, Lyn M wrote: > Neil, your patch works. I am now able to run testpmd, as well as l3fwd > with DPDK 1.8.0 and CONFIG_RTE_BUILD_COMBINE_LIBS=y. Thank you much! > > In my original post, I thought my choice of hex portmask -p 0x3 was causing > this issue -- now I know that was

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

2015-01-07 Thread Qiu, Michael
On 12/18/2014 1:43 AM, Xie, Huawei wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Sunday, December 14, 2014 10:26 PM >> To: Xie, Huawei; dev at dpdk.org >> Cc: haifeng.lin at intel.com >> Subject: Re: [PATCH RFC v2 00/12] lib/librte_vhost:

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-07 Thread Qiu, Michael
On 12/10/2014 9:04 AM, Jijiang Liu wrote: > In the current codes, the "tx_checksum set (ip|udp|tcp|sctp|vxlan) (hw|sw) > (port-id)" command is not easy to understand and extend, so the patch set > enhances the tx_checksum command and reworks csum forwarding engine due to > the change of

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Qiu, Michael
On 2015/1/19 17:14, Thomas Monjalon wrote: > 2015-01-19 08:21, David Marchand: >> On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin >> wrote: >> >>> It seems that your fix result in cannot launching applications. >>> I don't suspect the correction of your fix, but somewhere else needs to be >>>

[dpdk-dev] rte_eal_init() causes PANIC using latest DPDK code.

2015-01-19 Thread Qiu, Michael
Hi Tetsuya, I see two lines log like: EAL: cannot open VFIO container, error 2 (No such file or directory) EAL: VFIO support could not be initialized It should not happen as I have a patch merged to master branch. There should have something wrong, could you please help me to debug this?

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Qiu, Michael
On 2015/1/19 17:50, David Marchand wrote: On Mon, Jan 19, 2015 at 10:30 AM, Qiu, Michael mailto:michael.qiu at intel.com>> wrote: This could be, but I hope every contributor could do basic check like build and run of at lease one app like test-pmd, then it will reduce most of failure we

[dpdk-dev] rte_eal_init() causes PANIC using latest DPDK code.

2015-01-19 Thread Qiu, Michael
On 2015/1/19 18:06, Tetsuya Mukawa wrote: > On 2015/01/19 18:49, Qiu, Michael wrote: >> Hi Tetsuya, >> >> I see two lines log like: >> >> EAL: cannot open VFIO container, error 2 (No such file or directory) >> EAL: VFIO support could not be initializ

[dpdk-dev] [PATCH v4 00/11] Port Hotplug Framework

2015-01-19 Thread Qiu, Michael
feature. > > > PATCH v4 changes > - Merge patches to review easier. > - Fix indent of 'if' statement. > - Fix calculation method of eal_compare_pci_addr(). > - Fix header file declaration. > - Add header file to determine if hotplug can be enabled. >(Thanks to Qiu,

[dpdk-dev] FW: [PATCH v4 01/11] eal/pci, ethdev: Remove assumption that port will not be detached

2015-01-19 Thread Qiu, Michael
Hi, Tetsuya You see lots of places have below three lines: if (rte_eth_dev_validate_port(port_id) == DEV_INVALID) { PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); return -EINVAL; } They are all the same(only few has the print log different), so

[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

2015-01-19 Thread Qiu, Michael
Any comments? On 2015/1/15 22:45, Qiu, Michael wrote: > For ixgbe, when queue start failure, for example, mbuf allocate > failure, the device will still start success, which could be > an issue. > > Add return status check of queue start to avoid this issue. > > Signe

[dpdk-dev] [PATCH v4 06/11] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-01-20 Thread Qiu, Michael
On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: > The patch adds functions for unmapping igb_uio resources. The patch is only > for Linux and igb_uio environment. VFIO and BSD are not supported. > > v4: > - Add paramerter checking. > - Add header file to determine if hotplug can be enabled. > >

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

2015-07-10 Thread Qiu, Michael
Hi, Stephen This patch does not work for fm10k with vfio, see error below: EAL: PCI device :84:00.0 on NUMA socket 1 EAL: probe driver: 8086:15a4 rte_pmd_fm10k EAL: PCI memory mapped at 0x7f198000 EAL: Trying to map BAR 2 that contains the MSI-X table. Trying offsets: :,

[dpdk-dev] [PATCH] fm10k: fix improper RETA table config

2015-07-10 Thread Qiu, Michael
On 7/10/2015 4:19 PM, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > fm10k has 128 RETA entries in 32 registers, but it only initialized > first 32 when doing multiple rx queue configurations. This fix will > initialize all 128 entries instead. > > Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH] eal: fix vfio device never works.

2015-07-14 Thread Qiu, Michael
Hi, Tetsuya So this patch make linux app back to original? Thanks, Michael On 7/11/2015 2:30 PM, Tetsuya Mukawa wrote: > The patch fixes vfio initialization issue introduced by below patch. > - Commit 35b3313e322b ("pci: merge mapping functions for linux and bsd") > > Root cause is that

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-07-14 Thread Qiu, Michael
: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >>>>>> On 2015/07/06 20:35, Qiu, Michael wrote: >>>>>>> Hi, all >>>>>>> >>>>>>> As we has gap on the memory release action to be done in which step, >>>>>>&

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

2015-07-14 Thread Qiu, Michael
Hi, Stephen I have found out the root cause of this bug, and generate a patch. Will send out later after :) Thanks, Michael On 7/11/2015 1:24 AM, Stephen Hemminger wrote: > On Fri, 10 Jul 2015 07:54:10 + > "Qiu, Michael" wrote: > >> Hi, Stephen >> >&g

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

2015-07-14 Thread Qiu, Michael
/2015 1:24 AM, Stephen Hemminger wrote: > On Fri, 10 Jul 2015 07:54:10 + > "Qiu, Michael" wrote: > >> Hi, Stephen >> >> This patch does not work for fm10k with vfio, see error below: >> >> EAL: PCI device :84:00.0 on NUMA socket 1 >> EAL

[dpdk-dev] [PATCH] examples/l3fwd: increase lookup burst size to 8

2015-07-23 Thread Qiu, Michael
Hi, Pablo Is there any performance data for this change? Thanks, Michael -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara Sent: Thursday, July 23, 2015 9:12 AM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH] examples/l3fwd: increase lookup burst size

[dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd

2015-07-28 Thread Qiu, Michael
On 2015/7/8 2:04, Richardson, Bruce wrote: > On Wed, Jul 08, 2015 at 07:16:21AM +0000, Qiu, Michael wrote: [.../...] >>> port = [pi]; >>> if (rte_atomic16_cmpset(&(port->port_status), >>> + R

[dpdk-dev] [PATCH v6] Add toeplitz hash algorithm used by RSS

2015-07-29 Thread Qiu, Michael
Hi, Vladimir You need also to fix this issue in i686 platform: RHEL65_32,2.6.32,4.4.7,14.0.0 SUSE11SP3_32,3.0.76-0,4.3.4,14.0.0 i686-native-linuxapp-gcc/include/rte_thash.h:63: error: integer constant is too large for 'long' type i686-native-linuxapp-gcc/include/rte_thash.h:63: error: integer

[dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD

2015-06-02 Thread Qiu, Michael
On 6/1/2015 9:47 PM, Thomas Monjalon wrote: > 2015-05-12 05:30, Qiu, Michael: >> Hi, thomas >> >> What about this patch? > It seems this patch was not *really* sent to dev at dpdk.org. > Please re-send, keeping the Acked-by line. OK, I will resend it. Thanks, Mich

[dpdk-dev] [RFC PATCH] librte_pmd_fm10k: Add hotplug support for fm10k

2015-06-02 Thread Qiu, Michael
On 6/2/2015 4:26 PM, Iremonger, Bernard wrote: > > -Original Message- > From: Qiu, Michael > Sent: Sunday, May 31, 2015 3:37 PM > To: dev at dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard; He, Shaopeng; Qiu, Michael > Subject: [RFC PATCH] librte_pmd_fm10k: Add hotp

[dpdk-dev] [PATCH 0/6] fm10k: A series of bug fixes

2015-06-09 Thread Qiu, Michael
On 2015/5/29 16:11, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > This patch set include a few bug fixes and enhancements on fm10k driver. > > Chen Jing D(Mark) (6): > fm10k: Fix improper RX buffer size assignment > fm10k: Fix jumbo frame issue > fm10k: Fix data integrity issue with

[dpdk-dev] [PATCH 1/3] fm10k: Add promiscuous mode support

2015-06-09 Thread Qiu, Michael
On 2015/6/5 17:03, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > Add functions to support promiscuous/allmulticast enable and > disable. > > Signed-off-by: Chen Jing D(Mark) > --- > drivers/net/fm10k/fm10k_ethdev.c | 118 > +- > 1 files changed, 117

[dpdk-dev] [PATCH 3/3] fm10k: update VLAN offload features

2015-06-09 Thread Qiu, Michael
On 2015/6/9 11:27, Chen, Jing D wrote: > Hi, > > >> -Original Message- >> From: He, Shaopeng >> Sent: Tuesday, June 02, 2015 10:59 AM >> To: dev at dpdk.org >> Cc: Chen, Jing D; Qiu, Michael; He, Shaopeng >> Subject: [PATCH 3/3] fm10k: update

[dpdk-dev] [PATCH 1/3] fm10k: update VLAN filter

2015-06-09 Thread Qiu, Michael
On 2015/6/2 10:59, He, Shaopeng wrote: > VLAN filter was updated to add/delete one static entry in MAC table for each > combination of VLAN and MAC address. More sanity checks were added. > > Signed-off-by: Shaopeng He > --- > drivers/net/fm10k/fm10k.h| 23 + >

[dpdk-dev] [PATCH 2/3] fm10k: add MAC filter

2015-06-09 Thread Qiu, Michael
On 2015/6/2 10:59, He, Shaopeng wrote: > MAC filter function was newly added, each PF and VF can have up to 64 MAC > addresses. VF filter needs support from PF host, which is not available now. > > Signed-off-by: Shaopeng He > --- > drivers/net/fm10k/fm10k.h| 3 +- >

[dpdk-dev] [PATCH 4/6] fm10k: Fix issue that MAC addr can't be set to silicon

2015-06-09 Thread Qiu, Michael
On 2015/5/29 16:11, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > In fm10k, PF driver needs to communicate with switch through > mailbox if it needs to add/delete MAC address. > This fix will validate if switch is ready before going forward. > Then, it is necessary to acquire LPORT_MAP info

[dpdk-dev] i40e: Failed to init adminq

2015-06-10 Thread Qiu, Michael
Hi, This is an know issue, as I faced before. One workaround: remove i40e kernel driver, power off server, then power on. After that start dpdk, it should work. Thanks, Michael On 6/10/2015 6:12 PM, Dirk-Holger Lenz wrote: > Hello, > since I updated from 2.0.0 released to the current git clone

[dpdk-dev] [PATCH 0/2 v2] Enable hotplug support for fm10k

2015-06-10 Thread Qiu, Michael
Compare with RFC patch: 1. split one patch to two, especially for free memory. 2. rework from lib/ to drivers/net On 6/10/2015 8:21 PM, Qiu, Michael wrote: > Hotplug feature is supported in EAL, this patch set is to enable > this feature in driver side. > > Michael Qiu (2): > fm1

[dpdk-dev] [PATCH 2/6] fm10k: Fix jumbo frame issue

2015-06-12 Thread Qiu, Michael
Tested-by: Michael Qiu - OS: Fedora20 3.11.10-301 - GCC: gcc version 4.8.3 2014911 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Ethernet controller: Intel Corporation Device 15a4 (rev 01) - Default x86_64-native-linuxapp-gcc configuration - Total 5 cases, 5 passed, 0 failed - Case:

[dpdk-dev] [PATCH 1/6] fm10k: Fix improper RX buffer size assignment

2015-06-16 Thread Qiu, Michael
Tested-by: Michael Qiu - OS: Fedora20 3.11.10-301 - GCC: gcc version 4.8.3 2014911 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Ethernet controller: Intel Corporation Device 15a4 (rev 01) - Default x86_64-native-linuxapp-gcc configuration On 5/29/2015 4:11 PM, Chen, Jing D wrote: >

[dpdk-dev] [PATCH v2] fm10k: fix PF/VF MAC address register and clean up bug

2015-06-16 Thread Qiu, Michael
Tested-by: Michael Qiu - OS: Fedora20 3.11.10-301 - GCC: gcc version 4.8.3 2014911 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Ethernet controller: Intel Corporation Device 15a4 (rev 01) - Default x86_64-native-linuxapp-gcc configuration - Total 1 cases, 1 passed, 0 failed On

[dpdk-dev] [PATCH 3/6] fm10k: Fix data integrity issue with multi-segment frame

2015-06-16 Thread Qiu, Michael
Tested-by: Michael Qiu - OS: Fedora20 3.11.10-301 - GCC: gcc version 4.8.3 2014911 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Ethernet controller: Intel Corporation Device 15a4 (rev 01) - Default x86_64-native-linuxapp-gcc configuration - Total 5 cases, 5 passed, 0 failed - Case:

[dpdk-dev] [PATCH v2 0/3] fm10k: Add promiscuous mode support

2015-06-16 Thread Qiu, Michael
On 6/12/2015 3:07 PM, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > v2: > Add debug messages in allmulticast enable/disable functions. > > The patch set add promiscuous mode configuration and 2 bug fixes. > > Chen Jing D(Mark) (3): > fm10k: Add promiscuous mode support > fm10k: remove

[dpdk-dev] [PATCH v2 2/3] fm10k: add MAC filter

2015-06-16 Thread Qiu, Michael
On 6/15/2015 9:25 AM, He, Shaopeng wrote: > MAC filter function was newly added, each PF and VF can have up to 64 MAC > addresses. VF filter needs support from PF host, which is not available now. > > Signed-off-by: Shaopeng He [.../...] > @@ -820,6 +821,7 @@ static int >

[dpdk-dev] [PATCH 1/2 v2] fm10k: Free queues when close port

2015-06-19 Thread Qiu, Michael
On 6/19/2015 12:29 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Wednesday, June 17, 2015 8:59 AM >> To: dev at dpdk.org >> Cc: Chen, Jing D; Iremonger, Bernard; He, Shaopeng; Qiu, Michael >> Subject: [PATCH 1/2 v2

[dpdk-dev] [PATCH 2/2 v2] fm10k: Add hotplug support for fm10k

2015-06-19 Thread Qiu, Michael
On 6/19/2015 12:42 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Wednesday, June 17, 2015 9:45 AM >> To: dev at dpdk.org >> Cc: Chen, Jing D; Iremonger, Bernard; He, Shaopeng; Qiu, Michael >> Subject: [PATCH 2/2 v2]

[dpdk-dev] [PATCH 2/2 v2] fm10k: Add hotplug support for fm10k

2015-06-19 Thread Qiu, Michael
Sorry this is version 3, Thanks Michael On 6/19/2015 4:32 PM, Qiu, Michael wrote: > Add hotplug support for fm10k. > > Signed-off-by: Michael Qiu > --- > drivers/net/fm10k/fm10k_ethdev.c | 97 > +++- > 1 file changed, 96 insertions(+), 1

[dpdk-dev] [RFC PATCH] librte_pmd_ixgbe: changes to support PCI Port Hotplug

2015-04-22 Thread Qiu, Michael
On 4/8/2015 6:03 PM, Bernard Iremonger wrote: > This patch depends on the Port Hotplug Framework. > It implements the eth_dev_uninit functions for rte_ixgbe_pmd and > rte_ixgbevf_pmd.pmd. > > Signed-off-by: Bernard Iremonger > --- Tested-by: Michael Qiu > lib/librte_pmd_ixgbe/ixgbe_ethdev.c |

[dpdk-dev] What to do about UIO breakage in 2.0

2015-04-28 Thread Qiu, Michael
On 4/28/2015 6:06 AM, Stephen Hemminger wrote: > I raised the issue, but people seem to be ignoring that fact that igb_uio > was broken by the introduction of UIO PCI generic in 2.0. What do you mean about igb_uio broken? Thanks, Michael > > There are three options: > 1. Remove IGB_UIO only use

[dpdk-dev] [RFC] examples: remove l3fwd-vf example

2015-08-04 Thread Qiu, Michael
Actually, l3fwd works fine with fm10k vf. I don't know what's the exact reason of l3fwd-vf still in DPDK, at least we could make full support for vf in l3fwd instead of another sample with most code are the same compare with l3fwd. Thanks, Michael On 2015/7/22 7:51, Zhang, Helin wrote:

[dpdk-dev] how to build dpdk in debug mode?

2015-08-04 Thread Qiu, Michael
Please refer dec/build-sdk-quick.txt EXTRA_CFLAGS=-g should work. Thanks, Michael On 2015/8/3 9:29, Thomas Monjalon wrote: > 2015-08-03 16:16, Montorsi, Francesco: >> Hi all, >> I have searched the archives for this, without much success. >> >> Is it possible to build dpdk user-space libraries

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 9:05, De Lara Guarch, Pablo wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, August 07, 2015 4:29 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 9:06, Zhang, Helin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Thursday, August 6, 2015 8:29 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding >> >> For some

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 13:37, Zhang, Helin wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Friday, August 7, 2015 11:53 AM >> To: Zhang, Helin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding >>

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-10 Thread Qiu, Michael
On 2015/8/7 17:13, Ouyang, Changchun wrote: > >> [.../...] >> >> eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *); >> +ether_addr_copy(_eth_addrs[fs->peer_addr], >> +_hdr->d_addr); >> +ether_addr_copy([fs->tx_port].eth_addr, >> +

[dpdk-dev] [PATCH]doc: Add performance tuning guide about how to get DPDK high perf on Intel platform.

2015-08-10 Thread Qiu, Michael
On 2015/8/10 9:11, Zhang, Helin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Monday, August 10, 2015 6:38 AM >> To: Xu, Qian Q >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH]doc: Add performance tuning guide

[dpdk-dev] [PATCH v2] lib/librte_sched: Fix compile with gcc 4.3.4

2015-12-02 Thread Qiu, Michael
I will make v3 patch to fix the issue. Thanks, Michael On 2015/12/2 10:19, Thomas Monjalon wrote: > 2015-12-02 10:09, Michael Qiu: >> gcc 4.3.4 does not include "immintrin.h", and will post below error: >> lib/librte_sched/rte_sched.c:56:23: error: >> immintrin.h: No such file or

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
Hi, Thomas I see you recently merged one commit: commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 Author: Thomas Monjalon Date: Tue Dec 8 01:50:17 2015 +0100 mk: fix external library build when combine is enabled The object files are copied to prepare the internal combined library.

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
My mistake. please ignore this issue. Thanks, Michael On 2015/12/8 15:08, Qiu, Michael wrote: > Hi, Thomas > > I see you recently merged one commit: > > commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 > Author: Thomas Monjalon > Date: Tue Dec 8 01:50:17 2015 +0100 >

[dpdk-dev] [PATCH] ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Qiu, Michael
Sorry please ignore this :) Thanks, Michael -Original Message- From: Qiu, Michael Sent: Wednesday, December 9, 2015 4:40 PM To: dev at dpdk.org Cc: Singh, Jasvinder; Dumitrescu, Cristian; root; Qiu, Michael Subject: [PATCH] ip_pipeline: Fix compile issue with strict-aliasing From: root

[dpdk-dev] Issue with patch "app/testpmd: detect numa socket count"

2015-12-19 Thread Qiu, Michael
d indicate that EAL was able to detect a higher max socket even > though it's not enabled. > > Is there a reason we're not CCing the mailing list? > > > -- Stephen Hurd > > > -Original Message- > From: Qiu, Michael [mailto:michael.qiu at intel.com] >

[dpdk-dev] [PATCH v3] mem: calculate space left in a hugetlbfs

2015-12-21 Thread Qiu, Michael
On 2015/11/18 17:42, Jianfeng Tan wrote: > Currently DPDK does not respect the quota of a hugetblfs mount. > It will fail to init the EAL because it tries to map the number of > free hugepages in the system rather than using the number specified > in the quota for that mount. > > To solve this

[dpdk-dev] [PATCH] librte_ether: fix crashes in rte_ethdev functions.

2015-12-21 Thread Qiu, Michael
On 2015/12/18 1:24, Bernard Iremonger wrote: > The nb_rx_queues and nb_tx_queues are initialised before > the tx_queue and rx_queue arrays are allocated. The arrays > are allocated when the ethdev port is started. > > If any of the following functions are called before the ethdev > port is started

[dpdk-dev] [PATCH v4 1/6] fm10k: implement rx_descriptor_done function

2015-12-22 Thread Qiu, Michael
On 12/21/2015 6:20 PM, Shaopeng He wrote: > rx_descriptor_done is used by interrupt mode example application > (l3fwd-power) to check rxd DD bit to decide the RX trend, > then l3fwd-power will adjust the cpu frequency according to > the result. > > Signed-off-by: Shaopeng He > Acked-by: Jing Chen

[dpdk-dev] [PATCH v4 3/6] fm10k: remove rx queue interrupts when dev stops

2015-12-22 Thread Qiu, Michael
On 12/21/2015 6:20 PM, Shaopeng He wrote: > Previous dev_stop function stops the rx/tx queues. This patch adds logic > to disable rx queue interrupt, clean the datapath event and queue/vec map. > > Signed-off-by: Shaopeng He > Acked-by: Jing Chen > --- > drivers/net/fm10k/fm10k_ethdev.c | 22

[dpdk-dev] [PATCH v2 7/7] doc: release note update for fm10k intr mode

2015-12-22 Thread Qiu, Michael
On 10/26/2015 11:48 AM, He, Shaopeng wrote: > Signed-off-by: Shaopeng He > --- > doc/guides/rel_notes/release_2_2.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/guides/rel_notes/release_2_2.rst > b/doc/guides/rel_notes/release_2_2.rst > index 73dba47..44b3aea 100644 > ---

[dpdk-dev] [PATCH v4 2/6] fm10k: setup rx queue interrupts for PF and VF

2015-12-22 Thread Qiu, Michael
On 12/21/2015 6:20 PM, Shaopeng He wrote: > In interrupt mode, each rx queue can have one interrupt to notify the up > layer application when packets are available in that queue. Some queues > also can share one interrupt. > Currently, fm10k needs one separate interrupt for mailbox. So, only those

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2015-12-23 Thread Qiu, Michael
Is it suitable to put so many code in commit log? Thanks, Michael On 12/22/2015 5:36 PM, Didier Pallard wrote: > As demonstrated by the following code, CRC32c computation is not valid > when buffer length is not a multiple of 4 bytes: > (Output obtained by code below) > > CRC of 1 NULL bytes

[dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET

2015-12-24 Thread Qiu, Michael
On 12/23/2015 8:19 PM, Reshma Pattan wrote: > Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET > are blocking the secondary process from using the APIs. > API access should be given to both secondary and primary. Just as the log says, is it safe to do so? Thanks, Michael > Fix

[dpdk-dev] [PATCH v5 0/6] interrupt mode for fm10k

2015-12-24 Thread Qiu, Michael
On 12/23/2015 3:38 PM, He, Shaopeng wrote: > This patch series adds interrupt mode support for fm10k, > contains four major parts: > > 1. implement rx_descriptor_done function in fm10k > 2. add rx interrupt support in fm10k PF and VF > 3. make sure default VID available in dev_init in fm10k > 4.

[dpdk-dev] [PATCH 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd

2015-12-24 Thread Qiu, Michael
On 12/24/2015 11:07 AM, Zhihong Wang wrote: > Handle SIGINT and SIGTERM in testpmd. > > Signed-off-by: Zhihong Wang > --- > app/test-pmd/testpmd.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index

[dpdk-dev] [PATCH 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd

2015-12-24 Thread Qiu, Michael
On 12/24/2015 11:07 AM, Zhihong Wang wrote: > Handle SIGINT and SIGTERM in l2fwd. > > Signed-off-by: Zhihong Wang > --- > examples/l2fwd/main.c | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index

[dpdk-dev] [RFC PATCH 0/2] Reduce DPDK initialization time

2015-12-24 Thread Qiu, Michael
On 11/18/2015 6:30 PM, Zhihong Wang wrote: > This RFC patch aims to reduce DPDK initialization time, which is important in > cases such as micro service. > > Changes are: > > 1. Reduce timer initialization time > > 2. Remove unnecessary hugepage zero-filling operations > > With this patch: > > 1.

[dpdk-dev] [PATCH] mk: fix examples build failure

2015-12-28 Thread Qiu, Michael
On 12/24/2015 8:38 PM, steeven lee wrote: > 1. Fix examples build failure > 2. make build as default output folder name > > Signed-off-by: steeven > --- > mk/internal/rte.extvars.mk | 4 ++-- > mk/rte.extsubdir.mk| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-12-28 Thread Qiu, Michael
Hi, Tetsuya I have a question about your solution, as I know you plan to run qemu and dpdk both in container right? If so, I think it's a bit tricky, DPDK is a lib, and qemu is a App, seems it is not suitable to let a lib depends on Apps. Also, till now I don't see any usecase to run qemu

[dpdk-dev] [PATCH v6 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-02 Thread Qiu, Michael
On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: > These functions are used for attaching or detaching a port. > When rte_eal_dev_attach() is called, the function tries to realize the > device name as pci address. If this is done successfully, > rte_eal_dev_attach() will attach physical device port. If

[dpdk-dev] [PATCH v6 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-02 Thread Qiu, Michael
On 2/2/2015 1:43 PM, Qiu, Michael wrote: > On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: >> These functions are used for attaching or detaching a port. >> When rte_eal_dev_attach() is called, the function tries to realize the >> device name as pci address. If this

[dpdk-dev] [PATCH v6 10/13] eal/pci: Cleanup pci driver initialization code

2015-02-03 Thread Qiu, Michael
On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: > - Add rte_eal_pci_close_one_dirver() > The function is used for closing the specified driver and device. > - Add pci_invoke_all_drivers() > The function is based on pci_probe_all_drivers. But it can not only > probe but also close drivers. > -

[dpdk-dev] [PATCH v6 07/13] ethdev: Add functions that will be used by port hotplug functions

2015-02-03 Thread Qiu, Michael
On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: > The patch adds following functions. > > - rte_eth_dev_save() > The function is used for saving current rte_eth_dev structures. > - rte_eth_dev_get_changed_port() > The function receives the rte_eth_dev structures, then compare > these with

[dpdk-dev] [PATCH v6 10/13] eal/pci: Cleanup pci driver initialization code

2015-02-03 Thread Qiu, Michael
On 2/3/2015 12:07 PM, Tetsuya Mukawa wrote: > On 2015/02/03 11:35, Qiu, Michael wrote: >> On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: >>> - Add rte_eal_pci_close_one_dirver() >>> The function is used for closing the specified driver and device. >&

[dpdk-dev] [PATCH v6] testpmd: Add port hotplug support

2015-02-03 Thread Qiu, Michael
On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: > The patch introduces following commands. > - port attach [ident] > - port detach [port_id] > - attach: attaching a port > - detach: detaching a port > - ident: pci address of physical device. > Or device name and paramerters of virtual

[dpdk-dev] [PATCH v6] testpmd: Add port hotplug support

2015-02-03 Thread Qiu, Michael
On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: > The patch introduces following commands. > - port attach [ident] > - port detach [port_id] > - attach: attaching a port > - detach: detaching a port > - ident: pci address of physical device. > Or device name and paramerters of virtual

[dpdk-dev] [PATCH v6] testpmd: Add port hotplug support

2015-02-03 Thread Qiu, Michael
On 2/3/2015 2:16 PM, Qiu, Michael wrote: > On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: >> The patch introduces following commands. >> - port attach [ident] >> - port detach [port_id] >> - attach: attaching a port >> - detach: detaching a port >>

[dpdk-dev] [PATCH v6] testpmd: Add port hotplug support

2015-02-04 Thread Qiu, Michael
On 2/3/2015 6:30 PM, Tetsuya Mukawa wrote: > On 2015/02/03 18:14, Qiu, Michael wrote: >> On 2/3/2015 2:16 PM, Qiu, Michael wrote: >>> On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote: >>>> The patch introduces following commands. >>>> - port attach [ident] &

[dpdk-dev] [PATCH 10/18] fm10k: add dev start/stop functions

2015-02-04 Thread Qiu, Michael
On 1/30/2015 1:08 PM, Chen, Jing D wrote: > From: Jeff Shaw > > 1. Add function to initialize single RX queue. > 2. Add function to initialize single TX queue. > 3. Add fm10k_dev_start, fm10k_dev_stop and fm10k_dev_close >functions. > > Signed-off-by: Jeff Shaw > Signed-off-by: Chen Jing

[dpdk-dev] [RFC PATCH V4] ixgbe: changes to support PCI Port Hotplug

2015-06-24 Thread Qiu, Michael
On 6/9/2015 12:01 AM, Bernard Iremonger wrote: > This patch depends on the Port Hotplug Framework. > It implements the eth_dev_uninit functions for rte_ixgbe_pmd and > rte_ixgbevf_pmd. > > Changes in V4: > Release rx and tx queues in dev_uninit() functions. > Replace TRUE and FALSE with 1 and 0. >

[dpdk-dev] [RFC PATCH V4] ixgbe: changes to support PCI Port Hotplug

2015-06-24 Thread Qiu, Michael
On 6/9/2015 12:01 AM, Bernard Iremonger wrote: > This patch depends on the Port Hotplug Framework. > It implements the eth_dev_uninit functions for rte_ixgbe_pmd and > rte_ixgbevf_pmd. > > Changes in V4: > Release rx and tx queues in dev_uninit() functions. > Replace TRUE and FALSE with 1 and 0. >

[dpdk-dev] [RFC PATCH V2 1/4] i40e: changes to support PCI Port Hotplug

2015-06-24 Thread Qiu, Michael
On 6/5/2015 12:26 AM, Bernard Iremonger wrote: > This patch depends on the Port Hotplug Framework. > It implements the eth_dev_uninit functions for rte_i40e_pmd and > rte_i40evf_pmd. > > Signed-off-by: Bernard Iremonger > --- Tested-by: Michael Qiu > drivers/net/i40e/i40e_ethdev.c| 79

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 6/26/2015 7:02 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Friday, June 26, 2015 9:30 AM >> To: dev at dpdk.org >> Cc: Chen, Jing D; He, Shaopeng; Iremonger, Bernard; Qiu, Michael >> Subject: [PATCH 1/2 v4

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-06-29 Thread Qiu, Michael
On 6/26/2015 5:32 PM, Iremonger, Bernard wrote: > Changes in v2: > do not free mac_addrs and hash_mac_addrs here. > > Signed-off-by: Bernard Iremonger > --- > lib/librte_ether/rte_ethdev.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 6/29/2015 4:57 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Monday, June 29, 2015 9:17 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: Chen, Jing D; He, Shaopeng >> Subject: Re: [PATCH 1/2 v4] fm10k: Free

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 2015/6/29 17:54, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Monday, June 29, 2015 10:21 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: Chen, Jing D; He, Shaopeng >> Subject: Re: [PATCH 1/2 v4] fm10k: Free

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 2015/6/29 19:08, Ananyev, Konstantin wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael >> Sent: Monday, June 29, 2015 10:21 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: He

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 2015/6/29 22:58, Qiu, Michael wrote: > On 2015/6/29 17:54, Iremonger, Bernard wrote: >>> -Original Message- >>> From: Qiu, Michael >>> Sent: Monday, June 29, 2015 10:21 AM >>> To: Iremonger, Bernard; dev at dpdk.org >>> Cc: Chen, Jin

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-06-29 Thread Qiu, Michael
On 2015/6/29 18:20, Iremonger, Bernard wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Monday, June 29, 2015 9:55 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: Zhang, Helin; Ananyev, Konstantin; mukawa at igel.co.jp; Stephen >&

  1   2   3   >