RE: [PATCH v2 0/5] support item NSH matching
Hi, > -Original Message- > From: Haifei Luo > Sent: Monday, September 25, 2023 5:09 AM > To: dev@dpdk.org > Cc: Ori Kam ; Slava Ovsiienko ; > Raslan Darawsheh ; Xueming(Steven) Li > ; Haifei Luo > Subject: [PATCH v2 0/5] support item NSH matching > > NSH can be matched using the existed item: RTE_FLOW_ITEM_TYPE_NSH. > NSH fields matching is not supported. > > Add support for configuring VXLAN-GPE's next protocol. > The CLI is: vxlan-gpe protocol is . > > Add support for matching item NSH. The CLI is: nsh Add support for HCA > attribute query of NSH. > > Enhance the validation for the case matching item NSH is supported. > Add NSH support in net/mlx5. > > V2: Add Ack info in commit message. > > Haifei Luo (5): > app/testpmd: support for VXLAN-GPE's next protocol > common/mlx5: extend HCA attribute query for NSH > net/mlx5: enhance the validation for item VXLAN-GPE > app/testpmd: support for NSH flow item > net/mlx5: add support for item NSH > > app/test-pmd/cmdline_flow.c | 26 ++ > drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > drivers/common/mlx5/mlx5_prm.h | 4 ++- > drivers/net/mlx5/mlx5_flow.c | 52 > drivers/net/mlx5/mlx5_flow.h | 6 > drivers/net/mlx5/mlx5_flow_dv.c | 13 ++- > 7 files changed, 96 insertions(+), 9 deletions(-) > > -- > 2.27.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix jump ipool entry size
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Friday, August 25, 2023 9:44 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix jump ipool entry size
>
> In mlx5 PMD, MLX5_IPOOL_JUMP ipool configuration is used to initialize the
> ipool containing either:
>
> - flow table entry when DV flow engine is chosen or,
> - group table entry when HW steering flow engine is chosen.
>
> Default configuration for MLX5_IPOOL_JUMP ipool specified entry size as size
> of mlx5_flow_tbl_data_entry struct, used with DV flow engine.
> This could lead to memory corruption when mlx5_flow_group struct (used
> with HW steering flow engine) would have bigger size than
> mlx5_flow_tbl_data_entry.
>
> This patch fixes that. Entry size for MLX5_IPOOL_JUMP ipool is chosen
> dynamically based on device configuration.
>
> Fixes: d1559d66ed2d ("net/mlx5: add table management")
> Cc: suanmi...@nvidia.com
> Cc: sta...@dpdk.org
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: adds the checking for Tx queue affinity
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Friday, September 22, 2023 9:50 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: adds the checking for Tx queue affinity > > MLX5 PMD updates the TIS index based on the tx queue affinity, and creates > the DevX SQ object with updated the TIS index. > > This patch adds the checking that set the affinity per Tx Queue if HW objects > can be created by DevX. > > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH v4 0/5] support item NSH matching
Hi, > -Original Message- > From: Haifei Luo > Sent: Sunday, October 8, 2023 6:10 AM > To: dev@dpdk.org > Cc: Ori Kam ; Slava Ovsiienko ; > Raslan Darawsheh ; Xueming(Steven) Li > ; Haifei Luo > Subject: [PATCH v4 0/5] support item NSH matching > > NSH can be matched using the existed item: RTE_FLOW_ITEM_TYPE_NSH. > NSH fields matching is not supported. > > Add support for configuring VXLAN-GPE's next protocol. > The CLI is: vxlan-gpe protocol is . > > Add support for matching item NSH. The CLI is: nsh Add support for HCA > attribute query of NSH. > > Enhance the validation for the case matching item NSH is supported. > Add NSH support in net/mlx5. > > V2: Add Ack info in commit message. > V3: Add more Ack in commi message. > V4: Add nsh in feature ini file. > > Haifei Luo (5): > app/testpmd: support for VXLAN-GPE's next protocol > common/mlx5: extend HCA attribute query for NSH > net/mlx5: enhance the validation for item VXLAN-GPE > app/testpmd: support for NSH flow item > net/mlx5: add support for item NSH > > app/test-pmd/cmdline_flow.c | 26 ++ > doc/guides/nics/features/mlx5.ini| 1 + > drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > drivers/common/mlx5/mlx5_prm.h | 4 ++- > drivers/net/mlx5/mlx5_flow.c | 52 > drivers/net/mlx5/mlx5_flow.h | 6 > drivers/net/mlx5/mlx5_flow_dv.c | 13 ++- > 8 files changed, 97 insertions(+), 9 deletions(-) > > -- > 2.27.0 Series applied to next-net-mlx, Replied originally to V2 Now to the correct version ! Kindest regards, Raslan Darawsheh
RE: [PATCH 1/5] net/mlx5/hws: add support for matching on bth_a bit
Hi, > -Original Message- > From: Itamar Gozlan > Sent: Monday, September 18, 2023 3:07 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Matan > Azrad ; Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH 1/5] net/mlx5/hws: add support for matching on bth_a bit > > RTE_FLOW_ITEM_TYPE_IB_BTH matches an InfiniBand base transport header. > We extend the match on the acknowledgment bit (BTH_A). > > Signed-off-by: Itamar Gozlan Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix device checking for send to kernel action
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Wednesday, October 25, 2023 10:49 AM
> To: Suanming Mou ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix device checking for send to kernel action
>
> The previous commit extended the send to kernel support on FDB table.
> This action creation failed at MLX5 core kernel module, due to the VF/SF ports
> do NOT belong to E-Switch mode.
> The failure caused the kernel stuck with the older MLX5 core kernel version.
>
> This patch adds the checking to avoid creating action at the VF/SF ports on
> the
> FDB table.
>
> Fixes: b2cd39187cd4 ("net/mlx5: extend send to kernel action support")
>
> Signed-off-by: Jiawei Wang
> Acked-by: Suanming Mou
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix wrong decap action checking in sample flow
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Wednesday, October 11, 2023 9:37 AM
> To: Suanming Mou ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix wrong decap action checking in sample flow
>
> This patch uses the temp variable to check the current action type, to avoid
> overlap the sample action following the decap.
>
> Fixes: 7356aec64c48 ("net/mlx5: fix mirror flow split with L3 encapsulation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Suanming Mou
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v7] net/mlx5: add test for live migration
Hi, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, October 25, 2023 12:50 PM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: [PATCH v7] net/mlx5: add test for live migration > > This patch adds testpmd app a runtime function to test the live migration API. > > testpmd> mlx5 set flow_engine [] Flag is optional. > > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > Acked-by: Ori Kam Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix thread termination check on Windows
Hi,
> -Original Message-
> From: Tal Shnaiderman
> Sent: Wednesday, October 12, 2022 9:50 AM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh ;
> paul203...@gmail.com; Idan Hackmon ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
>
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
>
> Fixed to return the correct thread state.
>
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tal Shnaiderman
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix thread workspace memory leak
Hi,
> -Original Message-
> From: Bill Zhou
> Sent: Thursday, October 13, 2022 12:34 PM
> To: Slava Ovsiienko ; Matan Azrad
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> Xueming(Steven) Li ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread workspace memory leak
>
> The thread workspace push/pop should be paired. In the "flow_list_create"
> routine, if error happened the workspace pop was missed. This patch shares
> the workspace pop for all return paths.
>
> Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation")
> Cc: xuemi...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dong Zhou
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2 2/4] net/mlx5: introduce new mlx5 action flag
Hi, > -Original Message- > From: Michael Savisko > Sent: Wednesday, October 19, 2022 9:40 PM > To: dev@dpdk.org > Cc: Michael Savisko ; Ori Kam ; > Slava Ovsiienko ; Asaf Penso > ; Matan Azrad > Subject: [PATCH v2 2/4] net/mlx5: introduce new mlx5 action flag > > Add new mlx5 action flag MLX5_FLOW_ACTION_SEND_TO_KERNEL. > > Add element MLX5_FLOW_FATE_SEND_TO_KERNEL in enum > mlx5_flow_fate_type. > For that purpose field 'fate_action' in structure mlx5_flow_handle must be > expanded from 3 bits to 4 bits. > > Signed-off-by: Michael Savisko > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.h| 7 +-- > drivers/net/mlx5/mlx5_flow_dv.c | 17 + Missing doc update for features list, I'll handle during integration Kindest regards, Raslan Darawsheh
RE: [PATCH v2 0/4] net/mlx5: implement send to kernel action
Hi,
> -Original Message-
> From: Michael Savisko
> Sent: Wednesday, October 19, 2022 9:40 PM
> To: dev@dpdk.org
> Cc: Michael Savisko ; Ori Kam ;
> Slava Ovsiienko ; Asaf Penso
> ; Matan Azrad
> Subject: [PATCH v2 0/4] net/mlx5: implement send to kernel action
>
> This patchset provides mlx5 implementation of new rte_flow action
> RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL.
>
> Depends-on: patch-6838dd4bf976 ("ethdev: add send to kernel action")
>
> Signed-off-by: Michael Savisko
> Acked-by: Matan Azrad
> ---
> v2:
> - updated after code review
>
> v1:
> https://patches.dpdk.org/project/dpdk/list/?series=24734
>
> ---
> Michael Savisko (4):
> common/mlx5: new glue callback for send to kernel action
> net/mlx5: introduce new mlx5 action flag
> net/mlx5: add send to kernel action resource holder
> net/mlx5: translation of rte flow send to kernel action
>
> doc/guides/nics/features/default.ini| 1 +
> doc/guides/nics/features/mlx5.ini | 1 +
> drivers/common/mlx5/linux/meson.build | 2 +
> drivers/common/mlx5/linux/mlx5_glue.c | 17 ++
> drivers/common/mlx5/linux/mlx5_glue.h | 2 +
> drivers/net/mlx5/linux/mlx5_flow_os.h | 22
> drivers/net/mlx5/linux/mlx5_os.c| 13 +
> drivers/net/mlx5/mlx5.h | 6 ++
> drivers/net/mlx5/mlx5_flow.c| 32 +++
> drivers/net/mlx5/mlx5_flow.h| 10 +++-
> drivers/net/mlx5/mlx5_flow_dv.c | 74 +++--
> drivers/net/mlx5/mlx5_flow_hw.c | 3 +
> drivers/net/mlx5/windows/mlx5_flow_os.h | 24
> 13 files changed, 200 insertions(+), 7 deletions(-)
>
> --
> 2.27.0
Series applied to next-net-mlx,
With a small fix for the missing doc on the features list,
Kindest regards,
Raslan Darawsheh
RE: [v6 00/18] net/mlx5: Add HW steering low level support
|9 +-
> drivers/net/mlx5/mlx5.h |8 +-
> drivers/net/mlx5/mlx5_defs.h |2 +
> drivers/net/mlx5/mlx5_devx.c |2 +-
> drivers/net/mlx5/mlx5_dr.c | 383 ---
> drivers/net/mlx5/mlx5_flow.c | 29 +-
> drivers/net/mlx5/mlx5_flow.h | 174 +-
> drivers/net/mlx5/mlx5_flow_dv.c | 2567 +-
> drivers/net/mlx5/mlx5_flow_hw.c | 115 +-
> 48 files changed, 14368 insertions(+), 1694 deletions(-) create mode 100644
> drivers/net/mlx5/hws/meson.build rename drivers/net/mlx5/{mlx5_dr.h =>
> hws/mlx5dr.h} (67%) create mode 100644
> drivers/net/mlx5/hws/mlx5dr_action.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_action.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_buddy.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_buddy.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_cmd.c create mode
> 100644 drivers/net/mlx5/hws/mlx5dr_cmd.h create mode 100644
> drivers/net/mlx5/hws/mlx5dr_context.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_context.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_debug.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_debug.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_definer.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_definer.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_internal.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_matcher.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_matcher.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pat_arg.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pat_arg.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pool.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pool.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_rule.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_rule.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_send.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_send.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_table.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_table.h
> delete mode 100644 drivers/net/mlx5/mlx5_dr.c
>
> --
> 2.18.1
Series applied to next-net-mlx with small modifications to the commit logs,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v6 00/18] net/mlx5: HW steering PMD update
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, October 20, 2022 6:42 PM > Cc: dev@dpdk.org; Raslan Darawsheh ; Ori Kam > > Subject: [PATCH v6 00/18] net/mlx5: HW steering PMD update > > The skeleton of mlx5 HW steering(HWS) has been updated into upstream for > pretty a long time, but not updated anymore due to missing of the low-level > steering layer code. Luckily, better late than never, the steering layer > finnaly > comes[1]. > > This series will add more features to the existing PMD code: > - FDB and metadata copy. > - Modify field. > - Meter color. > - Counter. > - Aging. > - Action template pre-parser optimization. > - Connection tracking. > - Control flow. > > Some features such as meter/aging/ct touches the public API, and public API > changes have been sent to ML much earily in other threads in order not to be > swallowed by this big series. > > The dpends patches as below: > [1]https://inbox.dpdk.org/dev/20220922190345.394-1-va...@nvidia.com/ > > --- > > v6: > - Rebase to the latest version. > > v5: > - Rebase to the latest version. > > v4: > - Disable aging due to the flow age API change still in progress. > https://patches.dpdk.org/project/dpdk/cover/20221019144904.2543586-1- > michae...@nvidia.com/ > - Add control flow for HWS. > > v3: > - Fixed flow can't be aged out. > - Fix error not be filled properly while table creat failed. > - Remove transfer_mode in flow attributes before ethdev layer applied. > https://patches.dpdk.org/project/dpdk/patch/20220928092425.68214-1- > rongw...@nvidia.com/ > > v2: > - Remove the rte_flow patches as they will be integrated in other thread. > - Fix compilation issues. > - Make the patches be better organized. > > Alexander Kozyrev (2): > net/mlx5: add HW steering meter action > net/mlx5: implement METER MARK indirect action for HWS > > Bing Zhao (1): > net/mlx5: add extended metadata mode for hardware steering > > Dariusz Sosnowski (5): > net/mlx5: add HW steering port action > net/mlx5: support DR action template API > net/mlx5: support device control for E-Switch default rule > net/mlx5: support device control of representor matching > net/mlx5: create control flow rules with HWS > > Gregory Etelson (2): > net/mlx5: add HW steering VLAN push, pop and VID modify flow actions > net/mlx5: support flow integrity in HWS group 0 > > Michael Baum (1): > net/mlx5: add HWS AGE action support > > Suanming Mou (6): > net/mlx5: fix invalid flow attributes > net/mlx5: fix IPv6 and TCP RSS hash fields > net/mlx5: add shared header reformat support > net/mlx5: add modify field hws support > net/mlx5: add HW steering connection tracking support > net/mlx5: add async action push and pull support > > Xiaoyu Min (1): > net/mlx5: add HW steering counter action > > doc/guides/nics/features/default.ini |1 + > doc/guides/nics/features/mlx5.ini |2 + > doc/guides/nics/mlx5.rst | 43 +- > doc/guides/rel_notes/release_22_11.rst |8 +- > drivers/common/mlx5/mlx5_devx_cmds.c | 50 + > drivers/common/mlx5/mlx5_devx_cmds.h | 27 + > drivers/common/mlx5/mlx5_prm.h | 22 +- > drivers/common/mlx5/version.map|1 + > drivers/net/mlx5/linux/mlx5_os.c | 78 +- > drivers/net/mlx5/meson.build |1 + > drivers/net/mlx5/mlx5.c| 126 +- > drivers/net/mlx5/mlx5.h| 322 +- > drivers/net/mlx5/mlx5_defs.h |5 + > drivers/net/mlx5/mlx5_flow.c | 409 +- > drivers/net/mlx5/mlx5_flow.h | 335 +- > drivers/net/mlx5/mlx5_flow_aso.c | 797 ++- > drivers/net/mlx5/mlx5_flow_dv.c| 1128 +-- > drivers/net/mlx5/mlx5_flow_hw.c| 8789 +--- > drivers/net/mlx5/mlx5_flow_meter.c | 776 ++- > drivers/net/mlx5/mlx5_flow_verbs.c |8 +- > drivers/net/mlx5/mlx5_hws_cnt.c| 1247 > drivers/net/mlx5/mlx5_hws_cnt.h| 703 ++ > drivers/net/mlx5/mlx5_rxq.c|3 +- > drivers/net/mlx5/mlx5_trigger.c| 272 +- > drivers/net/mlx5/mlx5_tx.h |1 + > drivers/net/mlx5/mlx5_txq.c| 47 + > drivers/net/mlx5/mlx5_utils.h | 10 +- > drivers/net/mlx5/rte_pmd_mlx5.h | 17 + > drivers/net/mlx5/version.map |1 + > 29 files changed, 13589 insertions(+), 1640 deletions(-) create mode 100644 > drivers/net/mlx5/mlx5_hws_cnt.c create mode 100644 > drivers/net/mlx5/mlx5_hws_cnt.h > > -- > 2.25.1 Series applied to next-net-mlx with small modifications to the commit logs. Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix wrong free function in HWS AGE info
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Monday, October 24, 2022 4:28 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ; Michael
> Baum
> Subject: [PATCH] net/mlx5: fix wrong free function in HWS AGE info
>
> In AGE info initialization, the mlx5_hws_q_age_info structure is allocated by
> "mlx5_malloc" function.
>
> However, in case of failure, this structure is released by "rte_free".
>
> This patch changes it to use "mlx5_free".
>
> Fixes: 32c98171674f ("net/mlx5: add HWS AGE action support")
> Cc: michae...@nvidia.com
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
Patch squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix RSS expansion buffer size
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Thursday, October 20, 2022 12:59 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ; Slava
> Ovsiienko ; Lior Margalit
> Subject: [PATCH] net/mlx5: fix RSS expansion buffer size
>
> Increase expansion buffer size to accumulate more RSS types.
>
> Fixes: 3f02c7ff6815 ("net/mlx5: fix RSS expansion for inner tunnel VLAN")
>
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix tunnel header with IPIP offload
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Thursday, October 20, 2022 3:56 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Raslan Darawsheh
> ; Lior Margalit
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix tunnel header with IPIP offload
>
> For the flows with multiple tunnel layers and containing tunnel decap and
> modify actions, for example:
>
> ... / vxlan / eth / ipv4 proto is 4 / end actions raw_decap / modify_field /
> ...
> (note: proto 4 means we have the IP-over-IP tunnel in VXLAN payload)
>
> We have added the multiple tunnel layers validation rejecting the flows like
> above mentioned one.
>
> The hardware supports the above match combination till the inner IP-over-IP
> header (not including the last one), both for IP-over-IPv4 and IP-over-IPv6,
> so we should not blindly reject. Also, for the modify actions following the
> decap we should set the layer attributes correctly.
>
> This patch reverts the below code changes to support the match, and adjusts
> the layers update in case of decap with outer tunnel header.
>
> Fixes: fa06906a48ee ("net/mlx5: fix IPIP multi-tunnel validation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Slava Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [v4] net/mlx5: support matching flow on port representor ID
Hi, > -Original Message- > From: Sean Zhang > Sent: Tuesday, October 25, 2022 9:31 AM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [v4] net/mlx5: support matching flow on port representor ID > > Add support for port_representor item, it will match on traffic originated > from representor port specified in the pattern. This item is supported in FDB > steering domain only (in the flow with transfer attribute). > > For example, below flow will redirect the destination of traffic from ethdev 1 > to ethdev 2. > > testpmd> ... pattern eth / port_representor port_id is 1 / end actions > represented_port ethdev_port_id 2 / ... > > To handle abovementioned item, Tx queue matching is added in the driver, > and the flow will be expanded to number of the Tx queues. If the spec of > port_representor is NULL, the flow will not be expanded and match on traffic > from any representor port. > > Signed-off-by: Sean Zhang > Acked-by: Viacheslav Ovsiienko > --- > The depending patches as below: > > [1] http://patches.dpdk.org/project/dpdk/cover/20220930125315.5079-1- > suanmi...@nvidia.com > --- > v4 - update the commit title > v3 - rebase to the latest version > v2 - commit message updated and add missing feature in doc > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 0/2] mlx5: fix miss NULL check in devargs parsing
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, October 24, 2022 3:34 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 0/2] mlx5: fix miss NULL check in devargs parsing > > The MLX5 PMD parses the devargs in several places. > It gets structure called "devargs" as a member of EAL device containing all > needed information. > > When "devargs" structure is invalid, the PMD avoids parsing it. > However, when it valid but its field "args" is invalid, the PMD tries to > parse it > and dereference to NULL pointer. > > Those patches add checks to avoid these NULL dereferencing. > > > Michael Baum (2): > common/mlx5: fix miss null check in devargs parsing > net/mlx5: fix miss null check in ETH devargs parsing > > drivers/common/mlx5/mlx5_common.c | 8 +--- > drivers/net/mlx5/linux/mlx5_os.c | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > > -- > 2.25.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix assert failure in item translation
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, October 26, 2022 5:09 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix assert failure in item translation
>
> When HW Steering is enabled, mlx5dr translates flow items using DV
> item translation functions to configure flows in root flow table.
> Represented port item stores vport metadata tag in thread-local
> workspace when translate to DV spec. Due to the thread-local workspace
> was not created in HW Steering, it caused an assertion in
> mlx5_flow_get_thread_workspace()
>
> This patch adds initialization of thread-local workspace when flow items
> are translated to DV spec in HW Steering mode.
>
> Fixes: cfddba76af4f ("net/mlx5: add hardware steering item translation
> function")
>
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
Squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5/hws: set ft_type on root matcher creation
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, October 26, 2022 5:10 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh ; Alex Vesker
>
> Subject: [PATCH] net/mlx5/hws: set ft_type on root matcher creation
>
> The ft_type should be provided to mlx5dv_create_flow_matcher
> if the matcher attributes exist, not only for FDB but for NIC
> as well. If the ft_type is not provided, matcher/rule creation
> might fail.
>
> Fixes: ac7931dd1908 ("net/mlx5/hws: add HWS matcher object")
>
> Signed-off-by: Alex Vesker
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
Squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: remove unneeded SQ null checking
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, October 26, 2022 9:33 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: remove unneeded SQ null checking
>
> The ASO SQ is a dynamic array in the ASO pool struct. That means
> the checking of the SQ pointer is incorrect and not needed. And
> the mlx5_aso_destroy_sq() function internally also checks if inside
> the SQ any resources need to be released or not. There is no need
> to have that extra checking.
>
> This commit removes the redundant checking code.
>
> Fixes: aa90929cd5db ("net/mlx5: add HW steering connection tracking
> support")
>
> Signed-off-by: Suanming Mou
> Acked-by: Matan Azrad
Squashed into relevant commit into next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] doc: add Rx buffer split capability for mlx5
Hi,
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, October 9, 2022 11:20 PM
> To: dev@dpdk.org
> Cc: ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru;
> sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko
>
> Subject: [PATCH] doc: add Rx buffer split capability for mlx5
>
> When adding buffer split feature to mlx in DPDK 20.11, it has been forgotten
> to fill the feature matrix.
>
> Fixes: 6c8f7f1c1877 ("net/mlx5: report Rx buffer split capabilities")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Thomas Monjalon
Acked-by: Raslan Darawsheh
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: Impact due to the Electricity Shutdown next week
FYI, This means that we’ll not have any regression tonight. And work on features can continue only on local setups. Kindest regards, Raslan Darawsheh From: Eyal Gruber Sent: Wednesday, November 2, 2022 1:32 PM To: yarong-org Subject: RE: Impact due to the Electricity Shutdown next week Remainder, The cloud will be down starting today at ~15:00 until tomorrow Thanks, Eyal From: Eyal Gruber Sent: Wednesday, 26 October 2022 11:58 To: yarong-org mailto:yarong-...@exchange.nvidia.com>> Subject: Impact due to the Electricity Shutdown next week Importance: High Hi, Next week there will be an electricity Shutdown at Hermon Building (see attached mail) * When: Start time: Wednesday, November 2, 3pm, IL time (the shutdown itself starts at 4pm. Our services will go down 1 hour before) End time: Thursday, November 3, 9am, IL time * Impacted services: * Regressions * CI * OFED builds * Linux cloud Please be aware that additional services which are not provided by our team might also be impacted by the shutdown. Thanks, Eyal
RE: [PATCH 03/13] net/idpf: support device initialization
IRTCHNL2_CAP_TX_CSUM_GENERIC |
> + VIRTCHNL2_CAP_RX_CSUM_L3_IPV4 |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP |
> + VIRTCHNL2_CAP_RX_CSUM_GENERIC;
> +
> + caps_msg.seg_caps =
> + VIRTCHNL2_CAP_SEG_IPV4_TCP |
> + VIRTCHNL2_CAP_SEG_IPV4_UDP |
> + VIRTCHNL2_CAP_SEG_IPV4_SCTP|
> + VIRTCHNL2_CAP_SEG_IPV6_TCP |
> + VIRTCHNL2_CAP_SEG_IPV6_UDP |
> + VIRTCHNL2_CAP_SEG_IPV6_SCTP|
> + VIRTCHNL2_CAP_SEG_GENERIC;
> +
> + caps_msg.rss_caps =
> + VIRTCHNL2_CAP_RSS_IPV4_TCP |
> + VIRTCHNL2_CAP_RSS_IPV4_UDP |
> + VIRTCHNL2_CAP_RSS_IPV4_SCTP|
> + VIRTCHNL2_CAP_RSS_IPV4_OTHER |
> + VIRTCHNL2_CAP_RSS_IPV6_TCP |
> + VIRTCHNL2_CAP_RSS_IPV6_UDP |
> + VIRTCHNL2_CAP_RSS_IPV6_SCTP|
> + VIRTCHNL2_CAP_RSS_IPV6_OTHER |
> + VIRTCHNL2_CAP_RSS_IPV4_AH |
> + VIRTCHNL2_CAP_RSS_IPV4_ESP |
> + VIRTCHNL2_CAP_RSS_IPV4_AH_ESP |
> + VIRTCHNL2_CAP_RSS_IPV6_AH |
> + VIRTCHNL2_CAP_RSS_IPV6_ESP |
> + VIRTCHNL2_CAP_RSS_IPV6_AH_ESP;
> +
> + caps_msg.hsplit_caps =
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L2 |
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L3 |
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L4V4|
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L4V6;
> +
> + caps_msg.rsc_caps =
> + VIRTCHNL2_CAP_RSC_IPV4_TCP |
> + VIRTCHNL2_CAP_RSC_IPV4_SCTP|
> + VIRTCHNL2_CAP_RSC_IPV6_TCP |
> + VIRTCHNL2_CAP_RSC_IPV6_SCTP;
> +
> + caps_msg.other_caps =
> + VIRTCHNL2_CAP_RDMA |
> + VIRTCHNL2_CAP_SRIOV|
> + VIRTCHNL2_CAP_MACFILTER|
> + VIRTCHNL2_CAP_FLOW_DIRECTOR|
> + VIRTCHNL2_CAP_SPLITQ_QSCHED|
> + VIRTCHNL2_CAP_CRC |
> + VIRTCHNL2_CAP_WB_ON_ITR|
> + VIRTCHNL2_CAP_PROMISC |
> + VIRTCHNL2_CAP_LINK_SPEED |
> + VIRTCHNL2_CAP_VLAN;
> +
> + args.ops = VIRTCHNL2_OP_GET_CAPS;
> + args.in_args = (uint8_t *)&caps_msg;
> + args.in_args_size = sizeof(caps_msg);
> + args.out_buffer = adapter->mbx_resp;
> + args.out_size = IDPF_DFLT_MBX_BUF_SIZE;
> +
> + err = idpf_execute_vc_cmd(adapter, &args);
> + if (err) {
> + PMD_DRV_LOG(ERR,
> + "Failed to execute command of
> VIRTCHNL2_OP_GET_CAPS");
> + return err;
> + }
> +
> + rte_memcpy(adapter->caps, args.out_buffer, sizeof(caps_msg));
> +
> + return err;
> +}
> +
> +int
> +idpf_create_vport(__rte_unused struct rte_eth_dev *dev) {
> + uint16_t idx = adapter->next_vport_idx;
> + struct virtchnl2_create_vport *vport_req_info =
> +
RE: [PATCH] net/mlx5: support ESP item in Verbs interface
Hi, > -Original Message- > From: Maayan Kashani > Sent: Wednesday, January 4, 2023 1:59 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Matan Azrad > ; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: support ESP item in Verbs interface > > ESP item is not currently supported in Verbs interface. > > Validate/translate ESP item in Verbs interface. > > Signed-off-by: Maayan Kashani > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 1/4] net/mlx5/hws: definitions for Hash Split/Linear Lookup tbls
Hi, > -Original Message- > From: Yevgeny Kliteynik > Sent: Thursday, January 12, 2023 3:49 PM > To: Yevgeny Kliteynik ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH 1/4] net/mlx5/hws: definitions for Hash Split/Linear Lookup > tbls > > Added PRM bits for new RTC types: Hash Split and Linear Lookup tables, > as well as for HASH_RESULT field that contains hash result of the > Hash Split table calculation. > > Signed-off-by: Yevgeny Kliteynik Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Expect slowness in CI during the week of Feb 5
Hi Guys, Because we are migrating our servers from MTR to MTL, We need to have a shutdown for some of our services/servers in MTR which will affect our CI. In general, the services should continue working, but with a slower resolution time. One of our services (dpdk-tests) will be fully down (can’t be running per PR) during this time. For that, we need your help to make sure you are running the cloud regression yourself on each PR you have. (follow this guideline<https://confluence.nvidia.com/display/NSWX/How+to+run+DPDK+regression+on+cloud+setups>) Kindest regards, Raslan Darawsheh
RE: Expect slowness in CI during the week of Feb 5
You can disregard this email! It was sent by mistake to the wrong mailing address. Sorry for the spam! Kindest regards, Raslan Darawsheh From: Raslan Darawsheh Sent: Monday, January 30, 2023 12:34 PM To: dpdk-team ; dpdk-dev ; shys-org Cc: Ali Alnubani ; Shy Shyman Subject: Expect slowness in CI during the week of Feb 5 Importance: High Hi Guys, Because we are migrating our servers from MTR to MTL, We need to have a shutdown for some of our services/servers in MTR which will affect our CI. In general, the services should continue working, but with a slower resolution time. One of our services (dpdk-tests) will be fully down (can’t be running per PR) during this time. For that, we need your help to make sure you are running the cloud regression yourself on each PR you have. (follow this guideline<https://confluence.nvidia.com/display/NSWX/How+to+run+DPDK+regression+on+cloud+setups>) Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: share QUOTA indirect action
Hi, > -Original Message- > From: Gregory Etelson > Sent: Thursday, June 29, 2023 7:48 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Raslan Darawsheh > ; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Subject: [PATCH] net/mlx5: share QUOTA indirect action > > Support shared indirect QUOTA action. > > flow configure 1 queues_number 4 queues_size 64 quotas_number 32 flow > configure 0 queues_number 4 queues_size 64 quotas_number 0 \ > host_port 1 flags 2 > > flow indirect_action 1 create ingress action_id 8 \ > action quota_create limit 18000 mode l3 / end > > flow actions_template 0 create ingress actions_template_id 1 \ > template shared_indirect / jump / end \ > mask quota_create / jump group 0 / end > > flow queue 0 create 0 template_table 1 \ > pattern_template 0 actions_template 0 postpone no \ > pattern eth / end \ > actions shared_indirect 1 8 / jump group 2 / end > > Signed-off-by: Gregory Etelson Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 1/3] net/mlx5: extend send to kernel action support
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Friday, September 8, 2023 12:21 PM > To: Suanming Mou ; Ori Kam ; > NBU-Contact-Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 1/3] net/mlx5: extend send to kernel action support > > The send to kernel action was supported in NIC and FDB tables, Currently, the > send to kernel action is created in NIC RX only. > > With some TC rules (example: roce packets, redirects into rep ports) and DPDK > RTE rules for the rest of the traffic. Then it needs the specific rule to > re-route > the packets into the kernel through the FDB table. > > This patch adds the FDB and NIC-TX tables support for sending to the kernel > action. > > Signed-off-by: Jiawei Wang Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 1/4] net/mlx5/hws: allow relaxed mode in MPLS matching
Hi, > -Original Message- > From: Erez Shitrit > Sent: Sunday, September 10, 2023 5:03 PM > To: Alex Vesker ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; Suanming Mou > ; Matan Azrad ; Slava > Ovsiienko ; Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH 1/4] net/mlx5/hws: allow relaxed mode in MPLS matching > > > Remove the previous constrain on relaxed mode, that way it will be like all > other matching items, can be used in relaxed or non-relaxed mode. > > The previous constrain was due to HW limitation that supports MPLS over > specific UDP port, now we give the ability to the user to make sure it is with > the right needs for MPLS matching. > > Signed-off-by: Erez Shitrit > Reviewed-by: Alex Vesker > Acked-by: Matan Azrad Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH v3] common/mlx5: replace use of PMD logtype
Hi,
> -Original Message-
> From: Stephen Hemminger
> Sent: Monday, August 21, 2023 7:16 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Slava Ovsiienko
> ; Matan Azrad ; Ori Kam
> ; Suanming Mou ; Gregory
> Etelson
> Subject: [PATCH v3] common/mlx5: replace use of PMD logtype
>
> The goal to eliminate the generic PMD logtype.
> One place it is used unnecessarily is in the mlx5 common code.
> Change the one RTE_LOG() call here to use the same macro as other log
> messages in same file.
>
> Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
> Cc: viachesl...@nvidia.com
> Signed-off-by: Stephen Hemminger
> ---
> v3 - also address use in glue code
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v2 0/6] net/mlx5: reduce Tx datapath compile time
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, April 12, 2021 9:32 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2 0/6] net/mlx5: reduce Tx datapath compile time > > The mlx5_rxtx.c file contains a lot of Tx burst functions, each of those is > performance-optimized for the specific set of requested offloads. > These ones are generated on the basis of the template function and it takes > significant time to compile, just due to a large number of giant functions > generated in the same file and this compilation is not being done in parallel > with using multithreading. > > Therefore, in this series we split the mlx5_rxtx.c file into several separate > files to allow different functions to be compiled simultaneously. > > v2: fix compilation error + rebase > > Michael Baum (6): > net/mlx5: separate Rx function declarations to another file > net/mlx5: separate Rx function implementations to new file > net/mlx5: separate Tx function declarations to another file > net/mlx5: separate Tx burst template to header file > net/mlx5: separate Tx function implementations to new file > net/mlx5: separate Tx burst functions to different files > > drivers/net/mlx5/linux/mlx5_mp_os.c |2 + > drivers/net/mlx5/linux/mlx5_os.c|2 + > drivers/net/mlx5/linux/mlx5_verbs.c |3 +- > drivers/net/mlx5/meson.build|6 + > drivers/net/mlx5/mlx5.c |2 + > drivers/net/mlx5/mlx5_devx.c|3 +- > drivers/net/mlx5/mlx5_ethdev.c |2 + > drivers/net/mlx5/mlx5_flow.c|3 +- > drivers/net/mlx5/mlx5_flow_dv.c |3 +- > drivers/net/mlx5/mlx5_flow_verbs.c |2 +- > drivers/net/mlx5/mlx5_mr.c |2 + > drivers/net/mlx5/mlx5_rss.c |1 + > drivers/net/mlx5/mlx5_rx.c | 1203 > drivers/net/mlx5/mlx5_rx.h | 598 > drivers/net/mlx5/mlx5_rxmode.c |1 - > drivers/net/mlx5/mlx5_rxq.c |3 +- > drivers/net/mlx5/mlx5_rxtx.c| 5468 > +-- > drivers/net/mlx5/mlx5_rxtx.h| 915 +- > drivers/net/mlx5/mlx5_rxtx_vec.c|1 + > drivers/net/mlx5/mlx5_stats.c |3 +- > drivers/net/mlx5/mlx5_trigger.c |3 +- > drivers/net/mlx5/mlx5_tx.c | 780 + > drivers/net/mlx5/mlx5_tx.h | 3734 > drivers/net/mlx5/mlx5_tx_empw.c | 71 + > drivers/net/mlx5/mlx5_tx_mpw.c | 34 + > drivers/net/mlx5/mlx5_tx_nompw.c| 71 + > drivers/net/mlx5/mlx5_tx_txpp.c | 45 + > drivers/net/mlx5/mlx5_txpp.c|3 +- > drivers/net/mlx5/mlx5_txq.c |2 + > drivers/net/mlx5/mlx5_vlan.c|1 + > drivers/net/mlx5/windows/mlx5_os.c |2 + > 31 files changed, 6581 insertions(+), 6388 deletions(-) > create mode 100644 drivers/net/mlx5/mlx5_rx.c > create mode 100644 drivers/net/mlx5/mlx5_rx.h > create mode 100644 drivers/net/mlx5/mlx5_tx.c > create mode 100644 drivers/net/mlx5/mlx5_tx.h > create mode 100644 drivers/net/mlx5/mlx5_tx_empw.c > create mode 100644 drivers/net/mlx5/mlx5_tx_mpw.c > create mode 100644 drivers/net/mlx5/mlx5_tx_nompw.c > create mode 100644 drivers/net/mlx5/mlx5_tx_txpp.c > > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v4 2/2] ethdev: update qfi definition
Kindest regards,
Raslan Darawsheh
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, April 14, 2021 3:17 PM
> To: Ori Kam ; Raslan Darawsheh ;
> dev@dpdk.org; andrew.rybche...@oktetlabs.ru
> Cc: ivan.ma...@oktetlabs.ru; ying.a.w...@intel.com;
> olivier.m...@6wind.com; Slava Ovsiienko ; Shiri
> Kuzin ; sta...@dpdk.org; David Marchand
> ; NBU-Contact-Thomas Monjalon
>
> Subject: Re: [PATCH v4 2/2] ethdev: update qfi definition
>
> On 4/13/2021 10:24 AM, Ori Kam wrote:
> > Hi Raslan,
> >
> >> -Original Message-
> >> From: Raslan Darawsheh
> >> Subject: RE: [PATCH v4 2/2] ethdev: update qfi definition
> >>
> >> Hi,
> >>
> >>> -Original Message-
> >>> From: Ferruh Yigit
> >>> Sent: Tuesday, April 6, 2021 7:10 PM
> >>> To: Raslan Darawsheh ; dev@dpdk.org; Ori Kam
> >>> ; andrew.rybche...@oktetlabs.ru
> >>> Cc: ivan.ma...@oktetlabs.ru; ying.a.w...@intel.com;
> >>> olivier.m...@6wind.com; Slava Ovsiienko ;
> Shiri
> >>> Kuzin ; sta...@dpdk.org; David Marchand
> >>> ; NBU-Contact-Thomas Monjalon
> >>>
> >>> Subject: Re: [PATCH v4 2/2] ethdev: update qfi definition
> >>>
> >>> On 4/4/2021 8:45 AM, Raslan Darawsheh wrote:
> >>>> qfi field is 8 bits which represent single bit for
> >>>> PPP (paging Policy Presence) single bit for RQI
> >>>> (Reflective QoS Indicator) and 6 bits for qfi
> >>>> (QoS Flow Identifier) based on RFC 38415-g30
> >>>>
> >>>> This update the doxygen format and the mask for qfi
> >>>> to properly identify the full 8 bits of the field.
> >>>>
> >>>> note: changing the default mask would cause different
> >>>> patterns generated by testpmd.
> >>>>
> >>>> Fixes: 346553db5bd1 ("ethdev: add GTP extension header to flow API")
> >>>> Cc: ying.a.w...@intel.com
> >>>> Cc: sta...@dpdk.org
> >>>>
> >>>> Signed-off-by: Raslan Darawsheh
> >>>> ---
> >>>>doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++-
> >>>>lib/librte_ethdev/rte_flow.h| 20 +---
> >>>>2 files changed, 19 insertions(+), 4 deletions(-)
> >>>>
> >>>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> index f59eb8a27d..dd39c4c3c2 100644
> >>>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> @@ -3742,7 +3742,8 @@ This section lists supported pattern items and
> >>> their attributes, if any.
> >>>>- ``gtp_psc``: match GTP PDU extension header with type 0x85.
> >>>>
> >>>> - ``pdu_type {unsigned}``: PDU type.
> >>>> - - ``qfi {unsigned}``: QoS flow identifier.
> >>>> +
> >>>> + - ``qfi {unsigned}``: PPP, RQI and QoS flow identifier.
> >>>>
> >>>>- ``pppoes``, ``pppoed``: match PPPoE header.
> >>>>
> >>>> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> >>>> index 6cc57136ac..20b4389429 100644
> >>>> --- a/lib/librte_ethdev/rte_flow.h
> >>>> +++ b/lib/librte_ethdev/rte_flow.h
> >>>> @@ -20,6 +20,7 @@
> >>>>#include
> >>>>#include
> >>>>#include
> >>>> +#include
> >>>>#include
> >>>>#include
> >>>>#include
> >>>> @@ -1421,16 +1422,29 @@ static const struct rte_flow_item_meta
> >>> rte_flow_item_meta_mask = {
> >>>> *
> >>>> * Matches a GTP PDU extension header with type 0x85.
> >>>> */
> >>>> +RTE_STD_C11
> >>>>struct rte_flow_item_gtp_psc {
> >>>> -uint8_t pdu_type; /**< PDU type. */
> >>>> -uint8_t qfi; /**< QoS flow identifier. */
> >>>> +union {
> >>>> +struct {
> >>>> +/*
> >>>> + * These fields are retained for compatibility.
> >>>> + * Please switch to the new header field below.
> >>>> + */
&
Re: [dpdk-dev] [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ
Hi Li,
> -Original Message-
> From: Li Zhang
> Sent: Wednesday, April 14, 2021 5:58 AM
> To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai
> Subject: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ
>
> Initialize the flow meter ASO SQ WQEs with
> all the constant data that should not be updated
> per enqueue operation.
>
> Signed-off-by: Li Zhang
> Acked-by: Matan Azrad
> ---
> drivers/net/mlx5/linux/mlx5_os.c | 17
> drivers/net/mlx5/meson.build | 2 +-
> drivers/net/mlx5/mlx5.c | 68 -
> drivers/net/mlx5/mlx5.h | 22 +++--
> drivers/net/mlx5/mlx5_flow.h | 4 +-
> .../mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} | 96 ---
> drivers/net/mlx5/mlx5_flow_dv.c | 7 +-
> drivers/net/mlx5/mlx5_flow_meter.c| 7 +-
> 8 files changed, 191 insertions(+), 32 deletions(-)
> rename drivers/net/mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} (85%)
>
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index 6ac334263e..ee0d45796a 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -818,6 +818,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
> char name[RTE_ETH_NAME_MAX_LEN];
> int own_domain_id = 0;
> uint16_t port_id;
> + uint32_t log_obj_size;
This would raise this compilation error:
rivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o -MF
drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o.d -o
drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o -c
../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c
../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c: In function 'mlx5_dev_spawn':
../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c:823:11: error: unused variable
'log_obj_size' [-Werror=unused-variable]
uint32_t log_obj_size;
^~~~
When compiling with rdma-core-33
Kindest regards
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD
Hi,
> -Original Message-
> From: Li Zhang
> Sent: Thursday, April 15, 2021 6:11 PM
> To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai
> Subject: [PATCH v5 00/14] Add ASO meter support in MLX5 PMD
>
> To support more meters and better performance,
> MLX HW provide ASO flow meter.
> It can expose millions of ASO flow meter context's in HW.
> This ASO object can allocate the large bulk meter objects.
> This patch set implement the ASO flow meter for mlx5 driver.
> MLX5 PMD driver will be responsible for ASO flow meter manage to HW.
>
> V2: Fix compile error issue (mlx5_glue->destroy_flow_action)
> V3: Fix comments.
> V4: Fix comments and add Acked.
> V5: Fix unused log_obj_size issue.
>
> Li Zhang (10):
> net/mlx5: optimize meter statistics
> common/mlx5: add definitions for ASO flow meter
> common/mlx5: add read ASO flow meter HCA capability
> common/mlx5: add DevX API to create ASO flow meter object
> net/mlx5: flow meter pool to manage meter object
> net/mlx5: initialize the flow meter ASO SQ
> net/mlx5: aso flow meter send WQE and CQE handle
> net/mlx5: add support of ASO meter action
> net/mlx5: make ASO meter queue thread-safe
> net/mlx5: allow multiple flow tables on the same level
>
> Shun Hao (3):
> common/mlx5: add color register idle bits definition
> net/mlx5: fix meter statistics
> net/mlx5: use mask for meter register setting
>
> Suanming Mou (1):
> net/mlx5: support three level table walk
>
> doc/guides/nics/mlx5.rst | 6 +
> drivers/common/mlx5/mlx5_devx_cmds.c | 68 ++
> drivers/common/mlx5/mlx5_devx_cmds.h | 26 +-
> drivers/common/mlx5/mlx5_prm.h| 81 +-
> drivers/common/mlx5/version.map | 1 +
> drivers/net/mlx5/linux/mlx5_os.c | 20 +-
> drivers/net/mlx5/meson.build | 2 +-
> drivers/net/mlx5/mlx5.c | 98 +-
> drivers/net/mlx5/mlx5.h | 258 +-
> drivers/net/mlx5/mlx5_flow.c | 334 +--
> drivers/net/mlx5/mlx5_flow.h | 212 ++---
> .../mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} | 289 +-
> drivers/net/mlx5/mlx5_flow_dv.c | 792 +++-
> drivers/net/mlx5/mlx5_flow_meter.c| 873 --
> drivers/net/mlx5/mlx5_utils.h | 90 ++
> 15 files changed, 2320 insertions(+), 830 deletions(-)
> rename drivers/net/mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} (65%)
>
> --
> 2.27.0
Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax
Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, April 8, 2021 5:13 PM > To: Xueming(Steven) Li ; Slava Ovsiienko > > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Monjalon > ; Asaf Penso ; > ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global > syntax > > Hi, > > > -Original Message- > > From: Xueming(Steven) Li > > Sent: Thursday, April 8, 2021 5:08 PM > > To: Raslan Darawsheh ; Slava Ovsiienko > > > > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > > ; NBU-Contact-Thomas Monjalon > > ; Asaf Penso ; > > ferruh.yi...@intel.com > > Subject: RE: [PATCH v2 1/2] common/mlx5: support device global syntax > > > > Hi Raslan, > > > > Didi you see anything broken? ASAIK, having it in repo shouldn't hurt. > > On your decision :) > No, It doesn't hurt/ break anything really. > But, the idea that it has some logical dependency in the main tree so I'll > only > wait till we'll have it merged then will take this one. > > > > > Thanks, > > Xueming > > > Kindest regards > Raslan Darawsheh
Re: [dpdk-dev] [PATCH 0/2] support single flow dump on MLX5 PMD
Hi,
> -Original Message-
> From: Haifei Luo
> Sent: Wednesday, April 14, 2021 10:23 AM
> To: ferruh.yi...@intel.com; Slava Ovsiienko ;
> Matan Azrad ; xiaoyun...@intel.com; NBU-Contact-
> Thomas Monjalon ; Ori Kam
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> Xueming(Steven) Li ; Haifei Luo
>
> Subject: [PATCH 0/2] support single flow dump on MLX5 PMD
>
> Dump information for all flows are supported and it is
> useful to dump one flow.
> Add single flow dump support on MLX5 PMD.
> Modify API mlx5_flow_dev_dump to support.
> Modify mlx5_socket since one extra arg flow_ptr is added.
>
> Depends-on: series=16355 ("support single flow dump")
> http://patchwork.dpdk.org/project/dpdk/list/?series=16355
>
> Haifei Luo (2):
> common/mlx5: add mlx5 APIs for single flow dump feature
> net/mlx5: add mlx5 APIs for single flow dump feature
>
> drivers/common/mlx5/linux/meson.build | 6 --
> drivers/common/mlx5/linux/mlx5_glue.c | 13 +
> drivers/common/mlx5/linux/mlx5_glue.h | 1 +
> drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++
> drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++
> drivers/common/mlx5/version.map | 1 +
> drivers/net/mlx5/linux/mlx5_socket.c | 30 --
>
> drivers/net/mlx5/mlx5_flow.c | 30
> --
> 8 files changed, 87 insertions(+), 10 deletions(-)
>
> --
> 1.8.3.1
Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax
Sorry for all this confusion, But since we are still missing part of the dependency. so dropping form next-net-mlx again. Kindest regards, Raslan Darawsheh > -Original Message- > From: Raslan Darawsheh > Sent: Monday, April 19, 2021 12:30 PM > To: Raslan Darawsheh ; Xueming(Steven) Li > ; Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Monjalon > ; Asaf Penso ; > ferruh.yi...@intel.com > Subject: RE: [PATCH v2 1/2] common/mlx5: support device global syntax > > Series applied to next-net-mlx, > > Kindest regards, > Raslan Darawsheh > > > -Original Message- > > From: dev On Behalf Of Raslan Darawsheh > > Sent: Thursday, April 8, 2021 5:13 PM > > To: Xueming(Steven) Li ; Slava Ovsiienko > > > > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > > ; NBU-Contact-Thomas Monjalon > > ; Asaf Penso ; > > ferruh.yi...@intel.com > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device > global > > syntax > > > > Hi, > > > > > -Original Message- > > > From: Xueming(Steven) Li > > > Sent: Thursday, April 8, 2021 5:08 PM > > > To: Raslan Darawsheh ; Slava Ovsiienko > > > > > > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > > > ; NBU-Contact-Thomas Monjalon > > > ; Asaf Penso ; > > > ferruh.yi...@intel.com > > > Subject: RE: [PATCH v2 1/2] common/mlx5: support device global syntax > > > > > > Hi Raslan, > > > > > > Didi you see anything broken? ASAIK, having it in repo shouldn't hurt. > > > On your decision :) > > No, It doesn't hurt/ break anything really. > > But, the idea that it has some logical dependency in the main tree so I'll > only > > wait till we'll have it merged then will take this one. > > > > > > > > Thanks, > > > Xueming > > > > > Kindest regards > > Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN/DECAP actions not work in mirror flow
Hi,
> -Original Message-
> From: dev On Behalf Of Jiawei Wang
> Sent: Friday, April 9, 2021 3:37 PM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko ;
> Jiawei(Jonny) Wang
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN/DECAP actions not work in
> mirror flow
>
> Due to hardware limitations the VLAN push/pop and Decap actions following
> the sample action are supported in the FDB Tx steering domain only, the
> flows with incorrect action order for other domains are rejected by
> rdma-core.
>
> To provide the action order requested in RTE flow this patch checks for
> the VLAN or Decap precedence to the sample action and moves the VLAN or
> Decap actions into the next flow in the new table and adds the jump
> action in the prefix sample flow.
>
> This patch also adds the validation for these combination actions.
>
> Fixes: 255b8f86eb6e ("net/mlx5: fix E-Switch egress mirror flow validation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v6 15/15] doc: update release notes for ASO meter
Hi, > -Original Message- > From: Jiawei Wang > Sent: Tuesday, April 20, 2021 1:55 PM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; ferruh.yi...@intel.com; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; Asaf Penso > > Subject: [PATCH v6 15/15] doc: update release notes for ASO meter > > This patches updates the release notes for ASO meter supports. > MLX5 PMD can scale the meter usage from 4K to millions with this > feature. > > Signed-off-by: Jiawei Wang Acked-by: Raslan Darawsheh Kindest regards Raslan Darawsheh
Re: [dpdk-dev] [PATCH v6 00/15] Add ASO meter support in MLX5 PMD
Hi, > -Original Message- > From: Jiawei Wang > Sent: Tuesday, April 20, 2021 1:55 PM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; ferruh.yi...@intel.com; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; Asaf Penso > > Subject: [PATCH v6 00/15] Add ASO meter support in MLX5 PMD > > To support more meters and better performance, > MLX HW provides ASO (Advanced Steering Operation) flow meter. > It can expose millions of ASO flow meter context's in HW. > This ASO object can allocate the large bulk meter objects. > This patch set implement the ASO flow meter for mlx5 driver. > MLX5 PMD driver will be responsible for ASO flow meter manage to HW. > > V2: Fix compile error issue (mlx5_glue->destroy_flow_action) > V3: Fix comments. > V4: Fix comments and add Acked. > V5: Fix unused log_obj_size issue. > V6: Fix comments and update release notes. > > Jiawei Wang (1): > doc: update release notes for ASO meter > > Li Zhang (10): > net/mlx5: optimize meter statistics > common/mlx5: add definitions for ASO flow meter > common/mlx5: add read ASO flow meter HCA capability > common/mlx5: add DevX API to create ASO flow meter object > net/mlx5: flow meter pool to manage meter object > net/mlx5: initialize the flow meter ASO SQ > net/mlx5: add meter ASO queue management > net/mlx5: add support of ASO meter action > net/mlx5: make ASO meter queue thread-safe > net/mlx5: allow multiple flow tables on the same level > > Shun Hao (3): > common/mlx5: add color register idle bits definition > net/mlx5: fix meter statistics > net/mlx5: use mask for meter register setting > > Suanming Mou (1): > net/mlx5: support three level table walk > > doc/guides/nics/mlx5.rst | 6 + > doc/guides/rel_notes/release_21_05.rst | 1 + > drivers/common/mlx5/mlx5_devx_cmds.c | 68 +++ > drivers/common/mlx5/mlx5_devx_cmds.h | 26 +- > drivers/common/mlx5/mlx5_prm.h | 81 ++- > drivers/common/mlx5/version.map| 1 + > drivers/net/mlx5/linux/mlx5_os.c | 20 +- > drivers/net/mlx5/meson.build | 2 +- > drivers/net/mlx5/mlx5.c| 98 +++- > drivers/net/mlx5/mlx5.h| 258 +- > drivers/net/mlx5/mlx5_flow.c | 334 + > drivers/net/mlx5/mlx5_flow.h | 212 +++- > drivers/net/mlx5/mlx5_flow_age.c | 591 -- > drivers/net/mlx5/mlx5_flow_aso.c | 850 > > drivers/net/mlx5/mlx5_flow_dv.c| 792 +-- > --- > drivers/net/mlx5/mlx5_flow_meter.c | 873 + > > drivers/net/mlx5/mlx5_utils.h | 90 > 17 files changed, 2897 insertions(+), 1406 deletions(-) > delete mode 100644 drivers/net/mlx5/mlx5_flow_age.c > create mode 100644 drivers/net/mlx5/mlx5_flow_aso.c > > -- > 1.8.3.1 Removed V5 and v6 applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v7 0/4] net/mlx5: support meter policy operations
Hi,
> -Original Message-
> From: Li Zhang
> Sent: Wednesday, April 21, 2021 6:12 AM
> To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai
> Subject: [PATCH v7 0/4] net/mlx5: support meter policy operations
>
> MLX5 PMD checks the validation of actions in policy while add
> a new meter policy, if pass the validation, allocates the new
> policy object from the meter policy indexed memory pool.
>
> It is common to use the same policy for multiple meters.
> MLX5 PMD supports two types of policy: termination policy and
> no-termination policy.
>
> The termination policy must have a fate action as in the policy
> actions, it can support QUEUE, RSS, PORT_ID, DROP, JUMP, MARK and
> SET_TAG
> actions if policy color is GREEN, also supports DROP action
> if policy color is RED.
>
> The no-termination policy uses policy ID 0 as default policy,
> it is created internal and cannot be changed by API. The default
> policy red action is drop, green action is jump to suffix table.
> Create this policy by policy API with green/yellow no action,
> red with drop action.
> One example in testpmd command:
> add port meter policy 0 g_actions end y_actions end r_actions drop / end
>
> Depends-on: series=16520 ("Add ASO meter support in MLX5 PMD ")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16520
>
> Depends-on: series=16524 ("Support meter policy API ")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16524
>
> v7:
> * Rebase.
> V6:
> * Fix comments about Depends-on.
> V5:
> * Fix comments about destory meter on different ports.
> V4:
> * Fix comments about rte_mtr_meter_policy_add.
> V3:
> * Fix comments about Depends-on.
> V2:
> * Add MLX5_MTR_DEFAULT_POLICY_ID in MLX5 PMD.
>
> Li Zhang (3):
> net/mlx5: support meter policy operations
> net/mlx5: support meter creation with policy
> net/mlx5: prepare sub-policy for a flow with meter
>
> Shun Hao (1):
> net/mlx5: connect meter policy to created flows
>
> doc/guides/nics/mlx5.rst | 12 +
> drivers/net/mlx5/linux/mlx5_os.c | 13 +-
> drivers/net/mlx5/mlx5.c| 77 +-
> drivers/net/mlx5/mlx5.h| 212 +++-
> drivers/net/mlx5/mlx5_flow.c | 654 --
> drivers/net/mlx5/mlx5_flow.h | 119 +-
> drivers/net/mlx5/mlx5_flow_aso.c | 10 +-
> drivers/net/mlx5/mlx5_flow_dv.c| 1896
> ++--
> drivers/net/mlx5/mlx5_flow_meter.c | 742 ++-
> drivers/net/mlx5/mlx5_trigger.c|1 +
> 10 files changed, 3373 insertions(+), 363 deletions(-)
>
> --
> 2.27.0
Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v8 0/4] net/mlx5: support meter policy operations
Hi,
> -Original Message-
> From: Li Zhang
> Sent: Tuesday, April 27, 2021 1:44 PM
> To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai
> Subject: [PATCH v8 0/4] net/mlx5: support meter policy operations
>
> MLX5 PMD checks the validation of actions in policy while add a new meter
> policy, if pass the validation, allocates the new policy object from the meter
> policy indexed memory pool.
>
> It is common to use the same policy for multiple meters.
> MLX5 PMD supports two types of policy: termination policy and no-
> termination policy.
>
> The termination policy must have a fate action as in the policy actions, it
> can
> support QUEUE, RSS, PORT_ID, DROP, JUMP, MARK and SET_TAG actions if
> policy color is GREEN, also supports DROP action if policy color is RED.
>
> The no-termination policy uses policy ID 0 as default policy, it is created
> internal and cannot be changed by API. The default policy red action is drop,
> green action is jump to suffix table.
> Create this policy by policy API with green/yellow no action, red with drop
> action.
> One example in testpmd command:
> add port meter policy 0 g_actions end y_actions end r_actions drop / end
>
> Depends-on: series=16520 ("Add ASO meter support in MLX5 PMD ")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16520
>
> Depends-on: series=16524 ("Support meter policy API ")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16524
>
> V8:
> * Fix comments about release-note
> v7:
> * Rebase.
> V6:
> * Fix comments about Depends-on.
> V5:
> * Fix comments about destory meter on different ports.
> V4:
> * Fix comments about rte_mtr_meter_policy_add.
> V3:
> * Fix comments about Depends-on.
> V2:
> * Add MLX5_MTR_DEFAULT_POLICY_ID in MLX5 PMD.
>
> Li Zhang (3):
> net/mlx5: support meter policy operations
> net/mlx5: support meter creation with policy
> net/mlx5: prepare sub-policy for a flow with meter
>
> Shun Hao (1):
> net/mlx5: connect meter policy to created flows
>
> doc/guides/nics/mlx5.rst | 12 +
> doc/guides/rel_notes/release_21_05.rst |1 +
> drivers/net/mlx5/linux/mlx5_os.c | 13 +-
> drivers/net/mlx5/mlx5.c| 77 +-
> drivers/net/mlx5/mlx5.h| 212 ++-
> drivers/net/mlx5/mlx5_flow.c | 654 +++-
> drivers/net/mlx5/mlx5_flow.h | 119 +-
> drivers/net/mlx5/mlx5_flow_aso.c | 10 +-
> drivers/net/mlx5/mlx5_flow_dv.c| 1895 ++--
> drivers/net/mlx5/mlx5_flow_meter.c | 742 +-
> drivers/net/mlx5/mlx5_trigger.c|1 +
> 11 files changed, 3373 insertions(+), 363 deletions(-)
>
> --
> 2.27.0
Series applied to next-net-mlx,
And removed v7,
Kindest regards
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v5 0/1] Support meter PPS(packet per second) in MLX5 PMD
Hi,
> -Original Message-
> From: Li Zhang
> Sent: Tuesday, April 27, 2021 1:42 PM
> To: Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai
> Subject: [PATCH v5 0/1] Support meter PPS(packet per second) in MLX5 PMD
>
> Currently meter algorithms only supports rate is bytes per second(BPS).
> Add packet_mode flag in meter profile parameters data structure.
> So that it can meter traffic by packet per second.
>
> Depends-on: series=16312 ("Support PPS(packet per second) on meter")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16312
>
> Depends-on: series=16535 ("support meter policy operations")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16535
>
> V5:
> * Fix comments about release-note and merge two patches.
> v4:
> * Rebase.
> V3:
> * Rebase.
> * Fix comments about Depends-on.
> V2:
> * Fix comments about commit-log
>
> Li Zhang (1):
> net/mlx5: support meter PPS profile
>
> doc/guides/nics/mlx5.rst | 1 +
> doc/guides/rel_notes/release_21_05.rst | 1 +
> drivers/common/mlx5/mlx5_prm.h | 8 +++
> drivers/net/mlx5/mlx5_flow_aso.c | 17 +++---
> drivers/net/mlx5/mlx5_flow_meter.c | 74 ++++--
> 5 files changed, 78 insertions(+), 23 deletions(-)
>
> --
> 2.27.0
Series applied to next-net-mlx,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix drop queue function declarations
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Monday, April 5, 2021 1:07 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix drop queue function declarations
>
> There are some leftovers of removed code - there are no drop queue
> handling routines anymore.
>
> Fixes: 78be885295b8 ("net/mlx5: handle drop queues as regular queues")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
> ---
> drivers/net/mlx5/mlx5.h | 2 --
> 1 file changed, 2 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx4: fix buffer leakage on device close
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Saturday, April 17, 2021 8:14 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Matan
> Azrad ; Ori Kam
> Subject: [PATCH] net/mlx4: fix buffer leakage on device close
>
> The mlx4 PMD tracks the buffers (mbufs) for the packets being transmitted
> in the dedicated array named as "elts". The tx_burst routine frees the mbufs
> from this array once it needs to rearm the hardware descriptor and store the
> new mbuf, so it looks like as replacement mbuf pointer in the elts array.
>
> On the device stop mlx4 PMD freed only the part of elts according tail and
> head pointers, leaking the rest of buffers, remained in the elts array.
>
> Fixes: a2ce2121c01c ("net/mlx4: separate Tx configuration functions")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix probing the device in legacy bonding mode
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Wednesday, April 21, 2021 11:10 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix probing the device in legacy bonding mode
>
> If the device was configured as legacy bond one (without involving E-Switch),
> the mlx5 PMD erroneously tried to deduce the vport index raising the fatal
> error and preventing device from being used.
>
> The patch checks whether there is E-Switch present and we should use vport
> index indeed.
>
> Fixes: 2eb4d0107acc ("net/mlx5: refactor PCI probing on Linux")
> Fixes: d5c06b1b10ae ("net/mlx5: query vport index match mode and
> parameters")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH 0/3] mlx5 - support checksum offloads on Windows
Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Wednesday, April 21, 2021 7:35 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Raslan Darawsheh ; Asaf Penso > ; Odi Assli > Subject: [PATCH 0/3] mlx5 - support checksum offloads on Windows > > Support the following checksum offloads on Windows. > > RX supported offloads: > > DEV_RX_OFFLOAD_IPV4_CKSUM > DEV_RX_OFFLOAD_UDP_CKSUM > DEV_RX_OFFLOAD_TCP_CKSUM > > TX supported offloads: > > DEV_TX_OFFLOAD_IPV4_CKSUM > DEV_TX_OFFLOAD_UDP_CKSUM > DEV_TX_OFFLOAD_TCP_CKSUM > > Tal Shnaiderman (3): > net/mlx5: fix unsupported offloads disablement > common/mlx5: read checksum capability from DevX > net/mlx5: support checksum offload on Windows > > drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > drivers/net/mlx5/windows/mlx5_os.c | 20 > 3 files changed, 7 insertions(+), 16 deletions(-) > > -- > 2.16.1.windows.4 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
[dpdk-dev] [PATCH v5 0/1] add new hdr for gtp qfi
This is introducin a new hdr definition of gtp psc support to match the RFC 38415-g30 v2: introduce new header definition for gtp psc update commit msg for rte flow item change. v3: fixed typo in comment Cc relevant people. v4: update hdr definition to have hdr suffix. update variable name to be hdr in the gtp_psc item. update default max to use the new added hdr. v5: updated the hdr definition after code review. dropped the change for rte_flow item psc to avoid ABI breakage added hdr definition for type0 and type1 psc's Raslan Darawsheh (1): ethdev: add new ext hdr for gtp psc lib/net/rte_gtp.h | 78 +++ 1 file changed, 78 insertions(+) -- 2.25.1
[dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc
Define new rte header for gtp PDU session container
based on RFC 38415-g30
Signed-off-by: Raslan Darawsheh
---
lib/net/rte_gtp.h | 78 +++
1 file changed, 78 insertions(+)
diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h
index 6a6f9b238d..5a850a26e4 100644
--- a/lib/net/rte_gtp.h
+++ b/lib/net/rte_gtp.h
@@ -61,6 +61,84 @@ struct rte_gtp_hdr_ext_word {
uint8_t next_ext; /**< Next Extension Header Type. */
} __rte_packed;
+/**
+ * Optional extension for GTP with next_ext set to 0x85
+ * defined based on RFC 38415-g30.
+ */
+__extension__
+struct rte_gtp_psc_generic_hdr {
+ uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t type:4; /**< PDU type */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t pad:3; /**< type specfic pad bits */
+ uint8_t spare:2; /**< type specific spare bits */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+#else
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t spare:2; /**< type specific spare bits */
+ uint8_t pad:3; /**< type specfic pad bits */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t type:4; /**< PDU type */
+#endif
+ uint8_t data[0]; /**< variable length data feilds */
+} __rte_packed;
+
+/**
+ * Optional extension for GTP with next_ext set to 0x85
+ * type0 defined based on RFC 38415-g30
+ */
+__extension__
+struct rte_gtp_psc_type0_hdr {
+ uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t type:4; /**< PDU type */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t snp:1; /**< Sequence number presence */
+ uint8_t spare_dl1:2; /**< spare down link bits */
+ uint8_t ppp:1; /**< Paging policy presence */
+ uint8_t rqi:1; /**< Reflective Qos Indicator */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+#else
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t rqi:1; /**< Reflective Qos Indicator */
+ uint8_t ppp:1; /**< Paging policy presence */
+ uint8_t spare_dl1:2; /**< spare down link bits */
+ uint8_t snp:1; /**< Sequence number presence */
+ uint8_t type:4; /**< PDU type */
+#endif
+ uint8_t data[0]; /**< variable length data feilds */
+} __rte_packed;
+
+/**
+ * Optional extension for GTP with next_ext set to 0x85
+ * type1 defined based on RFC 38415-g30
+ */
+__extension__
+struct rte_gtp_psc_type1_hdr {
+ uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t type:4; /**< PDU type */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t dl_delay_ind:1; /**< dl delay result presence */
+ uint8_t ul_delay_ind:1; /**< ul delay result presence */
+ uint8_t snp:1; /**< Sequence number presence ul */
+ uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
+ uint8_t spare_ul2:1; /**< spare up link bits */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+#else
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t spare_ul2:1; /**< spare up link bits */
+ uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
+ uint8_t snp:1; /**< Sequence number presence ul */
+ uint8_t ul_delay_ind:1; /**< ul delay result presence */
+ uint8_t dl_delay_ind:1; /**< dl delay result presence */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t type:4; /**< PDU type */
+#endif
+ uint8_t data[0]; /**< variable length data feilds */
+} __rte_packed;
+
/** GTP header length */
#define RTE_ETHER_GTP_HLEN \
(sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr))
--
2.25.1
Re: [dpdk-dev] [PATCH v2] net/mlx5: workaround ASO memory region creation
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Monday, April 26, 2021 3:48 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ;
> sta...@dpdk.org
> Subject: [PATCH v2] net/mlx5: workaround ASO memory region creation
>
> Due to kernel issue in direct MKEY creation using the DevX API for
> physical memory, this patch replaces the ASO MR creation to use Verbs
> API.
>
> Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
> ---
> v2:
> The second patch in the series did not work due to a FW issue, this issue does
> not exist in this patch.
>
> drivers/common/mlx5/linux/mlx5_common_verbs.c | 1 -
> drivers/common/mlx5/windows/mlx5_common_os.c | 23 ---
> drivers/net/mlx5/mlx5.h | 10 +--
> drivers/net/mlx5/mlx5_flow_aso.c | 92
> +++
> 4 files changed, 52 insertions(+), 74 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v3] net/mlx5: add power monitoring support
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, April 29, 2021 5:55 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > leif.y.johans...@ericsson.com > Subject: [PATCH v3] net/mlx5: add power monitoring support > > Support the PMD power management API in MLX5 driver. > The monitor policy of this API puts a CPU core to sleep until a data in some > monitored memory address is changed by the NIC. > Implement the get_monitor_addr function to return an address of a CQE > owner bit to monitor the arrival of a new packet. > > Signed-off-by: Alexander Kozyrev > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix the size of tcp flags for modify actions
Hi,
> -Original Message-
> From: Wisam Monther
> Sent: Wednesday, April 28, 2021 1:29 PM
> To: Matan Azrad ; Ori Kam ; Slava
> Ovsiienko ; Alexander Kozyrev
> ; Raslan Darawsheh ;
> dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix the size of tcp flags for modify actions
>
> From RFC the size of the TCP flags is 9, while the defined current size is 6.
>
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: akozy...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Wisam Jaddo
> Reviewed-by: Alexander Kozyrev
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v3] net/mlx5: fix tunnel offload private items location
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Sunday, May 2, 2021 11:08 AM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Ori Kam ; Raslan Darawsheh
> ; sta...@dpdk.org; Slava Ovsiienko
> ; Shahaf Shuler
> Subject: [PATCH v3] net/mlx5: fix tunnel offload private items location
>
> Tunnel offload API requires application to query PMD for specific flow items
> and actions. Application uses these PMD specific elements to build flow rules
> according to the tunnel offload model.
> The model does not restrict private elements location in a flow rule, but the
> current MLX5 PMD implementation expects that tunnel offload rule will
> begin with PMD specific elements.
> The patch removes that placement limitation.
>
> Cc: sta...@dpdk.org
>
> Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
>
> Signed-off-by: Gregory Etelson
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v7 00/17] conntrack support in mlx5 PMD
Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, May 5, 2021 3:23 PM > To: Slava Ovsiienko ; Matan Azrad > ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > > Subject: [PATCH v7 00/17] conntrack support in mlx5 PMD > > This patch set adds the connection tracking offload support in the > mlx5 driver, as well as the documents update. > > --- > v2: code bug fixes, commits clean up and doc update > v3: fix error input pointer for CT MR registering > v4: fix typo in commit message of patch 11 > v5: adjust mkey to lkey in SQ initialization > v6: rebase and solve the conflict > v7: fix compiling for the commits series > --- > > Acked-by: Viacheslav Ovsiienko > > Bing Zhao (17): > common/mlx5: add connection tracking object definition > common/mlx5: add CT offload capability checking > net/mlx5: use meter color reg for CT > net/mlx5: initialization of CT management > common/mlx5: add Dexv CT objects creation > net/mlx5: add modify support for CT > net/mlx5: add actions creating for CT > net/mlx5: close CT management structure > net/mlx5: add ASO CT query implementation > net/mlx5: add ASO CT destroy handling > net/mlx5: add translation of CT action > net/mlx5: add translation of CT item > net/mlx5: add CT context update > net/mlx5: validation of CT action > net/mlx5: validation of CT item > net/mlx5: add support of CT between two ports > doc: update mlx5 support for conntrack > > doc/guides/nics/features/default.ini | 1 + > doc/guides/nics/features/mlx5.ini | 1 + > doc/guides/nics/mlx5.rst | 14 + > doc/guides/rel_notes/release_21_05.rst | 2 + > drivers/common/mlx5/linux/meson.build | 2 + > drivers/common/mlx5/mlx5_devx_cmds.c | 53 +++ > drivers/common/mlx5/mlx5_devx_cmds.h | 5 + > drivers/common/mlx5/mlx5_prm.h | 88 > drivers/common/mlx5/version.map| 1 + > drivers/net/mlx5/linux/mlx5_os.c | 13 + > drivers/net/mlx5/mlx5.c| 92 > drivers/net/mlx5/mlx5.h| 76 > drivers/net/mlx5/mlx5_flow.c | 44 +- > drivers/net/mlx5/mlx5_flow.h | 101 - > drivers/net/mlx5/mlx5_flow_aso.c | 592 > drivers/net/mlx5/mlx5_flow_dv.c | 601 - > 16 files changed, 1683 insertions(+), 3 deletions(-) > > -- > 2.26.2 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation
Hi,
> -Original Message-
> From: dev On Behalf Of Lior Margalit
> Sent: Wednesday, June 16, 2021 10:01 AM
> To: dev@dpdk.org; Slava Ovsiienko ; Matan Azrad
>
> Cc: Ori Kam ; Lior Margalit ;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation
>
> A flow rule must not include multiple tunnel layers.
> An attempt to create such a rule, for example:
> testpmd> flow create .../ vxlan / eth / ipv4 proto is 4 / end
> results in an unclear error.
>
> In the current implementation there is a check for
> multiple IPIP tunnels, but not for combination of IPIP
> and a different kind of tunnel, such as VXLAN. The fix
> is to enhance the above check to use MLX5_FLOW_LAYER_TUNNEL
> that consists of all the tunnel masks. The error message
> will be "multiple tunnel not supported".
>
> Fixes: 5e33bebdd8d3 ("net/mlx5: support IP-in-IP tunnel")
> Cc: sta...@dpdk.org
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
[dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc
Define new rte header for gtp PDU session container
based on RFC 38415-g30
Signed-off-by: Raslan Darawsheh
---
v6 : fixed typos
fixed indentation of comments for fields
---
lib/net/rte_gtp.h | 78 +++
1 file changed, 78 insertions(+)
diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h
index 6a6f9b238d..9f6deb9c7e 100644
--- a/lib/net/rte_gtp.h
+++ b/lib/net/rte_gtp.h
@@ -61,6 +61,84 @@ struct rte_gtp_hdr_ext_word {
uint8_t next_ext; /**< Next Extension Header Type. */
} __rte_packed;
+/**
+ * Optional extension for GTP with next_ext set to 0x85
+ * defined based on RFC 38415-g30.
+ */
+__extension__
+struct rte_gtp_psc_generic_hdr {
+ uint8_t ext_hdr_len;/**< PDU ext hdr len in multiples of 4 bytes */
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t type:4; /**< PDU type */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t pad:3; /**< type specific pad bits */
+ uint8_t spare:2;/**< type specific spare bits */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+#else
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t spare:2;/**< type specific spare bits */
+ uint8_t pad:3; /**< type specific pad bits */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t type:4; /**< PDU type */
+#endif
+ uint8_t data[0];/**< variable length data fields */
+} __rte_packed;
+
+/**
+ * Optional extension for GTP with next_ext set to 0x85
+ * type0 defined based on RFC 38415-g30
+ */
+__extension__
+struct rte_gtp_psc_type0_hdr {
+ uint8_t ext_hdr_len;/**< PDU ext hdr len in multiples of 4 bytes */
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t type:4; /**< PDU type */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t snp:1; /**< Sequence number presence */
+ uint8_t spare_dl1:2;/**< spare down link bits */
+ uint8_t ppp:1; /**< Paging policy presence */
+ uint8_t rqi:1; /**< Reflective Qos Indicator */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+#else
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t rqi:1; /**< Reflective Qos Indicator */
+ uint8_t ppp:1; /**< Paging policy presence */
+ uint8_t spare_dl1:2;/**< spare down link bits */
+ uint8_t snp:1; /**< Sequence number presence */
+ uint8_t type:4; /**< PDU type */
+#endif
+ uint8_t data[0];/**< variable length data fields */
+} __rte_packed;
+
+/**
+ * Optional extension for GTP with next_ext set to 0x85
+ * type1 defined based on RFC 38415-g30
+ */
+__extension__
+struct rte_gtp_psc_type1_hdr {
+ uint8_t ext_hdr_len;/**< PDU ext hdr len in multiples of 4 bytes */
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t type:4; /**< PDU type */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t dl_delay_ind:1; /**< dl delay result presence */
+ uint8_t ul_delay_ind:1; /**< ul delay result presence */
+ uint8_t snp:1; /**< Sequence number presence ul */
+ uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
+ uint8_t spare_ul2:1;/**< spare up link bits */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+#else
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t spare_ul2:1;/**< spare up link bits */
+ uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
+ uint8_t snp:1; /**< Sequence number presence ul */
+ uint8_t ul_delay_ind:1; /**< ul delay result presence */
+ uint8_t dl_delay_ind:1; /**< dl delay result presence */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
+ uint8_t type:4; /**< PDU type */
+#endif
+ uint8_t data[0];/**< variable length data fields */
+} __rte_packed;
+
/** GTP header length */
#define RTE_ETHER_GTP_HLEN \
(sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr))
--
2.25.1
Re: [dpdk-dev] [PATCH] net/mlx5: fix modify field action order for MAC
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, June 16, 2021 5:43 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko ; Matan Azrad
> Subject: [PATCH] net/mlx5: fix modify field action order for MAC
>
> MAC addresses are split into 2 parts inside Mellanox NIC:
> bits 0-15 are separate from bits 16-47. That makes a copy
> from another packet field tricky because any other field
> is aligned to 32 bits, not 16. This causes unexpected
> results when using the MODIFY_FIELD action with MAC addresses.
> Track crossing MAC addresses boundary and arrange a proper
> order for the MODIFY_FIELD action involving MAC addresses.
>
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alexander Kozyrev
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: convert meta register to big-endian
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 5:46 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: convert meta register to big-endian > > Metadata is stored in the CPU order (little-endian format on x86), > while all the packet header fields are stored in the network order. > That leads to the wrong results whenever we try to use the metadata > value in the modify_field actions: bytes are swapped as a result. > > Convert the metadata into the big-endian format before storing it > in the Mellanox NIC to achieve consistent behaviour. > > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Saturday, June 19, 2021 3:49 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; NBU-Contact-Thomas Monjalon > ; sta...@dpdk.org > Subject: [PATCH v2] common/mlx5: add provider query port support to glue > library > > The rdma-core mlx5 provider introduced the port attributes query > API since version v35.0 - the mlx5dv_query_port routine. In order > to support this change in the rdma-core the conditional compilation > flag HAVE_MLX5DV_DR_DEVX_PORT_V35 is introduced by the this patch. > > In the OFED rdma-core version the new compatible mlx5dv_query_port > routine was introduced as well, replacing the existing proprietary > mlx5dv_query_devx_port routine. The proprietary routine was > controlled in PMD code with HAVE_MLX5DV_DR_DEVX_PORT conditional > flag. > > Currently, the OFED rdma-core library contains both versions of > port query API. And this version is a transitional one, there are > the plans to remove the proprietary mlx5dv_query_devx_port routine > and the HAVE_MLX5DV_DR_DEVX_PORT flag in PMD will not work anymore. > > We had one more dependency on this flag in the code (for the > mlx5dv_dr_action_create_dest_ib_port routine) and the patch > fixes mentioned dependency also, by introducing the new > dedicated conditional flag - HAVE_MLX5DV_DR_CREATE_DEST_IB_PORT. > > This patch is highly desirable to be provided in DPDK LTS releases > due to it covers the major compatibility issue. > > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Matan Azrad Removed v1, V2 applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH] common/mlx5: fix Netlink port name attribute padding
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Saturday, June 19, 2021 4:56 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; sta...@dpdk.org
> Subject: [PATCH] common/mlx5: fix Netlink port name attribute padding
>
> On some kernels the string attributes within Netlink reply messages might be
> not padded with zeroes (in cases when string length is aligned with 4-byte
> boundary).
> This caused wrong physical port names recognition and
> mlx5 PMD load failures.
>
> Fixes: 30a86157f6d5 ("net/mlx5: support PF representor")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit
Ok dropping this patch from next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: Shiri Kuzin > Sent: Thursday, June 24, 2021 11:55 AM > To: Raslan Darawsheh ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit > > This patch will be removed for now until FW support is fully done and be > added when the support is completed. > > Regards, > Shiri > > > -Original Message- > > From: Raslan Darawsheh > > Sent: Sunday, June 6, 2021 2:32 PM > > To: Shiri Kuzin ; dev@dpdk.org > > Cc: Matan Azrad ; Slava Ovsiienko > > ; sta...@dpdk.org > > Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit > > > > Hi Shiri, > > > > > -Original Message- > > > From: Shiri Kuzin > > > Sent: Monday, May 31, 2021 2:46 PM > > > To: dev@dpdk.org > > > Cc: Matan Azrad ; Raslan Darawsheh > > > ; Slava Ovsiienko > > > Subject: [PATCH] net/mlx5: update GENEVE TLV option exist bit > > > > > > The GENEVE TLV option matching is done using a flex parser. > > > > > > Recent update in firmware, requires that in order to match on the > > > GENEVE TLV option the "geneve_tlv_option_0_exist" bit should be set. > > > > > > Add the new "geneve_tlv_option_0_exist" setting when translating the > > > GENEVE TLV option item. > > > > > > Signed-off-by: Shiri Kuzin > > > Acked-by: Viacheslav Ovsiienko > > > --- > > > > This is a valid Patch for Stable, so I'll add it during integration > > Cc:sta...@dpdk.org > > > > Patch applied to next-net-mlx, > > > > Kindest regards, > > Raslan Darawsheh
Re: [dpdk-dev] [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows
Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Tuesday, June 22, 2021 6:35 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Raslan Darawsheh ; Asaf Penso > ; Odi Assli > Subject: [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list > in Windows Title too long: Changing to : net/mlx5: add TCP and IPv6 to supported items in Windows > > WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP > and IPv6. > > Added the types to the supported items in mlx5_flow_os_item_supported > to allow them to be created in the PMD. > > Added description of new rules support in Windows kernel driver WINOF2 > 2.70 to the mlx5 driver guide. > > Signed-off-by: Tal Shnaiderman > > --- > v3 merge code and docu changes to a single patch. > --- > --- > doc/guides/nics/mlx5.rst| 3 +++ > drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++ > 2 files changed, 5 insertions(+) Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix meter policy with RSS action
Hi,
> -Original Message-
> From: Li Zhang
> Sent: Wednesday, June 23, 2021 10:25 AM
> To: Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix meter policy with RSS action
>
> When creating the meter sub-policy RSS rule,
> the RSS descriptor was used before its update.
> It also need update tunnel bit in RSS descriptor
> after flow translate.
>
> Use it only when it is updated.
>
> Fixes: ec962bad14e ("net/mlx5: fix metering cleanup on stop")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Li Zhang
> Acked-by: Matan Azrad
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix the modify field action flag checking
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Monday, June 28, 2021 1:58 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; NBU-Contact-Thomas
> Monjalon ; Shahaf Shuler ;
> Alexander Kozyrev
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix the modify field action flag checking
>
> The introduced MODIFY_FIELD action was used to manipulate
> the packet header field through copy or set operations.
>
> These modify header actions should be counted as one action
> in low level, the current code used wrong actions flags
> checking for modify field action.
>
> This patch update the action flags checking into the correct
> MODIFY_HDR_ACTIONS set.
>
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] common/mlx5: share memory free callback
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, June 28, 2021 6:06 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] common/mlx5: share memory free callback > > All the mlx5 drivers using MRs for data-path must unregister the mapped > memory when it is freed by the dpdk process. > > Currently, only the net/eth driver unregisters MRs in free event. > > Move the net callback handler from net driver to common. > > Cc: sta...@dpdk.org > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix the wrong representor ID checking for sample
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Tuesday, June 29, 2021 10:00 AM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; NBU-Contact-Thomas
> Monjalon ; Shahaf Shuler ;
> Xueming(Steven) Li
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix the wrong representor ID checking for sample
>
> The representor definition was introduced in the latest code.
> For non-representor port, like PF port, use the 0x instead of -1.
>
> This patch updates the representor id checking during splitting sample flow.
>
> Fixes: cb95feefdd03 ("net/mlx5: support sub-function representor")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Xueming Li
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix multi-segment inline for the first segment
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, June 22, 2021 7:41 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ali Alnubani ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix multi-segment inline for the first segment
>
> If the first segment in the multi-segment packet is short
> and below the inline threshold it should be inline into
> the WQE to improve the performance. For example, the T-Rex
> traffic generator might use small leading segments to
> handle packet headers and performance was affected.
>
> Fixes: cacb44a09962 ("net/mlx5: add no-inline Tx flag")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix TSO multi-segment inline length
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Sunday, June 20, 2021 9:30 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix TSO multi-segment inline length
>
> The inline data length for TSO ethernet segment should be calculated from
> the TSO header instead of the inline size configured by txq_inline_min
> devarg or reported by the NIC.
> It is imposed by the nature of TSO offload - inline header is being duplicated
> to every output TCP packet.
>
> Fixes: cacb44a09962 ("net/mlx5: add no-inline Tx flag")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] doc: announce common prefix for ethdev
> -Original Message- > From: Ajit Khaparde > Sent: Wednesday, June 30, 2021 6:12 PM > To: Jerin Jacob > Cc: Andrew Rybchenko ; Ferruh Yigit > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Andrew > Rybchenko ; NBU-Contact-Thomas Monjalon > ; David Marchand ; > Qi Z Zhang ; Raslan Darawsheh > ; Jerin Jacob Kollanukkaran > Subject: Re: [dpdk-dev] [PATCH] doc: announce common prefix for ethdev > > On Wed, Jun 30, 2021 at 8:03 AM Jerin Jacob > wrote: > > > > On Wed, Jun 30, 2021 at 7:28 PM Andrew Rybchenko > > wrote: > > > > > > On 6/30/21 12:21 PM, Ferruh Yigit wrote: > > > > Announce adding 'RTE_ETH_' prefix to all public ethdev macros/enums > on > > > > v21.11. > > > > Backward compatibility macros will be added on v21.11 and they will be > > > > removed on v22.11. > > > > > > > > Signed-off-by: Ferruh Yigit > > > > --- > > > > Cc: Andrew Rybchenko > > > > Cc: Thomas Monjalon > > > > Cc: David Marchand > > > > Cc: Qi Z Zhang > > > > Cc: Raslan Darawsheh > > > > Cc: Ajit Khaparde > > > > Cc: Jerin Jacob Kollanukkaran > > > > --- > > > > doc/guides/rel_notes/deprecation.rst | 5 + > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > > > index 9584d6bfd723..ae79673e37e3 100644 > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > @@ -118,6 +118,11 @@ Deprecation Notices > > > > consistent with existing outer header checksum status flag naming, > which > > > > should help in reducing confusion about its usage. > > > > > > > > +* ethdev: Will add 'RTE_ETH_' prefix to all ethdev macros/enums in > v21.11. Macros > > > > + will be added for backward compatibility. Backward compatibility > macros will be > > > > + removed on v22.11. A few old backward compatibility macros from > 2013 that does > > > > + not have proper prefix will be removed on v21.11. > > > > + > > > > * i40e: As there are both i40evf and iavf pmd, the functions of them > are > > > > duplicated. And now more and more advanced features are > developed on iavf. > > > > To keep consistent with kernel driver's name > > > > > > > > > > Acked-by: Andrew Rybchenko > > Acked-by: Jerin Jacob > Acked-by: Ajit Khaparde Acked-by: Raslan Darawsheh
Re: [dpdk-dev] [PATCH v1 0/4] ASO meter sharing support
Hi, > -Original Message- > From: Shun Hao > Sent: Friday, July 2, 2021 12:15 PM > To: Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; Roni > Bar Yanai > Subject: [PATCH v1 0/4] ASO meter sharing support > > This adds several fixes in ASO meter. With these fixes, meter created on one > port can be shared by other ports. > > Shun Hao (4): > net/mlx5: use meter profile lookup table > net/mlx5: fix meter policy ID table container > net/mlx5: fix meter flow direction check > net/mlx5: fix meter policy flow match item > > doc/guides/nics/mlx5.rst | 8 +++ > drivers/net/mlx5/linux/mlx5_os.c | 6 +- > drivers/net/mlx5/mlx5.c| 2 - > drivers/net/mlx5/mlx5.h| 7 ++- > drivers/net/mlx5/mlx5_flow.c | 83 --- > drivers/net/mlx5/mlx5_flow_dv.c| 58 --- > drivers/net/mlx5/mlx5_flow_meter.c | 91 +- > drivers/net/mlx5/windows/mlx5_os.c | 6 +- > 8 files changed, 172 insertions(+), 89 deletions(-) > > -- > 2.20.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: document workaround for ConnectX-4 with L2 encap
Hi,
> -Original Message-
> From: dev On Behalf Of Dmitry Kozlyuk
> Sent: Wednesday, June 30, 2021 10:01 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Slava Ovsiienko ; Matan
> Azrad ; Shahaf Shuler
> Subject: [dpdk-dev] [PATCH] net/mlx5: document workaround for
> ConnectX-4 with L2 encap
>
> ConnectX-4 and ConnectX-4 Lx NICs require all L2 headers of transmitted
> packets to be inlined. By default only first 18 bytes are inlined,
> which is insufficient if additional encapsulation is used, like Q-in-Q.
> Thus, default settings caused such traffic to be dropepd on Tx.
> Document a workaround to increase inlined data size in such cases.
>
> Fixes: 505f1fe426d3 ("net/mlx5: add Tx devargs")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk
> Reviewed-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: support flow dump value
Hi, > -Original Message- > From: Haifei Luo > Sent: Monday, May 31, 2021 5:22 AM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; Shahaf Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh > Subject: [PATCH] net/mlx5: support flow dump value > > Currently the flow dump provides few information about actions > - just the pointers. Add implementations to display details for > counter, modify_hdr and encap_decap actions. > > For counter, the regular flow operation query is engaged and > the counter content information is provided, including hits > and bytes values.For modify_hdr, encap_and decap actions, > the information stored in the ipool objects is dumped. > > There are the formats of information presented in the dump: > Counter: rec_type,id,hits,bytes > Modify_hdr: rec_type,id,actions_number,actions > Encap_decap: rec_type,id,buf > > Signed-off-by: Haifei Luo Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect r/w lock usage in DMA unmap
Hi,
> -Original Message-
> From: dev On Behalf Of Feifei Wang
> Sent: Thursday, May 27, 2021 12:48 PM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko
> Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ;
> Shahaf Shuler ; sta...@dpdk.org; Ruifeng Wang
>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix incorrect r/w lock usage in DMA
> unmap
>
> For mlx5 DMA unmap, write lock should be used for rebuilding memory
> region cache table rather than read lock.
>
> Fixes: 989e999d9305 ("net/mlx5: support PCI device DMA map and unmap")
> Cc: shah...@mellanox.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Feifei Wang
> Reviewed-by: Ruifeng Wang
Patch rebased and applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix pattern expansion in RSS flow rules
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Wednesday, June 30, 2021 10:20 AM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ;
> sta...@dpdk.org; Slava Ovsiienko ; Shahaf Shuler
> ; Dekel Peled ; Ferruh Yigit
>
> Subject: [PATCH] net/mlx5: fix pattern expansion in RSS flow rules
>
> Flow rule pattern may be implicitly expanded by the PMD if the rule
> has RSS flow action. The expansion adds network headers to the
> original pattern. The new pattern lists all network levels that
> participate in the rule RSS action.
>
> The patch validates that buffer for expanded pattern has enough bytes
> for new flow items.
>
> Fixes: c7870bfe09dc ("ethdev: move RSS expansion code to mlx5 driver")
>
> Cc: sta...@dpdk.org
> Signed-off-by: Gregory Etelson
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key
Hi,
> -Original Message-
> From: dev On Behalf Of Xiaoyu Min
> Sent: Thursday, July 1, 2021 8:55 AM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko ; Jack Min
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key
>
> Currently PMD needs previous layer information in order to set
> corresponding match field for MPLSoGRE or MPLSoUDP.
>
> GRE_KEY item is missing as supported previous layer when translate
> item MPLS, which causes flow[1] cannot match MPLS over GRE traffic.
>
> According to RFC4023, MPLS over GRE tunnel with optional key
> field needs to be supported too.
>
> By adding missing GRE_KEY as supported previous layer fix problem.
>
> [1]:
> flow create 0 ingress pattern eth / ipv6 / gre k_bit is 1 / gre_key /
> mpls label is 966138 / end actions queue index 1 / mark id 0xa / end
>
> Fixes: a7a0365565a4 ("net/mlx5: match GRE key and present bits")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Xiaoyu Min
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] common/mlx5: fix Netlink receive message buffer size
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Thursday, July 1, 2021 10:32 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] common/mlx5: fix Netlink receive message buffer size
>
> If there are many VFs the Netlink message length sent by kernel
> in reply to RTM_GETLINK request can be large. We should query
> the size of message being received in advance and allocate
> the large enough buffer to handle these large messages.
>
> Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix L4 integrity translation
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Monday, July 5, 2021 12:05 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ; Slava
> Ovsiienko ; Shahaf Shuler
> Subject: [PATCH] net/mlx5: fix L4 integrity translation
>
> MLX5 PMD supports L3 and L4 integrity bits.
> L4 checksum-ok bit was not translated correctly.
> The patch updates the l4_csum_ok integrity bit translation.
>
> Fixes: 79f8952783d0 ("net/mlx5: support integrity flow item")
Added missing Cc: sta...@dpdk.org
>
> Signed-off-by: Gregory Etelson
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH] net/mlx5: fix offset calculation for modify field action
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Monday, July 5, 2021 12:47 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko ; Matan Azrad
> Subject: [PATCH] net/mlx5: fix offset calculation for modify field action
>
> Offsets are not taken into account during MAC addresses
> manipulation for the MODIFY_FIELD action. That leads to
> a wrong split between 0-15 and 16-47 bits and corrupted
> data being copied to/from MAC addresses. Use both source
> and destination offsets to calcucate the proper modify
> header action specification.
>
> Fixes: fdd0c046f4 ("net/mlx5: fix modify field action order for MAC")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alexander Kozyrev
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc
Hi Guys, Sorry for missing this mail, for some reason it was missed in my inbox, This is the link to this rfc: https://www.3gpp.org/ftp/Specs/archive/38_series/38.415/38415-g30.zip Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Thursday, July 1, 2021 5:06 PM > To: Singh, Aman Deep ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc > > Hi Raslan, > > could you reply, please. > > Andrew. > > On 6/22/21 10:27 AM, Singh, Aman Deep wrote: > > Hi Raslan, > > > > Can you please provide link to this RFC 38415-g30 I just had some > > doubt on byte-order conversion as per RFC 1700 > > <https://tools.ietf.org/html/rfc1700> > > > > Regards > > Aman
Re: [dpdk-dev] [PATCH 0/3] MPLS RSS fixs
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Friday, July 2, 2021 11:35 AM > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] MPLS RSS fixs > > This patch set fixs several problems of MPLS RSS: > > - removed MPLSoIP(HW doesn't support) related code > - support MPLSoUDP, MPLSoGRE RSS expansion > - reduced number of expanded sub-flows for inner MPLS > > Xiaoyu Min (3): > net/mlx5: fix MPLS over IP > net/mlx5: fix MPLS RSS expansion > net/mlx5: limit inner RSS expansion for MPLS > > drivers/net/mlx5/mlx5_flow.c| 31 +-- > drivers/net/mlx5/mlx5_flow_dv.c | 3 --- > 2 files changed, 21 insertions(+), 13 deletions(-) > > -- > 2.32.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v1 0/4] Add support for meter hierarchy
Hi, > -Original Message- > From: Shun Hao > Sent: Tuesday, July 6, 2021 4:15 PM > To: Ori Kam ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh > Subject: [PATCH v1 0/4] Add support for meter hierarchy > > This adds support for meter hierarchy, which means multiple meters can > be chained together, and using the header meter of hierarchy in a flow > will apply all meters in hierarchy to that flow. > > Shun Hao (4): > net/mlx5: support meter action in meter policy > net/mlx5: support meter hierarchy drop count > net/mlx5: meter hierarchy destroy and cleanup > net/mlx5: validate meter action in policy > > doc/guides/nics/mlx5.rst | 15 + > doc/guides/rel_notes/release_21_08.rst | 6 + > drivers/net/mlx5/mlx5.h| 32 +- > drivers/net/mlx5/mlx5_flow.c | 123 +++-- > drivers/net/mlx5/mlx5_flow.h | 12 + > drivers/net/mlx5/mlx5_flow_dv.c| 701 + > drivers/net/mlx5/mlx5_flow_meter.c | 175 +- > 7 files changed, 935 insertions(+), 129 deletions(-) > > -- > 2.21.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v2 0/2] control rules with identical pattern behavior
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Tuesday, July 6, 2021 11:12 AM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2 0/2] control rules with identical pattern behavior > > In order to allow\disallow configuring rules with identical > patterns, the new device argument 'allow_duplicate_pattern' > is introduced. > If allow, these rules be inserted successfully and only the > first rule take affect. > If disallow, the first rule will be inserted and other rules > be rejected. > > The default is to allow. > Set it to 0 if disallow, for example: > -a ,allow_duplicate_pattern=0 > > Jiawei Wang (2): > common/mlx5: add glue function for duplicate rule ability > net/mlx5: control rules with identical pattern behavior > > doc/guides/nics/mlx5.rst | 14 ++ > doc/guides/rel_notes/release_21_08.rst | 6 ++ > drivers/common/mlx5/linux/meson.build | 2 ++ > drivers/common/mlx5/linux/mlx5_glue.c | 12 > drivers/common/mlx5/linux/mlx5_glue.h | 1 + > drivers/net/mlx5/linux/mlx5_os.c | 10 ++ > drivers/net/mlx5/mlx5.c| 6 ++ > drivers/net/mlx5/mlx5.h| 2 ++ > drivers/net/mlx5/mlx5_flow_dv.c| 12 > 9 files changed, 61 insertions(+), 4 deletions(-) > > -- > 2.18.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc
Thank you for the review, Basically it's not used yet since it will break the abi The main usage was in rte_flow item of gtp_psc To replace the current structure with the header definition. And since this will break the abi I'm adding the header definition now but will be used later in rte_flow. Kindest regards, Raslan Darawsheh From: Andrew Rybchenko Sent: Thursday, July 8, 2021, 12:23 PM To: Raslan Darawsheh; Singh, Aman Deep; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc Hi Raslan, On 7/6/21 5:24 PM, Raslan Darawsheh wrote: > Hi Guys, > > Sorry for missing this mail, for some reason it was missed in my inbox, > This is the link to this rfc: > https://www.3gpp.org/ftp/Specs/archive/38_series/38.415/38415-g30.zip Thanks for the link. The patch LGTM, but I have only one question left. Where is it used? Are you going to upstream corresponding code in the release cycle? Andrew. > Kindest regards, > Raslan Darawsheh > >> -Original Message- >> From: dev On Behalf Of Andrew Rybchenko >> Sent: Thursday, July 1, 2021 5:06 PM >> To: Singh, Aman Deep ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc >> >> Hi Raslan, >> >> could you reply, please. >> >> Andrew. >> >> On 6/22/21 10:27 AM, Singh, Aman Deep wrote: >>> Hi Raslan, >>> >>> Can you please provide link to this RFC 38415-g30 I just had some >>> doubt on byte-order conversion as per RFC 1700 >>> <https://tools.ietf.org/html/rfc1700> >>> >>> Regards >>> Aman
Re: [PATCH] net/mlx5: fix data access race condition for shared Rx queue
Hi,
From: Jiawei(Jonny) Wang
Sent: Friday, July 5, 2024 4:05 PM
To: Bing Zhao; Slava Ovsiienko; Dariusz Sosnowski; Ori Kam; Suanming Mou; Matan
Azrad; Alexander Kozyrev
Cc: dev@dpdk.org; Raslan Darawsheh; sta...@dpdk.org
Subject: [PATCH] net/mlx5: fix data access race condition for shared Rx queue
The rxq_data resources were shared for shared Rx queue with the same
group and queue ID.
The cq_ci:24 of rxq_data was unalignment with other fields in the one
32-bit data, like the dynf_meta and delay_drop.
32bit: xxxI IIIx
^ ...^
| cq_ci |
The issue is that while the control thread updates the dynf_meta:1 or
delay_drop:1 value during port start, another data thread updates the
cq_ci at the same time, it causes the bytes race condition with
different thread, and cq_ci value may be overwritten and updated the
abnormal value into HW CQ DB.
This patch separates the cq_ci from the configuration data spaces, and
adds checking for delay_drop and dynf_meta if shared Rx queue if
started.
Fixes: 02a6195cbe ("net/mlx5: support enhanced CQE compression in Rx burst")
Cc: sta...@dpdk.org
Signed-off-by: Jiawei Wang
Acked-by: Bing Zhao
Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH] net/mlx5: fix indexed pool resize
Hi,
From: Gregory Etelson
Sent: Sunday, July 7, 2024 12:48 PM
To: dev@dpdk.org
Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski; Slava
Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix indexed pool resize
On success, indexed pool resize sets maximal pool entries number to
the `num_entries` parameter value.
The patch fixes maximal pool entries assignment.
The patch also adds `error` parameter to log error types.
Fixes: 89578504edd9 ("net/mlx5: add ipool resize function")
Signed-off-by: Gregory Etelson
Acked-by: Dariusz Sosnowski
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH] net/mlx5: fix IPv6-in-IPv6 tunnel recognition
Hi,
From: Gregory Etelson
Sent: Sunday, July 7, 2024 1:13 PM
To: dev@dpdk.org
Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski; Slava
Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix IPv6-in-IPv6 tunnel recognition
The PMD did not recognize IPv6-in-IPv6 tunnel if IPv6 routing
extension was placed between IPv6 outer and inner headers.
The patch fixes IPv6-in-IPv6 tunnel recognition.
Fixes: 80c676259a04 ("net/mlx5: validate HWS template items")
Signed-off-by: Gregory Etelson
Acked-by: Dariusz Sosnowski
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH] net/mlx5: fix compilation warning in GCC-9.1
Hi,
From: Gregory Etelson
Sent: Sunday, July 7, 2024 12:57 PM
To: dev@dpdk.org
Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; sta...@dpdk.org; Dariusz
Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix compilation warning in GCC-9.1
GCC has introduced a bugfix in 9.1 that changed GCC ABI in ARM setups:
https://gcc.gnu.org/gcc-9/changes.html
```
On Arm targets (arm*-*-*), a bug in the implementation of the
procedure call standard (AAPCS) in the GCC 6, 7 and 8 releases
has been fixed: a structure containing a bit-field based on a 64-bit
integral type and where no other element in a structure required
64-bit alignment could be passed incorrectly to functions.
This is an ABI change. If the option -Wpsabi is enabled
(on by default) the compiler will emit a diagnostic note for code
that might be affected.
```
The patch fixes PMD compilation in the INTEGRITY flow item.
Fixes: 23b0a8b298b1 ("net/mlx5: fix integrity item validation and translation")
Cc: sta...@dpdk.org
Signed-off-by: Gregory Etelson
Acked-by: Dariusz Sosnowski
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH] net/mlx5: fix MTU configuration
Hi,
From: Dariusz Sosnowski
Sent: Monday, July 8, 2024 1:59 PM
To: Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: [PATCH] net/mlx5: fix MTU configuration
Apply provided MTU, derived from rte_eth_conf.rxmode.mtu,
on port configuration.
Bugzilla ID: 1483
Fixes: e60fbd5b24fc ("mlx5: add device configure/start/stop")
Cc: sta...@dpdk.org
Signed-off-by: Dariusz Sosnowski
Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH 0/8] HW steering team updates
Hi Itamar, From: Itamar Gozlan Sent: Tuesday, July 9, 2024 3:30 PM To: Itamar Gozlan; Erez Shitrit; Hamdan Agbariya; Yevgeny Kliteynik; Alex Vesker; Slava Ovsiienko; NBU-Contact-Thomas Monjalon (EXTERNAL); Suanming Mou Cc: dev@dpdk.org; Ori Kam Subject: [PATCH 0/8] HW steering team updates This patch series contains 8 commits from the HW steering team, addressing various improvements and fixes in the DPDK project. This is the second version of this submission. The previous version erroneously included two unnecessary commits, which have been removed in this iteration. Alex Vesker (1): net/mlx5/hws: fix incorrect port ID on root item convert Erez Shitrit (6): net/mlx5/hws: set eswitch owner vhc ID valid accordingly net/mlx5/hws: fix memory leak in modify header free net/mlx5/hws: fix deletion of action vport net/mlx5/hws: take out not needed variable net/mlx5/hws: fix NAT64 csum issue net/mlx5/hws: fix NA64 copy TOS field instead of TTL Itamar Gozlan (1): net/mlx5/hws: strictly range templates check fix drivers/net/mlx5/hws/mlx5dr_action.c | 213 ++ drivers/net/mlx5/hws/mlx5dr_action.h | 17 +- drivers/net/mlx5/hws/mlx5dr_cmd.c | 6 +- drivers/net/mlx5/hws/mlx5dr_cmd.h | 1 + drivers/net/mlx5/hws/mlx5dr_definer.c | 11 +- drivers/net/mlx5/hws/mlx5dr_matcher.c | 20 +-- drivers/net/mlx5/hws/mlx5dr_pat_arg.h | 1 - drivers/net/mlx5/hws/mlx5dr_rule.c| 22 +-- 8 files changed, 216 insertions(+), 75 deletions(-) -- 2.39.3 Series applied to next-net-mlx, Kindest regards Raslan Darawsheh
Re: [PATCH] net/mlx5: fix end condition of reading xstats
Hi,
From: Bing Zhao
Sent: Wednesday, July 17, 2024 7:33 PM
To: Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh
Cc: Ori Kam; Dariusz Sosnowski; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix end condition of reading xstats
The "mlx5_stats_n" in the "struct mlx5_xstats_ctrl" is the number of
device stats identified by PMD. Right now, the mapping of device
stats to the xstats is not compact. The "input index" of the device
stats would remain UINT16_MAX and be skipped when reading counters.
If some DPDK stats cannot be identified in the middle of the map, the
end condition should be bigger than the "mlx5_stats_n". Or else, some
counters would not be read and calculated.
Using the global const "xstats_n" as the end condition to traverse
the whole array in case some counters are missed. The "xstats_o_idx"
should be used instead of the iteration to check if the statistics
is an IB device counter.
In the meanwhile, adding another field to record the start index of
the IB counters to reduce the redundancy iterations.
Fixes: a687c3e658c2 ("net/mlx5: fix counters map in bonding mode")
Signed-off-by: Bing Zhao
Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH] net/mlx5: fix the uplink port probing in bond mode
Hi,
From: Bing Zhao
Sent: Wednesday, July 17, 2024 7:35 PM
To: Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh
Cc: Ori Kam; Dariusz Sosnowski; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix the uplink port probing in bond mode
In the HW-LAG bonding mode, the representor port can be from both
slave PFs. When probing a representor (REP), the UPLINK (proxy) port
always needs to be probed firstly before any REP port.
In the current implementation, when probing a device with the
following format:
-a :XX:00.0,dv_flow_en=N,representor=pf1vfy
Since the REP belongs to the 2nd PF in the bonding, the UPLINK would
not be added into the probing ports list.
1. In dv_flow_en=1 mode, the REP itself can be probed. But it didn't
obey the rules and the behaviors were inconsistent.
a. When probing the REP from 1st PFs, the UPLINK was also probed.
b. When detaching the UPLINK, all REPs were detached.
2. In dv_flow_en=2 mode, since some resources can only be allocated /
created on the proxy port, the probing would get a failure.
By removing the unneeded check of the bonding PF device index, the
UPLINK will always try to be probed with any format.
Fixes: 2e569a370395 ("net/mlx5: add VF LAG mode bonding device recognition")
Signed-off-by: Bing Zhao
Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH] common/mlx5: remove unneeded field when modify RQ table
Hi,
From: Bing Zhao
Sent: Wednesday, July 17, 2024 7:37 PM
To: Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh
Cc: Ori Kam; Dariusz Sosnowski; Suanming Mou; Matan Azrad
Subject: [PATCH] common/mlx5: remove unneeded field when modify RQ table
The attribute "rqt_max_size" of the RQT(RQ table) context is only
needed by when creating a new one. When modifying an old one, there
is no need to set this attribute.
The firmware usually ignored this unneeded field. When enabling some
extra check, an error will be returned to prevent the code from
continuing to run.
In the meanwhile, this field will always be set to the maximal one
fetched from the capability without any change. Removing the value
set and leave it to 0 will help to solve the potential failure.
Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
Cc: ma...@nvidia.com
Signed-off-by: Bing Zhao
Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
Re: [PATCH 0/3] net/mlx5: E-Switch and validation fixes
Hi, From: Dariusz Sosnowski Sent: Thursday, July 18, 2024 12:57 PM To: Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad Cc: dev@dpdk.org; Raslan Darawsheh Subject: [PATCH 0/3] net/mlx5: E-Switch and validation fixes Patch 1 - Fixes a bug with fdb_def_rule_en device argument, used to control default E-Switch flow rules created by mlx5 PMD. Patches 2-3 - Fixes for flow rule validation in async flow API, which were found during testing. Dariusz Sosnowski (3): net/mlx5: fix disabling E-Switch default flow rules net/mlx5: fix action configuration validation net/mlx5: fix RSS and queue action validation drivers/net/mlx5/mlx5_flow_hw.c | 182 +--- drivers/net/mlx5/mlx5_trigger.c | 4 +- drivers/net/mlx5/mlx5_txq.c | 13 ++- 3 files changed, 107 insertions(+), 92 deletions(-) series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Re: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs
Hi, From: Alexander Kozyrev Sent: Wednesday, November 1, 2023 4:57 PM To: dev@dpdk.org Cc: Suanming Mou; Slava Ovsiienko; Raslan Darawsheh Subject: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs Keep unzipping if the next CQE is the miniCQE array in rxq_cq_decompress_v() routine only for non-MPRQ scenario, MPRQ requires buffer replenishment between the miniCQEs. Restore the check for the initial compressed CQE for SPRQ and check that the current CQE is not compressed before copying it as a possible title CQE. Signed-off-by: Alexander Kozyrev Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
[PATCH] doc: add tested platforms with NVIDIA NICs
Add tested platforms with NVIDIA NICs to the 24.07 release notes. Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_24_07.rst | 107 + 1 file changed, 107 insertions(+) diff --git a/doc/guides/rel_notes/release_24_07.rst b/doc/guides/rel_notes/release_24_07.rst index eb2ed1a55f..30b8f97a90 100644 --- a/doc/guides/rel_notes/release_24_07.rst +++ b/doc/guides/rel_notes/release_24_07.rst @@ -286,3 +286,110 @@ Tested Platforms This section is a comment. Do not overwrite or remove it. Also, make sure to start the actual text at the margin. === + +* Intel\ |reg| platforms with NVIDIA\ |reg| NICs combinations + + * CPU: + +* Intel\ |reg| Xeon\ |reg| Gold 6154 CPU @ 3.00GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2697A v4 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2697 v3 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2680 v2 @ 2.80GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2670 0 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 v4 @ 2.20GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 v3 @ 2.30GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2640 @ 2.50GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 0 @ 2.00GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2620 v4 @ 2.10GHz + + * OS: + +* Red Hat Enterprise Linux release 9.1 (Plow) +* Red Hat Enterprise Linux release 8.6 (Ootpa) +* Red Hat Enterprise Linux release 8.4 (Ootpa) +* Red Hat Enterprise Linux Server release 7.9 (Maipo) +* Red Hat Enterprise Linux Server release 7.6 (Maipo) +* Ubuntu 22.04 +* Ubuntu 20.04 +* SUSE Enterprise Linux 15 SP2 + + * OFED: + +* MLNX_OFED 24.04-0.6.6.0 and above + + * upstream kernel: + +* Linux 6.10.0 and above + + * rdma-core: + +* rdma-core-52.0 and above + + * NICs + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Dx EN 100G MCX623106AN-CDAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:101d + * Firmware version: 22.41.1000 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Lx EN 25G MCX631102AN-ADAT (2x25G) + + * Host interface: PCI Express 4.0 x8 + * Device ID: 15b3:101f + * Firmware version: 26.41.1000 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-7 200G CX713106AE-HEA_QP1_Ax (2x200G) + + * Host interface: PCI Express 5.0 x16 + * Device ID: 15b3:1021 + * Firmware version: 28.41.1000 and above + +* NVIDIA\ |reg| BlueField\ |reg| SmartNIC + + * NVIDIA\ |reg| BlueField\ |reg|-2 SmartNIC MT41686 - MBF2H332A-AEEOT_A1 (2x25G) + +* Host interface: PCI Express 3.0 x16 +* Device ID: 15b3:a2d6 +* Firmware version: 24.41.1000 and above + + * NVIDIA\ |reg| BlueField\ |reg|-3 P-Series DPU MT41692 - 900-9D3B6-00CV-AAB (2x200G) + +* Host interface: PCI Express 5.0 x16 +* Device ID: 15b3:a2dc +* Firmware version: 32.41.1000 and above + + * Embedded software: + +* Ubuntu 22.04 +* MLNX_OFED 24.04-0.6.6.0 and above +* bf-bundle-2.7.0-33_24.04_ubuntu-22.04 +* DPDK application running on ARM cores + +* IBM Power 9 platforms with NVIDIA\ |reg| NICs combinations + + * CPU: + +* POWER9 2.2 (pvr 004e 1202) + + * OS: + +* Ubuntu 20.04 + + * NICs: + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Dx 100G MCX623106AN-CDAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:101d + * Firmware version: 22.41.1000 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-7 200G CX713106AE-HEA_QP1_Ax (2x200G) + + * Host interface: PCI Express 5.0 x16 + * Device ID: 15b3:1021 + * Firmware version: 28.41.1000 and above + + * OFED: + +* MLNX_OFED 24.04-0.6.6.0 -- 2.39.3 (Apple Git-146)
[PATCH] doc: add tested platforms with NVIDIA NICs
Add tested platforms with NVIDIA NICs to the 24.07 release notes. Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_24_07.rst | 107 + 1 file changed, 107 insertions(+) diff --git a/doc/guides/rel_notes/release_24_07.rst b/doc/guides/rel_notes/release_24_07.rst index eb2ed1a55f..30b8f97a90 100644 --- a/doc/guides/rel_notes/release_24_07.rst +++ b/doc/guides/rel_notes/release_24_07.rst @@ -286,3 +286,110 @@ Tested Platforms This section is a comment. Do not overwrite or remove it. Also, make sure to start the actual text at the margin. === + +* Intel\ |reg| platforms with NVIDIA\ |reg| NICs combinations + + * CPU: + +* Intel\ |reg| Xeon\ |reg| Gold 6154 CPU @ 3.00GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2697A v4 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2697 v3 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2680 v2 @ 2.80GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2670 0 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 v4 @ 2.20GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 v3 @ 2.30GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2640 @ 2.50GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 0 @ 2.00GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2620 v4 @ 2.10GHz + + * OS: + +* Red Hat Enterprise Linux release 9.1 (Plow) +* Red Hat Enterprise Linux release 8.6 (Ootpa) +* Red Hat Enterprise Linux release 8.4 (Ootpa) +* Red Hat Enterprise Linux Server release 7.9 (Maipo) +* Red Hat Enterprise Linux Server release 7.6 (Maipo) +* Ubuntu 22.04 +* Ubuntu 20.04 +* SUSE Enterprise Linux 15 SP2 + + * OFED: + +* MLNX_OFED 24.04-0.6.6.0 and above + + * upstream kernel: + +* Linux 6.10.0 and above + + * rdma-core: + +* rdma-core-52.0 and above + + * NICs + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Dx EN 100G MCX623106AN-CDAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:101d + * Firmware version: 22.41.1000 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Lx EN 25G MCX631102AN-ADAT (2x25G) + + * Host interface: PCI Express 4.0 x8 + * Device ID: 15b3:101f + * Firmware version: 26.41.1000 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-7 200G CX713106AE-HEA_QP1_Ax (2x200G) + + * Host interface: PCI Express 5.0 x16 + * Device ID: 15b3:1021 + * Firmware version: 28.41.1000 and above + +* NVIDIA\ |reg| BlueField\ |reg| SmartNIC + + * NVIDIA\ |reg| BlueField\ |reg|-2 SmartNIC MT41686 - MBF2H332A-AEEOT_A1 (2x25G) + +* Host interface: PCI Express 3.0 x16 +* Device ID: 15b3:a2d6 +* Firmware version: 24.41.1000 and above + + * NVIDIA\ |reg| BlueField\ |reg|-3 P-Series DPU MT41692 - 900-9D3B6-00CV-AAB (2x200G) + +* Host interface: PCI Express 5.0 x16 +* Device ID: 15b3:a2dc +* Firmware version: 32.41.1000 and above + + * Embedded software: + +* Ubuntu 22.04 +* MLNX_OFED 24.04-0.6.6.0 and above +* bf-bundle-2.7.0-33_24.04_ubuntu-22.04 +* DPDK application running on ARM cores + +* IBM Power 9 platforms with NVIDIA\ |reg| NICs combinations + + * CPU: + +* POWER9 2.2 (pvr 004e 1202) + + * OS: + +* Ubuntu 20.04 + + * NICs: + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Dx 100G MCX623106AN-CDAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:101d + * Firmware version: 22.41.1000 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-7 200G CX713106AE-HEA_QP1_Ax (2x200G) + + * Host interface: PCI Express 5.0 x16 + * Device ID: 15b3:1021 + * Firmware version: 28.41.1000 and above + + * OFED: + +* MLNX_OFED 24.04-0.6.6.0 -- 2.39.3 (Apple Git-146)
Re: [PATCH v2] net/mlx5: add metadata split for compatibility API
hi, From: Bing Zhao Sent: Thursday, July 4, 2024 1:26 PM To: Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh Cc: Ori Kam; Dariusz Sosnowski; Suanming Mou; Matan Azrad Subject: [PATCH v2] net/mlx5: add metadata split for compatibility API The method will not create any new flow rule implicitly during split stage, but only generate needed items, actions and attributes based on the detection. All the rules will still be created in the flow_hw_list_create(). In the meanwhile, once the mark action is specified in the FDB rule, a new rule in the NIC Rx will be created to: 1. match the mark value on REG_C_x in FDB and set it into Rx flow tag field. 2. copy the metadata in REG_C_x' into the REG_B. If there is no mark, the default rule with only copying metadata will be hit if there is Queue or RSS action in the NIC Rx rule. Regarding the NIC Tx, only the metadata is relevant and it will be copied in NIC Tx from REG_A into some REG_C_x. The current HWS implementation already has already supported in the default copy rule or the default SQ miss rule in the NIC Tx root table. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh
