[PATCH v4] doc: add removal warning for power empty poll API

2022-11-02 Thread Reshma Pattan
Add removal warning for experimental empty poll API. CC: David Hunt Signed-off-by: Reshma Pattan Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide

[PATCH v5] doc: add removal warning for power empty poll API

2022-11-02 Thread Reshma Pattan
Add removal warning for experimental empty poll API. CC: David Hunt Signed-off-by: Reshma Pattan Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst

[dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check

2021-04-21 Thread Reshma Pattan
c: david.h...@intel.com Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan --- examples/vm_power_manager/channel_manager.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index 458e37167..fe9156785 10

[PATCH v5] examples/vm_power_manager: use safe version of list iterator

2022-10-04 Thread Reshma Pattan
iterate and delete VM info structures. Fixes: e8ae9b662506 ("examples/vm_power: channel manager and monitor in host") Cc: alan.ca...@intel.com Cc: sta...@dpdk.org Signed-off-by: Hamza Khan Signed-off-by: Reshma Pattan Acked-by: David Hunt --- examples/vm_power_manager/channel_mana

[PATCH v2] doc: add removal note for power empty poll API

2022-10-05 Thread Reshma Pattan
Add removal note for experimental empty poll API. CC: David Hunt Signed-off-by: Reshma Pattan Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst

[PATCH v3] doc: add removal note for power empty poll API

2022-10-07 Thread Reshma Pattan
Add removal note for experimental empty poll API. CC: David Hunt Signed-off-by: Reshma Pattan Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst

[PATCH] doc: add removal note for power empty poll API

2022-08-02 Thread Reshma Pattan
Add removal note for experimental empty poll API. CC: David Hunt Signed-off-by: Reshma Pattan --- doc/guides/prog_guide/power_man.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst index 98cfd3c1f3

[PATCH v4] examples/vm_power_manager: use safe version of list iterator

2022-08-22 Thread Reshma Pattan
by: Reshma Pattan Acked-by: Reshma Pattan Signed-off-by: Reshma Pattan --- v4: fix header file inclusion --- examples/vm_power_manager/channel_manager.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/channel_manager.c

[PATCH] app/pdump: check lcore is not the maximum core

2022-02-18 Thread Reshma Pattan
rg Signed-off-by: Reshma Pattan --- app/pdump/main.c | 8 1 file changed, 8 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 04a38e8911..686c27d965 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -931,11 +931,19 @@ dump_packets(void) }

[PATCH v2] app/pdump: check lcore is not the maximum core

2022-02-21 Thread Reshma Pattan
rg Signed-off-by: Reshma Pattan --- app/pdump/main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 04a38e8911..7677a5f8f5 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -930,12 +930,15 @@ dump_packets(void)

[PATCH v3] app/pdump: check lcore is not the maximum core

2022-02-22 Thread Reshma Pattan
rg Signed-off-by: Reshma Pattan --- v3: add new function to get next core id and validate it. --- app/pdump/main.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 04a38e8911..e4e62811c9 100644 --- a/app/pdump/main.c +++ b

[PATCH v4] app/pdump: check lcore is not the maximum core

2022-02-28 Thread Reshma Pattan
rg Signed-off-by: Reshma Pattan --- v4: Remove inline of new function Change lcore type as unsigned int return lcore from the function --- app/pdump/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index

[dpdk-dev] [PATCH v7] distributor_app: new sample app

2014-11-03 Thread Reshma Pattan
From: Reshma Pattan A new sample app that shows the usage of the distributor library. This app works as follows: * An RX thread runs which pulls packets from each ethernet port in turn and passes those packets to worker using a distributor component. * The workers take the packets in turn

[dpdk-dev] [PATCH] doc: typos corrected in distributor application

2014-12-05 Thread Reshma Pattan
corrected couple of typos in distributor application Signed-off-by: Reshma Pattan --- doc/guides/sample_app_ug/dist_app.rst |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/dist_app.rst b/doc/guides/sample_app_ug/dist_app.rst index 76e3924

[dpdk-dev] [PATCH] linux_gsg: quick_start.rst fixed as per setup.sh menu options *corrected as per latest setup.sh menu options

2014-12-16 Thread Reshma Pattan
Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/quick_start.rst | 64 ++--- 1 files changed, 35 insertions(+), 29 deletions(-) diff --git a/doc/guides/linux_gsg/quick_start.rst b/doc/guides/linux_gsg/quick_start.rst index 089dddb..a99b8fa 100644 --- a

[dpdk-dev] [PATCH v2] doc: fix setup menu options in linux gsg

2014-12-17 Thread Reshma Pattan
From: Reshma Pattan v2 changes: fixed setup menu options in linux gsg to keep in synch with setup.sh Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/quick_start.rst | 62 ++ 1 files changed, 33 insertions(+), 29 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH] doc: update note on packet capture framework initialization

2017-07-03 Thread Reshma Pattan
Updated note to make users aware that the packet capture framework is initialized by default only in testpmd. Other primary applications need to explicitly modify the code to do this initialization. Signed-off-by: Reshma Pattan --- doc/guides/tools/pdump.rst | 6 ++ 1 file changed, 6

[dpdk-dev] [PATCH] doc: add how to use packet capture framework

2017-07-12 Thread Reshma Pattan
Describes how to use pdump library and dpdk-pdump tool to capture traffic on dpdk ports. Signed-off-by: Reshma Pattan --- doc/guides/howto/img/packet_capture_framework.svg | 128 +++ doc/guides/howto/index.rst| 1 + doc/guides/howto

[dpdk-dev] [RFC] ethdev: add IF-MIB attributes implementation

2017-07-13 Thread Reshma Pattan
. Signed-off-by: Reshma Pattan --- lib/Makefile | 6 +- lib/librte_ether/rte_ethdev.c | 130 +- lib/librte_ether/rte_ethdev.h | 7 ++ lib/librte_ether/rte_ethdev_pci.h | 4 ++ mk/rte.app.mk | 2 +- 5 files

[dpdk-dev] [RFC v2] ethdev: add IF-MIB attributes implementation

2017-07-13 Thread Reshma Pattan
? Looking forward to hear opinions. Signed-off-by: Reshma Pattan --- v2: Corrected typos and description of the commit message. --- lib/Makefile | 6 +- lib/librte_ether/rte_ethdev.c | 130 +- lib/librte_ether/rte_ethdev.h | 7

[dpdk-dev] [RFC v3] ethdev: add IF-MIB attributes implementation

2017-07-18 Thread Reshma Pattan
Since DPDK doesn't know about the the Network Management Portion, I assume these 2 attributes should not be implemented in DPDK. Please clarify. Looking forward to hear opinions. Signed-off-by: Reshma Pattan --- v3: *Added new file rte_clock.h to provide wrapper for clock_gettime(CLOCK_MO

[dpdk-dev] [PATCH v2] doc: add how-to on packet capture framework

2017-08-03 Thread Reshma Pattan
Add How-To doc to describe the use of the pdump library and the dpdk-pdump tool to capture traffic on DPDK ports. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- V2: Fixed SVG image. doc/guides/howto/img/packet_capture_framework.svg | 471 ++ doc/guides/howto

[dpdk-dev] [PATCH] doc: add option to install PMD driver shared library

2017-03-27 Thread Reshma Pattan
Update the document with the available EAL command line option to install the pmd drivers that are built as shared libraries. Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/build_sample_apps.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides

[dpdk-dev] [RFC v3] latencystats: added new library for latency stats

2016-10-17 Thread Reshma Pattan
far. *Jitter calculation is done based on inter packet delay variation. *Measured stats can be retrieved via get API of the libray (or) by calling generic get API of the new stats library, in this case callback is provided to update the stats into new stats library. Signed-off-by: Reshma Pattan

[dpdk-dev] [PATCH] pdump: revert PCI device name conversion

2016-10-25 Thread Reshma Pattan
vice name using ethdev library calls. Now after ethdev and eal rework http://dpdk.org/dev/patchwork/patch/15855/, the device names are created in the format "domain:bus:device.func", so pdump library conversion is not needed any more, hence removed the corresponding code. Signed-off-

[dpdk-dev] [RFC] latencystats: added new library for latency stats

2016-09-26 Thread Reshma Pattan
stats library, in this case callback is provided to update the stats into new stats library. Signed-off-by: Reshma Pattan --- config/common_base | 5 + examples/skeleton/basicfwd.c | 33 - lib/Makefile | 1 + lib

[dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF management

2016-09-29 Thread Reshma Pattan
Hi, On 9/29/2016 3:16 PM, Bernard Iremonger wrote: > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile > index a6c71f3..7493b8d 100644 > --- a/drivers/net/ixgbe/Makefile > +++ b/drivers/net/ixgbe/Makefile > @@ -119,6 +119,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_bypass

[dpdk-dev] [PATCH] pdump: remove unnecessary header file

2017-06-12 Thread Reshma Pattan
Missed to remove unnecessary header file rte_pci.h. Removed it now. Fixes: bb900072("pdump: revert PCI device name conversion") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/li

[dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET

2015-12-23 Thread Reshma Pattan
Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET are blocking the secondary process from using the APIs. API access should be given to both secondary and primary. Fix minor checkpath issues in rte_ethdev.h Reported-by: Sean Harte Signed-off-by: Reshma Pattan --- lib/librte_ether

[dpdk-dev] [PATCH 3/3] librte_ether: fix rte_eth_dev_configure

2015-12-23 Thread Reshma Pattan
User should be able to configure ethdev with zero rx/tx queues, but both should not be zero. After above change, rte_eth_dev_tx_queue_config, rte_eth_dev_rx_queue_config should allocate memory for rx/tx queues only when number of rx/tx queues are nonzero. Signed-off-by: Reshma Pattan --- lib

[dpdk-dev] [PATCH 2/3] librte_cryptodev: remove RTE_PROC_PRIMARY_OR_RET

2015-12-23 Thread Reshma Pattan
Macro RTE_PROC_PRIMARY_OR_ERR_RET blocking the secondary process from API usage. API access should be given to both secondary and primary. Signed-off-by: Reshma Pattan --- lib/librte_cryptodev/rte_cryptodev.c | 42 1 file changed, 42 deletions(-) diff --git

[dpdk-dev] [PATCH v2 1/3] mbuf: implement generic format for sched field

2018-12-07 Thread Reshma Pattan
. doc: Release notes updated. Removed deprecation notice for mbuf::hash::sched and sched API. [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- doc

[dpdk-dev] [PATCH v2 3/3] doc: add deprecation notice to remove rte meter color

2018-12-07 Thread Reshma Pattan
Added deprecation notice to replace rte_meter_color with rte_color. Signed-off-by: Reshma Pattan --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 60e081a54

[dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-07 Thread Reshma Pattan
use new color definition. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- app/test-pmd/cmdline_mtr.c | 47 +++-- app/test-pmd/cmdline_tm.c | 23 +- drivers/net/softnic/rte_eth_softnic_flow.c | 10 +++-- drivers/net

[dpdk-dev] [PATCH] doc: add deprecation notice to remove rte meter color

2018-12-12 Thread Reshma Pattan
Added deprecation notice to replace rte_meter_color with rte_color. Signed-off-by: Reshma Pattan Acked-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes

[dpdk-dev] [PATCH v3 1/2] eal: add new rte color definition

2018-12-13 Thread Reshma Pattan
, rte_mtr_color and rte_meter_color will be deprecated in future. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- v2: Addressed review comments given in the below link http://patches.dpdk.org/patch/48588/ Added rte_color.h to meson build. --- --- lib/librte_eal/common/Makefile

[dpdk-dev] [PATCH v3 2/2] mbuf: implement generic format for sched field

2018-12-13 Thread Reshma Pattan
. doc: Release notes updated. Removed deprecation notice for mbuf::hash::sched and sched API. [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- v3

[dpdk-dev] [PATCH v4 2/2] mbuf: implement generic format for sched field

2018-12-18 Thread Reshma Pattan
: Release notes updated. Removed deprecation notice for mbuf::hash::sched and sched API. [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- v4

[dpdk-dev] [PATCH v4 1/2] meter: add new rte color definition

2018-12-18 Thread Reshma Pattan
rte_tm_color, rte_mtr_color and rte_meter_color will be deprecated in future. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- v4: Removed rte_meter, rte_mtr and rte_tm color definitions. Moved rte_color definition from eal to meter library. v3:Addressed review comments given in the below

[dpdk-dev] [PATCH v5 1/2] meter: add new rte color definition

2018-12-19 Thread Reshma Pattan
rte_tm_color, rte_mtr_color and rte_meter_color will be deprecated in future. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Acked-by: Cristian Dumitrescu --- v5: Removed meter library from librte_mbuf dependency list. v4: Removed rte_meter, rte_mtr and rte_tm color definitions. Moved

[dpdk-dev] [PATCH v5 2/2] mbuf: implement generic format for sched field

2018-12-19 Thread Reshma Pattan
: Release notes updated. Removed deprecation notice for mbuf::hash::sched and sched API. [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Acked-by

[dpdk-dev] [PATCH v6 1/2] meter: add new rte color definition

2018-12-19 Thread Reshma Pattan
rte_tm_color, rte_mtr_color and rte_meter_color will be deprecated in future. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Acked-by: Cristian Dumitrescu --- v5: Removed meter library from librte_mbuf dependency list. v4: Removed rte_meter, rte_mtr and rte_tm color definitions. Moved

[dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-19 Thread Reshma Pattan
: Release notes updated. Removed deprecation notice for mbuf::hash::sched and sched API. [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Acked-by

[dpdk-dev] [PATCH v7 1/2] meter: add new rte color definition

2018-12-20 Thread Reshma Pattan
rte_tm_color, rte_mtr_color and rte_meter_color will be deprecated in future. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Acked-by: Cristian Dumitrescu --- v5: Removed meter library from librte_mbuf dependency list. v4: Removed rte_meter, rte_mtr and rte_tm color definitions. Moved

[dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field

2018-12-20 Thread Reshma Pattan
e mbuf->hash.txadapter.txq. doc: Release notes updated. Removed deprecation notice for mbuf->hash.sched and sched API. [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Patt

[dpdk-dev] [PATCH] net/softnic: add flow flush API

2018-10-01 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- This patch depends on below patch sets so must be applied after below patches are applied. https://mails.dpdk.org/archives/dev/2018-September/111379.html https://mails.dpdk.org/archives/dev/2018

[dpdk-dev] [PATCH v2] net/softnic: add flow flush API

2018-10-02 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- v2: Use TAILQ_FOREACH_SAFE instead of TAILQ_FOREACH for safe removal using TAILQ_REMOVAL. Corrected indentation and other style related nits. --- drivers/net/softnic/rte_eth_softnic_flow.c | 46

[dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement

2018-10-04 Thread Reshma Pattan
Updated the doc on how packets are marked to identify their timestamp as valid and considered for latency measurement. Suggested-by: Bao-Long Tran Signed-off-by: Reshma Pattan --- This change is relevant to the below patch and must be applied after that. http://patches.dpdk.org/patch/45328

[dpdk-dev] [PATCH v3] net/softnic: add flow flush API

2018-10-08 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- v3: Some style related changes v2: Use TAILQ_FOREACH_SAFE instead of TAILQ_FOREACH for safe removal using TAILQ_REMOVAL. --- drivers/net/softnic/rte_eth_softnic_flow.c | 47 +- 1

[dpdk-dev] [PATCH v4] net/softnic: add flow flush API

2018-10-08 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- v4: Abort on rule deletion failures only at the end. v3: Some style related changes v2: Use TAILQ_FOREACH_SAFE instead of TAILQ_FOREACH for safe removal using TAILQ_REMOVAL. --- drivers/net/softnic

[dpdk-dev] [PATCH] net/softnic: add rte flow vxlan action support

2018-10-12 Thread Reshma Pattan
Added support to handle vxlan action of rte flow rule. Signed-off-by: Reshma Pattan Acked-by: Dumitrescu Cristian --- drivers/net/softnic/rte_eth_softnic_flow.c | 192 + 1 file changed, 192 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/drivers

[dpdk-dev] [PATCH v2] net/softnic: add support for flow API vxlan encap action

2018-10-15 Thread Reshma Pattan
Added support to handle vxlan encap action of rte flow rule. Signed-off-by: Reshma Pattan Acked-by: Dumitrescu Cristian --- drivers/net/softnic/rte_eth_softnic_flow.c | 192 + 1 file changed, 192 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b

[dpdk-dev] [PATCH v3] net/softnic: add support for flow API vxlan encap action

2018-10-16 Thread Reshma Pattan
Added support to handle vxlan encap action of rte flow rule. Signed-off-by: Reshma Pattan Acked-by: Dumitrescu Cristian --- v3: fixed vlan pcp, dei and vid parsing. fixed ipv6 flow_label and dscp parsing. --- drivers/net/softnic/rte_eth_softnic_flow.c | 192 + 1 file

[dpdk-dev] [PATCH] doc: update softnic doc for flow and qos API support

2018-10-18 Thread Reshma Pattan
Update document with flow and qos api support in softnic PMD. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- doc/guides/nics/softnic.rst | 119 1 file changed, 119 insertions(+) diff --git a/doc/guides/nics/softnic.rst b/doc/guides/nics

[dpdk-dev] [PATCH v2] doc: update softnic doc for flow and qos API support

2018-10-18 Thread Reshma Pattan
Update document with flow and qos api support in softnic PMD. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Reviewed-by: Marko Kovacevic --- v2: fixed the Note. reworded the sentence. --- doc/guides/nics/softnic.rst | 120 1 file changed, 120

[dpdk-dev] [PATCH v2] doc: update softnic doc for flow and qos API support

2018-10-18 Thread Reshma Pattan
Update document with flow and qos api support in softnic PMD. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan Reviewed-by: Marko Kovacevic --- v2: fixed the Note. reworded the sentence. --- doc/guides/nics/softnic.rst | 120 1 file changed, 120

[dpdk-dev] [PATCH 2/4] net/softnic: fix string copy

2018-10-30 Thread Reshma Pattan
From: Reshma Pattan Replace strcpy with strlcpy to avoid buffer overrun. Coverity issue: 323515 Fixes: b767f8efc8 ("net/softnic: replace pointers with arrays") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/n

[dpdk-dev] [PATCH 1/4] net/softnic: fix string copy

2018-10-30 Thread Reshma Pattan
From: Reshma Pattan Use strlcpy instead of strcpy to avoid buffer overrun. Coverity issue: 323514 Fixes: b767f8efc8 ("net/softnic: replace pointers with arrays") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/n

[dpdk-dev] [PATCH 4/4] net/softnic: fix string copy

2018-10-30 Thread Reshma Pattan
From: Reshma Pattan Use strlcpy instead of strcpy to avoid buffer overrun. Coverity issue: 323478 Fixes: b767f8efc8 ("net/softnic: replace pointers with arrays") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/n

[dpdk-dev] [PATCH 3/4] net/softnic: fix string copy

2018-10-30 Thread Reshma Pattan
From: Reshma Pattan Use strlcpy instead of strcpy to avoid buffer overrun. Coverity issue: 323475 Fixes: c169b6a588 ("net/softnic: map flow attribute to pipeline table") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/n

[dpdk-dev] [PATCH v2] net/softnic: fix string copy

2018-10-31 Thread Reshma Pattan
com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- v2: merge the below patches into single patch. http://patchwork.dpdk.org/patch/47570/ http://patchwork.dpdk.org/patch/47571/ http://patchwork.dpdk.org/patch/47572/ http://patchwork.dpdk.org/patch/47573/ --- drivers/net/softnic/rte_eth

[dpdk-dev] [PATCH v2 03/10] autotest: make autotest runner python 2/3 compliant

2018-07-13 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v2 00/10] Make unit tests great again

2018-07-13 Thread Reshma Pattan
targets for classified testcases Reshma Pattan (2): autotest: add new test cases to autotest autotest: update result for skipped test cases mk/rte.sdkroot.mk|4 +- mk/rte.sdktest.mk| 33 +- test/test/autotest.py| 13 +- test/test

[dpdk-dev] [PATCH v2 01/10] autotest: fix printing

2018-07-13 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v2 02/10] autotest: fix invalid code on reports

2018-07-13 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v2 07/10] autotest: properly parallelize unit tests

2018-07-13 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v2 04/10] autotest: visually separate different test categories

2018-07-13 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v2 06/10] autotest: remove autotest grouping

2018-07-13 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v2 05/10] autotest: improve filtering

2018-07-13 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v2 08/10] autotest: add new test cases to autotest

2018-07-13 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy --- test/test/autotest_data.py | 370 - 1 file changed, 362 insertions(+), 8

[dpdk-dev] [PATCH v2 10/10] mk: update make targets for classified testcases

2018-07-13 Thread Reshma Pattan
cases for different targets are listed accordingly. Cc: sta...@dpdk.org Signed-off-by: Jananee Parthasarathy Reviewed-by: Reshma Pattan --- mk/rte.sdkroot.mk | 4 ++-- mk/rte.sdktest.mk | 33 +++-- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/mk

[dpdk-dev] [PATCH v2 09/10] autotest: update result for skipped test cases

2018-07-13 Thread Reshma Pattan
Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in autotests execution. Cc: sta...@dpdk.org Signed-off-by: Jananee Parthasarathy Signed-off-by: Reshma Pattan ---

[dpdk-dev] [PATCH v3 1/9] autotest: fix printing

2018-07-16 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v3 0/9] Make unit tests great again

2018-07-16 Thread Reshma Pattan
://patches.dpdk.org/patch/40371/ Reshma Pattan (9): autotest: fix printing autotest: fix invalid code on reports autotest: make autotest runner python 2/3 compliant autotest: visually separate different test categories autotest: improve filtering autotest: remove autotest grouping autotest: properly

[dpdk-dev] [PATCH v3 4/9] autotest: visually separate different test categories

2018-07-16 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v3 5/9] autotest: improve filtering

2018-07-16 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v3 3/9] autotest: make autotest runner python 2/3 compliant

2018-07-16 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v3 2/9] autotest: fix invalid code on reports

2018-07-16 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v3 6/9] autotest: remove autotest grouping

2018-07-16 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v3 7/9] autotest: properly parallelize unit tests

2018-07-16 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-16 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy --- test/test/autotest_data.py | 368 - 1 file

[dpdk-dev] [PATCH v3 9/9] mk: update make targets for classified testcases

2018-07-16 Thread Reshma Pattan
cases for different targets are listed accordingly. Cc: sta...@dpdk.org Signed-off-by: Jananee Parthasarathy Reviewed-by: Reshma Pattan --- mk/rte.sdkroot.mk | 4 ++-- mk/rte.sdktest.mk | 33 +++-- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/mk

[dpdk-dev] [PATCH] test: fix incorrect return types

2018-07-16 Thread Reshma Pattan
UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Fixes: 9c9befea4f ("test: add flow classify unit tests") CC: jasvinder.si...@intel.com CC: bernard.iremon...@intel.com CC: sta...@dpdk.org Signed-off-by: Reshma Pattan ---

[dpdk-dev] [PATCH v4 0/9] Make unit tests great again

2018-07-17 Thread Reshma Pattan
[1], [2] [1] http://dpdk.org/dev/patchwork/patch/40370/ [2] http://patches.dpdk.org/patch/40373/ v4: Removed non auto tests set_rxtx_mode, set_rxtx_anchor and set_rxtx_sc from autotest_data.py Reshma Pattan (9): autotest: fix printing autotest: fix invalid code on reports autotest: make

[dpdk-dev] [PATCH v4 1/9] autotest: fix printing

2018-07-17 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v4 2/9] autotest: fix invalid code on reports

2018-07-17 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant

2018-07-17 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v4 4/9] autotest: visually separate different test categories

2018-07-17 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v4 5/9] autotest: improve filtering

2018-07-17 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Reshma Pattan
cases for different targets are listed accordingly. Cc: sta...@dpdk.org Signed-off-by: Jananee Parthasarathy Reviewed-by: Reshma Pattan --- mk/rte.sdkroot.mk | 4 ++-- mk/rte.sdktest.mk | 33 +++-- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/mk

[dpdk-dev] [PATCH v4 8/9] autotest: update autotest test case list

2018-07-17 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy Reviewed-by: Anatoly Burakov --- test/test/autotest_data.py | 350

[dpdk-dev] [PATCH v4 7/9] autotest: properly parallelize unit tests

2018-07-17 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v4 6/9] autotest: remove autotest grouping

2018-07-17 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v2] test: fix incorrect return types

2018-07-17 Thread Reshma Pattan
") CC: jasvinder.si...@intel.com CC: bernard.iremon...@intel.com CC: sta...@dpdk.org Signed-off-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- v2: update commit message --- test/test/test_flow_classify.c | 110 - 1 file changed, 55 insertions(+), 55

[dpdk-dev] [PATCH v4 0/9] Make unit tests great again

2018-07-17 Thread Reshma Pattan
[1], [2] [1] http://dpdk.org/dev/patchwork/patch/40370/ [2] http://patches.dpdk.org/patch/40373/ v4: Removed non auto tests set_rxtx_mode, set_rxtx_anchor and set_rxtx_sc from autotest_data.py Reshma Pattan (9): autotest: fix printing autotest: fix invalid code on reports autotest: make

[dpdk-dev] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant

2018-07-17 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v4 4/9] autotest: visually separate different test categories

2018-07-17 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v4 2/9] autotest: fix invalid code on reports

2018-07-17 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v4 1/9] autotest: fix printing

2018-07-17 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v4 5/9] autotest: improve filtering

2018-07-17 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

  1   2   3   4   5   >