Re: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5

2021-09-03 Thread Shahaf Shuler
Monday, August 23, 2021 5:51 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5 > > For net/mlx4: > - removing Shahaf Shuler > - adding Viacheslav Ovsiienko > > For net/mlx5: > - removing Shahaf Shuler >

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-09 Thread Shahaf Shuler
Hi Georgios, It is not support on Mellanox PMD to read the primary process counters from a secondary process. --Shahaf -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of george@gmail.com Sent: Sunday, January 8, 2017 3:38 PM To: dev@dpdk.org Subject: [dpdk-dev

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-10 Thread Shahaf Shuler
equal to the number of packet/bytes which were send/received on the PMD. --Shahaf From: george@gmail.com [mailto:george@gmail.com] Sent: Monday, January 9, 2017 4:45 PM To: Shahaf Shuler Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver Hi Shahaf

[dpdk-dev] [PATCH] net/mlx5: support extended statistics

2017-01-11 Thread Shahaf Shuler
Implement xstats_*() DPDK callbacks Signed-off-by: Shahaf Shuler Signed-off-by: Elad Persiko Signed-off-by: Hanoch Haim --- drivers/net/mlx5/mlx5.c | 3 + drivers/net/mlx5/mlx5.h | 12 ++ drivers/net/mlx5/mlx5_defs.h| 3 + drivers/net/mlx5/mlx5_stats.c | 342

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-11 Thread Shahaf Shuler
--Shahaf -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Wednesday, January 11, 2017 3:47 PM To: Shahaf Shuler Cc: dev@dpdk.org; george@gmail.com Subject: Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver > > On Mon, Jan 9, 2017 a

[dpdk-dev] [PATCH v2] net/mlx5: support extended statistics

2017-01-12 Thread Shahaf Shuler
Implement xstats_*() DPDK callbacks Signed-off-by: Shahaf Shuler Signed-off-by: Elad Persiko Signed-off-by: Hanoch Haim --- drivers/net/mlx5/mlx5.c | 3 + drivers/net/mlx5/mlx5.h | 15 ++ drivers/net/mlx5/mlx5_defs.h| 3 + drivers/net/mlx5/mlx5_stats.c | 324

[dpdk-dev] [PATCH v3] net/mlx5: support extended statistics

2017-01-16 Thread Shahaf Shuler
Implement extended statistics callbacks. Suggested-by: Hanoch Haim Signed-off-by: Shahaf Shuler Signed-off-by: Elad Persiko --- changes on v3: * change commit log * add const to mlx5_counters_init * change warning message for unrecognized counter --- drivers/net/mlx5/mlx5.c | 3

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

2017-01-16 Thread Shahaf Shuler
--Shahaf -Original Message- From: Hanoch Haim (hhaim) [mailto:hh...@cisco.com] Sent: Thursday, January 12, 2017 11:57 AM To: Adrien Mazarguil ; Shahaf Shuler Cc: dev@dpdk.org; Elad Persiko Subject: RE: [PATCH] net/mlx5: support extended statistics Hi Shahaf, 1) I would add *all

[dpdk-dev] [PATCH] net/mlx5: support extended statistics

2017-01-17 Thread Shahaf Shuler
Implement extended statistics callbacks. Suggested-by: Hanoch Haim Signed-off-by: Shahaf Shuler Signed-off-by: Elad Persiko Acked-by: Adrien Mazarguil --- on v4: * fix compilation issue with clang * coding style adjustments * replace strcpy with strncpy on v3: * change commit log * add

[dpdk-dev] [PATCH v4] net/mlx5: support extended statistics

2017-01-17 Thread Shahaf Shuler
Implement extended statistics callbacks. Suggested-by: Hanoch Haim Signed-off-by: Shahaf Shuler Signed-off-by: Elad Persiko Acked-by: Adrien Mazarguil --- on v4: * fix compilation issue with clang * coding style adjustments * replace strcpy with strncpy on v3: * change commit log * add

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

2017-01-17 Thread Shahaf Shuler
Please ignore, forgot to add v4 to subject. Tuesday, January 17, 2017 4:29 PM, Shahaf Shuler: > > Implement extended statistics callbacks. > > Suggested-by: Hanoch Haim > Signed-off-by: Shahaf Shuler > Signed-off-by: Elad Persiko > Acked-by: Adrien Mazarguil &g

[dpdk-dev] [PATCH] net/mlx5: fix memory leak when parsing device params

2017-01-22 Thread Shahaf Shuler
in case of an error argument list is not freed. Fixes: e72dd09b614e ("net/mlx5: add support for configuration through kvargs") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driver

[dpdk-dev] [PATCH 1/2] net/mlx5: fix link status query

2017-01-25 Thread Shahaf Shuler
.@dpdk.org Signed-off-by: Shahaf Shuler --- while the ETHTOOL_GLINKSETTINGS API was introduced on kernel v4.6 [1] the bug was fixed only on kern

[dpdk-dev] [PATCH] net/mlx5: fix link status is always inconsist

2017-01-25 Thread Shahaf Shuler
the link to always stay on an inconsist state. This patch addresses the race condition. Once delayed query is scheduled no other agents beside it can query the link status. Fixes: 198a3c339a8f ("mlx5: handle link status interrupts") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler --

[dpdk-dev] [PATCH v2] net/mlx5: fix link status query

2017-01-31 Thread Shahaf Shuler
.@dpdk.org Signed-off-by: Shahaf Shuler --- on v2: * remove HAVE_ETHTOOL_LINK_MODE_* --- drivers/net/mlx5/Makefile | 15 --- drivers/net/mlx5/mlx5_ethdev.c | 12 +++- 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/drivers/net/mlx5/Makefile b/driver

[dpdk-dev] [PATCH v3] net/mlx5: fix link status is always inconsist

2017-01-31 Thread Shahaf Shuler
handlers, the link status will be stuck in an in-consist state. This patch addresses the race condition by not blocking link status queries in case delayed query is on the flight. Fixes: 198a3c339a8f ("mlx5: handle link status interrupts") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix link status query

2017-01-31 Thread Shahaf Shuler
: Tuesday, January 31, 2017 6:17 PM, Ferruh Yigit: > On 1/31/2017 11:45 AM, Shahaf Shuler wrote: > > Trying to query the link status through new kernel ioctl API > > ETHTOOL_GLINKSETTINGS was always failing due to kernel bug. > > The bug was fixed on version 4.9 > >

[dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support

2017-02-08 Thread Shahaf Shuler
This patchset adds support for rxq interrupts on MLX5 PMD. The first patch introduces changes on eal_interrupt to support external interrupt handlers. The second patch implements the support on mlx5 PMD and demonstrate the use of the changes made in the first patch [PATCH 1/2] eal_interrupts: su

[dpdk-dev] [PATCH 2/2] net/mlx5: support user space rxq interrupt event

2017-02-08 Thread Shahaf Shuler
Implement rxq interrupt callbacks Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.c | 2 + drivers/net/mlx5/mlx5_rxq.c | 126 +++- drivers/net/mlx5/mlx5_rxtx.c| 73

[dpdk-dev] [PATCH 1/2] eal_interrupts: support external rxq interrupt handlers

2017-02-08 Thread Shahaf Shuler
Prior to this patch only UIO/VFIO interrupt handlers types were supported. This patch adds support for the external interrupt handler type, allowing external drivers to set their own fds with specific interrupt handlers. Signed-off-by: Shahaf Shuler --- lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v3] net/mlx5: fix link status query

2017-02-09 Thread Shahaf Shuler
target system, by always defining missing symbols and moving the kernel version check at run time. Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Adrien Mazarguil --- on v3: * Dynamic decision on the l

[dpdk-dev] [PATCH] net/mlx5: fix multi segment packet send

2016-12-26 Thread Shahaf Shuler
Dseg pointer is not initialised when the first segment is inlined causing a segmentation fault in such situation. Fixes: 2a66cf378954 ("net/mlx5: support inline send") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 6 +- 1 file changed, 5

Re: [dpdk-dev] Question on mlx5 PMD txq memory registration

2017-07-20 Thread Shahaf Shuler
Hi Sagi, Thursday, July 20, 2017 5:06 PM, Sagi Grimberg: > >> Its worse than just a drop, without debug enabled the error > >> completion is ignored, and the wqe_pi is taken from an invalid field, > >> which leads to bogus mbufs free (elts_tail is not valid). > > > > Right > > A simple work-arou

Re: [dpdk-dev] Question on mlx5 PMD txq memory registration

2017-07-23 Thread Shahaf Shuler
Thursday, July 20, 2017 7:22 PM, Sagi Grimberg: > >> As I said, there are primitives which are designed to handle frequent > >> reads and rare mutations. > > > > Even with such primitives, rarely lock is more than never lock. > > You do realize that the cache mutation involves ibv_dereg_mr() right

[dpdk-dev] [PATCH] doc: postpone unaccomplished deprecation notice

2017-07-23 Thread Shahaf Shuler
The work on ethdev Rx and Tx offloads has not been completed for 17.08. It will be completed on 17.11 The notice is kept and postponed until the end of this work. Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/deprecation.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 3/3] doc: update mlx guides

2017-07-24 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/nics/mlx4.rst | 161 +++--- doc/guides/nics/mlx5

[dpdk-dev] [PATCH 1/3] doc: update mlx5 supported features

2017-07-24 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini | 4 ++-- 1 file changed, 2

[dpdk-dev] [PATCH 2/3] doc: update release notes for mlx driver

2017-07-24 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index ef51ebbe8..cdb156962

Re: [dpdk-dev] [PATCH 3/3] doc: update mlx guides

2017-07-25 Thread Shahaf Shuler
Adrien, Thanks for the review. sorry for the caps. One issue I not agree with below Tuesday, July 25, 2017 10:17 AM, Adrien Mazarguil: > Hi Shahaf, > [...] > > Currently supported by DPDK: > > > > -- Mellanox OFED **4.0-2.0.0.0**. > > -- Firmware version **2.40.7000**. > > +- Mellanox OFED **4.1

[dpdk-dev] [PATCH v2 1/3] doc: update mlx5 supported features

2017-07-25 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini | 4 ++-- 1 file changed, 2

[dpdk-dev] [PATCH v2 2/3] doc: update release notes for mlx driver

2017-07-25 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index ef51ebbe8..cdb156962

[dpdk-dev] [PATCH v2 3/3] doc: update mlx guides

2017-07-25 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- On v2: - Fixed grammer and spelling. - Changed limitations and Known issues location

[dpdk-dev] [PATCH v3 1/3] doc: update mlx5 supported features

2017-07-25 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/nics/features/mlx5.ini

[dpdk-dev] [PATCH v3 3/3] doc: update mlx guides

2017-07-25 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- On v3: - Changed Limitiation and Known issues to Limitation

[dpdk-dev] [PATCH v3 2/3] doc: update release notes for mlx driver

2017-07-25 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08

[dpdk-dev] [PATCH v4 1/3] doc: update mlx5 supported features

2017-07-26 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/nics/features/mlx5.ini

[dpdk-dev] [PATCH v4 2/3] doc: update release notes for mlx driver

2017-07-26 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08

[dpdk-dev] [PATCH v4 3/3] doc: update mlx guides

2017-07-26 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- On v4: - Fixed missing "." and ":&qu

[dpdk-dev] [PATCH 2/3] doc: cleanup UIO hard requirement

2017-07-26 Thread Shahaf Shuler
UIO is not a must for all PMDs. Cleaning up the Linux Getting Started Guide from this hard requirement. Signed-off-by: Shahaf Shuler --- doc/guides/linux_gsg/build_sample_apps.rst | 10 ++ doc/guides/linux_gsg/sys_reqs.rst | 2 -- 2 files changed, 6 insertions(+), 6 deletions

[dpdk-dev] [PATCH 1/3] doc: move kernel drivers to a new chapter

2017-07-26 Thread Shahaf Shuler
The UIO and VFIO sections should not be part of the "Compiling the DPDK Target from Source" chapter, as it is PMD specific and not true for all PMDs. Instead, moving those sections to a new chapter which include all kernel drivers being used along with the different PMDs. Signed-off-

[dpdk-dev] [PATCH 3/3] doc: move i40e specific to i40e guide

2017-07-26 Thread Shahaf Shuler
The Linux Getting Started Guide contains parts which are specific for i40e PMD. This results in confusion for users which read the guide at their first try with DPDK. Moving those parts to the i40e NIC manual. Signed-off-by: Shahaf Shuler --- doc/guides/linux_gsg/enable_func.rst

[dpdk-dev] [PATCH v5 1/3] doc: update mlx5 supported features

2017-07-28 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: John McNamara --- doc/guides

[dpdk-dev] [PATCH v5 2/3] doc: update release notes for mlx driver

2017-07-28 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: John McNamara --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides

[dpdk-dev] [PATCH v5 3/3] doc: update mlx guides

2017-07-28 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- On v5: - Fix doc compliation error. - replace hint with

[dpdk-dev] [PATCH v2 1/3] doc: move kernel drivers to a new chapter

2017-07-29 Thread Shahaf Shuler
The UIO and VFIO sections should not be part of the "Compiling the DPDK Target from Source" chapter, as it is PMD specific and not true for all PMDs. Instead, moving those sections to a new chapter which include all kernel drivers being used along with the different PMDs. Signed-off-

[dpdk-dev] [PATCH v2 2/3] doc: cleanup UIO hard requirement

2017-07-29 Thread Shahaf Shuler
UIO is not a must for all PMDs. Cleaning up the Linux Getting Started Guide from this hard requirement. Signed-off-by: Shahaf Shuler Acked-by: John McNamara --- doc/guides/linux_gsg/build_sample_apps.rst | 10 ++ doc/guides/linux_gsg/sys_reqs.rst | 2 -- 2 files changed, 6

[dpdk-dev] [PATCH v2 3/3] doc: move i40e specific to i40e guide

2017-07-29 Thread Shahaf Shuler
The Linux Getting Started Guide contains parts which are specific for i40e PMD. This results in confusion for users which read the guide at their first try with DPDK. Moving those parts to the i40e NIC manual. Signed-off-by: Shahaf Shuler Acked-by: John McNamara --- on v2: - Moved

[dpdk-dev] [RFC PATCH 1/4] ethdev: rename Rx and Tx configuration structs

2017-08-07 Thread Shahaf Shuler
Rename the structs rte_eth_txconf and rte_eth_rxconf to rte_eth_txq_conf and rte_eth_rxq_conf respectively as those structs represent per queue configuration. Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 24 +--- 2

[dpdk-dev] [RFC PATCH 0/4] ethdev new offloads API

2017-08-07 Thread Shahaf Shuler
. Shahaf Shuler (4): ethdev: rename Rx and Tx configuration structs ethdev: introduce Rx queue offloads API ethdev: introduce Tx queue offloads API ethdev: add helpers to move to the new offloads API lib/librte_ether/rte_ethdev.c | 144 - lib/librte_ether

[dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-07 Thread Shahaf Shuler
per port. The Rx queue offload API can be used only with devices which advertize the RTE_ETH_DEV_RXQ_OFFLOAD capability. The old Rx offloads API is kept for the meanwhile, in order to enable a smooth transition for PMDs and application to the new API. Signed-off-by: Shahaf Shuler --- lib

[dpdk-dev] [RFC PATCH 3/4] ethdev: introduce Tx queue offloads API

2017-08-07 Thread Shahaf Shuler
RTE_ETH_DEV_TXQ_OFFLOAD capability. The old Tx offloads API is kept for the meanwhile, in order to enable a smooth transition for PMDs and application to the new API. Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_ethdev.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

[dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-07 Thread Shahaf Shuler
ng to the underlying device a copy functions to/from the old/new APIs were added. Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_ethdev.c | 140 + 1 file changed, 140 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethd

Re: [dpdk-dev] [PATCH v2] doc: deprecate Xen support

2017-08-07 Thread Shahaf Shuler
4d9ba6a4d149256f461b%7C0%7C0%7C636374510531999709&sdata=7c31%2Ft > Cfn6cF > > uBJsLyoIBwiWznmr3rMkzUdN5d87UhI%3D&reserved=0 > > > > Signed-off-by: Thomas Monjalon > > Signed-off-by: Jianfeng Tan > > Acked-by: John McNamara > Acked-by: Shahaf Shuler

Re: [dpdk-dev] [PATCH v2] doc: announce API and ABI change for ethdev

2017-08-07 Thread Shahaf Shuler
redefinition of port_id to extend it from 1 bytes to 2 > bytes. All ethdev APIs and usages related to port_id will be changed at the > same time. > > > doc/guides/rel_notes/deprecation.rst | 6 ++ > > 1 file changed, 6 insertions(+) > > Acked-by: Remy Horton Acked-by: Shahaf Shuler

Re: [dpdk-dev] [PATCH] ethdev: add notice for planned name size change

2017-08-07 Thread Shahaf Shuler
l increase RTE_ETH_NAME_MAX_LEN > from > > + 32 to > > + 64 characters to allow using a globally unique identifier (GUID) in this > field. > > Except for the small comment above, > Acked-by: Yongseok Koh Acked-by: Shahaf Shuler > > Thanks, > Yongseok

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev and ethdev

2017-08-07 Thread Shahaf Shuler
NXP? > > It seems there is not yet a consensus on how to manage IPsec offloading. > > I heard there were some phone calls about these stuff but nothing > > clear appears publicly on the mailing list. > > Looks to be a community failure. > > We agreed to go ahead with this approach on one such phone call. I hope we > could use the dpdk github for development. > > Acked-by: Boris Pismenny Acked-by: Shahaf Shuler

[dpdk-dev] [PATCH] net/mlx5: fix TSO header size in case of VLAN insertion

2017-03-23 Thread Shahaf Shuler
When VLAN insertion is requested the vlan size must be added to the calculation of the TSO header size, as it is not embedded within the mbuf l2 length. Fixes: 98083fd482a2 ("net/mlx5: add hardware TSO support") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/m

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO header size in case of VLAN insertion

2017-03-28 Thread Shahaf Shuler
Tuesday, March 28, 2017 7:03 PM, Ferruh Yigit: > On 3/24/2017 8:25 AM, Nélio Laranjeiro wrote: > > On Thu, Mar 23, 2017 at 02:42:11PM +0200, Shahaf Shuler wrote: > >> When VLAN insertion is requested the vlan size must be added to the > >> calculation of the TSO header

[dpdk-dev] [PATCH] net/mlx5: remove not needed query if and rd from create qp

2017-03-30 Thread Shahaf Shuler
Since mlx5 PMD data path is on top of PRM, such verbs calls are no longer needed. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 79 +--- drivers/net/mlx5/mlx5_rxtx.h | 6 --- drivers/net/mlx5/mlx5_txq.c | 87

[dpdk-dev] [PATCH v2] net/mlx5: remove unnecessary Verbs library calls

2017-04-02 Thread Shahaf Shuler
Remove unnecessary interface queries and the Resource Domain when creating the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such Verbs library calls are no longer needed. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- on v2: * clarify

Re: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle

2017-04-04 Thread Shahaf Shuler
Wednesday, April 5, 2017 12:21 AM, Qi Zhang: > The patch change the prototype of callback function > (rte_intr_callback_fn) by removing the unnecessary parameter. > > Signed-off-by: Qi Zhang > --- > > v4: > > - Update mlx5 driver which is missed in v1, v2, v3. Thanks for the update of mlx5. Th

Re: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support

2017-02-11 Thread Shahaf Shuler
Thursday, February 9, 2017 4:48 PM, Ferruh Yigit: > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, February 9, 2017 4:48 PM > To: Shahaf Shuler ; david.march...@6wind.com; > Adrien Mazarguil ; Nélio Laranjeiro > > Cc: dev@dpdk.org > Subject: Re: [dpdk

[dpdk-dev] [PATCH] net/mlx5: add out of buffer counter to extended statistic

2017-02-14 Thread Shahaf Shuler
This commit adds RX out of buffer counter to xstats report. The counter counts the number of dropped occurred due to lack of buffers on device RX queues. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h| 2 ++ drivers/net/mlx5/mlx5_ethdev.c | 54

[dpdk-dev] [PATCH] net/mlx5: fix VLAN stripping indication

2017-02-20 Thread Shahaf Shuler
The indication on vlan stripping was taken from the wrong location in the completion entry. Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support

2017-02-21 Thread Shahaf Shuler
Wednesday, February 8, 2017 3:58 PM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support > > This patchset adds support for rxq interrupts on MLX5 PMD. > The first patch introduces changes on eal_interrupt to support external > interrupt handler

[dpdk-dev] [PATCH 1/2] net/mlx5: remove unused interface name query

2017-02-21 Thread Shahaf Shuler
Interface name is queried, however never used. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_stats.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c index 20c957e..0c80e4f 100644 --- a

[dpdk-dev] [PATCH 2/2] net/mlx5: fix extended statistics wrong number

2017-02-21 Thread Shahaf Shuler
commit address this issue, and query the number of statistics before every call to ETHTOOL. Fixes: a4193ae3bc4f ("net/mlx5: support extended statistics") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_st

[dpdk-dev] [PATCH 1/4] ethdev: add Tx offload limitations

2017-02-22 Thread Shahaf Shuler
Many Tx offloads are performed by hardware. As such, each offload has its own limitations. This commit adds the option to query Tx offload limitations in order to use them properly and avoid bugs. The limitations should be filled by the PMD upon query device info. Signed-off-by: Shahaf Shuler

[dpdk-dev] [PATCH 3/4] app/testpmd: add TSO disable to test options

2017-02-22 Thread Shahaf Shuler
Add the option to globaly disable hardware TSO offload from the command line. Signed-off-by: Shahaf Shuler --- app/test-pmd/parameters.c | 9 - doc/guides/testpmd_app_ug/run_app.rst | 4 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/app/test-pmd

[dpdk-dev] [PATCH 4/4] net/mlx5: add hardware TSO support

2017-02-22 Thread Shahaf Shuler
Implement support for hardware TSO. Signed-off-by: Shahaf Shuler --- Performance impact on tx function due to tso logic insertion is estimated ~4 clocks. --- doc/guides/nics/features/mlx5.ini | 1 + drivers/net/mlx5/mlx5.c | 8 +++ drivers/net/mlx5/mlx5.h | 2

[dpdk-dev] [PATCH 0/4] net/mlx5 add TSO support

2017-02-22 Thread Shahaf Shuler
This patchset adds support for hardware TSO on mlx5 PMD. * Patches 1/4 and 2/4 adds TSO flags and capabilities to ethdev layer. * Patch 3/4 adds support for the flag introduced in patch 2/4. This patch also simplifies the testing of patch 4/4. * Patch 4/4 implement support for hardware TSO and

[dpdk-dev] [PATCH 2/4] ethdev: add TSO disable flag

2017-02-22 Thread Shahaf Shuler
This commit adds the option to disable TSO offload on a specific txq. Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 3ab8568..b93be09 100644 --- a/lib

Re: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support

2017-02-27 Thread Shahaf Shuler
Tuesday, February 21, 2017 1:40 PM, Shahaf Shuler: > Wednesday, February 8, 2017 3:58 PM, Shahaf Shuler: > > Subject: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support > > > > This patchset adds support for rxq interrupts on MLX5 PMD. > > The first

[dpdk-dev] [PATCH 2/2] net/mlx5: add hardware TSO support for VXLAN and GRE

2017-02-28 Thread Shahaf Shuler
This commit adds support for hardware TSO for tunneled packets. Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_ethdev.c | 4 +++- drivers/net/mlx5/mlx5_rxtx.c | 9 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net

[dpdk-dev] [PATCH 1/2] net/mlx5: add hardware checksum offload for tunnel packets

2017-02-28 Thread Shahaf Shuler
Prior to this commit Tx checksum offload was supported only for the inner headers. This commit adds support for the hardware to compute the checksum for the outer headers as well. The support is for tunneling protocols GRE and VXLAN. Signed-off-by: Shahaf Shuler --- doc/guides/nics/features

[dpdk-dev] [PATCH 0/2] net/mlx5: add Tx offloads for tunneled packets

2017-02-28 Thread Shahaf Shuler
This patchset adds support for hardware TX offloads for tunneled packets. [PATCH 1/2] net/mlx5: add hardware checksum offload for tunnel [PATCH 2/2] net/mlx5: add hardware TSO support for VXLAN and GRE

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: add Tx offloads for tunneled packets

2017-03-01 Thread Shahaf Shuler
Tuesday, February 28, 2017 5:54 PM, Shahaf Shuler: > > This patchset adds support for hardware TX offloads for tunneled packets. > > [PATCH 1/2] net/mlx5: add hardware checksum offload for tunnel [PATCH > 2/2] net/mlx5: add hardware TSO support for VXLAN and GRE Forgot to me

[dpdk-dev] [PATCH v2 0/1] net/mlx5: add TSO support

2017-03-01 Thread Shahaf Shuler
on v2: * Suppressed patches: [PATCH 1/4] ethdev: add Tx offload limitations. [PATCH 2/4] ethdev: add TSO disable flag. [PATCH 3/4] app/testpmd: add TSO disable to test options. * The changes introduced on the above conflict with tx_prepare API and break ABI. A proposal to disable by defaul

[dpdk-dev] [PATCH v2 1/1] net/mlx5: add hardware TSO support

2017-03-01 Thread Shahaf Shuler
Implement support for hardware TSO. Signed-off-by: Shahaf Shuler --- on v2: * Instead of exposing capability, TSO checks on data path. * PMD specific parameter to enable TSO. * different implementaion for the data path. Performance impact ~0.1-0.2Mpps --- doc/guides/nics/features/mlx5.ini

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: add Tx offloads for tunneled packets

2017-03-01 Thread Shahaf Shuler
Wednesday, March 1, 2017 11:24 AM, Shahaf Shuler: February 28, 2017 5:54 PM, Shahaf Shuler: > > > > This patchset adds support for hardware TX offloads for tunneled packets. > > > > [PATCH 1/2] net/mlx5: add hardware checksum offload for tunnel [PATCH > > 2/2] net/

[dpdk-dev] [PATCH v3 1/1] net/mlx5: add hardware TSO support

2017-03-02 Thread Shahaf Shuler
Implement support for hardware TSO. Signed-off-by: Shahaf Shuler --- on v3: * fix alignment issues * for warn log on v2: * Instead of exposing capability, TSO checks on data path. * PMD specific parameter to enable TSO. * different implementaion for the data path. Performance impact ~0.1

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add hardware checksum offload for tunnel packets

2017-03-02 Thread Shahaf Shuler
Prior to this commit Tx checksum offload was supported only for the inner headers. This commit adds support for the hardware to compute the checksum for the outer headers as well. The support is for tunneling protocols GRE and VXLAN. Signed-off-by: Shahaf Shuler --- on v2: * fix outer l3

[dpdk-dev] [PATCH v2 2/2] net/mlx5: add hardware TSO support for VXLAN and GRE

2017-03-02 Thread Shahaf Shuler
This commit adds support for hardware TSO for tunneled packets. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 +++- drivers/net/mlx5/mlx5_rxtx.c | 9 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix extended statistics counters identification

2017-03-05 Thread Shahaf Shuler
Checking whether the counter is IB counter was performed with the wrong index. Fixes: a4e3056b7018 ("net/mlx5: add out of buffer counter to extended statistic") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_stats.c | 2 +- 1 file changed, 1 inser

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: add hardware TSO support

2017-03-06 Thread Shahaf Shuler
Monday, March 6, 2017 11:31 AM, Ferruh Yigit: > On 3/6/2017 8:50 AM, Ferruh Yigit wrote: > > On 3/2/2017 9:01 AM, Shahaf Shuler wrote: > >> Implement support for hardware TSO. > >> > >> Signed-off-by: Shahaf Shuler > >> --- > >> on v3: > &

[dpdk-dev] [PATCH] doc: announce TSO support on mlx5 driver

2017-03-06 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/release_17_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index 05fe784..8c381a8 100644 --- a/doc/guides/rel_notes/release_17_05.rst +++ b/doc

[dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag

2017-03-07 Thread Shahaf Shuler
Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 405836c..2d33f2d 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxt

Re: [dpdk-dev] [PATCH 1/2] eal_interrupts: support external rxq interrupt handlers

2017-03-12 Thread Shahaf Shuler
Thursday, March 9, 2017 8:10 PM, Thomas Monjalon: > 2017-02-08 15:57, Shahaf Shuler: > > /** > > + * It deletes registered eventfds. > > + * > > + * @param intr_handle > > + * Pointer to the interrupt handle. > > + */ > > +void > > +rte_int

[dpdk-dev] [PATCH v2 0/2] net/mlx5 add rxq interrupt support

2017-03-14 Thread Shahaf Shuler
This patchset adds support for rxq interrupts on MLX5 PMD. The first patch introduces changes on eal_interrupt to support external interrupt handlers. The second patch implements the support on mlx5 PMD and demonstrate the use of the changes made in the first patch on v2: * add new function to

[dpdk-dev] [PATCH v2 1/2] eal/linux: support external Rx interrupt

2017-03-14 Thread Shahaf Shuler
Prior to this patch only UIO/VFIO interrupt handlers types were supported. This patch adds support for the external interrupt handler type, allowing external drivers to set their own fds with specific interrupt handlers. Signed-off-by: Shahaf Shuler --- lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v2 2/2] net/mlx5: support user space rxq interrupt event

2017-03-14 Thread Shahaf Shuler
Implement rxq interrupt callbacks Signed-off-by: Shahaf Shuler --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/rel_notes/release_17_05.rst | 6 ++ drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.c| 2 + drivers/net/mlx5/mlx5_rxq.c

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Shahaf Shuler
t; > Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler [...]

Re: [dpdk-dev] [PATCH v2 2/2] doc: update PMD options for mlx5

2017-03-15 Thread Shahaf Shuler
. This limits the size of packet > + to be inlined. If the size of a packet is larger than configured > + value, the packet isn't inlined even though there's enough space > + remained in the descriptor. Instead, the packet is included with pointer. > + > + Effective on

[dpdk-dev] [PATCH] doc: add VLAN flow limitation on mlx5 PMD

2017-06-06 Thread Shahaf Shuler
On mlx5 PMD Flow pattern without any specific vlan will match for vlan packets as well. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro nelio.laranje...@6wind.com --- doc/guides/rel_notes/release_17_08.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH v2] doc: add VLAN flow limitation on mlx5 PMD

2017-06-13 Thread Shahaf Shuler
On mlx5 PMD Flow pattern without any specific vlan will match for vlan packets as well. Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- on v2: * move the reported issue to mlx5 guide as it is present since commit 12475fb203ad ("net/mlx5: support VLAN

[dpdk-dev] [PATCH] net/mlx5: fix TSO segment size

2017-06-19 Thread Shahaf Shuler
;) Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index cade625f9..70314b393 100644 --- a/drivers/net/mlx5/m

Re: [dpdk-dev] DPDK drivers should not use kernel version

2017-06-24 Thread Shahaf Shuler
ed only after 4.9. One could try to use the GSET API, and if fails use the GLINKSETTINGS. However, for kernels in range of [4.5,4.9) the behavior will not be correct. On this specific example - backported kernel should maintain both APIs. > > > > > $ git blame drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags

2017-04-12 Thread Shahaf Shuler
e device states") Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index d07253874..2d1bc12aa 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librt

[dpdk-dev] [PATCH 1/2] net/mlx5: modify PMD args process

2017-04-16 Thread Shahaf Shuler
argument process, enabling to differ which parameter was forced by the application. Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 72 + 1 file changed, 61 insertions(+), 11 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 2/2] net/mlx5: fix PMD specific parameters defaults

2017-04-16 Thread Shahaf Shuler
rdware TSO support") Signed-off-by: Shahaf Shuler Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 9d850dbbd..f

  1   2   3   4   5   6   7   8   9   10   >