[dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app

Signed-off-by: Shreyansh Jain --- doc/guides/testpmd_app_ug/build_app.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/testpmd_app_ug/build_app.rst b/doc/guides/testpmd_app_ug/build_app.rst index 7f32a7c..4c7cf2e 100644 --- a/doc/guides/testpmd_app_ug

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

Hi Jan, On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: > On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: >> On Thu, 14 Jul 2016 10:57:55 +0530 >> Shreyansh jain wrote: >> >>> Hi Jan, >>> >>> On Wednesday 13 July 2016 11:04 PM, Jan V

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi, This is more of a question/clarification than a comment. (And I have taken only some snippets from original mail to keep it cleaner) > +MEMPOOL_REGISTER_OPS(ops_mp_mc); > +MEMPOOL_REGISTER_OPS(ops_sp_sc); > +MEMPOOL_REGISTER_OPS(ops_mp_sc); > +MEMPOOL_REGISTER_OPS(ops_sp_mc); > +

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi, (Apologies for overly-eager email sent on this thread earlier. Will be more careful in future). This is more of a question/clarification than a comment. (And I have taken only some snippets from original mail to keep it cleaner) > +MEMPOOL_REGISTER_OPS(ops_mp_mc); >

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Hunt > Sent: Friday, June 03, 2016 8:28 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; David Hunt > Subject: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi David, Thanks for explanation. I have some comments inline... > -Original Message- > From: Hunt, David [mailto:david.hunt at intel.com] > Sent: Tuesday, June 07, 2016 2:56 PM > To: Shreyansh Jain ; dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi David, Sorry for multiple mails on a patch. I forgot a trivial comment in previous mail. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Hunt > Sent: Friday, June 03, 2016 8:28 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi David, > -Original Message- > From: Hunt, David [mailto:david.hunt at intel.com] > Sent: Thursday, June 09, 2016 3:10 PM > To: Shreyansh Jain ; dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com > S

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Thursday, June 09, 2016 6:01 PM > To: Shreyansh Jain > Cc: Hunt, David ; dev at dpdk.org; olivier.matz at > 6wind.com; > viktorin at rehivetech.com > Subject: Re

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi David, > -Original Message- > From: Hunt, David [mailto:david.hunt at intel.com] > Sent: Friday, June 10, 2016 3:05 PM > To: Olivier Matz ; Jan Viktorin > > Cc: Shreyansh Jain ; dev at dpdk.org; > jerin.jacob at caviumnetworks.com > Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, June 10, 2016 1:00 PM > To: Jan Viktorin ; Hunt, David > > Cc: Shreyansh Jain ; dev at dpdk.org; > jerin.jacob at caviumnetworks.com > Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH v1 02/28] eal: extract function eal_parse_sysfs_valuef

Hi Jan, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > Sent: Friday, May 06, 2016 7:18 PM > To: dev at dpdk.org > Cc: Jan Viktorin ; David Marchand > ; Thomas Monjalon ; > Bruce Richardson ; Declan Doherty > ; jianbo.liu at linaro.org; >

[dpdk-dev] [PATCH v1 07/28] eal/soc: add rte_eal_soc_register/unregister logic

Another trivial comment inlined: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > Sent: Friday, May 06, 2016 7:18 PM > To: dev at dpdk.org > Cc: Jan Viktorin ; David Marchand > ; Thomas Monjalon ; > Bruce Richardson ; Declan Doherty > ;

[dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > Sent: Friday, May 06, 2016 7:18 PM > To: dev at dpdk.org > Cc: Jan Viktorin ; David Marchand > ; Thomas Monjalon ; > Bruce Richardson ; Declan Doherty > ; jianbo.liu at linaro.org; > jerin.jacob

[dpdk-dev] [PATCH v1 02/28] eal: extract function eal_parse_sysfs_valuef

Hi Jan, > -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Monday, June 13, 2016 7:55 PM > To: Shreyansh Jain > Cc: dev at dpdk.org; David Marchand ; Thomas > Monjalon > ; Bruce Richardson intel.com>; > Declan Doherty

[dpdk-dev] [PATCH v10 1/3] mempool: support external mempool operations

Hi, > -Original Message- > From: David Hunt [mailto:david.hunt at intel.com] > Sent: Tuesday, June 14, 2016 3:16 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; Shreyansh Jain ; > David Hunt

[dpdk-dev] [PATCH v10 2/3] app/test: test external mempool manager

> -Original Message- > From: David Hunt [mailto:david.hunt at intel.com] > Sent: Tuesday, June 14, 2016 3:16 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; Shreyansh Jain ; > David Hunt >

[dpdk-dev] [PATCH v10 3/3] mbuf: make default mempool ops configurable at build

> -Original Message- > From: David Hunt [mailto:david.hunt at intel.com] > Sent: Tuesday, June 14, 2016 3:16 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; Shreyansh Jain ; > David Hunt >

[dpdk-dev] [PATCH v1 07/28] eal/soc: add rte_eal_soc_register/unregister logic

Hi Jan, One more comment which I missed in previous reply: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shreyansh Jain > Sent: Monday, June 13, 2016 7:50 PM > To: Jan Viktorin > Cc: David Marchand ; Thomas Monjalon > ; Bruce Ric

[dpdk-dev] [PATCH v12 0/3] mempool: add external mempool manager

Though I am late to the discussion... > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, June 15, 2016 10:10 PM > To: Hunt, David ; Jan Viktorin > > Cc: dev at dpdk.org; jerin.jacob at caviumnetworks.com; Shreyansh Jai

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

Hi David, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Friday, May 27, 2016 3:54 PM > To: David Marchand ; dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; viktorin at rehivetech.com > Subject: Re: [dpdk-dev] [PATCH v2 00/17]

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

Hi, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, June 16, 2016 1:04 PM > To: Shreyansh Jain > Cc: David Marchand ; viktorin at rehivetech.com; > dev at dpdk.org; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PA

[dpdk-dev] [PATCH v1 02/28] eal: extract function eal_parse_sysfs_valuef

Sorry, didn't notice this email earlier... Comments inline > -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Wednesday, June 15, 2016 3:26 PM > To: Shreyansh Jain > Cc: dev at dpdk.org; David Marchand ; Thomas > Monjalon &g

[dpdk-dev] [PATCH v3 00/17] prepare for rte_device / rte_driver

From: David Marchand * Original patch series is from David Marchand. This is just a rebase over master (d76c19309) * Following discussions with Jan [1] and some cleanup I started on pci code, here is a patchset that reworks pdev drivers registration and hotplug api.

[dpdk-dev] [PATCH v3 01/17] pci: no need for dynamic tailq init

From: David Marchand These lists can be initialized once and for all at build time. With this, those lists are only manipulated in a common place (and we could even make them private). A nice side effect is that pci drivers can now register in constructors.

[dpdk-dev] [PATCH v3 02/17] crypto: no need for a crypto pmd type

From: David Marchand This information is not used and just adds noise. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files

[dpdk-dev] [PATCH v3 03/17] drivers: align pci driver definitions

From: David Marchand Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH v3 04/17] eal: remove duplicate function declaration

From: David Marchand rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its introduction. This function has been exported in ABI, so remove it from eal_private.h Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and pci

[dpdk-dev] [PATCH v3 05/17] eal: introduce init macros

From: David Marchand Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). RTE_EAL_PCI_REGISTER is added as a helper for pci drivers. Suggested-by: Jan Viktorin

[dpdk-dev] [PATCH v3 06/17] crypto: export init/uninit common wrappers for pci drivers

From: David Marchand Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand ---

[dpdk-dev] [PATCH v3 07/17] ethdev: export init/uninit common wrappers for pci drivers

From: David Marchand Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 14

[dpdk-dev] [PATCH v3 08/17] drivers: convert all pdev drivers as pci drivers

From: David Marchand Simplify crypto and ethdev pci drivers init by using newly introduced init macros and helpers. Those drivers then don't need to register as "rte_driver"s anymore. virtio and mlx* drivers use the general purpose RTE_INIT macro, as they both need

[dpdk-dev] [PATCH v3 09/17] crypto: get rid of crypto driver register callback

From: David Marchand Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 22 ---

[dpdk-dev] [PATCH v3 10/17] ethdev: get rid of eth driver register callback

From: David Marchand Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v3 11/17] eal/linux: move back interrupt thread init before setting affinity

From: David Marchand Now that virtio pci driver is initialized in a constructor, iopl() stuff happens early enough so that interrupt thread can be created right after plugin loading. This way, chelsio driver should be happy again [1]. [1]

[dpdk-dev] [PATCH v3 12/17] pci: add a helper for device name

From: David Marchand eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c| 27 ---

[dpdk-dev] [PATCH v3 14/17] ethdev: do not scan all pci devices on attach

From: David Marchand No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8

[dpdk-dev] [PATCH v3 15/17] eal: add hotplug operations for pci and vdev

From: David Marchand hotplug which deals with resources should come from the layer that already handles them, i.e. eal. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand ---

[dpdk-dev] [PATCH v3 16/17] ethdev: convert to eal hotplug

From: David Marchand Remove bus logic from ethdev hotplug by using eal for this. Current api is preserved: - the last port that has been created is tracked to return it to the application when attaching, - the internal device name is reused when detaching. We can

[dpdk-dev] [PATCH v3 17/17] ethdev: get rid of device type

From: David Marchand Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +-

[dpdk-dev] [PATCH v3 10/17] ethdev: get rid of eth driver register callback

On Thursday 16 June 2016 07:36 PM, Shreyansh Jain wrote: > From: David Marchand > > Now that all pdev are pci drivers, we don't need to register ethdev drivers > through a dedicated channel. > > Signed-off-by: David Marchand > --- > lib/librte_ether/rt

[dpdk-dev] [PATCH v4 00/17] prepare for rte_device / rte_driver

* Original patch series is from David Marchand [1], [2]. * Cover letter text has been modified to make it author agnostic David created the original patchset based on the discussions on list [3]. Being a large piece of work, this patchset introduces first level of changes for generalizing the

[dpdk-dev] [PATCH v4 01/17] pci: no need for dynamic tailq init

Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c| 3 --- lib/librte_eal/common/eal_common_pci.c | 6 -- lib/librte_eal/linuxapp/eal/eal_pci.c | 3 --- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal

[dpdk-dev] [PATCH v4 02/17] crypto: no need for a crypto pmd type

This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v4 03/17] drivers: align pci driver definitions

Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2

[dpdk-dev] [PATCH v4 04/17] eal: remove duplicate function declaration

Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_private.h | 7 --- lib/librte_eal/linuxapp/eal/eal.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 857dc3e..06a68f6 100644

[dpdk-dev] [PATCH v4 05/17] eal: introduce init macros

-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_dev.h | 4 ++-- lib/librte_eal/common/include/rte_eal.h | 3 +++ lib/librte_eal/common/include/rte_pci.h | 8 lib/librte_eal/common/include/rte_tailq.h | 4 ++-- 4

[dpdk-dev] [PATCH v4 06/17] crypto: export init/uninit common wrappers for pci drivers

Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c

[dpdk-dev] [PATCH v4 07/17] ethdev: export init/uninit common wrappers for pci drivers

Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 14 +++--- lib

[dpdk-dev] [PATCH v4 08/17] drivers: convert all pdev drivers as pci drivers

egistering a pci driver. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 16 +++ drivers/net/bnx2x/bnx2x_ethdev.c| 35 +--- drivers/net/cxgbe/cxgbe_ethdev.c| 24 +++-- drivers

[dpdk-dev] [PATCH v4 09/17] crypto: get rid of crypto driver register callback

Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30

[dpdk-dev] [PATCH v4 10/17] ethdev: get rid of eth driver register callback

Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12

[dpdk-dev] [PATCH v4 11/17] eal/linux: move back interrupt thread init before setting affinity

Marchand Tested-by: Rahul Lakkireddy Signed-off-by: Shreyansh Jain --- lib/librte_eal/linuxapp/eal/eal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 29fba52..748daca 100644 --- a/lib

[dpdk-dev] [PATCH v4 12/17] pci: add a helper for device name

eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c| 27 --- lib/librte_eal/common/include

[dpdk-dev] [PATCH v4 13/17] pci: add a helper to update a device

This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 + lib/librte_eal/common

[dpdk-dev] [PATCH v4 14/17] ethdev: do not scan all pci devices on attach

No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6 deletions

[dpdk-dev] [PATCH v4 15/17] eal: add hotplug operations for pci and vdev

hotplug which deals with resources should come from the layer that already handles them, i.e. eal. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal

[dpdk-dev] [PATCH v4 16/17] ethdev: convert to eal hotplug

Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 158 +- 1 file changed, 33 insertions(+), 125 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 6f2b169..28604ca 100644 --- a/lib/librte_ether

[dpdk-dev] [PATCH v4 17/17] ethdev: get rid of device type

Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- drivers/net/bonding

[dpdk-dev] [PATCH v4 00/17] prepare for rte_device / rte_driver

Self NACK. Rebase over master before posting series broke compilation. Apologies. On Tuesday 21 June 2016 05:32 PM, Shreyansh Jain wrote: > * Original patch series is from David Marchand [1], [2]. > * Cover letter text has been modified to make it author agnostic > > David created

[dpdk-dev] [PATCH v5 00/17] Prepare for rte_device / rte_driver

/archives/dev/2016-January/032387.html [2] http://dpdk.org/ml/archives/dev/2016-April/037686.html [3] http://dpdk.org/ml/archives/dev/2016-January/031390.html David Marchand, Shreyansh Jain (17): pci: no need for dynamic tailq init crypto: no need for a crypto pmd type drivers: align pci driver

[dpdk-dev] [PATCH v5 01/17] pci: no need for dynamic tailq init

Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c| 3 --- lib/librte_eal/common/eal_common_pci.c | 6 -- lib/librte_eal/linuxapp/eal/eal_pci.c | 3 --- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal

[dpdk-dev] [PATCH v5 02/17] crypto: no need for a crypto pmd type

This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v5 05/17] eal: introduce init macros

Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). RTE_EAL_PCI_REGISTER is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v5 06/17] crypto: export init/uninit common wrappers for pci drivers

Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c

[dpdk-dev] [PATCH v5 08/17] drivers: convert all pdev drivers as pci drivers

egistering a pci driver. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 16 +++ drivers/net/bnx2x/bnx2x_ethdev.c| 35 +--- drivers/net/cxgbe/cxgbe_ethdev.c| 24 +++-- drivers

[dpdk-dev] [PATCH v5 10/17] ethdev: get rid of eth driver register callback

Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12

[dpdk-dev] [PATCH v5 09/17] crypto: get rid of crypto driver register callback

Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30

[dpdk-dev] [PATCH v5 11/17] eal/linux: move back interrupt thread init before setting affinity

Marchand Tested-by: Rahul Lakkireddy Signed-off-by: Shreyansh Jain --- lib/librte_eal/linuxapp/eal/eal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 29fba52..748daca 100644 --- a/lib

[dpdk-dev] [PATCH v5 07/17] ethdev: export init/uninit common wrappers for pci drivers

Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 14 +++--- lib

[dpdk-dev] [PATCH v5 12/17] pci: add a helper for device name

eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c| 27 --- lib/librte_eal/common/include

[dpdk-dev] [PATCH v5 13/17] pci: add a helper to update a device

This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 + lib/librte_eal/common

[dpdk-dev] [PATCH v5 14/17] ethdev: do not scan all pci devices on attach

No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6 deletions

[dpdk-dev] [PATCH v5 16/17] ethdev: convert to eal hotplug

Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 207 +++--- 1 file changed, 33 insertions(+), 174 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 6f2b169..10e81e1 100644 --- a/lib/librte_ether

[dpdk-dev] [PATCH v5 09/17] crypto: get rid of crypto driver register callback

On Wednesday 22 June 2016 06:57 PM, Neil Horman wrote: > On Wed, Jun 22, 2016 at 02:36:28PM +0530, Shreyansh Jain wrote: >> Now that all pdev are pci drivers, we don't need to register crypto drivers >> through a dedicated channel. >> >> Signed-off-by: David Marchand

[dpdk-dev] [PATCH v5 10/17] ethdev: get rid of eth driver register callback

On Wednesday 22 June 2016 06:58 PM, Neil Horman wrote: > On Wed, Jun 22, 2016 at 02:36:29PM +0530, Shreyansh Jain wrote: >> Now that all pdev are pci drivers, we don't need to register ethdev drivers >> through a dedicated channel. >> >> Signed-off-by: David Marchand

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

Hi Jan, On Friday 06 May 2016 07:18 PM, Jan Viktorin wrote: > Signed-off-by: Jan Viktorin > --- > lib/librte_ether/rte_ethdev.c | 127 > +- > lib/librte_ether/rte_ethdev.h | 31 +++ > 2 files changed, 157 insertions(+), 1 deletion(-) > > diff

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

On Monday 04 July 2016 06:34 PM, Jan Viktorin wrote: > On Wed, 29 Jun 2016 15:12:07 +0530 > Shreyansh jain wrote: > >> Hi Jan, >> >> On Friday 06 May 2016 07:18 PM, Jan Viktorin wrote: >>> Signed-off-by: Jan Viktorin >>>

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: > On Mon, 4 Jul 2016 19:57:18 +0530 > Shreyansh jain wrote: > > [...] > >>>>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct >>>>> rte_eth_dev_info *dev_info) >

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

Hi Jan, Apologies for delay in my response. On Tuesday 05 July 2016 10:46 AM, Jan Viktorin wrote: > Hello Shreyansh, > ? >> On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: >>> On Mon, 4 Jul 2016 19:57:18 +0530 >>> Shreyansh jain wrote: >>> &

[dpdk-dev] [PATCH v1 00/15] rte_driver/device infrastructure

Hi Jan, On Saturday 09 July 2016 12:39 AM, Jan Viktorin wrote: > Hello, > > based on the discussions with Shreyansh, I propose a patchset with > the important EAL changes. It is incomplete and I suppose to extend > and change certain things in the foreseeable future. > > Important notes: > > *

[dpdk-dev] [PATCH v1 01/15] eal: extract vdev infra

Hi Jan, Some comments. On Saturday 09 July 2016 12:39 AM, Jan Viktorin wrote: > Move all PMD_VDEV-specific code into a separate module and header > file to not polute the generic code anymore. There is now a list > of virtual devices available. > > The rte_vdev_driver integrates the original

[dpdk-dev] [PATCH v6 00/17] Prepare for rte_device / rte_driver

4.html [7] http://dpdk.org/ml/archives/dev/2016-July/043172.html David Marchand, Shreyansh Jain (17): pci: no need for dynamic tailq init crypto: no need for a crypto pmd type drivers: align pci driver definitions eal: remove duplicate function declaration eal: introduce init macros

[dpdk-dev] [PATCH v6 04/17] eal: remove duplicate function declaration

Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_private.h | 7 --- lib/librte_eal/linuxapp/eal/eal.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 857dc3e..06a68f6 100644

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). DRIVER_REGISTER_PCI is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v6 06/17] crypto: export init/uninit common wrappers for pci drivers

Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c

[dpdk-dev] [PATCH v6 07/17] ethdev: export init/uninit common wrappers for pci drivers

Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 14 +++--- lib

[dpdk-dev] [PATCH v6 08/17] drivers: convert all pdev drivers as pci drivers

t modified - they continue to use PMD_REGISTER_DRIVER. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 16 +++- drivers/net/bnx2x/bnx2x_ethdev.c| 34 +--- drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v6 10/17] ethdev: get rid of eth driver register callback

Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12

[dpdk-dev] [PATCH v6 09/17] crypto: get rid of crypto driver register callback

Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30

[dpdk-dev] [PATCH v6 11/17] eal/linux: move back interrupt thread init before setting affinity

Marchand Tested-by: Rahul Lakkireddy Signed-off-by: Shreyansh Jain --- lib/librte_eal/linuxapp/eal/eal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index fe9c704..259a7e4 100644 --- a/lib

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c| 27 --- lib/librte_eal/common/include

[dpdk-dev] [PATCH v6 13/17] pci: add a helper to update a device

This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 + lib/librte_eal/common

[dpdk-dev] [PATCH v6 14/17] ethdev: do not scan all pci devices on attach

No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6 deletions

[dpdk-dev] [PATCH v6 15/17] eal: add hotplug operations for pci and vdev

Hotplug which deals with resources should come from the layer that already handles them, i.e. EAL. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal

[dpdk-dev] [PATCH v6 16/17] ethdev: convert to eal hotplug

Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 207 +++--- 1 file changed, 33 insertions(+), 174 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index a667012..8d14fd7 100644 --- a/lib/librte_ether

[dpdk-dev] [PATCH v6 17/17] ethdev: get rid of device type

Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- drivers/net/bonding

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

Hi Jan, On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: > On Mon, 4 Jul 2016 19:57:18 +0530 > Shreyansh jain wrote: > > [...] > >>>>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct >>>>> rte_eth_dev_info *dev_info) >

[dpdk-dev] [PATCH] doc: grammatical fix in EAL docs

Signed-off-by: Shreyansh Jain --- doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst index 4b9895e..10a10a8 100644 --- a/doc/guides

[dpdk-dev] [PATCH] doc: fix consumer/producer mixup in Ring lib doc

Signed-off-by: Shreyansh Jain --- doc/guides/prog_guide/ring_lib.rst | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/guides/prog_guide/ring_lib.rst b/doc/guides/prog_guide/ring_lib.rst index 3b92a8f..5cf4ce2 100644 --- a/doc/guides/prog_guide

  1   2   3   4   5   >