On 2015/02/04 10:44, Qiu, Michael wrote:
> On 2/3/2015 6:30 PM, Tetsuya Mukawa wrote:
>> On 2015/02/03 18:14, Qiu, Michael wrote:
>>> On 2/3/2015 2:16 PM, Qiu, Michael wrote:
>>>> On 2/1/2015 12:02 PM, Tetsuya Mukawa wrote:
>>>>> The patch introduces f
with CONFIG_RTE_BUILD_SHARED_LIB, it may need to
specify more libraries using '-d' option.
v4:
- Fix memory leak.
(Thanks to Iremonger, Bernard)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 5 +
config/common_linuxapp | 5 +
lib/Makefile | 1
This patch adds port hotplug support to null PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Fix commit title.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 32
1 file changed, 32 insertions(+)
diff --git a/lib/librte_pmd_null
eal_pci: pci memory map work with driver type
Tetsuya Mukawa (12):
eal/pci,ethdev: Remove assumption that port will not be detached
eal/pci: Consolidate pci address comparison APIs
ethdev: Add rte_eth_dev_free to free specified device
eal,ethdev: Add a function and function pointers to close
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 454 +---
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 186 insertions(+), 275 deletions(-)
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by
eal_compare_pci_addr().
v5:
- Fix pci_scan_one to handle pt_driver correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal
rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 7 +
lib/librte_ether/rte_ethdev.c | 47 +
lib
bug while comparing pci addresses.
- Add error checking codes.
Reported-by: Mark Enright
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 109 +-
lib/librte_ether/rte_ethdev.h | 80 +++
2 files changed, 188
The function removes the specified devargs entry from devargs_list.
Also, the patch adds sanity checking to rte_eal_devargs_add().
v5:
- Change function definition of rte_eal_devargs_remove().
v4:
- Fix sanity check code.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common
:
- Remove RTE_EAL_INVOKE_TYPE_UNKNOWN, because it's unused.
v4:
- Fix parameter checking.
- Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 90 +
lib/librte_eal/common/eal_private.h | 24 +
lib
function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 274
lib/librte_eal/common/eal_private.h | 11 ++
lib/librte_eal/common/include/rte_dev.h | 33
lib/librte_eal/linuxapp/eal/Makefile| 1 +
lib/librte_eal
The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration.
Signed-off-by: Tetsuya Mukawa
---
config/common_linuxapp | 5 +
1 file changed, 5 insertions(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index d428f84..81055f8 100644
--- a/config/common_linuxapp
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
)
- port_id: port identifier
v7:
- Fix doc.
(Thanks to Iremonger, Bernard)
- Fix port checking implementation of star_port();
(Thanks to Qiu, Michael)
v5:
- Add testpmd documentation.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test
On 2015/02/06 20:32, Iremonger, Bernard wrote:
> Hi Tetsuya,
>
> My comments are in line below.
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Friday, February 6, 2015 4:38 AM
>> To: dev at dpdk.org
>&
On 2015/02/10 0:34, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Monday, February 9, 2015 8:31 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Qiu, Michael; Tetsuya Mukawa
>>
On 2015/02/11 0:08, Iremonger, Bernard wrote:
>> -Original Message-
>> From: Qiu, Michael
>> Sent: Monday, February 9, 2015 1:10 PM
>> To: Tetsuya Mukawa; dev at dpdk.org
>> Cc: Iremonger, Bernard
>> Subject: Re: [PATCH v7 04/14] eal/pci: Consoli
On 2015/02/11 12:27, Qiu, Michael wrote:
> On 2/10/2015 11:11 PM, Iremonger, Bernard wrote:
>>> -Original Message-
>>> From: Qiu, Michael
>>> Sent: Monday, February 9, 2015 1:10 PM
>>> To: Tetsuya Mukawa; dev at dpdk.org
>>> Cc: Iremonger, B
On 2015/02/11 13:53, Tetsuya Mukawa wrote:
> On 2015/02/11 12:27, Qiu, Michael wrote:
>> On 2/10/2015 11:11 PM, Iremonger, Bernard wrote:
>>>> -Original Message-
>>>> From: Qiu, Michael
>>>> Sent: Monday, February 9, 2015 1:10 PM
>>>&g
On 2015/02/11 21:13, Qiu, Michael wrote:
> On 2/11/2015 4:14 PM, Tetsuya Mukawa wrote:
>> On 2015/02/11 15:29, Qiu, Michael wrote:
>>> On 2/11/2015 12:57 PM, Tetsuya Mukawa wrote:
>>>> On 2015/02/11 13:53, Tetsuya Mukawa wrote:
>>>>> On 2015/02/11 12:2
with CONFIG_RTE_BUILD_SHARED_LIB, it may need to
specify more libraries using '-d' option.
v7:
- Add parameter checkings.
(Thanks to Iremonger, Bernard)
- Remove needless "__rte_unused".
v4:
- Fix memory leak.
(Thanks to Iremonger, Bernard)
Signed-off-by: Tetsuya Mukawa
---
config/com
This patch adds port hotplug support to Null PMD.
v7:
- Add parameter checkings.
(Thanks to Iremonger, Bernard)
v6:
- Fix a parameter of rte_eth_dev_free().
v4:
- Fix commit title.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 35
to hold kernel driver type
eal_pci: pci memory map work with driver type
Tetsuya Mukawa (12):
eal/pci,ethdev: Remove assumption that port will not be detached
eal/pci: Consolidate pci address comparison APIs
ethdev: Add rte_eth_dev_free to free specified device
eal,ethdev: Add a function
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
parameters of rte_eth_dev_validate_port() to cleanup code.
v4:
- Use braces with 'for' loop.
- Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 454 +---
lib/librte_ether/rt
of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h | 34 +++
lib/librte_eal
This patch adds rte_eth_dev_free(). The function is used for changing an
attached status of the device that has specified name.
v6:
- Use rte_eth_dev structure as the paramter of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c
rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 7 +
lib/librte_ether/rte_ethdev.c | 47 +
lib
of below functions.
rte_eth_dev_get_changed_port().
rte_eth_dev_get_port_by_addr().
v4:
- Add parameter checking.
v3:
- Fix if-condition bug while comparing pci addresses.
- Add error checking codes.
Reported-by: Mark Enright
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c
to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/Makefile | 1 +
lib/librte_eal/common/include/rte_dev_hotplug.h | 44 +
lib/librte_eal/linuxapp/eal/eal_pci.c | 44 +
lib/librte_eal/linuxapp/eal
The function removes the specified devargs entry from devargs_list.
Also, the patch adds sanity checking to rte_eal_devargs_add().
v5:
- Change function definition of rte_eal_devargs_remove().
v4:
- Fix sanity check code.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common
:
- Remove RTE_EAL_INVOKE_TYPE_UNKNOWN, because it's unused.
v4:
- Fix parameter checking.
- Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 90 +
lib/librte_eal/common/eal_private.h | 24 +
lib
.
(Thanks to Qiu, Michael and Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
app/test/virtual_pmd.c | 2 +-
lib/librte_ether/rte_ethdev.c| 25 +++--
lib/librte_ether/rte_ethdev.h
in rte_eal_dev_detach().
v4:
- Fix comment.
- Add error checking.
- Fix indent of 'if' statement.
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 276
lib/librte_eal/common/eal_private.h | 11 +
lib/librte_eal/common
The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration.
Signed-off-by: Tetsuya Mukawa
---
config/common_linuxapp | 5 +
1 file changed, 5 insertions(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index d428f84..81055f8 100644
--- a/config/common_linuxapp
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
)
- port_id: port identifier
v7:
- Fix doc.
(Thanks to Iremonger, Bernard)
- Fix port checking implementation of star_port();
(Thanks to Qiu, Michael)
v5:
- Add testpmd documentation.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test
This patch adds port hotplug support to Null PMD.
v7:
- Add parameter checkings.
(Thanks to Iremonger, Bernard)
v6:
- Fix a parameter of rte_eth_dev_free().
v4:
- Fix commit title.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 35
Hi Xie,
Could you please check commit title?
I guess this commit title involves first sentence of commit log.
Thanks,
Tetsuya
On 2015/02/12 14:07, Huawei Xie wrote:
> In virtnet_send_command:
>
> /* Caller should know better */
> BUG_ON(!virtio_has_feature(vi->vdev,
On 2015/02/12 14:07, Huawei Xie wrote:
> * support calling rte_vhost_driver_register after
> rte_vhost_driver_session_start
> * add mutext to protect fdset from concurrent access
> * add busy flag in fdentry. this flag is set before cb and cleared after cb
> is finished.
>
> mutex lock scenario
On 2015/02/12 14:07, Huawei Xie wrote:
> vhost-user supports passing vring information to a seperate vhost enabled
> user space process, normally a user space vSwitch, through unix domain socket.
>
> In previous DPDK version, we implement a user space character device driver
> vhost-cuse in user
On 2015/02/16 21:45, Neil Horman wrote:
> On Mon, Feb 16, 2015 at 01:14:27PM +0900, Tetsuya Mukawa wrote:
>> The patch adds functions for unmapping igb_uio resources. The patch is only
>> for Linux and igb_uio environment. VFIO and BSD are not supported.
>>
>> v8:
On 2015/02/16 21:41, Neil Horman wrote:
> On Mon, Feb 16, 2015 at 01:14:26PM +0900, Tetsuya Mukawa wrote:
>> The patch adds following functions.
>>
>> - rte_eth_dev_save()
>> The function is used for saving current rte_eth_dev structures.
>> - rte_eth_dev_get
Hi Thomas,
I appreciate for your all comments.
On 2015/02/17 9:36, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> To remove assumption, do like followings.
>>
>> This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver
>> structu
On 2015/02/17 9:44, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> This patch replaces pci_addr_comparison() and memcmp() of pci addresses by
>> eal_compare_pci_addr().
>>
>> v8:
>> - Fix pci_scan_one() to update sysfs values.
>> (Thanks
On 2015/02/17 9:46, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> This patch adds rte_eth_dev_free(). The function is used for changing an
>> attached status of the device that has specified name.
>>
>> v6:
>> - Use rte_eth_dev structure as the para
On 2015/02/17 9:56, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> The patch adds function pointer to rte_pci_driver and eth_driver
>> structure. These function pointers are used when ports are detached.
>> Also, the patch adds rte_eth_dev_uninit(). So
On 2015/02/17 10:11, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> The patch adds functions for unmapping igb_uio resources. The patch is only
>> for Linux and igb_uio environment. VFIO and BSD are not supported.
>>
>> v8:
>> - Fix typo.
>>
On 2015/02/17 10:18, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> - Add rte_eal_pci_close_one_dirver()
>> The function is used for closing the specified driver and device.
>> - Add pci_invoke_all_drivers()
>> The function is based on pci_probe_all_d
On 2015/02/17 10:24, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> This new parameter is needed to keep device type like physical or virtual.
> Actually types are "PCI" and "virtual".
OK, I will change above sentence to explain it more clear
On 2015/02/17 10:25, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration.
> This patch should be introduced earlier in the patchset.
Sure, I will.
On 2015/02/17 10:04, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> The patch adds following functions.
>>
>> - rte_eth_dev_save()
>> The function is used for saving current rte_eth_dev structures.
>> - rte_eth_dev_get_changed_port()
>>
On 2015/02/17 10:48, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> These functions are used for attaching or detaching a port.
>> When rte_eal_dev_attach() is called, the function tries to realize the
>> device name as pci address. If this
On 2015/02/17 18:23, Thomas Monjalon wrote:
> 2015-02-17 17:51, Tetsuya Mukawa:
>> On 2015/02/17 10:48, Thomas Monjalon wrote:
>>> 2015-02-16 13:14, Tetsuya Mukawa:
>>>> +/* attach the new physical device, then store port_id of the device */
>>>> +stati
On 2015/02/18 10:02, Thomas Monjalon wrote:
> 2015-02-17 15:14, Tetsuya Mukawa:
>> On 2015/02/17 9:44, Thomas Monjalon wrote:
>>> 2015-02-16 13:14, Tetsuya Mukawa:
>>>> @@ -356,13 +342,24 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf)
>>>>
On 2015/02/18 10:17, Thomas Monjalon wrote:
> 2015-02-17 19:26, Tetsuya Mukawa:
>> On 2015/02/17 18:23, Thomas Monjalon wrote:
>>> 2015-02-17 17:51, Tetsuya Mukawa:
>>>> On 2015/02/17 10:48, Thomas Monjalon wrote:
>>>>> 2015-02-16 13:14, Tetsuya Muka
On 2015/02/18 10:54, Tetsuya Mukawa wrote:
> On 2015/02/18 9:31, Thomas Monjalon wrote:
>> 2015-02-17 15:14, Tetsuya Mukawa:
>>> On 2015/02/17 9:36, Thomas Monjalon wrote:
>>>> 2015-02-16 13:14, Tetsuya Mukawa:
>>>> Is uint8_t sill a good size for hotplugg
On 2015/02/18 10:09, Thomas Monjalon wrote:
> 2015-02-17 15:15, Tetsuya Mukawa:
>> On 2015/02/17 10:11, Thomas Monjalon wrote:
>>> 2015-02-16 13:14, Tetsuya Mukawa:
>>>> +#ifdef ENABLE_HOTPLUG
>>> Please avoid using #ifdef if not really necessary.
>> I
On 2015/02/18 19:03, Bruce Richardson wrote:
> On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote:
>> 2015-02-18 15:10, Tetsuya Mukawa:
>>> On 2015/02/18 10:54, Tetsuya Mukawa wrote:
>>>> On 2015/02/18 9:31, Thomas Monjalon wrote:
>>>>> 201
On 2015/02/18 20:39, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>> Sent: Wednesday, February 18, 2015 10:33 AM
>> To: Iremonger, Bernard
>> Cc: Tetsuya Mukawa; dev at dpdk.org; ivan.
On 2015/02/18 21:23, Bruce Richardson wrote:
> On Wed, Feb 18, 2015 at 07:58:06PM +0900, Tetsuya Mukawa wrote:
>> On 2015/02/18 19:03, Bruce Richardson wrote:
>>> On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote:
>>>> 2015-02-18 15:10, Tetsuya Muk
On 2015/02/18 21:33, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
>> Sent: Wednesday, February 18, 2015 10:58 AM
>> To: Richardson, Bruce; Thomas Monjalon
>> Cc: dev at dpd
flag to hold kernel driver type
eal_pci: pci memory map work with driver type
Tetsuya Mukawa (12):
eal: Enable port Hotplug framework in Linux
eal/pci,ethdev: Remove assumption that port will not be detached
eal/pci: Consolidate pci address comparison APIs
ethdev: Add rte_eth_dev_rel
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD
configuration. So far, Hotplug functions only support linux.
v9:
- Move this patch at the top of this patch series.
(Thanks to Thomas Monjalon)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 ++
config
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 273
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 177 insertions(+), 103 deletions(-)
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 11 +++
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 23 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 56797a5
parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 6
lib/librte_ether/rte_ethdev.c | 62 +++--
lib/librte_ether/rte_ethdev.h | 24 +
3 files changed, 90
:
- Add parameter checking.
v3:
- Fix if-condition bug while comparing pci addresses.
- Add error checking codes.
Reported-by: Mark Enright
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 103 -
lib/librte_ether/rte_ethdev.h | 83
ove pci_unmap_device(). It will be implemented in later patch.
v8:
- Fix typo.
(Thanks to Iremonger, Bernard)
v5:
- Fix pci_unmap_device() to check pt_driver.
v4:
- Add parameter checking.
- Add header file to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal
The function removes the specified devargs entry from devargs_list.
Also, the patch adds sanity checking to rte_eal_devargs_add().
v5:
- Change function definition of rte_eal_devargs_remove().
v4:
- Fix sanity check code.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common
indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 98 -
lib/librte_eal/common/eal_private.h | 15 +
lib/librte_eal/common/include/rte_pci.h | 32 +++
lib/librte_eal/linuxapp/eal/eal_pci.c | 94
is replaced by RTE_ETH_DEV_PCI.
(Thanks to Thomas Monjalon)
v8:
- NONE_TRACE is replaced by NO_TRACE.
- Add missing symbol in version map.
(Thanks to Qiu, Michael and Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
app/test/virtual_pmd.c
-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 307
lib/librte_eal/common/eal_private.h | 11 +
lib/librte_eal/common/include/rte_dev.h | 33 +++
lib/librte_eal/linuxapp/eal/Makefile| 1 +
lib/librte_eal
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
)
- port_id: port identifier
v7:
- Fix doc.
(Thanks to Iremonger, Bernard)
- Fix port checking implementation of star_port();
(Thanks to Qiu, Michael)
v5:
- Add testpmd documentation.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test
emory leak.
(Thanks to Iremonger, Bernard)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 5 +
config/common_linuxapp | 5 +
lib/Makefile | 1 +
lib/librte_pmd_null/Makefile | 6
This patch adds port hotplug support to Null PMD.
v9:
- Use rte_eth_dev_release_port() instead of rte_eth_dev_free().
v7:
- Add parameter checkings.
(Thanks to Iremonger, Bernard)
v6:
- Fix a parameter of rte_eth_dev_free().
v4:
- Fix commit title.
Signed-off-by: Tetsuya Mukawa
---
lib
On 2015/02/19 20:17, Thomas Monjalon wrote:
>> @@ -152,6 +159,7 @@ struct rte_pci_device {
>> uint16_t max_vfs; /**< sriov enable if not zero */
>> int numa_node; /**< NUMA node connection */
>> struct rte_devargs *devargs;
On 2015/02/19 20:24, Thomas Monjalon wrote:
> 2015-02-19 11:49, Tetsuya Mukawa:
>> --- a/lib/librte_ether/rte_ether_version.map
>> +++ b/lib/librte_ether/rte_ether_version.map
>> @@ -109,6 +109,13 @@ DPDK_2.0 {
>> rte_eth_tx_queue_setup;
On 2015/02/19 22:30, Tetsuya Mukawa wrote:
> On 2015/02/19 21:10, Thomas Monjalon wrote:
>> 2015-02-19 11:49, Tetsuya Mukawa:
>>> +/* attach the new virtual device, then store port_id of the device */
>>> +static int
>>> +rte_eal_dev_attach_vdev(co
Hi,
It seems after applying below patch, 2nd parameter of PMD initialization
code can be NULL when vdev option is like below.
commit c07691ae10894bb6bf284fed75829b95844eacdb
devargs: remove limit on parameters length
Here is example vdev option
--vdev
On 2015/02/19 23:31, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Thursday, February 19, 2015 2:50 AM
>> To: dev at dpdk.org
>> Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon
On 2015/02/19 23:51, Iremonger, Bernard wrote:
>
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Thursday, February 19, 2015 2:50 AM
>> To: dev at dpdk.org
>> Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon
On 2015/02/19 22:29, Tetsuya Mukawa wrote:
> On 2015/02/19 20:17, Thomas Monjalon wrote:
>>> @@ -152,6 +159,7 @@ struct rte_pci_device {
>>> uint16_t max_vfs; /**< sriov enable if not zero */
>>> int numa_node;
g, if attaching and
detaching
is repeatedly.
- Fix if-condition of rte_eth_dev_get_port_by_addr().
(Thanks to Mark Enright)
RFC PATCH v2 Changes:
- remove 'rte_eth_dev_validate_port()', and cleanup codes.
Michael Qiu (2):
eal_pci: Add flag to hold kernel driver type
eal_pci: pci memory map
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD
configuration. So far, Hotplug functions only support linux.
v9:
- Move this patch at the top of this patch series.
(Thanks to Thomas Monjalon)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 ++
config
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 273
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 177 insertions(+), 103 deletions(-)
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 11 +++
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 23 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 6e22216
Monjalon)
v6:
- Fix rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 6
lib/librte_ether/rte_ethdev.c | 64
1 - 100 of 983 matches
Mail list logo