[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-24 Thread Tetsuya Mukawa
On 2015/11/21 9:15, Rich Lane wrote: > On Thu, Nov 12, 2015 at 9:20 PM, Tetsuya Mukawa wrote: > >> +static uint16_t >> +eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) >> +{ >> > ... > >> + >> + /* Enque

[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-24 Thread Tetsuya Mukawa
On 2015/11/24 12:40, Yuanhan Liu wrote: > On Tue, Nov 24, 2015 at 11:48:04AM +0900, Tetsuya Mukawa wrote: >> On 2015/11/20 20:43, Yuanhan Liu wrote: >>> On Fri, Nov 13, 2015 at 02:20:31PM +0900, Tetsuya Mukawa wrote: >>> >>>> +st

[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-24 Thread Tetsuya Mukawa
On 2015/11/20 20:43, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 02:20:31PM +0900, Tetsuya Mukawa wrote: > >> +static pthread_mutex_t internal_list_lock = PTHREAD_MUTEX_INITIALIZER; >> + >> +static rte_atomic16_t nb_started_ports; >> +pthread_t session

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-11-20 Thread Tetsuya Mukawa
On 2015/11/20 11:35, Tetsuya Mukawa wrote: > On 2015/11/20 11:00, Xie, Huawei wrote: >> On 11/20/2015 2:16 AM, Rich Lane wrote: >>> What's the reason for using qemu as a middleman? Couldn't the new PMD >>> itself open /dev/vhost-net or the vhost-user socket and send

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-11-20 Thread Tetsuya Mukawa
On 2015/11/20 11:00, Xie, Huawei wrote: > On 11/20/2015 2:16 AM, Rich Lane wrote: >> What's the reason for using qemu as a middleman? Couldn't the new PMD >> itself open /dev/vhost-net or the vhost-user socket and send the commands >> to set up virtqueues? That was the approach taken by Jianfeng's

[dpdk-dev] [RFC PATCH 2/2] virtio: Extend virtio-net PMD to support container environment

2015-11-19 Thread Tetsuya Mukawa
emory between DPDK application and ivshmem device in QEMU. Signed-off-by: Tetsuya Mukawa --- config/common_linuxapp | 5 + drivers/net/virtio/Makefile| 4 + drivers/net/virtio/qtest.c | 590 + drivers/net/virtio/virtio_ethdev.c | 2

[dpdk-dev] [RFC PATCH 1/2] EAL: Add new EAL "--shm" option.

2015-11-19 Thread Tetsuya Mukawa
The patch adds new EAL "--shm" option. If the option is specified, EAL will allocate one file from hugetlbfs. This memory is for sharing memory between DPDK applicaiton and QEMU ivhsmem device. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_options.c | 5 +++ lib/

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-11-19 Thread Tetsuya Mukawa
any kind of QEMU devices from DPDK application. So far, I don't have any ideas except for virtio-net device. But someone would have. Tetsuya Mukawa (2): EAL: Add new EAL "--shm" option. virtio: Extend virtio-net PMD to support container environment config/common_linuxapp

[dpdk-dev] [PATCH v2] vhost: Fix reset_owner message handling not to clear callfd

2015-11-19 Thread Tetsuya Mukawa
The patch fixes reset_owner message handling not to clear callfd, because callfd will be valid while connection is establihed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/virtio-net.c | 44 +-- 1 file changed, 38 insertions(+), 6 deletions(-) diff

[dpdk-dev] [PATCH] vhost: Fix reset_owner message handling not to clear callfd

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/19 16:03, Yuanhan Liu wrote: > On Thu, Nov 19, 2015 at 03:23:26PM +0900, Tetsuya Mukawa wrote: >> The patch fixes reset_owner message handling not to clear callfd, >> because callfd will be valid while connection is establihed. >> >> Signed-off-by: Tet

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/19 15:31, Yuanhan Liu wrote: > On Thu, Nov 19, 2015 at 02:58:56PM +0900, Tetsuya Mukawa wrote: >> On 2015/11/19 14:45, Yuanhan Liu wrote: >>> On Thu, Nov 19, 2015 at 02:14:13PM +0900, Tetsuya Mukawa wrote: >>>> On 2015/11/19 12:33, Yuanhan Liu wrote: >&

[dpdk-dev] [PATCH] vhost: Fix reset_owner message handling not to clear callfd

2015-11-19 Thread Tetsuya Mukawa
The patch fixes reset_owner message handling not to clear callfd, because callfd will be valid while connection is establihed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/virtio-net.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/lib

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/19 14:45, Yuanhan Liu wrote: > On Thu, Nov 19, 2015 at 02:14:13PM +0900, Tetsuya Mukawa wrote: >> On 2015/11/19 12:33, Yuanhan Liu wrote: >>> On Thu, Nov 19, 2015 at 12:13:38PM +0900, Tetsuya Mukawa wrote: >>>> On 2015/11/19 11:18, Yuanhan Liu wrote: >&

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/19 12:33, Yuanhan Liu wrote: > On Thu, Nov 19, 2015 at 12:13:38PM +0900, Tetsuya Mukawa wrote: >> On 2015/11/19 11:18, Yuanhan Liu wrote: >>> On Thu, Nov 19, 2015 at 11:03:50AM +0900, Tetsuya Mukawa wrote: >>>> On 2015/11/17 22:29, Yuanhan Liu wrote: >&

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/19 11:18, Yuanhan Liu wrote: > On Thu, Nov 19, 2015 at 11:03:50AM +0900, Tetsuya Mukawa wrote: >> On 2015/11/17 22:29, Yuanhan Liu wrote: >>> On Fri, Nov 13, 2015 at 02:20:30PM +0900, Tetsuya Mukawa wrote: >>>> These variables are needed to be able t

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/17 22:29, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 02:20:30PM +0900, Tetsuya Mukawa wrote: >> These variables are needed to be able to manage one of virtio devices >> using both vhost library APIs and vhost PMD. >> For example, if vhost PMD uses current callbac

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-19 Thread Tetsuya Mukawa
On 2015/11/17 22:26, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 03:50:16PM +0900, Tetsuya Mukawa wrote: >> On 2015/11/13 14:32, Yuanhan Liu wrote: >>> On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: >>>> The patch introduces a new PMD. This PMD

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/13 14:32, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. >> >> * Known issue. >> We may see issues while handling RESET_

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/13 14:32, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. >> >> * Known issue. >> We may see issues while handling RESET_

[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
To connect above testpmd, here is qemu command example. $ qemu-system-x86_64 \ -chardev socket,id=chr0,path=/tmp/sock0 \ -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ -device virtio-net-pci,netdev=net0 Signed-off-by: Tetsuya Mukawa --- config

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-13 Thread Tetsuya Mukawa
. To avoid it, callback and private data for vhost PMD are needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_vhost_version.map| 6 +++ lib/librte_vhost/rte_virtio_net.h | 3 ++ lib/librte_vhost/vhost_user/virtio-net-user.c | 13 +++--- lib/librte_vhost/virtio

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
t use vhost PMD, can fully use vhost library APIs. - Add code to support vhost multiple queues. Actually, multiple queues functionality is not enabled so far. RFC PATCH v2 changes: - Fix issues reported by checkpatch.pl (Thanks to Stephen Hemminger) Tetsuya Mukawa (2): vhost: Add callb

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/13 13:03, Rich Lane wrote: >> + if (rte_kvargs_count(kvlist, ETH_VHOST_IFACE_ARG) == 1) { >> + ret = rte_kvargs_process(kvlist, ETH_VHOST_IFACE_ARG, >> +_iface, _name); >> + if (ret < 0) >> +

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/12 21:52, Wang, Zhihong wrote: > Hi Tetsuya, > > In my test I created 2 vdev using "--vdev > 'eth_vhost0,iface=/tmp/sock0,queues=1' --vdev > 'eth_vhost1,iface=/tmp/sock1,queues=1'", and the qemu message got handled in > wrong order. > The reason is that: 2 threads are created to

[dpdk-dev] [PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-11-10 Thread Tetsuya Mukawa
On 2015/11/10 19:05, Panu Matilainen wrote: > On 11/10/2015 11:48 AM, Tetsuya Mukawa wrote: >> On 2015/11/10 16:16, Panu Matilainen wrote: >>> On 11/10/2015 05:13 AM, Tetsuya Mukawa wrote: >>>> On 2015/11/10 3:16, Aaron Conole wrote: >>>>>

[dpdk-dev] [PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-11-10 Thread Tetsuya Mukawa
On 2015/11/10 16:16, Panu Matilainen wrote: > On 11/10/2015 05:13 AM, Tetsuya Mukawa wrote: >> On 2015/11/10 3:16, Aaron Conole wrote: >>> Greetings, >>> >>> Tetsuya Mukawa writes: >>>> These variables are needed to be able to manage one of v

[dpdk-dev] [PATCH] vhost: make destroy callback on VHOST_USER_RESET_OWNER

2015-11-10 Thread Tetsuya Mukawa
On 2015/11/10 11:25, Yuanhan Liu wrote: > On Mon, Nov 09, 2015 at 06:15:13PM -0800, Rich Lane wrote: >> QEMU sends this message first when shutting down. There was previously no way >> for the dataplane to know that the virtio_net instance had become unusable >> and >> it would segfault when

[dpdk-dev] [PATCH 3/3] vhost: Add VHOST PMD

2015-11-10 Thread Tetsuya Mukawa
On 2015/11/10 7:25, Stephen Hemminger wrote: > On Tue, 27 Oct 2015 15:12:55 +0900 > Tetsuya Mukawa wrote: > >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >> The vho

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-10 Thread Tetsuya Mukawa
On 2015/11/10 7:22, Stephen Hemminger wrote: > On Mon, 9 Nov 2015 14:17:01 +0900 > Tetsuya Mukawa wrote: > >> +rte_atomic32_set(>while_queuing, 1); >> + >> +if (unlikely(rte_atomic32_read(>allow_queuing) == 0)) >> +goto out; >

[dpdk-dev] [PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-11-10 Thread Tetsuya Mukawa
On 2015/11/10 3:16, Aaron Conole wrote: > Greetings, > > Tetsuya Mukawa writes: >> These variables are needed to be able to manage one of virtio devices >> using both vhost library APIs and vhost PMD. >> For example, if vhost PMD uses current callback handler and privat

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-09 Thread Tetsuya Mukawa
Hi Liu, Thank you so much for your reviewing. I will fix them, then submit again in this week. Thanks, Tetsuya On 2015/11/09 15:21, Yuanhan Liu wrote: > Hi Tetsuya, > > Here I just got some minor nits after a very rough glimpse. > > On Mon, Nov 09, 2015 at 02:17:01PM +0900,

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-09 Thread Tetsuya Mukawa
To connect above testpmd, here is qemu command example. $ qemu-system-x86_64 \ -chardev socket,id=chr0,path=/tmp/sock0 \ -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ -device virtio-net-pci,netdev=net0 Signed-off-by: Tetsuya Mukawa --- config

[dpdk-dev] [PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-11-09 Thread Tetsuya Mukawa
. To avoid it, callback and private data for vhost PMD are needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_vhost_version.map| 6 +++ lib/librte_vhost/rte_virtio_net.h | 3 ++ lib/librte_vhost/vhost_user/virtio-net-user.c | 13 +++ lib/librte_vhost/virtio

[dpdk-dev] [PATCH v3 0/2] Add VHOST PMD

2015-11-09 Thread Tetsuya Mukawa
o changed. Anyway, if users doesn't use vhost PMD, can fully use vhost library APIs. - Add code to support vhost multiple queues. Actually, multiple queues functionality is not enabled so far. RFC PATCH v2 changes: - Fix issues reported by checkpatch.pl (Thanks to Stephen Hemminger)

[dpdk-dev] [PATCH v2 2/2] vhost: Add VHOST PMD

2015-11-06 Thread Tetsuya Mukawa
On 2015/11/06 11:22, Yuanhan Liu wrote: > On Mon, Nov 02, 2015 at 12:58:57PM +0900, Tetsuya Mukawa wrote: > ... >> + >> +static uint16_t >> +eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) >> +{ >> +struct vhost_queu

[dpdk-dev] [RFC PATCH] vhost: remove lockless enqueue to virt ring

2015-11-06 Thread Tetsuya Mukawa
On 2015/11/05 19:21, Xie, Huawei wrote: > If no objections, would remove the internal cmpset enqueue, should get > some improved performance. > > No idea why commit message is lost: > DPDK doesn't support receiving/transmitting packets from/to the same > port/queue. > Vhost pmd wraps vhost device

[dpdk-dev] [PATCH v2 0/2] Add VHOST PMD

2015-11-05 Thread Tetsuya Mukawa
Hi, Could someone please review below patch series? Regards, Tetsuya On 2015/11/02 12:58, Tetsuya Mukawa wrote: > The patch introduces a new PMD. This PMD is implemented as thin wrapper > of librte_vhost. The patch will work on below patch series. > - [PATCH v7 00/28] remove pci dr

[dpdk-dev] [PATCH] doc: Add missing new line before code block

2015-11-05 Thread Tetsuya Mukawa
Hi Thomas, Could you please merge below patch? Thanks, Tetsuya On 2015/10/28 18:33, Mcnamara, John wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Tuesday, October 20, 2015 3:42 AM >> To: dev at

[dpdk-dev] [PATCH v2 2/2] vhost: Add VHOST PMD

2015-11-02 Thread Tetsuya Mukawa
To connect above testpmd, here is qemu command example. $ qemu-system-x86_64 \ -chardev socket,id=chr0,path=/tmp/sock0 \ -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ -device virtio-net-pci,netdev=net0 Signed-off-by: Tetsuya Mukawa --- config

[dpdk-dev] [PATCH v2 1/2] vhost: Add callback and private data for vhost PMD

2015-11-02 Thread Tetsuya Mukawa
. To avoid it, callback and private data for vhost PMD are needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_vhost_version.map| 6 +++ lib/librte_vhost/rte_virtio_net.h | 3 ++ lib/librte_vhost/vhost_user/virtio-net-user.c | 13 +++ lib/librte_vhost/virtio

[dpdk-dev] [PATCH v2 0/2] Add VHOST PMD

2015-11-02 Thread Tetsuya Mukawa
o changed. Anyway, if users doesn't use vhost PMD, can fully use vhost library APIs. - Add code to support vhost multiple queues. Actually, multiple queues functionality is not enabled so far. RFC PATCH v2 changes: - Fix issues reported by checkpatch.pl (Thanks to Stephen Hemminger)

[dpdk-dev] [PATCH 0/3] Add VHOST PMD

2015-11-02 Thread Tetsuya Mukawa
On 2015/10/31 3:30, Thomas Monjalon wrote: > 2015-10-27 16:54, Tetsuya Mukawa: >> Below patch has been submitted as a separate patch. >> >> - [dpdk-dev,1/3] vhost: Fix wrong handling of virtqueue array index >> (http://dpdk.org/dev/patchwork/patch/8038/) > Please

[dpdk-dev] [PATCH 2/3] vhost: Add callback and private data for vhost PMD

2015-11-02 Thread Tetsuya Mukawa
K application that links vhost library >> cannot use some of vhost library APIs. To avoid it, callback and private >> data for vhost PMD are needed. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_vhost/rte_vhost_version.map| 6 +++ >&

[dpdk-dev] [RFC PATCH v3 2/2] vhost: Add VHOST PMD

2015-10-30 Thread Tetsuya Mukawa
On 2015/10/29 23:25, Xie, Huawei wrote: > On 10/22/2015 5:48 PM, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >> The vhost messages will be han

[dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding

2015-10-29 Thread Tetsuya Mukawa
On 2015/10/28 22:43, Kulasek, TomaszX wrote: >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Tuesday, October 27, 2015 17:59 >> To: Kulasek, TomaszX >> Cc: dev at dpdk.org; Tetsuya Mukawa >> Subject: Re:

[dpdk-dev] [PATCH v2] vhost: Fix wrong handling of virtqueue array index

2015-10-28 Thread Tetsuya Mukawa
The patch fixes wrong handling of virtqueue array index when GET_VRING_BASE message comes. --- lib/librte_vhost/vhost_user/virtio-net-user.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-28 Thread Tetsuya Mukawa
On 2015/10/27 22:44, Traynor, Kevin wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa > [snip] > >> Hi, >> >> I have submitted latest patches. >> I will keep vhost library until we will

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
On 2015/10/27 17:39, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 08:24:00AM +, Xie, Huawei wrote: >> On 10/27/2015 3:52 PM, Tetsuya Mukawa wrote: >>> The patch fixes wrong handling of virtqueue array index when >>> GET_VRING_BASE message comes. >>> The vh

[dpdk-dev] [PATCH 0/3] Add VHOST PMD

2015-10-27 Thread Tetsuya Mukawa
Below patch has been submitted as a separate patch. - [dpdk-dev,1/3] vhost: Fix wrong handling of virtqueue array index (http://dpdk.org/dev/patchwork/patch/8038/) Tetsuya On 2015/10/27 15:12, Tetsuya Mukawa wrote: > The patch introduces a new PMD. This PMD is implemented as thin wrap

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
The patch fixes wrong handling of virtqueue array index when GET_VRING_BASE message comes. The vhost backend will receive the message per virtqueue. Also we should call a destroy callback handler when both RXQ and TXQ receives the message. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
Hi Yuanhan, I appreciate your checking. I haven't noticed SET_BACKEND is only supported by vhost-cuse. :-( I will follow your comments, then submit again. Thanks, Tetsuya On 2015/10/27 15:47, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 03:12:53PM +0900, Tetsuya Mukawa wrote: >> The pa

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Tetsuya Mukawa
On 2015/10/26 14:42, Yuanhan Liu wrote: > On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: >> On 2015/10/22 21:35, Yuanhan Liu wrote: > ... >>> @@ -292,13 +300,13 @@ user_get_vring_base(struct vhost_device_ctx ctx, >>> * sent and only sent in vho

[dpdk-dev] [PATCH 3/3] vhost: Add VHOST PMD

2015-10-27 Thread Tetsuya Mukawa
To connect above testpmd, here is qemu command example. $ qemu-system-x86_64 \ -chardev socket,id=chr0,path=/tmp/sock0 \ -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ -device virtio-net-pci,netdev=net0 Signed-off-by: Tetsuya Mukawa --- config

[dpdk-dev] [PATCH 2/3] vhost: Add callback and private data for vhost PMD

2015-10-27 Thread Tetsuya Mukawa
. To avoid it, callback and private data for vhost PMD are needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_vhost_version.map| 6 +++ lib/librte_vhost/rte_virtio_net.h | 3 ++ lib/librte_vhost/vhost_user/virtio-net-user.c | 13 +++ lib/librte_vhost/virtio

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
2. Also a vhost frontend(QEMU) may send such a index. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/vhost_user/virtio-net-user.c | 22 +++--- lib/librte_vhost/virtio-net.c | 5 +++-- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH 0/3] Add VHOST PMD

2015-10-27 Thread Tetsuya Mukawa
(Thanks to Stephen Hemminger) Tetsuya Mukawa (3): vhost: Fix wrong handling of virtqueue array index vhost: Add callback and private data for vhost PMD vhost: Add VHOST PMD config/common_linuxapp| 6 + doc/guides/nics/index.rst | 1 + doc/g

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2015-10-26 Thread Tetsuya Mukawa
On 2015/10/26 15:30, Yuanhan Liu wrote: > On Mon, Oct 26, 2015 at 02:54:07PM +0900, Tetsuya Mukawa wrote: >> On 2015/10/25 2:16, Thomas Monjalon wrote: >>> 2015-08-12 03:34, Xie, Huawei: >>>> On 8/8/2015 1:21 AM, Jan Kiszka wrote: >>>>> On VH

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2015-10-26 Thread Tetsuya Mukawa
On 2015/10/25 2:16, Thomas Monjalon wrote: > 2015-08-12 03:34, Xie, Huawei: >> On 8/8/2015 1:21 AM, Jan Kiszka wrote: >>> On VHOST_*_RESET_OWNER, we reinitialize the device but without telling >>> the application. That will cause crashes when it continues to invoke >>> vhost services on the

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-26 Thread Tetsuya Mukawa
On 2015/10/22 21:35, Yuanhan Liu wrote: > All queue pairs, including the default (the first) queue pair, > are allocated dynamically, when a vring_call message is received > first time for a specific queue pair. > > This is a refactor work for enabling vhost-user multiple queue; > it should not

[dpdk-dev] [RFC PATCH v3 2/2] vhost: Add VHOST PMD

2015-10-23 Thread Tetsuya Mukawa
On 2015/10/22 21:49, Bruce Richardson wrote: > On Thu, Oct 22, 2015 at 06:45:50PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >&g

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
On 2015/10/21 19:22, Bruce Richardson wrote: > On Wed, Oct 21, 2015 at 09:25:12AM +0300, Panu Matilainen wrote: >> On 10/21/2015 07:35 AM, Tetsuya Mukawa wrote: >>> On 2015/10/19 22:27, Richardson, Bruce wrote: >>>>> -Original Message- >>>

[dpdk-dev] [RFC PATCH v3 2/2] vhost: Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
To connect above testpmd, here is qemu command example. $ qemu-system-x86_64 \ -chardev socket,id=chr0,path=/tmp/sock0 \ -netdev vhost-user,id=net0,chardev=chr0,vhostforce \ -device virtio-net-pci,netdev=net0 Signed-off-by: Tetsuya Mukawa --- config/common_linuxapp

[dpdk-dev] [RFC PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-10-22 Thread Tetsuya Mukawa
. To avoid it, callback and private data for vhost PMD are needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_virtio_net.h | 3 ++ lib/librte_vhost/vhost_user/virtio-net-user.c | 8 +++--- lib/librte_vhost/virtio-net.c | 40 +-- lib

[dpdk-dev] [RFC PATCH v3 0/2] Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
ost.h". - rte_eth_vhost_portid2vdev() To support this functionality, vhost library is also changed. Anyway, if users doesn't use vhost PMD, can fully use vhost library APIs. - Add code to support vhost multiple queues. Actually, multiple queues functionality is not enabled so far. Tetsuya Mukawa (2):

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-21 Thread Tetsuya Mukawa
On 2015/10/19 22:27, Richardson, Bruce wrote: >> -Original Message- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Monday, October 19, 2015 2:26 PM >> To: Tetsuya Mukawa ; Richardson, Bruce >> ; Loftus, Ciara >> Cc: dev at dpdk.

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-21 Thread Tetsuya Mukawa
On 2015/10/20 23:13, Loftus, Ciara wrote: > + +static uint16_t +eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) +{ + struct vhost_queue *r = q; + uint16_t i, nb_tx = 0; + + if (unlikely(r->internal == NULL)) + return 0;

[dpdk-dev] [PATCH] doc: Add missing new line before code block

2015-10-20 Thread Tetsuya Mukawa
The patch adds missing new line to "Managing ABI updates" section. Signed-off-by: Tetsuya Mukawa --- doc/guides/contributing/versioning.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing/vers

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-19 Thread Tetsuya Mukawa
On 2015/10/19 18:45, Bruce Richardson wrote: > On Mon, Oct 19, 2015 at 10:32:50AM +0100, Loftus, Ciara wrote: >>> On 2015/10/16 21:52, Bruce Richardson wrote: >>>> On Mon, Aug 31, 2015 at 12:55:26PM +0900, Tetsuya Mukawa wrote: >>>>> The patch introduces a n

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-19 Thread Tetsuya Mukawa
On 2015/10/16 21:52, Bruce Richardson wrote: > On Mon, Aug 31, 2015 at 12:55:26PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >> Th

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-16 Thread Tetsuya Mukawa
mp/sock0 \ >> -netdev vhost-user,id=net0,chardev=chr0,vhostforce \ >> -device virtio-net-pci,netdev=net0 >> >> Signed-off-by: Tetsuya Mukawa >> --- >> config/common_linuxapp | 6 + >> drivers/net/Makefile

[dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create

2015-10-15 Thread Tetsuya Mukawa
On 2015/10/14 21:42, Jastrzebski, MichalX K wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Wednesday, October 14, 2015 3:35 AM >> To: Kulasek, TomaszX; dev at dpdk.org >> Subject: Re: [dpdk-de

[dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create

2015-10-14 Thread Tetsuya Mukawa
gt; drivers/net/null/rte_pmd_null_version.map |7 + > 4 files changed, 49 insertions(+), 2 deletions(-) > create mode 100644 drivers/net/null/rte_eth_null.h Acked-by: Tetsuya Mukawa

[dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration

2015-10-14 Thread Tetsuya Mukawa
- replaced memcpy with rte_memcpy > > Signed-off-by: Tomasz Kulasek > --- > drivers/net/null/rte_eth_null.c | 116 > +++ > 1 file changed, 116 insertions(+) Acked-by: Tetsuya Mukawa

[dpdk-dev] [PATCH v5 3/9] null: extend number of virtual queues

2015-10-14 Thread Tetsuya Mukawa
gt; Signed-off-by: Tomasz Kulasek > --- > drivers/net/null/rte_eth_null.c | 28 +++- > 1 file changed, 19 insertions(+), 9 deletions(-) Acked-by: Tetsuya Mukawa

[dpdk-dev] [PATCH v5 2/9] null: fix segfault when null_pmd added to bonding

2015-10-14 Thread Tetsuya Mukawa
rivers/net/null/rte_eth_null.c |2 ++ > 1 file changed, 2 insertions(+) Acked-by: Tetsuya Mukawa

[dpdk-dev] Hotplug

2015-10-08 Thread Tetsuya Mukawa
On 2015/10/07 22:16, Srikanth Akula wrote: > Thank you for the inputs . > > I was able to solve the problem of device notification from my control > plane. > > I would like to know if we have any way to know if the PCI device is > already attached before we try to attach it ( if the device is

[dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues

2015-09-30 Thread Tetsuya Mukawa
ktlen = (uint32_t)-1; > - dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues; > - dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues; > + dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues); > + dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues); > dev_info->min_rx_bufsize = 0; > dev_info->pci_dev = NULL; > } > -- > Acked-by: Tetsuya Mukawa

[dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding

2015-09-30 Thread Tetsuya Mukawa
On 2015/09/30 0:10, Kulasek, TomaszX wrote: > Hi Tetsuya, > > Changes from patch below, solves the problem. I've removed malloc. > > Tomasz. > > --- > From e03e77a7dc0e47ac9d750545a834624f88f61966 Mon Sep 17 00:00:00 2001 > From: Tomasz Kulasek > Date: Tue, 29 Sep 2015 16:48:31 +0200 > Subject:

[dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues

2015-09-29 Thread Tetsuya Mukawa
On 2015/09/29 18:46, Kulasek, TomaszX wrote: >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Tuesday, September 29, 2015 04:25 >> To: Kulasek, TomaszX; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCHv4 3/9] null: exte

[dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding

2015-09-29 Thread Tetsuya Mukawa
On 2015/09/29 18:39, Kulasek, TomaszX wrote: > Hi Tetsuya, > >> Thanks for extending null pmd features. >> Is it possible to use rte_null_pmd here? >> Could you please check ring pmd? It may also uses rte_ring_pmd for link >> status callback. >> >> Tetsuya > My first attempt was to use ring pmd,

[dpdk-dev] [PATCH v3] Change rte_eal_vdev_init to update port_id

2015-09-29 Thread Tetsuya Mukawa
if (rte_eal_parse_devargs_str(vdevargs, , )) > goto end; > > - /* save current port status */ > - if (rte_eth_dev_save(devs, sizeof(devs))) > - goto end; > /* walk around dev_driver_list to find the driver of the device, > - * then

[dpdk-dev] [PATCHv4 5/9] null: export eth_dev_null_create

2015-09-29 Thread Tetsuya Mukawa
On 2015/07/16 2:26, Tomasz Kulasek wrote: > To use eth_dev_null_create in application this method needs to be exported. > > Signed-off-by: Tomasz Kulasek > --- > drivers/net/null/Makefile |2 +- > drivers/net/null/rte_eth_null.c |3 ++- >

[dpdk-dev] [PATCHv4 4/9] null: virtual dynamic rss configuration

2015-09-29 Thread Tetsuya Mukawa
On 2015/07/16 2:26, Tomasz Kulasek wrote: > This implementation allows to set and read RSS configuration for null > device, and is used to validate right values propagation over the slaves, > in test units for dynamic RSS configuration for bonding. > > Signed-off-by: Tomasz Kulasek > --- >

[dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues

2015-09-29 Thread Tetsuya Mukawa
On 2015/07/16 2:26, Tomasz Kulasek wrote: > This patch adds a possibility to configure more than one queue on null > device. > > Signed-off-by: Tomasz Kulasek > --- > drivers/net/null/rte_eth_null.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

[dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding

2015-09-29 Thread Tetsuya Mukawa
On 2015/07/16 2:26, Tomasz Kulasek wrote: > When device is added to the bonding, the link status callback is added to > the slave's eth_dev->link_intr_cbs list. This list is not initialized for > null pmd and adding it to the bonding segfaults application. > > This patch allocates and sets up

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-26 Thread Tetsuya Mukawa
Hi Ravi, I am out of office now, and will be back 29th. After backing, I will check it and send reply. Tetsuya On 2015/09/24 6:22, Ravi Kerur wrote: > Hi David, Tetsuya, > > I have sent V3 (changes isolated to rte_ether component) for formal review. > Please look into it and let me know your

[dpdk-dev] [RFC PATCH] vhost: Add VHOST PMD

2015-09-16 Thread Tetsuya Mukawa
On 2015/09/16 1:27, Loftus, Ciara wrote: >> + >> +static int >> +rte_pmd_vhost_devinit(const char *name, const char *params) >> +{ >> +struct rte_kvargs *kvlist = NULL; >> +int ret = 0; >> +int index; >> +char *iface_name; >> + >> +RTE_LOG(INFO, PMD, "Initializing pmd_vhost for

[dpdk-dev] virtio optimization idea

2015-09-08 Thread Tetsuya Mukawa
On 2015/09/05 1:50, Xie, Huawei wrote: > There is some format issue with the ascii chart of the tx ring. Update > that chart. > Sorry for the trouble. Hi XIe, Thanks for sharing a way to optimize virtio. I have a few questions. > > On 9/4/2015 4:25 PM, Xie, Huawei wrote: >> Hi: >> >> Recently I

[dpdk-dev] vhost compliant virtio based networking interface in container

2015-09-08 Thread Tetsuya Mukawa
On 2015/09/07 14:54, Xie, Huawei wrote: > On 8/26/2015 5:23 PM, Tetsuya Mukawa wrote: >> On 2015/08/25 18:56, Xie, Huawei wrote: >>> On 8/25/2015 10:59 AM, Tetsuya Mukawa wrote: >>>> Hi Xie and Yanping, >>>> >>>> >>>> May I ask

[dpdk-dev] [PATCH v4 02/12] vhost: support multiple queues in virtio dev

2015-09-03 Thread Tetsuya Mukawa
On 2015/08/12 17:02, Ouyang Changchun wrote: > diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.h > b/lib/librte_vhost/vhost_user/virtio-net-user.h > index df24860..2429836 100644 > --- a/lib/librte_vhost/vhost_user/virtio-net-user.h > +++ b/lib/librte_vhost/vhost_user/virtio-net-user.h >

[dpdk-dev] [RFC PATCH] vhost: Add VHOST PMD

2015-08-31 Thread Tetsuya Mukawa
On 2015/08/31 14:14, Ouyang, Changchun wrote: > > +struct pmd_internal { > + TAILQ_ENTRY(pmd_internal) next; > + char *dev_name; > + char *iface_name; > + unsigned nb_rx_queues; > + unsigned nb_tx_queues; > + rte_atomic16_t xfer; > + > + struct vhost_queue >

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-08-31 Thread Tetsuya Mukawa
/sock0' -- -i To connect above testpmd, here is qemu command example. $ qemu-system-x86_64 \ -chardev socket,id=chr0,path=/tmp/sock0 \ -netdev vhost-user,id=net0,chardev=chr0,vhostforce \ -device virtio-net-pci,netdev=net0 Signed-off-by: Tetsuya Mukawa --- config

[dpdk-dev] [RFC PATCH] Add VHOST PMD

2015-08-28 Thread Tetsuya Mukawa
: Fix RESET_OWNER handling not to free virtqueue Tetsuya Mukawa (1): vhost: Add VHOST PMD config/common_linuxapp | 6 + drivers/net/Makefile| 4 + drivers/net/vhost/Makefile | 61 +++ drivers/net/vhost/rte_eth_vhost.c

[dpdk-dev] vhost compliant virtio based networking interface in container

2015-08-26 Thread Tetsuya Mukawa
On 2015/08/25 18:56, Xie, Huawei wrote: > On 8/25/2015 10:59 AM, Tetsuya Mukawa wrote: >> Hi Xie and Yanping, >> >> >> May I ask you some questions? >> It seems we are also developing an almost same one. > Good to know that we are tackling the same problem

[dpdk-dev] Why the offloads of the guest's virtio-net network adapter are disabled when vhost-user is used?

2015-08-25 Thread Tetsuya Mukawa
On 2015/08/24 22:09, leo zhu wrote: > Hi all, > > I am running the vhost sample application on my server. > > According to the dpdk-sample-applications-user-guide.pdf, I run the Virtual > Machine with vhost-user enabled. > Following is the command that is used to run the virtual machine. > > > > >

[dpdk-dev] vhost compliant virtio based networking interface in container

2015-08-25 Thread Tetsuya Mukawa
Hi Xie and Yanping, May I ask you some questions? It seems we are also developing an almost same one. On 2015/08/20 19:14, Xie, Huawei wrote: > Added dev at dpdk.org > > On 8/20/2015 6:04 PM, Xie, Huawei wrote: >> Yanping: >> I read your mail, seems what we did are quite similar. Here i wrote a

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-21 Thread Tetsuya Mukawa
On 2015/08/21 4:16, Ravi Kerur wrote: > > > /** > > * Uninitalize a driver specified by name. > > @@ -125,6 +127,38 @@ int rte_eal_vdev_init(const char *name, > const char *args); > > */ > > int rte_eal_vdev_uninit(const char *name); > > > > +/** > > + *

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-20 Thread Tetsuya Mukawa
On 2015/08/20 4:42, Ravi Kerur wrote: > v2: >> Remove rte_pmd_mpipe_devinit changes >> Use rte_eal_compare_pci_addr for address comparison >> Use dpdk_2.2 in version map file for new functions > > v1: > Changes include >> Modify rte_eal_vdev_init to return allocated port_id >>

[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

2015-08-20 Thread Tetsuya Mukawa
_dev) { > RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname); > rte_free(priv); > + return -ENOMEM; > } > > RTE_LOG(INFO, PMD, "%s: Initialized mpipe device" Acked-by: Tetsuya Mukawa

[dpdk-dev] [PATCH 3/3] vhost: Fix RESET_OWNER handling not to free virtqueue

2015-08-19 Thread Tetsuya Mukawa
SET_MEM_TABLE message is issued, and vhost library has already had such a functionality. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/virtio-net.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c index 7794e8b..9475d00 100644

<    1   2   3   4   5   6   7   8   9   10   >