return;
> +
> printf("Closing ports...\n");
>
> FOREACH_PORT(pi, ports) {
> - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != pi)
> + if (pid != pi && pid != (portid_t)RTE_PORT_ALL)
> continue;
>
> port = [pi];
Acked-by: Tetsuya Mukawa
On 2015/03/06 19:32, Iremonger, Bernard wrote:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
>> Sent: Wednesday, March 4, 2015 3:12 AM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH 1/3] BSD:
/* file->index refers to the queue index. The txq is 1, rxq is 0. */
> vq = dev->virtqueue[file->index];
>
> - if ((int)vq->kickfd >= 0)
> - close((int)vq->kickfd);
> + if ((int)vq->callfd >= 0)
> + close((int)vq->callfd);
>
> - vq->kickfd = file->fd;
> + vq->callfd = file->fd;
>
> return 0;
> }
> @@ -621,10 +621,10 @@ set_vring_kick(struct vhost_device_ctx ctx, struct
> vhost_vring_file *file)
> /* file->index refers to the queue index. The txq is 1, rxq is 0. */
> vq = dev->virtqueue[file->index];
>
> - if ((int)vq->callfd >= 0)
> - close((int)vq->callfd);
> + if ((int)vq->kickfd >= 0)
> + close((int)vq->kickfd);
>
> - vq->callfd = file->fd;
> + vq->kickfd = file->fd;
>
> return 0;
> }
Acked-by: Tetsuya Mukawa
f (dev->virtqueue[VIRTIO_TXQ]->kickfd)
> + if ((int)dev->virtqueue[VIRTIO_TXQ]->kickfd >= 0)
> close((int)dev->virtqueue[VIRTIO_TXQ]->kickfd);
> }
>
Acked-by: Tetsuya Mukawa
On 2015/03/06 22:53, De Lara Guarch, Pablo wrote:
> Hi Michael,
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael
>> Sent: Thursday, March 05, 2015 1:33 PM
>> To: Tetsuya Mukawa; dev at dpdk.org
>> Subject:
The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD.
To remove expanding macros when parsing the config files won't
add any issue.
Signed-off-by: Tetsuya Mukawa
---
mk/rte.sdkconfig.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.sdkconfig.mk b/mk
When "port stop all" is executed, the command doesn't work as it should
because of wrong port validation. The patch fixes this issue.
Reported-by: Pablo de Lara
Signed-off-by: Tetsuya Mukawa
---
app/test-pmd/testpmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 2015/03/04 19:15, Bruce Richardson wrote:
> On Wed, Mar 04, 2015 at 10:33:14AM +0100, Olivier MATZ wrote:
>> Hi Tetsuya, Hi Bruce,
>>
>> On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote:
>>> On 2015/03/02 19:22, Bruce Richardson wrote:
>>>> On Mon, Mar 02
On 2015/03/04 0:54, De Lara Guarch, Pablo wrote:
> Hi Tetsuya,
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
>> Sent: Wednesday, February 25, 2015 7:32 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [
2015-02-26 19:57 GMT+09:00 Thomas Monjalon :
> 2015-02-26 18:06, Tetsuya Mukawa:
>> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon :
>> > 2015-02-25 16:49, Stephen Hemminger:
>> >> Build fails if HOTPLUG is disabled
>>
>> Hi Stephen,
>>
>>
On 2015/03/02 19:22, Bruce Richardson wrote:
> On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote:
>> Hi,
>>
>> I got a error while building master branch on FreeBSD.
>> Here is a log.
>>
>> $ gmake T=x86_64-native-bsdapp-clang config
>> cc
This patch removes below limitation from hotplug section of
programmer's guide.
- The framework can only be enabled with Linux. BSD is not supported.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/port_hotplug_framework.rst | 2 --
1 file changed, 2 deletions(-)
diff --git a/doc
The patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option from DPDK.
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 --
config/common_linuxapp | 5 -
lib/librte_eal/common/eal_common_dev.c | 2 --
lib/librte_eal/common
This patch adds Hotplug support to BSD.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 169 +-
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 6 +
lib/librte_eal/common/include/rte_pci.h | 1 +
lib/librte_ether/rte_ethdev.c
If testpmd is invoked with portmask option like below, segmentation
fault will be occured. This patch fixes the issue.
Reported-by: De Lara Guarch, Pablo
Signed-off-by: Tetsuya Mukawa
---
app/test-pmd/testpmd.c | 37 +++--
1 file changed, 23 insertions(+), 14
On 2015/02/27 3:49, De Lara Guarch, Pablo wrote:
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
>> Sent: Wednesday, February 25, 2015 7:32 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH v15]
This patch fixes following errors with icc.
error #188: enumerated type mixed with another type
return -1;
Reported-by: Mcnamara, John
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib
This patch fixes following errors with icc.
rte_eth_null.c(47): error #83:
type qualifier specified more than once
Reported-by: Mcnamara, John
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib
This patch fixes following errors with gcc-4.7.
lib/librte_pmd_null/rte_eth_null.c:302:28:
error: array subscript is above array bounds
Reported-by: Mcnamara, John
Reported-by: Stephen Hemminger
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_null/rte_eth_null.c | 12 +++-
1
On 2015/02/27 0:36, Mcnamara, John wrote:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John
>> Sent: Thursday, February 26, 2015 12:21 PM
>> To: Tetsuya Mukawa; Thomas Monjalon
>> Cc: dev at dpdk.org
>> Su
2015-02-26 19:57 GMT+09:00 Thomas Monjalon :
> 2015-02-26 18:06, Tetsuya Mukawa:
>> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon :
>> > 2015-02-25 16:49, Stephen Hemminger:
>> >> Build fails if HOTPLUG is disabled
>>
>> Hi Stephen,
>>
>>
2015-02-26 16:03 GMT+09:00 Thomas Monjalon :
> 2015-02-25 16:49, Stephen Hemminger:
>> Build fails if HOTPLUG is disabled
Hi Stephen,
I appreciate for you reporting.
>
> OK thanks for reporting.
> Actually there is no good reason to disable hotplug on Linux.
> Though it means that it's
.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test-pmd/cmdline.c | 137 +++
app/test-pmd/config.c | 102 --
app/test-pmd/parameters.c | 22
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
This patch adds a new section for describing port hotplug framework.
v15:
- Fix function names like below.
- rte_eal_dev_attach() to rte_eth_dev_attach().
- rte_eal_dev_detach() to rte_eth_dev_detach().
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1
().
rte_eal_dev_invoke() to rte_eal_vdev_invoke().
- Add code to handle a return value of rte_eal_devargs_remove().
- Fix pci address format in rte_eal_dev_detach().
v4:
- Fix comment.
- Add error checking.
- Fix indent of 'if' statement.
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib
The patch adds following functions.
- rte_eal_vdev_init();
- rte_eal_vdev_uninit();
- rte_eal_parse_devargs_str().
These functions are used for driver initialization and finalization.
v15:
- Add this patch to hotplug series.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common
commit log.
- RTE_ETH_DEV_PHYSICAL is replaced by RTE_ETH_DEV_PCI.
(Thanks to Thomas Monjalon)
v8:
- NONE_TRACE is replaced by NO_TRACE.
- Add missing symbol in version map.
(Thanks to Qiu, Michael and Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
parameter checking.
- Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 98 -
lib/librte_eal/common/eal_private.h | 15
lib/librte_eal/common/include/rte_pci.h | 32
lib/librte_eal
ove pci_unmap_device(). It will be implemented in later patch.
v8:
- Fix typo.
(Thanks to Iremonger, Bernard)
v5:
- Fix pci_unmap_device() to check pt_driver.
v4:
- Add parameter checking.
- Add header file to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 248
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 164 insertions(+), 91 deletions(-)
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
l Qiu (2):
eal_pci: Add flag to hold kernel driver type
eal_pci: pci memory map work with driver type
Tetsuya Mukawa (11):
eal: Enable port Hotplug framework in Linux
eal/pci,ethdev: Remove assumption that port will not be detached
eal/pci: Consolidate pci address comparison APIs
ethdev
On 2015/02/25 23:00, Thomas Monjalon wrote:
> 2015-02-25 21:32, Tetsuya Mukawa:
>> 2015-02-25 20:21 GMT+09:00 Thomas Monjalon :
>>> 2015-02-25 13:04, Tetsuya Mukawa:
>>>> --- a/lib/librte_eal/common/eal_common_dev.c
>>>> +++ b/lib/librte_eal/com
2015-02-25 20:21 GMT+09:00 Thomas Monjalon :
> 2015-02-25 13:04, Tetsuya Mukawa:
>> --- a/lib/librte_eal/common/eal_common_dev.c
>> +++ b/lib/librte_eal/common/eal_common_dev.c
>> @@ -32,10 +32,13 @@
>> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE
On 2015/02/25 12:39, Cunming Liang wrote:
> These two patches are the fixing for the compling error when
> CONFIG_RTE_BUILD_SHARED_LIB=y.
> The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in
> the version map.
> Thanks for the notification from
)
- port_id: port identifier
v7:
- Fix doc.
(Thanks to Iremonger, Bernard)
- Fix port checking implementation of star_port();
(Thanks to Qiu, Michael)
v5:
- Add testpmd documentation.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
of rte_eal_devargs_remove().
- Fix pci address format in rte_eal_dev_detach().
v4:
- Fix comment.
- Add error checking.
- Fix indent of 'if' statement.
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 278 ++--
lib/librte_eal
y NO_TRACE.
- Add missing symbol in version map.
(Thanks to Qiu, Michael and Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
app/test/virtual_pmd.c | 2 +-
lib/librte_ether/rte_ethdev.c| 25
ove pci_unmap_device(). It will be implemented in later patch.
v8:
- Fix typo.
(Thanks to Iremonger, Bernard)
v5:
- Fix pci_unmap_device() to check pt_driver.
v4:
- Add parameter checking.
- Add header file to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal
.
rte_eth_dev_get_changed_port().
rte_eth_dev_get_port_by_addr().
v4:
- Add parameter checking.
v3:
- Fix if-condition bug while comparing pci addresses.
- Add error checking codes.
Reported-by: Mark Enright
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 103
Monjalon)
v6:
- Fix rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 6
lib/librte_ether/rte_ethdev.c | 64
of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 11 +++
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 23 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index b702039
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 248
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 164 insertions(+), 91 deletions(-)
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD
configuration. So far, Hotplug functions only support linux.
v9:
- Move this patch at the top of this patch series.
(Thanks to Thomas Monjalon)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 ++
config
Hi,
I've got following error when I enable CONFIG_RTE_BUILD_SHARED_LIB.
dpdk/x86_64-native-linuxapp-gcc/lib/libethdev.so: undefined reference to
`per_lcore__socket_id'
collect2: error: ld returned 1 exit status
make[5]: *** [dump_cfg] Error 1
make[4]: *** [dump_cfg] Error 2
make[4]: *** Waiting
Hi,
I cannot compile l2fwd-jobstats using master branch.
Here is log
$ T=x86_64-native-linuxapp-gcc make examples
== Build examples for x86_64-native-linuxapp-gcc
== bond
== cmdline
== distributor
== exception_path
== helloworld
== ip_pipeline
== ip_reassembly
== ipv4_multicast
2015-02-24 22:25 GMT+09:00 Maxime Leroy :
> Hi Tetsuya,
>
> On Tue, Feb 24, 2015 at 5:49 AM, Tetsuya Mukawa wrote:
>> These functions are used for attaching or detaching a port.
> [...]
>> +static int
>> +rte_eal_vdev_init(const char *name, const char *args)
>
ng the empty argument as "" and add a note in the api.
> Restore associated tests.
>
> Fixes: c07691ae1089 ("devargs: remove limit on parameters length")
> Reported-by: Tetsuya Mukawa
> Signed-off-by: David Marchand
> ---
> app/test/test_devargs.c
On 2015/02/24 0:00, Bruce Richardson wrote:
> On Mon, Feb 23, 2015 at 02:57:24PM +, Bruce Richardson wrote:
>> Instead of distinguishing the BAR mappings via offset within a single
>> file, originally /dev/uioX, switch to mapping each individual bar via
>> the appropriately numbered resourceX
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
in rte_eal_dev_detach().
v4:
- Fix comment.
- Add error checking.
- Fix indent of 'if' statement.
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 284 ++--
lib/librte_eal/common/eal_common_devargs.c | 46 ++--
lib/librte_eal
y NO_TRACE.
- Add missing symbol in version map.
(Thanks to Qiu, Michael and Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
app/test/virtual_pmd.c | 2 +-
lib/librte_ether/rte_ethdev.c| 25
indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 98 -
lib/librte_eal/common/eal_private.h | 15 +
lib/librte_eal/common/include/rte_pci.h | 32 +++
lib/librte_eal/linuxapp/eal/eal_pci.c | 94
ove pci_unmap_device(). It will be implemented in later patch.
v8:
- Fix typo.
(Thanks to Iremonger, Bernard)
v5:
- Fix pci_unmap_device() to check pt_driver.
v4:
- Add parameter checking.
- Add header file to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal
Monjalon)
v6:
- Fix rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 6
lib/librte_ether/rte_ethdev.c | 64
of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 11 +++
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 23 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index b702039
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 248
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 164 insertions(+), 91 deletions(-)
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD
configuration. So far, Hotplug functions only support linux.
v9:
- Move this patch at the top of this patch series.
(Thanks to Thomas Monjalon)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 ++
config
)
- port_id: port identifier
v7:
- Fix doc.
(Thanks to Iremonger, Bernard)
- Fix port checking implementation of star_port();
(Thanks to Qiu, Michael)
v5:
- Add testpmd documentation.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
comment.
- Add error checking.
- Fix indent of 'if' statement.
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 285 ++--
lib/librte_eal/common/eal_common_devargs.c | 46 ++--
lib/librte_eal/common/eal_private.h
y NO_TRACE.
- Add missing symbol in version map.
(Thanks to Qiu, Michael and Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
app/test/virtual_pmd.c | 2 +-
lib/librte_ether/rte_ethdev.c| 25
indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 98 -
lib/librte_eal/common/eal_private.h | 15 +
lib/librte_eal/common/include/rte_pci.h | 32 +++
lib/librte_eal/linuxapp/eal/eal_pci.c | 94
ove pci_unmap_device(). It will be implemented in later patch.
v8:
- Fix typo.
(Thanks to Iremonger, Bernard)
v5:
- Fix pci_unmap_device() to check pt_driver.
v4:
- Add parameter checking.
- Add header file to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal
.
rte_eth_dev_get_changed_port().
rte_eth_dev_get_port_by_addr().
v4:
- Add parameter checking.
v3:
- Fix if-condition bug while comparing pci addresses.
- Add error checking codes.
Reported-by: Mark Enright
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 103
Monjalon)
v6:
- Fix rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 6
lib/librte_ether/rte_ethdev.c | 64
of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 11 +++
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 23 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 0e1e5c9
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
Fix indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 +
lib/librte_ether/rte_ethdev.c | 248
lib/librte_ether/rte_ethdev.h | 5 +
3 files changed, 164 insertions(+), 91 deletions(-)
From: Michael Qiu <michael@intel.com>
With the driver type flag in struct rte_pci_dev, we do not need
to always map uio devices with vfio related function when
vfio enabled.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.
handle differently in runtime. For example, pci memory map,
pot hotplug, and so on.
This patch add a flag field for pci device to solve above issue.
Signed-off-by: Michael Qiu
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 8 +
lib/librte_eal/linuxapp/eal/eal_pci.c
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD
configuration. So far, Hotplug functions only support linux.
v9:
- Move this patch at the top of this patch series.
(Thanks to Thomas Monjalon)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 ++
config
ove 'rte_eth_dev_validate_port()', and cleanup codes.
Michael Qiu (2):
eal_pci: Add flag to hold kernel driver type
eal_pci: pci memory map work with driver type
Tetsuya Mukawa (11):
eal: Enable port Hotplug framework in Linux
eal/pci,ethdev: Remove assumption that port will not be detac
On 2015/02/23 20:39, Iremonger, Bernard wrote:
the pointer diff --git a/lib/librte_ether/rte_ether_version.map
b/lib/librte_ether/rte_ether_version.map
index f66fd2d..099c769 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
On 2015/02/23 20:12, Bruce Richardson wrote:
> On Mon, Feb 23, 2015 at 11:33:45AM +0900, Tetsuya Mukawa wrote:
>> On 2015/02/23 5:46, Bruce Richardson wrote:
>>> On Sun, Feb 22, 2015 at 02:30:02PM +0900, Tetsuya Mukawa wrote:
>>>> Hi,
>>>>
>>>&
On 2015/02/23 20:01, Iremonger, Bernard wrote:
>> -Original Message-
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Monday, February 23, 2015 5:09 AM
>> To: dev at dpdk.org
>> Cc: Qiu, Michael; Iremonger, Bernard; maxime.leroy at 6wind.com;
This patch adds port hotplug support to Null PMD.
v9:
- Use rte_eth_dev_release_port() instead of rte_eth_dev_free().
v7:
- Add parameter checkings.
(Thanks to Iremonger, Bernard)
v6:
- Fix a parameter of rte_eth_dev_free().
v4:
- Fix commit title.
Signed-off-by: Tetsuya Mukawa
---
lib
parameter checkings.
(Thanks to Iremonger, Bernard)
- Remove needless "__rte_unused".
v4:
- Fix memory leak.
(Thanks to Iremonger, Bernard)
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 5 +
config/common_linuxapp |
)
- port_id: port identifier
v7:
- Fix doc.
(Thanks to Iremonger, Bernard)
- Fix port checking implementation of star_port();
(Thanks to Qiu, Michael)
v5:
- Add testpmd documentation.
(Thanks to Iremonger, Bernard)
v4:
- Fix strings of command help.
Signed-off-by: Tetsuya Mukawa
---
app/test
This patch adds finalization code to free resources allocated by the
PMD.
v6:
- Fix a paramter of rte_eth_dev_free().
v4:
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++
1 file changed, 40 insertions
This patch adds a new section for describing port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++
2 files changed, 111 insertions(+)
create mode 100644
comment.
- Add error checking.
- Fix indent of 'if' statement.
- Change function name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 285 ++--
lib/librte_eal/common/eal_common_devargs.c | 46 ++--
lib/librte_eal/common/eal_private.h
Iremonger, Bernard)
v4:
- Fix comments of rte_eth_dev_type.
Signed-off-by: Tetsuya Mukawa
---
app/test/virtual_pmd.c | 2 +-
lib/librte_ether/rte_ethdev.c| 25 +++--
lib/librte_ether/rte_ethdev.h| 25
indent of 'if' statement.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 98 -
lib/librte_eal/common/eal_private.h | 15 +
lib/librte_eal/common/include/rte_pci.h | 32 +++
lib/librte_eal/linuxapp/eal/eal_pci.c | 94
ove pci_unmap_device(). It will be implemented in later patch.
v8:
- Fix typo.
(Thanks to Iremonger, Bernard)
v5:
- Fix pci_unmap_device() to check pt_driver.
v4:
- Add parameter checking.
- Add header file to determine if hotplug can be enabled.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal
.
rte_eth_dev_get_changed_port().
rte_eth_dev_get_port_by_addr().
v4:
- Add parameter checking.
v3:
- Fix if-condition bug while comparing pci addresses.
- Add error checking codes.
Reported-by: Mark Enright
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 103
Monjalon)
v6:
- Fix rte_eth_dev_uninit() to handle a return value of uninit
function of PMD.
v4:
- Add parameter checking.
- Change function names.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 6
lib/librte_ether/rte_ethdev.c | 64
of rte_eth_dev_free().
v4:
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 11 +++
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 23 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 0e1e5c9
er correctly.
v4:
- Fix calculation method of eal_compare_pci_addr().
- Add parameter checking.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 29 --
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h
501 - 600 of 983 matches
Mail list logo
