Hi, I have a question about the "scattered Rx" feature: why enabling it
disabled "bulk allocation" feature?
There is some unclear comment in the ixgbe_recv_scattered_pkts():
/*
* Descriptor done.
*
* Allocate a new mbuf to
On 02/25/15 13:02, Bruce Richardson wrote:
> On Wed, Feb 25, 2015 at 11:40:36AM +0200, Vlad Zolotarov wrote:
>> Hi, I have a question about the "scattered Rx" feature: why enabling it
>> disabled "bulk allocation" feature?
> The "bulk-allocation" fe
On 01/04/15 09:18, Ouyang Changchun wrote:
> Put global register configuring out of loop for queue; also fix typo and
> indent;
> Also fix typo and indent.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
> ---
> lib/librte_pmd_ix
On 01/04/15 09:18, Ouyang Changchun wrote:
> Negotiate API version with VF when receiving the IXGBE_VF_API_NEGOTIATE
> message.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
> ---
> lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 +
> lib/librte_pmd_ixgb
On 01/04/15 10:26, Vlad Zolotarov wrote:
>
> On 01/04/15 09:18, Ouyang Changchun wrote:
>> Negotiate API version with VF when receiving the
>> IXGBE_VF_API_NEGOTIATE message.
>>
>> Signed-off-by: Changchun Ouyang
>
> Reviewed-by: Vlad Zolotarov
One sm
On 01/04/15 09:18, Ouyang Changchun wrote:
> Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES
> message from VF.
>
> Signed-off-by: Changchun Ouyang
> ---
> lib/librte_pmd_ixgbe/ixgbe_pf.c | 35 ++-
> 1 file changed, 34
On 01/04/15 10:37, Ouyang, Changchun wrote:
> Hi Vlad,
>
>> -Original Message-----
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:30 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev
On 01/04/15 09:18, Ouyang Changchun wrote:
> Check mq mode for VMDq RSS, handle it correctly instead of returning an error;
> Also remove the limitation of per pool queue number has max value of 1,
> because
> the per pool queue number could be 2 or 4 if it is VMDq RSS mode;
>
> The number of
On 01/04/15 09:18, Ouyang Changchun wrote:
> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS
> information.
>
> Signed-off-by: Changchun Ouyang
> ---
> app/test-pmd/testpmd.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c
On 01/04/15 10:51, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:40 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 2/6] i
On 01/04/15 10:58, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:45 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 4
On 01/04/15 11:01, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:50 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 6/6]
On 01/05/15 04:59, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:39 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v
On 01/05/15 03:00, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 5:46 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v
On 01/05/15 12:38, Bruce Richardson wrote:
> On Thu, Dec 25, 2014 at 01:46:54AM +, Ouyang, Changchun wrote:
>> Hi,
>>
>>> -Original Message-
>>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>>> Sent: Wednesday, December 24, 2
On 01/06/15 03:11, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Monday, January 5, 2015 9:02 PM
>> To: Richardson, Bruce; Ouyang, Changchun
>> Cc: dev at dpdk.org
>> Subjec
On 01/06/15 03:11, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Monday, January 5, 2015 9:02 PM
>> To: Richardson, Bruce; Ouyang, Changchun
>> Cc: dev at dpdk.org
>> Subjec
On 01/06/15 03:54, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Monday, January 5, 2015 6:07 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v
On 01/06/15 04:01, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Monday, January 5, 2015 6:12 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 6
On 01/06/15 03:56, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Monday, January 5, 2015 6:10 PM
>> To: Ouyang, Changchun;dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 4
On 01/07/15 08:32, Ouyang Changchun wrote:
> Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES
> message from VF.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
>
> changes in v5
>- Add some 'FIX ME' comments fo
On 01/07/15 08:32, Ouyang Changchun wrote:
> It needs config RSS and IXGBE_MRQC and IXGBE_VFPSRTYPE to enable VF RSS.
>
> The psrtype will determine how many queues the received packets will
> distribute to,
> and the value of psrtype should depends on both facet: max VF rxq number which
> has
On 01/07/15 08:32, Ouyang Changchun wrote:
> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS
> information.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
Some nitpicking below... ;)
>
> changes in v5
>- Assign txmode.mq_mod
On 01/07/15 08:32, Ouyang Changchun wrote:
> This patch enables VF RSS for Niantic, which allow each VF having at most 4
> queues.
> The actual queue number per VF depends on the total number of pool, which is
> determined by the max number of VF at PF initialization stage and the number
> of
>
On 01/08/15 11:19, Vlad Zolotarov wrote:
>
> On 01/07/15 08:32, Ouyang Changchun wrote:
>> Check mq mode for VMDq RSS, handle it correctly instead of returning
>> an error;
>> Also remove the limitation of per pool queue number has max value of
>> 1, because
>
On 01/09/15 07:54, Ouyang, Changchun wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Friday, January 9, 2015 2:49 AM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v
Hi,
guys could you share form your experience what is the best way to
distribute the DPDK libraries with the DPDK-based app:
* Is there any significant benefit in compiling the libraries on a
target machine?
* Is there an already existing DPDK-libs packaging: I've noticed there
is
On 01/12/15 05:41, Ouyang, Changchun wrote:
>
> *From:*Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> *Sent:* Friday, January 09, 2015 9:50 PM
> *To:* Ouyang, Changchun; dev at dpdk.org
> *Subject:* Re: [dpdk-dev] [PATCH v5 4/6] ether: Check VMDq RSS mode
>
> On 0
ber which
> has been negotiated with PF, and the number of rxq specified in config on
> guest.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
>
> Changes in v6:
>- Raise an error for the case of ETH_16_POOLS in config vf rss, as the
On 01/12/15 07:59, Ouyang Changchun wrote:
> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS
> information.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
>
> changes in v6
>- Put common statement outside the if bran
t;
> The number of rxq specified in config will determine the mq mode for VMDq RSS.
>
> Signed-off-by: Changchun Ouyang
Reviewed-by: Vlad Zolotarov
>
> changes in v6:
>- More clear error message when queue number is invalid.
>
> changes in v5:
>- Fix '<
On 01/12/15 16:50, Neil Horman wrote:
> On Mon, Jan 12, 2015 at 11:30:26AM +, Bruce Richardson wrote:
>> On Sun, Jan 11, 2015 at 07:10:30PM +0200, Vlad Zolotarov wrote:
>>> Hi,
>>> guys could you share form your experience what is the best way to distri
On 01/13/15 03:50, Ouyang, Changchun wrote:
>
> *From:*Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> *Sent:* Monday, January 12, 2015 9:59 PM
> *To:* Ouyang, Changchun; dev at dpdk.org
> *Subject:* Re: [dpdk-dev] [PATCH v5 4/6] ether: Check VMDq RSS mode
>
> On 0
On 01/12/15 17:46, Jastrzebski, MichalX K wrote:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
>> Sent: Monday, January 12, 2015 3:43 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH 1/2] pmd: add DCB for VF for ixgbe
>>
>>
On 01/12/15 16:43, Michal Jastrzebski wrote:
> Date: Mon, 12 Jan 2015 15:39:40 +0100
> Message-Id: <1421073581-6644-2-git-send-email-michalx.k.jastrzebski at
> intel.com>
> X-Mailer: git-send-email 2.1.1
> In-Reply-To: <1421073581-6644-1-git-send-email-michalx.k.jastrzebski at
> intel.com>
>
On 01/12/15 17:50, Michal Jastrzebski wrote:
> From: Pawel Wodkowski
>
> Hi,
> this patchset enables DCB in SRIOV (ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB)
> for each VF and PF for ixgbe driver.
>
> As a side effect this allow to use multiple queues for TX in VF (8 if there is
> 16 or less VFs
On 01/12/15 17:50, Michal Jastrzebski wrote:
> From: Pawel Wodkowski
>
> This patch add support for DCB in SRIOV mode. When no PFC
> is enabled this feature might be used as multiple queues
> (up to 8 or 4) for VF.
>
> It incorporate following modifications:
> - Allow zero rx/tx queues to be
On 01/12/15 17:50, Michal Jastrzebski wrote:
> From: Pawel Wodkowski
>
> This patch incorporate fixes to support DCB in SRIOV mode for testpmd.
> It also clean up some old code that is not needed or wrong.
The same here: could u, pls., separate the "cleanup" part of the patch
from the "fixes"
On 01/18/15 23:58, Thomas Monjalon wrote:
> 2015-01-08 11:56, Vlad Zolotarov:
>> I've acked PATCH1 and PATCH2 already before and since there are no
>> changes in them, pls., consider them ACKed... ;)
> Thank you for the great review.
>
> Note to everybody reading tha
On 12/23/14 19:08, Thomas Monjalon wrote:
> Hello all,
>
> We now have 2 new maintainers managing their own sub-tree for some
> specific areas of DPDK:
> - Stephen Hemminger will maintain the driver bnx2x
Cool!
> - Helin Zhang will maintain the driver i40e
>
> These repositories can
TARTED(1) / STOPPED(0).
> */
> + lro : 1; /**< RX LRO is ON(1) / OFF(0) */
Acked-by: Vlad Zolotarov
> };
>
> /**
Hi, Konstantin, Helin,
there is a documented limitation of xl710 controllers (i40e driver)
which is not handled in any way by a DPDK driver.
From the datasheet chapter 8.4.1:
"? A single transmit packet may span up to 8 buffers (up to 8 data descriptors
per packet including
both the header and
On 07/30/15 19:10, Zhang, Helin wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Thursday, July 30, 2015 7:58 AM
>> To: dev at dpdk.org; Ananyev, Konstantin; Zhang, Helin
>> Subject: RFC: i40e
On 07/30/15 19:20, Avi Kivity wrote:
>
>
> On 07/30/2015 07:17 PM, Stephen Hemminger wrote:
>> On Thu, 30 Jul 2015 17:57:33 +0300
>> Vlad Zolotarov wrote:
>>
>>> Hi, Konstantin, Helin,
>>> there is a documented limitation of xl710 controllers (i40
On 07/30/15 20:01, Stephen Hemminger wrote:
> On Thu, 30 Jul 2015 19:50:27 +0300
> Vlad Zolotarov wrote:
>
>>
>> On 07/30/15 19:20, Avi Kivity wrote:
>>>
>>> On 07/30/2015 07:17 PM, Stephen Hemminger wrote:
>>>> On Thu, 30 Jul 2015 17:57
On 07/30/15 20:33, Zhang, Helin wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Thursday, July 30, 2015 9:44 AM
>> To: Zhang, Helin; Ananyev, Konstantin
>> Cc: dev at dpdk.org
>> Su
s
doesn't mean
to fix/add new functionality to it. VF PMD should be patched in the similar way
I've
patched PF PMD in my previous series in order to fix the same issues that were
fixed in
the PF PMD and in order to enable LRO and scattered Rx with bulk allocations.
Vlad Zolotarov (4):
i
Move the above fields from ixgbe_hw to ixgbe_adapter.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 --
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 +++
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 3 +++
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 38
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ---
lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index 60344a9..a45f51e 100644
--- a/lib/librte_pmd_ixgbe
Kill ixgbe_recv_scattered_pkts() - use ixgbe_recv_pkts_lro_single_alloc()
instead.
Work against HW queues in LRO and scattered Rx cases is exactly the same.
Therefore we may drop the inferior callback.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 +-
lib
Simply initialze rx_pkt_burst callback to ixgbe_recv_pkts_lro_bulk_alloc() if
the conditions are right.
This is possible because work against HW in LRO and scattered cases is exactly
the same
and LRO callback already supports the bulk allocation.
Signed-off-by: Vlad Zolotarov
---
lib
On 04/28/15 20:42, Ananyev, Konstantin wrote:
> Hi Vlad,
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov
>> Sent: Sunday, April 26, 2015 3:46 PM
>> To: dev at dpdk.org
>> Subject: [
On 04/29/15 09:47, Vlad Zolotarov wrote:
>
>
> On 04/28/15 20:42, Ananyev, Konstantin wrote:
>> Hi Vlad,
>>
>>> -Original Message-
>>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov
>>> Sent: Sunday, April 26,
C-specific structures to "Scattered Rx" derivatives.
- Always allocate Scattered Rx ring.
Vlad Zolotarov (5):
ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter
ixgbe: ixgbe_rx_queue: remove unused rsc_en field
ixgbe: Rename yy_rsc_xx -> yy_sc/scatte
Move the above fields from ixgbe_hw to ixgbe_adapter.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 --
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 +++
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 3 +++
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 38
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ---
lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index 60344a9..a45f51e 100644
--- a/lib/librte_pmd_ixgbe
- ixgbe_rsc_entry -> ixgbe_scattered_rx_entry
- sw_rsc_ring -> sw_sc_ring
- ixgbe_free_rsc_cluster() -> ixgbe_free_sc_cluster()
- In local variables: xx_rsc_yy -> xx_sc_yy
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe
() to
always allocate sw_rsc_ring instead of explicitly allocating it in all possible
cases
when it may be needed: LRO and/or scattered Rx.
This will only impose sizeof(void*) * IXGBE_MAX_RING_DESC = 32KB overhead
per Rx queue as a price for a much simpler code, which seems reasonable.
Signed-off-by: Vlad
Simply initialze rx_pkt_burst callback to ixgbe_recv_pkts_lro_bulk_alloc() if
the conditions are right.
This is possible because work against HW in LRO and scattered cases is exactly
the same
and LRO callback already supports the bulk allocation.
Signed-off-by: Vlad Zolotarov
---
lib
According to 82599 and x540 HW specifications RS bit *must* be
set in the last descriptor of *every* packet.
This patch fixes the Tx hang we were constantly hitting with a
seastar-based application on x540 NIC.
Signed-off-by: Vlad Zolotarov
---
drivers/net/ixgbe/ixgbe_ethdev.c | 9
rent from zero.
>
> Regards,
> Helin
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Thursday, August 13, 2015 11:07 AM
>> To: dev at dpdk.org
>> Cc: Zhang, Helin; Ananyev, Konstantin; avi at cloudius-syst
According to 82599 and x540 HW specifications RS bit *must* be
set in the last descriptor of *every* packet.
This patch fixes the Tx hang we were constantly hitting with a
seastar-based application on x540 NIC.
Signed-off-by: Vlad Zolotarov
---
New in v2:
- ixgbevf: ixgbevf_dev_info_get
XD (I still doubt we really
> do) - ,
Well, if u doubt u may ask the guys from the Intel networking division
that wrote the 82599 and x540 HW specs where they clearly state that. ;)
> I think inside PMD it still should be possible to check TX completion in
> chunks.
> Konstan
On 08/20/15 11:56, Vlad Zolotarov wrote:
>
>
> On 08/20/15 11:41, Ananyev, Konstantin wrote:
>> Hi Vlad,
>>
>>> -Original Message-
>>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>>> Sent: Wednesday, August 19, 2015 11:03 AM
above, that will set the RS
bit in every EOP descriptor.
ixgbe_set_tx_function() will set the appropriate Tx callback according
to the device family.
This patch fixes the Tx hang we were constantly hitting with a
seastar-based application on x540 NIC.
Signed-off-by: Vlad Zolotarov
---
New in v4
On 08/20/15 18:37, Vlad Zolotarov wrote:
> According to 82599 and x540 HW specifications RS bit *must* be
> set in the last descriptor of *every* packet.
>
> Before this patch there were 3 types of Tx callbacks that were setting
> RS bit every tx_rs_thresh descriptors. This p
On 03/05/15 07:56, Zhang, Helin wrote:
> Hi Gleb
>
> Sorry for late! I am struggling on my tasks for the following DPDK release
> these days.
>
>> -Original Message-
>> From: Gleb Natapov [mailto:gleb at cloudius-systems.com]
>> Sent: Monday, March 2, 2015 8:56 PM
>> To: dev at dpdk.org
On 08/24/15 20:51, Zhang, Helin wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Monday, August 24, 2015 4:14 AM
>> To: Zhang, Helin; Gleb Natapov; dev at dpdk.org
>> Subject: Re: [dpdk-dev] i40e and
On 08/25/15 22:30, Vladislav Zolotarov wrote:
>
>
> On Aug 25, 2015 22:16, "Zhang, Helin" <mailto:helin.zhang at intel.com>> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Vlad Zolotarov [mailto:vladz at cloudius-s
On 08/30/15 16:03, Vlad Zolotarov wrote:
> Hi, I have the most strange issue on a setup of 2 pairs of connected
> back to back XL710 cards.
> It seems that frames above 1510 bytes are being filtered out by an
> i40e PMD receiver.
> The same setup works perfectly when I us
HW requires it regardless the presence of the VLAN tag in the received frame.
Otherwise Rx frames are being filtered out on the MTU-4 boundary.
Signed-off-by: Vlad Zolotarov
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e
1.41%
- With LRO:total throughput: 8.21Gbps, coefficient of variance: 0.59%
Vlad Zolotarov (5):
ixgbe: Cleanups
ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices
ixgbe: Code refactoring
common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option
ixgbe: Add
(): shorten the lines by defining a local alias variable
to access
>data->dev_conf.rxmode.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 52 +--
1 file changed, 28 insertions(+), 24 deletions(-)
diff --git
According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should
be configured to the same value as HLREG0.RXCRCSTRP.
Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec
but seems harmless.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3
of the cluster's HEAD buffer into
the inline function.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 116 +++---
1 file changed, 70 insertions(+), 46 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
b/lib
Enables LRO support in PMDs.
Signed-off-by: Vlad Zolotarov
---
config/common_linuxapp | 1 +
1 file changed, 1 insertion(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 97f1c9e..5b98595 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -137,6 +137,7
and to igb_rx_queue.
- Use the appropriate handler when LRO is requested.
Signed-off-by: Vlad Zolotarov
---
lib/librte_ether/rte_ethdev.h | 7 +-
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 17 ++
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 5 +
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 563
On 03/04/15 02:33, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> +lro_bulk_alloc: 1, /**< RX LRO with bulk alloc is ON(1) /
>> OFF(0) */
> This is an internal decision and should not be exposed in the API.
&g
On 03/04/15 02:33, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> +next_desc:
>> +/*
>> + * The code in this whole file uses the volatile pointer to
>> + * ensure the read or
On 03/04/15 02:34, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> +
>> +if (!bulk_alloc) {
>> +__le64 dma =
>> + rte_cpu_to_le_64(R
On 03/04/15 02:36, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> - Only x540 and 82599 devices support LRO.
>> - Add the appropriate HW configuration.
>> - Add RSC aware rx_pkt_burst() handlers:
>>
On 03/04/15 20:54, Stephen Hemminger wrote:
> On Wed, 04 Mar 2015 09:57:24 +0200
> Vlad Zolotarov wrote:
>
>>
>> On 03/04/15 02:33, Stephen Hemminger wrote:
>>> On Tue, 3 Mar 2015 21:48:43 +0200
>>> Vlad Zolotarov wrote:
>>>
>>>>
h).
- Fixed a few styling and spelling issues.
Vlad Zolotarov (6):
ixgbe: Cleanups
ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices
ixgbe: Code refactoring
ixgbe: Unify the rx_pkt_bulk callback initialization
common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT opt
(): shorten the lines by defining a local alias variable
to access
>data->dev_conf.rxmode.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 52 +--
1 file changed, 28 insertions(+), 24 deletions(-)
diff --git
According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should
be configured to the same value as HLREG0.RXCRCSTRP.
Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec
but seems harmless.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3
of the cluster's HEAD buffer into
the inline function.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 116 +++---
1 file changed, 70 insertions(+), 46 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
b/lib
().
- Bug fix: vector scattered packets callback was called regardless the
appropriate
preconditions.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 1 +
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 14 ++-
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 158
Enables LRO support in PMDs.
Signed-off-by: Vlad Zolotarov
---
config/common_linuxapp | 1 +
1 file changed, 1 insertion(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 97f1c9e..5b98595 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -137,6 +137,7
and to igb_rx_queue.
- Use the appropriate handler when LRO is requested.
Signed-off-by: Vlad Zolotarov
---
New in v2:
- Removed rte_eth_dev_data.lro_bulk_alloc.
- Fixed a few styling and spelling issues.
---
lib/librte_ether/rte_ethdev.h | 6 +-
lib/librte_pmd_ixgbe/ixgbe_ethdev.c
On 03/05/15 15:19, Thomas Monjalon wrote:
> 2015-03-05 13:28, Vlad Zolotarov:
>> Enables LRO support in PMDs.
>>
>> Signed-off-by: Vlad Zolotarov
>> ---
>> config/common_linuxapp | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --gi
On 03/05/15 16:01, Thomas Monjalon wrote:
> 2015-03-05 15:39, Vlad Zolotarov:
>> On 03/05/15 15:19, Thomas Monjalon wrote:
>>> 2015-03-05 13:28, Vlad Zolotarov:
>>>> Enables LRO support in PMDs.
>>>>
>>>> Signed-off-by: Vlad Zolotarov
>&g
bulk_alloc and added
ixgbe_hw.rx_bulk_alloc_allowed
instead.
- Unified the rx_pkt_bulk callback setting (a separate new patch).
- Fixed a few styling and spelling issues.
Vlad Zolotarov (6):
ixgbe: Cleanups
ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices
ixg
(): shorten the lines by defining a local alias variable
to access
>data->dev_conf.rxmode.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 52 +--
1 file changed, 28 insertions(+), 24 deletions(-)
diff --git
According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should
be configured to the same value as HLREG0.RXCRCSTRP.
Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec
but seems harmless.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3
of the cluster's HEAD buffer into
the inline function.
Signed-off-by: Vlad Zolotarov
---
New in v3:
- ixgbe_rx_alloc_bufs(): Always reset refcnt of the buffers to 1.
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 114 +++---
1 file changed, 69 insertions(+), 45
ixgbe_hw.rx_bulk_alloc_allowed
instead.
- Bug fix: vector scattered packets callback was called regardless the
appropriate
preconditions.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 1 +
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 14 ++-
lib/librte_pmd_ixgbe
Enables LRO support in PMDs.
Signed-off-by: Vlad Zolotarov
---
config/common_linuxapp | 1 +
1 file changed, 1 insertion(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 97f1c9e..5b98595 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -137,6 +137,7
and to igb_rx_queue.
- Use the appropriate handler when LRO is requested.
Signed-off-by: Vlad Zolotarov
---
New in v2:
- Removed rte_eth_dev_data.lro_bulk_alloc.
- Fixed a few styling and spelling issues.
---
lib/librte_ether/rte_ethdev.h | 6 +-
lib/librte_pmd_ixgbe/ixgbe_ethdev.c
te_eth_dev_data.lro_bulk_alloc and added
ixgbe_hw.rx_bulk_alloc_allowed
instead.
- Unified the rx_pkt_bulk callback setting (a separate new patch).
- Fixed a few styling and spelling issues.
Vlad Zolotarov (5):
ixgbe: Cleanups
ixgbe: Bug fix: Properly configure Rx CRC stripping
(): shorten the lines by defining a local alias variable
to access
>data->dev_conf.rxmode.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 46 +--
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git
1 - 100 of 223 matches
Mail list logo
