Re: [dpdk-dev] [PATCH v3 3/3] ring:add ring walk routine

2018-12-27 Thread Wiles, Keith
> On Dec 27, 2018, at 9:17 AM, Olivier Matz wrote: > > Hi, > > On Thu, Dec 27, 2018 at 02:52:51PM +0000, Wiles, Keith wrote: >> >> >>> On Dec 27, 2018, at 8:47 AM, Wiles, Keith wrote: >>> >>> >>> >>>> On Dec

Re: [dpdk-dev] Compiler for Windows

2019-01-03 Thread Wiles, Keith
> On Jan 3, 2019, at 11:10 AM, Jason Messer wrote: > > +Jeffrey, Manasi > > We will get the most traction from the Windows developer community if we use > msvc. The only thing preventing that last time was GNU extensions used in > DPDK source which were not ISO C standards compliant. We were

Re: [dpdk-dev] DPDK on IBM Power9

2019-01-09 Thread Wiles, Keith
> On Jan 9, 2019, at 4:25 PM, Daniel Waddington > wrote: > > Hi, > I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to DPDK > on Power). > Thx, > Daniel > Below is what I get: > > $ sudo ./examples/ethtool/ethtool-app/ppc_64-power8-linuxapp-gcc/app/ethtool > --iova-mo

Re: [dpdk-dev] DPDK on IBM Power9

2019-01-09 Thread Wiles, Keith
ror 22" which is the first > indicator of the problem. > > Daniel > > -"Wiles, Keith" wrote: - > To: Daniel Waddington > From: "Wiles, Keith" > Date: 01/09/2019 02:52PM > Cc: "dev@dpdk.org" > Subject: Re: [dpdk-dev] DPDK

Re: [dpdk-dev] DPDK on IBM Power9

2019-01-09 Thread Wiles, Keith
> On Jan 9, 2019, at 6:07 PM, Thomas Monjalon wrote: > > Hi, > > 09/01/2019 23:25, Daniel Waddington: >> Hi, >> I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to >> DPDK on Power). > > As mentioned in the release notes, Power9 is supported: > http://doc.dpdk.org

Re: [dpdk-dev] [PATCH v3 1/2] net/tap: change queue fd to be pointers to process private

2018-10-02 Thread Wiles, Keith
o me Anyway my email compiler is not very good and maybe this will not work. We can leave the current design in place for now, till I have time to really look at doing a PoC for my suggestion. > > Kindest regards, > Raslan Darawsheh > > -Original Message- > From: Wiles,

Re: [dpdk-dev] [PATCH v2 5/6] net/tap: disable tap build in FREEBSD

2018-10-03 Thread Wiles, Keith
> On Oct 3, 2018, at 9:00 AM, Babu Radhakrishnan, AgalyaX > wrote: > > Disabled tap build in FreeBSD because it is not supported > Added changes to enable tap build if it is Linux OS and > disable in FreeBSD. > > Signed-off-by: Agalya Babu RadhaKrishnan > Thought I acked this one already.

Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay

2018-10-05 Thread Wiles, Keith
> On Sep 3, 2018, at 9:44 AM, Ilya Maximets wrote: > > For meson build without deprecation warnings following > patch should be applied first: >http://patches.dpdk.org/patch/44129/ Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_s

Re: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro

2018-10-05 Thread Wiles, Keith
> On Oct 3, 2018, at 11:09 AM, Yigit, Ferruh wrote: > > On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote: >> Signed-off-by: Keith Wiles >> --- >> lib/librte_eal/common/include/rte_common.h | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/lib/librte_eal/common/

Re: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro

2018-10-05 Thread Wiles, Keith
> On Oct 5, 2018, at 9:11 AM, Wiles, Keith wrote: > > > >> On Oct 3, 2018, at 11:09 AM, Yigit, Ferruh wrote: >> >> On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote: >>> Signed-off-by: Keith Wiles >>> --- >>> lib/li

Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay

2018-10-05 Thread Wiles, Keith
> On Oct 5, 2018, at 9:44 AM, Ilya Maximets wrote: > > On 05.10.2018 17:09, Wiles, Keith wrote: >> >> >>> On Sep 3, 2018, at 9:44 AM, Ilya Maximets wrote: >>> >>> For meson build without deprecation warnings following >>> patch sho

[dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-10-08 Thread Wiles, Keith
Hi Everyone, I would like to request comments on DFS as I presented at the DPDK summit in Ireland. As we know DPDK can be difficult to manage at run time and as DPDK becomes more dynamic we need to address how to configure and monitor DPDK and DPDK-based applications. A possible solution is t

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-10-09 Thread Wiles, Keith
> On Oct 8, 2018, at 5:42 PM, Wiles, Keith wrote: > > Hi Everyone, > > I would like to request comments on DFS as I presented at the DPDK summit in > Ireland. Here is a repo you can look at and play with. The code is mostly ready for upstream but still more work needs

Re: [dpdk-dev] [PATCH] net/tap: fix reported number of Tx packets

2018-10-10 Thread Wiles, Keith
> On Oct 10, 2018, at 2:01 AM, Raslan Darawsheh wrote: > > When writev fails to send packets it doesn't update the > number of Tx packets, but it still num_tx is updated. > > the value that should be returned is the actual number > of sent packets which is num_packets. > > Fixes: 02f96a0a ("

Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process

2018-10-10 Thread Wiles, Keith
> On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrote: > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronization, the secon

Re: [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

2018-10-10 Thread Wiles, Keith
> On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrote: > > Signed-off-by: Raslan Darawsheh This title for the patch is the what we did not why we did it, should that be changed? To me it does not convey the reason or we would need to add a more complete comment body text to explain why we

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-10-16 Thread Wiles, Keith
> On Oct 9, 2018, at 5:52 PM, Wiles, Keith wrote: > > > >> On Oct 8, 2018, at 5:42 PM, Wiles, Keith wrote: >> >> Hi Everyone, >> >> I would like to request comments on DFS as I presented at the DPDK summit in >> Ireland. > > Her

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: > > 11/06/2018 18:35, Wiles, Keith: >> >>> On Jun 11, 2018, at 11:06 AM, Ophir Munk wrote: >>> >>> This commit explains how to manually compile the C source file >>> tap_bpf_program.c

Re: [dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

2018-06-12 Thread Wiles, Keith
> On Jun 7, 2018, at 6:24 PM, Raslan Darawsheh wrote: > > Hi, > > As you know that currently TAP pmd support attaching a secondary process to a > primary process. > But, it's still lacking the ability to do Rx/Tx burst since it's lacking the > necessary fds for RX/TX queues, > And the setti

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 7:58 AM, Thomas Monjalon wrote: > > 12/06/2018 14:36, Wiles, Keith: >> >>> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: >>> >>> 11/06/2018 18:35, Wiles, Keith: >>>> >>>>> On Jun 11, 2018, at

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 8:44 AM, Thomas Monjalon wrote: > > 12/06/2018 15:33, Wiles, Keith: >> >>> On Jun 12, 2018, at 7:58 AM, Thomas Monjalon wrote: >>> >>> 12/06/2018 14:36, Wiles, Keith: >>>> >>>>> On Jun 12, 2018, at

Re: [dpdk-dev] [PATCH v4 1/2] net/tap: calculate checksums of multi segs packets

2018-06-12 Thread Wiles, Keith
A few formatting problems I have noticed. We can review the code logic in a meeting. > On Jun 12, 2018, at 11:31 AM, Ophir Munk wrote: > > Prior to this commit IP/UDP/TCP checksum offload calculations > were skipped in case of a multi segments packet. > This commit enables TAP checksum calculat

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 11:31 AM, Ophir Munk wrote: > > This commit implements TCP segmentation offload in TAP. > librte_gso library is used to segment large TCP payloads (e.g. packets > of 64K bytes size) into smaller MTU size buffers. > By supporting TSO offload capability in software a TAP de

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-13 Thread Wiles, Keith
> On Jun 12, 2018, at 11:31 AM, Ophir Munk wrote: > > This commit implements TCP segmentation offload in TAP. > librte_gso library is used to segment large TCP payloads (e.g. packets > of 64K bytes size) into smaller MTU size buffers. > By supporting TSO offload capability in software a TAP de

Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-13 Thread Wiles, Keith
> On Jun 13, 2018, at 11:59 AM, Thomas Monjalon wrote: > > 13/06/2018 18:41, Ferruh Yigit: >> On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: >>> diff --git a/drivers/net/cxgbe/cxgbe_filter.h >>> b/drivers/net/cxgbe/cxgbe_filter.h >>> new file mode 100644 >>> index 0..d69c79e80 >>> --- /

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-14 Thread Wiles, Keith
> On Jun 14, 2018, at 2:59 AM, Ophir Munk wrote: > > > >> -Original Message----- >> From: Wiles, Keith [mailto:keith.wi...@intel.com] >> Sent: Wednesday, June 13, 2018 7:04 PM >> To: Ophir Munk >> Cc: DPDK ; Pascal Mazon ; >> Thomas Monja

Re: [dpdk-dev] [PATCH v2 20/22] net/tap: enable port detach on secondary process

2018-06-21 Thread Wiles, Keith
> On Jun 20, 2018, at 9:00 PM, Qi Zhang wrote: > > Previously, detach port on secondary process will mess primary > process and cause same device can't be attached again, by take > advantage of rte_eth_release_port_private, we can support this > with minor change. > > Signed-off-by: Qi Zhang

Re: [dpdk-dev] [PATCH v5 1/2] net/tap: calculate checksums of multi segs packets

2018-06-24 Thread Wiles, Keith
> On Jun 23, 2018, at 6:17 PM, Ophir Munk wrote: > > Prior to this commit IP/UDP/TCP checksum offload calculations > were skipped in case of a multi segments packet. > This commit enables TAP checksum calculations for multi segments > packets. > The only restriction is that the first segment mu

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-07-05 Thread Wiles, Keith
ate "+#include "bpf_api.h", which includes a iproute2 >> header, I am not sure about this one and how to manage this dependency. > > If you feel it needs some improvement, we can postpone it for 18.11. > The most important is to have a patch to reference when somebo

Re: [dpdk-dev] Change ether_addr to avoid conflict

2018-10-22 Thread Wiles, Keith
> On Oct 21, 2018, at 8:39 AM, Lewis Donzis wrote: > > Please consider changing “struct ether_addr” in rte_ether.h to “struct > rte_ether_addr”, in order to avoid conflicts with the same structure name > /usr/include/net/ethernet.h. > > This is kind of a pain for us since we would like to in

Re: [dpdk-dev] [RFC 02/14] net: add rte prefix to arp defines

2018-10-24 Thread Wiles, Keith
> On Oct 24, 2018, at 1:18 AM, Olivier Matz wrote: > > Add 'RTE_' prefix to defines: > - rename ARP_HRD_ETHER as RTE_ARP_HRD_ETHER. > - rename ARP_OP_REQUEST as RTE_ARP_OP_REQUEST. > - rename ARP_OP_REPLY as RTE_ARP_OP_REPLY. > - rename ARP_OP_REVREQUEST as RTE_ARP_OP_REVREQUEST. > - rename AR

Re: [dpdk-dev] [RFC 00/14] prefix network structures

2018-10-24 Thread Wiles, Keith
> On Oct 24, 2018, at 1:18 AM, Olivier Matz wrote: > > This RFC targets 19.02. > > The rte_net headers conflict with the libc headers, because > some definitions are duplicated, sometimes with few differences. > This was discussed in [1], and more recently at the techboard. > > Before sendin

Re: [dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

2018-11-02 Thread Wiles, Keith
> On Nov 2, 2018, at 6:31 AM, Burakov, Anatoly > wrote: > > On 02-Nov-18 4:00 AM, Somnath Kotur wrote: >> Hello, >>I'm trying to launch a thread - lcore_mainloop( from >> examples/timer/main.c ) that runs rte_manage_timer() every 2s from testpmd >> to ensure the timers i've registered

Re: [dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

2018-11-02 Thread Wiles, Keith
> On Nov 2, 2018, at 9:35 AM, Wiles, Keith wrote: > > Sorry, meant to hit cancel for my previous email, Anatoly answered it correctly. Regards, Keith

Re: [dpdk-dev] [PATCH v2] build: disable compiler AVX512F support

2018-11-05 Thread Wiles, Keith
> On Nov 2, 2018, at 9:04 PM, Yongseok Koh wrote: > > This is a workaround to prevent a crash, which might be caused by > optimization of newer gcc (7.3.0) on Intel Skylake. Should the code below not also test for the gcc version and the Sky Lake processor, maybe I am wrong but it seems it i

Re: [dpdk-dev] [PATCH v2] build: disable compiler AVX512F support

2018-11-07 Thread Wiles, Keith
> On Nov 6, 2018, at 9:30 PM, Yongseok Koh wrote: > > >> On Nov 5, 2018, at 6:06 AM, Wiles, Keith wrote: >> >> >> >>> On Nov 2, 2018, at 9:04 PM, Yongseok Koh wrote: >>> >>> This is a workaround to prevent a crash, which might

Re: [dpdk-dev] [PATCH 3/4] net/tap: fix file descriptor leak on error

2018-11-07 Thread Wiles, Keith
> On Nov 6, 2018, at 7:30 PM, Stephen Hemminger > wrote: > > If netlink socket setup fails the file descriptor was leaked. Acked-by: Keith Wiles > > Coverity issue: 257040 > Fixes: 7c25284e30c2 ("net/tap: add netlink back-end for flow API") > Signed-off-by: Stephen Hemminger > --- > drive

Re: [dpdk-dev] [PATCH 4/4] net/tap: fix warning about comparison of fd

2018-11-07 Thread Wiles, Keith
> On Nov 6, 2018, at 7:30 PM, Stephen Hemminger > wrote: > > Static analysis tools don't like the fact that fd could be zero > in the error path. This won't happen in real world because > stdin would have to be closed, then other error occurring. Acked-by: Keith Wiles > > Coverity issue: 1

Re: [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure

2018-11-07 Thread Wiles, Keith
> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin wrote: > > In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish > has to be invoked for successful device registration. > Acked-by: Keith Wiles > Signed-off-by: Vipin Varghese > --- > --- > drivers/net/tap/rte_eth_tap.c | 1

Re: [dpdk-dev] rte_eth_tx_burst send packet fail when upgrade dpdk from 17.02 to 18.02

2018-11-08 Thread Wiles, Keith
Sent from my iPhone > On Nov 7, 2018, at 2:36 AM, Jiang Huiyou wrote: > > Hi, > My user-space TCP/IP stack works fine on DPDK 17.02, now I upgrade it to > 18.02. And then I use wrk http benchmark to test my stack, it work well > fine, but after a while, it couldn't send packet. I deb

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-14 Thread Wiles, Keith
> On Nov 14, 2018, at 4:51 AM, Morten Brørup wrote: > > Anatoly, > > This differs from the Linux kernel's behavior, where padding belongs in the > NIC driver layer, not in the protocol layer. If you pass a runt frame (too > short packet) to a Linux NIC driver's transmission function, the NIC

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-15 Thread Wiles, Keith
> On Nov 15, 2018, at 4:27 AM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith >>> On Nov 14, 2018, at 4:51 AM, Morten Brørup >> wrote: >>> >>> Anatoly, >>> >>> This differs from t

Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-15 Thread Wiles, Keith
> On Nov 15, 2018, at 7:27 AM, Hunt, David wrote: > > Hi Anatoly, > > On 13/11/2018 4:42 PM, Anatoly Burakov wrote: >> If there aren't any devices of a particular category on user's >> system, we still display them, which is bad for usability. Fix >> devbind to not print out a category unless

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly > wrote: > > On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: >> On Thu, 15 Nov 2018 15:47:13 + >> Anatoly Burakov wrote: >>> This is a placeholder for Python library abstracting away many of >>> mundane details DPDK configuration scripts ha

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Wiles, Keith
On Nov 16, 2018, at 3:51 AM, Ananyev, Konstantin mailto:konstantin.anan...@intel.com>> wrote: Hi everyone, Hi, 16/11/2018 09:42, Ilya Maximets: Hi, While discussing the ways to enable DPDK 18.11 new features in OVS there was suggestions to use 'rte_eth_devices[]' array directly. But this ar

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 3:51 AM, Ananyev, Konstantin > wrote: > > Hi everyone, > >> >> Hi, >> >> 16/11/2018 09:42, Ilya Maximets: >>> Hi, >>> While discussing the ways to enable DPDK 18.11 new features in OVS >>> there was suggestions to use 'rte_eth_devices[]' array directly. >>> But this a

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 8:37 AM, Burakov, Anatoly > wrote: > > On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: >>> -Original Message----- >>> From: Wiles, Keith >>> Sent: Friday, November 16, 2018 2:10 PM >>> To: Burakov, Anatoly >

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 8:55 AM, Thomas Monjalon wrote: > > 16/11/2018 15:37, Burakov, Anatoly: >> On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: >>> From: Wiles, Keith >>>>> On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly >>>>> On 16-No

Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-20 Thread Wiles, Keith
> On Nov 20, 2018, at 3:16 AM, Ananyev, Konstantin > wrote: > > Hi Qi, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang >> Sent: Tuesday, November 20, 2018 4:46 AM >> To: Richardson, Bruce ; Wiles, Keit

Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-23 Thread Wiles, Keith
> On Nov 19, 2018, at 10:45 PM, Zhang, Qi Z wrote: > > The patch optimizes the mac swap operation by taking advantage > of SSE instructions, it only impacts x86 platform. > > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang > --- > app/test-pmd/macswap.c | 16 +++- > 1 file change

Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-23 Thread Wiles, Keith
> On Nov 19, 2018, at 10:45 PM, Zhang, Qi Z wrote: > > The patch optimizes the mac swap operation by taking advantage > of SSE instructions, it only impacts x86 platform. > > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang > --- > app/test-pmd/macswap.c | 16 +++- > 1 file change

Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-24 Thread Wiles, Keith
> On Nov 23, 2018, at 4:43 PM, Wiles, Keith wrote: > > > >> On Nov 19, 2018, at 10:45 PM, Zhang, Qi Z wrote: >> >> The patch optimizes the mac swap operation by taking advantage >> of SSE instructions, it only impacts x86 platform. >> >> Cc

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-27 Thread Wiles, Keith
> On Oct 8, 2018, at 5:42 PM, Wiles, Keith wrote: > > Hi Everyone, > > I would like to request comments on DFS as I presented at the DPDK summit in > Ireland. > > As we know DPDK can be difficult to manage at run time and as DPDK becomes > more dynamic we need

Re: [dpdk-dev] [Bug 113] pktgen -s option send pcap traffic once

2018-11-29 Thread Wiles, Keith
> On Nov 29, 2018, at 8:09 AM, bugzi...@dpdk.org wrote: > > https://bugs.dpdk.org/show_bug.cgi?id=113 > >Bug ID: 113 > Summary: pktgen -s option send pcap traffic once > Product: DPDK > Version: unspecified > Hardware: x86 >OS:

Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Wiles, Keith
> On Nov 29, 2018, at 8:21 AM, Anatoly Burakov > wrote: > > We already trigger a mem event notification inside the walk function, > no need to do it twice. > > Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov

Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Wiles, Keith
> On Nov 29, 2018, at 9:36 AM, Burakov, Anatoly > wrote: > > On 29-Nov-18 2:54 PM, Wiles, Keith wrote: >>> On Nov 29, 2018, at 8:21 AM, Anatoly Burakov >>> wrote: >>> >>> We already trigger a mem event notification inside the walk func

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-30 Thread Wiles, Keith
On Nov 30, 2018, at 7:13 AM, Zhang, Qi Z mailto:qi.z.zh...@intel.com>> wrote: Hi Keith: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith Sent: Tuesday, November 27, 2018 11:00 PM To: dpdk-dev mailto:dev@dpdk.org>> Cc: Richa

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-30 Thread Wiles, Keith
Plain text format is a real pain unless I time travel to the 1990’s :-( > On Nov 30, 2018, at 7:13 AM, Zhang, Qi Z wrote: > > Hi Keith: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith >> Sent: Tuesday,

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: > > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. > > Signed-off-by: Gage Eads > --- > drivers/net/tap/rte_eth_tap.c | 56 +-- > 1 file changed, 54 inserti

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 4:51 PM, Eads, Gage wrote: > > > >>> >>> +static int >>> +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) >>> +{ >>> + dev->data->rx_queue_state[rx_queue_id] = >> RTE_ETH_QUEUE_STATE_STARTED; >> >> We need to verify the rx_queue_id is valid before s

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: > > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. > > Signed-off-by: Gage Eads Acked-by Keith Wiles Regards, Keith

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 5:00 PM, Wiles, Keith wrote: > > > >> On Jul 9, 2018, at 4:51 PM, Eads, Gage wrote: >> >> >> >>>> >>>> +static int >>>> +tap_rx_queue_start(struct rte_eth_dev *dev, uin

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
What version of Pktgen and DPDK are you using? Most likely DPDK has changed for the given version or Pktgen. I normally only keep pktgen working on the last releases version 18.05 in this case. I am over due pushing a updated version of pktgen, so I will try to get that done soon. > On Jul 11,

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
> On Jul 11, 2018, at 6:47 AM, khemendra kumar > wrote: > > Hi All, > > Kindly help to check below compile error in DPDK Pkt-gen on x86. > > I am following instructions from " > http://pktgen-dpdk.readthedocs.io/en/latest/getting_started.html"; > > *Below cmd I followed:* > sudo make config

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
> On Jul 11, 2018, at 8:21 AM, Wiles, Keith wrote: > > > >> On Jul 11, 2018, at 6:47 AM, khemendra kumar >> wrote: >> >> Hi All, >> >> Kindly help to check below compile error in DPDK Pkt-gen on x86. >> >> I am following instru

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
r. > > > > Just to clarify my use case, I want to use Pktgen as TG for send traffic to > VPP. > Both Pktgen and VPP will be running on 2 ARM machines (ARMv8). > > > Thanks & Regards > Khem > > On Wed, Jul 11, 2018 at 7:47 PM, Wiles, Keith wrote: >

Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device

2018-07-12 Thread Wiles, Keith
> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom > wrote: > > This is the Distributed Software (DSW) event device, which distributes > the task of scheduling events among all the eventdev ports and their > lcore threads. > > DSW is primarily designed for atomic-only queues, but also supports >

Re: [dpdk-dev] [RFC 00/11] Support externally allocated memory in DPDK

2018-07-13 Thread Wiles, Keith
> On Jul 13, 2018, at 12:10 PM, Burakov, Anatoly > wrote: > > On 06-Jul-18 2:17 PM, Anatoly Burakov wrote: >> This is a proposal to enable using externally allocated memory >> in DPDK. >> In a nutshell, here is what is being done here: >> - Index malloc heaps by NUMA node index, rather than NU

Re: [dpdk-dev] Does lthread_cond_wait need a mutex?

2018-07-18 Thread Wiles, Keith
> On Jul 17, 2018, at 10:43 PM, wubenq...@ruijie.com.cn wrote: > > Hi~ >Reference: > http://doc.dpdk.org/guides-18.05/sample_app_ug/performance_thread.html?highlight=lthread >The L-thread subsystem provides a set of functions that are logically > equivalent to the corresponding functio

Re: [dpdk-dev] Does lthread_cond_wait need a mutex?

2018-07-18 Thread Wiles, Keith
de is somewhat different then the code in DPDK and my changes would not apply to DPDK lthreads. > > So I think there is a problem with pthread_cond_wait implemented by lthread. > If that is the case, could lthread fix this problem? > > Regards, > Wubenqing >

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-07-20 Thread Wiles, Keith
> On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: > > From: Raslan Darawsheh > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IP

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-07-21 Thread Wiles, Keith
> On Jul 20, 2018, at 4:51 PM, Thomas Monjalon wrote: > > 20/07/2018 17:35, Wiles, Keith: >>> On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: >>> + /* FIXME: handle replies.nb_received > 1 */ >> >> I am not a big fan of having TODO or FIXME

Re: [dpdk-dev] Does lthread_cond_wait need a mutex?

2018-07-21 Thread Wiles, Keith
> On Jul 20, 2018, at 8:32 PM, wubenq...@ruijie.com.cn wrote: > > Hi~ > I would be appreciate it if you could provide your lthread code for me. > And I found that DPDK lthreads does not provide lthread_cond_timedwait API > which I am looking for. > Thanks. I took the lthread code and

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Wiles, Keith
> On Jul 23, 2018, at 2:09 PM, Morten Brørup wrote: > > I haven't performance tested, but they are compiler branch prediction hints > pointing out the most likely execution path, so I expect them to have a > positive effect. We really need to make sure this provides any performance improveme

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-24 Thread Wiles, Keith
> On Jul 24, 2018, at 6:31 AM, Van Haaren, Harry > wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Morten Brørup >> Sent: Tuesday, July 24, 2018 9:14 AM >> To: Olivier Matz ; Wiles, Keith >> >> Cc: Honnappa Nagarahalli ; dev@dpdk.

Re: [dpdk-dev] [PATCH] net/tap: add probe finish call for tun secondary

2018-07-24 Thread Wiles, Keith
> On Jul 24, 2018, at 12:05 AM, Vipin Varghese wrote: > > Invoke rte_eth_dev_probing_finish for rte_pmd_tun_probe. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/

Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach

2018-07-24 Thread Wiles, Keith
> On Jul 19, 2018, at 7:21 AM, ilia.kura...@intel.com wrote: > > From: Ilia Kurakin > > The patch changes rx_burst profiling approach: > 1. VTune's instrumentation is removed > 2. empty hook callback for profiling is added > This way all VTune-specific logic moves to the VTune sid

Re: [dpdk-dev] [PATCH] hash table: add a bucket iterator function

2018-07-29 Thread Wiles, Keith
> On Jul 28, 2018, at 12:48 PM, Qiaobin Fu wrote: > > Function rte_hash_bucket_iterate() enables callers to > incrementally iterate over the hash table bucket by bucket, > so that it can avoid creating hiccups and thrashing the cache > of the processor. > > This patch mainly deals with cases i

Re: [dpdk-dev] [PATCH] hash table: add a bucket iterator function

2018-07-31 Thread Wiles, Keith
is no different. If we can hide the internals, then it would be good. The callback function should not expose any internals only the value in the hash table, which I believe is do just that, right? > > Hope this clarifies the patch. > > Best, > Qiaobin > >> >>> ---

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

2018-08-01 Thread Wiles, Keith
> On Aug 1, 2018, at 7:07 AM, Burakov, Anatoly > wrote: > > Due to the upcoming external memory support [1], some API and ABI > changes will be required. In addition, although the changes called > out in the deprecation notice are not yet present in form of code > in the published RFC itself,

Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

2018-08-02 Thread Wiles, Keith
> On Aug 2, 2018, at 5:33 AM, Matan Azrad wrote: > > The rte_flow meaning of zero flow mask configuration is to match all > the range of the item value. > For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 > should much all the ipv4 traffic from the rte_flow API perspective. >

Re: [dpdk-dev] [PATCH 1/2] rawdev: fix missing queue count API

2018-08-06 Thread Wiles, Keith
> On Jul 31, 2018, at 5:33 AM, Shreyansh Jain wrote: > > Rawdev queue count API prototype was declared, but the definition was > missing from the library. This patch implements the function. > > This API is used to query the device about the count of queues it has > been configured with. > >

Re: [dpdk-dev] [PATCH 2/2] raw/skeleton: implement queue count API

2018-08-06 Thread Wiles, Keith
> On Jul 31, 2018, at 5:33 AM, Shreyansh Jain wrote: > > Use the rte_rawdev_queue_count API in skeleton and add its unit test > case. > > Signed-off-by: Shreyansh Jain > --- > drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 13 + > drivers/raw/skeleton_rawdev/skeleton_rawdev_

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Wiles, Keith
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger > wrote: > > The hexdump code obviously came from somewhere else originally. > It is not formatted according to DPDK coding style. > > Also, drop the comment which is not useful the docbock comment > is already in the rte_hexdump.h > > Signe

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Wiles, Keith
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger > wrote: > > The hexdump code obviously came from somewhere else originally. > It is not formatted according to DPDK coding style. > > Also, drop the comment which is not useful the docbock comment > is already in the rte_hexdump.h > > Signed

[dpdk-dev] dpaa2: building with EXTRA_CFLAGS="-g -O0" and shared libs link error

2018-08-19 Thread Wiles, Keith
I am building on Ubuntu 18.04.1 LTS, gcc 7.3.0-16ubuntu3 and with EXTRA_CFLAGS=“-g -O0” with shared libs enabled. I get an undefined reference to rte_dpaa2_memsegs when building portal/dpaa2_hw_dpio.c in the link phase. The odd part is this does not happen unless you are building with EXTRA_CF

Re: [dpdk-dev] dpaa2: building with EXTRA_CFLAGS="-g -O0" and shared libs link error

2018-08-20 Thread Wiles, Keith
> On Aug 20, 2018, at 2:33 AM, Hemant Agrawal wrote: > > Hi Keith, > I am able to reproduce the issue. We will send the fix asap. Thanks Hemant. > > Regards, > Hemant > > -Original Message- > From: dev On Behalf Of Wiles, Keith > Sent: Sun

Re: [dpdk-dev] Minimum kernel version for DPDK

2018-08-20 Thread Wiles, Keith
> On Aug 20, 2018, at 3:46 AM, Kevin Wilson wrote: > > Hi all, > Maybe this is a silly question, please bear with me. > > According to the “Getting Started Guide for Linux” in > http://doc.dpdk.org/guides/linux_gsg/sys_reqs.html, > the kernel version should be >= 3.2. > Accrding to my understa

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-20 Thread Wiles, Keith
> On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi wrote: > > Hello Olivier, > > Il 13/08/2018 23:54, Olivier Matz ha scritto: >> Hello Matteo, >> >> On Mon, Aug 13, 2018 at 03:20:44PM +0200, Matteo Lanzuisi wrote: >>> Any suggestion? any idea about this behaviour? >>> >>> Il 08/08/2018 11:56,

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Wiles, Keith
> On Aug 21, 2018, at 7:01 AM, Matteo Lanzuisi wrote: > > Hi > > Il 20/08/2018 18:03, Wiles, Keith ha scritto: >>> On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi >>> wrote: >>> >>> Hello Olivier, >>> >>> Il 13/08/2018

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Wiles, Keith
> On Aug 21, 2018, at 7:44 AM, Matteo Lanzuisi wrote: > > Il 21/08/2018 14:17, Wiles, Keith ha scritto: >> >>> On Aug 21, 2018, at 7:01 AM, Matteo Lanzuisi wrote: >>> >>> Hi >>> >>> Il 20/08/2018 18:03, Wiles, Keith ha

Re: [dpdk-dev] pktgen: about x710 init error

2018-08-21 Thread Wiles, Keith
> On Aug 18, 2018, at 6:58 AM, Chengbo CB1 Gao wrote: > > Hi Team, > > When I used PKTGEN by X710VF, I found that PKTGEN failed to be initialized. > The reason is that VF has no ability to disable HW CRC strip. But it's > defaulted to be disabled in PKTGEN because the global variable(hw_stri

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-24 Thread Wiles, Keith
; // don't use mempool but call a function instead > } > } > > and now it all goes well. > It is possibile that sending to itself could generate this issue? > > Regards, > Matteo > > Il 21/08/2018 16:46, Matteo Lanzuisi ha scritto: >&

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Wiles, Keith
Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a performance problem. > On Aug 28, 2018, at 12:05 PM, Saber Rezvani wrote: > > > > On 08/28/2018 08:31 PM, Stephen Hemminger wrote: >> On Tue, 28 Aug 2018 17:34:27 +0430 >> Saber Rezvani wrote: >> >>> Hi, >>> >>> >>> I have

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Wiles, Keith
> On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: > > > > On 08/28/2018 11:39 PM, Wiles, Keith wrote: >> Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a >> performance problem. > I use Pktgen verion 3.0.0, indeed it is O.k as far as I h

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-29 Thread Wiles, Keith
> On Aug 29, 2018, at 12:19 PM, Saber Rezvani wrote: > > > > On 08/29/2018 01:39 AM, Wiles, Keith wrote: >> >>> On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: >>> >>> >>> >>> On 08/28/2018 11:39 PM, Wiles, Keith wrot

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-18 Thread Wiles, Keith
> On Apr 18, 2018, at 8:50 AM, Thomas Monjalon wrote: > > 18/04/2018 10:56, Bruce Richardson: >> On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: >>> 18/04/2018 00:11, Scott Branden: On 18-04-17 03:06 PM, Thomas Monjalon wrote: > 17/04/2018 23:49, Stephen Hemminger: >>>

Re: [dpdk-dev] Why packet replication is more efficient when done using memcpy( ) as compared to rte_mbuf_refcnt_update() function?

2018-04-18 Thread Wiles, Keith
> On Apr 18, 2018, at 11:43 AM, Shailja Pandey wrote: > > Hello, > > I am doing packet replication and I need to change the ethernet and IP header > field for each replicated packet. I did it in two different ways: > > 1. Share payload from the original packet using rte_mbuf_refcnt_update >

Re: [dpdk-dev] Why packet replication is more efficient when done using memcpy( ) as compared to rte_mbuf_refcnt_update() function?

2018-04-19 Thread Wiles, Keith
> On Apr 19, 2018, at 9:30 AM, Shailja Pandey wrote: > >> The two code fragments are doing two different ways the first is using a >> loop to create possible more then one replication and the second one is not, >> correct? The loop can cause performance hits, but should be small. > Sorry for

Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Wiles, Keith
> On Aug 31, 2018, at 1:45 PM, Ilya Maximets wrote: > > NICs uses different delays up to a second during their > configuration. It makes no sense to busy-wait so long wasting > CPU cycles and preventing any other threads to execute on the > same CPU core. These busy polling are the rudiments t

<    1   2   3   4   5   6   7   8   9   >