[dpdk-dev] [PATCH 2/3] vhost: fix the comments and log

On 7/2/2015 11:33 AM, Ouyang, Changchun wrote: > It fixes the wrong log info when fails to unregister vhost driver. > > Signed-off-by: Changchun Ouyang > --- > examples/vhost/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/vhost/main.c

[dpdk-dev] [PATCH] virtio: fix the vq size issue

On 7/2/2015 10:16 AM, Ouyang, Changchun wrote: > >> -Original Message- >> From: Xie, Huawei >> Sent: Thursday, July 2, 2015 10:02 AM >> To: Ouyang, Changchun; dev at dpdk.org; Thomas Monjalon >> Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue

[dpdk-dev] [PATCH] virtio: fix the vq size issue

On 7/2/2015 8:29 AM, Ouyang, Changchun wrote: > Hi huawei, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xie, Huawei >> Sent: Wednesday, July 1, 2015 11:53 PM >> To: dev at dpdk.org; Thomas Monjalon >> Subject: Re: [

[dpdk-dev] [PATCH] virtio: fix the vq size issue

On 7/1/2015 3:49 PM, Ouyang Changchun wrote: > This commit breaks virtio basic packets rx functionality: > d78deadae4dca240e85054bf2d604a801676becc > > The QEMU use 256 as default vring size, also use this default value to > calculate the virtio > avail ring base address and used ring base

[dpdk-dev] [PATCH v3 1/2] vhost: vhost unix domain socket cleanup

On 6/30/2015 5:04 AM, Thomas Monjalon wrote: > Huawei, > I don't understand this reply. You forgot quoting, you didn't remove useless > lines, > and you seem to reply to yourself. > Should this patch be applied? > Thomas: Oh, here i remove useless lines. I am sending a new patch to fix a

[dpdk-dev] [PATCH v3 1/2] vhost: vhost unix domain socket cleanup

On 6/19/2015 1:40 AM, Huawei Xie wrote: rte_vhost_driver_unregister API will remove the listenfd for the specified path from event processing list, and then close it. v2 changes: -minor code style fix: remove unnecessary new line Signed-off-by: Huawei Xie

[dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to a function

Two opens here, the trivial one is i think it is not good practice to explicitly inline non performance critical functions in c file, even if it will be done by compiler anyway. The critical one i have concern is whether it will introduce inconsistency if we call fd_install on a fd that is just

[dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket

On 6/18/2015 5:02 AM, Thomas Monjalon wrote: > 2015-06-05 11:26, Huawei Xie: >> rte_vhost_driver_unregister will remove the listenfd from event list, and >> then close it. >> >> Signed-off-by: Huawei Xie >> Signed-off-by: Peng Sun >> --- >> lib/librte_vhost/rte_virtio_net.h| 3 ++

[dpdk-dev] [PATCH] vhost: provide vhost API to unregister vhost unix domain socket

On 6/17/2015 12:17 PM, Tetsuya Mukawa wrote: > On 2015/06/02 10:50, Huawei Xie wrote: >> rte_vhost_driver_unregister will remove the listenfd from event list, and >> then close it. >> >> Signed-off-by: Huawei Xie >> Signed-off-by: Peng Sun >> --- >> >> +/** >> + * Unregister the specified

[dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket

On 6/5/2015 5:04 PM, Loftus, Ciara wrote: > >> -Original Message- >> From: Xie, Huawei >> Sent: Friday, June 05, 2015 4:26 AM >> To: dev at dpdk.org >> Cc: Loftus, Ciara; Xie, Huawei; Sun, Peng A >> Subject: [PATCH v2] vhost: provide vhost API to

[dpdk-dev] [PATCH v7 0/4] Fix vhost enqueue/dequeue issue

Acked-by: Huawei Xie On 6/9/2015 9:03 AM, Ouyang, Changchun wrote: > Fix enqueue/dequeue can't handle chained vring descriptors; > Remove unnecessary vring descriptor length updating; > Add support copying scattered mbuf to vring; > > Changchun Ouyang (4): > lib_vhost: Fix enqueue/dequeue

[dpdk-dev] [PATCH v7 0/4] Fix vhost enqueue/dequeue issue

Acked-by: Huawei Xie On 6/9/2015 9:03 AM, Ouyang, Changchun wrote: > Fix enqueue/dequeue can't handle chained vring descriptors; > Remove unnecessary vring descriptor length updating; > Add support copying scattered mbuf to vring; > > Changchun Ouyang (4): > lib_vhost: Fix enqueue/dequeue

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

On 6/9/2015 4:47 PM, Michael S. Tsirkin wrote: > On Tue, Jun 09, 2015 at 03:04:02PM +0800, Linhaifeng wrote: >> >> On 2015/4/24 15:27, Luke Gorrie wrote: >>> On 24 April 2015 at 03:01, Linhaifeng wrote: >>> If not add memory fence what would happen? Packets loss or interrupt loss?How to

[dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket

On 6/5/2015 5:04 PM, Loftus, Ciara wrote: > >> -Original Message- >> From: Xie, Huawei >> Sent: Friday, June 05, 2015 4:26 AM >> To: dev at dpdk.org >> Cc: Loftus, Ciara; Xie, Huawei; Sun, Peng A >> Subject: [PATCH v2] vhost: provide vhost API to

[dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket

Sorry, forget the --in-reply-to, please ignore this thread. On 6/5/2015 10:49 AM, Xie, Huawei wrote: > rte_vhost_driver_unregister will remove the listenfd from event list, and > then close it. > > Signed-off-by: Huawei Xie > Signed-off-by: Peng Sun > --- >

[dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket

On 6/5/2015 10:49 AM, Xie, Huawei wrote: > rte_vhost_driver_unregister will remove the listenfd from event list, and > then close it. > > Signed-off-by: Huawei Xie > Signed-off-by: Peng Sun > --- The v2 patch just fixes two lines of code style issue.

[dpdk-dev] [PATCH] vhost: provide vhost API to unregister vhost unix domain socket

On 6/3/2015 8:55 PM, Ouyang, Changchun wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie >> Sent: Tuesday, June 2, 2015 9:50 AM >> To: dev at dpdk.org >> Cc: Sun, Peng A >> Subject: [dpdk-dev] [PATCH] vhost: provide vhost API to unregister

[dpdk-dev] [PATCH 2/6] lib_vhost: Support multiple queues in virtio dev

On 5/21/2015 3:51 PM, Ouyang Changchun wrote: > Each virtio device could have multiple queues, say 2 or 4, at most 8. > Enabling this feature allows virtio device/port on guest has the ability to > use different vCPU to receive/transmit packets from/to each queue. > > In multiple queues mode,

[dpdk-dev] [PATCH v3 1/4] lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors

On 6/1/2015 4:26 PM, Ouyang, Changchun wrote: > Vring enqueue need consider the 2 cases: > 1. use separate descriptors to contain virtio header and actual data, e.g. > the first descriptor > is for virtio header, and then followed by descriptors for actual data. > 2. virtio header and some

[dpdk-dev] [PATCH 3/6] lib_vhost: Set memory layout for multiple queues mode

Is there any possibility that different queue has different memory translation? How about we use the memory region of the first queue discovered? On 5/21/2015 3:50 PM, Ouyang Changchun wrote: > QEMU sends separate commands orderly to set the memory layout for each queue > in one virtio device,

[dpdk-dev] [PATCH v2 5/5] lib_vhost: Add support copying scattered mbuf to vring

virtio_dev_rx & scatter_rx & merge-able rx should be merged and the code could be much simpler, unless there is special performance consideration. On 5/28/2015 11:17 PM, Ouyang, Changchun wrote: > Add support copying scattered mbuf to vring which is done by dev_scatter_rx, > and check the 'next'

[dpdk-dev] [PATCH v2 1/5] lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors

On 5/28/2015 11:17 PM, Ouyang, Changchun wrote: > Vring enqueue need consider the 2 cases: > 1. Vring descriptors chained together, the first one is for virtio header, > the rest are for real > data, virtio driver in Linux usually use this scheme; > 2. Only one descriptor, virtio header and

[dpdk-dev] [PATCH v2 1/5] lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors

On 5/28/2015 11:17 PM, Ouyang, Changchun wrote: > Vring enqueue need consider the 2 cases: > 1. Vring descriptors chained together, the first one is for virtio header, > the rest are for real > data, virtio driver in Linux usually use this scheme; > 2. Only one descriptor, virtio header and

[dpdk-dev] [PATCH] vhost: make vhost lockless enqueue configurable

On 4/29/2015 7:57 PM, Thomas Monjalon wrote: > 2015-04-29 13:38 GMT+02:00 Panu Matilainen : >> On 04/29/2015 02:29 PM, Huawei Xie wrote: >>> vhost enabled vSwitch could have their own thread-safe vring enqueue >>> policy. >>> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless enqueue.

[dpdk-dev] [PATCH] virtio: Fix enqueue/dequeue can't handle chained vring descriptors.

On 5/18/2015 9:23 PM, Ouyang, Changchun wrote: > Hi Huawei, > >> -Original Message----- >> From: Xie, Huawei >> Sent: Monday, May 18, 2015 5:39 PM >> To: Ouyang, Changchun; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] virtio: Fix enqueue/dequeue can't

[dpdk-dev] [PATCH] virtio: Fix enqueue/dequeue can't handle chained vring descriptors.

On 5/4/2015 2:27 PM, Ouyang Changchun wrote: > Vring enqueue need consider the 2 cases: > 1. Vring descriptors chained together, the first one is for virtio header, > the rest are for real data; > 2. Only one descriptor, virtio header and real data share one single > descriptor; > > So does

[dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to a function

On 5/7/2015 9:17 PM, Pavel Boldin wrote: On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 4/3/2015 1:02 AM, Pavel Boldin wrote: > Move ioctl `EVENTFD_COPY' handler code to an inline function. Pavel: There is no necessity to inline this func

[dpdk-dev] Issues with example/vhost with running VM

Try --socket-mem or -m 2048 to limit the vhost switch's memory consumption, note that vswitch requires several GB memory due to some issue in the example, so try allocating more huges pages. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Grochowski

[dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to a function

On 4/3/2015 1:02 AM, Pavel Boldin wrote: > Move ioctl `EVENTFD_COPY' handler code to an inline function. Pavel: There is no necessity to inline this function. /huawei

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

On 4/16/2015 7:48 PM, Pavel Boldin wrote: > Replace copy-pasted `fget_from_files' -> `filp_close' with > a `sys_close' call. > > Signed-off-by: Pavel Boldin > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 49 > +++- > 1 file changed, 12 insertions(+), 37

[dpdk-dev] [PATCH v5 0/5] Refactor module `eventfd_link'

Thomas: Would review this patch this week. On 4/28/2015 10:36 PM, Thomas Monjalon wrote: > Huawei, Changchun, > Any opinion about these patches? > > 2015-04-16 14:48, Pavel Boldin: >> This patchset contains refactoring steps for the `eventfd_link' module >> of the DPDK's `librte_vhost' part. >>

[dpdk-dev] data copy in vhost-user

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss > Sent: Tuesday, April 28, 2015 12:27 AM > To: Nikita Kalyazin; dev at dpdk.org > Subject: Re: [dpdk-dev] data copy in vhost-user > > > > On 27/04/15 12:54, Nikita Kalyazin wrote: > > Hi, > > >

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Friday, April 24, 2015 9:01 AM > To: Xie, Huawei; dev at dpdk.org > Cc: luke at snabb.co; mst at redhat.com > Subject: Re: [PATCH] vhost: flush used->idx update before re

[dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua?

ion at lists.linux-foundation.org > Subject: Re: [dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua? > > Howdy, > > On 8 April 2015 at 17:15, Xie, Huawei wrote: > > > luke: > > 1. host read the flag. 2 guest toggles the flag 3.guest checks the used. > > 4.

[dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua?

On 4/7/2015 10:23 PM, Luke Gorrie wrote: > Hi Michael, > > I'm writing to follow up the previous discussion about memory barriers in > virtio-net device implementations, and Cc'ing the DPDK list because I > believe this is relevant to them too. > > First, thanks again for getting in touch and

[dpdk-dev] [PATCH] cast used->idx to volatile

On 4/1/2015 3:51 PM, Thomas Monjalon wrote: > 2015-03-30 15:56, Xie, Huawei: >> On 3/30/2015 5:21 PM, Linhaifeng wrote: >>> On 2015/3/24 18:06, Xie, Huawei wrote: >>>> On 3/24/2015 3:44 PM, Linhaifeng wrote: >>>>> On 2015/3/24 9:53, Xie, Huawei wrote:

[dpdk-dev] [PATCH] cast used->idx to volatile

On 3/30/2015 5:21 PM, Linhaifeng wrote: > > On 2015/3/24 18:06, Xie, Huawei wrote: >> On 3/24/2015 3:44 PM, Linhaifeng wrote: >>> On 2015/3/24 9:53, Xie, Huawei wrote: >>>> On 3/24/2015 9:00 AM, Linhaifeng wrote: >>>>> On 2015/3/23 20:54,

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

On 3/30/2015 11:33 PM, Thomas Monjalon wrote: > 2015-03-30 15:23, Xie, Huawei: >> On 3/30/2015 11:08 PM, Thomas Monjalon wrote: >>> 2015-03-30 14:52, Xie, Huawei: >>>> On 3/30/2015 8:25 PM, Thomas Monjalon wrote: >>>>> 2015-03-30 08:31, Xie, Huawei:

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

On 3/30/2015 11:08 PM, Thomas Monjalon wrote: > 2015-03-30 14:52, Xie, Huawei: >> On 3/30/2015 8:25 PM, Thomas Monjalon wrote: >>> 2015-03-30 08:31, Xie, Huawei: >>>> On 3/9/2015 11:45 PM, Huawei Xie wrote: >>>>> --- >>>>>

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

On 3/30/2015 8:25 PM, Thomas Monjalon wrote: > 2015-03-30 08:31, Xie, Huawei: >> On 3/9/2015 11:45 PM, Huawei Xie wrote: >>> --- >>> MAINTAINERS | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS &

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

On 3/9/2015 11:45 PM, Huawei Xie wrote: > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 07fdf5e..b4327d3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_* > F: examples/vhost_xen/

[dpdk-dev] [PATCH v2] virtio: Fix crash issue for secondary process

On 3/27/2015 2:35 PM, Ouyang, Changchun wrote: > It needs Rx function even in the case of secondary process, and it also needs > check if > it supports mergeable feature or not. > > Signed-off-by: Changchun Ouyang > --- > > Changes in v2: > -- Check if it supports mergeable or not for the

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `fput' call > to decrease the reference counter. > > Signed-off-by: Pavel Boldin > --- >

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `fput' call > to decrease the reference counter. > > Signed-off-by: Pavel Boldin > --- >

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/25/2015 4:08 AM, Pavel Boldin wrote: On Tue, Mar 24, 2015 at 6:20 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/24/2015 7:10 PM, Pavel Boldin wrote: On Tue, Mar 24, 2015 at 8:28 AM, Xie, Huawei mailto:huawei.xie at intel.com><mailto:huawei.xie a

[dpdk-dev] [PATCH] vhost: Fix Segmentation fault of NULL address

On 3/26/2015 3:05 PM, Qiu, Michael wrote: > Function gpa_to_vva() could return zero, while this will lead > a Segmentation fault. > > This patch is to fix this issue. > > Signed-off-by: Michael Qiu > --- > lib/librte_vhost/vhost_rxtx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[dpdk-dev] [PATCH] virtio: Fix crash issue for secondary process

On 3/23/2015 10:33 PM, Xie, Huawei wrote: > On 3/21/2015 5:59 AM, Thomas Monjalon wrote: > > 2015-03-19 09:45, Ouyang Changchun: > > > It definitely needs Rx function even in the case of secondary process, so put > the assignment a bit earlier to make sure of it. > &g

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/24/2015 7:10 PM, Pavel Boldin wrote: On Tue, Mar 24, 2015 at 8:28 AM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct fi

[dpdk-dev] [PATCH] cast used->idx to volatile

On 3/24/2015 3:44 PM, Linhaifeng wrote: > > On 2015/3/24 9:53, Xie, Huawei wrote: >> On 3/24/2015 9:00 AM, Linhaifeng wrote: >>> On 2015/3/23 20:54, Xie, Huawei wrote: >>>>> -Original Message- >>>>> From: Linhaifeng [mailto:haifeng.lin at

[dpdk-dev] [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails

On 3/22/2015 8:08 PM, Ouyang, Changchun wrote: > >> -Original Message- >> From: linhaifeng [mailto:haifeng.lin at huawei.com] >> Sent: Saturday, March 21, 2015 9:47 AM >> To: dev at dpdk.org >> Cc: Ouyang, Changchun; Xie, Huawei >> Subject: [PATCH

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `fput' call > to decrease the reference counter. > > Signed-off-by: Pavel Boldin > --- >

[dpdk-dev] [PATCH] cast used->idx to volatile

On 3/24/2015 9:00 AM, Linhaifeng wrote: > > On 2015/3/23 20:54, Xie, Huawei wrote: >> >>> -Original Message- >>> From: Linhaifeng [mailto:haifeng.lin at huawei.com] >>> Sent: Monday, March 23, 2015 8:24 PM >>> To: dev at dpdk.org >&g

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 11:27 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 5:16 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 10:52 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei mailto:huawei.xie at intel.com><mailto:huawei.xie a

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 10:52 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 10:37 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei mailto:huawei.xie at intel.com><mailto:huawei.xie a

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 10:37 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct fi

[dpdk-dev] [PATCH] virtio: Fix crash issue for secondary process

On 3/21/2015 5:59 AM, Thomas Monjalon wrote: 2015-03-19 09:45, Ouyang Changchun: It definitely needs Rx function even in the case of secondary process, so put the assignment a bit earlier to make sure of it. Signed-off-by: Changchun Ouyang ---

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `fput' call > to decrease the reference counter. > > Signed-off-by: Pavel Boldin > --- >

[dpdk-dev] [PATCH] vhost library doc update

On 3/22/2015 10:00 PM, Butler, Siobhan A wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Huawei Xie Sent: Wednesday, March 11, 2015 4:22 PM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH] vhost library doc update add vhost user

[dpdk-dev] [PATCH] lib/librte_pmd_virtio fix can't receive packets after rx_q is empty

On 3/20/2015 6:47 PM, linhaifeng wrote: > From: Linhaifeng > > If failed to alloc mbuf ring_size times the rx_q may be empty and can't > receive any packets forever because nb_used is 0 forever. Agreed. In current implementation, once VQ becomes empty, we have no chance to refill it again. The

[dpdk-dev] [PATCH] vhost: Add a hint on how to add or remove the device to a data core

Acked-by Huawei Xie On 2/27/2015 6:22 PM, Beno?t Canet wrote: > Let's make sure people will not forget to set and unset VIRTIO_DEV_RUNNING. > > Signed-off-by: Beno?t Canet > --- > doc/guides/prog_guide/vhost_lib.rst | 3 ++- > lib/librte_vhost/rte_virtio_net.h | 4 > 2 files changed, 6

[dpdk-dev] [PATCH v3 09/11] lib/librte_vhost: vhost user support

On 2/24/2015 1:36 AM, Czesnowicz, Przemyslaw wrote: > From: "Xie, Huawei" > > In rte_vhost_driver_register(), vhost unix domain socket listener fd is > created > and added to polled(based on select) fdset. > > In rte_vhost_driver_session_start(), fds in the fds

[dpdk-dev] Vhost-user early adopter feedback

On 2/18/2015 3:59 PM, Beno?t Canet wrote: > Hello Xie, > > As promized I integrated your vhost-user patchset from january in my vswitch. > > I just tried it, it works pretty well. > > I just had a minor bug with rte_vhost_driver_register taking ownership of the > string patch pointer too late. I

[dpdk-dev] [PATCH v3 00/11] qemu vhost-user support

Czesnowicz wrote: > v3 changes: > * move things around to make all patches compile > > > Xie, Huawei (11): > lib/librte_vhost: enable VIRTIO_NET_F_CTRL_RX VIRTIO_NET_F_CTRL_RX is > dependant on VIRTIO_NET_F_CTRL_VQ. Observed that virtio-net driver > in gue

[dpdk-dev] [PATCH v4 00/26] Single virtio implementation

Acked-by Huawei Xie On 2/9/2015 9:14 AM, Ouyang, Changchun wrote: > This is the patch set for single virtio implementation. > > Why we need single virtio? > > As we know currently there are at least 3 virtio PMD driver implementations: > A)

[dpdk-dev] [PATCH v2 09/11] lib/librte_vhost: vhost user support

On 2/12/2015 4:28 PM, Linhaifeng wrote: > > On 2015/2/12 13:07, Huawei Xie wrote: >> + >> +/* This is ugly */ >> +mapped_size = memory.regions[idx].memory_size + >> +memory.regions[idx].mmap_offset; >> +mapped_address =

[dpdk-dev] [PATCH v2 00/11] qemu vhost-user support

Sorry, forget to add --in-reply-to and add v2 changes. v2 changes: * vhost-cuse and vhost-user have their own set_mem_table message handler. * rework and refine mutex operation in fd management to avoid race condition * increase listen backlog * use memset to fix initialization compiler errors

[dpdk-dev] [PATCH v3 19/25] ether: Fix vlan strip/insert issue

On 1/29/2015 3:24 PM, Ouyang Changchun wrote: > Need swap the data from cpu to BE(big endian) for vlan-type. > > Signed-off-by: Changchun Ouyang > --- > lib/librte_ether/rte_ether.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ether/rte_ether.h

[dpdk-dev] [RFC PATCH v2 01/14] enable VIRTIO_NET_F_CTRL_RX VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. Observed that virtio-net driver in guest would crash with only CTRL_RX enabled.

> > Hi,Xie > > If don't have features VIRTIO_NET_F_CTRL_VQ and VIRTIO_NET_F_CTRL_RX > what would happen? > Why add the two features? If virtio-net driver doesn't require those two features, it will work fine. Changchun cced added these two features for control queue support and

[dpdk-dev] [PATCH 05/12] lib/librte_vhost: copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c

> > + * map it to our address space. > > + */ > > +static int > > +host_memory_map(struct virtio_net *dev, struct virtio_memory *mem, > > + pid_t pid, uint64_t addr) > > +{ > > Hi Xie, > > This patch only copy host_memory_map() to a new file. > And actually the original function is removed at

[dpdk-dev] [PATCH 01/12] lib/librte_vhost: enable VIRTIO_NET_F_CTRL_RX

> @@ -73,7 +73,8 @@ static struct virtio_net_config_ll *ll_root; > > > > /* Features supported by this lib. */ > > #define VHOST_SUPPORTED_FEATURES ((1ULL << > VIRTIO_NET_F_MRG_RXBUF) | \ > > - (1ULL << VIRTIO_NET_F_CTRL_RX)) > > + (1ULL <<

[dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Thursday, January 29, 2015 8:39 PM > To: Xie, Huawei; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there > is > no buffer > > &

[dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of linhaifeng > Sent: Thursday, January 29, 2015 6:30 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is > no > buffer > > From: Linhaifeng > > If we found

[dpdk-dev] vhost user examples

> -Original Message- > From: Beno?t Canet [mailto:benoit.canet at irqsave.net] > Sent: Wednesday, January 28, 2015 1:00 AM > To: Xie, Huawei > Cc: Beno?t Canet; dev at dpdk.org > Subject: Re: vhost user examples > > The Tuesday 27 Jan 2015 ? 16:33:19 (+

[dpdk-dev] vhost user examples

> -Original Message- > From: Beno?t Canet [mailto:benoit.canet at irqsave.net] > Sent: Tuesday, January 27, 2015 10:11 PM > To: Xie, Huawei; dev at dpdk.org > Subject: vhost user examples > > > Hi Xie, > > I would be interested in alpha t

[dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers

> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, January 27, 2015 5:59 PM > To: Xie, Huawei > Cc: Ouyang, Changchun; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers >

[dpdk-dev] [PATCH v2 04/24] virtio: Add support for Link State interrupt

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Tuesday, January 27, 2015 10:36 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 04/24] virtio: Add support for Link State > interrupt > > Virtio has link state interrupt

[dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Tuesday, January 27, 2015 10:36 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers > > The DPDK driver only has to deal with the case of

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Friday, January 23, 2015 4:17 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user >

[dpdk-dev] [PATCH v2] vhost: add interface name to virtio-net struct

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Linhaifeng > Sent: Sunday, January 25, 2015 12:42 PM > To: Loftus, Ciara; dev at dpdk.org > Cc: Anthony Fee > Subject: Re: [dpdk-dev] [PATCH v2] vhost: add interface name to virtio-net > struct > > > > On

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Thursday, December 11, 2014 1:36 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vh

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Thursday, December 11, 2014 2:04 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vh

[dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, January 15, 2015 12:37 AM > To: dev at dpdk.org > Cc: Xie, Huawei; Ouyang, Changchun > Subject: Re: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config >

[dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature

> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > index 27ba175..744156c 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -68,7 +68,9 @@ static struct virtio_net_device_ops const *notify_ops; > static struct virtio_net_config_ll

[dpdk-dev] [PATCH RFC v2 03/12] lib/librte_vhost: move event_copy logic from virtio-net.c to vhost-net-cdev.c

> + file = *(const struct vhost_vring_file *)in_buf; > + LOG_DEBUG(VHOST_CONFIG, > + "idx:%d fd:%d\n", file.index, file.fd); > + fd = eventfd_copy(file.fd, ctx.pid); > + if (fd < 0) { > +

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Wednesday, December 10, 2014 10:36 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vh

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Wednesday, December 24, 2014 12:21 AM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support > > (

[dpdk-dev] [PATCH] vhost: add interface name to virtio-net struct

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Loftus, Ciara > Sent: Thursday, December 18, 2014 10:02 AM > To: Thomas Monjalon > Cc: dev at dpdk.org; Anthony Fee > Subject: Re: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net struct > > Hi

[dpdk-dev] [PATCH RFC v2 07/12] lib/librte_vhost: async event and callback

> > I got error from checkpatch.pl like followings. > > ERROR: trailing statements should be on next line > #74: FILE: lib/librte_vhost/vhost_user/fd_man.c:61: > + for (i = 0; i < pfdset->num && pfdset->fd[i].fd != fd; i++); Thanks. This is RFC, so maybe it is far from perfection, :). > > +

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Sunday, December 14, 2014 10:26 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support > &g

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> > +{ > > + struct virtio_net *dev = get_device(ctx); > > + > > + /* We have to stop the queue (virtio) if it is running. */ > > + if (dev->flags & VIRTIO_DEV_RUNNING) > > + notify_ops->destroy_device(dev); > > I have an one concern about finalization of vrings. > Can

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> -Original Message- > From: Xie, Huawei > Sent: Thursday, December 11, 2014 10:13 AM > To: 'Linhaifeng'; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: RE: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user > support > > > > &

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

> > Only support one vhost-user port ? Do you mean vhost server by "port"? If that is the case, yes, now only one vhost server is supported for multiple virtio devices. As stated in the cover letter, we have requirement and plan for multiple server support, though I am not sure if it is

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

This patch set is based on latest vhost. It fixes vhost-user memory map/unmap alignment issue. It uses VHOST_USER_GET_VRING_BASE as the message for vhost device stop in vhost-user. It uses VHOST_SET_VRING_KICK as the message that tells us vhost device is ready in

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

Hi Michael: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael > Sent: Monday, December 08, 2014 8:28 AM > To: Burakov, Anatoly; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module > not loaded > > On

[dpdk-dev] DDPK use of MAP_FIXED in mmap

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, December 09, 2014 2:55 AM > To: Karmarkar Suyash > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] DDPK use of MAP_FIXED in mmap > > On Mon, Dec 08, 2014 at 07:02:38PM +,

[dpdk-dev] [PATCH] i40e: Fix a vlan bug

Hi Thomas: I will continue work on this fix. Do you have comments to the v4 patch? For Bruce's comment, I add some descriptive commit message for the commit. For the constant number, I define a macro as the wrapper for the VFA array index and value. One question is it isn't based on latest

[dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter fix

> -Original Message- > From: Qiu, Michael > Sent: Monday, November 24, 2014 1:33 AM > To: Xie, Huawei; Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter > fix > > On 11/10/2014 2:42 PM, Xie, Huawei wrote

[dpdk-dev] [PATCH v2 0/2] lib/librte_pmd_i40e: set vlan filter fix

Hi Thomas: Do you have issues applying this patch and vhost VMDQ patch? Without this fix, the vlan filter set willn't work. -Huawei > -Original Message- > From: Chen, Jing D > Sent: Monday, November 10, 2014 1:26 AM > To: Xie, Huawei; dev at dpdk.org > Subject: RE: [dpdk

[dpdk-dev] vhost-user technical isssues

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, November 13, 2014 7:53 PM > To: Xie, Huawei; dev at dpdk.org > Cc: Long, Thomas > Subject: Re: vhost-user technical isssues > > Hi Xie, > > (2014/11/14 9:22), Xie,

[dpdk-dev] vhost-user technical isssues

; From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, November 13, 2014 11:57 PM > To: Linhaifeng; Xie, Huawei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] vhost-user technical isssues > > Hi Lin, > (2014/11/14 14:30), Linhaifeng wrote: > > > > On

<    1   2   3   4   5   >