RE: 22.11.3 patches review and test

2023-09-05 Thread Xueming(Steven) Li
> -Original Message- > From: Kevin Traynor > Sent: 9/5/2023 16:50 > To: Zeng, ZhichaoX ; Xu, HailinX > ; Xueming(Steven) Li ; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Xu, Ke1 ; Zhang, Qi Z > > Cc: xuemi...@nvdia.com; dev@dpdk.org; Stokes, Ia

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-09-21 Thread Xueming(Steven) Li
> -Original Message- > From: Ferruh Yigit > Sent: 9/21/2023 23:50 > To: Ori Kam ; Xueming(Steven) Li > Cc: dev@dpdk.org; fengcheng...@huawei.com; Ivan Malov > ; Raslan Darawsheh > Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function > > On

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-14 Thread Xueming(Steven) Li
Hi Haiyue, > > + > > +/* > > + * Test whether the auxiliary device exist */ bool > > +auxiliary_exists(const char *name) > > is_auxiliary_support() ? This function test whether an auxiliary device exists, name parameter is device name. I think auxiliary_dev_exists(name) make more sense. Agree

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-14 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, April 14, 2021 4:18 PM > To: Xueming(Steven) Li ; Wang, Haiyue > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella > Subject: Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Xueming(Steven) Li
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, April 15, 2021 3:36 PM > To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella ; Neil Horman > > Subject: RE: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Xueming(Steven) Li
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, April 15, 2021 3:52 PM > To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella ; Neil Horman > > Subject: RE: [dpdk-dev] [PATCH v

Re: [dpdk-dev] Bug with commit 64051bb1 (devargs: unify scratch buffer storage)

2021-04-17 Thread Xueming(Steven) Li
Hi Jim, > From: Harris, James R > Sent: Saturday, April 17, 2021 6:05 AM > To: dev@dpdk.org; Xueming(Steven) Li > Subject: Bug with commit 64051bb1 (devargs: unify scratch buffer storage) > > Hi, > > SPDK has identified a regression with commit 64051bb1 (devargs:

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-18 Thread Xueming(Steven) Li
Hi Bruce, > -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Saturday, April 17, 2021 1:05 AM > To: dev@dpdk.org > Cc: Bruce Richardson > Subject: [dpdk-dev] [PATCH 00/14] Build file updates > > This RFC contains 5 changes/updates to the DPDK build and build files. >

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-21 Thread Xueming(Steven) Li
> -Original Message- > From: Bruce Richardson > Sent: Monday, April 19, 2021 9:06 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/14] Build file updates > > On Sun, Apr 18, 2021 at 08:45:25AM +, Xueming(Steven

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-21 Thread Xueming(Steven) Li
> -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, April 21, 2021 9:02 PM > To: 'Bruce Richardson' > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 00/14] Build file updates > > > > -Original Message- > > From

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-22 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 22, 2021 12:11 AM > To: Parav Pandit ; Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; Kinsella Ray > ; david.march...@redhat.com; > ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 23, 2021 4:22 PM > To: Parav Pandit ; Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; Kinsella Ray > ; david.march...@redhat.com; > ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 23, 2021 4:15 PM > To: Xueming(Steven) Li > Cc: Parav Pandit ; dev@dpdk.org; Wang Haiyue > ; Kinsella Ray ; > david.march...@redhat.com; ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-24 Thread Xueming(Steven) Li
Thanks for clarification, will update in next version. From: Thomas Monjalon Sent: Thursday, June 24, 2021 2:37:19 PM To: Xueming(Steven) Li Cc: Parav Pandit ; dev@dpdk.org ; Wang Haiyue ; Kinsella Ray ; david.march...@redhat.com ; ferruh.yi...@intel.com

Re: [dpdk-dev] [PATCH v5 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-24 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Friday, June 25, 2021 12:19 AM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; Kinsella Ray > > Subject: Re: [dpdk-dev] [PATCH v5 2/2] bus/auxiliary: introduce auxiliary bus > > 2

Re: [dpdk-dev] [RFC] bus/auxiliary: introduce auxiliary bus

2021-06-25 Thread Xueming(Steven) Li
> -Original Message- > From: Stephen Hemminger > Sent: Friday, June 25, 2021 12:34 PM > To: Xueming(Steven) Li > Cc: NBU-Contact-Thomas Monjalon ; dev@dpdk.org; Parav > Pandit ; Ray Kinsella > ; Neil Horman > Subject: Re: [dpdk-dev] [RFC] bus/auxiliary:

[dpdk-dev] 20.11.2 patches review and test

2021-06-26 Thread Xueming(Steven) Li
Hi all, Here is a list of patches targeted for stable release 20.11.2. The planned date for the final release is 6th July. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations

Re: [dpdk-dev] [PATCH 2/2] devtools: auto detect branch to search fix patches

2021-06-29 Thread Xueming(Steven) Li
> -Original Message- > From: dev On Behalf Of Xueming(Steven) Li > Sent: Tuesday, June 15, 2021 6:56 PM > To: Christian Ehrhardt > Cc: dev ; Luca Boccassi ; NBU-Contact-Thomas > Monjalon ; dpdk stable > ; Yuanhan Liu > Subject: Re: [dpdk-dev] [PATCH 2/2] devt

Re: [dpdk-dev] [PATCH] ethdev: keep count of allocated and used representor ranges

2021-07-02 Thread Xueming(Steven) Li
Hi > -Original Message- > From: Andrew Rybchenko > Sent: Friday, July 2, 2021 10:23 PM > To: Matan Azrad ; Shahaf Shuler ; Slava > Ovsiienko ; NBU- > Contact-Thomas Monjalon ; Ferruh Yigit > ; Xueming(Steven) Li > > Cc: dev@dpdk.org; Viacheslav Galak

Re: [dpdk-dev] [PATCH] ethdev: keep count of allocated and used representor ranges

2021-07-04 Thread Xueming(Steven) Li
> -Original Message- > From: Viacheslav Galaktionov > Sent: Saturday, July 3, 2021 6:01 PM > To: Xueming(Steven) Li > Cc: Andrew Rybchenko ; Matan Azrad > ; Shahaf Shuler > ; Slava Ovsiienko ; > NBU-Contact-Thomas Monjalon ; > Ferruh Yigit ; dev@dpdk.org

Re: [dpdk-dev] [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Xueming(Steven) Li
Hi Andrew, Thanks very much all the good suggestions, v7 posted. Best Regards, Xueming > -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 5, 2021 12:13 AM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; NBU-Contact-Thomas > Monjalon ; Kin

Re: [dpdk-dev] [PATCH v7 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Xueming(Steven) Li
Made changes and forgot to commit :( please ignore and refer to new v8. > -Original Message- > From: Xueming(Steven) Li > Sent: Monday, July 5, 2021 1:37 PM > Cc: dev@dpdk.org; Xueming(Steven) Li ; Wang Haiyue > ; NBU-Contact-Thomas > Monjalon ; Kinsella Ray ; A

Re: [dpdk-dev] [PATCH v8 1/2] devargs: add common key definition

2021-07-05 Thread Xueming(Steven) Li
Sorry, this patch missed the ack line from Andrew: Acked-by: Andrew Rybchenko > -Original Message- > From: Xueming(Steven) Li > Sent: Monday, July 5, 2021 2:45 PM > Cc: dev@dpdk.org; Xueming(Steven) Li ; > NBU-Contact-Thomas Monjalon ; Matan > Azrad ; Sha

Re: [dpdk-dev] [PATCH v8 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-05 Thread Xueming(Steven) Li
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 5, 2021 5:19 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; NBU-Contact-Thomas > Monjalon ; Kinsella Ray > ; Parav Pandit ; Neil Horman > > Subject: Re: [

Re: [dpdk-dev] [PATCH v2] ethdev: keep count of allocated and used representor ranges

2021-07-05 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 5, 2021 6:03 PM > To: Matan Azrad ; Shahaf Shuler ; Slava > Ovsiienko ; NBU- > Contact-Thomas Monjalon ; Ferruh Yigit > ; Xueming(Steven) Li > > Cc: dev@dpdk.org; Viacheslav Galaktionov &g

Re: [dpdk-dev] 20.11.2 patches review and test

2021-07-05 Thread Xueming(Steven) Li
> -Original Message- > From: Ali Alnubani > Sent: Thursday, July 1, 2021 11:54 PM > To: Xueming(Steven) Li ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Akhil > Goyal ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@i

Re: [dpdk-dev] 20.11.2 patches review and test

2021-07-05 Thread Xueming(Steven) Li
> -Original Message- > From: Jiang, YuX > Sent: Wednesday, June 30, 2021 6:33 PM > To: Xueming(Steven) Li ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Akhil > Goyal ; Ali Alnubani > ; Walker, Benjamin ; David > Christensen ; > Govindharajan, Har

Re: [dpdk-dev] [dpdk-stable] 20.11.2 patches review and test

2021-07-05 Thread Xueming(Steven) Li
> > From: Kalesh Anakkur Purayil > Sent: Tuesday, July 6, 2021 11:27 AM > To: Xueming(Steven) Li > Cc: dpdk stable ; dpdk-dev ; Abhishek Marathe > ; Akhil Goyal ; Ali > Alnubani Subject: Re: [dpdk-stable] 20.11.2 patches review and test > > Hi Xueming, > >

[dpdk-dev] [dpdk-announce] DPDK 20.11.2 released

2021-07-07 Thread Xueming(Steven) Li
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-20.11.2.tar.xz The git tree is at: https://git.dpdk.org/dpdk-stable/log/?h=20.11 Special thanks to Luca for his great help on this version! Xueming Li --- .ci/linux-build.sh |

Re: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor

2021-03-30 Thread Xueming(Steven) Li
>-Original Message- >From: Wang, Haiyue >Sent: Tuesday, February 23, 2021 7:46 PM >To: Stephen Hemminger ; Xueming(Steven) Li > >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: RE: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor &g

Re: [dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunction representor

2021-03-31 Thread Xueming(Steven) Li
Thanks! >-Original Message- >From: Raslan Darawsheh >Sent: Wednesday, March 31, 2021 3:21 PM >To: Xueming(Steven) Li ; Slava Ovsiienko > >Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > >Subject: RE: [dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunc

Re: [dpdk-dev] [PATCH v3 3/5] kvargs: add get by key function

2021-04-01 Thread Xueming(Steven) Li
>-Original Message- >From: Kinsella, Ray >Sent: Thursday, April 1, 2021 5:06 PM >To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon >; Gaetan Rivet > >Cc: dev@dpdk.org; Asaf Penso ; Olivier Matz >; Neil Horman > >Subject: Re: [PATCH v3 3/5] kvargs: add

Re: [dpdk-dev] [PATCH v3 4/5] bus: add device arguments name parsing API

2021-04-01 Thread Xueming(Steven) Li
>-Original Message- >From: Thomas Monjalon >Sent: Wednesday, March 31, 2021 6:20 PM >To: Xueming(Steven) Li >Cc: Gaetan Rivet ; dev@dpdk.org; Asaf Penso >; david.march...@redhat.com; >ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; hemant.ag

Re: [dpdk-dev] [PATCH v2 1/2] pci: rename catch-all ID

2021-04-05 Thread Xueming(Steven) Li
>-Original Message- >From: dev On Behalf Of Thomas Monjalon >Sent: Monday, April 5, 2021 5:15 PM >To: dev@dpdk.org >Cc: Matan Azrad ; Shahaf Shuler ; Slava >Ovsiienko ; Gaetan >Rivet >Subject: [dpdk-dev] [PATCH v2 1/2] pci: rename catch-all ID > >The name of the constant PCI_ANY_ID was

Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

2021-04-05 Thread Xueming(Steven) Li
>-Original Message- >From: dev On Behalf Of Thomas Monjalon >Sent: Monday, April 5, 2021 5:15 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types > >The names of the prototypes pci_probe_t and pci_remove_t are missing a prefix >rte_. >Th

Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

2021-04-06 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 6, 2021 5:39 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation > types > > 06/04/2021 08:32, Xueming(Steven) Li

Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax

2021-04-08 Thread Xueming(Steven) Li
Hi Raslan, Didi you see anything broken? ASAIK, having it in repo shouldn't hurt. On your decision :) Thanks, Xueming > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, April 8, 2021 10:04 PM > To: Slava Ovsiienko ; Xueming(Steven) Li > > Cc: de

Re: [dpdk-dev] [RFC] bus/auxiliary: introduce auxiliary bus

2021-04-12 Thread Xueming(Steven) Li
> +/* > + * Test whether the auxiliary device exist */ bool > +auxiliary_exists(const char *name) { > + DIR *dir; > + char dirname[PATH_MAX]; > + > + snprintf(dirname, sizeof(dirname), "%s/%s", > + rte_auxiliary_get_sysfs_path(), name); > + dir = opendir(rte_auxilia

Re: [dpdk-dev] [PATCH v4 3/5] kvargs: add get by key function

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier Matz > Sent: Monday, April 12, 2021 2:53 PM > To: Xueming(Steven) Li > Cc: NBU-Contact-Thomas Monjalon ; Gaetan Rivet > ; dev@dpdk.org; Asaf Penso > ; Ray Kinsella ; Neil Horman > > Subject: Re: [PATCH v4 3/5] kvar

Re: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Tal Shnaiderman > Sent: Sunday, April 11, 2021 4:00 AM > To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon > ; Gaetan Rivet > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Wenzhuo Lu > ; Beilei Xing ; Bernard

Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 13, 2021 5:17 AM > To: Xueming(Steven) Li > Cc: Gaetan Rivet ; dev@dpdk.org; Asaf Penso > > Subject: Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing > API > >

Re: [dpdk-dev] [PATCH v4 5/5] devargs: parse global device syntax

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 13, 2021 5:25 AM > To: Xueming(Steven) Li > Cc: Gaetan Rivet ; dev@dpdk.org; Xueming(Steven) Li > ; Asaf Penso > ; Ferruh Yigit ; Andrew Rybchenko > > Subject: Re: [dpdk-dev] [PATCH v4

Re: [dpdk-dev] [PATCH] net/virtio: fix vectorized Rx queue stuck

2021-04-13 Thread Xueming(Steven) Li
+@谢华伟(此时此刻) > -Original Message- > From: Xueming Li > Sent: Wednesday, April 14, 2021 12:27 PM > Cc: dev@dpdk.org; Xueming(Steven) Li ; > huawei@intel.com; jerin.ja...@caviumnetworks.com; > d...@linux.vnet.ibm.com; sta...@dpdk.org; Maxime Coquelin > ; Chenb

Re: 20.11.4 patches review and test

2022-01-12 Thread Xueming(Steven) Li
qat: fix queue pairs number > > As this patch relates to new feature introduce in 2021 and is not meant for > 20.11 stable. > Sorry for the problem caused. NP, happy new year! > > Regards, > Fan > > > -Original Message- > > From: Xueming(Steven

Re: 20.11.4 patches review and test

2022-01-12 Thread Xueming(Steven) Li
On Wed, 2022-01-12 at 11:29 +, Jiang, YuX wrote: > > -Original Message- > > From: Xueming(Steven) Li > > Sent: Wednesday, January 12, 2022 7:02 PM > > To: Lin, Xueqin ; sta...@dpdk.org; Zhang, Roy > > Fan > > ; Jiang, YuX > > Cc: Sto

Re: [PATCH 05/12] gen: add raw packet data API and tests

2022-01-21 Thread Xueming(Steven) Li
On Mon, 2021-12-20 at 18:51 +0530, Jerin Jacob wrote: > On Fri, Dec 17, 2021 at 5:10 PM Van Haaren, Harry > wrote: > > > > +CC Thomas; > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, December 15, 2021 12:41 PM > > > To: Randles, Ronan > > > Cc: dpdk-dev ; Va

Re: [PATCH 00/12] add packet generator library and example app

2022-01-21 Thread Xueming(Steven) Li
On Tue, 2021-12-14 at 14:12 +, Ronan Randles wrote: > This patchset introduces a Gen library for DPDK. This library provides an easy > way to generate traffic in order to test software based network components. > > This library enables the basic functionality required in the traffic > generat

Re: [PATCH] vhost: add vDPA resource cleanup callback

2022-01-27 Thread Xueming(Steven) Li
On Wed, 2022-01-26 at 11:03 +0100, Maxime Coquelin wrote: > Hi Xueming, > > On 11/3/21 14:49, Maxime Coquelin wrote: > > > > > > On 11/3/21 14:45, Xueming(Steven) Li wrote: > > > On Wed, 2021-11-03 at 09:46 +0100, Maxime Coquelin wrote: > > > &

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: introduce shared Rx queue

2021-10-11 Thread Xueming(Steven) Li
On Mon, 2021-10-11 at 13:47 +0300, Andrew Rybchenko wrote: > On 9/30/21 5:55 PM, Xueming Li wrote: > > In current DPDK framework, each RX queue is pre-loaded with mbufs for > > RX -> Rx > > > incoming packets. When number of representors scale out in a switch > > domain, the memory consumption be

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-11 Thread Xueming(Steven) Li
On Mon, 2021-10-11 at 14:49 +0300, Andrew Rybchenko wrote: > Hi Xueming, > > On 9/30/21 5:55 PM, Xueming Li wrote: > > In current DPDK framework, all RX queues is pre-loaded with mbufs for > > incoming packets. When number of representors scale out in a switch > > domain, the memory consumption be

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-12 Thread Xueming(Steven) Li
On Mon, 2021-10-11 at 23:11 +0800, Xueming Li wrote: > On Mon, 2021-10-11 at 14:49 +0300, Andrew Rybchenko wrote: > > Hi Xueming, > > > > On 9/30/21 5:55 PM, Xueming Li wrote: > > > In current DPDK framework, all RX queues is pre-loaded with mbufs for > > > incoming packets. When number of represe

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-12 Thread Xueming(Steven) Li
On Tue, 2021-10-12 at 11:48 +0300, Andrew Rybchenko wrote: > On 10/12/21 9:37 AM, Xueming(Steven) Li wrote: > > On Mon, 2021-10-11 at 23:11 +0800, Xueming Li wrote: > > > On Mon, 2021-10-11 at 14:49 +0300, Andrew Rybchenko wrote: > > > > Hi Xueming, > > > &g

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-12 Thread Xueming(Steven) Li
On Tue, 2021-10-12 at 14:28 +0300, Andrew Rybchenko wrote: > On 10/12/21 1:55 PM, Xueming(Steven) Li wrote: > > On Tue, 2021-10-12 at 11:48 +0300, Andrew Rybchenko wrote: > > > On 10/12/21 9:37 AM, Xueming(Steven) Li wrote: > > > > On Mon, 2021-10-11 at 23:11 +0800,

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: retry VAR allocation during vDPA restart

2021-10-13 Thread Xueming(Steven) Li
On Wed, 2021-10-13 at 12:06 +0200, Maxime Coquelin wrote: > > On 9/23/21 10:17, Xueming Li wrote: > > VAR is the device memory space for the virtio queues doorbells, qemu > > could mmap it to directly to speed up doorbell push. > > > > On a busy system, Qemu takes time to release VAR resources du

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-13 Thread Xueming(Steven) Li
On Tue, 2021-10-12 at 14:28 +0300, Andrew Rybchenko wrote: > On 10/12/21 1:55 PM, Xueming(Steven) Li wrote: > > On Tue, 2021-10-12 at 11:48 +0300, Andrew Rybchenko wrote: > > > On 10/12/21 9:37 AM, Xueming(Steven) Li wrote: > > > > On Mon, 2021-10-11 at 23:11 +0800,

Re: [dpdk-dev] [PATCH] driver: i40evf device initialization

2021-10-15 Thread Xueming(Steven) Li
sta...@dpdk.org. Regards, Xueming Li > > Thanks and appreciate the advice, > > Ben Magistro > > On Mon, Sep 13, 2021 at 10:52 PM Ben Magistro > wrote: > > +cc: sta...@dpdk.org > > > > Per discussions here, cc'ing stable for fix to be applied to LTS a

Re: [dpdk-dev] [PATCH v6 1/5] ethdev: introduce shared Rx queue

2021-10-15 Thread Xueming(Steven) Li
On Fri, 2021-10-15 at 12:28 +0300, Andrew Rybchenko wrote: > On 10/12/21 5:39 PM, Xueming Li wrote: > > In current DPDK framework, each Rx queue is pre-loaded with mbufs to > > save incoming packets. For some PMDs, when number of representors scale > > out in a switch domain, the memory consumption

Re: [dpdk-dev] [PATCH v1 1/2] vdpa/mlx5: workaround FW first completion in start

2021-10-15 Thread Xueming(Steven) Li
On Fri, 2021-10-15 at 15:57 +0200, Maxime Coquelin wrote: > > On 10/15/21 15:43, Xueming Li wrote: > > After a vDPA application restart, qemu restores VQ with used and > > available index, new incoming packet triggers virtio driver to > > handle buffers. Under heavy traffic, no available buffer fo

Re: [dpdk-dev] [PATCH v6 1/5] ethdev: introduce shared Rx queue

2021-10-16 Thread Xueming(Steven) Li
On Fri, 2021-10-15 at 18:20 +0100, Ferruh Yigit wrote: > On 10/12/2021 3:39 PM, Xueming Li wrote: > > index 6d80514ba7a..041da6ee52f 100644 > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -1044,6 +1044,13 @@ struct rte_eth_rxconf { > > uint8_t rx_drop_en; /**< Drop pa

Re: [dpdk-dev] [PATCH v7 1/5] ethdev: introduce shared Rx queue

2021-10-17 Thread Xueming(Steven) Li
On Sat, 2021-10-16 at 22:33 -0700, Ajit Khaparde wrote: > On Sat, Oct 16, 2021 at 1:43 AM Xueming Li wrote: > > > > In current DPDK framework, each Rx queue is pre-loaded with mbufs to > > save incoming packets. For some PMDs, when number of representors scale > > out in a switch domain, the memo

Re: [dpdk-dev] [PATCH v6 1/5] ethdev: introduce shared Rx queue

2021-10-18 Thread Xueming(Steven) Li
On Mon, 2021-10-18 at 09:46 +0300, Andrew Rybchenko wrote: > On 10/15/21 1:54 PM, Xueming(Steven) Li wrote: > > On Fri, 2021-10-15 at 12:28 +0300, Andrew Rybchenko wrote: > > > On 10/12/21 5:39 PM, Xueming Li wrote: > > > > In current DPDK framework, each Rx que

Re: [dpdk-dev] [PATCH v8 0/6] ethdev: introduce shared Rx queue

2021-10-18 Thread Xueming(Steven) Li
Sorry, forgot to reply to original thread, resent. Please ignore this series. On Mon, 2021-10-18 at 20:08 +0800, Xueming Li wrote: > In current DPDK framework, all Rx queues is pre-loaded with mbufs for > incoming packets. When number of representors scale out in a switch > domain, the m

Re: [dpdk-dev] [PATCH v8 1/6] ethdev: introduce shared Rx queue

2021-10-18 Thread Xueming(Steven) Li
On Mon, 2021-10-18 at 17:21 -0700, Ajit Khaparde wrote: > On Mon, Oct 18, 2021 at 6:00 AM Xueming Li wrote: > > > > In current DPDK framework, each Rx queue is pre-loaded with mbufs to > > save incoming packets. For some PMDs, when number of representors scale > > out in a switch domain, the memo

Re: [dpdk-dev] [PATCH v9 2/6] app/testpmd: dump device capability and Rx domain info

2021-10-19 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 11:33 +0300, Andrew Rybchenko wrote: > On 10/19/21 11:17 AM, Xueming Li wrote: > > Dump device capability and Rx domain ID if shared Rx queue is supported > > by device. > > > > Signed-off-by: Xueming Li > > LGTM except one minor note: > > Acked-by: Andrew Rybchenko > >

Re: [dpdk-dev] [PATCH v1 3/3] test/devargs: add devargs test cases

2021-10-20 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 17:07 +0200, Gaëtan Rivet wrote: > On Tue, Oct 5, 2021, at 17:54, Xueming Li wrote: > > Initial version to test Global devargs syntax. > > > > Signed-off-by: Xueming Li > > Hi, > > The test is a very nice addition, absolutely required. > I have however two remarks on the c

Re: [dpdk-dev] [PATCH v2 3/3] test/devargs: add devargs test cases

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 09:38 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 9:32 AM Xueming Li wrote: > > > > Initial version to test Global devargs syntax. > > > > Signed-off-by: Xueming Li > > --- > > app/test/autotest_data.py | 803 ++ > > This fil

Re: [dpdk-dev] [PATCH v3 3/3] test/devargs: add devargs test cases

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 11:08 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 10:22 AM Xueming Li wrote: > > > > Initial version to test Global devargs syntax. > > > > Signed-off-by: Xueming Li > > 10/95 DPDK:fast-tests / devargs_autotest FAIL 0.17 s (exit > status 255 or signal

Re: [dpdk-dev] [PATCH v10 2/7] ethdev: new API to resolve device capability name

2021-10-20 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 20:57 +0300, Andrew Rybchenko wrote: > On 10/19/21 6:28 PM, Xueming Li wrote: > > This patch adds API to return name of device capability. > > > > Signed-off-by: Xueming Li > > [snip] > > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > > index bc55f899f7

Re: [dpdk-dev] [PATCH v3 0/8] net/mlx5: support more than 255 representors

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 13:40 +, Raslan Darawsheh wrote: > Hi, > > > -Original Message- > > From: dev On Behalf Of Xueming Li > > Sent: Tuesday, October 19, 2021 1:35 PM > > To: dev@dpdk.org > > Cc: Xueming(Steven) Li ; Slava Ovsiienko > &g

Re: [dpdk-dev] [PATCH v4 3/3] test/devargs: add devargs test cases

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 13:55 +0200, Gaëtan Rivet wrote: > On Wed, Oct 20, 2021, at 13:12, Xueming Li wrote: > > Initial version to test global devargs syntax. > > > > Signed-off-by: Xueming Li > > --- > > app/test/meson.build| 5 ++ > > app/test/test_devargs.c | 184

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 21:14 +0200, Thomas Monjalon wrote: > 20/10/2021 19:29, Ajit Khaparde: > > On Wed, Oct 20, 2021 at 12:54 AM Xueming Li wrote: > > > > > > Adds "--rxq-share=X" parameter to enable shared RxQ, > > You should end the sentence here. > > > > share if device > > > supports, othe

Re: [dpdk-dev] [PATCH v11 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 21:20 +0200, Thomas Monjalon wrote: > 20/10/2021 09:53, Xueming Li: > > To support shared Rx queue, this patch introduces dedicate forwarding > > engine. The engine groups received packets by mbuf->port into sub-group, > > updates stream statistics and simply frees packets. >

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-21 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 10:29 -0700, Ajit Khaparde wrote: > On Wed, Oct 20, 2021 at 12:54 AM Xueming Li wrote: > > > > Adds "--rxq-share=X" parameter to enable shared RxQ, share if device > > supports, otherwise fallback to standard RxQ. > > > > Share group number grows per X ports. X defaults to

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 03:24 +, Li, Xiaoyun wrote: > Hi > > > -Original Message- > > From: Xueming Li > > Sent: Wednesday, October 20, 2021 15:53 > > To: dev@dpdk.org; Zhang, Yuying > > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > > ; Andrew Rybchenko > > ; Viacheslav Ovsiie

Re: [dpdk-dev] [PATCH v11 6/7] app/testpmd: force shared Rx queue polled on same core

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 03:24 +, Li, Xiaoyun wrote: > Hi > > > -Original Message- > > From: Xueming Li > > Sent: Wednesday, October 20, 2021 15:53 > > To: dev@dpdk.org; Zhang, Yuying > > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > > ; Andrew Rybchenko > > ; Viacheslav Ovsiie

Re: [dpdk-dev] [PATCH v12 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 06:33 +, Li, Xiaoyun wrote: > > -Original Message- > > From: Xueming Li > > Sent: Thursday, October 21, 2021 13:09 > > To: dev@dpdk.org; Zhang, Yuying ; Li, > > Xiaoyun > > > > Cc: xuemi...@nvidia.com; Jerin Jacob ; > > Yigit, Ferruh > > ; Andrew Rybchenko > > ;

Re: [dpdk-dev] [PATCH v12 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 08:01 +, Li, Xiaoyun wrote: > > > -Original Message- > > From: Xueming(Steven) Li > > Sent: Thursday, October 21, 2021 15:59 > > To: Li, Xiaoyun ; Zhang, Yuying > > ; dev@dpdk.org > > Cc: Ananyev, Konstantin ; > &

Re: [dpdk-dev] [PATCH v5 0/3] devargs: support path in global syntax

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 11:22 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 5:47 PM Xueming Li wrote: > > > > - Support path in global syntax. > > - Fix bus name resolving > > - Add devargs test cases > > > > v1: initial version > > v2: > > - add test cases to test suite > > - add more

Re: [dpdk-dev] [PATCH] vhost: add vDPA resource cleanup callback

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 14:00 +0200, Maxime Coquelin wrote: > Hi Xueming, > > On 10/19/21 13:39, Xueming Li wrote: > > This patch adds vDPA device cleanup callback to release resources on > > vhost user connection close. > > > > Signed-off-by: Xueming Li > > --- > > lib/vhost/rte_vdpa_dev.h | 3

Re: [dpdk-dev] [PATCH v2 1/2] vdpa/mlx5: workaround FW first completion in start

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 14:27 +0200, Maxime Coquelin wrote: > > On 10/15/21 17:05, Xueming Li wrote: > > After a vDPA application restart, qemu restores VQ with used and > > available index, new incoming packet triggers virtio driver to > > handle buffers. Under heavy traffic, no available buffer fo

Re: [dpdk-dev] [PATCH v13 0/7] ethdev: introduce shared Rx queue

2021-10-22 Thread Xueming(Steven) Li
On Fri, 2021-10-22 at 00:41 +0100, Ferruh Yigit wrote: > On 10/21/2021 11:41 AM, Xueming Li wrote: > > In current DPDK framework, all Rx queues is pre-loaded with mbufs for > > incoming packets. When number of representors scale out in a switch > > domain, the memory consumption became significant.

Re: [dpdk-dev] [PATCH v5 3/3] test/devargs: add devargs test cases

2021-10-23 Thread Xueming(Steven) Li
On Sat, 2021-10-23 at 08:17 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 5:48 PM Xueming Li wrote: > > + kvlist = rte_kvargs_parse(args, NULL); > > + if (kvlist == NULL) { > > + printf("rte_devargs_parse(%s) %s_str: %s not parsed\n", > > + d

Re: [dpdk-dev] [PATCH v7 1/6] ethdev: fix max Rx packet length

2021-11-05 Thread Xueming(Steven) Li
On Mon, 2021-10-18 at 18:31 +0100, Ferruh Yigit wrote: > On 10/18/2021 2:48 PM, Ferruh Yigit wrote: > > There is a confusion on setting max Rx packet length, this patch aims to > > clarify it. > > > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > > 'uint32_t max_rx_pkt_len' field

Re: [dpdk-dev] [PATCH v3] net/i40e: fix i40evf device initialization

2021-11-08 Thread Xueming(Steven) Li
On Tue, 2021-10-12 at 14:17 +, Ben Magistro wrote: > The i40evf driver is not initializing the eth_dev attribute which > can result in a nullptr dereference. Changes were modeled after the > iavf_dev_init() per suggestion from the mailing list[1]. > > [1] https://mails.dpdk.org/archives/dev/20

Re: [dpdk-dev] [PATCH] net/i40e: fix vf rxq buf size alignment

2021-11-08 Thread Xueming(Steven) Li
On Mon, 2021-09-06 at 15:00 +0800, Qiming Chen wrote: > The RTE_ALIGN macro is aligned upwards. If the buf_size variable is not > aligned with 1 << I40E_RXQ_CTX_DBUFF_SHIFT, the rx_buf_len is larger than > the actual mbuf memory after the operation. When receiving the packet, if > the packet is lar

Re: [dpdk-dev] [PATCH] net/virtio: wait device ready in device reset

2021-09-15 Thread Xueming(Steven) Li
On Thu, 2021-08-26 at 07:15 +, Xia, Chenbo wrote: > Hi Adrew & Xueming, > > > -Original Message- > > From: Andrew Rybchenko > > Sent: Tuesday, August 24, 2021 11:41 PM > > To: Xueming(Steven) Li > > Cc: dev@dpdk.org; Maxime Coquelin ; Xia

Re: [dpdk-dev] [PATCH v1] net/virtio: wait device ready during reset

2021-09-15 Thread Xueming(Steven) Li
On Wed, 2021-09-15 at 12:27 +0300, Andrew Rybchenko wrote: > On 9/15/21 12:21 PM, Xueming Li wrote: > > According to virtio spec, the device MUST reset when 0 is written to > > device_status, and present 0 in device_status once reset is done. > > > > This patch waits status value to be 0 during re

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-15 Thread Xueming(Steven) Li
On Wed, 2021-08-11 at 12:59 +, Xueming(Steven) Li wrote: > > > -Original Message- > > From: Ferruh Yigit > > Sent: Wednesday, August 11, 2021 8:04 PM > > To: Xueming(Steven) Li ; Jerin Jacob > > > > Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-09-15 Thread Xueming(Steven) Li
Hi Jerin, On Mon, 2021-08-30 at 15:01 +0530, Jerin Jacob wrote: > On Sat, Aug 28, 2021 at 7:46 PM Xueming(Steven) Li > wrote: > > > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Thursday, August 26, 2021 7:58

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-16 Thread Xueming(Steven) Li
On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > 15/09/2021 15:02, Xueming Li: > > To align with other eth device queue configuration callbacks, cleanup > > queue release callback API by changing RX and TX queue release callback > > API parameter from queue object to device and queue ind

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-17 Thread Xueming(Steven) Li
On Thu, 2021-09-16 at 17:50 +0200, Thomas Monjalon wrote: > 16/09/2021 17:43, Xueming(Steven) Li: > > On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > > > 15/09/2021 15:02, Xueming Li: > > > > --- a/lib/ethdev/rte_ethdev.c > &g

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: queue release callback optional

2021-09-17 Thread Xueming(Steven) Li
On Fri, 2021-09-17 at 14:53 +0300, Andrew Rybchenko wrote: > On 9/17/21 2:29 PM, Andrew Rybchenko wrote: > > On 9/17/21 12:39 PM, Xueming Li wrote: > > > Some drivers don't need Rx and Tx queue release callback, make it > > > optional. > > > > > > Signed-off-by: Xueming Li > > > > LGTM, but plea

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: change queue release callback

2021-09-17 Thread Xueming(Steven) Li
On Fri, 2021-09-17 at 14:49 +0300, Andrew Rybchenko wrote: > On 9/17/21 12:39 PM, Xueming Li wrote: > > Currently, most ethdev callback api use queue ID as parameter, but Rx > > api -> API > > > and Tx queue release callback use queue object which is used in Rx and > > Tx burst data plane callbac

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: change queue release callback

2021-09-18 Thread Xueming(Steven) Li
On Sat, 2021-09-18 at 09:50 +0300, Andrew Rybchenko wrote: > On 9/17/21 5:28 PM, Xueming Li wrote: > > Currently, most ethdev callback API use queue ID as parameter, but Rx > > and Tx queue release callback use queue object which is used by Rx and > > Tx burst data plane callback. > > > > To align

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Xueming(Steven) Li
Hi Ferruh, Appreciate for the careful check! On Tue, 2021-09-21 at 19:13 +0100, Ferruh Yigit wrote: > On 9/18/2021 1:35 PM, Xueming Li wrote: > > Currently, most ethdev callback API use queue ID as parameter, but Rx > > and Tx queue release callback use queue object which is used by Rx and > > T

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: > > > > > > <...> > > > > > > > void > > > > -i40e_dev_rx_queue_release(void *rxq) > > > > +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) > > > > +{ > > > > + i40e_rx_queue_release(dev->data->rx_queues[qid]); > > > >

Re: [dpdk-dev] [PATCH v1] sched: adds function to get 64 bits greatest common divisor

2021-09-22 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 18:09 +0100, Kevin Traynor wrote: > On 15/09/2021 11:26, Xueming Li wrote: > > This patch adds new function that compute the greatest common > > divisor of 64 bits, also changes the original 32 bits function to call > > this new 64 bits version. > > > > Can you say why it is

Re: [dpdk-dev] [PATCH v2 0/2] mlx5: support global device syntax

2021-09-22 Thread Xueming(Steven) Li
On Mon, 2021-09-20 at 10:07 +0200, Thomas Monjalon wrote: > 18/01/2021 16:26, Xueming Li: > > Xueming Li (2): > > common/mlx5: support device global syntax > > net/mlx5: support new global device syntax > > > > drivers/common/mlx5/mlx5_common_pci.c | 6 +- > > drivers/net/mlx5/mlx5.c

Re: [dpdk-dev] [PATCH 0/5] kvargs: promote or remove experimental api

2021-09-25 Thread Xueming(Steven) Li
On Fri, 2021-09-24 at 17:57 +0200, Olivier Matz wrote: > This patchset promotes 2 functions rte_kvargs_parse_delim() and > rte_kvargs_get() as stable. > > It also replaces rte_kvargs_strcmp() by a new one > rte_kvargs_get_with_value(), which is easier to use. > > Olivier Matz (5): > kvargs: pro

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-25 Thread Xueming(Steven) Li
On Wed, 2021-08-11 at 13:04 +0100, Ferruh Yigit wrote: > On 8/11/2021 9:28 AM, Xueming(Steven) Li wrote: > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, August 11, 2021 4:03 PM > > > To: Xueming(Steven)

  1   2   3   4   5   >