>
>
> http://video.fosdem.org/2015/devroom-network_management_and_sdn/
> <http://video.fosdem.org/2015/devroom-network_management_and_sdn/>
>
> On Wed, Apr 8, 2015 at 9:35 AM, Aaron Campbell <mailto:aaron at arbor.net>> wrote:
> Hi,
>
> I have a machine
Acked-by: Aaron Campbell mailto:aaron at arbor.net>>
Minor comments inline below, I don?t need to see another patch.
Thanks,
-Aaron
> On Nov 4, 2014, at 5:40 PM, Thomas Monjalon
> wrote:
>
> + RTE_LOG(ERR, EAL, "please spec
> On Nov 4, 2014, at 3:00 PM, Thomas Monjalon
> wrote:
>
> 2014-11-03 13:02, Aaron Campbell:
>>> On Jul 8, 2014, at 5:28 AM, Simon Kuenzer
>>> wrote:
>>>
>>> + else if (!strcmp(
Hi Simon,
Thanks for the patch, this will be useful for us. I responded separately to
your original post with one suggestion.
Our application currently assumes that DPDK will assign the first bit set in
the coremask to the master lcore. As far as I can tell, this is hard-coded as
of 1.7.1.
> On Jul 8, 2014, at 5:28 AM, Simon Kuenzer wrote:
>
> + else if (!strcmp(lgopts[option_index].name,
> OPT_MASTER_LCORE)) {
> + if (!coremask_ok) {
> + RTE_LOG(ERR, EAL, "please specify the
> master "
> +
On Jun 26, 2014, at 12:09 PM, Richardson, Bruce
wrote:
>> I agree we should try to use the "deprecated" attribute when possible.
>> So application porting effort will be smoother.
>>
>> But in this case, there is something different: as Stephen wrote,
>> rte_snprintf
>> is useless. It's
already been freed. So move the closedir() call lower.
Signed-off-by: Aaron Campbell
---
lib/librte_eal/linuxapp/eal/eal_lcore.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_lcore.c
b/lib/librte_eal/linuxapp/eal/eal_lcore.c
index
hat Pablo De Lara has beat you to it by a few minutes :-) Are there
> any other places this could potentially happen?
>
>> Must reset errno to zero before calling strtoull(), else on success it could
>> be
>> any arbitrary value from past errors.
>>
>>
Must reset errno to zero before calling strtoull(), else on success it
could be any arbitrary value from past errors.
Signed-off-by: Aaron Campbell
---
lib/librte_eal/linuxapp/eal/eal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal.c
b/lib/librte_eal
9 matches
Mail list logo