[dpdk-dev] [PATCH v3] nfp: report link speed using hardware info

2016-12-02 Thread Alejandro Lucero
Previous reported speed was hardcoded. v3: remove unsed macro v2: using RTE_DIM instead of own macro Signed-off-by: Alejandro Lucero <alejandro.luc...@netronome.com> --- drivers/net/nfp/nfp_net.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v2] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-12-01 Thread Alejandro Lucero
On Mon, Nov 28, 2016 at 11:13 AM, Thomas Monjalon wrote: > 2016-11-24 17:59, Olivier Matz: > > Hi, > > > > On Mon, 2016-11-21 at 09:59 +0000, Alejandro Lucero wrote: > > > From: Bert van Leeuwen > > > > > > Arrays inside rte_eth_stats have size

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-21 Thread Alejandro Lucero
On Mon, Nov 21, 2016 at 11:18 AM, Ferruh Yigit wrote: > On 11/18/2016 4:06 PM, Alejandro Lucero wrote: > > Previous reported speed was hardcoded. > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 28

[dpdk-dev] [PATCH v2] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-11-21 Thread Alejandro Lucero
using MIN between the reported number of queues and RTE_ETHDEV_QUEUE_STAT_CNTRS. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_et

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 4:29 PM, Thomas Monjalon wrote: > 2016-11-18 16:06, Alejandro Lucero: > > Previous reported speed was hardcoded. > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 28 ++-- > &g

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
Previous reported speed was hardcoded. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 ++-- drivers/net/nfp/nfp_net_ctrl.h | 13 + 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 3:31 PM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit > wrote: > >> On 11/18/2016 3:10 PM, Alejandro Lucero wrote: >> > Hi Thomas, >> > >> >

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 3:26 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report t

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report t

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
Nov 18, 2016 at 3:04 PM Subject: |WARNING| [PATCH] nfp: report link speed using hardware info To: test-report at dpdk.org Cc: Alejandro Lucero Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17091 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possibl

[dpdk-dev] [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
Previous reported speed was hardcoded. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 31 +-- drivers/net/nfp/nfp_net_ctrl.h | 13 + 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers

[dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-11-11 Thread Alejandro Lucero
On Fri, Nov 11, 2016 at 9:29 AM, Thomas Monjalon wrote: > 2016-11-11 09:16, Alejandro Lucero: > > Thomas, > > > > We are wondering if you realize this patch fixes a bug with current > ethdev > > code as a device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS. &g

[dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-11-11 Thread Alejandro Lucero
email thread the discussion of how to solve the RTE_ETHDEV_QUEUE_STAT_CNTRS problem. Should we remove this from patchwork and to send another patch that way? On Thu, Nov 10, 2016 at 4:04 PM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Thu, Nov 10, 2016 at

[dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-11-10 Thread Alejandro Lucero
On Thu, Nov 10, 2016 at 4:01 PM, Thomas Monjalon wrote: > 2016-11-10 15:43, Alejandro Lucero: > > On Thu, Nov 10, 2016 at 2:42 PM, Thomas Monjalon < > thomas.monjalon at 6wind.com> > > wrote: > > > > > 2016-11-10 14:00, Alejandro Lucero: > > > &g

[dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-11-10 Thread Alejandro Lucero
On Thu, Nov 10, 2016 at 2:42 PM, Thomas Monjalon wrote: > 2016-11-10 14:00, Alejandro Lucero: > > From: Bert van Leeuwen > > > > A device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS queues which > > is used inside struct rte_eth_stats. Id

[dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-11-10 Thread Alejandro Lucero
_stats for allowing dynamically allocated arrays and maybe some extra fields for keeping the array sizes. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c

[dpdk-dev] Fwd: mbuf changes

2016-11-10 Thread Alejandro Lucero
I forgot to include dev at dpdk.org in my response. My comment at the end o this email. On Wed, Oct 26, 2016 at 10:28 AM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Tue, Oct 25, 2016 at 2:05 PM, Bruce Richardson < > bruce.richardson at intel.co

[dpdk-dev] mbuf changes

2016-11-09 Thread Alejandro Lucero
On Wed, Oct 26, 2016 at 10:28 AM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Tue, Oct 25, 2016 at 2:05 PM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > >> On Tue, Oct 25, 2016 at 05:24:28PM +0530, Shreyansh Jain wrote:

[dpdk-dev] mbuf changes

2016-10-26 Thread Alejandro Lucero
On Tue, Oct 25, 2016 at 2:05 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Oct 25, 2016 at 05:24:28PM +0530, Shreyansh Jain wrote: > > On Monday 24 October 2016 09:55 PM, Bruce Richardson wrote: > > > On Mon, Oct 24, 2016 at 04:11:33PM +, Wiles, Keith wrote: > > > > >

[dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing

2016-09-16 Thread Alejandro Lucero
With an app using hotplug feature, when a device is unplugged without unregistering makes the interrupt handling unstable. Fixes: 6c53f87b3497 ("nfp: add link status interrupt") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 5 + 1 file changed, 5 insertions(+)

[dpdk-dev] [PATCH v2] nfp: fixing bug when copying MAC address

2016-09-16 Thread Alejandro Lucero
Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 1948a12..d79f0a1 100644 ---

[dpdk-dev] [PATCH v2] nfp: using random MAC address if not configured

2016-09-16 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 82e3e4e..1948a12 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net

[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

2016-09-16 Thread Alejandro Lucero
Thank you for the feedback. I'll send the fixed patched today. On Tue, Sep 13, 2016 at 8:30 PM, Thomas Monjalon wrote: > 2016-09-13 18:10, Ferruh Yigit: > > Hi Alejandro, > > > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > > > S

[dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform

2016-09-04 Thread Alejandro Lucero
I know RedHat is working on a vIOMMU so I guess this work is related to that effort, but it is a surprise virtio using IOMMU. I thought IOMMU just made sense when using SRIOV. My second guess is using IOMMU with virtio is a matter of security, but by other hand, virtio + IOMMU could imply serious

[dpdk-dev] [PATCH] nfp: unregister interrupt callback function when closing device

2016-08-16 Thread Alejandro Lucero
With an app using hotplug feature, when a device is unplugged without unregistering makes the interrupt handling unstable. Fixes: 6c53f87b3497 ("nfp: add link status interrupt") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 5 + 1 file changed, 5 insertions(+)

[dpdk-dev] [PATCH] nfp: fixing bug when copying mac address

2016-08-16 Thread Alejandro Lucero
Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 45d122d..229c8e6 100644 ---

[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

2016-08-16 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 82e3e4e..45d122d 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net

[dpdk-dev] memory allocation requirements

2016-05-18 Thread Alejandro Lucero
On Wed, Apr 13, 2016 at 5:03 PM, Thomas Monjalon wrote: > After looking at the patches for container support, it appears that > some changes are needed in the memory management: > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/32786/focus=32788 > > I think it is time to collect what

[dpdk-dev] [dpdk-dev, 2/3] eth_dev: add support for device dma mask

2016-05-13 Thread Alejandro Lucero
to leave a white line before my replies. > See below... > > On Thu, 12 May 2016 16:03:14 +0100 > Alejandro Lucero wrote: > > > Hi Jan > > > > On Thu, May 12, 2016 at 3:52 PM, Jan Viktorin > > wrote: > > > > > Hello Alejandro, > > >

[dpdk-dev] [dpdk-dev,3/3] nfp: set device dma mask

2016-05-12 Thread Alejandro Lucero
t;. > > That is a good idea. I was thinking on adding a memseg dump info as well which would help to understand this issue and other related to memory allocation. > > > > Signed-off-by: Alejandro Lucero > > > > --- > > drivers/net/nfp/nfp_net.c | 11

[dpdk-dev] [dpdk-dev, 2/3] eth_dev: add support for device dma mask

2016-05-12 Thread Alejandro Lucero
he beginning of line. As for me > I prefer a fluent text describing the purpose. The '-' is useful for > a real list of notes. > > > > > Signed-off-by: Alejandro Lucero > > > > --- > > lib/librte_ether/rte_ethdev.c | 7 +++ > > lib/librte_ether/rte_

[dpdk-dev] [PATCH 3/3] nfp: set device dma mask

2016-05-12 Thread Alejandro Lucero
- Just hugepages within the supported range will be available. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index ea5a2a3..e0e444a 100644 --- a/drivers/net

[dpdk-dev] [PATCH 2/3] eth_dev: add support for device dma mask

2016-05-12 Thread Alejandro Lucero
- New dma_mask field in rte_eth_dev_data. - If PMD sets device dma_mask, call to check hugepages within supported range. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.c | 7 +++ lib/librte_ether/rte_ethdev.h | 1 + 2 files changed, 8 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH 1/3] eal/linux: add function for checking hugepages within device supported address range

2016-05-12 Thread Alejandro Lucero
- This is needed for avoiding problems with devices not being able to address all the physical available memory. Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/include/rte_memory.h | 6 ++ lib/librte_eal/linuxapp/eal/eal_memory.c | 27 +++ 2 files

[dpdk-dev] [PATCH 0/3] add support for devices with addressing limitations

2016-05-12 Thread Alejandro Lucero
and the amount of them the checking could slow down initialization. If a device has not addressing limitations the checking is not done. Third patch adds support for setting dma mask in the PMD NFP. Current NFP card just supports 40 bits. Future versions will support 64 bits. Alejandro Lucero (3

[dpdk-dev] [PATCH v1] igu_uio: fix IOMMU domain issue

2016-05-11 Thread Alejandro Lucero
On Tue, May 10, 2016 at 4:59 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Tue, 10 May 2016 19:21:41 +0800 > Zhe Tao wrote: > > > Problem: > > The following operations will cause the igb_uio based DPDK > > operation failed. > > --Any device assignment through the

[dpdk-dev] [PATCH] nfp: avoiding concurrency when hardware reconfig

2016-05-03 Thread Alejandro Lucero
Hi Bruce, Sorry about this. I sent a v2 for this patch but not in the same thread: http://www.dpdk.org/ml/archives/dev/2016-April/037996.html On Tue, May 3, 2016 at 12:01 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Apr 26, 2016 at 01:14:15PM +0100, Alejand

[dpdk-dev] [PATCH] nfp: add flag for enabling device hotplug

2016-04-26 Thread Alejandro Lucero
RTE_PCI_DRV_DETACHABLE is required for detaching a device during execution. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 1259d2c..ea5a2a3 100644

[dpdk-dev] [PATCH] nfp: fixing a bug when gather

2016-04-26 Thread Alejandro Lucero
mbufs where not properly released when they are chained. Fixes: b812daadad0d ("nfp: add Rx and Tx") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/d

[dpdk-dev] [PATCH v2] nfp: avoiding concurrency when hardware reconfig

2016-04-26 Thread Alejandro Lucero
the firmware will stop and a device reset is necessary. - v2: header file to the right place Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 drivers/net/nfp/nfp_net_pmd.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp

[dpdk-dev] [PATCH] nfp: avoiding concurrency when hardware reconfig

2016-04-26 Thread Alejandro Lucero
the firmware will stop and a device reset is necessary. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 drivers/net/nfp/nfp_net_pmd.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index bc0a3d8..ba0ee04 100644

[dpdk-dev] [PATCH] nfp: modifying guide about using uio modules

2016-04-26 Thread Alejandro Lucero
- Removing dependency on nfp_uio kernel module. The igb_uio kernel modules can be used instead. Fixes: 80bc1752f16e ("nfp: add guide") Signed-off-by: Alejandro Lucero --- doc/guides/nics/nfp.rst | 47 --- 1 file changed, 16 inserti

[dpdk-dev] [PATCH v13 5/8] ethdev: add speed capabilities

2016-03-29 Thread Alejandro Lucero
For nfp.c, speed_capa should be ETH_LINK_SPEED_40G instead of ETH_LINK_SPEED_50G. By the way, the change in patch 4 sets the right link speed using the new constants. Regards On Sat, Mar 26, 2016 at 1:27 AM, Marc Sune wrote: > The speed capabilities of a device can be retrieved with >

[dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev

2016-03-29 Thread Alejandro Lucero
Hi guys, Sorry for the delay but I was on a Easter break. That patch is OK for me. In fact, I had one patch ready for upstreaming with this change needed for supporting hotplug. I was waiting for some feedback from one internal project needing this hotplug functionality before submitting.

[dpdk-dev] [PATCH] nfp: fix tx queue reset

2016-03-14 Thread Alejandro Lucero
When using start-stop functionality the per queue fields need to be properly reset. Fixes: b812daadad0d (\"nfp: add Rx and Tx\") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/nfp/nfp_net.c b/drive

[dpdk-dev] [PATCH] nfp: fix how tx checksum is advertised to firmware

2016-03-03 Thread Alejandro Lucero
Even with tx checksum offload available, do not set the flag by default. Fixes: b812daadad0d (\"nfp: add Rx and Tx\") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/d

[dpdk-dev] [PATCH v2] nfp: fix variable type in tx checksum offload

2016-03-03 Thread Alejandro Lucero
The mbuf ol_flags field was changed to uin64_t with DPDK version 1.8 Fixes: b812daadad0d (\"nfp: add Rx and Tx\") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drive

[dpdk-dev] [PATCH] nfp: tx checksum offload fixes

2016-03-03 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index fd4dd39..6078e9f 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -1522,7

[dpdk-dev] thoughts on DPDK after a few days of reading sources

2016-02-11 Thread Alejandro Lucero
Hi Seth, I do not know if you and Ubuntu know about the kernel VFIO no-iommu mode which DPDK will use in the future (then getting rid of UIO drives). This implies distributions enabling that kernel VFIO mode which is not enable by default as it is a security issue. It would be good to know

[dpdk-dev] [PATCH] nfp: fix non-x86 build

2016-02-08 Thread Alejandro Lucero
On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon wrote: > The file sys/io.h was included but it can be unavailable in some > non-x86 toolchains. > As others system includes in the file nfp_net.c, it seems useless, > so the easy fix is to remove them. > > Signed-off-by: Thomas Monjalon > --- >

[dpdk-dev] VFIO no-iommu

2015-12-15 Thread Alejandro Lucero
Hi, I know a bit about VFIO implementation, have been debugging IOMMU (intel) problems, know how QEMU/KVM work about using legacy or vfio attached devices, and I'm the maintainer of a DPDK PMD recently accepted upstream which requires our particular UIO driver (not maintained upstream). So I

[dpdk-dev] [PATCH v10 8/8] nfp: adding nic guide

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- MAINTAINERS |1 + doc/guides/nics/index.rst |1 + doc/guides/nics/nfp.rst | 265 + 3 files changed, 267 insertions(+) create mode 100644 doc/guides/nics

[dpdk-dev] [PATCH v10 7/8] nfp: link status change interrupt support

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 123 + 1 file changed, 123 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index ff9a8d6..bc2089f 100644 --- a/drivers

[dpdk-dev] [PATCH v10 6/8] nfp: adding extra functionality

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 191 + 1 file changed, 191 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 7c82e96..ff9a8d6 100644 --- a/drivers

[dpdk-dev] [PATCH v10 5/8] nfp: adding link functionality

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 96 + 1 file changed, 96 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 0912064..7c82e96 100644 --- a/drivers/net

[dpdk-dev] [PATCH v10 4/8] nfp: adding stats

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 179 + 1 file changed, 179 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index a9be403..0912064 100644 --- a/drivers

[dpdk-dev] [PATCH v10 3/8] nfp: adding rss

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 218 + 1 file changed, 218 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 0d85fa4..a9be403 100644 --- a/drivers

[dpdk-dev] [PATCH v10 2/8] nfp: adding rx/tx functionality

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 993 + 1 file changed, 993 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index b9240db..0d85fa4 100644 --- a/drivers

[dpdk-dev] [PATCH v10 1/8] nfp: basic initialization

2015-11-30 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- MAINTAINERS |3 + config/common_linuxapp |6 + doc/guides/rel_notes/release_2_2.rst|3 + drivers/net/Makefile|1 + drivers/net/nfp/Makefile

[dpdk-dev] [PATCH v10 0/8] support for netronome nfp-6xxx card

2015-11-30 Thread Alejandro Lucero
style guide. - Documentation changes using the right rst format. - Moving the documentation files to a new patch file. - Adding info to MAINTAINERS and release files. Alejandro Lucero (8): nfp: basic initialization nfp: adding rx/tx functionality nfp: adding rss nfp: adding stats nfp

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

2015-11-27 Thread Alejandro Lucero
< stephen at networkplumber.org> wrote: > On Thu, 26 Nov 2015 09:49:21 + > Alejandro Lucero wrote: > > > +static inline void > > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val) > > +{ > > + uint32_t off; > > Minor nit. why mix use of Linux sp

[dpdk-dev] [PATCH v9 8/9] nfp: adding nic guide

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- doc/guides/nics/index.rst |1 + doc/guides/nics/nfp.rst | 265 + 2 files changed, 266 insertions(+) create mode 100644 doc/guides/nics/nfp.rst diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v9 7/9] nfp: link status change interrupt support

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 123 + 1 file changed, 123 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 5383f51..3763790 100644 --- a/drivers

[dpdk-dev] [PATCH v9 6/9] nfp: adding extra functionality

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 191 + 1 file changed, 191 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 567ea26..5383f51 100644 --- a/drivers

[dpdk-dev] [PATCH v9 5/9] nfp: adding link functionality

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 96 + 1 file changed, 96 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index fc02916..567ea26 100644 --- a/drivers/net

[dpdk-dev] [PATCH v9 4/9] nfp: adding stats

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 179 + 1 file changed, 179 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 8451a49..fc02916 100644 --- a/drivers

[dpdk-dev] [PATCH v9 3/9] nfp: adding rss

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 218 + 1 file changed, 218 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 7e30774..8451a49 100644 --- a/drivers

[dpdk-dev] [PATCH v9 2/9] nfp: adding rx/tx functionality

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- drivers/net/nfp/nfp_net.c | 993 + 1 file changed, 993 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 18067c0..7e30774 100644 --- a/drivers

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

2015-11-26 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- MAINTAINERS |3 + config/common_linuxapp |6 + doc/guides/rel_notes/release_2_2.rst|4 + drivers/net/Makefile|1 + drivers/net/nfp/Makefile

[dpdk-dev] [PATCH v9 0/9] support for netronome nfp-6xxx card

2015-11-26 Thread Alejandro Lucero
. - Moving the documentation files to a new patch file. - Adding info to MAINTAINERS and release files. Alejandro Lucero (9): nfp: basic initialization nfp: adding rx/tx functionality nfp: adding rss nfp: adding stats nfp: adding link functionality nfp: adding extra functionality nfp: link

[dpdk-dev] [PATCH v8 5/9] nfp: adding link functionality

2015-11-25 Thread Alejandro Lucero
I tried to do that but there is some issue with the inlining. I think this is due to inline keyword being processed (also) as static by the compiler. On Wed, Nov 25, 2015 at 4:29 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Wed, 25 Nov 2015 16:19:51 + >

[dpdk-dev] [PATCH v6 0/7] support for netronome nfp-6xxx card

2015-11-06 Thread Alejandro Lucero
Yes. There was a bug in 1.8 affecting how BARs are used in the device, but this should be fixed in 2.2 On Thu, Nov 5, 2015 at 11:42 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Thu, 05 Nov 2015 11:59:59 +0100 > Vincent JARDIN wrote: > > > > > On 05/11/2015 11:43,

[dpdk-dev] [PATCH v6 0/7] support for netronome nfp-6xxx card

2015-11-05 Thread Alejandro Lucero
Yes, this is true. There is a internal Netronome project for upstreaming the netdev kernel driver along with a BSP driver. PMD support will be in the BSP. There is a public github repo with current drivers: https://github.com/Netronome/nfp-drv-kmods On Thu, Nov 5, 2015 at 10:59 AM, Vincent

[dpdk-dev] [PATCH v5 8/9] nfp: adding nic guide

2015-11-04 Thread Alejandro Lucero
Yes. It will build by now. Once we add the PF then BSP will be needed. I guess this is the same for MLX PMDs needing specific Mellanox libraries. On Wed, Nov 4, 2015 at 3:03 PM, Thomas Monjalon wrote: > 2015-11-02 12:25, Alejandro.Lucero: > > +Before using the Netronome's DPDK PMD some

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-22 Thread Alejandro Lucero
to do (pci mask will be wrong). So, would it be acceptable to submit a new PMD without any documentation by now? I prefer this for the sake of integration than giving wrong or incomplete documentation. Thanks On Wed, Oct 21, 2015 at 8:40 PM, Alejandro Lucero < alejandro.lucero at netronome.

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Alejandro Lucero
On Wed, Oct 21, 2015 at 5:03 PM, Thomas Monjalon wrote: > 2015-10-21 16:57, Alejandro Lucero: > > I understand interest for not having another UIO driver does exist. We > > could maintain an external nfp_uio by now till either we get rid of it or > > we definitely find ou

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Alejandro Lucero
of it or we definitely find out it is really needed. any chance to accept nfp_uio by now? Thanks On Wed, Oct 21, 2015 at 4:25 PM, Thomas Monjalon wrote: > 2015-10-21 15:39, Alejandro Lucero: > > On Wed, Oct 21, 2015 at 6:24 AM, David Marchand < > david.marchand at 6wind

[dpdk-dev] rte_eth_rx_queue_count accuracy

2015-09-22 Thread Alejandro Lucero
I can not see that code. Can you point out where is it? Thanks On Mon, Sep 21, 2015 at 11:41 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Fri, 18 Sep 2015 11:33:36 +0100 > Alejandro Lucero wrote: > > > I have seen the API definition says nothing ab

[dpdk-dev] rte_eth_rx_queue_count accuracy

2015-09-18 Thread Alejandro Lucero
I have seen the API definition says nothing about accuracy but some PMD implementations sacrifice accuracy for the sake of performance. If I'm not understanding the code wrongly i40e and ixgbe check DD bit just for the first descriptor in a group of 4, and they take all of them as used if the

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-10 Thread Alejandro Lucero
Hi Rahul, Go ahead. That's fine for me. Thanks On Fri, Jul 10, 2015 at 10:54 AM, Rahul Lakkireddy < rahul.lakkireddy at chelsio.com> wrote: > On Tue, Jul 07, 2015 at 10:50:23 +, Burakov, Anatoly wrote: > > Hi Rahul, > > > > > However, unsigned long seems to be working fine for all builds.

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-06 Thread Alejandro Lucero
el maintainer and his answer: On Thu, 2015-07-02 at 14:42 +0100, Alejandro Lucero wrote: > Hi Alex, > > is VFIO expected to work in 32 bit systems? > > I know VFIO initial goal was a better control of device assignment to > virtual machines and it is based on IOMMU hardware supp

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-01 Thread Alejandro Lucero
I submitted a patch for fixing this issue on the 25th of June. I did not notice someone had reported this before. The last patch from Rahul does not solve the problem. For those cases where the MSI-X table is in one of the BARs to map, the memreg array is still in use. My fix was using unsigned

[dpdk-dev] [PATCH] eal_pci_vfio.c: fix the type for handling BAR size and offset info

2015-06-24 Thread Alejandro Lucero
Kernel mmap syscall and VFIO kernel driver expect unsigned long for offset. The BAR index to work with inside VFIO kernel driver will be the wrong one except for BAR 0. The patch solves the issue.

[dpdk-dev] ret_pktmbuf_pool_init problem with opaque_arg

2015-01-09 Thread Alejandro Lucero
Hi Olivier, On Fri, Jan 9, 2015 at 2:28 PM, Olivier MATZ wrote: > Hi Alejandro, > > On 01/09/2015 03:12 PM, Alejandro Lucero wrote: > > Inside this function mbuf_data_room_size is set to a default value if > > opaque_arg is null and it should be set to the value po

[dpdk-dev] About RTE_MAX_ETHPORT_QUEUE_STATS_MAPS

2014-08-21 Thread Alejandro Lucero
Hi, Documentation and header files describe stat_idx parameter for rte_eth_dev_set_tx_queue_stats_mapping and rte_eth_dev_set_rx_queue_stats_mapping as The value must be in the range [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1] I have not found a definition for RTE_MAX_ETHPORT_QUEUE_STATS_MAPS