[dpdk-dev] [PATCH] MAINTAINERS: update entry for compressdev

2021-10-06 Thread Fiona Trahe
Replacing myself with Fan as compressdev API maintainer. Signed-off-by: Fiona Trahe --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 278e5b3..2586468 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -438,7 +438,7 @@ F: doc

[dpdk-dev] [PATCH v2] cryptodev: clarify wireless inputs in digest-encrypted cases

2019-10-22 Thread Fiona Trahe
Clarify constraints on fields specified in bits for wireless algorithms in digest-encrypted case. v2 changes: - added note on each of the affected parameter fields Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h | 23 +++ 1 files changed, 19

[dpdk-dev] [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases

2019-10-22 Thread Fiona Trahe
Clarify constraints on fields specified in bits for wireless algorithms in digest-encrypted case. Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib

[dpdk-dev] [PATCH] crypto/qat: fix digest length in XCBC capability

2019-09-10 Thread Fiona Trahe
Digest length in RTE_CRYPTO_AUTH_AES_XCBC_MAC capability was incorrectly marked 16 bytes, should be 12. Fixes: 6a3c87bc6a6c ("crypto/qat: refactor capabilities infrastructure") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym_capabilities.h |4 ++-

[dpdk-dev] [PATCH v2 3/3] common/qat: add dual thread support

2019-09-06 Thread Fiona Trahe
, but enqueues and dequeues may be in separate threads. Documentation updated. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 5 - doc/guides/cryptodevs/qat.rst| 11 -- drivers/common/qat/qat_qp.c | 40

[dpdk-dev] [PATCH v2 1/3] common/qat: remove tail write coalescing feature

2019-09-06 Thread Fiona Trahe
The feature Coalescing Tail Writes on Enqueue is removed as it is not thread-safe and a dual-thread feature will be added shortly. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 16 +++- drivers/common/qat/qat_qp.h | 6 -- 2 files changed, 3 insertions(+), 19

[dpdk-dev] [PATCH v2 2/3] common/qat: move max inflights param into qp

2019-09-06 Thread Fiona Trahe
The max_inflights parameter is moved from qat_queue to qat_qp as it's a more appropriate location. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 23 --- drivers/common/qat/qat_qp.h | 2 +- 2 files changed, 13 insertions(+), 12 deletions(-) diff --

[dpdk-dev] [PATCH v2 0/3] Add dual threading in QAT PMD

2019-09-06 Thread Fiona Trahe
, but enqueues and dequeues may be in separate threads. As the tail-coalescing feature is not threadsafe it is removed first. v2 changes: - clarified wording in docs Fiona Trahe (3): common/qat: remove tail write coalescing feature common/qat: move max inflights param into qp common/qat

[dpdk-dev] [PATCH 2/3] common/qat: move max inflights param into qp

2019-09-06 Thread Fiona Trahe
The max_inflights parameter is moved from qat_queue to qat_qp as it's a more appropriate location. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 23 --- drivers/common/qat/qat_qp.h |2 +- 2 files changed, 13 insertions(+), 12 deletions(-) diff --

[dpdk-dev] [PATCH 3/3] common/qat: add dual thread support

2019-09-06 Thread Fiona Trahe
, but enqueues and dequeues may be in separate threads. Documentation updated. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst |5 +++- doc/guides/cryptodevs/qat.rst| 11 +++- drivers/common/qat/qat_qp.c | 40

[dpdk-dev] [PATCH 1/3] common/qat: remove tail write coalescing feature

2019-09-06 Thread Fiona Trahe
The feature Coalescing Tail Writes on Enqueue is removed as it is not thread-safe and a dual-thread feature will be added shortly. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 16 +++- drivers/common/qat/qat_qp.h |6 -- 2 files changed, 3 insertions(+), 19

[dpdk-dev] [PATCH 0/3] Add dual threading in QAT PMD

2019-09-06 Thread Fiona Trahe
, but enqueues and dequeues may be in separate threads. As the tail-coalescing feature is not threadsafe it is removed first. Fiona Trahe (3): common/qat: remove tail write coalescing feature common/qat: move max inflights param into qp common/qat: add dual thread support doc/guides

[dpdk-dev] [PATCH] doc/compressdev: clarify that structs should be zeroed before use

2019-08-27 Thread Fiona Trahe
Some structs used on the API are zeroed on creation by API calls, (e.g. rte_comp_op), but a few are allocated in the application domain. Clarify that the application should zero those to enable future extensions without API breakage. Signed-off-by: Fiona Trahe --- doc/guides/prog_guide

[dpdk-dev] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-25 Thread Fiona Trahe
Clarify the corner case with incompressible data whereby the output can actually be greater than the uncompressed data. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/librte_compressdev

[dpdk-dev] [PATCH] crypto/qat: fix seg-fault

2019-07-10 Thread Fiona Trahe
ned-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym.c | 35 ++- 1 files changed, 22 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c index 2dc0614..46ef27a 100644 --- a/drivers/crypto/qat/qat_sym.c +++

[dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages

2019-07-05 Thread Fiona Trahe
Use ERR rather than INFO to warn that it's a negative test else the errors are seen but the warning to expect them isn't. Also add comment to make it easier to follow code. Signed-off-by: Fiona Trahe --- app/test/test_compressdev.c |4 ++-- 1 files changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v2] compress/qat: fixed overflow status return from qat pmd

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch fixes fail status returned from compression PMD in case destination buffer size is not enough to store all data. Fixes: 3dc9ef2d23fe ("compress/qat: fix returned status on overflow") Cc: sta...@dpdk.org Signed-off-by: Tomasz Jozwiak Signed-off-by: Adam Dybkowski

[dpdk-dev] [PATCH v7 5/6] doc: update dpdk-test-compress-perf description

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch updates dpdk-test-compress-perf documentation. Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- doc/guides/tools/comp_perf.rst | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/comp

[dpdk-dev] [PATCH v7 6/6] app/test-compress-perf: add force process termination

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds a possibility to force controlled process termination as a result of two signals: SIGTERM and SIGINT Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/comp_perf_options.h| 1 + app/test-compress-perf/comp_perf_test_b

[dpdk-dev] [PATCH v7 2/6] app/test-compress-perf: add ptest command line option

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds --ptest option to make possible to choose test case from command line. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/comp_perf_options_parse.c | 32 1 file changed,

[dpdk-dev] [PATCH v7 4/6] app/test-compress-perf: add benchmark test case

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds a benchmark part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Also updates release notes. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile

[dpdk-dev] [PATCH v7 3/6] app/test-compress-perf: add verification test case

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds a verification part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile| 1 + app

[dpdk-dev] [PATCH v7 1/6] app/test-compress-perf: add weak functions for multi-cores test

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds template functions for multi-cores performance version of compress-perf-tool Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 3 +- app/test-compress-perf/comp_per

[dpdk-dev] [PATCH v7 0/6] add multiple cores feature to test-compress-perf

2019-07-05 Thread Fiona Trahe
This patchset adds multiple cores feature to compression perf tool. All structures have been aligned and are consistent with crypto perf tool. All test cases have constructor, runner and destructor and can use more cores and compression devices at the same time. v7 changes: - rebase as patch fail

[dpdk-dev] [PATCH] doc/cryptodev: clarify that full xform struct should be zeroed before use

2019-05-15 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/prog_guide/cryptodev_lib.rst | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst index 23fa5bc..cc53b25 100644 --- a/doc/guides/prog_guide

[dpdk-dev] [PATCH v3] doc/compress: clarify error handling on data-plane

2019-05-15 Thread Fiona Trahe
Fixed some typos and clarified how errors on ops which fail to get submitted on the enqueue API should be handled. Fixes: a584d3bea902 ("doc: add compressdev library guide") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- v3 changes: - change proposal so appl must check

[dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs

2019-05-03 Thread Fiona Trahe
Added release note entry for QAT compression PMD Clarified that previous entry was for QAT sym crypto PMD Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- doc/guides/rel_notes/release_19_05.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides

[dpdk-dev] [PATCH] test/crypto: added NULL algo tests to loop test mechanism

2019-04-26 Thread Fiona Trahe
Added NULL algo tests into loop test mechanism used by block cipher tests as easier to extend there. Included chain, cipher-only and auth-only use-cases. Extended to cover out-of-place use-cases and use-cases where data length is not an 8-byte multiple. Signed-off-by: Fiona Trahe --- app/test

[dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple

2019-04-26 Thread Fiona Trahe
NULL cipher algo of 4-byte multiple and other sizes caused firmware hang due to use of wrong mode. Changed from ECB mode to CTR mode to fix. Fixes: 98f060891615 ("crypto/qat: add symmetric session file") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym

[dpdk-dev] [PATCH v3] test/compress: fix max mbuf size test case

2019-04-19 Thread Fiona Trahe
ion -std=c99 or -std=gnu99 to compile your code ../app/test/test_compressdev.c:1996:19: warning: assignment from incompatible pointer type [enabled by default] Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case") Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe

[dpdk-dev] [PATCH v3] doc/crypto: add release notes and more detailed doc to qat

2019-04-18 Thread Fiona Trahe
From: Arek Kusztal This patch adds release notes to 19.05 release document, and more detailed description to Intel QuickAssist Technology driver documentation files for asymmmetric crypto PMD. Signed-off-by: Arek Kusztal Signed-off-by: Fiona Trahe --- v3 changes: - fixed broken table and

[dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-09 Thread Fiona Trahe
Fixed some typos and clarified which errors should be returned when and why on the enqueue and dequeue APIs. Fixes: a584d3bea902 ("doc: add compressdev library guide") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- v2 changes: - changed "0 or undefined" to just

[dpdk-dev] [PATCH] compress/qat: fixed data-plane return from QAT PMD

2019-04-08 Thread Fiona Trahe
Fixes: 62ada2182a46 ("compress/qat: add dynamic sgl allocation") Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 2fadb0

[dpdk-dev] [PATCH] doc/compress: clarify error handling on data-plane

2019-04-08 Thread Fiona Trahe
Fixed some typos and clarified which errors should be returned when and why on the enqueue and dequeue APIs. Fixes: a584d3bea902 ("doc: add compressdev library guide") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- doc/guides/prog_guide/compressde

[dpdk-dev] [PATCH] doc/crypto: fix missing asymmetric algo table

2019-04-03 Thread Fiona Trahe
Fixes: 11e5ba72cf67 ("doc: add crypto asymmetric feature list") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- .gitignore | 1 + doc/guides/conf.py | 5 + doc/guides/cryptodevs/features/aesni_gcm.ini | 5 +

[dpdk-dev] [PATCH] doc/qat: fix table of kernel drivers

2019-02-07 Thread Fiona Trahe
;) Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 53 --- 1 file changed, 30 insertions(+), 23 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index b079aa381..784334d92 100644 --- a/

[dpdk-dev] [PATCH] crypto/qat: fix digest issue in wireless auth case

2019-01-25 Thread Fiona Trahe
When operation calls for auth (digest generation), followed by encryption of both data plus digest, the digest-in-buffer flag must be set for QAT. Fixes: 39e0bee48e81 ("crypto/qat: rework request builder for performance") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/

[dpdk-dev] [PATCH] doc/qat: add GCM AAD limitation

2019-01-17 Thread Fiona Trahe
Add limitation that AAD buffer must be padded with zeroes in GCM case. Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done

2019-01-17 Thread Fiona Trahe
. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_compressdev.c | 2 ++ lib/librte_compressdev/rte_compressdev.h | 6 ++ 2 files changed, 8 insertions(+) diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib/librte_compressdev/rte_compressdev.c index 10101ebbe..338134bdf 100644

[dpdk-dev] [PATCH] crypto/aesni_mb: enable out of place processing

2018-12-20 Thread Fiona Trahe
Add out-of-place processing, i.e. different source and destination m_bufs, plus related capability update, tests and documentation. Document limitation to cipher-only as lib doesn't support digest generation in encrypt & generate direction for out-of-place yet. Signed-off-by: Fiona Trah

[dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD

2018-12-20 Thread Fiona Trahe
Remove AESNI_MB flag from SGL test cases which it doesn't support. Signed-off-by: Fiona Trahe --- test/test/test_cryptodev_aes_test_vectors.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test/test_cryptodev_aes_test_vectors.h b/test

[dpdk-dev] [PATCH] test/crypto: fix misleading trace message

2018-12-20 Thread Fiona Trahe
Test was reporting digest verification failed for all operation errors. Fixed so it only reports this if the PMD actually reports an auth failure. Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test") CC: sta...@dpdk.org Signed-off-by: Fiona Trahe ---

[dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-11-19 Thread Fiona Trahe
enqueue (default). An application may find this useful for tuning. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_compressdev.c | 2 ++ lib/librte_compressdev/rte_compressdev.h | 8 2 files changed, 10 insertions(+) diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib

[dpdk-dev] [PATCH 2/2] test/compress: use bulk free operations api

2018-11-19 Thread Fiona Trahe
Use the new rte_comp_op_bulk_free API. Add trace to catch any mempool elements not freed at test end. Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/test/test/test_compressdev.c b/test/test

[dpdk-dev] [PATCH 0/2] compressdev: add bulk op free API

2018-11-19 Thread Fiona Trahe
Add API to bulk free operations and use it in the unit test suite. Fiona Trahe (2): compressdev: add api to bulk free ops test/compress: use bulk free operations api lib/librte_compressdev/rte_comp.c | 12 lib/librte_compressdev/rte_comp.h

[dpdk-dev] [PATCH 1/2] compressdev: add api to bulk free ops

2018-11-19 Thread Fiona Trahe
There's an API to bulk allocate operations, this adds a corresponding bulk free API. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.c | 12 lib/librte_compressdev/rte_comp.h | 14 ++ lib/librte_compre

[dpdk-dev] [PATCH v2] compress/qat: display error in case IM buffer too small

2018-10-31 Thread Fiona Trahe
Display trace if error returned from firmware is likely due to intermediate buffers being too small for the compressed output. Update documentation to explain this error case and to clarify intermediate buffer memory usage. Signed-off-by: Fiona Trahe --- v2 changes: - improved some text in

[dpdk-dev] [PATCH] compress/qat: display error in case IM buffer too small

2018-10-30 Thread Fiona Trahe
Display trace if error returned from firmware is likely due to intermediate buffers being too small for the compressed output. Update documentation to explain this error case and to clarify intermediate buffer memory usage. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 22

[dpdk-dev] [PATCH] test/compress: improve trace

2018-10-30 Thread Fiona Trahe
Make clear which engine is compressing and which is decompressing in debug output. Also add newline and print ratio = 0 if test fails. Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/test

[dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

2018-10-30 Thread Fiona Trahe
ned-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 38 - 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c index 01dd736..ea93077 100644 --- a/drivers/co

[dpdk-dev] [PATCH v2] lib/compressdev: Fix logic error on op allocation

2018-10-26 Thread Fiona Trahe
;) Cc: sta...@dpdk.org Reported-by: Sabyasachi Sengupta Signed-off-by: Fiona Trahe --- v2 change: - added Reported-by tag lib/librte_compressdev/rte_comp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/

[dpdk-dev] [PATCH] lib/compressdev: Fix logic error on op allocation

2018-10-26 Thread Fiona Trahe
("compressdev: add operation management") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c index c663be

[dpdk-dev] [PATCH] lib/compressdev: clarify usage of op structure

2018-10-26 Thread Fiona Trahe
Add note on usage of op structure and when it can be accessed and freed. Fixes: 63f4bfd5328b ("compressdev: add enqueue/dequeue functions") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_compressdev.h | 7 +++ 1 file changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH v7] compress/qat: enable dynamic huffman encoding

2018-10-26 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v7 changes: - replace %ld with %zu for printing size_t to fix compiler issue - replace phys addr with rte_iova_t v6 changes

[dpdk-dev] [PATCH v6] compress/qat: enable dynamic huffman encoding

2018-10-24 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v6 changes: - replace %lx with PRIx64 to fix compiler issue - reorder entry in release notes so

[dpdk-dev] [PATCH] common/qat: fix for invalid response from firmware

2018-10-23 Thread Fiona Trahe
Check that the firmware response has a bit set indicating it's valid before dereferencing the rest of the response contents. Fixes: 0bdd36e12245 ("crypto/qat: make dequeue function generic") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 8 +

[dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding

2018-10-17 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v5 changes: - update release note v4 changes: - use #define for IM buffer logs, disable all by default and use param for clearer hexdump length. v3

[dpdk-dev] [PATCH v4] compress/qat: enable dynamic huffman encoding

2018-10-15 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v4 changes: - use #define for IM buffer logs, disable all by default and use param for clearer hexdump length. v3 changes: - reverted to 1 buffer per intermediate buffer sgl

[dpdk-dev] [PATCH v3] drivers/qat: fix failure to create PMD

2018-10-11 Thread Fiona Trahe
rg Signed-off-by: Fiona Trahe --- v3 changes: - moved checks up a layer to the probe fn as more appropriate place. v2 changes: - clarified documentation drivers/common/qat/qat_device.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v3] compress/qat: enable dynamic huffman encoding

2018-10-11 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v3 changes: - reverted to 1 buffer per intermediate buffer sgl v2 changes: - allocate 2 buffers per intermediate buffer sgl - Compile out trace for debugging intermediate

[dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding

2018-10-05 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 changes: - allocate 2 buffers per intermediate buffer sgl - Compile out trace for debugging intermediate buffers Depends on: https://patches.dpdk.org/patch/45794/ config

[dpdk-dev] [PATCH] common/qat: add support for GEN3 devices

2018-10-01 Thread Fiona Trahe
This adds pci detection, queue-pair configuration and documentation for Intel GEN3 QuickAssist devices. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 3 +++ doc/guides/rel_notes/release_18_11.rst | 4 drivers/common/qat/qat_common.h| 3 ++- drivers

[dpdk-dev] [PATCH v2] drivers/qat: fix failure to create PMD

2018-10-01 Thread Fiona Trahe
tions") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- v2 changes: - clarified documentation doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 6 -- drivers/crypto/qat/qat_sym_pmd.c| 6 -- 3 files changed, 11 insertions(+), 7 deletions(-)

[dpdk-dev] [PATCH] drivers/qat: fix failure to create PMD

2018-10-01 Thread Fiona Trahe
.@dpdk.org Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 6 -- drivers/crypto/qat/qat_sym_pmd.c| 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c index 63af23a..6510

[dpdk-dev] [PATCH] test/crypto: fix number of queue pairs

2018-09-22 Thread Fiona Trahe
returned by the PMD in the rte_cryptodev_get_info query, this value is stored in the ts_params. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- test/test/test_cryptodev.c | 6 +++--- 1 file changed, 3 insert

[dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment

2018-09-22 Thread Fiona Trahe
Same variable was assigned twice, remove one. Fixes: 6a7ea14819e9 ("compress/qat: add xform processing") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/co

[dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression

2018-09-22 Thread Fiona Trahe
Checksum was always 0 on QAT decompression due to incorrect use of union variable. Fixes: 6a7ea14819e9 ("compress/qat: add xform processing") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

[dpdk-dev] [PATCH 1/2] crypto/qat: fix typo

2018-08-10 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym_pmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_pmd.h b/drivers/crypto/qat/qat_sym_pmd.h index d343285..75c3362 100644 --- a/drivers/crypto/qat/qat_sym_pmd.h +++ b/drivers/crypto/qat

[dpdk-dev] [PATCH] compress/qat: use compression specific driver name

2018-08-10 Thread Fiona Trahe
The QAT compression driver was named "qat". Rename to compress_qat for consistency with other compressdev drivers and with crypto_qat. Signed-off-by: Fiona Trahe --- The patch depends on https://patches.dpdk.org/patch/43673/ doc/guides/cryptodevs/qat.rst | 2 +- drivers/

[dpdk-dev] [PATCH v3 6/6] doc/qat: describe build config options

2018-08-10 Thread Fiona Trahe
Added description of the build configuration options for QAT. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 31 +++ 1 file changed, 31 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index a352dabcd

[dpdk-dev] [PATCH v3 5/6] doc/qat: update build instructions for both PMDs

2018-08-10 Thread Fiona Trahe
Update PMD build section. Linked to kernel dependency section and refactored text between those 2 sections. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 81 ++- 1 file changed, 49 insertions(+), 32 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH v3 4/6] doc/qat: add overview of doc sections

2018-08-10 Thread Fiona Trahe
Add overview of QAT doc sections and link between them. Indent to next level all sections within the crypto and common sections. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 2 +- doc/guides/cryptodevs/qat.rst| 46 +++- 2 files

[dpdk-dev] [PATCH v3 3/6] doc/qat: fix typos and make cosmetic changes

2018-08-10 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 7df49ca44..17b313c9d 100644 --- a/doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH v3 2/6] doc/qat: add information on how to test

2018-08-10 Thread Fiona Trahe
Add section to common QAT part of doc about which tests can be used to exercise QAT compress and crypto PMDS Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides

[dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options

2018-08-10 Thread Fiona Trahe
underline line length - fixed typo: comp_qat should be qat v2 changes - split into patchset - changed test path from build/build/test/test to build/app - use make defconfig instead of make config T=xxx - matched underline lengths to titles Fiona Trahe (6): doc/qat: add limitations to compressdev

[dpdk-dev] [PATCH v3 1/6] doc/qat: add limitations to compressdev PMD

2018-08-10 Thread Fiona Trahe
Add 2 missing limitations to QAT compressdev documentation Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst index 8b1270b70

[dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 76 --- 1 file changed, 49 insertions(+), 27 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 2f233ec9d..6e4927697 100644 --- a/doc/guides

[dpdk-dev] [PATCH v2 6/8] doc/qat: update kernel dependency section

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index e6d78ac16..2f233ec9d 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides

[dpdk-dev] [PATCH v2 4/8] doc/qat: add overview of doc sections

2018-08-09 Thread Fiona Trahe
Add overview of QAT doc sections and link between them. Indent to next level all sections within the crypto and common sections. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 2 +- doc/guides/cryptodevs/qat.rst| 46 +++- 2 files

[dpdk-dev] [PATCH v2 5/8] doc/qat: remove unnecessary text

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index ab15e234b..e6d78ac16 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides/cryptodevs/qat.rst @@ -169,12

[dpdk-dev] [PATCH v2] doc/qat: describe build config options

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 31 +++ 1 file changed, 31 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 6e4927697..68cfd9e3e 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides

[dpdk-dev] [PATCH v2 3/8] doc/qat: fix typos and make cosmetic changes

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 7df49ca44..bfa4327b7 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b

[dpdk-dev] [PATCH v2 2/8] doc/qat: add information on how to test

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index bdc58eb2c..7df49ca44 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides/cryptodevs

[dpdk-dev] [PATCH v2 1/8] doc/qat: add limitations to compressdev PMD

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst index 8b1270b70..b45f4a626 100644 --- a/doc/guides/compressdevs/qat_comp.rst

[dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options

2018-08-09 Thread Fiona Trahe
- use make defconfig instead of make config T=xxx - matched underline lengths to titles Fiona Trahe (8): doc/qat: add limitations to compressdev PMD doc/qat: add information on how to test doc/qat: fix typos and make cosmetic changes doc/qat: add overview of doc sections doc/qat: remove

[dpdk-dev] [PATCH] doc/qat: clarify build config options

2018-08-09 Thread Fiona Trahe
Clarified documentation structure between compressedev, cryptodev and common build parts. Clarified build configuration options. Added Testing section. Fixed typos and made some cosmetic improvements. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 6 +- doc/guides

[dpdk-dev] [PATCH v2 2/2] compression/qat: add sgl feature

2018-07-23 Thread Fiona Trahe
This patch adds sgl feature to QAT compression PMD Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 : no change - just resubmit with the changed 1/2 patch config/common_base | 1 + config/rte_config.h | 1 + doc/guides/compressdevs

[dpdk-dev] [PATCH v2 1/2] common/qat: add sgl header

2018-07-23 Thread Fiona Trahe
This patch refactors the sgl struct so it includes a flexible array of flat buffers as sym and compress PMDs can have different size sgls. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 changes: - changed max_segs from int32_t to uint16_t to match max allowed by mbuf

[dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES

2018-07-20 Thread Fiona Trahe
Added extra case to support 8 byte key size for 3DES CBC. Also changed capabilities to reflect the change. Signed-off-by: Marko Kovacevic Signed-off-by: Fiona Trahe --- v3: rebased against QAT refactored code. v2: Fixed implementation (Fiona) drivers/crypto/qat/qat_sym_capabilities.h | 2

[dpdk-dev] [PATCH] compress/qat: enable dynamic huffman encoding

2018-07-20 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- config/common_base | 1 + config/rte_config.h | 1 + doc/guides/compressdevs/features/qat.ini | 1 + doc/guides/compressdevs

[dpdk-dev] [PATCH] test/compress: limit max number of segments in sgl test

2018-07-19 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 59 ++-- 1 file changed, 40 insertions(+), 19 deletions(-) diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c index e3bfcd1..8645388 100644 --- a/test/test

[dpdk-dev] [PATCH 2/2] compression/qat: add sgl feature

2018-07-17 Thread Fiona Trahe
This patch add sgl feature to QAT compression PMD Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- config/common_base | 1 + config/rte_config.h | 1 + doc/guides/compressdevs/features/qat.ini | 3 +++ doc/guides/compressdevs

[dpdk-dev] [PATCH 1/2] common/qat: add sgl header

2018-07-17 Thread Fiona Trahe
This patch refactors the sgl struct so it includes a flexible array of flat buffers as sym and compress PMDs can have different size sgls. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_common.c | 53 ++--- drivers/common

[dpdk-dev] [PATCH v6 08/16] compress/qat: setup queue-pairs for compression service

2018-07-12 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 61 + drivers/compress/qat

[dpdk-dev] [PATCH v6 16/16] docs/qat: refactor docs adding compression guide

2018-07-12 Thread Fiona Trahe
Extend QAT guide to cover crypto and compression and common information, particularly about kernel driver dependency. Update release note. Update compression feature list for qat. Signed-off-by: Fiona Trahe --- config/common_base | 2 +- doc/guides/compressdevs/features

[dpdk-dev] [PATCH v6 13/16] compress/qat: create and populate the ops structure

2018-07-12 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific functions. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat/qat_comp_pmd.h | 30 - 2 files

[dpdk-dev] [PATCH v6 07/16] compress/qat: add stats functions

2018-07-12 Thread Fiona Trahe
Add functions to get and clear compression queue-pair statistics. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++ 2 files changed, 42 insertions(+) diff

[dpdk-dev] [PATCH v6 12/16] compress/qat: add device start and stop fns

2018-07-12 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 17 insertions

[dpdk-dev] [PATCH v6 10/16] compress/qat: add fn to return device info

2018-07-12 Thread Fiona Trahe
Add capabilities pointer to internal qat comp device and function to return this and other info. C Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 19 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 25

[dpdk-dev] [PATCH v6 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-12 Thread Fiona Trahe
Now that all the device operations are available, add the functions to create and destroy the pmd. Called on probe and remove of the qat pci device, these register the device with the compressdev API and plug in all the device functionality. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz

  1   2   3   4   >