[dpdk-dev] [PATCH] ip_frag: fix missing dependency on librte_hash

2016-10-05 Thread Panu Matilainen
depends on librte_hash so its probably more a question of something commonly masking the issue. Signed-off-by: Panu Matilainen --- lib/librte_ip_frag/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ip_frag/Makefile b/lib/librte_ip_frag/Makefile index e97dfbd..43f8b1e 100644

[dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver

2016-09-16 Thread Panu Matilainen
On 09/15/2016 05:10 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > config/common_linuxapp | 3 +++ > drivers/net/Makefile | 1 + > mk/rte.app.mk | 1 + > 3 files changed, 5 insertions(+) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index

[dpdk-dev] [PATCH v3 02/15] eal/soc: add rte_eal_soc_register/unregister logic

2016-09-16 Thread Panu Matilainen
On 09/15/2016 05:09 PM, Thomas Monjalon wrote: > 2016-09-15 15:09, Jan Viktorin: >> On Thu, 15 Sep 2016 14:00:25 +0100 >> "Hunt, David" wrote: >> new file mode 100644 index 000..56135ed --- /dev/null +++ b/lib/librte_eal/common/eal_common_soc.c @@ -0,0 +1,56 @@

[dpdk-dev] [PATCH v3 12/15] ether: extract function eth_dev_get_intr_handle

2016-09-16 Thread Panu Matilainen
On 09/15/2016 05:05 PM, Thomas Monjalon wrote: > 2016-09-15 14:02, Hunt, David: >> On 9/9/2016 9:43 AM, Shreyansh Jain wrote: >>> +static inline >>> +struct rte_intr_handle *eth_dev_get_intr_handle(struct rte_eth_dev *dev) >>> +{ >>> + if (dev->pci_dev) { >>> + return

[dpdk-dev] [PATCH] dpdk_procinfo: check for primary process

2016-09-07 Thread Panu Matilainen
On 09/06/2016 08:12 PM, Maryam Tahhan wrote: > Add a check to see if the primary process is running and exit gracefully if it > is not. > > Suggested-by: Patrick Kutch > Signed-off-by: Maryam Tahhan > --- > app/proc_info/main.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[dpdk-dev] [PATCH 0/4] provide man pages for binaries provided by DPDK

2016-08-31 Thread Panu Matilainen
On 08/30/2016 05:51 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt >> Sent: Thursday, August 4, 2016 12:17 PM >> To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com; >> dev at dpdk.org >>

[dpdk-dev] Permanently binding NIC ports with DPDK drivers

2016-08-25 Thread Panu Matilainen
On 08/25/2016 02:01 PM, Ferruh Yigit wrote: > On 8/25/2016 5:57 AM, Keren Hochman wrote: >> Hi, >> I there a way to permanently bind a nic port when using DPDK drier with >> kernel < 3.6 ? (In this kernel VFIO driver is not supported)? >> Thanks, Keren >> > > There was a tool from Panu for this

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-24 Thread Panu Matilainen
On 08/24/2016 11:44 AM, Thomas Monjalon wrote: > 2016-08-24 13:46, Yuanhan Liu: >> On Tue, Aug 23, 2016 at 12:45:54PM +0300, Panu Matilainen wrote: >>>>>> Since collecting data of vhost_update_packet_xstats will have some >>>>>> effect on RX

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-23 Thread Panu Matilainen
On 08/23/2016 11:04 AM, Yang, Zhiyong wrote: > Hi, Panu: > >> -Original Message----- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Monday, August 22, 2016 3:53 PM >> To: Yang, Zhiyong ; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] vhost: add pmd xstats

2016-08-22 Thread Panu Matilainen
On 08/19/2016 03:16 PM, Zhiyong Yang wrote: > This feature adds vhost pmd extended statistics from per queue perspective > for the application such as OVS etc. > > The statistics counters are based on RFC 2819 and 2863 as follows: > > rx/tx_good_packets > rx/tx_total_bytes > rx/tx_dropped_pkts >

[dpdk-dev] DPDK Stable Releases and Long Term Support

2016-08-17 Thread Panu Matilainen
[ Yes I'm late to this party, apologies for missing the first round of discussion ] On 07/28/2016 03:33 PM, Mcnamara, John wrote: > > This document sets out the guidelines for DPDK Stable Releases and Long Term > Support releases (LTS) based on the initial RFC and comments: >

[dpdk-dev] [PATCH] ivshmem: remove integration in dpdk

2016-08-04 Thread Panu Matilainen
100644 lib/librte_ivshmem/Makefile > delete mode 100644 lib/librte_ivshmem/rte_ivshmem.c > delete mode 100644 lib/librte_ivshmem/rte_ivshmem.h > delete mode 100644 lib/librte_ivshmem/rte_ivshmem_version.map > [...] Ooh, what a nice "welcome back from vacation" message in my inbox :) FWIW, Acked-by: Panu Matilainen - Panu -

[dpdk-dev] [PATCH v2] mempool: rename functions with confusing names

2016-06-30 Thread Panu Matilainen
On 06/30/2016 03:00 PM, Thomas Monjalon wrote: > 2016-06-29 17:27, Bruce Richardson: >> Fix this by introducing two new functions to replace the old ones, >> * rte_mempool_avail_count to replace rte_mempool_count >> * rte_mempool_in_use_count to replace rte_mempool_free_count > > This patch needs

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Panu Matilainen
On 06/30/2016 10:57 AM, Yuanhan Liu wrote: > On Thu, Jun 30, 2016 at 10:39:45AM +0300, Panu Matilainen wrote: >> On 06/07/2016 06:51 AM, Yuanhan Liu wrote: >>> v3: - adapted the new vhost ABI/API changes to tep_term example, to make >>> sure not break build at lea

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Panu Matilainen
On 06/07/2016 06:51 AM, Yuanhan Liu wrote: > v3: - adapted the new vhost ABI/API changes to tep_term example, to make > sure not break build at least. > - bumped the ABI version to 3 > > NOTE: I created a branch at dpdk.org [0] for more conveinient testing: > > [0]:

[dpdk-dev] [PATCH v2 5/7] mk: fix external dependencies of crypto drivers

2016-06-27 Thread Panu Matilainen
On 06/26/2016 07:42 PM, Thomas Monjalon wrote: > When linking drivers as shared libraries, the dependencies need > to be marked as DT_NEEDED entries. > > The crypto dependencies (libsso and libIPSec) are static libraries. > To make them linked in the shared PMDs, the code must relocatable: > -

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-22 Thread Panu Matilainen
t KNI") Signed-off-by: Panu Matilainen --- lib/librte_port/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile index 0fc929b..3d84a0e 100644 --- a/lib/librte_port/Makefile +++ b/lib/librte_port/Makefile @@ -82,6 +82,8

[dpdk-dev] [PATCH] mem: skip memory locking on failure

2016-06-21 Thread Panu Matilainen
On 06/14/2016 05:12 PM, Olivier MATZ wrote: > Hi Panu, > > On 06/14/2016 03:21 PM, Panu Matilainen wrote: >> On 06/13/2016 01:26 PM, Olivier Matz wrote: >>> Since recently [1], it is not possible to run the dpdk with user >>> (non-root) privileges and the --no-hug

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

2016-06-21 Thread Panu Matilainen
On 06/21/2016 01:58 PM, Dumitrescu, Cristian wrote: > > >> -Original Message----- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Tuesday, June 21, 2016 11:45 AM >> To: Richardson, Bruce >> Cc: Dumitrescu, Cristian ; dev at dpdk.org; &g

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

2016-06-21 Thread Panu Matilainen
On 06/21/2016 01:29 PM, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: >> In current i40e codebase, if single VLAN header is added in a packet, >> it's treated as inner VLAN. Generally, a single VLAN header is >> treated as the outer VLAN header. So change

[dpdk-dev] [PATCH 2/3] pdump: fix missing dependency on libpthread

2016-06-21 Thread Panu Matilainen
Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Panu Matilainen --- lib/librte_pdump/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_pdump/Makefile b/lib/librte_pdump/Makefile index af81a28..a506c4d 100644 --- a/lib/librte_pdum

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

2016-06-21 Thread Panu Matilainen
On 06/10/2016 12:26 AM, Thomas Monjalon wrote: > Looking a bit more into librte_ivshmem, the documentation says we need > a Qemu patch but the URL doesn't exist anymore: > https://01.org/packet-processing/intel%C2%AE-ovdk > -> 404 Oops, we couldn't find that page > > I've never

[dpdk-dev] [PATCHv7 1/6] pmdinfogen: Add buildtools and pmdinfogen utility

2016-06-16 Thread Panu Matilainen
On 06/16/2016 04:33 PM, Neil Horman wrote: > On Thu, Jun 16, 2016 at 03:29:57PM +0300, Panu Matilainen wrote: >> On 06/09/2016 08:46 PM, Neil Horman wrote: >>> pmdinfogen is a tool used to parse object files and build json strings for >>> use in later determinin

[dpdk-dev] [PATCHv7 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-06-16 Thread Panu Matilainen
ting, where the raw JSON strings are dumped out > b) table format (default) where hex pci ids are dumped in a table format > c) pretty, where a user supplied pci.ids file is used to print out vendor > and device strings > > Signed-off-by: Neil Horman > CC: Bruce Richardson

[dpdk-dev] [PATCHv7 1/6] pmdinfogen: Add buildtools and pmdinfogen utility

2016-06-16 Thread Panu Matilainen
y: Neil Horman > CC: Bruce Richardson > CC: Thomas Monjalon > CC: Stephen Hemminger > CC: Panu Matilainen > --- Unlike earlier versions, pmdinfogen ends up installed in bindir during "make install". Is that intentional, or just a side-effect from using rte.hostapp.mk? If its intentional it probably should be prefixed with dpdk_ like the other tools. - Panu -

[dpdk-dev] [PATCH v4] eal: out-of-bounds write

2016-06-16 Thread Panu Matilainen
On 06/15/2016 04:25 PM, Slawomir Mrozowicz wrote: > Overrunning array mcfg->memseg of 256 44-byte elements > at element index 257 using index j. > Fixed by add condition with message information. > > Fixes: af75078fece3 ("first public release") > Coverity ID 13282 > > Signed-off-by: Slawomir

[dpdk-dev] random pkt generator PMD

2016-06-15 Thread Panu Matilainen
On 06/15/2016 03:14 PM, Yerden Zhumabekov wrote: > > > On 15.06.2016 17:25, Panu Matilainen wrote: >> On 06/15/2016 02:10 PM, Yerden Zhumabekov wrote: >>> >>> >>> On 15.06.2016 16:43, Dumitrescu, Cristian wrote: >>>> >>>>>

[dpdk-dev] random pkt generator PMD

2016-06-15 Thread Panu Matilainen
On 06/15/2016 02:10 PM, Yerden Zhumabekov wrote: > > > On 15.06.2016 16:43, Dumitrescu, Cristian wrote: >> >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yerden >>> Zhumabekov >>> Sent: Wednesday, June 15, 2016 10:44 AM >>> To: dev at dpdk.org >>>

[dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory

2016-06-15 Thread Panu Matilainen
On 06/15/2016 12:35 PM, Kerlin, MarcinX wrote: > Hi Sergio, > > Thanks for tips, I removed double casting and I leave (void *) casting > because pointer hp is const and compiler returns warnings. If hp is something that needs freeing then it shouldn't be const in the first place. Please fix

[dpdk-dev] [PATCH] mem: skip memory locking on failure

2016-06-14 Thread Panu Matilainen
"mem: lock pages when not using hugepages") > Reported-by: Panu Matilainen > Signed-off-by: Olivier Matz > --- > lib/librte_eal/linuxapp/eal/eal_memory.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c >

[dpdk-dev] [PATCH v3 08/20] vhost: introduce new API to export numa node

2016-06-07 Thread Panu Matilainen
On 06/07/2016 06:51 AM, Yuanhan Liu wrote: > Introduce a new API rte_vhost_get_numa_node() to get the numa node > from which the virtio_net struct is allocated. > > Signed-off-by: Yuanhan Liu > Tested-by: Rich Lane > Acked-by: Rich Lane > --- > drivers/net/vhost/rte_eth_vhost.c | 13

[dpdk-dev] [PATCH] mk: generate internal library dependencies from DEPDIRS-y automatically

2016-06-07 Thread Panu Matilainen
that information to generate LDLIBS entries for internal libraries automatically. Also revert commit 8180554d82b3 ("vhost: fix linkage of driver with library") which is made redundant by this change. Signed-off-by: Panu Matilainen --- drivers/net/vhost/Makefile | 1 - mk/

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-06-07 Thread Panu Matilainen
On 06/07/2016 11:23 AM, Thomas Monjalon wrote: > 2016-05-24 12:56, Panu Matilainen: >> On 05/20/2016 08:08 PM, Thomas Monjalon wrote: >>> 2016-05-20 18:50, Christian Ehrhardt: >>>> The individual libraries have various cross dependencies. >>>> This is

[dpdk-dev] [RFC] Yet another option for DPDK options

2016-06-03 Thread Panu Matilainen
On 06/03/2016 03:01 PM, Arnon Warshavsky wrote: > > > On Fri, Jun 3, 2016 at 2:50 PM, Neil Horman > wrote: > > On Fri, Jun 03, 2016 at 12:01:30PM +0100, Bruce Richardson wrote: > > On Fri, Jun 03, 2016 at 11:29:43AM +0100, Bruce Richardson wrote: > > >

[dpdk-dev] [RFC] Yet another option for DPDK options

2016-06-03 Thread Panu Matilainen
On 06/03/2016 02:50 PM, Neil Horman wrote: > On Fri, Jun 03, 2016 at 12:01:30PM +0100, Bruce Richardson wrote: >> On Fri, Jun 03, 2016 at 11:29:43AM +0100, Bruce Richardson wrote: >>> On Thu, Jun 02, 2016 at 04:08:37PM -0400, Neil Horman wrote: On Thu, Jun 02, 2016 at 07:41:10PM +, Wiles,

[dpdk-dev] [PATCH v2 1/2] ethdev: add callback to get register size in bytes

2016-05-30 Thread Panu Matilainen
On 05/30/2016 12:39 PM, zr at semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes

[dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Panu Matilainen
On 05/27/2016 02:35 PM, Neil Horman wrote: > On Fri, May 27, 2016 at 12:16:03PM +0300, Panu Matilainen wrote: > >> Yup. But there's also a bit of a gotcha involved with the virtual devices >> with added api. This is how eg testpmd looks when built in shared library >>

[dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes

2016-05-27 Thread Panu Matilainen
On 05/25/2016 09:36 AM, zr at semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes

[dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-27 Thread Panu Matilainen
On 05/25/2016 09:58 PM, Thomas Monjalon wrote: > 2016-05-25 13:47, Neil Horman: >> On Wed, May 25, 2016 at 07:22:39PM +0200, Thomas Monjalon wrote: >>> 2016-05-24 15:41, Neil Horman: Note that, in the case of dynamically linked applications, pmdinfo.py will scan for implicitly

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-27 Thread Panu Matilainen
me test on my end next week then. >> >> >> >> Christian Ehrhardt >> Software Engineer, Ubuntu Server >> Canonical Ltd >> >> On Tue, May 24, 2016 at 11:56 AM, Panu Matilainen >> wrote: >> >>> On 05/20/2016 08:08 PM, Thomas Monjalon wrote:

[dpdk-dev] [PATCHv4 0/5] Implement pmd hardware support exports

2016-05-25 Thread Panu Matilainen
rguments > * Fixed some erroneous macro usage in drivers that aren't in the default > build > > Signed-off-by: Neil Horman > CC: Bruce Richardson > CC: Thomas Monjalon > CC: Stephen Hemminger > CC: Panu Matilainen /me happy now, so: Acked-by: Panu Matilainen As alway

[dpdk-dev] [PATCH] qede: add missing external dependency and disable by default

2016-05-24 Thread Panu Matilainen
The qede driver depends on libz but the LDLIBS entry in makefile was missing. Also because of the external dependency, make it disabled in default config as per common DPDK policy on external deps. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Panu Matilainen -

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-24 Thread Panu Matilainen
On 05/20/2016 08:08 PM, Thomas Monjalon wrote: > 2016-05-20 18:50, Christian Ehrhardt: >> The individual libraries have various cross dependencies. >> This is already refelcted in the DEPDIR dependency, but not yet in >> proper DT_NEEDED flags in the .so's. >> This adds the -l flags so that is

[dpdk-dev] [PATCHv3 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-24 Thread Panu Matilainen
for scripting, where the raw JSON strings are dumped out > b) table format (default) where hex pci ids are dumped in a table format > c) pretty, where a user supplied pci.ids file is used to print out vendor and > device strings > > Signed-off-by: Neil Horman > CC: Bruce Richar

[dpdk-dev] [PATCHv3 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-24 Thread Panu Matilainen
for scripting, where the raw JSON strings are dumped out > b) table format (default) where hex pci ids are dumped in a table format > c) pretty, where a user supplied pci.ids file is used to print out vendor and > device strings > > Signed-off-by: Neil Horman > CC: Bruce Richar

[dpdk-dev] [PATCHv3 2/5] drivers: Update driver registration macro usage

2016-05-24 Thread Panu Matilainen
On 05/20/2016 08:24 PM, Neil Horman wrote: > Modify the PMD_REGISTER_DRIVER macro, adding a name argument to it. The > addition of a name argument creates a token that can be used for subsequent > macros in the creation of unique symbol names to export additional bits of > information for use by

[dpdk-dev] [PATCH 4/4] pmd_hw_support.py: Add tool to query binaries for hw support information

2016-05-24 Thread Panu Matilainen
On 05/23/2016 04:55 PM, Neil Horman wrote: > On Mon, May 23, 2016 at 02:56:18PM +0300, Panu Matilainen wrote: >> On 05/20/2016 05:06 PM, Neil Horman wrote: >> [...] >>> Look, I think we're simply not going to agree on this issue at all. What >>> about >>>

[dpdk-dev] [PATCH 4/4] pmd_hw_support.py: Add tool to query binaries for hw support information

2016-05-23 Thread Panu Matilainen
On 05/20/2016 05:06 PM, Neil Horman wrote: [...] > Look, I think we're simply not going to agree on this issue at all. What > about > this in the way of compromise. I simply am not comfortable with automatically > trying to guess what hardware support will exist in an application based on >

[dpdk-dev] [PATCH] mk: Fix cruft getting installed by "make install" with tar >= 1.29

2016-05-23 Thread Panu Matilainen
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1337864 Signed-off-by: Panu Matilainen --- mk/rte.sdkinstall.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 68e56b6..abdab0f 100644 --- a/mk/rte.sdkinstall.m

[dpdk-dev] Underlinked libs and overlinked applications - an issue?

2016-05-20 Thread Panu Matilainen
On 05/19/2016 09:17 PM, Thomas Monjalon wrote: > 2016-05-19 17:38, Christian Ehrhardt: >> Hi, >> I was working on the new 16.04 build system to adapt deb packaging to it. >> I remember somewhen back in the DPDK 2.2 and shared+combined library days I >> had some issues with over/underlinking - but

[dpdk-dev] [PATCHv2 4/4] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-20 Thread Panu Matilainen
On 05/20/2016 11:55 AM, Thomas Monjalon wrote: > 2016-05-20 08:22, Panu Matilainen: >> Ability to query individual DSOs is a building block for other things >> like automation (you dont expect normal users to go manually loading hw >> support modules for the OS either), bu

[dpdk-dev] [PATCH v3 00/35] mempool: rework memory allocation

2016-05-20 Thread Panu Matilainen
On 05/19/2016 03:47 PM, Thomas Monjalon wrote: > 2016-05-18 13:04, Olivier Matz: >> This series is a rework of mempool. For those who don't want to read >> all the cover letter, here is a sumary: >> >> - it is not possible to allocate large mempools if there is not enough >> contiguous memory,

[dpdk-dev] [PATCH 4/4] pmd_hw_support.py: Add tool to query binaries for hw support information

2016-05-20 Thread Panu Matilainen
On 05/19/2016 04:26 PM, Neil Horman wrote: > On Thu, May 19, 2016 at 09:08:52AM +0300, Panu Matilainen wrote: >> On 05/18/2016 04:48 PM, Neil Horman wrote: >>> On Wed, May 18, 2016 at 03:48:12PM +0300, Panu Matilainen wrote: >>>> On 05/18/2016 03:03 PM, Neil Horm

[dpdk-dev] [PATCH] scripts: remove unused map files merger

2016-05-20 Thread Panu Matilainen
was such a script :) Thanks for spotting. Acked-by: Panu Matilainen - Panu -

[dpdk-dev] [PATCHv2 4/4] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-20 Thread Panu Matilainen
On 05/19/2016 03:00 PM, Neil Horman wrote: > On Thu, May 19, 2016 at 12:02:27PM +0300, Panu Matilainen wrote: >> On 05/19/2016 12:08 AM, Neil Horman wrote: >>> This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary, >>> and, if found parses the remain

[dpdk-dev] [PATCHv2 4/4] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-05-19 Thread Panu Matilainen
On 05/19/2016 12:08 AM, Neil Horman wrote: > This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary, > and, if found parses the remainder of the string as a json encoded string, > outputting the results in either a human readable or raw, script parseable > format > > Note that,

[dpdk-dev] [PATCHv2 2/4] drivers: Update driver registration macro usage

2016-05-19 Thread Panu Matilainen
to make hardware support info discoverable later. > > Signed-off-by: Neil Horman > CC: Bruce Richardson > CC: Thomas Monjalon > CC: Stephen Hemminger > CC: Panu Matilainen > --- > drivers/Makefile | 2 ++ > drivers/crypto/aesni_g

[dpdk-dev] [PATCHv2 1/4] pmdinfogen: Add buildtools and pmdinfogen utility

2016-05-19 Thread Panu Matilainen
On 05/19/2016 12:08 AM, Neil Horman wrote: [...] > + if (strcmp(secname, ".modinfo") == 0) { > + if (nobits) > + fprintf(stderr, "%s has NOBITS .modinfo\n", > filename); > + info->modinfo = (void *)hdr +

[dpdk-dev] [PATCH 4/4] pmd_hw_support.py: Add tool to query binaries for hw support information

2016-05-19 Thread Panu Matilainen
On 05/18/2016 04:48 PM, Neil Horman wrote: > On Wed, May 18, 2016 at 03:48:12PM +0300, Panu Matilainen wrote: >> On 05/18/2016 03:03 PM, Neil Horman wrote: >>> On Wed, May 18, 2016 at 02:48:30PM +0300, Panu Matilainen wrote: >>>> On 05/16/2016 11:41 PM, Neil Horman w

[dpdk-dev] [PATCH 4/4] pmd_hw_support.py: Add tool to query binaries for hw support information

2016-05-18 Thread Panu Matilainen
On 05/18/2016 03:03 PM, Neil Horman wrote: > On Wed, May 18, 2016 at 02:48:30PM +0300, Panu Matilainen wrote: >> On 05/16/2016 11:41 PM, Neil Horman wrote: >>> This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary, >>> and, if found parses the remain

[dpdk-dev] [PATCH 4/4] pmd_hw_support.py: Add tool to query binaries for hw support information

2016-05-18 Thread Panu Matilainen
t; > Signed-off-by: Neil Horman > CC: Bruce Richardson > CC: Thomas Monjalon > CC: Stephen Hemminger > CC: Panu Matilainen > --- > tools/pmd_hw_support.py | 174 > > 1 file changed, 174 insertions(+) > create

[dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

2016-05-18 Thread Panu Matilainen
On 05/14/2016 04:06 AM, Rasesh Mody wrote: >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Friday, May 13, 2016 8:38 AM >> >> 2016-05-10 13:01, Panu Matilainen: >>> With gcc >= 6.0, qede base driver fails to build with: >>> d

[dpdk-dev] [PATCH 2/2] doc: announce ABI change of struct rte_port_sink_params

2016-05-16 Thread Panu Matilainen
On 05/16/2016 04:18 PM, Fan Zhang wrote: > The ABI changes are planned for rte_port_sink_params, which will be > supported from release 16.11. Here announces that ABI changes in detail. > > Signed-off-by: Fan Zhang > Acked-by: Cristian Dumitrescu > --- > doc/guides/rel_notes/deprecation.rst | 4

[dpdk-dev] [PATCH 02/20] thunderx/nicvf: add pmd skeleton

2016-05-11 Thread Panu Matilainen
On 05/07/2016 06:16 PM, Jerin Jacob wrote: > diff --git a/drivers/net/thunderx/Makefile b/drivers/net/thunderx/Makefile > new file mode 100644 > index 000..69bb750 > --- /dev/null > +++ b/drivers/net/thunderx/Makefile > @@ -0,0 +1,64 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2016 Cavium

[dpdk-dev] [PATCH 01/40] bnxt: new driver for Broadcom NetXtreme-C devices

2016-05-11 Thread Panu Matilainen
On 05/06/2016 10:25 PM, Stephen Hurd wrote: > Initial skeleton simply fails init. > Add nic guide and tie into build system. > > Signed-off-by: Stephen Hurd > --- [...] > diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile > new file mode 100644 > index 000..89b4a27 > ---

[dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

2016-05-10 Thread Panu Matilainen
With gcc >= 6.0, qede base driver fails to build with: drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common': cc1: error: left shift of negative value [-Werror=shift-negative-value] Since the base drivers are untouchable, work around by disabling the warning. Signed-off-by: P

[dpdk-dev] [PATCH] mk: cleanup leftover references to librte_malloc

2016-04-26 Thread Panu Matilainen
librte_malloc was long since merged into librte_eal, mop up the leftovers from rarer drivers. Fixes: 2f9d47013e4d ("mem: move librte_malloc to eal/common") Signed-off-by: Panu Matilainen --- drivers/net/cxgbe/Makefile| 2 +- drivers/net/ena/Makefile | 2 +- drivers/net/mpip

[dpdk-dev] [PATCH v2] vhost: Fix linkage of vhost PMD

2016-04-26 Thread Panu Matilainen
- DPDK application doesn't link librte_vhost. > - Above application tries to link vhost PMD using '-d' DPDK option. > > The patch adds linkage for librte_vhost to vhost PMD not to cause an > above error. > > Signed-off-by: Tetsuya Mukawa > Acked-by: Panu Matilainen > --

[dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost

2016-04-25 Thread Panu Matilainen
What do you think about adding it to vhost PMD? Yes, this is absolutely the right thing to do. Ultimately this should be done for all dependencies in all libraries, but missing dependencies are even more pronounced in plugins so the sooner this goes in, the better. Acked-by: Panu Matilainen - Panu - > > Thanks, > Tetsuya >

[dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak

2016-04-22 Thread Panu Matilainen
On 04/21/2016 02:19 PM, Sergio Gonzalez Monroy wrote: > On 20/04/2016 10:15, David Marchand wrote: >> On Tue, Apr 19, 2016 at 6:27 PM, Marcin Kerlin >> wrote: >>> Fix issue reported by Coverity. >>> >>> Coverity ID 13295, 13296, 13303: >>> Resource leak: The system resource will not be reclaimed

[dpdk-dev] [dpdk-users] DPDK 16.04 link changes cause PMD drivers to not be loaded

2016-04-22 Thread Panu Matilainen
On 04/21/2016 06:24 PM, Aurojit Panda wrote: > > > Thomas Monjalon wrote: >> 2016-04-21 08:01, Aurojit Panda: >>> Panu Matilainen wrote: >> [...] >>>> Again, PMDs are *plugins* that are *meant* to be loaded at runtime. >>>> That allows for

[dpdk-dev] On DPDK ABI policy

2016-04-07 Thread Panu Matilainen
[ change of subject since this is about ABI policy, not namespacing ] On 04/07/2016 01:16 PM, Marc Sune wrote: > > > 2016-04-07 11:33 GMT+02:00 Panu Matilainen <mailto:pmatilai at redhat.com>>: > > On 04/07/2016 12:18 PM, Thomas Monjalon wrote: > &

[dpdk-dev] DPDK namespace

2016-04-07 Thread Panu Matilainen
On 04/07/2016 12:18 PM, Thomas Monjalon wrote: > Thank you everyone for the feedbacks. > > 2016-04-05 15:56, Thomas Monjalon: >> The goal of this email is to get some feedback on how important it is >> to fix the DPDK namespace. > > Everybody agree every symbols must be prefixed. Checking and

[dpdk-dev] [PATCH] vhost: ABI/API change announcement due to refactor

2016-04-07 Thread Panu Matilainen
both ABI and API change. > + The proposed refactor would expose DPDK vhost dev to applications as > + a handle, like the way kernel exposes an fd to user for locating a > + specific file, and to keep all major structures internally, so that > + we are likely to be free from AB

[dpdk-dev] DPDK namespace

2016-04-06 Thread Panu Matilainen
On 04/06/2016 08:26 AM, Yuanhan Liu wrote: > On Tue, Apr 05, 2016 at 05:31:22PM +0300, Arnon Warshavsky wrote: >> On Tue, Apr 5, 2016 at 5:13 PM, Trahe, Fiona >> wrote: >> >>> >>> -Original Message- From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon

[dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6

2016-04-01 Thread Panu Matilainen
On 03/31/2016 06:02 PM, Thomas Monjalon wrote: > 2016-03-22 17:37, Aaron Conole: >> This series brings a number of code cleanups to allow building using gcc6, >> with various legitimate warnings being fixed. >> >> Some of these fixes are to the drivers area, making this series a bit >> atypical.

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-24 Thread Panu Matilainen
On 03/24/2016 02:35 AM, Lu, Wenzhuo wrote: > Hi Thomas, Aaron, >>> Wenzhuo, do you agree to fix the base driver here? > Honestly I find the logic has some problem and maybe more changes needed. I'm > talking with our kernel driver contactors to make sure they have no concern > about my idea. >

[dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Panu Matilainen
On 03/22/2016 11:58 AM, Daniel Mrzyglod wrote: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is > now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). > >

[dpdk-dev] [PATCH 2/2] mk: fix two more missing libm dependencies

2016-03-21 Thread Panu Matilainen
vital they are removed before passing to linker. Fixes: e86a699cf6b1 ("mk: fix shared library dependencies on libm and librt") Reported-by: Ferruh Yigit Signed-off-by: Panu Matilainen --- drivers/net/nfp/Makefile | 2 ++ lib/librte_meter/Makefile | 2 ++ mk/rte.app.mk | 2 +

[dpdk-dev] [PATCH 1/2] mk: Eliminate possible duplicates from LDLIBS

2016-03-21 Thread Panu Matilainen
Duplicates in LDLIBS can cause link failures from multiply defined symbols, ensure all libraries are only mentioned once. Can't use sorting for duplicate elimination as order is critical so awk one-liner is used. Signed-off-by: Panu Matilainen --- mk/rte.app.mk | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH] mk: fix linker script when re-building

2016-03-17 Thread Panu Matilainen
7 +42,7 @@ endif > RTE_LIBNAME := dpdk > COMBINEDLIB := lib$(RTE_LIBNAME)$(EXT) > > -LIBS := $(notdir $(wildcard $(RTE_OUTPUT)/lib/*$(EXT))) > +LIBS := $(filter-out $(COMBINEDLIB), $(notdir $(wildcard > $(RTE_OUTPUT)/lib/*$(EXT > > all: FORCE > $(Q)echo &q

[dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux

2016-03-16 Thread Panu Matilainen
On 03/16/2016 03:58 PM, Thomas Monjalon wrote: > 2016-03-16 15:15, Panu Matilainen: >> What I really would like to see is a clear policy regarding kernel >> modules in DPDK. I certainly am in no position to dictate one, and >> that's why I've been asking questions and

[dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux

2016-03-16 Thread Panu Matilainen
On 03/16/2016 01:13 PM, Ferruh Yigit wrote: > On 3/16/2016 10:45 AM, Thomas Monjalon wrote: >> 2016-03-16 10:26, Ferruh Yigit: >>> On 3/16/2016 8:22 AM, Panu Matilainen wrote: >>>> On 03/16/2016 10:19 AM, Ferruh Yigit wrote: >>>>> On 3/16/2016 7:26 AM

[dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux

2016-03-16 Thread Panu Matilainen
On 03/16/2016 12:26 PM, Ferruh Yigit wrote: > On 3/16/2016 8:22 AM, Panu Matilainen wrote: >> On 03/16/2016 10:19 AM, Ferruh Yigit wrote: >>> On 3/16/2016 7:26 AM, Panu Matilainen wrote: >>>> On 03/14/2016 05:32 PM, Ferruh Yigit wrote: >>>>

[dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux

2016-03-16 Thread Panu Matilainen
On 03/16/2016 10:19 AM, Ferruh Yigit wrote: > On 3/16/2016 7:26 AM, Panu Matilainen wrote: >> On 03/14/2016 05:32 PM, Ferruh Yigit wrote: >>> On 3/9/2016 11:17 AM, Ferruh Yigit wrote: >>>> This patch sent to keep record of latest status of the work. >>

[dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux

2016-03-16 Thread Panu Matilainen
On 03/14/2016 05:32 PM, Ferruh Yigit wrote: > On 3/9/2016 11:17 AM, Ferruh Yigit wrote: >> This patch sent to keep record of latest status of the work. >> >> >> This is slow data path communication implementation based on existing KNI. >> >> Difference is: librte_kni converted into a PMD, kdp

[dpdk-dev] [PATCH v3 1/3] mk: clear up libm and librt linkage confusion

2016-03-15 Thread Panu Matilainen
On 03/14/2016 06:44 PM, Ferruh Yigit wrote: > On 3/10/2016 1:15 PM, Panu Matilainen wrote: >> There are two places that need -lm (test app and librte_sched) and >> exactly one that needs -lrt (librte_sched). Add the relevant >> DT_NEEDED entries to both, and eliminate

[dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type

2016-03-11 Thread Panu Matilainen
On 03/11/2016 10:49 AM, Helin Zhang wrote: > In order to set ether type of VLAN for single VLAN, inner > and outer VLAN, the VLAN type as an input parameter is added > to 'rte_eth_dev_set_vlan_ether_type()'. > In addition, corresponding changes in e1000, ixgbe and i40e > are also added. > >

[dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled

2016-03-11 Thread Panu Matilainen
On 03/11/2016 11:28 AM, Thomas Monjalon wrote: > 2016-03-11 11:13, Panu Matilainen: >> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled, >> build of any crypto pmds will fail because of the missing dependency. >> This has been present for a while now but hidd

[dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled

2016-03-11 Thread Panu Matilainen
the entire drivers/crypto directory on CONFIG_RTE_LIBRTE_CRYPTODEV to fix. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: Panu Matilainen --- drivers/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/Makefile b/drivers/Makefile ind

[dpdk-dev] [PATCH 8/8] drivers/net/ixgbe: Fix uninitialized warning

2016-03-10 Thread Panu Matilainen
On 03/10/2016 04:45 PM, Remy Horton wrote: > > On 10/03/2016 13:42, Panu Matilainen wrote: >> On 02/25/2016 08:48 PM, Aaron Conole wrote: >>> Silence a compiler warning that this variable may be used uninitialized. >>> >>> Signed-off-by: Aaron

[dpdk-dev] [RFC 35/35] mempool: update copyright

2016-03-10 Thread Panu Matilainen
On 03/09/2016 08:52 PM, Stephen Hemminger wrote: > I understand that 6Wind has made major contributions to DPDK in many places. > > I would prefer that each file not get copyright additions from each > contributor, > otherwise this starts a bad precedent where the source gets cluttered with >

[dpdk-dev] [PATCH] pipeline: use unsigned constants for left shift operations

2016-03-10 Thread Panu Matilainen
Tell the compiler to use unsigned constants for left shift ops, otherwise building with gcc >= 6.0 fails due to multiple warnings like: warning: left shift of negative value [-Wshift-negative-value] Signed-off-by: Panu Matilainen --- examples/ip_pipeline/pipeline/pipeline_common_fe.c

[dpdk-dev] [PATCH 8/8] drivers/net/ixgbe: Fix uninitialized warning

2016-03-10 Thread Panu Matilainen
On 02/25/2016 08:48 PM, Aaron Conole wrote: > Silence a compiler warning that this variable may be used uninitialized. > > Signed-off-by: Aaron Conole > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[dpdk-dev] [PATCH 7/8] drivers/net/ixgbe: Signed left shift operator

2016-03-10 Thread Panu Matilainen
1), vfre_slot - 1); > - IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot), (~0) << vfre_offset); > + IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot), (~0U) << vfre_offset); > IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot ^ 1), vfre_slot - 1); > > /* PFDMA Tx General Switch Control Enables VMDQ loopback */ > Acked-by: Panu Matilainen CC'd the ixgbe maintainers... - Panu -

[dpdk-dev] [PATCH 6/8] drivers/net/e1000/igb: Signed left shift operator

2016-03-10 Thread Panu Matilainen
;< vf_num); > > /* PFDMA Tx General Switch Control Enables VMDQ loopback */ > if (hw->mac.type == e1000_i350) > Acked-by: Panu Matilainen CC'd the e1000 maintainer too. - Panu -

[dpdk-dev] [PATCH 5/8] drivers/net/ixgbe: Fix vlan filter missing brackets

2016-03-10 Thread Panu Matilainen
; pool_idx))) { > ret = hw->mac.ops.set_vfta(hw,vlan,pool_idx,vlan_on); > if (ret < 0) > return ret; > + } > } > > return ret; > Acked-by: Panu Matilainen Seems really obvious but cc'd the ixgbe maintainers too. - Panu -

[dpdk-dev] [PATCH 4/8] drivers/net/e1000: Fix missing lsc interrupt check brackets

2016-03-10 Thread Panu Matilainen
em_dev_clear_queues(dev); > return ret; > } > + } > } else { > rte_intr_callback_unregister(intr_handle, > eth_em_interrupt_handler, > Acked-by: Panu Matilainen Seems really obvious but cc'd the e1000 maintainer too. - Panu -

[dpdk-dev] [PATCH 2/8] app/test/test: Fix missing brackets

2016-03-10 Thread Panu Matilainen
printf(" + > --- +\n"); > printf(" + Test Suite : %s\n", suite->suite_name); > + } > > if (suite->setup) > if (suite->setup() != 0) > Acked-by: Panu Matilainen This is just about as obvious as they get... - Panu -

[dpdk-dev] [PATCH v3 3/3] mk: add DT_NEEDED entries for librte_eal external dependencies

2016-03-10 Thread Panu Matilainen
Details between the platforms differ somewhat, and for static builds they need to be handled from mk/exec-env still. Signed-off-by: Panu Matilainen --- lib/librte_eal/bsdapp/eal/Makefile | 4 lib/librte_eal/linuxapp/eal/Makefile | 4 2 files changed, 8 insertions(+) diff --git

  1   2   3   4   >