[dpdk-dev] [PATCH v2 2/2] cmdline: add polling mode for command line

2015-05-13 Thread Pawel Wodkowski
This patch adds the ability to process console input in the same thread as packet processing by using poll() function. Signed-off-by: Pawel Wodkowski --- doc/api/doxy-api.conf | 1 + lib/librte_cmdline/cmdline.c | 35 ++ lib

[dpdk-dev] [PATCH v2 1/2] cmdline: fix missing include files

2015-05-13 Thread Pawel Wodkowski
When including only some of library headers some definitions are missing and build fails. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline.h | 3 +++ lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 ++ lib/librte_cmdline/cmdline_rdline.h | 1 + lib/librte_cmdline

[dpdk-dev] [PATCH v2 0/2] cmdline: add polling mode for command line

2015-05-13 Thread Pawel Wodkowski
in cmdline_parse_ipaddr.h Pawel Wodkowski (2): cmdline: fix missing include files cmdline: add polling mode for command line doc/api/doxy-api.conf | 1 + lib/librte_cmdline/cmdline.c | 35 ++ lib/librte_cmdline/cmdline.h

[dpdk-dev] [PATCH 2/2] cmdline: add polling mode for command line

2015-05-12 Thread Pawel Wodkowski
On 2015-05-12 16:36, Olivier MATZ wrote: > Hi Pawel, > > On 05/12/2015 01:10 PM, Pawel Wodkowski wrote: >> This patch adds the ability to process console input in the same thread >> as packet processing by using poll() function. >> >> Signed-off-by: Pawel

[dpdk-dev] [PATCH 2/2] cmdline: add polling mode for command line

2015-05-12 Thread Pawel Wodkowski
This patch adds the ability to process console input in the same thread as packet processing by using poll() function. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline.c | 35 ++ lib/librte_cmdline/cmdline.h | 1 + lib

[dpdk-dev] [PATCH 1/2] cmdline: fix missing include files

2015-05-12 Thread Pawel Wodkowski
When including only some of library headers some definitions are missing and build fails. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline.h| 3 +++ lib/librte_cmdline/cmdline_rdline.h | 1 + lib/librte_cmdline/cmdline_vt100.h | 2 ++ 3 files changed, 6 insertions(+) diff

[dpdk-dev] [PATCH 0/2] cmdline: add polling mode for command line

2015-05-12 Thread Pawel Wodkowski
This patchset adds the ability to process console input in the same thread as packet processing by using poll() function and fixes some minor issues. Pawel Wodkowski (2): cmdline: fix missing include files cmdline: add polling mode for command line lib/librte_cmdline/cmdline.c

[dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio

2015-04-23 Thread Pawel Wodkowski
On 2015-04-22 17:33, Ravi Kerur wrote: > +/** > + * Compare bytes between two locations. The locations must not overlap. > + * > + * @note This is implemented as a macro, so it's address should not be taken > + * and care is needed as parameter expressions may be evaluated multiple > times. > + *

[dpdk-dev] cost of reading tsc register

2015-04-22 Thread Pawel Wodkowski
On 2015-04-20 16:37, Ravi Kumar Iyer wrote: > Hi, > We were doing some code optimizations , running DPDK based applications, and > chanced upon the rte_rdtsc function [ to read tsc timestamp register value ] > consuming cpu cycles of the order of 100clock cycles with a delta of upto > 40cycles

[dpdk-dev] [PATCH] Clean up rte_memcpy.h file

2015-04-15 Thread Pawel Wodkowski
On 2015-04-14 23:31, Ravi Kerur wrote: > + > + for (i = 0; i < 8; i++) { > + ymm = _mm256_loadu_si256((const __m256i *)(src + i * > 32)); > + _mm256_storeu_si256((__m256i *)(dst + i * 32), ymm); > + } > + > n -= 256; >

[dpdk-dev] [PATCH 5/5] bond mode 4: tests for external state machine

2015-04-10 Thread Pawel Wodkowski
On 2015-04-06 19:01, Eric Kinzie wrote: > > +static void > +lacp_recv_cb(uint8_t slave_id, struct rte_mbuf *lacp_pkt) > +{ > + lacpdu_rx_count[slave_id]++; > + RTE_VERIFY(lacp_pkt != NULL); > + rte_pktmbuf_free(lacp_pkt); > +} > + Would be nice to check here if it is valid LACP

[dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine

2015-04-10 Thread Pawel Wodkowski
Hi Eric Please see my comments. On 2015-04-06 19:01, Eric Kinzie wrote: >Provide functions to allow an external 802.3ad state machine to transmit >and recieve LACPDUs and to set the collection/distribution flags on >slave interfaces. > > Signed-off-by: Eric Kinzie > --- >

[dpdk-dev] [PATCH 3/5] bond mode 4: do not ignore multicast

2015-04-10 Thread Pawel Wodkowski
ddr(_mac, > >d_addr { > + (!is_multicast_ether_addr(>d_addr) > && > + !is_same_ether_addr(_mac, > >d_addr) { > You can drop extra parenthesis here, but beside that I think it is OK. Should be marked as bugfix. Acked-by: Pawel Wodkowski

[dpdk-dev] [PATCH 2/5] bond mode 4: copy entire config structure

2015-04-10 Thread Pawel Wodkowski
gt;rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks; > } > > void > This is bugfix. Acked-by: Pawel Wodkowski -- Pawel

[dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine

2015-04-07 Thread Pawel Wodkowski
On 2015-04-07 16:18, Pawel Wodkowski wrote: > > Also, maybe a renaming "external_sm" to "state_machine_cb", set it to > against default one and using it without "if()" will simplify code. It > is no crucial but will eliminate couple of if's. In > rte

[dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine

2015-04-07 Thread Pawel Wodkowski
On 2015-04-06 19:01, Eric Kinzie wrote: Interesting patch. I will closer look at this tomorrow. For now I have first comments: > +static void bond_mode_8023ad_ext_periodic_cb(void *arg); > + > #ifdef RTE_LIBRTE_BOND_DEBUG_8023AD > #define MODE4_DEBUG(fmt, ...) RTE_LOG(DEBUG, PMD, "%6u [Port

[dpdk-dev] [PATCH v2 2/2] test: fix strict aliasing rule error in link bonding mode 4 test

2015-03-27 Thread Pawel Wodkowski
Fix strict aliasing rule error seen in gcc 4.4 Signed-off-by: Pawel Wodkowski --- app/test/test_link_bonding_mode4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index c35129f..02380f9 100644

[dpdk-dev] [PATCH v2 1/2] test: fix strict aliasing rule error in virtual pmd

2015-03-27 Thread Pawel Wodkowski
Fix strict aliasing rule error seen in gcc 4.4 Signed-off-by: Pawel Wodkowski --- app/test/virtual_pmd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 9b07ab1..f163562 100644 --- a/app/test/virtual_pmd.c

[dpdk-dev] [PATCH] hash: fix breaking strict-aliasing rules

2015-03-20 Thread Pawel Wodkowski
On 2015-03-18 17:51, Yerden Zhumabekov wrote: > > - switch (7 - (data_len & 0x07)) { > + i = 7 - (data_len & 0x07); > + switch (i) { > case 0: > - temp |= (uint64_t) *((const uint8_t *)p64 + 6) << 48; > - /* Fallthrough */ > case 1: > -

[dpdk-dev] [PATCH] hash: fix breaking strict-aliasing rules

2015-03-20 Thread Pawel Wodkowski
On 2015-03-18 17:51, Yerden Zhumabekov wrote: > Fix rte_hash_crc() function. Casting uint64_t pointer to uin32_t > may trigger a compiler warning about breaking strict-aliasing rules. > To avoid that, introduce a lookup table which is used to mask out > a remainder of data. > > See issue #1,

[dpdk-dev] [PATCH 2/2] doc: add jobstats library and application release notes

2015-03-20 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- doc/guides/rel_notes/new_features.rst | 2 ++ doc/guides/rel_notes/supported_features.rst | 4 2 files changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/new_features.rst b/doc/guides/rel_notes/new_features.rst index b8d4ea4..6acfe0c 100644

[dpdk-dev] [PATCH 1/2] doc: update bonding mode 6 release notes

2015-03-20 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- doc/guides/rel_notes/new_features.rst | 2 +- doc/guides/rel_notes/supported_features.rst | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/new_features.rst b/doc/guides/rel_notes/new_features.rst index

[dpdk-dev] [PATCH 0/2] doc: update release notes for jobstats and bonding mode 6

2015-03-20 Thread Pawel Wodkowski
Update release notes for jobstats and bonding mode 6. Pawel Wodkowski (2): doc: update bonding mode 6 release notes doc: add jobstats library and application release notes doc/guides/rel_notes/new_features.rst | 4 +++- doc/guides/rel_notes/supported_features.rst | 9 - 2

[dpdk-dev] [PATCH] ixgbe: fix buffer overrun bug in non-bulk alloc mode setup

2015-03-19 Thread Pawel Wodkowski
From: Pawel Wodkowski <pawelx.wdkow...@intel.com> When bulk alloc is enabled at compile time but preconditions for it are not met at runtime the ixgbe_reset_rx_queue() function overrides rxq->sw_ring not allocated elements. Fixes: 01fa1d6 ("ixgbe: unify Rx setup") Signed-off-

[dpdk-dev] [PATCH v2] doc: add l2fwd-jobstats user guide

2015-03-18 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- Changes v2 1. Fix trailing spaces and typos. 2. Add maintaners claim MAINTAINERS | 1 + doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample_app_ug/l2_forward_job_stats.rst | 637

[dpdk-dev] [PATCH] doc: add l2fwd-jobstats user guide

2015-03-11 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample_app_ug/l2_forward_job_stats.rst | 637 ++ 2 files changed, 638 insertions(+) create mode 100644 doc/guides/sample_app_ug/l2_forward_job_stats.rst diff --git a/doc

[dpdk-dev] [PATCH v6] af_packet: Fix some klocwork errors

2015-03-10 Thread Pawel Wodkowski
On 2015-03-10 09:49, Ouyang, Changchun wrote: > > >> -Original Message- >> From: Wodkowski, PawelX >> Sent: Tuesday, March 10, 2015 4:37 PM >> To: Ouyang, Changchun; dev at dpdk.org >> Cc: linville at tuxdriver.com; nhorman at tuxdriver.com >> Subject: Re: [PATCH v6] af_packet: Fix some

[dpdk-dev] [PATCH v6] af_packet: Fix some klocwork errors

2015-03-10 Thread Pawel Wodkowski
> - > - return 0; > +exit: > + if (kvlist != NULL) No need for if(). This part was fine previous patch. > + rte_kvargs_free(kvlist); > + return ret; > } > > static struct rte_driver pmd_af_packet_drv = { > -- Pawel

[dpdk-dev] [PATCH 1/2] example: fix minor bug in l2fwd-jobstats init sequence

2015-03-09 Thread Pawel Wodkowski
On 2015-03-09 17:05, Pawel Wodkowski wrote: > [PATCH 1/2] This is standalone patch. '1/2' generated by accident. -- Pawel

[dpdk-dev] [PATCH 1/2] example: fix minor bug in l2fwd-jobstats init sequence

2015-03-09 Thread Pawel Wodkowski
Fix check of returned values during application init phase. Signed-off-by: Pawel Wodkowski --- examples/l2fwd-jobstats/main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index a5a1aaa..ba9d3c0

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Pawel Wodkowski
On 2015-03-09 11:49, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 09, 2015 10:21 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> - Removed the

[dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to integer of different size

2015-03-04 Thread Pawel Wodkowski
On 2015-03-04 02:58, Qiu, Michael wrote: > On 3/3/2015 9:38 PM, Wodkowski, PawelX wrote: >>> -Original Message- >>> From: Qiu, Michael >>> Sent: Tuesday, March 03, 2015 11:00 AM >>> To: Wodkowski, PawelX; dev at dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast

[dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to integer of different size

2015-03-03 Thread Pawel Wodkowski
> -Original Message- > From: Qiu, Michael > Sent: Tuesday, March 03, 2015 11:00 AM > To: Wodkowski, PawelX; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to > integer of different size > > On 3/3/2015 4:25 PM, Wodkowski, PawelX wrote: > > On

[dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to integer of different size

2015-03-03 Thread Pawel Wodkowski
On 2015-03-03 03:20, Michael Qiu wrote: > /i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error: > cast from pointer to integer of different size > [-Werror=pointer-to-int-cast] > >dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16; > > Type 'long long' is 64-bit in i686 platform

[dpdk-dev] [PATCH] eal: prevent dereferencing NULL pointer in rte_eal_devargs_add()

2015-03-02 Thread Pawel Wodkowski
On 2015-03-02 15:40, Wiles, Keith wrote: > > > On 3/2/15, 6:23 AM, "David Marchand" wrote: > >> Hello Pawel, >> >> On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski >> >> wrote: >> >>> On failure devargs->args should not be ac

[dpdk-dev] [PATCH] A fix to work around strict-aliasing rules breaking

2015-03-02 Thread Pawel Wodkowski
On 2015-03-02 11:32, Bruce Richardson wrote: > On Mon, Mar 02, 2015 at 05:03:50PM +0800, zhihong.wang at intel.com wrote: >> Fixed strict-aliasing rules breaking errors for some GCC version. >> > > This looks messy. Also, I believe the definition of memcpy should include > the "restrict" keyword

[dpdk-dev] [PATCH] eal: prevent dereferencing NULL pointer in rte_eal_devargs_add()

2015-03-02 Thread Pawel Wodkowski
On failure devargs->args should not be accesed if devargs is NULL. Signed-off-by: Pawel Wodkowski --- lib/librte_eal/common/eal_common_devargs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/com

[dpdk-dev] [PATCH] af_packet: Fix some klocwork errors

2015-02-26 Thread Pawel Wodkowski
On 2015-02-26 07:42, Ouyang Changchun wrote: > Fix possible memory leak issue: free kvlist before return; > Fix possible resource lost issue: close qssockfd before return; > > Signed-off-by: Changchun Ouyang > --- > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 11 +-- > 1 file

[dpdk-dev] [PATCH v2 4/4] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

2015-02-25 Thread Pawel Wodkowski
Fix warning reported during static analysis about size_t to int cast when passing parameters to parse_set_list(). This patch fix code formating errors that give checkpatch.pl errors after generating patch. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline_parse_portlist.c | 4

[dpdk-dev] [PATCH v2 3/4] pmd ring: fix possible memory leak during devinit

2015-02-25 Thread Pawel Wodkowski
Free kvlist on function exit to avoid memory leak. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ring/rte_eth_ring.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_ring/rte_eth_ring.c b/lib/librte_pmd_ring/rte_eth_ring.c index a5dc71e..f049bb3

[dpdk-dev] [PATCH v2 2/4] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

2015-02-25 Thread Pawel Wodkowski
By convenction free() functions should ignore NULL parameter. This patch add this behaviour for rte_kvargs_free(). Signed-off-by: Pawel Wodkowski --- lib/librte_kvargs/rte_kvargs.c | 4 lib/librte_kvargs/rte_kvargs.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 1/4] rte_timer: change declaration of rte_timer_cb_t

2015-02-25 Thread Pawel Wodkowski
This patch remove inconsistency between declaration of type rte_timer_cb_t, field f in struct rte_timer and function __rte_timer_reset(). Although compiler treat both of them the same, the static analysis tool like complain about that. Signed-off-by: Pawel Wodkowski --- lib/librte_timer

[dpdk-dev] [PATCH v2 0/4] Fix issues reported by static analysis tool

2015-02-25 Thread Pawel Wodkowski
list sugestions. Pawel Wodkowski (4): rte_timer: change declaration of rte_timer_cb_t librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions pmd ring: fix possible memory leak during devinit cmdline: make parse_set_list() use size_t instead of i

[dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV

2015-02-25 Thread Pawel Wodkowski
On 2015-02-25 04:36, Ouyang, Changchun wrote: >> @@ -652,7 +655,9 @@ ixgbe_get_vf_queues(struct rte_eth_dev *dev, >> >uint32_t vf, uint32_t *msgbuf) { >> >struct ixgbe_vf_info *vfinfo = >> >*IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data- >>> > >dev_private); >> >- uint32_t default_q =

[dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() logic to driver

2015-02-25 Thread Pawel Wodkowski
On 2015-02-25 07:14, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski >> Sent: Thursday, February 19, 2015 11:55 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v4

[dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx and tx nb_q_per_pool

2015-02-25 Thread Pawel Wodkowski
On 2015-02-25 04:24, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski >> Sent: Thursday, February 19, 2015 11:55 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v4 3/7

[dpdk-dev] Cannot compile l2fwd-jobstats example

2015-02-25 Thread Pawel Wodkowski
_64-native-linuxapp-gcc_examples] Error 2 > make: *** [examples] Error 2 > > > As a result of bisecting, it seems after applying below commit, this > error can be seen. > > commit 2caeb8c0141dcf488f2d68aa8e8c44d1f85ed28b > Author: Pawel Wodkowski > Date: Tue Feb 24 17:33:24 2

[dpdk-dev] [PATCH v6 3/3] MAINTAINERS: claim responsibility for rte_jobstats library and example app

2015-02-24 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a771fa3..7b3ef00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,10 @@ F: app/test/test_timer* F: examples/timer/ F: doc/guides/sample_app_ug

[dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example

2015-02-24 Thread Pawel Wodkowski
. Signed-off-by: Pawel Wodkowski --- examples/Makefile|1 + examples/l2fwd-jobstats/Makefile | 51 ++ examples/l2fwd-jobstats/main.c | 1040 ++ mk/rte.app.mk|4 + 4 files changed, 1096 insertions(+) create mode 100644

[dpdk-dev] [PATCH v6 1/3] librte_jobstats: New library for checking core/system/app load

2015-02-24 Thread Pawel Wodkowski
of loops that executed at least one job - executed jobs - time when statistics were reset. Each job provide total/min/max execution time and execution count statistics. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp | 5 + config/common_linuxapp

[dpdk-dev] [PATCH v6 0/3] new rte_jobstats library and example application

2015-02-24 Thread Pawel Wodkowski
thousands separating in stats. - More readable statistics format. Pawel Wodkowski (3): librte_jobstats: New library for checking core/system/app load examples: introduce new l2fwd-jobstats example MAINTAINERS: claim responsibility for rte_jobstats library and example app MAINTAINERS

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

2015-02-24 Thread Pawel Wodkowski
On 2015-02-24 12:05, Olivier MATZ wrote: > On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: >> Free kvlist on function exit to avoid memory leak. >> >> Signed-off-by: Pawel Wodkowski > > Acked-by: Olivier Matz > Please have in mind that this patch depend on patch 2/5 -- Pawel

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Pawel Wodkowski
On 2015-02-23 17:04, Thomas Monjalon wrote: >>> Do you mean that you plan to add some features to this library? >>> > >Is it going to stay at providing some stats or could you make some >>> > >actions >>> > >like time-sharing helpers? >> >What do you mean here saying time-sharing? > I mean

[dpdk-dev] [PATCH 5/5] Fix usage of fgets in various places

2015-02-23 Thread Pawel Wodkowski
Declaration of fgets() is char *fgets(char *str, int size, FILE *stream); Klocwork complain about passing "sizeof()" as size parameter since implicit casting size_t to int might cause loss of precision. Signed-off-by: Pawel Wodkowski --- lib/librte_cfgfile/rte_cfgfile.c

[dpdk-dev] [PATCH 4/5] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

2015-02-23 Thread Pawel Wodkowski
Fix warning reported by klocwork about size_t to int cast when passing parameters to parse_set_list(). This patch fix code formating errors that give checkpatch.pl errors after generating patch. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline_parse_portlist.c | 4 ++-- 1 file

[dpdk-dev] [PATCH 2/5] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

2015-02-23 Thread Pawel Wodkowski
It is desired that all type of *_free() functions mimic behaviour of libc free() function. This function does nothing if given parameter is NULL. This patch add this behaviour for rte_kvargs_free(). Signed-off-by: Pawel Wodkowski --- lib/librte_kvargs/rte_kvargs.c | 4 lib/librte_kvargs

[dpdk-dev] [PATCH 0/5] Fix issues reported by static analysis tool

2015-02-23 Thread Pawel Wodkowski
Klockwork report some issues against current DPDK version. Most of them need only cosmetic code changes (changing type of variable or adding explicit cast). One issue related with ring pmd fix real memory leak problem. Pawel Wodkowski (5): rte_timer: fix invalid declaration of rte_timer_cb_t

[dpdk-dev] [PATCH v4 7/7] pmd ixgbe: fix vlan setting in in PF

2015-02-19 Thread Pawel Wodkowski
nly command 'rx_vlan add VLAN port PORT vf MASK' can enable pointed VLAN id for PF. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ix

[dpdk-dev] [PATCH v4 6/7] tespmd: fix DCB in SRIOV mode support

2015-02-19 Thread Pawel Wodkowski
This patch incorporate fixes to support DCB in SRIOV mode for testpmd. Signed-off-by: Pawel Wodkowski --- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/testpmd.c | 39 +-- app/test-pmd/testpmd.h | 10 -- 3 files changed, 31 insertions(+), 22

[dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV

2015-02-19 Thread Pawel Wodkowski
Enable DCB in SRIOV mode for ixgbe driver. To use DCB in VF PF must configure port as DCB + VMDQ and VF must configure port as DCB only. VF are not allowed to change DCB settings that are common to all ports like number of TC. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ixgbe

[dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() logic to driver

2015-02-19 Thread Pawel Wodkowski
Function rte_eth_dev_check_mq_mode() is driver specific. It should be done in PF configuration phase. This patch move igb/ixgbe driver specific mq check and SRIOV configuration code to driver part. Also rewriting log messages to be shorter and more descriptive. Signed-off-by: Pawel Wodkowski

[dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx and tx nb_q_per_pool

2015-02-19 Thread Pawel Wodkowski
rx and tx number of queue might be different if RX and TX are configured in different mode. This allow to inform VF about proper number of queues. Signed-off-by: Pawel Wodkowski --- lib/librte_ether/rte_ethdev.c | 12 ++-- lib/librte_ether/rte_ethdev.h | 3 ++- lib

[dpdk-dev] [PATCH v4 2/7] pmd igb: fix VMDQ mode checking

2015-02-19 Thread Pawel Wodkowski
RX mode is an enum created by ORing flags. Change compare by value to test a flag when enabling/disabling VLAN filtering during RX queue setup. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_e1000/igb_ethdev.c | 2 +- lib/librte_pmd_e1000/igb_rxtx.c | 2 +- 2 files changed, 2 insertions

[dpdk-dev] [PATCH v4 1/7] ethdev: Allow zero rx/tx queues in SRIOV mode

2015-02-19 Thread Pawel Wodkowski
based NIC and VF count is 16, 32 or 64 all recources are assigned to VFs so PF might be used only for configuration purpose. Signed-off-by: Pawel Wodkowski --- lib/librte_ether/rte_ethdev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/librte_ether

[dpdk-dev] [PATCH v4 0/7] Enable DCB in SRIOV mode for ixgbe driver

2015-02-19 Thread Pawel Wodkowski
patch for easer review. - Remove "pmd: add api version negotiation for ixgbe driver" and "pmd: extend mailbox api to report number of RX/TX queues" patches as those are already already marged from other patch Pawel Wodkowski (7): ethdev: Allow zero rx/tx queues in SRIOV

[dpdk-dev] [PATCH v5 3/3] MAINTAINERS: claim responsibility for headroom library and example app

2015-02-19 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a771fa3..782b585 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,10 @@ F: app/test/test_timer* F: examples/timer/ F: doc/guides/sample_app_ug

[dpdk-dev] [PATCH v5 2/3] examples: introduce new l2fwd-headroom example

2015-02-19 Thread Pawel Wodkowski
-by: Pawel Wodkowski --- examples/Makefile|1 + examples/l2fwd-headroom/Makefile | 51 ++ examples/l2fwd-headroom/main.c | 1040 ++ mk/rte.app.mk|4 + 4 files changed, 1096 insertions(+) create mode 100644

[dpdk-dev] [PATCH v5 1/3] librte_headroom: New library for checking core/system/app load

2015-02-19 Thread Pawel Wodkowski
that executed at least one job - executed jobs - time when statistics were reset. Each job provide total/min/max execution time and execution count statistics. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp | 5 + config/common_linuxapp | 5

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-19 Thread Pawel Wodkowski
new app parameter '-l' for automatic thousands separating in stats. - More readable statistics format. Pawel Wodkowski (3): librte_headroom: New library for checking core/system/app load examples: introduce new l2fwd-headroom example MAINTAINERS: claim responsibility for headroom library

[dpdk-dev] [PATCH v4 2/2] examples: introduce new l2fwd-headroom example

2015-02-17 Thread Pawel Wodkowski
-by: Pawel Wodkowski --- examples/Makefile|1 + examples/l2fwd-headroom/Makefile | 51 ++ examples/l2fwd-headroom/main.c | 1039 ++ mk/rte.app.mk|4 + 4 files changed, 1095 insertions(+) create mode 100644 examples/l2fwd

[dpdk-dev] [PATCH v4 1/2] librte_headroom: New library for checking core/system/app load

2015-02-17 Thread Pawel Wodkowski
at least one job - executed jobs - time when statistics were reset. Each job provide total/min/max execution time and execution count statistics. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp | 5 + config/common_linuxapp | 5 + lib

[dpdk-dev] [PATCH v4 0/2] new headroom stats library and example application

2015-02-17 Thread Pawel Wodkowski
from library to not duplicate tasking library behaviour. - Cleenup/remove useless statistics. - Rework example application to use rte_timer library for jobs selection. - Introduce new app parameter '-l' for automatic thousands separating in stats. - More readable statistics format. Pawel

[dpdk-dev] [PATCH v3 2/2] tespmd: fix DCB in SRIOV mode support

2015-02-17 Thread Pawel Wodkowski
This patch incorporate fixes to support DCB in SRIOV mode for testpmd. Signed-off-by: Pawel Wodkowski --- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/testpmd.c | 39 +-- app/test-pmd/testpmd.h | 10 -- 3 files changed, 31 insertions(+), 22

[dpdk-dev] [PATCH v3 1/2] pmd: enable DCB in SRIOV

2015-02-17 Thread Pawel Wodkowski
This patch enables DCB in SRIOV mode for ixgbe (Niantic) driver. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 +- lib/librte_pmd_ixgbe/ixgbe_pf.c | 19 ++- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 7 +++ 3 files changed, 14 insertions(+), 14

[dpdk-dev] [PATCH v3 0/2] new headroom stats library and example application

2015-02-17 Thread Pawel Wodkowski
. - Cleenup/remove useless statistics. - Rework example application to use rte_timer library for jobs selection. - Introduce new app parameter '-l' for automatic thousands separating in stats. - More readable statistics format. Pawel Wodkowski (2): pmd: enable DCB in SRIOV tespmd: fix DCB

[dpdk-dev] [PATCH v2 2/2] examples: introduce new l2fwd-headroom example

2015-02-17 Thread Pawel Wodkowski
-by: Pawel Wodkowski --- examples/Makefile|1 + examples/l2fwd-headroom/Makefile | 51 ++ examples/l2fwd-headroom/main.c | 1039 ++ mk/rte.app.mk|4 + 4 files changed, 1095 insertions(+) create mode 100644 examples/l2fwd

[dpdk-dev] [PATCH v2 1/2] librte_headroom: New library for checking core/system/app load

2015-02-17 Thread Pawel Wodkowski
at least one job - executed jobs - time when statistics were reset. Each job provide total/min/max execution time and execution count statistics. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp |5 + config/common_linuxapp |5 + lib

[dpdk-dev] [PATCH v2 0/2] new headroom stats library and example application

2015-02-17 Thread Pawel Wodkowski
. - Rework example application to use rte_timer library for jobs selection. - Introduce new app parameter '-l' for automatic thousands separating in stats. - More readable statistics format. Pawel Wodkowski (2): librte_headroom: New library for checking core/system/app load examples: introduce

[dpdk-dev] [PATCH v2] bond: fix 'extern "C"' decls in mode4 header files

2015-01-30 Thread Pawel Wodkowski
v2: Remove 'extern "C"' declarations from bond private header files. v1: Add missing declarations to rte_bond_8023ad.h. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 8 lib/librte_pmd_bond/rte_eth_bond_private.h | 8 2 files

[dpdk-dev] [PATCH 2/2] examples: introduce new l2fwd-headroom example

2015-01-29 Thread Pawel Wodkowski
own application with headroom measurements. Please notice that assigning separate core for printing stats is prefered becouse flushing stdout is terrible slow and might impact headroom statistics. Signed-off-by: Pawel Wodkowski --- examples/Makefile|1 + examples/l2fwd

[dpdk-dev] [PATCH 1/2] librte_headroom: New library for checking core/system/app load

2015-01-29 Thread Pawel Wodkowski
. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp |6 + config/common_linuxapp |6 + lib/Makefile |1 + lib/librte_headroom/Makefile | 50 lib/librte_headroom/rte_headroom.c | 368 +++ lib

[dpdk-dev] [PATCH 0/2] new headroom stats library and example application

2015-01-29 Thread Pawel Wodkowski
, flush and stats) on LCores (execution unit). This example does no limit possible schemes on which this library can be used. Pawel Wodkowski (2): librte_headroom: New library for checking core/system/app load examples: introduce new l2fwd-headroom example config/common_bsdapp

[dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header files

2015-01-27 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_bond/rte_eth_bond_8023ad.h |8 lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h |8 2 files changed, 16 insertions(+) diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h b/lib/librte_pmd_bond

[dpdk-dev] [PATCH v2 4/4] testpmd: fix dcb in vt mode

2015-01-19 Thread Pawel Wodkowski
This patch incorporate fixes to support DCB in SRIOV mode for testpmd. Signed-off-by: Pawel Wodkowski --- app/test-pmd/cmdline.c |4 ++-- app/test-pmd/testpmd.c | 39 +-- app/test-pmd/testpmd.h | 10 -- 3 files changed, 31 insertions(+), 22

[dpdk-dev] [PATCH v2 3/4] pmd: add support for DCB in SRIOV mode for ixgbe driver.

2015-01-19 Thread Pawel Wodkowski
Rx in ETH_MQ_RX_DCB and Tx in ETH_MQ_TX_DCB to use multiple queues and/or DCB. Signed-off-by: Pawel Wodkowski --- lib/librte_ether/rte_ethdev.c | 32 lib/librte_ether/rte_ethdev.h |2 +- lib/librte_pmd_ixgbe/ixgbe_pf.c | 42

[dpdk-dev] [PATCH v2 2/4] ethdev: prevent changing of nb_q_per_pool in rte_eth_dev_check_mq_mode()

2015-01-19 Thread Pawel Wodkowski
is impossible. This patch fix first issue by not changing RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool and second by comparing nb_q_per_pool separately for RX (nb_rx_q_per_pool) and for TX (nb_tx_q_per_pool). Signed-off-by: Pawel Wodkowski --- lib/librte_ether/rte_ethdev.c | 16 ++-- 1 file

[dpdk-dev] [PATCH v2 1/4] ethdev: Allow zero rx/tx queues in SRIOV mode

2015-01-19 Thread Pawel Wodkowski
based NIC and VF count is 16, 32 or 64 all recources are assigned to VFs so PF might be used only for configuration purpose. Signed-off-by: Pawel Wodkowski --- lib/librte_ether/rte_ethdev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/librte_ether

[dpdk-dev] [PATCH v2 0/4] Enable DCB in SRIOV mode for ixgbe driver

2015-01-19 Thread Pawel Wodkowski
(ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB) for each VF and PF for ixgbe driver. As a side effect this allow to use multiple queues for TX in VF (8 if there is 16 or less VFs or 4 if there is 32 or less VFs) when PFC is not enabled. Pawel Wodkowski (4): ethdev: Allow zero rx/tx queues in SRIOV mode ethd

[dpdk-dev] [PATCH v3] alarms: Change alarm cancel function to be thread-safe

2014-10-01 Thread Pawel Wodkowski
v3: Set rte_errno inside rte_alarm_cancel() to inform caller about canceling result. v2: Eliminate a race between rte_alarm_set() used in context of executing callback function and other threads that use rte_alarm_cancel(). Signed-off-by: Pawel Wodkowski --- lib/librte_eal/common/include

[dpdk-dev] [PATCH v2] bond: Add mode 4 support.

2014-09-30 Thread Pawel Wodkowski
-by: Pawel Wodkowski --- lib/librte_ether/rte_ether.h |1 + lib/librte_pmd_bond/Makefile |1 + lib/librte_pmd_bond/rte_eth_bond.h |4 + lib/librte_pmd_bond/rte_eth_bond_8023ad.c | 1070 lib/librte_pmd_bond

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-17 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski Signed-off-by: Maciej T Gajdzica Reviewed-by: Declan Doherty --- lib/librte_ether/rte_ether.h |1 + lib/librte_pmd_bond/Makefile |1 + lib/librte_pmd_bond/rte_eth_bond.h |4 + lib/librte_pmd_bond

[dpdk-dev] [PATCH 1/2] bond: extract common code to separate functions

2014-09-17 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski Reviewed-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_api.c | 59 +--- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 47 ++ lib/librte_pmd_bond/rte_eth_bond_private.h | 30 -- 3 files

[dpdk-dev] [PATCH 0/2] bond: add mode 4 support

2014-09-17 Thread Pawel Wodkowski
This patch set adds support of mode 4 to link bonding pmd. It also introduce some minor changes to the orginal pmd driver to easer integrate mode 4. This patchset depend on Declan Doherty patch set: http://dpdk.org/ml/archives/dev/2014-September/005069.html Pawel Wodkowski (2): bond: Extract

[dpdk-dev] [PATCH] compiling kni module on Ubunutu 12.04 failed

2014-08-20 Thread Pawel Wodkowski
On Ubuntu 12.04.4 file '/proc/version_signature' contains 'Ubuntu 3.11.0-15.25~precise1-generic 3.11.10'. This introduce compilation error since '~precise1' will not be discarded. This patch discards everything after '~' inclusively. Signed-off-by: Pawel Wodkowski --- lib/librte_eal/linuxapp

[dpdk-dev] [PATCH] igb_uio: Remove code that blocks support of some integrated NICs

2014-06-11 Thread Pawel Wodkowski
This patch removes obsolete code that prevents adding integrated copper NICs 82575EB and I350 to list of supported NICs. --- app/test/test_pci.c |1 - lib/librte_eal/common/include/rte_pci_dev_ids.h |8 2 files changed, 9 deletions(-) diff --git