[dpdk-dev] DPDK and HW offloads

2016-03-23 Thread Qiu, Michael
On 3/22/2016 6:20 PM, Richardson, Bruce wrote: > On Tue, Mar 22, 2016 at 05:50:28AM +0000, Qiu, Michael wrote: >> On 3/21/2016 11:27 PM, Kyle Larose wrote: >>> On Mon, Mar 21, 2016 at 10:52 AM, Bruce Richardson >>> wrote: >>>> On Sun, Mar 20, 2016 at

[dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD

2016-03-22 Thread Qiu, Michael
On 3/22/2016 2:51 PM, Marvin Liu wrote: > Build log: > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named > 's6_addr32' in 'struct in6_addr' > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd >

[dpdk-dev] [PATCH] ixgbe: add TX queue number check

2016-03-22 Thread Qiu, Michael
On 3/22/2016 4:10 PM, Wenzhuo Lu wrote: > Ixgbe supports at most 128 TX queues. But in none VT nor DCB mode > the queues 64 ~ 127 should not be used. Ixgbe doesn't do any check > about that. If a queue larger than 64 is used, the TX packets will > be dropped silently. It's hard to debug. > This

[dpdk-dev] [PATCH 1/2 v2] fm10k: Add Atwood Channel Support

2016-03-09 Thread Qiu, Michael
Hi, Bruce What about this patch? Thanks, Michael On 2/4/2016 4:36 PM, Qiu, Michael wrote: > Atwood Channel is intel 25G NIC, and this patch add the support > in DPDK. > > Signed-off-by: Michael Qiu > Acked-by: John McNamara > --- > drivers/net/fm10k/base/fm10k_o

[dpdk-dev] [PATCH v1] virtio: Use cpuflag for vector api

2016-03-04 Thread Qiu, Michael
On 3/2/2016 10:48 AM, Yuanhan Liu wrote: > On Wed, Mar 02, 2016 at 02:10:14AM +0000, Qiu, Michael wrote: >> On 3/1/2016 5:46 PM, Santosh Shukla wrote: >>> On Tue, Mar 1, 2016 at 2:41 PM, Qiu, Michael >>> wrote: >>>> On 2/26/2016 4:53 PM, Santosh Shukla

[dpdk-dev] [PATCH 1/4] ixgbe: support UDP tunnel add/del

2016-03-03 Thread Qiu, Michael
On 1/11/2016 3:08 PM, Wenzhuo Lu wrote: > Add UDP tunnel add/del support on ixgbe. Now it only support > VxLAN port configuration. > Although the VxLAN port has a default value 4789, it can be > changed. We support VxLAN port configuration to meet the > change. > Note, the default value of VxLAN

[dpdk-dev] New driver (large patch) question.

2016-03-03 Thread Qiu, Michael
On 3/3/2016 7:11 AM, Stephen Hurd wrote: > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon > wrote: > >>> The comments in it are the only publicly available >>> documentation on the hardware I'm aware of. >> So you must keep the comments. >> > That's my goal, but the comments are well over the

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-03 Thread Qiu, Michael
On 3/3/2016 11:36 AM, Dhana Eadala wrote: > We found a problem in dpdk-2.2 using under multi-process environment. > Here is the brief description how we are using the dpdk: > > We have two processes proc1, proc2 using dpdk. These proc1 and proc2 are two > different compiled binaries. > proc1 is

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process

2016-03-02 Thread Qiu, Michael
On 3/2/2016 2:57 AM, Dhananjaya Reddy Eadala wrote: > Hi > > We found a problem in dpdk-2.2 using under multi-process environment. > Here is the brief description how we are using the dpdk: > > We have two processes proc1, proc2 using dpdk. These proc1 and proc2 are > two different compiled

[dpdk-dev] [PATCH v9 0/2] Add VHOST PMD

2016-03-02 Thread Qiu, Michael
On 3/1/2016 10:19 AM, Tetsuya Mukawa wrote: > On 2016/03/01 11:00, Qiu, Michael wrote: >> On 2/26/2016 4:36 PM, Tetsuya Mukawa wrote: >>> On 2016/02/26 13:29, Tetsuya Mukawa wrote: >>>> [...] >>>> >>>> BTW, I have set the frontend mergeab

[dpdk-dev] [PATCH v1] virtio: Use cpuflag for vector api

2016-03-02 Thread Qiu, Michael
On 3/1/2016 5:46 PM, Santosh Shukla wrote: > On Tue, Mar 1, 2016 at 2:41 PM, Qiu, Michael wrote: >> On 2/26/2016 4:53 PM, Santosh Shukla wrote: >>> Check cpuflag macro before using vectored api. >>> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so add

[dpdk-dev] [PATCH v1] virtio: Use cpuflag for vector api

2016-03-01 Thread Qiu, Michael
On 2/26/2016 4:53 PM, Santosh Shukla wrote: > Check cpuflag macro before using vectored api. > -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added > cpuflag. > - Also wrap other vectored freind api ie.. > 1) virtqueue_enqueue_recv_refill_simple > 2) virtio_rxq_vec_setup > >

[dpdk-dev] [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array

2016-02-25 Thread Qiu, Michael
On 2/24/2016 4:27 PM, Yuanhan Liu wrote: > On Wed, Feb 24, 2016 at 08:15:36AM +0000, Qiu, Michael wrote: >> On 2/22/2016 10:35 PM, Yuanhan Liu wrote: >>> Broadcast RARP packet by injecting it to receiving mbuf array at >>> rte_vhost_dequeue_burst(). >>> >

[dpdk-dev] [PATCH v9 0/2] Add VHOST PMD

2016-02-25 Thread Qiu, Michael
On 2/24/2016 1:10 PM, Tetsuya Mukawa wrote: > On 2016/02/24 11:45, Qiu, Michael wrote: >> Hi, Tetsuya >> >> When I applied your v6 patch, I could reach 9.5Mpps with 64B packet. >> >> But when apply v9 only 8.4 Mpps, could you figure out why has >> per

[dpdk-dev] [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array

2016-02-24 Thread Qiu, Michael
On 2/22/2016 10:35 PM, Yuanhan Liu wrote: > Broadcast RARP packet by injecting it to receiving mbuf array at > rte_vhost_dequeue_burst(). > > Commit 33226236a35e ("vhost: handle request to send RARP") iterates > all host interfaces and then broadcast it by all of them. It did > notify the

[dpdk-dev] [PATCH v9 0/2] Add VHOST PMD

2016-02-24 Thread Qiu, Michael
Hi, Tetsuya When I applied your v6 patch, I could reach 9.5Mpps with 64B packet. But when apply v9 only 8.4 Mpps, could you figure out why has performance drop? Thanks, Michael On 2/9/2016 5:38 PM, Tetsuya Mukawa wrote: > The patch introduces a new PMD. This PMD is implemented as thin wrapper

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-19 Thread Qiu, Michael
On 2016/2/2 19:03, Ananyev, Konstantin wrote: > [...] I don't think i40e miss it, because it not the right please to disable interrupt. because all interrupts are enabled in init stage. Actually, ixgbe enable the interrupt in init stage, but in dev_start, it

[dpdk-dev] [PATCH 2/2 v2] fm10k: update doc for Atwood Channel

2016-02-05 Thread Qiu, Michael
On 2/4/2016 5:05 PM, Thomas Monjalon wrote: > Hi Michael, > > 2016-02-04 16:36, Michael Qiu: >> Atwood Channel is 25GbE NIC and belongs to Intel FM10K family, >> update the doc for it. >> >> Signed-off-by: Michael Qiu >> Acked-by: John McNamara > Next time, it would be better to send the doc

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-02 Thread Qiu, Michael
On 2/2/2016 11:07 AM, Zhang, Helin wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Tuesday, February 2, 2016 10:57 AM >> To: Zhang, Helin ; Lu, Wenzhuo >> ; dev at dpdk.org >> Cc: Zhou, Danny ; Liu, Yong ; >> Liang, Cunming

[dpdk-dev] [PATCH 1/3] fm10k: enable FTAG based forwarding

2016-02-02 Thread Qiu, Michael
On 1/25/2016 4:08 PM, Wang Xiao W wrote: > This patch enables reading sglort info into mbuf for RX and inserting > an FTAG at the beginning of the packet for TX. The vlan_tci_outer field > selected from rte_mbuf structure for sglort is not used in fm10k now. > In FTAG based forwarding mode, the

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-02 Thread Qiu, Michael
On 2/2/2016 10:14 AM, Zhang, Helin wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Tuesday, February 2, 2016 10:07 AM >> To: Lu, Wenzhuo; dev at dpdk.org >> Cc: Zhou, Danny; Liu, Yong; Liang, Cunming; Zhang, Helin >> Subject: Re: [PATCH

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-02 Thread Qiu, Michael
[+cc helin] On 2/2/2016 9:03 AM, Lu, Wenzhuo wrote: > Hi Michael, > >> -Original Message----- >> From: Qiu, Michael >> Sent: Monday, February 1, 2016 4:05 PM >> To: Lu, Wenzhuo; dev at dpdk.org >> Cc: Zhou, Danny; Liu, Yong; Liang, Cunming >>

[dpdk-dev] i40evf DPDK init_adminq failed: -53

2016-02-01 Thread Qiu, Michael
Hi, Saurabh It's known issue, to fix this you'd better to upgrade the firmware version of i40e. BTW, will it work in guest with kernel driver? If yes, to workaround(somebody reports it does not work for them): Remove i40e.ko in guest, so that it will not auto-loaded when boot up. Hope it works

[dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

2016-02-01 Thread Qiu, Michael
On 1/29/2016 4:07 PM, Lu, Wenzhuo wrote: > Hi Michael, > >> -Original Message----- >> From: Qiu, Michael >> Sent: Friday, January 29, 2016 1:58 PM >> To: dev at dpdk.org >> Cc: Zhou, Danny; Liu, Yong; Liang, Cunming; Lu, Wenzhuo; Qiu, Michael >> Subjec

[dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC

2016-01-29 Thread Qiu, Michael
Hi, Wenzhuo Better to explain what E-tag is, so that reviewers could known it. Thanks, Michael On 1/29/2016 3:05 PM, Wenzhuo Lu wrote: > This patch set adds the support of E-tag offloading and forwarding > on X550. > The offloading means E-tag can be inserted and stripped by HW. > And E-tag

[dpdk-dev] [PATCH] lib/librte_eal: Fix compile issue with gcc 5.3.1

2016-01-28 Thread Qiu, Michael
On 1/28/2016 4:32 PM, Thomas Monjalon wrote: > 2016-01-28 15:30, Michael Qiu: >> In fedora 22 with GCC version 5.3.1, when compile, >> will result an error: >> >> include/rte_memcpy.h:309:7: error: "RTE_MACHINE_CPUFLAG_AVX2" >> is not defined [-Werror=undef] >>

[dpdk-dev] [PATCH 4/4] virtio/vdev: add a new vdev named eth_cvio

2016-01-27 Thread Qiu, Michael
On 1/11/2016 2:43 AM, Tan, Jianfeng wrote: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. > > Configured parameters include: > - rx (optional, 1 by default): number of rx, only allowed to be > 1 for now. > -

[dpdk-dev] [PATCH] eal: add function to check if primary proc alive

2016-01-26 Thread Qiu, Michael
On 1/26/2016 5:04 PM, Van Haaren, Harry wrote: >> From: Qiu, Michael >> On 1/25/2016 7:51 PM, Van Haaren, Harry wrote: >>> Not really, the secondary process will need some CPU, >>> however it can sleep so it doesn't have to use 100% of it. >>> It

[dpdk-dev] [PATCH 0/4] virtio support for container

2016-01-26 Thread Qiu, Michael
On 1/11/2016 2:43 AM, Tan, Jianfeng wrote: > This patchset is to provide high performance networking interface (virtio) > for container-based DPDK applications. The way of starting DPDK apps in > containers with ownership of NIC devices exclusively is beyond the scope. > The basic idea here is to

[dpdk-dev] [PATCH] eal: add function to check if primary proc alive

2016-01-26 Thread Qiu, Michael
On 1/25/2016 7:51 PM, Van Haaren, Harry wrote: >> From: Qiu, Michael >> Subject: Re: [dpdk-dev] [PATCH] eal: add function to check if primary proc >> alive >> >> So secondary will waste a whole lcore to do such polling? > Not really, the secondary process wil

[dpdk-dev] [PATCH] eal: add function to check if primary proc alive

2016-01-25 Thread Qiu, Michael
On 1/20/2016 9:26 PM, Harry van Haaren wrote: > This patch adds a new function to the EAL API: > int rte_eal_primary_proc_alive(const char *path); > > The function indicates if a primary process is alive right now. > This functionality is implemented by testing for a write- > lock on the config

[dpdk-dev] [PATCH] eal: add function to check if primary proc alive

2016-01-25 Thread Qiu, Michael
On 1/23/2016 1:38 AM, Richardson, Bruce wrote: > On Thu, Jan 21, 2016 at 09:02:41AM +, Van Haaren, Harry wrote: >>> From: Qiu, Michael >>> Sent: Thursday, January 21, 2016 6:14 AM >>> To: Van Haaren, Harry ; david.marchand at >>> 6wind.com >>>

[dpdk-dev] [PATCH] eal: add function to check if primary proc alive

2016-01-21 Thread Qiu, Michael
On 1/20/2016 9:26 PM, Harry van Haaren wrote: > This patch adds a new function to the EAL API: > int rte_eal_primary_proc_alive(const char *path); > > The function indicates if a primary process is alive right now. > This functionality is implemented by testing for a write- > lock on the config

[dpdk-dev] Getting error while running DPDK test app on X-Gene1

2016-01-14 Thread Qiu, Michael
On 1/14/2016 12:15 PM, Jerin Jacob wrote: > On Wed, Jan 13, 2016 at 03:52:01PM +0530, Ankit Jindal wrote: >> Hi, >> >> We are trying to run dpdk on our arm64 based SOC having Intel 10G >> ixgbe PCIe card plugged. While running any test app, we are getting >> following error. >> >> EAL: PCI device

[dpdk-dev] Getting error while running DPDK test app on X-Gene1

2016-01-14 Thread Qiu, Michael
Could you show what's exists in /sys/bus/pci/devices/:01:00.0/ Thanks, Michael On 1/13/2016 6:23 PM, Ankit Jindal wrote: > Hi, > > We are trying to run dpdk on our arm64 based SOC having Intel 10G > ixgbe PCIe card plugged. While running any test app, we are getting > following error. >

[dpdk-dev] [PATCH 00/12] Add API to get packet type info

2016-01-13 Thread Qiu, Michael
On 12/31/2015 9:53 PM, Jianfeng Tan wrote: > HAPPRY NEW YEAR! > > A new ether API rte_eth_dev_get_ptype_info() is added to query what > packet type information will be provided by current pmd driver of the > specifed port. > > To achieve this, a new function pointer, dev_ptype_info_get, is added >

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-12-28 Thread Qiu, Michael
Hi, Tetsuya I have a question about your solution, as I know you plan to run qemu and dpdk both in container right? If so, I think it's a bit tricky, DPDK is a lib, and qemu is a App, seems it is not suitable to let a lib depends on Apps. Also, till now I don't see any usecase to run qemu

[dpdk-dev] [PATCH] mk: fix examples build failure

2015-12-28 Thread Qiu, Michael
On 12/24/2015 8:38 PM, steeven lee wrote: > 1. Fix examples build failure > 2. make build as default output folder name > > Signed-off-by: steeven > --- > mk/internal/rte.extvars.mk | 4 ++-- > mk/rte.extsubdir.mk| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

[dpdk-dev] [RFC PATCH 0/2] Reduce DPDK initialization time

2015-12-24 Thread Qiu, Michael
On 11/18/2015 6:30 PM, Zhihong Wang wrote: > This RFC patch aims to reduce DPDK initialization time, which is important in > cases such as micro service. > > Changes are: > > 1. Reduce timer initialization time > > 2. Remove unnecessary hugepage zero-filling operations > > With this patch: > > 1.

[dpdk-dev] [PATCH 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd

2015-12-24 Thread Qiu, Michael
On 12/24/2015 11:07 AM, Zhihong Wang wrote: > Handle SIGINT and SIGTERM in l2fwd. > > Signed-off-by: Zhihong Wang > --- > examples/l2fwd/main.c | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index

[dpdk-dev] [PATCH 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd

2015-12-24 Thread Qiu, Michael
On 12/24/2015 11:07 AM, Zhihong Wang wrote: > Handle SIGINT and SIGTERM in testpmd. > > Signed-off-by: Zhihong Wang > --- > app/test-pmd/testpmd.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index

[dpdk-dev] [PATCH v5 0/6] interrupt mode for fm10k

2015-12-24 Thread Qiu, Michael
On 12/23/2015 3:38 PM, He, Shaopeng wrote: > This patch series adds interrupt mode support for fm10k, > contains four major parts: > > 1. implement rx_descriptor_done function in fm10k > 2. add rx interrupt support in fm10k PF and VF > 3. make sure default VID available in dev_init in fm10k > 4.

[dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET

2015-12-24 Thread Qiu, Michael
On 12/23/2015 8:19 PM, Reshma Pattan wrote: > Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET > are blocking the secondary process from using the APIs. > API access should be given to both secondary and primary. Just as the log says, is it safe to do so? Thanks, Michael > Fix

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2015-12-23 Thread Qiu, Michael
Is it suitable to put so many code in commit log? Thanks, Michael On 12/22/2015 5:36 PM, Didier Pallard wrote: > As demonstrated by the following code, CRC32c computation is not valid > when buffer length is not a multiple of 4 bytes: > (Output obtained by code below) > > CRC of 1 NULL bytes

[dpdk-dev] [PATCH v4 2/6] fm10k: setup rx queue interrupts for PF and VF

2015-12-22 Thread Qiu, Michael
On 12/21/2015 6:20 PM, Shaopeng He wrote: > In interrupt mode, each rx queue can have one interrupt to notify the up > layer application when packets are available in that queue. Some queues > also can share one interrupt. > Currently, fm10k needs one separate interrupt for mailbox. So, only those

[dpdk-dev] [PATCH v2 7/7] doc: release note update for fm10k intr mode

2015-12-22 Thread Qiu, Michael
On 10/26/2015 11:48 AM, He, Shaopeng wrote: > Signed-off-by: Shaopeng He > --- > doc/guides/rel_notes/release_2_2.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/guides/rel_notes/release_2_2.rst > b/doc/guides/rel_notes/release_2_2.rst > index 73dba47..44b3aea 100644 > ---

[dpdk-dev] [PATCH v4 3/6] fm10k: remove rx queue interrupts when dev stops

2015-12-22 Thread Qiu, Michael
On 12/21/2015 6:20 PM, Shaopeng He wrote: > Previous dev_stop function stops the rx/tx queues. This patch adds logic > to disable rx queue interrupt, clean the datapath event and queue/vec map. > > Signed-off-by: Shaopeng He > Acked-by: Jing Chen > --- > drivers/net/fm10k/fm10k_ethdev.c | 22

[dpdk-dev] [PATCH v4 1/6] fm10k: implement rx_descriptor_done function

2015-12-22 Thread Qiu, Michael
On 12/21/2015 6:20 PM, Shaopeng He wrote: > rx_descriptor_done is used by interrupt mode example application > (l3fwd-power) to check rxd DD bit to decide the RX trend, > then l3fwd-power will adjust the cpu frequency according to > the result. > > Signed-off-by: Shaopeng He > Acked-by: Jing Chen

[dpdk-dev] [PATCH] librte_ether: fix crashes in rte_ethdev functions.

2015-12-21 Thread Qiu, Michael
On 2015/12/18 1:24, Bernard Iremonger wrote: > The nb_rx_queues and nb_tx_queues are initialised before > the tx_queue and rx_queue arrays are allocated. The arrays > are allocated when the ethdev port is started. > > If any of the following functions are called before the ethdev > port is started

[dpdk-dev] [PATCH v3] mem: calculate space left in a hugetlbfs

2015-12-21 Thread Qiu, Michael
On 2015/11/18 17:42, Jianfeng Tan wrote: > Currently DPDK does not respect the quota of a hugetblfs mount. > It will fail to init the EAL because it tries to map the number of > free hugepages in the system rather than using the number specified > in the quota for that mount. > > To solve this

[dpdk-dev] Issue with patch "app/testpmd: detect numa socket count"

2015-12-19 Thread Qiu, Michael
d indicate that EAL was able to detect a higher max socket even > though it's not enabled. > > Is there a reason we're not CCing the mailing list? > > > -- Stephen Hurd > > > -Original Message- > From: Qiu, Michael [mailto:michael.qiu at intel.com] >

[dpdk-dev] [PATCH] ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Qiu, Michael
Sorry please ignore this :) Thanks, Michael -Original Message- From: Qiu, Michael Sent: Wednesday, December 9, 2015 4:40 PM To: dev at dpdk.org Cc: Singh, Jasvinder; Dumitrescu, Cristian; root; Qiu, Michael Subject: [PATCH] ip_pipeline: Fix compile issue with strict-aliasing From: root

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
My mistake. please ignore this issue. Thanks, Michael On 2015/12/8 15:08, Qiu, Michael wrote: > Hi, Thomas > > I see you recently merged one commit: > > commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 > Author: Thomas Monjalon > Date: Tue Dec 8 01:50:17 2015 +0100 >

[dpdk-dev] Compile error with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2015-12-08 Thread Qiu, Michael
Hi, Thomas I see you recently merged one commit: commit 8f1c704fb0f1b867471fc692ed2c0fc5610831e2 Author: Thomas Monjalon Date: Tue Dec 8 01:50:17 2015 +0100 mk: fix external library build when combine is enabled The object files are copied to prepare the internal combined library.

[dpdk-dev] [PATCH v2] lib/librte_sched: Fix compile with gcc 4.3.4

2015-12-02 Thread Qiu, Michael
I will make v3 patch to fix the issue. Thanks, Michael On 2015/12/2 10:19, Thomas Monjalon wrote: > 2015-12-02 10:09, Michael Qiu: >> gcc 4.3.4 does not include "immintrin.h", and will post below error: >> lib/librte_sched/rte_sched.c:56:23: error: >> immintrin.h: No such file or

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
tantin ??? > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael >> Sent: Friday, November 27, 2015 11:53 AM >> To: Thomas Monjalon >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compi

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
really?I don't think so. AVX Marco only exist in the gcc version below 4.4, I still need to check if below or beyond 4.4 am I right? Thanks, Michael > ? 2015?11?275:01?Thomas Monjalon ??? > > 2015-11-27 02:26, Qiu, Michael: >>> On 2015/11/27 5:29, Thomas Monjalon wro

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
On 2015/11/27 5:29, Thomas Monjalon wrote: > 2015-11-26 18:49, Michael Qiu: >> gcc 4.3.4 does not include "immintrin.h", and will post below error: >> lib/librte_sched/rte_sched.c:56:23: error: >> immintrin.h: No such file or directory >> >> To avoid this issue, a gcc version check is need

[dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform

2015-11-27 Thread Qiu, Michael
On 2015/11/27 5:15, Thomas Monjalon wrote: > 2015-11-26 09:35, Michael Qiu: >> In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK >> need define as 'ULL' >> >> Signed-off-by: Michael Qiu > This patch is correct but the description is not exact: > I have no issue with my i686 compiler. >

[dpdk-dev] [PATCH] fm10k: fix a crash bug when quit from testpmd

2015-11-17 Thread Qiu, Michael
On 2015/11/12 12:58, Chen Jing D(Mark) wrote: > From: "Chen Jing D(Mark)" > > When the fm10k port is closed, both func tx_queue_clean() and > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > SW ring. The latter func won't do sanity check on those pointers > and cause crash. > >

[dpdk-dev] [PATCH 4/4] fm10k: remove crc size from all byte counters

2015-11-17 Thread Qiu, Michael
Hi, Harry Have you ever tested this patch by yourself? fm10k's stats should already remove the crc bytes by default. After your patch applied, if send a packet without vlan(64 bytes), we expect receive 60 bytes, but it will disappoint you, that only 56 bytes shows in system. Thanks, Michael

[dpdk-dev] [PATCH] PPC64: turn off fm10k driver compilation on IBM POWER

2015-11-04 Thread Qiu, Michael
On 2015/11/4 14:14, Chao Zhu wrote: > The fm10k vector driver is specific for x86 platform which can't compile > on IBM POWER for lacking of tmmintrin.h header file. This patch turns > off fm10k driver compilation on IBM POWER to prevent compile issue. > > Signed-off-by: Chao Zhu Acked-by:

[dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs

2015-11-02 Thread Qiu, Michael
Hi, Bernard Could we merge some patch together? I see lots of patches are simple and doing the same thing but in different NIC, merge them almost have no affect of review, what's more it will make reviewers more comfortable with less and simple patches. Then we could have a clean patch set with

[dpdk-dev] [PATCH v6 00/28] remove pci driver from vdevs

2015-10-30 Thread Qiu, Michael
On 2015/10/30 2:37, Bernard Iremonger wrote: > There is a dummy pci driver in the vdev PMD's at present. > This patch set removes the pci driver from the vdev PMD's. > Changes have been made to librte_ether to handle vdevs and pdevs in the same > way. > > The following vdev PMD's have had the pci

[dpdk-dev] [PATCH v3 0/4] fm10k: add VMDQ support

2015-10-30 Thread Qiu, Michael
On 2015/10/27 17:25, He, Shaopeng wrote: > This patch series adds VMDQ support for fm10k. > It includes the functions to configure VMDQ mode and > add MAC address for each VMDQ queue pool. > It also includes logic to do sanity check for > multi-queue settings. > > Changes in v3: > - Keep device

[dpdk-dev] DPDK patch backlog

2015-10-22 Thread Qiu, Michael
On 2015/10/21 17:05, Thomas Monjalon wrote: > 2015-10-21 11:48, Panu Matilainen: >> On 10/21/2015 11:25 AM, Thomas Monjalon wrote: >>> 2015-10-20 21:34, Stephen Hemminger: Patch backlog is not getting better, now at 486. How can we break this logjam? Do I need to make a new

[dpdk-dev] DPDK patch backlog

2015-10-22 Thread Qiu, Michael
On 2015/10/16 22:25, Neil Horman wrote: > On Fri, Oct 16, 2015 at 10:45:23AM +0200, Thomas Monjalon wrote: >> 2015-10-15 14:44, Stephen Hemminger: >>> There are currently 428 patches in New state in DPDK patchwork. >>> >>> Thomas, could you start reducing that backlog? >> Yes >> >>> The simplest

[dpdk-dev] [PATCH 1/3] fm10k: add multi-queue checking

2015-10-22 Thread Qiu, Michael
On 2015/10/15 19:07, He, Shaopeng wrote: > Hi, Michael > >> -Original Message----- >> From: Qiu, Michael >> Sent: Thursday, October 15, 2015 2:28 PM >> To: He, Shaopeng; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/3] fm10k: add multi-queue checking &

[dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data

2015-10-20 Thread Qiu, Michael
On 2015/10/13 0:26, Bernard Iremonger wrote: > add dev_flags to rte_eth_dev_data, add macros for dev_flags. > add kdrv to rte_eth_dev_data. > add numa_node to rte_eth_dev_data. > add drv_name to rte_eth_dev_data. > use dev_type to distinguish between vdev's and pdev's. > remove pci_dev branches. >

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-20 Thread Qiu, Michael
On 2015/10/20 16:09, Vincent JARDIN wrote: > On 20/10/2015 09:53, Qiu, Michael wrote: >> But as I know it is different all the time, am I right? >> If yes, I don't know what's the value of this field. > It can be used to get some snapshot/instant view informations while we

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-20 Thread Qiu, Michael
On 2015/10/14 19:50, Ananyev, Konstantin wrote: > Hi Amine, > >> -Original Message- >> From: Amine Kherbouche [mailto:amine.kherbouche at 6wind.com] >> Sent: Wednesday, October 14, 2015 12:40 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Subject: Re: [dpdk-dev, PATCHv5, 1/8] ethdev:

[dpdk-dev] [PATCH 1/3] fm10k: add multi-queue checking

2015-10-15 Thread Qiu, Michael
On 2015/9/30 15:29, Shaopeng He wrote: > Add multi-queue checking in device configure process. > Currently, VMDQ and RSS are supported. > > Signed-off-by: Shaopeng He > --- > drivers/net/fm10k/fm10k_ethdev.c | 44 > > 1 file changed, 44 insertions(+) > >

[dpdk-dev] [PATCH v2 1/2] fm10k: enable TSO support

2015-10-13 Thread Qiu, Michael
On 2015/10/12 14:38, Wang Xiao W wrote: > This patch enables fm10k TSO feature for both non-tunneling packet > and tunneling packet. > > Signed-off-by: Wang Xiao W > --- Acked-by: Michael Qiu

[dpdk-dev] [PATCH] librte_eal: Fix wrong header file for old gcc version

2015-10-13 Thread Qiu, Michael
Hi, all Any comments on this? Thanks, Michael On 2015/9/25 10:56, Qiu, Michael wrote: > On 2015/9/7 22:46, Thomas Monjalon wrote: >> 2015-08-24 17:22, Michael Qiu: >>> For __SSE3__, the corresponding header file should be pmmintrin.h, >>> tmmintrin.h works for __S

[dpdk-dev] [PATCH] librte_eal: Fix wrong header file for old gcc version

2015-09-25 Thread Qiu, Michael
On 2015/9/7 22:46, Thomas Monjalon wrote: > 2015-08-24 17:22, Michael Qiu: >> For __SSE3__, the corresponding header file should be pmmintrin.h, >> tmmintrin.h works for __SSSE3__. > Please could you better explain the difference and what is exactly the bug > being fixed? It should solve this

[dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-23 Thread Qiu, Michael
On 2015/9/22 6:40, Stephen Hemminger wrote: > On Wed, 16 Sep 2015 22:51:24 +0100 > Pablo de Lara wrote: > >> This is important to avoid trying to start/stop twice a queue, >> which will result in undefined behaviour >> (which may cause RX/TX disruption). >> >> Mind that only the PMDs which have

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-09-14 Thread Qiu, Michael
Hi, all any other comments about this patch? Thanks, Michael On 8/26/2015 2:12 PM, Liu, Jijiang wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, August 07, 2015 11:29 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev]

[dpdk-dev] [PATCH]doc: Add performance tuning guide about how to get DPDK high perf on Intel platform.

2015-08-10 Thread Qiu, Michael
On 2015/8/10 9:11, Zhang, Helin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Monday, August 10, 2015 6:38 AM >> To: Xu, Qian Q >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH]doc: Add performance tuning guide

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-10 Thread Qiu, Michael
On 2015/8/7 17:13, Ouyang, Changchun wrote: > >> [.../...] >> >> eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *); >> +ether_addr_copy(_eth_addrs[fs->peer_addr], >> +_hdr->d_addr); >> +ether_addr_copy([fs->tx_port].eth_addr, >> +

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 13:37, Zhang, Helin wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Friday, August 7, 2015 11:53 AM >> To: Zhang, Helin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding >>

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 9:06, Zhang, Helin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Thursday, August 6, 2015 8:29 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding >> >> For some

[dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

2015-08-07 Thread Qiu, Michael
On 2015/8/7 9:05, De Lara Guarch, Pablo wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, August 07, 2015 4:29 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum

[dpdk-dev] how to build dpdk in debug mode?

2015-08-04 Thread Qiu, Michael
Please refer dec/build-sdk-quick.txt EXTRA_CFLAGS=-g should work. Thanks, Michael On 2015/8/3 9:29, Thomas Monjalon wrote: > 2015-08-03 16:16, Montorsi, Francesco: >> Hi all, >> I have searched the archives for this, without much success. >> >> Is it possible to build dpdk user-space libraries

[dpdk-dev] [RFC] examples: remove l3fwd-vf example

2015-08-04 Thread Qiu, Michael
Actually, l3fwd works fine with fm10k vf. I don't know what's the exact reason of l3fwd-vf still in DPDK, at least we could make full support for vf in l3fwd instead of another sample with most code are the same compare with l3fwd. Thanks, Michael On 2015/7/22 7:51, Zhang, Helin wrote:

[dpdk-dev] [PATCH v6] Add toeplitz hash algorithm used by RSS

2015-07-29 Thread Qiu, Michael
Hi, Vladimir You need also to fix this issue in i686 platform: RHEL65_32,2.6.32,4.4.7,14.0.0 SUSE11SP3_32,3.0.76-0,4.3.4,14.0.0 i686-native-linuxapp-gcc/include/rte_thash.h:63: error: integer constant is too large for 'long' type i686-native-linuxapp-gcc/include/rte_thash.h:63: error: integer

[dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd

2015-07-28 Thread Qiu, Michael
On 2015/7/8 2:04, Richardson, Bruce wrote: > On Wed, Jul 08, 2015 at 07:16:21AM +0000, Qiu, Michael wrote: [.../...] >>> port = [pi]; >>> if (rte_atomic16_cmpset(&(port->port_status), >>> + R

[dpdk-dev] [PATCH] examples/l3fwd: increase lookup burst size to 8

2015-07-23 Thread Qiu, Michael
Hi, Pablo Is there any performance data for this change? Thanks, Michael -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara Sent: Thursday, July 23, 2015 9:12 AM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH] examples/l3fwd: increase lookup burst size

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

2015-07-14 Thread Qiu, Michael
/2015 1:24 AM, Stephen Hemminger wrote: > On Fri, 10 Jul 2015 07:54:10 + > "Qiu, Michael" wrote: > >> Hi, Stephen >> >> This patch does not work for fm10k with vfio, see error below: >> >> EAL: PCI device :84:00.0 on NUMA socket 1 >> EAL

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

2015-07-14 Thread Qiu, Michael
Hi, Stephen I have found out the root cause of this bug, and generate a patch. Will send out later after :) Thanks, Michael On 7/11/2015 1:24 AM, Stephen Hemminger wrote: > On Fri, 10 Jul 2015 07:54:10 + > "Qiu, Michael" wrote: > >> Hi, Stephen >> >&g

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-07-14 Thread Qiu, Michael
: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >>>>>> On 2015/07/06 20:35, Qiu, Michael wrote: >>>>>>> Hi, all >>>>>>> >>>>>>> As we has gap on the memory release action to be done in which step, >>>>>>&

[dpdk-dev] [PATCH] eal: fix vfio device never works.

2015-07-14 Thread Qiu, Michael
Hi, Tetsuya So this patch make linux app back to original? Thanks, Michael On 7/11/2015 2:30 PM, Tetsuya Mukawa wrote: > The patch fixes vfio initialization issue introduced by below patch. > - Commit 35b3313e322b ("pci: merge mapping functions for linux and bsd") > > Root cause is that

[dpdk-dev] [PATCH] fm10k: fix improper RETA table config

2015-07-10 Thread Qiu, Michael
On 7/10/2015 4:19 PM, Chen, Jing D wrote: > From: "Chen Jing D(Mark)" > > fm10k has 128 RETA entries in 32 registers, but it only initialized > first 32 when doing multiple rx queue configurations. This fix will > initialize all 128 entries instead. > > Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [RFC] vfio: only map regions VFIO supports

2015-07-10 Thread Qiu, Michael
Hi, Stephen This patch does not work for fm10k with vfio, see error below: EAL: PCI device :84:00.0 on NUMA socket 1 EAL: probe driver: 8086:15a4 rte_pmd_fm10k EAL: PCI memory mapped at 0x7f198000 EAL: Trying to map BAR 2 that contains the MSI-X table. Trying offsets: :,

[dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd

2015-07-08 Thread Qiu, Michael
Any comments? This is a bug fix, not a feature. Thanks, Michael On 6/24/2015 3:56 PM, Qiu, Michael wrote: > When close one port twice, testpmd will give out wrong messagse. > > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Port 0 Link Up - speed

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-07-06 Thread Qiu, Michael
On 6/30/2015 9:32 AM, Qiu, Michael wrote: > On 6/30/2015 12:42 AM, Iremonger, Bernard wrote: >>> -Original Message- >>> From: Qiu, Michael >>> Sent: Monday, June 29, 2015 4:22 PM >>> To: Iremonger, Bernard; dev at dpdk.org >>> Cc: Zhang,

[dpdk-dev] [PATCH] fm10k: fix an error message when adding default VLAN

2015-07-02 Thread Qiu, Michael
On 6/26/2015 10:37 AM, He, Shaopeng wrote: > The default MAC address is directly copied to Device Ethernet > Link address array in the device initialize phase, which > bypasses fm10k MAC address number check mechanism, and will > cause an error message when adding default VLAN. Fix it by > moving

[dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize

2015-07-02 Thread Qiu, Michael
Hi, all Any comments on this patch? Thanks, Michael On 6/22/2015 8:47 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Thursday, June 11, 2015 8:30 AM >> To: dev at dpdk.org >> Cc: Iremonger, Bernard; thomas.monja

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-06-29 Thread Qiu, Michael
On 2015/6/29 18:20, Iremonger, Bernard wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Monday, June 29, 2015 9:55 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: Zhang, Helin; Ananyev, Konstantin; mukawa at igel.co.jp; Stephen >&

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 2015/6/29 22:58, Qiu, Michael wrote: > On 2015/6/29 17:54, Iremonger, Bernard wrote: >>> -Original Message- >>> From: Qiu, Michael >>> Sent: Monday, June 29, 2015 10:21 AM >>> To: Iremonger, Bernard; dev at dpdk.org >>> Cc: Chen, Jin

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

2015-06-29 Thread Qiu, Michael
On 2015/6/29 19:08, Ananyev, Konstantin wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael >> Sent: Monday, June 29, 2015 10:21 AM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: He

  1   2   3   >