[dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2016-06-06 Thread Ravi Kerur
gt; > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > > Sent: Tuesday, March 8, 2016 7:01 AM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions > > > > v1: > > This patch adds test case

[dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2016-03-07 Thread Ravi Kerur
v1: This patch adds test cases for rte_memcmp functions. New rte_memcmp functions can be tested via 'make test' and 'testpmd' utility. Compiled and tested on Ubuntu 14.04(non-NUMA) and 15.10(NUMA) systems. Signed-off-by: Ravi Kerur --- app/test/Makefile

[dpdk-dev] [PATCH v1 1/2] rte_memcmp functions using Intel AVX and SSE intrinsics

2016-03-07 Thread Ravi Kerur
v1: This patch adds memcmp functionality using AVX and SSE intrinsics provided by Intel. For other architectures supported by DPDK regular memcmp function is used. Compiled and tested on Ubuntu 14.04(non-NUMA) and 15.10(NUMA) systems. Signed-off-by: Ravi

[dpdk-dev] [PATCH v1 0/2] rte_memcmp functions

2016-03-07 Thread Ravi Kerur
512,45.8233 *** *** 1024, 103.4597 *** *** 2048, 163.5588 *** *** 4096, 232.7368 *** *** 8192, 368.1143 *** *** 16384, 649.0326 *** Test OK RTE>>quit Ravi Kerur (2): rte_memcmp functions using Intel AVX and SSE intrinsics Test cases fo

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-03-02 Thread Ravi Kerur
Hi, Wenzhuo, Bruce, I have superseded old patch with a new submission. Please let me know if that approach is ok. Thanks, Ravi On Tue, Mar 1, 2016 at 5:21 PM, Lu, Wenzhuo wrote: > Hi Ravi, > > > > >Do you want me to resend it as 'v1' and include your comments in commit > message? let me know.

[dpdk-dev] [PATCH v1] I217 and I218 changes

2016-03-02 Thread Ravi Kerur
-linuxapp-clang M. Jay(Intel) had used the patch for DPDK demo. Signed-off-by: Ravi Kerur Acked-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_osdep.h| 26 +++- drivers/net/e1000/em_ethdev.c | 32 + lib

[dpdk-dev] [PATCH v1] I217 and I218 changes

2016-03-02 Thread Ravi Kerur
-linuxapp-clang M. Jay(Intel) had used the patch for DPDK demo. Signed-off-by: Ravi Kerur Acked-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_osdep.h| 26 +++- drivers/net/e1000/em_ethdev.c | 32 + lib

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-03-01 Thread Ravi Kerur
On Mon, Feb 29, 2016 at 9:18 PM, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: Ravi Kerur [mailto:rkerur at gmail.com] > > Sent: Tuesday, March 1, 2016 2:31 AM > > To: Lu, Wenzhuo; dev at dpdk.org > > Cc: Ravi Kerur > > Subject: [

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-02-29 Thread Ravi Kerur
and I218 Intel NICs. Compiled and tested (via testpmd) on Ubuntu 14.04 for target x86_64-native-linuxapp-gcc Compiled for target x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- drivers/net/e1000/base/e1000_osdep.h| 26 +++- drivers

[dpdk-dev] [dpdk-dev, v3] Implement memcmp using Intel SIMD instrinsics.

2016-02-23 Thread Ravi Kerur
On Tue, Feb 23, 2016 at 4:22 AM, Wang, Zhihong wrote: > > > It'd be great if you could format this patch into a patch set with > several > > > little ones. :-) > > > Also, the kernel checkpatch is very helpful. > > > Good coding style and patch organization make it easy for in-depth > reviews. >

[dpdk-dev] [dpdk-dev, v3] Implement memcmp using Intel SIMD instrinsics.

2016-02-19 Thread Ravi Kerur
On Wed, Jan 27, 2016 at 7:08 PM, Zhihong Wang wrote: > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcmp.h b/lib > > /librte_eal/common/include/arch/x86/rte_memcmp.h > > [...] > > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > +/** > > + * Compare bytes between two

[dpdk-dev] [dpdk-dev,v2] Clean up rte_memcpy.h file

2016-02-19 Thread Ravi Kerur
results match the results with baseline. > > > > Signed-off-by: Ravi Kerur > > Acked-by: Stephen Hemminger > > > > --- > > .../common/include/arch/x86/rte_memcpy.h | 340 > +++-- > > 1 file changed, 175 insertions(+), 165

[dpdk-dev] [PATCH v1] Modify and modularize l3fwd code

2015-12-21 Thread Ravi Kerur
> Compiled for > i686-native-linuxapp-gcc > x86_64-native-linuxapp-gcc > x86_x32-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > Tested on > Ubuntu 14.04 (GCC 4.8.4)

[dpdk-dev] [PATCH v1] Modify and modularize l3fwd code

2015-12-21 Thread Ravi Kerur
-L ... (LPM) Options "E" and "L" are mutualy-exclusive. If none selected, "L" is default. Ravi Kerur (1): Modify and modularize l3fwd code examples/l3fwd/Makefile|9 +- examples/l3fwd/l3fwd.h | 209 examples/l3fwd/l3fwd

[dpdk-dev] [PATCH v4] Move rte_mbuf macros to common header file

2015-10-01 Thread Ravi Kerur
86_64-native-linuxapp-clang > x86_64-native-linuxapp-gcc > i686-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and make te

[dpdk-dev] [PATCH v4] Move rte_mbuf macros to common header file

2015-10-01 Thread Ravi Kerur
t; x86_64-native-linuxapp-gcc > i686-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd

[dpdk-dev] [PATCH v2] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
On Wed, Sep 30, 2015 at 12:41 PM, Aaron Conole wrote: > Ravi Kerur writes: > > > Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT > > are defined in each PMD driver file. Move those macros into common > > lib/librte_mbuf/rte_mbuf.h file. PMD drivers inc

[dpdk-dev] [PATCH v3] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
ive-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd Signed-off-by: Ravi Kerur --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x.h

[dpdk-dev] [PATCH v2] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd Signed-off-by: Ravi Kerur --- drivers/net/bnx2x/bnx2x.h | 3 --- drivers/net/cxgbe/sge.c| 3 --- drivers/n

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-30 Thread Ravi Kerur
Hi Tetsuya, On Mon, Sep 28, 2015 at 8:32 PM, Tetsuya Mukawa wrote: > On 2015/09/24 6:22, Ravi Kerur wrote: > > Hi David, Tetsuya, > > > > I have sent V3 (changes isolated to rte_ether component) for formal > review. > > Please look into it and let me know your

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
Thanks Konstantin. I will send out v2 shortly. On Tue, Sep 29, 2015 at 2:55 AM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > > Hi Ravi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur >

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-25 Thread Ravi Kerur
On Thu, Sep 24, 2015 at 4:25 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Thu, 24 Sep 2015 15:50:41 -0700 > Ravi Kerur wrote: > > > Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT > > are defined in each PMD driver file. Mo

[dpdk-dev] [PATCH v1] Add support for Intel chipsets

2015-09-25 Thread Ravi Kerur
On Fri, Sep 25, 2015 at 1:04 AM, Lu, Wenzhuo wrote: > Hi all, > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Friday, September 25, 2015 3:08 PM > > To: Ravi Kerur > > Cc: dev at dpdk.org; Lu, Wenzhu

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-24 Thread Ravi Kerur
for: > x86_64-native-linuxapp-clang > x86_64-native-linuxapp-gcc > i686-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd Signed-off-by: Ravi Ke

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-24 Thread Ravi Kerur
Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT are defined in each PMD driver file. Move those macros into common lib/librte_mbuf/rte_mbuf.h file. All PMD drivers include rte_mbuf.h file directly/indirectly hence no additionl header file inclusion is necessary. Ravi Kerur (1

[dpdk-dev] [PATCH v1] Add support for I217 and I218 Intel 1G chipsets.

2015-09-24 Thread Ravi Kerur
This patch adds I217 and I218 Intel chipsets. Compiled for: > i686-native-linuxapp-gcc > x86_64-native-linuxapp-clang > x86_64-native-linuxapp-gcc > x86_x32-native-linuxapp-gcc Tested on: > x86_64 Ubuntu 14.04 with Intel I218-V and I217-LM chipsets. Signed-off

[dpdk-dev] [PATCH v1] Add support for Intel chipsets

2015-09-24 Thread Ravi Kerur
in the mainline. Ravi Kerur (1): Add support for I217 and I218 Intel 1G chipsets. drivers/net/e1000/base/e1000_api.c | 1 + drivers/net/e1000/base/e1000_hw.h | 1 + drivers/net/e1000/base/e1000_ich8lan.c | 30 +++- drivers/net/e1000/base

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-23 Thread Ravi Kerur
e logic. Let me know if this not correct I can fix both. Thanks, Ravi On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur wrote: > Hi David, > > > On Thu, Sep 3, 2015 at 7:04 AM, David Marchand > wrote: > >> Hello Ravi, Tetsuya, >> >> On Tue, Aug 25, 2015 at 7:59 P

[dpdk-dev] [PATCH v3] Change rte_eal_vdev_init to update port_id

2015-09-23 Thread Ravi Kerur
alidate_abi on Linux for following targets > x86_64-native-linuxapp-gcc > x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- lib/librte_ether/rte_ethdev.c | 116 +++--- 1 file changed, 63 insertions(+), 53 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v3] Send updated port_id in vdev_init functions

2015-09-23 Thread Ravi Kerur
Instead of executing following functions before and after vdev_init > rte_eth_dev_save and > rte_eth_dev_get_changed_port update following functions to return allocated port_id. > rte_eal_vdev_init > rte_eal_probe_one Ravi Kerur (1): Change rte_eal_vdev_init to update p

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-15 Thread Ravi Kerur
Hi David, On Thu, Sep 3, 2015 at 7:04 AM, David Marchand wrote: > Hello Ravi, Tetsuya, > > On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur wrote: > >> Let us know how you want us to fix this? To fix rte_eal_vdev_init and >> rte_eal_pci_probe_one to return allocated por

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-25 Thread Ravi Kerur
attaching diffs (preliminary) with this email. Please let us know your inputs since it involves EAL component. Thanks, Ravi On Thu, Aug 20, 2015 at 8:33 PM, Tetsuya Mukawa wrote: > On 2015/08/21 4:16, Ravi Kerur wrote: > > > > > /** > > > * Uninitalize

[dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2015-08-19 Thread Ravi Kerur
u 14.04, testpmd functionality > FreeBSD 10.1, testpmd functionality Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 3 +- lib/librte_eal/bsdapp/eal/eal_thread.c| 153 -- lib/librte_eal/common/eal_common_thread.c | 147 +++

[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

2015-08-19 Thread Ravi Kerur
In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate fails return error which is inline with other drivers. Signed-off-by: Ravi Kerur --- drivers/net/mpipe/mpipe_tilegx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-19 Thread Ravi Kerur
rgets > x86_64-native-linuxapp-gcc > x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- drivers/net/enic/enic_ethdev.c | 2 +- lib/librte_eal/common/eal_common_dev.c | 13 ++-- lib/librte_eal/common/eal_common_pci.c | 6 +- lib/librte_eal/common/include/rte

[dpdk-dev] [PATCH v2] Send updated port_id in vdev_init functions

2015-08-19 Thread Ravi Kerur
Instead of executing following functions before and after vdev_init > rte_eth_dev_save and > rte_eth_dev_get_changed_port update following functions to return allocated port_id. > rte_eal_vdev_init > rte_eal_probe_one Thanks to Tetsuya for his valuable inputs. R

[dpdk-dev] [PATCH v1] Move EAL thread common functions

2015-08-07 Thread Ravi Kerur
following targets > x86_64-native-bsdapp-clang > x86_64-native-bsdapp-gcc Tested on Linux: > testpmd (pmd_perf_autotest) Tested on FreeBSD: > testpmd Successful run of checkpatch.pl on the diffs Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 3 +-

[dpdk-dev] [PATCH v1] Move eal_thread.c common functions.

2015-08-07 Thread Ravi Kerur
As per Thomas's suggestion we will split remaining files in EAL cleanup effort into multiple patches, eal_thread.c is first in this series. Ravi Kerur (1): Move EAL thread common functions lib/librte_eal/bsdapp/eal/Makefile| 3 +- lib/librte_eal/bsdapp/eal/eal_thread.c| 152

[dpdk-dev] [PATCH v1] Change rte_eal_vdev_init to update port_id

2015-08-07 Thread Ravi Kerur
Hi Tetsuya, On Thu, Aug 6, 2015 at 7:25 PM, Tetsuya Mukawa wrote: > On 2015/08/07 3:04, Ravi Kerur wrote: > > diff --git a/drivers/net/enic/enic_ethdev.c > b/drivers/net/enic/enic_ethdev.c > > index 8280cea..472ef5a 100644 > > --- a/drivers/net/enic/enic_ethdev.c &g

[dpdk-dev] [PATCH v1] Change rte_eal_vdev_init to update port_id

2015-08-06 Thread Ravi Kerur
lose all > port detach 0 Successful run of checkpatch.pl on the diffs Successful validate_abi on Linux for following targets > x86_64-native-linuxapp-gcc > x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- drivers/net/enic/enic_ethdev.c | 2 +- d

[dpdk-dev] lost when learning how to test dpdk

2015-07-30 Thread Ravi Kerur
On Thu, Jul 30, 2015 at 10:06 AM, Ravi Kerur wrote: > > > On Thu, Jul 30, 2015 at 9:19 AM, Jan Viktorin > wrote: > >> OK, I've added the card into RTE_PCI_DEVEM_ID_DECL_EM list. >> Much better now: >> >> EAL: Requesting 64 pages of size 2MB from socket

[dpdk-dev] lost when learning how to test dpdk

2015-07-30 Thread Ravi Kerur
or socket 0 failed > > I've tried both uio_pci_generic and igb_uio. Is there anything else > I can do about it? > I am attaching patch from M Jay/Cuming (Intel engineers), it's not yet integrated into DPDK mainline. You need it to fix above mbuf error. > > Jan V. > > On Thu, 30 J

[dpdk-dev] lost when learning how to test dpdk

2015-07-30 Thread Ravi Kerur
On Thu, Jul 30, 2015 at 5:03 AM, Jan Viktorin wrote: > Hi, > > thanks for reply. I could see those docs but it does not help me a lot. > I still do not understand very well the principle of the tool. How it > chooses the NICs to use? Previously I confused -b in dpdk_nic_bind and > testpmd. They

[dpdk-dev] [PATCH v10 0/3] deduplicate EAL common functions

2015-07-30 Thread Ravi Kerur
Hi Olivier, On Thu, Jul 30, 2015 at 1:12 AM, Olivier MATZ wrote: > Hi Thomas & Ravi, > > > On 07/27/2015 02:59 AM, Thomas Monjalon wrote: > >> 2015-07-27 02:56, Thomas Monjalon: >> >>> v9 was a subset of previous deduplications by Ravi Kerur. >>&

[dpdk-dev] [PATCH v2] Add support for pthreads setname.

2015-07-28 Thread Ravi Kerur
in V1: Add support for _setname_ on Linux and FreeBSD. Signed-off-by: Ravi Kerur --- examples/vhost/Makefile| 1 + examples/vhost/main.c | 21 +++-- examples/vhost_xen/Makefile| 1 + examples

[dpdk-dev] [PATCH v2] Add support for pthread_setname

2015-07-28 Thread Ravi Kerur
sleep piperd Ravi Kerur (1): Add support for pthreads_setname. examples/vhost/Makefile| 1 + examples/vhost/main.c | 21 +++-- examples/vhost_xen/Makefile| 1 + examples/vhost_xen/main.c

[dpdk-dev] [PATCH] Use pthread_setname APIs

2015-07-27 Thread Ravi Kerur
On Mon, Jul 27, 2015 at 2:09 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Mon, 27 Jul 2015 13:40:08 -0700 > Ravi Kerur wrote: > > > On Sun, Jul 26, 2015 at 2:54 PM, Thomas Monjalon < > thomas.monjalon at 6wind.com> > > wrote: > >

[dpdk-dev] [PATCH] Use pthread_setname APIs

2015-07-27 Thread Ravi Kerur
On Sun, Jul 26, 2015 at 2:54 PM, Thomas Monjalon wrote: > Hi Ravi, > It seems to be a nice improvement but it needs some cleanup. > > Checkpatch returns some errors. > > 2015-04-22 14:06, Ravi Kerur: > > use pthread_setname_np and pthread_set_name_np for Linux and

[dpdk-dev] [PATCH v9 0/3] Move EAL common functions

2015-07-25 Thread Ravi Kerur
As per Thomas's suggestion dividing v8 patch into multiple smaller series. This patch contains changes to eal_lcore.c, eal_timer.c and eal_memory.c files. Tested on Ubuntu x86_64 14.04 GCC and Clang Tested on FreeBSD 10.0 x86_64 GCC and Clang testpmd, make test were run successfully. Ravi

[dpdk-dev] [PATCH v9 3/3] Move common functions in eal_memory.c

2015-07-25 Thread Ravi Kerur
/common/ eal_common_memory.c file. Following functions are moved to eal_common_memory.c file static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_memory.c| 52

[dpdk-dev] [PATCH v9 2/3] Move common functions in eal_timer.c

2015-07-25 Thread Ravi Kerur
set_tsc_freq(void); Makefile changes to reflect new file added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_timer.c| 52 +++- lib/librte_eal/common/eal_common_timer.c | 102

[dpdk-dev] [PATCH v9 1/3] Move common functions in eal_lcore.c

2015-07-25 Thread Ravi Kerur
(void); Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in common function. Makefile changes to reflect new file added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_lcore.c| 72

[dpdk-dev] [PATCH v3] Implement memcmp using SIMD intrinsics

2015-06-15 Thread Ravi Kerur
On Fri, Jun 12, 2015 at 1:30 AM, Ond?ej B?lka wrote: > On Mon, May 18, 2015 at 01:01:42PM -0700, Ravi Kerur wrote: > > Background: > > After preliminary discussion with John (Zhihong) and Tim from Intel it > was > > decided that it would be beneficial to use AVX/S

[dpdk-dev] [PATCH v3] Implement memcmp using Intel SIMD instrinsics.

2015-05-18 Thread Ravi Kerur
nges in v1: Initial changes to support memcmp with support upto 128 bytes. Signed-off-by: Ravi Kerur --- app/test/Makefile | 5 +- app/test/autotest_data.py | 19 + app/test/test_hash_perf.c | 36 +- app/test/tes

[dpdk-dev] [PATCH v3] Implement memcmp using SIMD intrinsics

2015-05-18 Thread Ravi Kerur
and performance. Further discussions lead to complete functionality implementation of memory comparison and v3 code reflects that. Test was conducted on Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz, Ubuntu 14.04, x86_64, 16GB DDR3 system. Ravi Kerur (1): Implement memcmp using Intel SIMD instrinsics

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-13 Thread Ravi Kerur
On Wed, May 13, 2015 at 2:03 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, May 12, 2015 at 06:16:20PM -0700, Ravi Kerur wrote: > > On Mon, May 11, 2015 at 3:29 PM, Don Provan wrote: > > > > > I probably shouldn't stick my nose into

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-13 Thread Ravi Kerur
On Wed, May 13, 2015 at 5:21 AM, Jay Rolette wrote: > On Tue, May 12, 2015 at 8:16 PM, Ravi Kerur wrote: > >> On Mon, May 11, 2015 at 3:29 PM, Don Provan wrote: >> >> > I probably shouldn't stick my nose into this, but I can't help myself. >> > >

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-13 Thread Ravi Kerur
gt; > Subject: FW: [dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE > instructions. > > > > > > > > From: Ravi Kerur [mailto:rkerur at gmail.com] > > Sent: Monday, May 11, 2015 9:47 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org > >

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-13 Thread Ravi Kerur
On Wed, May 13, 2015 at 12:22 AM, Linhaifeng wrote: > > > On 2015/5/13 9:18, Ravi Kerur wrote: > > If you can wait until Thursday I will probably send v3 patch which will > > have full memcmp support. > > Ok, I'd like to test it:) > > > > > In your

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-12 Thread Ravi Kerur
Hi Linhaifeng, On Tue, May 12, 2015 at 1:13 AM, Linhaifeng wrote: > Hi, Ravi Kerur > > On 2015/5/9 5:19, Ravi Kerur wrote: > > Preliminary results on Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz, Ubuntu > > 14.04 x86_64 shows comparisons using AVX/SSE instructions taking 1/3rd

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-12 Thread Ravi Kerur
uld be > for a routine that only handles specific sizes to be split into versions > that only take fixed sizes, but I don't know enough about your use > cases to say whether that makes sense here. > > Users of rte_memcmp will be existing dpdk test and library code. -don provan

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-11 Thread Ravi Kerur
Hi Konstantin, On Mon, May 11, 2015 at 12:35 PM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > > Hi Ravi, > > > > > From: Ravi Kerur [mailto:rkerur at gmail.com] > > Sent: Monday, May 11, 2015 6:43 PM > > To: Ananyev, Konstanti

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-11 Thread Ravi Kerur
Hi Konstantin, On Mon, May 11, 2015 at 2:51 AM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > Hi Ravi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > > Sent: Friday, May 08, 2015 11:55

[dpdk-dev] [PATCH v2] Clean up rte_memcpy.h file

2015-05-08 Thread Ravi Kerur
Any inputs here? No functionality change just cleanup. I have run "make test" and "memcpy_perf_autotest". I have not noticed any changes in numbers. On Mon, Apr 20, 2015 at 1:33 PM, Ravi Kerur wrote: > Remove unnecessary type casting in functions. > > Tested on Ubu

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-08 Thread Ravi Kerur
On Fri, May 8, 2015 at 3:29 PM, Matt Laswell wrote: > > > On Fri, May 8, 2015 at 4:19 PM, Ravi Kerur wrote: > >> This patch replaces memcmp in librte_hash with rte_memcmp which is >> implemented with AVX/SSE instructions. >> >> +static inline int >>

[dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions.

2015-05-08 Thread Ravi Kerur
. In addition, hash_perf_autotest results shows using new comparison function results in faster completion of hash operations than existing memcmp in all categories. Signed-off-by: Ravi Kerur --- app/test/test_hash_perf.c | 36 +- .../common/include/arch/ppc_64

[dpdk-dev] [PATCH v2] Implement rte_memcmp with AVX/SSE instructions.

2015-05-08 Thread Ravi Kerur
, 1048576, 8 , 0 , 0.08 , 201.35 jhash , Lookup , 16 , 1048576, 16, 0 , 0.15 , 223.54 Ravi Kerur (1): Implement memcmp using AVX/SSE instructions. app/test/test_hash_perf.c

[dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio

2015-05-05 Thread Ravi Kerur
On Thu, Apr 23, 2015 at 3:26 PM, Ravi Kerur wrote: > > > On Thu, Apr 23, 2015 at 7:00 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > >> On Thu, Apr 23, 2015 at 06:53:44AM -0700, Ravi Kerur wrote: >> > On Thu, Apr 23,

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-30 Thread Ravi Kerur
On Thu, Apr 30, 2015 at 9:00 AM, Neil Horman wrote: > On Wed, Apr 29, 2015 at 10:47:04AM -0700, Ravi Kerur wrote: > > > > I tried to run validate-abi.sh on BSD but ran into errors. If there > is a > > > > way to check against BSD please let me know. > > &

[dpdk-dev] gmake test on freeBSD

2015-04-29 Thread Ravi Kerur
On Wed, Apr 29, 2015 at 1:29 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Apr 28, 2015 at 06:15:53PM -0700, Ravi Kerur wrote: > > DPDK team, > > > > Is there a automated tests to run on freeBSD similar to Linux (make > test). > > &

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-29 Thread Ravi Kerur
> > I tried to run validate-abi.sh on BSD but ran into errors. If there is a > > way to check against BSD please let me know. > > > The ABI checker should work on BSD as far as I know, since it only relies > on > dwarf information in the output binary. What errors are you seeing? >

[dpdk-dev] gmake test on freeBSD

2015-04-28 Thread Ravi Kerur
DPDK team, Is there a automated tests to run on freeBSD similar to Linux (make test). I ran "gmake test T=x86_64-native-bsdapp-clang CC=clang" I get following output /usr/home/rkerur/dpdk-validate-abi-1/dpdk/build/app/test -c f -n 4 Test name Test result

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-28 Thread Ravi Kerur
On Tue, Apr 28, 2015 at 12:35 PM, Neil Horman wrote: > On Mon, Apr 27, 2015 at 03:39:41PM -0700, Ravi Kerur wrote: > > On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman > wrote: > > > > > On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > > > > On Sa

[dpdk-dev] [PATCH v8 6/6] Move common functions in eal_pci.c

2015-04-28 Thread Ravi Kerur
. Changes in v3 N/A Changes in v2 N/A Changes in v1 N/A Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_pci.c| 72 +--- lib/librte_eal/common/eal_common_pci.c | 72 lib/librte_eal/common/eal_private.h| 39

[dpdk-dev] [PATCH v8 5/6] Move common functions in eal_memory.c

2015-04-28 Thread Ravi Kerur
. Following functions are moved to eal_common_memory.c file static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_memory.c| 47 +++ lib/librte_eal/common

[dpdk-dev] [PATCH v8 4/6] Move common functions in eal_timer.c

2015-04-28 Thread Ravi Kerur
to reflect new file added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_timer.c| 52 +++- lib/librte_eal/common/eal_common_timer.c | 102 +++ lib/librte_eal

[dpdk-dev] [PATCH v8 3/6] Move common functions in eal_lcore.c

2015-04-28 Thread Ravi Kerur
to differentiate minor differences in common function. Makefile changes to reflect new file added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_lcore.c| 72 + lib/librte_eal/common

[dpdk-dev] [PATCH v8 2/6] Move common functions in eal.c

2015-04-28 Thread Ravi Kerur
void rte_eal_mcfg_complete(void); int rte_eal_has_hugepages(void); enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id); enum rte_proc_type_t rte_eal_process_type(void); Makefile changes to reflect new files added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib

[dpdk-dev] [PATCH v8 1/6] Move common functions in eal_thread.c

2015-04-28 Thread Ravi Kerur
. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 3 +- lib/librte_eal/bsdapp/eal/eal_thread.c| 152 -- lib/librte_eal/common/eal_common_thread.c | 147 - lib/librte_eal/linuxapp/eal/Makefile | 3 +- lib

[dpdk-dev] [PATCH v8 0/6] Move common functions in EAL

2015-04-28 Thread Ravi Kerur
and x86_64-native-linuxapp-clang). "make test" results match baseline code. testpmd utility on I217/I218 Intel chipset. FreeBSD 10.0 x86_64 Compilation successful (x86_64-native-bsdapp-gcc and x86_64-native-bsdapp-clang). Tested with helloworld, timer and cmdline examples. Ravi Kerur (

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-27 Thread Ravi Kerur
On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman wrote: > On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > > On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman > wrote: > > > > > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > > > O

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-25 Thread Ravi Kerur
On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman wrote: > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > > > > > > &

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > wrote: > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman >> wrote: >> > &g

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > wrote: > > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > > On Fr

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > wrote: > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > >

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > Changes in v7 > > Remove _setname_ pthread calls. > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > Changes in v6 &g

[dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio

2015-04-23 Thread Ravi Kerur
On Thu, Apr 23, 2015 at 7:00 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Thu, Apr 23, 2015 at 06:53:44AM -0700, Ravi Kerur wrote: > > On Thu, Apr 23, 2015 at 2:23 AM, Ananyev, Konstantin < > > konstantin.ananyev at intel.com> wrote: > >

[dpdk-dev] [PATCH v7 6/6] Move common functions in eal_pci.c

2015-04-23 Thread Ravi Kerur
/A Changes in v2 N/A Changes in v1 N/A Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_pci.c| 72 +--- lib/librte_eal/common/eal_common_pci.c | 72 lib/librte_eal/common/eal_private.h| 39 +- lib

[dpdk-dev] [PATCH v7 5/6] Move common functions in eal_memory.c

2015-04-23 Thread Ravi Kerur
are moved to eal_common_memory.c file static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_memory.c| 47 +++ lib/librte_eal/common/eal_common_memory.c

[dpdk-dev] [PATCH v7 4/6] Move common functions in eal_timer.c

2015-04-23 Thread Ravi Kerur
. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_timer.c| 52 +++- lib/librte_eal/common/eal_common_timer.c | 102 +++ lib/librte_eal/common/eal_private.h | 24 lib/librte_eal

[dpdk-dev] [PATCH v7 3/6] Move common functions in eal_lcore.c

2015-04-23 Thread Ravi Kerur
changes to reflect new file added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_lcore.c| 72 + lib/librte_eal/common/eal_common_lcore.c | 107

[dpdk-dev] [PATCH v7 2/6] Move common functions in eal.c

2015-04-23 Thread Ravi Kerur
rte_proc_type_t rte_eal_process_type(void); Makefile changes to reflect new files added. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile | 4 + lib/librte_eal/bsdapp/eal/eal.c | 271 +++- lib/librte_eal/common

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-23 Thread Ravi Kerur
into common directory. Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. Rename eal_thread.c to eal_common_thread.c Makefile changes to reflect file move and name change. Fix checkpatch warnings. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 2 +- lib

[dpdk-dev] [PATCH v7 0/6] Move EAL common functions.

2015-04-23 Thread Ravi Kerur
t; results match baseline code. testpmd utility on I217/I218 Intel chipset. FreeBSD 10.0 x86_64 Compilation successful (x86_64-native-bsdapp-gcc). helloworld. Ravi Kerur (6): Move common functions in eal_thread.c Move common functions in eal.c Move common functions in eal_lcore.c M

[dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio

2015-04-23 Thread Ravi Kerur
t; To: Wodkowski, PawelX > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio > > > > On Thu, Apr 23, 2015 at 09:24:52AM +0200, Pawel Wodkowski wrote: > > > On 2015-04-22 17:33, Ravi Kerur wrote: > > > >+/**

[dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio

2015-04-23 Thread Ravi Kerur
On Thu, Apr 23, 2015 at 12:24 AM, Pawel Wodkowski < pawelx.wodkowski at intel.com> wrote: > On 2015-04-22 17:33, Ravi Kerur wrote: > >> +/** >> + * Compare bytes between two locations. The locations must not overlap. >> + * >> + * @note This is implemente

[dpdk-dev] [PATCH] Use pthread_setname APIs

2015-04-22 Thread Ravi Kerur
test. testpmd with I217 NIC. Check /proc//comm file for names. FreeBSD: Compiled with gcc (x86_64-native-bsdapp-gcc) helloworld/testpmd with I218 NIC. Signed-off-by: Ravi Kerur --- config/common_bsdapp | 5 + config/common_linuxapp

[dpdk-dev] [PATCH] Use pthread_setname APIs

2015-04-22 Thread Ravi Kerur
Add code to set names to threads via pthread APIs. In Linux corresponding _getname_ is available, however, FreeBSD doesn't have corresponding _get_name API available yet. Hence _getname_ is not yet used in the code. Ravi Kerur (1): Use pthread_setname apis config/common_bsdapp

[dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c

2015-04-21 Thread Ravi Kerur
On Tue, Apr 21, 2015 at 7:25 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Sat, Apr 18, 2015 at 12:43:06PM -0700, Ravi Kerur wrote: > > Changes in v6 > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > Add pthread_setname_np/pthread_se

[dpdk-dev] [PATCH v2] Clean up rte_memcpy.h file

2015-04-20 Thread Ravi Kerur
Remove unnecessary type casting in functions. Tested on Ubuntu (14.04 x86_64) with "make test". "make test" results match the results with baseline. "Memcpy perf" results match the results with baseline. Signed-off-by: Ravi Kerur --- .../common/include/arch/x8

  1   2   >