[dpdk-dev] [PATCH v2 3/7] pci: Pass rte_pci_addr to functions instead of separate args

2016-12-01 Thread Shreyansh Jain
Hello Ben, On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > Instead of passing domain, bus, devid, func, just pass > an rte_pci_addr. > > Signed-off-by: Ben Walker > --- > lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +--- > 1 file changed, 13 insertions(+),

[dpdk-dev] [PATCH v2 6/7] pci: Combine rte_eal_pci_scan and rte_eal_pci_probe

2016-11-25 Thread Shreyansh Jain
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > Two functions is both confusing and unnecessary. Previously, > rte_eal_pci_scan populated an internal list of devices by > scanning sysfs. Then, rte_eal_pci_probe would match registered > drivers to that internal list. These are not really

[dpdk-dev] [PATCH v2 4/7] pci: rte_eal_pci_scan now handles removal of PCI devices

2016-11-25 Thread Shreyansh Jain
Hi Ben, On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > rte_eal_pci_scan can be called repeatedly to re-scan the PCI > bus. If a device was removed from the system, the associated > driver will automatically be unloaded. > > Signed-off-by: Ben Walker > --- [...] While reviewing, I

[dpdk-dev] [PATCH v2 3/7] pci: Pass rte_pci_addr to functions instead of separate args

2016-11-25 Thread Shreyansh Jain
>d_name, sizeof(e->d_name), ) > != 0) > continue; > > snprintf(dirname, sizeof(dirname), "%s/%s", > pci_get_sysfs_path(), e->d_name); > - if (pci_scan_one(dirname, domain, bus, devid, function) < 0) > + if (pci_scan_one(dirname, ) < 0) > goto error; > } > closedir(dir); > + > return 0; > > error: > This is much more cleaner than passing all the BDF entries. Except the above unnecessary new line: Acked-by: Shreyansh Jain

[dpdk-dev] [PATCH v2 2/7] pci: Separate detaching ethernet ports from PCI devices

2016-11-25 Thread Shreyansh Jain
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > Attaching and detaching ethernet ports from an application > is not the same thing as physically removing a PCI device, > so clarify the flags indicating support. All PCI devices > are assumed to be physically removable, so no flag is >

[dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources.

2016-11-25 Thread Shreyansh Jain
> + if (ret) { > dev->driver = NULL; > + if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) > + rte_eal_pci_unmap_device(dev); > + } > > return ret; > } > Acked-by: Shreyansh Jain

[dpdk-dev] [RFC PATCH 0/6] Restructure EAL device model for bus support

2016-11-23 Thread Shreyansh Jain
I should have replied to this earlier, apologies. On Sunday 20 November 2016 09:00 PM, David Marchand wrote: > On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain > wrote: >> DPDK has been inherently a PCI inclined framework. Because of this, the >> design of device tree (or

[dpdk-dev] [PATCH v2 3/8] drivers: Use ETH_DEV_PCI_DEV() helper

2016-11-22 Thread Shreyansh Jain
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote: > The drivers should not directly access the rte_eth_dev->pci_dev but use > a macro instead. This is a preparation for replacing the pci_dev with > a struct rte_device member in the future. > > Signed-off-by: Jan Blunck > --- >

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Shreyansh Jain
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote: > This macro is based on Jan Viktorin's original patch but also checks the > type of the passed pointer against the type of the member. > > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > [jblunck at infra

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-22 Thread Shreyansh Jain
On Tuesday 22 November 2016 07:30 AM, Yuanhan Liu wrote: > On Sat, Nov 19, 2016 at 12:57:15AM +0530, Jerin Jacob wrote: >> On Fri, Nov 18, 2016 at 04:04:29PM +, Bruce Richardson wrote: >>> +Thomas >>> >>> On Fri, Nov 18, 2016 at 03:25:18PM +, Bruce Richardson wrote: On Fri, Nov 18,

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Shreyansh Jain
> -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Tuesday, November 22, 2016 6:03 PM > To: Shreyansh Jain > Cc: Thomas Monjalon ; Jan Blunck > ; dev at dpdk.org; david.marchand at 6wind.com > Subject: Re: [dpdk-dev] [PATC

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 22, 2016 3:50 PM > To: Shreyansh Jain ; Jan Blunck > > Cc: dev at dpdk.org; david.marchand at 6wind.com; Jan Viktorin > > Subject: Re: [dpdk-dev] [P

[dpdk-dev] [PATCH] eal: postpone vdev initialization

2016-11-21 Thread Shreyansh Jain
On Sunday 20 November 2016 01:30 PM, Jerin Jacob wrote: > Some platform like octeontx may use pci and > vdev based combined device to represent a logical > dpdk functional device.In such case, postponing the > vdev initialization after pci device > initialization will provide the better view of >

[dpdk-dev] [RFC PATCH 6/6] eal: removing eth_driver

2016-11-18 Thread Shreyansh Jain
sorry for delay in responding; somehow I didn't notice this email. On Thursday 17 November 2016 06:23 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> This patch demonstrates how eth_driver can be replaced with appropriate >> changes for r

[dpdk-dev] [RFC PATCH 0/6] Restructure EAL device model for bus support

2016-11-17 Thread Shreyansh Jain
On Thursday 17 November 2016 05:25 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain > wrote: >> DPDK has been inherently a PCI inclined framework. Because of this, the >> design of device tree (or list) within DPDK is also PCI inclined. A non-PCI >

[dpdk-dev] [RFC PATCH 1/6] eal: define container macro

2016-11-17 Thread Shreyansh Jain
On Thursday 17 November 2016 05:36 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> From: Jan Viktorin >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_eal/common/include/rte_c

[dpdk-dev] [RFC PATCH 2/6] eal: introduce bus-device-driver structure

2016-11-17 Thread Shreyansh Jain
Hello Jan, Thanks for comments. Replies inline. On Thursday 17 November 2016 04:49 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> A device is connected to a bus and services by a driver associated with >> the bus. It is responsibility of t

[dpdk-dev] [RFC PATCH 6/6] eal: removing eth_driver

2016-11-17 Thread Shreyansh Jain
d to extraction relvant xxx type, container_of would have to be used. Signed-off-by: Shreyansh Jain --- drivers/net/ixgbe/ixgbe_ethdev.c | 49 +--- lib/librte_ether/rte_ethdev.c| 36 + lib/librte_ether/rte_ethdev.h| 6

[dpdk-dev] [RFC PATCH 5/6] eal: supporting bus model in init process

2016-11-17 Thread Shreyansh Jain
all the operations for a PCI device, whether binding to a driver or mmap, be moved to PCI bus code base? All of that is not relevant for a bus, but then having multiple implementation areas for a common sub-system (PCI, here) is also not a nice thing. Signed-off-by: Shreyansh Jain

[dpdk-dev] [RFC PATCH 4/6] eal/common: handle bus abstraction for device/driver objects

2016-11-17 Thread Shreyansh Jain
, for example when added a new device (hotplugging). At present rte_driver has the probe hook. This should be wrapped around some API at the bus level so that bus can search through multiple drivers associated with it for calling probe. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common

[dpdk-dev] [RFC PATCH 3/6] bus: add bus driver layer

2016-11-17 Thread Shreyansh Jain
- no work on this has been done yet. Signed-off-by: Shreyansh Jain --- bus/Makefile | 36 bus/pci/Makefile | 37 bus/pci/linuxapp/pci_bus.c | 418 + bus/pci/linuxapp/pci_bus.h | 55 ++ 4 files changed, 546

[dpdk-dev] [RFC PATCH 2/6] eal: introduce bus-device-driver structure

2016-11-17 Thread Shreyansh Jain
bus || | | |+-+| / / +---+ Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_bus.h | 243 lib/librte_eal/common/include/rte_dev.h | 36 ++--- 2 files chan

[dpdk-dev] [RFC PATCH 1/6] eal: define container macro

2016-11-17 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/

[dpdk-dev] [RFC PATCH 0/6] Restructure EAL device model for bus support

2016-11-17 Thread Shreyansh Jain
rt of 17.02 roadmap. [1] http://dpdk.org/ml/archives/dev/2016-November/050186.html Jan Viktorin (1): eal: define container macro Shreyansh Jain (5): eal: introduce bus-device-driver structure bus: add bus driver layer eal/common: handle bus abstraction for device/driver objects eal: suppor

[dpdk-dev] Clarification for eth_driver changes

2016-11-16 Thread Shreyansh Jain
On Monday 14 November 2016 11:08 PM, Ferruh Yigit wrote: [...] > What I was thinking is: > > rte_device/driver are not abstract classes. > > rte_bus device/driver is an abstract class and any bus inherited from > this class. > rte_func device/driver is and abstract class and eth/crypto inherited >

[dpdk-dev] Clarification for eth_driver changes

2016-11-12 Thread Shreyansh Jain
Hello Ferruh, (Please ignore if line wrappings are not correct. Using a possibly unconfigured mail client). > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > Sent: Saturday, November 12, 2016 12:46 AM > To: Shreyansh Jain ; David Marchand

[dpdk-dev] [PATCH v1] doc: fix release notes for 16.11

2016-11-11 Thread Shreyansh Jain
vice naming functions have been generalized from ethdev and cryptodev > to EAL. ``rte_eal_pci_device_name`` has been introduced for obtaining > unique device name from PCI Domain-BDF description. If it is possible to have a Reviewed-by for a particular part of a patch: Reviewed-by: Shreyansh Jain

[dpdk-dev] [PATCH] doc: add sub-repositories information

2016-11-11 Thread Shreyansh Jain
Hello Ferruh, Trivial comment/suggestion: On Thursday 10 November 2016 10:57 PM, Ferruh Yigit wrote: > DPDK switched to main and sub-repositories approach, this patch > documents new approach and updates development process according. > > Signed-off-by: Ferruh Yigit > --- >

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-11-11 Thread Shreyansh Jain
On Thursday 10 November 2016 02:56 PM, Thomas Monjalon wrote: > 2016-11-10 14:40, Shreyansh Jain: >> On Thursday 10 November 2016 01:11 PM, Jianbo Liu wrote: >>> On 10 November 2016 at 14:10, Shreyansh Jain >>> wrote: >>>> On Thursday 10 November 2016 09:0

[dpdk-dev] [PATCH] doc: announce API and ABI changes for librte_eal

2016-11-10 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/deprecation.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 1a9e1ae..2af2476 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
Hello David, On Thursday 10 November 2016 01:46 PM, David Marchand wrote: > Hello Shreyansh, > > On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain > wrote: >> I need some help and clarification regarding some changes I am doing to >> cleanup the EAL code. >> >>

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:11 PM, Jianbo Liu wrote: > On 10 November 2016 at 14:10, Shreyansh Jain > wrote: >> On Thursday 10 November 2016 09:00 AM, Jianbo Liu wrote: >>> >>> On 28 October 2016 at 20:26, Shreyansh Jain >>> wrote: >>>

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:33 PM, Thomas Monjalon wrote: > 2016-11-10 15:51, Jianbo Liu: >> On 10 November 2016 at 15:26, Shreyansh Jain >> wrote: >>> This is what the current outline of eth_driver is: >>> >>> +

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:21 PM, Jianbo Liu wrote: > On 10 November 2016 at 15:26, Shreyansh Jain > wrote: >> Hello David, list, >> >> I need some help and clarification regarding some changes I am doing to >> cleanup the EAL code. >> >> T

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
Hello David, list, I need some help and clarification regarding some changes I am doing to cleanup the EAL code. There are some changes which should be done for eth_driver/rte_eth_device structures: 1. most obvious, eth_driver should be renamed to rte_eth_driver. 2. eth_driver currently has

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 09:00 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> Each SoC PMD registers a set of callback for scanning its own bus/infra and >> matching devices to drivers when probe is called. >> This patch introduces the i

[dpdk-dev] [PATCH v7 08/21] eal/soc: implement SoC device list and dump

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 08:36 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> SoC devices would be linked in a separate list (from PCI). This is used for >> probe function. >> A helper for dumping the d

[dpdk-dev] [PATCH v7 06/21] eal/soc: introduce very essential SoC infra definitions

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 09:39 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> Define initial structures and functions for the SoC infrastructure. >> This patch supports only a very minimal function

[dpdk-dev] [PATCH v7 03/21] eal/linux: generalize PCI kernel unbinding driver to EAL

2016-11-10 Thread Shreyansh Jain
Hello Jianbo, Thanks a lot for your time in commenting this. My comments inline (as well as on other similar mails). On Thursday 10 November 2016 07:54 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> Genera

[dpdk-dev] [PATCH v7 00/21] Introduce SoC device/driver framework for EAL

2016-11-09 Thread Shreyansh Jain
u have given offline/IRC etc.) I was beginning to wonder that probably only Jan and me were the ones interested in this. Ironically, I felt that being EAL changes, a lot of people would come and be critic of it - giving an opportunity to get it widely accepted. > > 2016-10-28 17:

[dpdk-dev] [PATCH] pci: Don't call probe callback if driver already loaded.

2016-11-02 Thread Shreyansh Jain
On 10/26/2016 3:20 AM, Ben Walker wrote: > If the user asks to probe multiple times, the probe > callback should only be called on devices that don't have > a driver already loaded. > > This is useful if a driver is registered after the > execution of a program has started and the list of devices

[dpdk-dev] PCIe Hot Insert/Remove Support

2016-11-02 Thread Shreyansh Jain
Hello Ben, Apologies for joining this discussion late. On 10/24/2016 11:46 PM, Walker, Benjamin wrote: > Hi all, > > My name is Ben Walker and I'm the technical lead for SPDK (it's like DPDK, but > for storage devices). SPDK relies on DPDK only for the base functionality in > the > EAL - memory

[dpdk-dev] [PATCH v7 00/21] Introduce SoC device/driver framework for EAL

2016-10-28 Thread Shreyansh Jain
On Friday 28 October 2016 05:56 PM, Shreyansh Jain wrote: > Introduction: > = > > This patch set is direct derivative of Jan's original series [1],[2]. > > - This version is based on master HEAD (ca41215) > > - In this, I am merging the series [11] bac

[dpdk-dev] [PATCH v7 21/21] eal/crypto: Support rte_soc_driver/device for cryptodev

2016-10-28 Thread Shreyansh Jain
- rte_cryptodev_driver/rte_cryptodev_dev embeds rte_soc_driver/device for linking SoC PMDs to crypto devices. - Add probe and remove functions linked Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 122

[dpdk-dev] [PATCH v7 20/21] ether: introduce ethernet dev probe remove

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 148 +- lib/librte_ether/rte_ethdev.h | 31 + 2 files change

[dpdk-dev] [PATCH v7 19/21] ether: extract function eth_dev_get_intr_handle

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> We abstract access to the intr_handle here as we want to get it either from the pci_dev or soc_dev. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 14 +++

[dpdk-dev] [PATCH v7 18/21] ether: verify we copy info from a PCI device

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Now that different types of ethdev exist, check for presence of PCI dev while copying out the info. Similar would be done for SoC. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte

[dpdk-dev] [PATCH v7 17/21] ether: utilize container_of for pci_drv

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> It is not necessary to place the rte_pci_driver at the beginning of the rte_eth_dev struct anymore as we use the container_of macro to get the parent pointer. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant A

[dpdk-dev] [PATCH v7 16/21] eal/soc: additional features for SoC

2016-10-28 Thread Shreyansh Jain
lready registered Signed-off-by: Jan Viktorin [Shreyansh: merge multiple patches into single set] Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_soc.c | 30 lib/librte_eal/common/eal_private.h | 23 ++ lib/librte_eal/common/include/rte_soc.h | 28 ++

[dpdk-dev] [PATCH v7 15/21] eal/soc: add default scan for Soc devices

2016-10-28 Thread Shreyansh Jain
ed-off-by: Jan Viktorin [Shreyansh: restructure commit to be an optional implementation] Signed-off-by: Shreyansh Jain -- v5: - Update rte_eal_soc_scan to rte_eal_soc_scan_platform_bus - Fix comments over scan and match functions --- lib/librte_eal/common/include/rte_soc.h | 16 +- lib/libr

[dpdk-dev] [PATCH v7 14/21] eal/soc: add intr_handle

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib/libr

[dpdk-dev] [PATCH v7 13/21] eal/soc: add drv_flags

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> The flags are copied from the PCI ones. They should be refactorized into a general set of flags in the future. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.

[dpdk-dev] [PATCH v7 12/21] eal/soc: extend and utilize devargs

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> It is assumed that SoC Devices provided on command line are prefixed with "soc:". This patch adds parse and attach support for such devices. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal ---

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-10-28 Thread Shreyansh Jain
-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal -- v4: - Update test_soc for descriptive test function names - Comments over test functions - devinit and devuninint --> probe/remove - RTE_VERIFY at some places --- app/test/test_so

[dpdk-dev] [PATCH v7 10/21] eal/soc: init SoC infra from EAL

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/Makefile| 1 + lib/librte_eal/bsdapp/eal/eal.c | 4 +++ lib/librte_eal/bsdapp/eal/eal_soc.c

[dpdk-dev] [PATCH v7 09/21] eal: introduce command line enable SoC option

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Support --enable-soc. SoC support is disabled by default. Signed-off-by: Jan Viktorin [Shreyansh: Change --no-soc to --enable-soc; disabled by default] Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- doc/guides/testpmd_

[dpdk-dev] [PATCH v7 08/21] eal/soc: implement SoC device list and dump

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> SoC devices would be linked in a separate list (from PCI). This is used for probe function. A helper for dumping the device list is added. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/libr

[dpdk-dev] [PATCH v7 07/21] eal/soc: add SoC PMD register/unregister logic

2016-10-28 Thread Shreyansh Jain
ed-off-by: Jan Viktorin [Shreyansh: update PMD registration method] Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- app/test/test_soc.c | 111 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 + lib/librte_eal/

[dpdk-dev] [PATCH v7 06/21] eal/soc: introduce very essential SoC infra definitions

2016-10-28 Thread Shreyansh Jain
device/rte_soc_driver. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- app/test/Makefile | 1 + app/test/test_soc.c | 90 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/

[dpdk-dev] [PATCH v7 05/21] eal: define container macro

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/

[dpdk-dev] [PATCH v7 04/21] eal/linux: generalize PCI kernel driver extraction to EAL

2016-10-28 Thread Shreyansh Jain
ed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 7 +++ lib/librte_eal/common/eal_private.h | 14 ++ lib/librte_eal/linuxapp/eal/eal.c | 29 + lib/librte_eal/linuxapp/eal/eal_pci.c | 31 +-- 4 files chang

[dpdk-dev] [PATCH v7 03/21] eal/linux: generalize PCI kernel unbinding driver to EAL

2016-10-28 Thread Shreyansh Jain
tation updated as ENOTSUP Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain -- Changes since v2: - update BSD support for unbind kernel driver --- lib/librte_eal/bsdapp/eal/eal.c | 7 +++ lib/librte_eal/bsdapp/eal/eal_pci.c | 4 ++-- lib/librte_eal/common/eal_private.h

[dpdk-dev] [PATCH v7 02/21] eal: generalize PCI map/unmap resource to EAL

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> The functions pci_map_resource, pci_unmap_resource are generic so the pci_* prefix can be omitted. The functions are moved to the eal_common_dev.c so they can be reused by other infrastructure. Signed-off-by: Jan Viktorin Signed-off-by: Shr

[dpdk-dev] [PATCH v7 01/21] eal: generalize PCI kernel driver enum to EAL

2016-10-28 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain -- Changes since v0: - fix compilation error due to missing include --- lib/librte_eal/common/include/rte_dev.h | 12 lib/librte_eal/common/include/rte_pci.h | 9 --

[dpdk-dev] [PATCH v7 00/21] Introduce SoC device/driver framework for EAL

2016-10-28 Thread Shreyansh Jain
a PCI device ether: extract function eth_dev_get_intr_handle ether: introduce ethernet dev probe remove Shreyansh Jain (2): eal/soc: implement probing of drivers eal/crypto: Support rte_soc_driver/device for cryptodev app/test/Makefile | 1 + app/test/test_

[dpdk-dev] [PATCH v6 21/21] eal/crypto: Support rte_soc_driver/device for cryptodev

2016-10-27 Thread Shreyansh Jain
- rte_cryptodev_driver/rte_cryptodev_dev embeds rte_soc_driver/device for linking SoC PMDs to crypto devices. - Add probe and remove functions linked Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 122

[dpdk-dev] [PATCH v6 20/21] ether: introduce ethernet dev probe remove

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 148 +- lib/librte_ether/rte_ethdev.h | 31 + 2 files change

[dpdk-dev] [PATCH v6 19/21] ether: extract function eth_dev_get_intr_handle

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> We abstract access to the intr_handle here as we want to get it either from the pci_dev or soc_dev. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 14 +++

[dpdk-dev] [PATCH v6 18/21] ether: verify we copy info from a PCI device

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Now that different types of ethdev exist, check for presence of PCI dev while copying out the info. Similar would be done for SoC. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte

[dpdk-dev] [PATCH v6 17/21] ether: utilize container_of for pci_drv

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> It is not necessary to place the rte_pci_driver at the beginning of the rte_eth_dev struct anymore as we use the container_of macro to get the parent pointer. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant A

[dpdk-dev] [PATCH v6 16/21] eal/soc: additional features for SoC

2016-10-27 Thread Shreyansh Jain
lready registered Signed-off-by: Jan Viktorin [Shreyansh: merge multiple patches into single set] Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_soc.c | 30 lib/librte_eal/common/eal_private.h | 23 ++ lib/librte_eal/common/include/rte_soc.h | 28 ++

[dpdk-dev] [PATCH v6 15/21] eal/soc: add default scan for Soc devices

2016-10-27 Thread Shreyansh Jain
ed-off-by: Jan Viktorin [Shreyansh: restructure commit to be an optional implementation] Signed-off-by: Shreyansh Jain -- v5: - Update rte_eal_soc_scan to rte_eal_soc_scan_platform_bus - Fix comments over scan and match functions --- lib/librte_eal/common/include/rte_soc.h | 16 +- lib/libr

[dpdk-dev] [PATCH v6 14/21] eal/soc: add intr_handle

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib/libr

[dpdk-dev] [PATCH v6 13/21] eal/soc: add drv_flags

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> The flags are copied from the PCI ones. They should be refactorized into a general set of flags in the future. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.

[dpdk-dev] [PATCH v6 12/21] eal/soc: extend and utilize devargs

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> It is assumed that SoC Devices provided on command line are prefixed with "soc:". This patch adds parse and attach support for such devices. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal ---

[dpdk-dev] [PATCH v6 10/21] eal/soc: init SoC infra from EAL

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/Makefile| 1 + lib/librte_eal/bsdapp/eal/eal.c | 4 +++ lib/librte_eal/bsdapp/eal/eal_soc.c

[dpdk-dev] [PATCH v6 09/21] eal: introduce command line enable SoC option

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Support --enable-soc. SoC support is disabled by default. Signed-off-by: Jan Viktorin [Shreyansh: Change --no-soc to --enable-soc; disabled by default] Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- doc/guides/testpmd_

[dpdk-dev] [PATCH v6 08/21] eal/soc: implement SoC device list and dump

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> SoC devices would be linked in a separate list (from PCI). This is used for probe function. A helper for dumping the device list is added. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/libr

[dpdk-dev] [PATCH v6 07/21] eal/soc: add SoC PMD register/unregister logic

2016-10-27 Thread Shreyansh Jain
ed-off-by: Jan Viktorin [Shreyansh: update PMD registration method] Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- app/test/test_soc.c | 111 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 + lib/librte_eal/

[dpdk-dev] [PATCH v6 06/21] eal/soc: introduce very essential SoC infra definitions

2016-10-27 Thread Shreyansh Jain
device/rte_soc_driver. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- app/test/Makefile | 1 + app/test/test_soc.c | 90 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/

[dpdk-dev] [PATCH v6 05/21] eal: define container macro

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/

[dpdk-dev] [PATCH v6 04/21] eal/linux: generalize PCI kernel driver extraction to EAL

2016-10-27 Thread Shreyansh Jain
ed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 7 +++ lib/librte_eal/common/eal_private.h | 14 ++ lib/librte_eal/linuxapp/eal/eal.c | 29 + lib/librte_eal/linuxapp/eal/eal_pci.c | 31 +-- 4 files chang

[dpdk-dev] [PATCH v6 03/21] eal/linux: generalize PCI kernel unbinding driver to EAL

2016-10-27 Thread Shreyansh Jain
tation updated as ENOTSUP Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain -- Changes since v2: - update BSD support for unbind kernel driver --- lib/librte_eal/bsdapp/eal/eal.c | 7 +++ lib/librte_eal/bsdapp/eal/eal_pci.c | 4 ++-- lib/librte_eal/common/eal_private.h

[dpdk-dev] [PATCH v6 02/21] eal: generalize PCI map/unmap resource to EAL

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> The functions pci_map_resource, pci_unmap_resource are generic so the pci_* prefix can be omitted. The functions are moved to the eal_common_dev.c so they can be reused by other infrastructure. Signed-off-by: Jan Viktorin Signed-off-by: Shr

[dpdk-dev] [PATCH v6 01/21] eal: generalize PCI kernel driver enum to EAL

2016-10-27 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain -- Changes since v0: - fix compilation error due to missing include --- lib/librte_eal/common/include/rte_dev.h | 12 lib/librte_eal/common/include/rte_pci.h | 9 --

[dpdk-dev] [PATCH v6 00/21] Introduce SoC device/driver framework for EAL

2016-10-27 Thread Shreyansh Jain
e ether: introduce ethernet dev probe remove Shreyansh Jain (2): eal/soc: implement probing of drivers eal/crypto: Support rte_soc_driver/device for cryptodev app/test/Makefile | 1 + app/test/test_soc.c | 404 +++

[dpdk-dev] [PATCH v4] eal: fix lib version for device generalization patches

2016-10-27 Thread Shreyansh Jain
On Thursday 27 October 2016 04:59 PM, Shreyansh Jain wrote: > index aa0c09a..db20567 100644 > --- a/doc/guides/rel_notes/release_16_11.rst > +++ b/doc/guides/rel_notes/release_16_11.rst > @@ -201,6 +201,32 @@ API Changes > * The ``file_name`` data type of ``struct rte_por

[dpdk-dev] [PATCH v4] eal: fix lib version for device generalization patches

2016-10-27 Thread Shreyansh Jain
_device_name API |- moved device naming to EAL Also, deprecation notice from 16.07 has been removed and release notes for 16.11 added. [1] http://dpdk.org/ml/archives/dev/2016-September/047087.html Signed-off-by: Shreyansh Jain -- v4: - fix spelling mistakes and incorrect symbol name in doc

[dpdk-dev] [PATCH v3] eal: fix libabi macro for device generalization patches

2016-10-27 Thread Shreyansh Jain
Hello Thomas, On Thursday 27 October 2016 03:45 PM, Thomas Monjalon wrote: > 2016-10-27 12:38, Shreyansh Jain: >> rte_device/driver generalization patches [1] were merged without a change >> in the LIBABIVER macro. This patches bumps the macro of affected libs. > &

[dpdk-dev] [PATCH v3] eal: fix libabi macro for device generalization patches

2016-10-27 Thread Shreyansh Jain
s been removed and release notes for 16.11 added. [1] http://dpdk.org/ml/archives/dev/2016-September/047087.html Signed-off-by: Shreyansh Jain -- v3: - add API/ABI change info in commit log - fix library version change notification in release note - fix erroneous change to librte_eal version

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

2016-10-27 Thread Shreyansh Jain
On Wednesday 26 October 2016 08:53 PM, Thomas Monjalon wrote: > 2016-10-26 15:25, Ferruh Yigit: >> eal version seems already increased for this release, 2 => 3, in: >> d7e61ad3ae36 ("log: remove deprecated history dump") > > Yes thanks. > >> So NO need to increase it again, sorry for late notice,

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

2016-10-27 Thread Shreyansh Jain
Hello Ferruh, On Wednesday 26 October 2016 07:55 PM, Ferruh Yigit wrote: > Hi Shreyansh, > > On 10/26/2016 2:12 PM, Shreyansh Jain wrote: >> On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote: >>> rte_device/driver generalization patches [1] were

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

2016-10-26 Thread Shreyansh Jain
On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote: > rte_device/driver generalization patches [1] were merged without a change > in the LIBABIVER macro. This patches bumps the macro of affected libs. > > Also, deprecation notice from 16.07 has been removed and release notes

[dpdk-dev] [PATCH] eal: fix libabi macro for device generalization patches

2016-10-26 Thread Shreyansh Jain
On Wednesday 26 October 2016 06:08 PM, Shreyansh Jain wrote: > rte_device/driver generalization patches [1] were merged without a change > in the LIBABIVER macro. This patches bumps the macro of affected libs. > > Also, deprecation notice from 16.07 has been removed and release notes

[dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches

2016-10-26 Thread Shreyansh Jain
rte_device/driver generalization patches [1] were merged without a change in the LIBABIVER macro. This patches bumps the macro of affected libs. Also, deprecation notice from 16.07 has been removed and release notes for 16.11 added. Signed-off-by: Shreyansh Jain -- v2: - Mark bumped libraries

[dpdk-dev] [PATCH] eal: fix libabi macro for device generalization patches

2016-10-26 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/deprecation.rst | 12 doc/guides/rel_notes/release_16_11.rst | 16 lib/librte_cryptodev/Makefile | 2 +- lib/librte_eal/bsdapp/eal/Makefile | 2 +- lib/librte_eal/linuxapp/eal/Makefile | 2

[dpdk-dev] [PATCH v10 11/25] eal/pci: helpers for device name parsing/update

2016-10-26 Thread Shreyansh Jain
Hello Reshma, On Tuesday 25 October 2016 09:19 PM, Pattan, Reshma wrote: > Hi Shreyansh, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shreyansh Jain >> Sent: Friday, September 16, 2016 5:30 AM >> To: dev at dpdk.org >

[dpdk-dev] [PATCH v5 06/21] eal/soc: introduce very essential SoC infra definitions

2016-10-25 Thread Shreyansh Jain
On Tuesday 25 October 2016 11:06 AM, Shreyansh Jain wrote: > Hello Jan, > > On Monday 24 October 2016 09:51 PM, Jan Viktorin wrote: >> On Mon, 24 Oct 2016 17:29:25 +0530 >> Shreyansh Jain wrote: >> >>> From: Jan Viktorin >>> >>> Define initi

[dpdk-dev] mbuf changes

2016-10-25 Thread Shreyansh Jain
On Monday 24 October 2016 09:55 PM, Bruce Richardson wrote: > On Mon, Oct 24, 2016 at 04:11:33PM +, Wiles, Keith wrote: >> >>> On Oct 24, 2016, at 10:49 AM, Morten Br?rup >>> wrote: >>> >>> First of all: Thanks for a great DPDK Userspace 2016! >>> >>> >>> >>> Continuing the Userspace

[dpdk-dev] [PATCH v5 06/21] eal/soc: introduce very essential SoC infra definitions

2016-10-25 Thread Shreyansh Jain
Hello Jan, On Monday 24 October 2016 09:51 PM, Jan Viktorin wrote: > On Mon, 24 Oct 2016 17:29:25 +0530 > Shreyansh Jain wrote: > >> From: Jan Viktorin >> >> Define initial structures and functions for the SoC infrastructure. >> This patch supports only a very m

  1   2   3   4   5   >