[dpdk-dev] [PATCH] enic: fix vlan filtering

2015-10-31 Thread Sujith Sankar (ssujith)
On 30/10/15 9:43 pm, "David Marchand" wrote: >From: Julien Meunier > >Report an error when something went wrong. > >Signed-off-by: Julien Meunier >Signed-off-by: David Marchand >--- > drivers/net/enic/enic_ethdev.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git

[dpdk-dev] [PATCH 2/2] enic: fix hash creation when not using first numa node

2015-09-11 Thread Sujith Sankar (ssujith)
On 11/09/15 1:32 pm, "David Marchand" wrote: >If dpdk is run with memory only available on socket != 0, then hash >creation will fail and flow director feature won't be available. >Fix this by asking for allocation on caller socket. > >Signed-off-by: David Marchand >--- >

[dpdk-dev] [PATCH 1/2] enic: fix allocation when not using first numa node

2015-09-11 Thread Sujith Sankar (ssujith)
On 11/09/15 1:32 pm, "David Marchand" wrote: >Seen by code review. > >If dpdk is run with memory only available on socket != 0, then enic pmd >refuses to initialize ports as this pmd requires some memory on socket 0. >Fix this by setting socket to SOCKET_ID_ANY, so that allocations happen on

[dpdk-dev] [PATCH 2/3] enic: use appropriate key length in hash table

2015-09-04 Thread Sujith Sankar (ssujith)
On 04/09/15 2:35 pm, "Pablo de Lara" wrote: >RTE_HASH_KEY_LENGTH_MAX was deprecated, and the hash table >actually is hosting bigger keys than that size, so key length >has been increased to properly allocate all keys. > >Signed-off-by: Pablo de Lara >--- > drivers/net/enic/enic_clsf.c | 4 ++--

[dpdk-dev] [PATCH 1/2] enic: silence log message

2015-05-21 Thread Sujith Sankar (ssujith)
Stephen, The enic debug flag is off by default. So it is going to print the version only if the user wants it to. Isn?t that fine? Thanks, -Sujith From: Stephen Hemminger <step...@networkplumber.org> Date: Wednesday, 20 May 2015 11:17 pm To: "Sujith Sankar (ssujith)" Cc:

[dpdk-dev] [PATCH v2 06/19] enic: move enic PMD to drivers/net directory

2015-05-20 Thread Sujith Sankar (ssujith)
On 20/05/15 9:44 pm, "Thomas Monjalon" wrote: >2015-05-20 16:04, Richardson, Bruce: >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> > 2015-05-15 16:56, Bruce Richardson: >> > > move enic PMD to drivers/net directory >> > > >> > > Signed-off-by: Bruce Richardson >> > > --- >>

[dpdk-dev] [PATCH 1/2] enic: silence log message

2015-05-20 Thread Sujith Sankar (ssujith)
On 19/05/15 3:38 pm, "Bruce Richardson" wrote: >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: >> From: Stephen Hemminger >> >> Silence is normal. drivers should speak only when spoken to and not >> be chatty. >> >> Signed-off-by: Stephen Hemminger > >Acked-by: Bruce

[dpdk-dev] [PATCH] enicpmd: build changes for FreeBSD

2015-05-07 Thread Sujith Sankar (ssujith)
On 06/05/15 9:19 pm, "Bruce Richardson" wrote: >On Wed, May 06, 2015 at 02:41:00PM +0530, Sujith Sankar wrote: >> This patch adds the changes required to build enic for FreeBSD >> > >Hi, > >I see no issues with this patch, but I suggest the description for it >should >be changed. There is no

[dpdk-dev] [PATCH] enic: disable debug traces

2015-04-08 Thread Sujith Sankar (ssujith)
On 07/04/15 11:10 pm, "Thomas Monjalon" wrote: >The function name is printed in each enic_ethdev function. >Disable it by default with a new build option. > >Signed-off-by: Thomas Monjalon >--- > config/common_bsdapp | 1 + > config/common_linuxapp| 1 + >

[dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2015-03-11 Thread Sujith Sankar (ssujith)
On 27/02/15 4:16 pm, "Thomas Monjalon" wrote: >2015-02-27 08:09, Sujith Sankar: >> Hi Thomas, >> >> No update on it from my side :-( >> It would take some more time for me to start working on it (and flow >> director api) as a few other things are keeping me busy. > >It's unfortunate. >We now

[dpdk-dev] [PATCH] enic: silence log message

2015-02-15 Thread Sujith Sankar (ssujith)
Stephen, Saw your patch. Will take a look. Thanks, -Sujith On 15/02/15 11:43 am, "Sujith Sankar (ssujith)" wrote: >Hi Stephen, David, > >I agree with you and shall submit this change. > >Thanks, >-Sujith > >On 09/02/15 9:41 pm, "Stephen Hemminger"

[dpdk-dev] [PATCH] enic: silence log message

2015-02-15 Thread Sujith Sankar (ssujith)
Hi Stephen, David, I agree with you and shall submit this change. Thanks, -Sujith On 09/02/15 9:41 pm, "Stephen Hemminger" wrote: >Agree it should not use printf. >If you insist on keeping the useless message then it should be log level >debug

[dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2015-01-21 Thread Sujith Sankar (ssujith)
pktgen-dpdk as I was stuck on it. Thanks, -Sujith From: David Marchand mailto:david.march...@6wind.com>> Date: Tuesday, 20 January 2015 4:55 pm To: "Sujith Sankar (ssujith)" mailto:ssujith at cisco.com>> Cc: "dev at dpdk.org<mailto:dev at dpdk.org>" mailto:

[dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface

2014-12-30 Thread Sujith Sankar (ssujith)
On 29/12/14 1:45 pm, "Wu, Jingjing" wrote: >Hi, ssujith > >> +.tx_queue_release = enicpmd_dev_tx_queue_release, >> +.dev_led_on = NULL, >> +.dev_led_off = NULL, >> +.flow_ctrl_get= NULL, >> +.flow_ctrl_set= NULL, >> +

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 4:06 pm, "Burakov, Anatoly" wrote: >> -Original Message- >> From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com] >> Sent: Tuesday, December 16, 2014 10:34 AM >> To: Burakov, Anatoly; Thomas Monjalon >> Cc: dev at dpdk.org

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 3:52 pm, "Burakov, Anatoly" wrote: >> On 16/12/14 4:54 am, "Thomas Monjalon" >> wrote: >> >> >2014-12-12 13:48, Sujith Sankar: >> >> This patch corrects the usage of the flag VFIO_PRESENT in enic >>driver. >> > >> >Please, could you explain why the flag VFIO_PRESENT was not well

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 1:21 pm, "Qiu, Michael" wrote: >On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote: >> On 16/12/14 4:54 am, "Thomas Monjalon" >>wrote: >> >>> 2014-12-12 13:48, Sujith Sankar: >>>> This patch corrects the usage

[dpdk-dev] [PATCH] enic: fix warnings

2014-12-04 Thread Sujith Sankar (ssujith)
On 02/12/14 8:29 pm, "Thomas Monjalon" wrote: >A lot of warnings were not seen because $(WERROR_FLAGS) was not set >in the Makefile. But they appear with toolchains that enforce more checks. > >-Wno-deprecated seems useless. >-Wno-strict-aliasing is added to avoid false positives. > >This

[dpdk-dev] [PATCH] enicpd: Warnings and one error when built using clang compiler

2014-12-01 Thread Sujith Sankar (ssujith)
On 01/12/14 4:27 pm, "Bruce Richardson" wrote: >On Sat, Nov 29, 2014 at 12:47:37PM +0530, Sujith Sankar wrote: >> This patch fixes the warnings and error reported by clang compiler on >>Linux. >> >> Reported-by: Bruce Richardson >> Signed-off-by: Sujith Sankar > >This PMD now compiles up

[dpdk-dev] [PATCH] enicpd: Warnings and one error when built using clang compiler

2014-11-29 Thread Sujith Sankar (ssujith)
On 29/11/14 4:47 pm, "Thomas Monjalon" wrote: >29/11/2014 07:22, Sujith Sankar : >> Sorry for the typo in the subject. It is enicpmd. > >Actually no, it should be enic. Usually we use enic to denote the kernel mode driver and enicpmd to denote the PMD. But it is alright to follow what?s being

[dpdk-dev] [PATCH v2] enicpmd: replace the type u_int* with uint* to remove compilation errors on a few platforms

2014-11-28 Thread Sujith Sankar (ssujith)
On 28/11/14 9:36 pm, "Bruce Richardson" wrote: >On Fri, Nov 28, 2014 at 04:01:00PM +, Sujith Sankar (ssujith) wrote: >> >> >> On 28/11/14 9:22 pm, "Bruce Richardson" >>wrote: >> >> >On Fri, Nov 28, 2014 at 03:08:19PM +05

[dpdk-dev] [PATCH v2] enicpmd: replace the type u_int* with uint* to remove compilation errors on a few platforms

2014-11-28 Thread Sujith Sankar (ssujith)
On 28/11/14 9:22 pm, "Bruce Richardson" wrote: >On Fri, Nov 28, 2014 at 03:08:19PM +0530, Sujith Sankar wrote: >> ENIC PMD was giving compilation errors on ppc_64-power8-linuxapp-gcc >>because >> of types such as u_int32_t. This patch replaces all those with >>uint32_t and >> similar ones. >>

[dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h

2014-11-28 Thread Sujith Sankar (ssujith)
On 28/11/14 1:54 am, "Thomas Monjalon" wrote: >2014-11-27 19:01, Thomas Monjalon: >> 2014-11-27 22:44, Sujith Sankar: >> > Inclusion of vfio.h was giving compilation errors if kernel version >>is less >> > than 3.6.0 and if RTE_EAL_VFIO was on in config. >> > >> > Replaced inclusion of vfio.h

[dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h

2014-11-27 Thread Sujith Sankar (ssujith)
On 27/11/14 10:44 pm, "Sujith Sankar (ssujith)" wrote: >Inclusion of vfio.h was giving compilation errors if kernel version is >less >than 3.6.0 and if RTE_EAL_VFIO was on in config. > >Replaced inclusion of vfio.h with eal_vfio.h and replaced RTE_EAL_VFIO >with &

[dpdk-dev] [PATCH] config: disable enic driver on Power

2014-11-27 Thread Sujith Sankar (ssujith)
Marchand mailto:david.march...@6wind.com>> Date: Thursday, 27 November 2014 5:14 pm To: "Sujith Sankar (ssujith)" mailto:ssujith at cisco.com>> Cc: Chao Zhu mailto:chaozhu at linux.vnet.ibm.com>>, "dev at dpdk.org<mailto:dev at dpdk.org>" mailto:d

[dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2014-11-27 Thread Sujith Sankar (ssujith)
Thanks Thomas, David and Neil ! I shall work on finishing the documentation. About that, you had mentioned that you wanted it in doc/drivers/ path. Could I send a patch with documentation in the path doc/drivers/enicpmd/ ? Thanks, -Sujith On 27/11/14 3:41 am, "Thomas Monjalon" wrote: >> >

[dpdk-dev] [PATCH v5 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2014-11-25 Thread Sujith Sankar (ssujith)
Thanks David. I shall rectify those. Regards, -Sujith From: David Marchand mailto:david.march...@6wind.com>> Date: Tuesday, 25 November 2014 8:58 pm To: "Sujith Sankar (ssujith)" mailto:ssujith at cisco.com>> Cc: "dev at dpdk.org<mailto:dev at dpdk.org>"

[dpdk-dev] [PATCH v3 6/6] DPDK changes for accommodating ENIC PMD

2014-11-24 Thread Sujith Sankar (ssujith)
On 24/11/14 5:47 am, "Neil Horman" wrote: >On Sun, Nov 23, 2014 at 09:38:19PM +0530, Sujith Sankar wrote: >> Signed-off-by: Sujith Sankar >> --- >> config/common_linuxapp | 5 + >> lib/Makefile | 1 + >>

[dpdk-dev] [PATCH v2 5/6] DPDK-ENIC PMD interface

2014-11-21 Thread Sujith Sankar (ssujith)
Thanks for the comments, Neil. I shall include those in v3. Regards, -Sujith On 21/11/14 6:54 pm, "Neil Horman" wrote: >On Fri, Nov 21, 2014 at 10:03:02PM +0530, Sujith Sankar wrote: >> Signed-off-by: Sujith Sankar >> --- >> lib/librte_pmd_enic/enic_etherdev.c | 620

[dpdk-dev] [PATCH v2 2/6] ENIC PMD Makefile

2014-11-21 Thread Sujith Sankar (ssujith)
On 21/11/14 5:03 pm, "Neil Horman" wrote: >On Fri, Nov 21, 2014 at 10:02:59PM +0530, Sujith Sankar wrote: >> Signed-off-by: Sujith Sankar >> --- >> lib/librte_pmd_enic/Makefile | 67 >> >> 1 file changed, 67 insertions(+) >> create mode 100644

[dpdk-dev] [PATCH v2 0/6] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD

2014-11-21 Thread Sujith Sankar (ssujith)
Hi David, Since the kernel version is less than 3.6.0, support for VFIO is not there. Could you please turn off VFIO in config/common_linuxapp and try with IGB_UIO? Thanks, -Sujith From: David Marchand mailto:david.march...@6wind.com>> Date: Friday, 21 November 2014 3:22 pm To: "Su

[dpdk-dev] [PATCH 0/7] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD

2014-11-10 Thread Sujith Sankar (ssujith)
Thanks for the clear response. I?ll take a look at it. Regards, -Sujith On 10/11/14 3:33 pm, "Thomas Monjalon" wrote: >2014-11-10 09:27, Sujith Sankar: >> On 07/11/14 9:17 pm, "Thomas Monjalon" >>wrote: >> >It seems that this PMD is based on DPDK 1.7. >> >Could you rebase it on HEAD? >> >>

[dpdk-dev] [PATCH 3/7] ENIC PMD Makefile

2014-11-10 Thread Sujith Sankar (ssujith)
Neil, If I move the DPDK patch that accommodates ENIC PMD (that is the one that patches lib/Makefile) to the last in the series, builds between commits would succeed, wouldn?t it? Moving that to the last is anyway needed. Thanks, -Sujith On 07/11/14 9:16 pm, "Sujith Sankar (ssujith)&qu

[dpdk-dev] [PATCH 0/7] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD

2014-11-10 Thread Sujith Sankar (ssujith)
Thomas, It is our pleasure to be part of the community and to be contributing to it. Looking forward to a healthy and fruitful association. Thanks and Regards, -Sujith On 07/11/14 4:39 pm, "Thomas Monjalon" wrote: >2014-11-08 01:35, Sujith Sankar: >> ENIC PMD is the poll-mode driver for the

[dpdk-dev] [PATCH 0/7] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD

2014-11-10 Thread Sujith Sankar (ssujith)
Thomas, This patch is based on 1.7.1. Thought that is the latest. And I got the diff from origin. What made you feel that the patch is from 1.7? Regards, -Sujith On 07/11/14 9:17 pm, "Thomas Monjalon" wrote: >Sujith, > >It seems that this PMD is based on DPDK 1.7. >Could you rebase it on

[dpdk-dev] [PATCH 0/7] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD

2014-11-07 Thread Sujith Sankar (ssujith)
Thomas, Let me work on that too. Thanks, -Sujith On 07/11/14 9:17 pm, "Thomas Monjalon" wrote: >Sujith, > >It seems that this PMD is based on DPDK 1.7. >Could you rebase it on HEAD? > >Thank you >-- >Thomas

[dpdk-dev] [PATCH 7/7] Release notes for ENIC PMD 1.0.0.3

2014-11-07 Thread Sujith Sankar (ssujith)
Hi Thomas, Thank you for the comments. I?ll work on moving the release notes to rst and add performance numbers with testpmd. Once I fix these and Neil?s comments, I shall get back with version 2. Thanks, -Sujith On 07/11/14 5:50 pm, "Thomas Monjalon" wrote: >Many informations in the release

[dpdk-dev] [PATCH 3/7] ENIC PMD Makefile

2014-11-07 Thread Sujith Sankar (ssujith)
Hi Neil, Thanks for the comments. I shall work on the modifications that you have suggested and get back with V2. Regards, -Sujith On 07/11/14 5:04 pm, "Neil Horman" wrote: >On Sat, Nov 08, 2014 at 01:35:43AM +0530, Sujith Sankar wrote: >> Signed-off-by: Sujith Sankar >> --- >>

[dpdk-dev] [PATCH 00/16] [RFC] [VFIO] Add VFIO support to DPDK

2014-09-08 Thread Sujith Sankar (ssujith)
h the steps, >although they are basically the same as for VFIO. > >Thanks, >Anatoly > >-Original Message- >From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com] >Sent: Monday, September 8, 2014 9:28 AM >To: Burakov, Anatoly; Stephen Hemminger >Cc: dev at

[dpdk-dev] [PATCH 00/16] [RFC] [VFIO] Add VFIO support to DPDK

2014-09-08 Thread Sujith Sankar (ssujith)
ot; wrote: >Hi Sujith > >Not that I know of, no. There are other ways to run physical NICs in a VM >though, you don't require VFIO for that. > >Thanks, >Anatoly > >-----Original Message- >From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com] >Sent: Mon

[dpdk-dev] [PATCH 00/16] [RFC] [VFIO] Add VFIO support to DPDK

2014-09-08 Thread Sujith Sankar (ssujith)
Hi Anatoly, Has anything happened in this front? Do you see running of DPDK in guest OS on KVM with physical NIC passed through to it happening soon? Thanks, -Sujith On 02/05/14 2:28 pm, "Burakov, Anatoly" wrote: >Hi Stephen, > >> Will this work in guest? or only on bare metal? > >VFIO is

[dpdk-dev] PMD for Cisco VIC Ethernet NIC - Request for guidelines for submission

2014-07-21 Thread Sujith Sankar (ssujith)
Hi Hobywan, We?re still working on benchmarking, and would share the numbers once we are done with it. Could you please elaborate on vectorisation functions? Thanks, -Sujith From: Hobywan Kenoby mailto:hobyw...@hotmail.com>> Date: Friday, 11 July 2014 6:46 pm To: "Sujith Sank

[dpdk-dev] PMD for Cisco VIC Ethernet NIC - Request for guidelines for submission

2014-07-11 Thread Sujith Sankar (ssujith)
of submitting the patch soon. Thanks, -Sujith From: Hobywan Kenoby mailto:hobyw...@hotmail.com>> Date: Thursday, 10 July 2014 1:37 am To: "Sujith Sankar (ssujith)" mailto:ssujith at cisco.com>>, "dev at dpdk.org<mailto:dev at dpdk.org>" mailto:dev at dpdk.org>&g

[dpdk-dev] PMD for Cisco VIC Ethernet NIC - Request for guidelines for submission

2014-05-29 Thread Sujith Sankar (ssujith)
Thank you Anatoly ! I?ll take a look at it and get back in case of questions. -Sujith On 28/05/14 2:22 pm, "Burakov, Anatoly" wrote: >Hi Sujith, > >> One aspect of ENIC PMD is that it works with VFIO-PCI and not UIO. Hope >> this is acceptable. The following thread in dpdk-dev influenced

[dpdk-dev] PMD for Cisco VIC Ethernet NIC - Request for guidelines for submission

2014-05-28 Thread Sujith Sankar (ssujith)
Hi all, We have been working on development of poll-mode driver for Cisco VIC Ethernet NIC and integration of it with DPDK. We would like to submit this poll-mode driver (ENIC PMD) to the DPDK community so that it could be part of the DPDK tree. Could someone please provide the guidelines and

[dpdk-dev] Query on the use of FDIR feature

2014-04-23 Thread Sujith Sankar (ssujith)
Hi, Could someone kindly give information about the following aspects of the use of FDIR? It is about adding of flow classification rule using fdir_add_perfect_filter() 1. For SCTP, what are the mandatory fields to be provided in struct rte_fdir_filter ? Is it enough if protocol and src

[dpdk-dev] Questions on use of multiple NIC interfaces

2014-03-28 Thread Sujith Sankar (ssujith)
Hi all, Could someone answer the following questions about the usage of multiple NIC interfaces with DPDK? 1. If my server has two identical Intel NICs, could I use both with DPDK and its applications? 2. If both the NIC cards could be used with DPDK, could I use them with separate

[dpdk-dev] A query on the latency numbers

2013-10-24 Thread Sujith Sankar (ssujith)
Hi all, In the documentation available on DPDK, I could find the performance numbers in terms of packets per second. Could someone point me to some documentation which gives performance gain of round trip time or packet processing time in terms of time, say, usecs? Also, what is the tool

[dpdk-dev] TCP/IP stack - options

2013-09-19 Thread Sujith Sankar (ssujith)
.000. >[Powering 30 Years of >Innovation]<http://www.windriver.com/announces/wr30/> > >On Sep 17, 2013, at 12:36 AM, Sujith Sankar (ssujith) >mailto:ssujith at cisco.com>> wrote: > >Hi Vincent, > >Sincere thanks to you for the email ! This is very helpful. >I th

[dpdk-dev] TCP/IP stack - options

2013-09-19 Thread Sujith Sankar (ssujith)
Thank you Gil. -Sujith On 17/09/13 6:39 PM, "Gil Hellmann" wrote: >Hi Sujith, > >To add to the respond given by Mr. Jardin, Wind River also has commercial >grade protocol stack that could be used with DPDK libraries and >application, it is part of Wind Rivers' INP (Intelligent Networking

[dpdk-dev] TCP/IP stack - options

2013-09-17 Thread Sujith Sankar (ssujith)
Hi Vincent, Sincere thanks to you for the email ! This is very helpful. I think I'll go with Rump kernel stack to start with, and might think about the other options later. Regards, -Sujith On 17/09/13 2:01 AM, "Vincent JARDIN" wrote: >Hi Sujith, > >NetBSD/Rump is the only open source TCP/IP

[dpdk-dev] TCP/IP stack - options

2013-09-05 Thread Sujith Sankar (ssujith)
Hi all, I'm new to DPDK and this group. In order to try out some of my applications on DPDK, I'd like to know a little bit about the options that are there for protocol processing. Could someone give info about the TCP/IP stacks that could be used with DPDK libraries and applications? Quick