[dpdk-dev] [PATCH 1/7] ether: don't mark input multicast for deprecation
2015-11-05 17:04, Stephen Hemminger: > The number of received multicast frames is useful and already > available in many/most drivers. Therefore don't mark it as > deprecated. There are other useful stats in xstats. The idea of this basic stats structure is to provide only the really mandatory and basic counters. A multicast counter is not so basic and won't be implemented everywhere. This patch won't be applied. We'll need a consensus to definitively remove the deprecated stats.
[dpdk-dev] [PATCH 1/7] ether: don't mark input multicast for deprecation
On Thu, 5 Nov 2015 17:04:33 -0800
Stephen Hemminger wrote:
> The number of received multicast frames is useful and already
> available in many/most drivers. Therefore don't mark it as
> deprecated.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
> lib/librte_ether/rte_ethdev.h| 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 0b0bbcf..3b71c0c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2715,7 +2715,6 @@ ixgbevf_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
> stats->opackets = hw_stats->vfgptc;
> stats->obytes = hw_stats->vfgotc;
> stats->imcasts = hw_stats->vfmprc;
> - /* stats->imcasts should be removed as imcasts is deprecated */
> }
>
> static void
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 48a540d..f653e37 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -204,8 +204,7 @@ struct rte_eth_stats {
> /**< Deprecated; Total of RX packets with bad length. */
> uint64_t ierrors; /**< Total number of erroneous received packets. */
> uint64_t oerrors; /**< Total number of failed transmitted packets. */
> - uint64_t imcasts;
> - /**< Deprecated; Total number of multicast received packets. */
> + uint64_t imcasts; /**< Total number of multicast received packets. */
> uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */
> uint64_t fdirmatch;
> /**< Deprecated; Total number of RX packets matching a filter. */
I am okay with removing imcasts if all the drivers that support provide
the same information in xstats.
[dpdk-dev] [PATCH 1/7] ether: don't mark input multicast for deprecation
The number of received multicast frames is useful and already
available in many/most drivers. Therefore don't mark it as
deprecated.
Signed-off-by: Stephen Hemminger
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
lib/librte_ether/rte_ethdev.h| 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 0b0bbcf..3b71c0c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2715,7 +2715,6 @@ ixgbevf_dev_stats_get(struct rte_eth_dev *dev, struct
rte_eth_stats *stats)
stats->opackets = hw_stats->vfgptc;
stats->obytes = hw_stats->vfgotc;
stats->imcasts = hw_stats->vfmprc;
- /* stats->imcasts should be removed as imcasts is deprecated */
}
static void
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 48a540d..f653e37 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -204,8 +204,7 @@ struct rte_eth_stats {
/**< Deprecated; Total of RX packets with bad length. */
uint64_t ierrors; /**< Total number of erroneous received packets. */
uint64_t oerrors; /**< Total number of failed transmitted packets. */
- uint64_t imcasts;
- /**< Deprecated; Total number of multicast received packets. */
+ uint64_t imcasts; /**< Total number of multicast received packets. */
uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */
uint64_t fdirmatch;
/**< Deprecated; Total number of RX packets matching a filter. */
--
2.1.4
