Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
On 2/8/2018 2:38 PM, Thomas Monjalon wrote:
> 08/02/2018 15:35, Ferruh Yigit:
>> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
>>> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
Nor upstream kernel nor MLNX_OFED support such filter.
Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
Cc: nelio.laranje...@6wind.com
Signed-off-by: Shahaf Shuler
>>>
>>> Acked-by: Nelio Laranjeiro
>>
>> Applied to dpdk-next-net/master, thanks.
>
> Have you applied the v1 or v2?
v2 applied, but I reply to v1 by mistake.
Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
08/02/2018 15:35, Ferruh Yigit:
> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
> > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
> >> Nor upstream kernel nor MLNX_OFED support such filter.
> >>
> >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
> >> Cc: nelio.laranje...@6wind.com
> >>
> >> Signed-off-by: Shahaf Shuler
> >
> > Acked-by: Nelio Laranjeiro
>
> Applied to dpdk-next-net/master, thanks.
Have you applied the v1 or v2?
Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
>> Nor upstream kernel nor MLNX_OFED support such filter.
>>
>> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
>> Cc: nelio.laranje...@6wind.com
>>
>> Signed-off-by: Shahaf Shuler
>
> Acked-by: Nelio Laranjeiro
Applied to dpdk-next-net/master, thanks.
Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
> Nor upstream kernel nor MLNX_OFED support such filter.
>
> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
> Cc: nelio.laranje...@6wind.com
>
> Signed-off-by: Shahaf Shuler
> ---
> doc/guides/rel_notes/release_18_02.rst | 1 -
> drivers/net/mlx5/mlx5_flow.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index 32067969f..0d4630335 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -94,7 +94,6 @@ New Features
>* Improved multi-segment packet performance.
>* Changed driver name to use the PCI address to be compatible with
> OVS-DPDK APIs.
>* Extended statistics for physical port packet/byte counters.
> - * Supported IPv4 time-to-live filter.
>* Converted to the new offloads API.
>* Supported device removal check operation.
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 822705060..f88ece123 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
> .dst_addr = -1,
> .type_of_service = -1,
> .next_proto_id = -1,
> - .time_to_live = -1,
> },
> },
> .default_mask = &rte_flow_item_ipv4_mask,
> --
> 2.12.0
Acked-by: Nelio Laranjeiro
--
Nélio Laranjeiro
6WIND
