[dpdk-dev] [PATCH] eal: clear errno before calling strtoull() to parse base_virtaddr

Hi Aaron, It seems that Pablo De Lara has beat you to it by a few minutes :-) Are there any other places this could potentially happen? > Must reset errno to zero before calling strtoull(), else on success it could > be > any arbitrary value from past errors. > > Signed-off-by: Aaron Campbell

[dpdk-dev] [PATCH] eal: clear errno before calling strtoull() to parse base_virtaddr

Yes, that was extremely bizarre. I didn?t check the whole project, but at least eal_parse_socket_mem() in the same file was already correct. Pablo you can add me to Acked-by, obviously. :-) -Aaron On Jun 19, 2014, at 12:46 PM, Burakov, Anatoly wrote: > Hi Aaron, > > It seems that Pablo

[dpdk-dev] [PATCH] eal: clear errno before calling strtoull() to parse base_virtaddr

Must reset errno to zero before calling strtoull(), else on success it could be any arbitrary value from past errors. Signed-off-by: Aaron Campbell --- lib/librte_eal/linuxapp/eal/eal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal.c