[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-20 Thread Thomas Monjalon
2016-07-20 07:03, Liang, Cunming: >Probably a clean way is not to handle device external interrupt event in > EAL >interrupt thread (intr mb may have some problem). The EAL interrupt thread > is >only used to postpone the delay execution or other background interrupt >(e.g.

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-20 Thread Liang, Cunming
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 20, 2016 4:42 PM > To: Liang, Cunming > Cc: Yong Wang ; dev at dpdk.org; > david.marchand at 6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal:

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-20 Thread Liang, Cunming
Hi Yong, > -Original Message- > From: Yong Wang [mailto:yongwang at vmware.com] > Sent: Wednesday, July 20, 2016 5:59 AM > To: Thomas Monjalon > Cc: dev at dpdk.org; Liang, Cunming ; > david.marchand at 6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-19 Thread Yong Wang
> On Jul 18, 2016, at 2:21 AM, Thomas Monjalon > wrote: > > Hi Yong, > > I think the interrupt management should be simpler. > If you want to invest some time to rework this API, you > are very welcome. > > > 2016-07-18 14:19, Liang, Cunming: >> Hi Yong, >> >> rte_intr_dp_is_en() returns

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-18 Thread Liang, Cunming
Hi Yong, rte_intr_dp_is_en() returns true when rte_intr_efd_enable() (the way to enable data-path interrupt) sets a number of event fds. In this case, "intr_conf.rxq=1" configuration causes "nb_efd=1". The value comes from RTE_MIN($nb_efd, 1) from data-path, but not from link event. Per link

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-18 Thread Thomas Monjalon
Hi Yong, I think the interrupt management should be simpler. If you want to invest some time to rework this API, you are very welcome. 2016-07-18 14:19, Liang, Cunming: > Hi Yong, > > rte_intr_dp_is_en() returns true when rte_intr_efd_enable() (the way to > enable data-path interrupt) sets a

[dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check

2016-07-14 Thread Yong Wang
When binding a device to igb_uio with intr_conf.rxq set to 1, nb_efd is 1 (for link event) but rte_intr_dp_is_en() will still return true. rte_intr_dp_is_en() should also consider intr_handle type in addition to nb_efd. Signed-off-by: Yong Wang --- lib/librte_eal/linuxapp/eal/eal_interrupts.c |