[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-31 Thread Thomas Monjalon
> > If the provided configuration does not call for RSS, then RSS is > > explicitly disabled. Without this change, the device continues to > > operate under the previous RSS configuration. > > > > Fixes: 57033cdf8fdc ("fm10k: add PF RSS") > > > > Signed-off-by: Michael Frasca > Acked-by : Jing

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-31 Thread Thomas Monjalon
Please, anyone to confirm that the patch is valid and must be applied? This discussion shows some doubts. 2016-03-24 13:35, Michael Frasca: > Jing, > > Thanks for your assistance. The experiment that you have built should allow > you > to observe the bug. In [5], I would expect that queue 0

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-31 Thread Chen, Jing D
; Chen, Jing D > > Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during > device initialization > > Please, anyone to confirm that the patch is valid and must be applied? > This discussion shows some doubts. > > > 2016-03-24 13:35, Michael Frasca: &g

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-24 Thread Michael Frasca
Jing, Thanks for your assistance. The experiment that you have built should allow you to observe the bug. In [5], I would expect that queue 0 receives roughly 1/4 of the packets that you sending, assuming the input packets have varied IP addresses. Can you measure what % of packets are actually

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-24 Thread Chen, Jing D
Hi, Frasca, > -Original Message- > From: Michael Frasca [mailto:michael.frasca at oracle.com] > Sent: Wednesday, March 23, 2016 9:43 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [PATCH] fm10k: conditionally disable RSS during device > initialization > > Hi Jing, > > I

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-23 Thread Michael Frasca
Hi Jing, I ran into this issue while trying to run experiments with different RSS configurations (no RSS being one cases). It is not clear to me that setting this register to zero is the best way to disable RSS. After digging further, I have a theory that I'm having this issues because I've only

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-23 Thread Chen, Jing D
Hi, > -Original Message- > From: Michael Frasca [mailto:michael.frasca at oracle.com] > Sent: Wednesday, March 23, 2016 12:58 AM > To: Chen, Jing D > Cc: dev at dpdk.org; Michael Frasca > Subject: [PATCH] fm10k: conditionally disable RSS during device initialization > > If the provided

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-22 Thread Michael Frasca
If the provided configuration does not call for RSS, then RSS is explicitly disabled. Without this change, the device continues to operate under the previous RSS configuration. Fixes: 57033cdf8fdc ("fm10k: add PF RSS") Signed-off-by: Michael Frasca --- drivers/net/fm10k/fm10k_ethdev.c | 4 +++-