[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-05 Thread Olivier Matz
Hi David, On 10/04/2016 10:28 AM, David Marchand wrote: > On Mon, Oct 3, 2016 at 6:27 PM, Wiles, Keith wrote: >>> On Oct 3, 2016, at 10:37 AM, Olivier Matz wrote: >>> What makes you feel it's easier to add a log level instead of adding a >>> new RTE_LOG_DP() function? >> >> It seems to me the

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-05 Thread Olivier Matz
Hi David, On 10/04/2016 10:26 AM, David Marchand wrote: > On Fri, Sep 16, 2016 at 9:43 AM, Olivier Matz > wrote: >> Today, all logs whose level is lower than INFO are dropped at >> compile-time. This prevents from enabling debug logs at runtime using >> --log-level=8. >> >> The rationale was to

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-04 Thread David Marchand
On Mon, Oct 3, 2016 at 6:27 PM, Wiles, Keith wrote: >> On Oct 3, 2016, at 10:37 AM, Olivier Matz wrote: >> What makes you feel it's easier to add a log level instead of adding a >> new RTE_LOG_DP() function? > > It seems to me the log levels are for displaying logs at different levels > adding

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-04 Thread David Marchand
On Fri, Sep 16, 2016 at 9:43 AM, Olivier Matz wrote: > Today, all logs whose level is lower than INFO are dropped at > compile-time. This prevents from enabling debug logs at runtime using > --log-level=8. > > The rationale was to remove debug logs from the data path at > compile-time, avoiding a

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-03 Thread Olivier Matz
On 10/03/2016 05:27 PM, Wiles, Keith wrote: > > Regards, > Keith > >> On Oct 3, 2016, at 10:02 AM, Olivier Matz wrote: >> >> Hi Keith, >> >> On 09/30/2016 05:48 PM, Wiles, Keith wrote: On Sep 30, 2016, at 4:33 AM, Thomas Monjalon >>> 6wind.com> wrote: 2016-09-16 09:43, Olivier

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-03 Thread Olivier Matz
Hi Keith, On 09/30/2016 05:48 PM, Wiles, Keith wrote: >> On Sep 30, 2016, at 4:33 AM, Thomas Monjalon >> wrote: >> >> 2016-09-16 09:43, Olivier Matz: >>> Today, all logs whose level is lower than INFO are dropped at >>> compile-time. This prevents from enabling debug logs at runtime using >>>

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-03 Thread Wiles, Keith
Regards, Keith > On Oct 3, 2016, at 10:37 AM, Olivier Matz wrote: > > > > On 10/03/2016 05:27 PM, Wiles, Keith wrote: >> >> Regards, >> Keith >> >>> On Oct 3, 2016, at 10:02 AM, Olivier Matz wrote: >>> >>> Hi Keith, >>> >>> On 09/30/2016 05:48 PM, Wiles, Keith wrote: > On Sep 30,

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-03 Thread Wiles, Keith
Regards, Keith > On Oct 3, 2016, at 10:02 AM, Olivier Matz wrote: > > Hi Keith, > > On 09/30/2016 05:48 PM, Wiles, Keith wrote: >>> On Sep 30, 2016, at 4:33 AM, Thomas Monjalon >>> wrote: >>> >>> 2016-09-16 09:43, Olivier Matz: Today, all logs whose level is lower than INFO are

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-09-16 Thread Olivier Matz
Today, all logs whose level is lower than INFO are dropped at compile-time. This prevents from enabling debug logs at runtime using --log-level=8. The rationale was to remove debug logs from the data path at compile-time, avoiding a test at run-time. This patch changes the behavior of RTE_LOG()