[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-03-09 Thread Olivier MATZ
Hi Vadim, On 03/07/2015 12:24 AM, Vadim Suraev wrote: > Hi, Olivier, > I realized that if local cache for the mempool is enabled and greater > than 0, > if, say, the mempool size is X and local cache length is Y (and it is > not empty,Y>0) > an attempt to allocate a bulk, whose size is greater tha

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-03-07 Thread Vadim Suraev
Hi, Olivier, I realized that if local cache for the mempool is enabled and greater than 0, if, say, the mempool size is X and local cache length is Y (and it is not empty,Y>0) an attempt to allocate a bulk, whose size is greater than local cache size (max) and greater than X-Y (which is the number

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-03-04 Thread Olivier MATZ
Hi Vadim, On 02/27/2015 06:09 PM, Vadim Suraev wrote: > >Indeed, this function looks useful, and I also have a work in progress > >on this topic, but currently it is not well tested. > I'm sorry, I didn't know. I'll not interfere with my patch)) That not what I wanted to say :) You are very we

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Vadim Suraev
Hi, Olivier, Hi Konstantin, >Indeed, this function looks useful, and I also have a work in progress >on this topic, but currently it is not well tested. I'm sorry, I didn't know. I'll not interfere with my patch)) >About the inlining, I have no objection now, although Stephen may be >right. I thi

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Olivier MATZ
Hi Vadim, Hi Konstantin, On 02/27/2015 01:18 PM, Vadim Suraev wrote: > Hi, Konstantin, > >> Seems really useful. Indeed, this function looks useful, and I also have a work in progress on this topic, but currently it is not well tested. As we are on the mbuf subject, for 2.1, I would like to dis

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Vadim Suraev
6, 2015 11:15 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing > optimization > > > > From: "vadim.suraev at gmail.com" > > > > new function - rte_pktmbuf_free_bulk makes freeing long > > scat

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Ananyev, Konstantin
> From: Vadim Suraev [mailto:vadim.suraev at gmail.com] > Sent: Friday, February 27, 2015 12:19 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing > optimization > > Hi, Konstantin, > >Seems

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Ananyev, Konstantin
Hi Vadim, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of vadim.suraev at > gmail.com > Sent: Thursday, February 26, 2015 11:15 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization >

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread vadim.sur...@gmail.com
From: "vadim.suraev at gmail.com" new function - rte_pktmbuf_free_bulk makes freeing long scattered (chained) pktmbufs belonging to the same pool more optimal using rte_mempool_put_bulk rather than calling rte_mempool_put for each segment. Inlike rte_pktmbuf_free, which calls rte_pktmbuf_free_s

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-26 Thread Stephen Hemminger
On Fri, 27 Feb 2015 01:15:06 +0200 "vadim.suraev at gmail.com" wrote: > +static inline void __attribute__((always_inline)) > +rte_pktmbuf_free_bulk(struct rte_mbuf *head) Quit with the inlining. Inlining all the time isn't faster it just increase the code bloat and causes i-cache misses. > +{ >