[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-10 Thread Yuanhan Liu
On Wed, Dec 09, 2015 at 04:14:01PM +, Iremonger, Bernard wrote: > Hi John, > > > > 2015-12-09 14:50, Mcnamara, John: > > > Also, as a general note, not just to this document/patch. > > > > > > I don't think the "user at target:~$" prefixes used in some DPDK Doc > > > commandlines is useful. >

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Iremonger, Bernard
Hi John, > 2015-12-09 14:50, Mcnamara, John: > > Also, as a general note, not just to this document/patch. > > > > I don't think the "user at target:~$" prefixes used in some DPDK Doc > > commandlines is useful. > > > > It prevents a straight copy and paste for testing, it makes the > > literal b

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Iremonger, Bernard
Hi John, > Hi Bernard, > > Thanks for that. One comment (in several places): > > > > .. code-block:: console > > > > -user at target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir > /mnt/huge -- -p 0x1 --dev-basename usvhost > > +user at target:~$ ./build/app/vhost-swit

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Thomas Monjalon
2015-12-09 14:50, Mcnamara, John: > Also, as a general note, not just to this document/patch. > > I don't think the "user at target:~$" prefixes used in some DPDK > Doc commandlines is useful. > > It prevents a straight copy and paste for testing, it makes the > literal block lines longer than th

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Wednesday, December 9, 2015 12:36 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application > guide > > correct

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Wednesday, December 9, 2015 12:36 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application > guide > > correct

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Xie, Huawei
On 12/9/2015 8:36 PM, Iremonger, Bernard wrote: > correct sample console commands > > Fixes: d0dff9ba445e ("doc: sample application user guide" > Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") > Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") > Signed-off-by: Bernard Iremonger

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Bernard Iremonger
correct sample console commands Fixes: d0dff9ba445e ("doc: sample application user guide" Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") Signed-off-by: Bernard Iremonger --- doc/guides/sample_app_ug/vhost.rst | 40 +