[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-18 Thread Remy Horton
On 17/11/2016 17:42, Qiming Yang wrote: > This patch added API for 'rte_eth_dev_fwver_get' > > void rte_eth_dev_fwver_get(uint8_t port_id, > char *fw_version, int fw_length); Suggest description such as: This patch adds ethdev API for fetching firmware version. Also see Thomas's comments.

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-18 Thread Yang, Qiming
Yes, that's my fault. I have set their statuses to 'suspended' Qiming -Original Message- From: Horton, Remy Sent: Friday, November 18, 2016 9:10 AM To: Yang, Qiming ; dev at dpdk.org Cc: Wu, Jingjing ; Chen, Jing D Subject: Re: [PATCH 1/5] ethdev: add firmware version get On

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-18 Thread Yang, Qiming
Hi, Thomas -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, November 17, 2016 9:37 PM To: Yang, Qiming Cc: dev at dpdk.org; Horton, Remy ; Wu, Jingjing ; Chen, Jing D Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get 2016

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-17 Thread Qiming Yang
This patch added API for 'rte_eth_dev_fwver_get' void rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int fw_length); Signed-off-by: Qiming Yang --- lib/librte_ether/rte_ethdev.c | 12 lib/librte_ether/rte_ethdev.h | 18 ++

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-17 Thread Thomas Monjalon
2016-11-17 17:42, Qiming Yang: > This patch added API for 'rte_eth_dev_fwver_get' > > void rte_eth_dev_fwver_get(uint8_t port_id, > char *fw_version, int fw_length); Copying some code here doesn't help really help. Could you describe what we can expect in this string? How can we compare this