[dpdk-dev] [PATCH 2/2] examples/ip_pipeline: modify source port default parameter

[Thomas Monjalon]

> > The default value of ``file_name`` parameter of the source port structure is
> > changed from ``NULL`` to ``./config/packets.pcap``.
> > 
> > Signed-off-by: Jasvinder Singh 
> 
> Acked-by: Cristian Dumitrescu 

Series applied, thanks

[dpdk-dev] [PATCH 2/2] examples/ip_pipeline: modify source port default parameter

[Dumitrescu, Cristian]

> -Original Message-
> From: Singh, Jasvinder
> Sent: Tuesday, August 9, 2016 9:31 AM
> To: dev at dpdk.org
> Cc: Dumitrescu, Cristian 
> Subject: [PATCH 2/2] examples/ip_pipeline: modify source port default
> parameter
> 
> The default value of ``file_name`` parameter of the source port structure is
> changed from ``NULL`` to ``./config/packets.pcap``.
> 
> Signed-off-by: Jasvinder Singh 
> ---
>  examples/ip_pipeline/app.h  | 4 ++--
>  examples/ip_pipeline/config_parse.c | 6 +-
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 

Acked-by: Cristian Dumitrescu 

[dpdk-dev] [PATCH 2/2] examples/ip_pipeline: modify source port default parameter

[Jasvinder Singh]

The default value of ``file_name`` parameter of the source port structure is
changed from ``NULL`` to ``./config/packets.pcap``.

Signed-off-by: Jasvinder Singh 
---
 examples/ip_pipeline/app.h  | 4 ++--
 examples/ip_pipeline/config_parse.c | 6 +-
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h
index 6a6fdd9..4fdf0d9 100644
--- a/examples/ip_pipeline/app.h
+++ b/examples/ip_pipeline/app.h
@@ -182,14 +182,14 @@ struct app_pktq_source_params {
uint32_t parsed;
uint32_t mempool_id; /* Position in the app->mempool_params array */
uint32_t burst;
-   char *file_name; /* Full path of PCAP file to be copied to mbufs */
+   const char *file_name; /* Full path of PCAP file to be copied to mbufs 
*/
uint32_t n_bytes_per_pkt;
 };

 struct app_pktq_sink_params {
char *name;
uint8_t parsed;
-   char *file_name; /* Full path of PCAP file to be copied to mbufs */
+   const char *file_name; /* Full path of PCAP file to be copied to mbufs 
*/
uint32_t n_pkts_to_dump;
 };

diff --git a/examples/ip_pipeline/config_parse.c 
b/examples/ip_pipeline/config_parse.c
index 8fe8157..48c9923 100644
--- a/examples/ip_pipeline/config_parse.c
+++ b/examples/ip_pipeline/config_parse.c
@@ -207,7 +207,7 @@ struct app_pktq_source_params default_source_params = {
.parsed = 0,
.mempool_id = 0,
.burst = 32,
-   .file_name = NULL,
+   .file_name = "./config/packets.pcap",
.n_bytes_per_pkt = 0,
 };

@@ -3083,10 +3083,6 @@ app_config_init(struct app_params *app)

memcpy(app, _params_default, sizeof(struct app_params));

-   /* configure default_source_params */
-   default_source_params.file_name = strdup("./config/packets.pcap");
-   PARSE_ERROR_MALLOC(default_source_params.file_name != NULL);
-
for (i = 0; i < RTE_DIM(app->mempool_params); i++)
memcpy(>mempool_params[i],
_params_default,
-- 
2.5.5