[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-27 Thread Rahul Lakkireddy
On Tue, May 26, 2015 at 22:49:08 -0700, Thomas Monjalon wrote: > 2015-05-23 11:23, Rahul Lakkireddy: > > We need to rebase anyway since PMDs now seem to have moved to > > drivers/net directory. > > Yes. And the subdirectory should probably be renamed base/. Yes, we will do this. > > It would

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-27 Thread Rahul Lakkireddy
On Tue, May 26, 2015 at 10:24:37 -0700, Stephen Hemminger wrote: > On Tue, 26 May 2015 22:32:07 +0530 > Rahul Lakkireddy wrote: > > > On Sat, May 23, 2015 at 11:27:56 +0530, Rahul Lakkireddy wrote: > > > On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > > > > On Fri, 22 May 2015

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-26 Thread Thomas Monjalon
2015-05-23 11:23, Rahul Lakkireddy: > We need to rebase anyway since PMDs now seem to have moved to > drivers/net directory. Yes. And the subdirectory should probably be renamed base/. It would be nice to introduce the PMD features in separate patches as it was done for fm10k. Thanks

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-26 Thread Rahul Lakkireddy
On Sat, May 23, 2015 at 11:27:56 +0530, Rahul Lakkireddy wrote: > On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > > On Fri, 22 May 2015 18:54:20 +0530 > > Rahul Lakkireddy wrote: > > > > > +#define pr_err(y, args...) dev_err(0, y, ##args) > > > +#define pr_warn(y, args...)

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-26 Thread Stephen Hemminger
On Tue, 26 May 2015 22:32:07 +0530 Rahul Lakkireddy wrote: > On Sat, May 23, 2015 at 11:27:56 +0530, Rahul Lakkireddy wrote: > > On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > > > On Fri, 22 May 2015 18:54:20 +0530 > > > Rahul Lakkireddy wrote: > > > > > > > +#define

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-23 Thread Rahul Lakkireddy
On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > On Fri, 22 May 2015 18:54:20 +0530 > Rahul Lakkireddy wrote: > > > +#define pr_err(y, args...) dev_err(0, y, ##args) > > +#define pr_warn(y, args...) dev_warn(0, y, ##args) > > +#define pr_info(y, args...) dev_info(0, y, ##args)

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-23 Thread Rahul Lakkireddy
On Fri, May 22, 2015 at 09:43:20 -0700, Stephen Hemminger wrote: > On Fri, 22 May 2015 18:54:20 +0530 > Rahul Lakkireddy wrote: > > > +/** > > + * fls - find last (most-significant) bit set > > + * @x: the word to search > > + * > > + * This is defined the same way as ffs. > > + * Note fls(0) =

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-22 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver for DPDK under lib/librte_pmd_cxgbe directory. This patch: 1. Adds the Makefile to compile cxgbe pmd. 2. Registers and initializes the cxgbe pmd driver. 3. Implements the necessary eth_dev_ops. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi ---

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-22 Thread Stephen Hemminger
On Fri, 22 May 2015 18:54:20 +0530 Rahul Lakkireddy wrote: > +static int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev, > + __rte_unused int wait_to_complete) > +{ > + struct port_info *pi = (struct port_info *)(eth_dev->data->dev_private); > + struct

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-22 Thread Stephen Hemminger
On Fri, 22 May 2015 18:54:20 +0530 Rahul Lakkireddy wrote: > +/** > + * fls - find last (most-significant) bit set > + * @x: the word to search > + * > + * This is defined the same way as ffs. > + * Note fls(0) = 0, fls(1) = 1, fls(0x8000) = 32. > + */ > +static inline int fls(int x) Isn't

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-22 Thread Stephen Hemminger
On Fri, 22 May 2015 18:54:20 +0530 Rahul Lakkireddy wrote: > +#define pr_err(y, args...) dev_err(0, y, ##args) > +#define pr_warn(y, args...) dev_warn(0, y, ##args) > +#define pr_info(y, args...) dev_info(0, y, ##args) > +#define BUG() pr_err("BUG at %s:%d", __func__, __LINE__) > + > +#define