Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2017-01-04 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, January 03, 2017 7:41 AM > > On 12/31/2016 7:41 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Friday, December 23, 2016 7:42 AM > >> > >> On 12/3/2016 9:11 AM, Rasesh Mody wrote: > >>

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2017-01-03 Thread Ferruh Yigit
On 12/31/2016 7:41 AM, Mody, Rasesh wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Friday, December 23, 2016 7:42 AM >> >> On 12/3/2016 9:11 AM, Rasesh Mody wrote: >>> This patch consists of semantic/formatting changes. It also includes >>> comment additions. >> >> As far as

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2016-12-30 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:42 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > This patch consists of semantic/formatting changes. It also includes > > comment additions. > > As far as I can see majority of the changes are formattin

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2016-12-23 Thread Ferruh Yigit
On 12/3/2016 9:11 AM, Rasesh Mody wrote: > This patch consists of semantic/formatting changes. It also includes > comment additions. As far as I can see majority of the changes are formatting, but not all. Functional changes are hard to detect in this patch, what do you think separating formattin

[dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2016-12-03 Thread Rasesh Mody
This patch consists of semantic/formatting changes. It also includes comment additions. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/common_hsi.h | 5 +- drivers/net/qede/base/ecore_dev.c| 53 --- drivers/net/qede/base/ecore_hsi_common.h | 14 +- drivers/net/qede/ba