[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 Thread Thomas Monjalon
2015-02-25 09:52, Liang, Cunming: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-02-25 00:57, Liang, Cunming: > > > From: John W. Linville [mailto:linville at tuxdriver.com] > > > > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote: > > > > > 2015-02-12 17:08,

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 Thread Liang, Cunming
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 25, 2015 4:46 PM > To: Liang, Cunming > Cc: John W. Linville; dev at dpdk.org; John Linville > Subject: Re: [dpdk-dev] [PATCH v1] afpacket: fix critical

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 Thread Thomas Monjalon
2015-02-25 00:57, Liang, Cunming: > From: John W. Linville [mailto:linville at tuxdriver.com] > > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote: > > > 2015-02-12 17:08, Cunming Liang: > > > > --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c > > > > +++ b/lib/librte_pmd_af_packet

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 Thread Liang, Cunming
> -Original Message- > From: John W. Linville [mailto:linville at tuxdriver.com] > Sent: Saturday, February 21, 2015 2:39 AM > To: Thomas Monjalon > Cc: Liang, Cunming; dev at dpdk.org; John Linville > Subject: Re: [dpdk-dev] [PATCH v1] afpacket: fix critical issue repo

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-20 Thread John W. Linville
On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote: > Hi Cunming, > > You would have more chance to have a review by CC'ing John. > I checked your patch and have a comment below. > > 2015-02-12 17:08, Cunming Liang: > > Klocwork report 'req' might be used uninitialized. > > In some c

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-20 Thread Thomas Monjalon
Hi Cunming, You would have more chance to have a review by CC'ing John. I checked your patch and have a comment below. 2015-02-12 17:08, Cunming Liang: > Klocwork report 'req' might be used uninitialized. > In some cases it can 'goto error' when '*internals' not been set. > The result is unexpect

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-12 Thread Cunming Liang
Klocwork report 'req' might be used uninitialized. In some cases it can 'goto error' when '*internals' not been set. The result is unexpected checking the value of '*internals'. Signed-off-by: Cunming Liang --- lib/librte_pmd_af_packet/rte_eth_af_packet.c | 4 +++- 1 file changed, 3 insertions(+