[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-30 Thread Thomas Monjalon
2016-03-24 08:54, Panu Matilainen: > --- a/drivers/net/e1000/Makefile > +++ b/drivers/net/e1000/Makefile > @@ -54,6 +54,9 @@ else > # > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(shell test $(GCC_VERSION) -ge 60 &&

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-30 Thread Aaron Conole
Thomas Monjalon writes: > 2016-03-24 08:54, Panu Matilainen: >> --- a/drivers/net/e1000/Makefile >> +++ b/drivers/net/e1000/Makefile >> @@ -54,6 +54,9 @@ else >> # >> CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter >> CFLAGS_BASE_DRIVER += -Wno-unused-variable >> +ifeq

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-24 Thread Panu Matilainen
On 03/24/2016 02:35 AM, Lu, Wenzhuo wrote: > Hi Thomas, Aaron, >>> Wenzhuo, do you agree to fix the base driver here? > Honestly I find the logic has some problem and maybe more changes needed. I'm > talking with our kernel driver contactors to make sure they have no concern > about my idea. >

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-24 Thread Lu, Wenzhuo
Hi Thomas, Aaron, > > Wenzhuo, do you agree to fix the base driver here? Honestly I find the logic has some problem and maybe more changes needed. I'm talking with our kernel driver contactors to make sure they have no concern about my idea. And Aaron, do we really need to fix this code? For I

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-23 Thread Thomas Monjalon
fixing Wenzhuo email address... 2016-03-23 11:38, Thomas Monjalon: > 2016-03-22 17:37, Aaron Conole: > > The register read/write mphy functions have misleading whitespace around > > the locked check. This cleanup merely preserves the existing functionality > > while improving the ready check. > >

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-23 Thread Thomas Monjalon
2016-03-22 17:37, Aaron Conole: > The register read/write mphy functions have misleading whitespace around > the locked check. This cleanup merely preserves the existing functionality > while improving the ready check. > > Fixes commit 38db3f7f50bd ("e1000: update base driver") > >

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-22 Thread Aaron Conole
The register read/write mphy functions have misleading whitespace around the locked check. This cleanup merely preserves the existing functionality while improving the ready check. Fixes commit 38db3f7f50bd ("e1000: update base driver") Signed-off-by: Aaron Conole --- v2: * Changed from