[dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes

2015-12-22 Thread Peter Xu
On Tue, Dec 22, 2015 at 03:13:49PM +0800, Yuanhan Liu wrote: > On Tue, Dec 22, 2015 at 02:55:52PM +0800, Peter Xu wrote: > > On Thu, Dec 17, 2015 at 11:11:58AM +0800, Yuanhan Liu wrote: > > > +static inline void __attribute__((always_inline)) > > > +vhost_log_used_vring(struct virtio_net *dev, stru

[dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes

2015-12-22 Thread Peter Xu
On Tue, Dec 22, 2015 at 07:07:25AM +, Xie, Huawei wrote: > On 12/22/2015 2:56 PM, Peter Xu wrote: > > Got a question here: > > > > I see that we are logging down changes when we are marking > > used_vring. Do we need to log down buffer copy in rte_memcpy() too? > > I am not sure whether I under

[dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes

2015-12-22 Thread Yuanhan Liu
On Tue, Dec 22, 2015 at 02:55:52PM +0800, Peter Xu wrote: > On Thu, Dec 17, 2015 at 11:11:58AM +0800, Yuanhan Liu wrote: > > +static inline void __attribute__((always_inline)) > > +vhost_log_used_vring(struct virtio_net *dev, struct vhost_virtqueue *vq, > > +uint64_t offset, uint64_

[dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes

2015-12-22 Thread Peter Xu
On Thu, Dec 17, 2015 at 11:11:58AM +0800, Yuanhan Liu wrote: > +static inline void __attribute__((always_inline)) > +vhost_log_used_vring(struct virtio_net *dev, struct vhost_virtqueue *vq, > + uint64_t offset, uint64_t len) > +{ One thing optional: I feel it a little bit confusin

[dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes

2015-12-22 Thread Xie, Huawei
On 12/22/2015 2:56 PM, Peter Xu wrote: > On Thu, Dec 17, 2015 at 11:11:58AM +0800, Yuanhan Liu wrote: >> +static inline void __attribute__((always_inline)) >> +vhost_log_used_vring(struct virtio_net *dev, struct vhost_virtqueue *vq, >> + uint64_t offset, uint64_t len) >> +{ [...] >

[dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes

2015-12-17 Thread Yuanhan Liu
Introducing a vhost_log_write() wrapper, vhost_log_used_vring, to log used vring changes. Signed-off-by: Yuanhan Liu Signed-off-by: Victor Kaplansky log_guest_addr + offset; + vhost_log_write(dev, addr, len); +} + /** * This function adds buffers to the virtio devices RX virtqueue. Buffe