[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-14 Thread Yuanhan Liu
On Thu, Oct 13, 2016 at 11:23:44AM +0200, Maxime Coquelin wrote: > I was going to re-run some PVP benchmark with 0% pkt loss, as I had > some strange results last week. > > Problem is that your series no more apply cleanly due to > next-virtio's master branch history rewrite. > Any chance you

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Yuanhan Liu
On Wed, Oct 12, 2016 at 12:22:08PM +, Wang, Zhihong wrote: > > > >> > 3. How many percentage of drop are you seeing? > > > The testing result: > > > size (bytes) improvement (%) > > > 64 3.92 > > > 128 11.51 > > > 256 24.16 > > > 512

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Jianbo Liu
Hi Thomas, On 12 October 2016 at 23:31, Thomas Monjalon wrote: > Sorry guys, you lost me in the discussion. > > Is there some regression only on ARM? > Does it need some work specifically on memcpy for ARM, I don't know if there is common way to improve memcpy on different ARM hardware. Even

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Maxime Coquelin
On 10/13/2016 09:54 AM, Maxime Coquelin wrote: > > > On 10/13/2016 08:02 AM, Wang, Zhihong wrote: >>> > Yes, that's great effort! With your hardwork, we know what the >>> bottleneck >>> > is and how it could be improved. >>> > >>> > However, you don't have to do code refactor (merge two code

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Maxime Coquelin
On 10/13/2016 08:02 AM, Wang, Zhihong wrote: >> > Yes, that's great effort! With your hardwork, we know what the bottleneck >> > is and how it could be improved. >> > >> > However, you don't have to do code refactor (merge two code path to one) >> > to apply those improvements. From what I know,

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, October 13, 2016 1:33 PM > To: Wang, Zhihong > Cc: Jianbo Liu ; Thomas Monjalon > ; Maxime Coquelin > ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5]

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 12, 2016 11:31 PM > To: Wang, Zhihong > Cc: Yuanhan Liu ; Jianbo Liu > ; Maxime Coquelin ; > dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5]

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-12 Thread Thomas Monjalon
Sorry guys, you lost me in the discussion. Is there some regression only on ARM? Does it need some work specifically on memcpy for ARM, or vhost for ARM? Who can work on ARM optimization? More comments below. 2016-10-12 12:22, Wang, Zhihong: > From: Yuanhan Liu [mailto:yuanhan.liu at

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-12 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, October 12, 2016 10:53 AM > To: Wang, Zhihong ; Jianbo Liu linaro.org> > Cc: Maxime Coquelin ; dev at dpdk.org; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-12 Thread Yuanhan Liu
On Thu, Sep 22, 2016 at 01:47:45PM +0800, Jianbo Liu wrote: > On 22 September 2016 at 10:29, Yuanhan Liu > wrote: > > On Wed, Sep 21, 2016 at 08:54:11PM +0800, Jianbo Liu wrote: > >> >> > My setup consists of one host running a guest. > >> >> > The guest generates as much 64bytes packets as

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-10 Thread Jianbo Liu
k.org >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue >> >> On 10 October 2016 at 10:44, Yuanhan Liu >> wrote: >> > On Sun, Oct 09, 2016 at 12:09:07PM +, Wang, Zhihong wrote: >> >> > > > Tested with testpmd, host: txonly, g

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-10 Thread Jianbo Liu
On 10 October 2016 at 10:44, Yuanhan Liu wrote: > On Sun, Oct 09, 2016 at 12:09:07PM +, Wang, Zhihong wrote: >> > > > Tested with testpmd, host: txonly, guest: rxonly >> > > > size (bytes) improvement (%) >> > > > 644.12 >> > > > 128 6 >> > > > 256

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-10 Thread Yuanhan Liu
On Sun, Oct 09, 2016 at 12:09:07PM +, Wang, Zhihong wrote: > > > > Tested with testpmd, host: txonly, guest: rxonly > > > > size (bytes) improvement (%) > > > > 644.12 > > > > 128 6 > > > > 256 2.65 > > > > 512 -1.12

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-10 Thread Wang, Zhihong
> -Original Message- > From: Jianbo Liu [mailto:jianbo.liu at linaro.org] > Sent: Monday, October 10, 2016 2:58 PM > To: Wang, Zhihong > Cc: Yuanhan Liu ; Maxime Coquelin > ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue > &g

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-10 Thread Wang, Zhihong
> -Original Message- > From: Jianbo Liu [mailto:jianbo.liu at linaro.org] > Sent: Monday, October 10, 2016 1:32 PM > To: Yuanhan Liu > Cc: Wang, Zhihong ; Maxime Coquelin > ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue > &g

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-09 Thread Wang, Zhihong
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wang, Zhihong > Sent: Wednesday, September 28, 2016 12:45 AM > To: Yuanhan Liu ; Jianbo Liu > > Cc: Maxime Coquelin ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vh

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-24 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, August 22, 2016 6:35 PM > To: Maxime Coquelin ; Wang, Zhihong > ; yuanhan.liu at linux.intel.com > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vh

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 10:43:36AM +, Wang, Zhihong wrote: > > > I forgot to add that before this series, I think we should first fix the > > > windows > > bug. > > > Else we will need a dedicated fix for the stable branch. > > > > Okay I'll try to fix it, though I can't make any promises at

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Maxime Coquelin
On 08/23/2016 12:43 PM, Wang, Zhihong wrote: > > >> -Original Message- >> From: Wang, Zhihong >> Sent: Tuesday, August 23, 2016 10:31 AM >> To: Maxime Coquelin ; dev at dpdk.org >> Cc: yuanhan.liu at linux.intel.com >> Subject: RE: [PATCH v3 0/5] vhost: optimize enqueue >> >> >> >>>

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Wang, Zhihong
> -Original Message- > From: Wang, Zhihong > Sent: Tuesday, August 23, 2016 10:31 AM > To: Maxime Coquelin ; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: RE: [PATCH v3 0/5] vhost: optimize enqueue > > > > > -Original Message- > > From: Maxime Coquelin

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Wang, Zhihong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Monday, August 22, 2016 6:02 PM > To: Wang, Zhihong ; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: Re: [PATCH v3 0/5] vhost: optimize enqueue > > > On 08/22/2016 10:11 AM,

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-23 Thread Wang, Zhihong
> Subject: Re: [PATCH v3 0/5] vhost: optimize enqueue > > Hi Zhihong, > [...] > > The main optimization techniques are: > > > > 1. Reorder code to reduce CPU pipeline stall cycles. > > > > 2. Batch update the used ring for better efficiency. > > > > 3. Prefetch descriptor to hide cache

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-22 Thread Thomas Monjalon
2016-08-22 12:01, Maxime Coquelin: > I forgot to add that before this series, I think we should first fix the > windows bug. > Else we will need a dedicated fix for the stable branch. This is a funny situation :) If Zhihong had reworked the code without mentioning it is fixing a scenario with

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-22 Thread Maxime Coquelin
On 08/22/2016 10:11 AM, Maxime Coquelin wrote: > Hi Zhihong, > > On 08/19/2016 07:43 AM, Zhihong Wang wrote: > > This patch set optimizes the vhost enqueue function. > > > > It implements the vhost logic from scratch into a single function > > designed > > for high performance and good

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-22 Thread Maxime Coquelin
Hi Zhihong, On 08/19/2016 07:43 AM, Zhihong Wang wrote: > This patch set optimizes the vhost enqueue function. > > It implements the vhost logic from scratch into a single function designed > for high performance and good maintainability, and improves CPU efficiency > significantly by optimizing

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-08-19 Thread Zhihong Wang
This patch set optimizes the vhost enqueue function. It implements the vhost logic from scratch into a single function designed for high performance and good maintainability, and improves CPU efficiency significantly by optimizing cache access, which means: * For fast frontends (eg. DPDK