[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-31 Thread Harish Patil
> >On Wed, 30 Mar 2016 22:16:51 + >Harish Patil wrote: > >> > >> >On Tue, 29 Mar 2016 22:28:20 -0700 >> >Rasesh Mody wrote: >> > >> >> + >> >> +static void qede_print_adapter_info(struct qede_dev *qdev) >> >> +{ >> >> + struct ecore_dev *edev = >edev; >> >> + struct qed_dev_info *info =

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-31 Thread Stephen Hemminger
On Thu, 31 Mar 2016 19:36:55 + Harish Patil wrote: > > > > >On Wed, 30 Mar 2016 22:16:51 + > >Harish Patil wrote: > > > >> > > >> >On Tue, 29 Mar 2016 22:28:20 -0700 > >> >Rasesh Mody wrote: > >> > > >> >> + > >> >> +static void qede_print_adapter_info(struct qede_dev *qdev) > >> >>

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-31 Thread Harish Patil
> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> +static void >> +qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info >>*info) >> +{ >> +rte_memcpy(>dev_info, info, sizeof(*info)); > >Why bother with rte_memcpy here? why not just assignment or memcpy()?

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Harish Patil
> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> +static void >> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev, >> + __rte_unused uint32_t index) >> +{ >> +struct qede_dev *qdev = eth_dev->data->dev_private; >> +struct ecore_dev *edev =

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Harish Patil
> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> + >> +static void qede_print_adapter_info(struct qede_dev *qdev) >> +{ >> +struct ecore_dev *edev = >edev; >> +struct qed_dev_info *info = >dev_info.common; >> +char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; >> + >> +

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2016 22:16:51 + Harish Patil wrote: > > > >On Tue, 29 Mar 2016 22:28:20 -0700 > >Rasesh Mody wrote: > > > >> + > >> +static void qede_print_adapter_info(struct qede_dev *qdev) > >> +{ > >> + struct ecore_dev *edev = >edev; > >> + struct qed_dev_info *info =

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +void qede_config_rx_mode(struct rte_eth_dev *eth_dev) > +{ > + struct qede_dev *qdev = eth_dev->data->dev_private; > + struct ecore_dev *edev = >edev; > + /* TODO: - QED_FILTER_TYPE_UCAST */ > + enum

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > +static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool action) > +{ > + struct ecore_dev *edev = >edev; > + struct qed_update_vport_params params; > + int rc; > + > + /* Proceed only if action actually needs to

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > +static void > +qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info *info) > +{ > + rte_memcpy(>dev_info, info, sizeof(*info)); Why bother with rte_memcpy here? why not just assignment or memcpy()? > + qdev->num_tc

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +static void > +qede_dev_info_get(struct rte_eth_dev *eth_dev, > + struct rte_eth_dev_info *dev_info) > +{ > + struct qede_dev *qdev = eth_dev->data->dev_private; > + struct ecore_dev *edev = >edev; > + > +

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +static void qede_print_adapter_info(struct qede_dev *qdev) > +{ > + struct ecore_dev *edev = >edev; > + struct qed_dev_info *info = >dev_info.common; > + char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; > + > + RTE_LOG(INFO,

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-29 Thread Rasesh Mody
The Qlogic Everest Driver for Ethernet(QEDE) Poll Mode Driver(PMD) is the DPDK specific module for QLogic FastLinQ QL4 25G/40G CNA family of adapters as well as their virtual functions (VF) in SR-IOV context. This patch adds QEDE PMD, which interacts with base driver and initialises the HW.